> -Original Message-
> From: Richardson, Bruce
> Sent: Wednesday, January 22, 2025 7:24 PM
> To: Ye, MingjinX
> Cc: dev@dpdk.org
> Subject: Re: [PATCH 0/3] flexible IPv4 fragment action
>
> On Wed, Jan 22, 2025 at 08:23:07AM +, Mingjin Ye wrote:
> > Support for distributing the fi
> Subject: [PATCH 1/1] test/crypto: additional RSA tests for CNXK PMD
>
> Include additional RSA tests for CNXK PMD. These tests validates RSA
> operations using private key in exponent form.
>
> Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Anoob Joseph
On 2025/1/23 15:59, Thomas Monjalon wrote:
> 23/01/2025 06:48, WanRenyong:
>> On 2025/1/22 21:39, Thomas Monjalon wrote:
+Yunsilicon xsc
+M: WanRenyong
+M: Na Na
+M: Rong Qian
+M: Xiaoxiong Zhang
+M: Dongwei Xu
>>> Looking at how the names are codified in email ad
> Subject: [PATCH] examples/ipsec-secgw: fix cryptodev and eventdev ID
>
> Fixing cryptodev and eventdev ID numbers.
>
> Fixes: 0dbe550a4af5 ("examples/ipsec-secgw: initialize event crypto adapter")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Tejasree Kondoj
Acked-by: Anoob Joseph
On Mon, Jan 20, 2025 at 02:32:49PM +, Bruce Richardson wrote:
> On Mon, Jan 13, 2025 at 08:30:01AM -0800, Stephen Hemminger wrote:
> > On Mon, 13 Jan 2025 08:54:04 +
> > Praveen Shetty wrote:
> >
> > > Heap use after free error is detected in AddressSanitizer while quitting
> > > the test
On Tue, Jan 14, 2025 at 3:32 AM Andre Muezerie
wrote:
>
> As per guidance technical board meeting 2024/04/17. This series
> removes the use of VLAs from code built for Windows for all 3
> toolchains. If there are additional opportunities to convert VLAs
> to regular C arrays please provide the det
> -Original Message-
> From: Mingjin Ye
> Sent: Wednesday, January 22, 2025 4:23 PM
> To: dev@dpdk.org
> Cc: Ye, MingjinX ; Richardson, Bruce
> ; Burakov, Anatoly
>
> Subject: [PATCH 3/3] net/ice: ACL filter support for IPv4 fragment
>
> Enable ACL filter on PF. Add support for FRAG_IPV4
On Thu, Jan 23, 2025 at 12:18 PM Bruce Richardson
wrote:
>
> On Mon, Jan 20, 2025 at 02:32:49PM +, Bruce Richardson wrote:
> > On Mon, Jan 13, 2025 at 08:30:01AM -0800, Stephen Hemminger wrote:
> > > On Mon, 13 Jan 2025 08:54:04 +
> > > Praveen Shetty wrote:
> > >
> > > > Heap use after f
Hello Bruce,
On Wed, Jan 22, 2025 at 4:21 PM Andre Muezerie
wrote:
>
> v2:
> * Updated commit messages to follow standard format.
>
> This patch avoids warnings like the one below emitted by MSVC, and is
> needed to get the code to compile cleanly with MSVC.
>
> ../drivers/common/idpf/idpf_commo
On Thu, Jan 23, 2025 at 01:23:15PM +0100, David Marchand wrote:
> Hello Bruce,
>
> On Wed, Jan 22, 2025 at 4:21 PM Andre Muezerie
> wrote:
> >
> > v2:
> > * Updated commit messages to follow standard format.
> >
> > This patch avoids warnings like the one below emitted by MSVC, and is
> > needed
On Thu, Jan 23, 2025 at 12:58:49PM +0100, David Marchand wrote:
> On Tue, Jan 14, 2025 at 3:32 AM Andre Muezerie
> wrote:
> >
> > As per guidance technical board meeting 2024/04/17. This series
> > removes the use of VLAs from code built for Windows for all 3
> > toolchains. If there are additiona
On Thu, Jan 23, 2025 at 12:43:50PM +0100, David Marchand wrote:
> On Thu, Jan 23, 2025 at 12:18 PM Bruce Richardson
> wrote:
> >
> > On Mon, Jan 20, 2025 at 02:32:49PM +, Bruce Richardson wrote:
> > > On Mon, Jan 13, 2025 at 08:30:01AM -0800, Stephen Hemminger wrote:
> > > > On Mon, 13 Jan 202
On Thu, Jan 23, 2025 at 1:46 PM Bruce Richardson
wrote:
>
> On Thu, Jan 23, 2025 at 01:23:15PM +0100, David Marchand wrote:
> > Hello Bruce,
> >
> > On Wed, Jan 22, 2025 at 4:21 PM Andre Muezerie
> > wrote:
> > >
> > > v2:
> > > * Updated commit messages to follow standard format.
> > >
> > > Th
On Wed, Jan 22, 2025 at 6:10 PM Morten Brørup
wrote:
>
> > From: Andre Muezerie [mailto:andre...@linux.microsoft.com]
> > Sent: Wednesday, 22 January 2025 17.24
> >
> > MSVC supports forcing code to be inlined or forcing code to not be
> > inlined, like other compilers. It does not support the "h
On Tue, Jan 14, 2025 at 5:33 PM Bruce Richardson
wrote:
>
> On Tue, Jan 14, 2025 at 08:21:13AM -0800, Andre Muezerie wrote:
> > Error reported:
> > ../lib/net/net_crc_sse.c:49:17: error: call to undeclared function
> > '_mm_clmulepi64_si128'; ISO C99 and later do not support implicit
> > function
23/01/2025 06:48, WanRenyong:
> On 2025/1/22 21:39, Thomas Monjalon wrote:
> >> +Yunsilicon xsc
> >> +M: WanRenyong
> >> +M: Na Na
> >> +M: Rong Qian
> >> +M: Xiaoxiong Zhang
> >> +M: Dongwei Xu
> > Looking at how the names are codified in email addresses,
> > I feel "Renyong Wan" is the right
> From: Andre Muezerie [mailto:andre...@linux.microsoft.com]
> Sent: Tuesday, 21 January 2025 23.36
>
> It was a common pattern to have "GCC diagnostic ignored" pragmas
> sprinkled over the code and only activate these pragmas for certain
> compilers (gcc and clang). Clang supports GCC's pragma fo
> From: Andre Muezerie [mailto:andre...@linux.microsoft.com]
> Sent: Tuesday, 21 January 2025 23.36
>
> It was a common pattern to have "GCC diagnostic ignored" pragmas
> sprinkled over the code and only activate these pragmas for certain
> compilers (gcc and clang). Clang supports GCC's pragma fo
> From: Andre Muezerie [mailto:andre...@linux.microsoft.com]
> Sent: Tuesday, 21 January 2025 23.36
>
> It was a common pattern to have "GCC diagnostic ignored" pragmas
> sprinkled over the code and only activate these pragmas for certain
> compilers (gcc and clang). Clang supports GCC's pragma fo
On Thu, Jan 23, 2025 at 03:16:40PM +0100, David Marchand wrote:
> Hello Bruce, Thomas,
>
> On Mon, Jan 20, 2025 at 1:00 PM Bruce Richardson
> wrote:
> >
> > Consolidate all Intel HW NIC drivers into a driver/net/intel This
> > matches the layout used for drivers in the kernel, and potentially
>
Hello Bruce, Thomas,
On Mon, Jan 20, 2025 at 1:00 PM Bruce Richardson
wrote:
>
> Consolidate all Intel HW NIC drivers into a driver/net/intel This
> matches the layout used for drivers in the kernel, and potentially
> enabling easier sharing among drivers.
>
> Signed-off-by: Bruce Richardson
-
On Thu, Jan 23, 2025 at 02:03:29PM +0100, David Marchand wrote:
> On Thu, Jan 23, 2025 at 1:46 PM Bruce Richardson
> wrote:
> >
> > On Thu, Jan 23, 2025 at 01:23:15PM +0100, David Marchand wrote:
> > > Hello Bruce,
> > >
> > > On Wed, Jan 22, 2025 at 4:21 PM Andre Muezerie
> > > wrote:
> > > >
>
> -Original Message-
> From: Harman Kalra
> Sent: Thursday, November 14, 2024 3:09 PM
> To: Nithin Kumar Dabilpuram ; Kiran Kumar
> Kokkilagadda ; Sunil Kumar Kori
> ; Satha Koteswara Rao Kottidi
> ; Harman Kalra
> Cc: dev@dpdk.org
> Subject: [EXTERNAL] [PATCH] net/cnxk: toggle link sta
Use function attributes to catch cases where fib table is allocated
but not freed correctly.
Signed-off-by: Stephen Hemminger
---
lib/fib/rte_fib.h | 26 +++---
lib/fib/rte_fib6.h | 24 +---
lib/fib/trie.h | 7 ---
3 files changed, 32 insertions(
Add function attributes to catch cases where rib is allocated
and not freed correctly.
Signed-off-by: Stephen Hemminger
---
lib/rib/rte_rib.h | 24 +---
lib/rib/rte_rib6.h | 24 +---
2 files changed, 26 insertions(+), 22 deletions(-)
diff --git a/lib/rib
Use function attributes to catch cases where hash table is allocated
but not freed correctly.
Signed-off-by: Stephen Hemminger
---
lib/hash/rte_fbk_hash.h | 24 +---
lib/hash/rte_hash.h | 21 +++--
2 files changed, 24 insertions(+), 21 deletions(-)
diff -
This patch series builds on the allocation function attributes
added in 24.11 release. These annotations will allow for compiler
to flag cases where a pointer is allocated with one function
but incorrectly passed to a different free function.
The current code base does this correctly now, but ad
Use function attributes to catch cases where lpm table is allocated
but not freed correctly.
Signed-off-by: Stephen Hemminger
---
lib/lpm/rte_lpm.h | 23 ---
lib/lpm/rte_lpm6.h | 23 ---
2 files changed, 24 insertions(+), 22 deletions(-)
diff --git a/lib
Use function attributes to catch cases where ring is allocated
but not freed correctly.
Signed-off-by: Stephen Hemminger
---
lib/ring/rte_ring.h | 22 --
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/lib/ring/rte_ring.h b/lib/ring/rte_ring.h
index 63a71d5871
Use function attributes to catch cases where acl table is allocated
but not freed correctly.
Signed-off-by: Stephen Hemminger
---
lib/acl/rte_acl.h | 26 +++---
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a/lib/acl/rte_acl.h b/lib/acl/rte_acl.h
index ca75a6f
Use function attributes to catch cases where pipeline is allocated
but not freed correctly.
Signed-off-by: Stephen Hemminger
---
lib/pipeline/rte_port_in_action.h | 55 ---
lib/pipeline/rte_table_action.h | 53 +++--
2 files changed, 56 inser
Use function attributes to catch cases where bitratestats is allocated
but not freed correctly.
Signed-off-by: Stephen Hemminger
---
lib/bitratestats/rte_bitrate.h | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/lib/bitratestats/rte_bitrate.h b/lib/bitr
Use function attributes to catch cases where member table is allocated
but not freed correctly.
Signed-off-by: Stephen Hemminger
---
lib/member/rte_member.h | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/lib/member/rte_member.h b/lib/member/rte_mem
Use function attributes to catch cases where eventdev is allocated
but not freed correctly.
Signed-off-by: Stephen Hemminger
---
lib/eventdev/rte_event_ring.h | 27 ++-
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/lib/eventdev/rte_event_ring.h b/lib/eve
Use function attributes to catch cases where mempool is allocated
but not freed correctly.
Signed-off-by: Stephen Hemminger
Reviewed-by: Morten Brørup
---
lib/mempool/rte_mempool.h | 37 -
1 file changed, 20 insertions(+), 17 deletions(-)
diff --git a/lib/me
Use function attributes to catch cases where reorder table is allocated
but not freed correctly.
Signed-off-by: Stephen Hemminger
Acked-by: Volodymyr Fialko
---
lib/reorder/rte_reorder.h | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/lib/reorder/rt
Use function attributes to catch cases where sched port config
is allocated but not freed correctly.
Signed-off-by: Stephen Hemminger
---
lib/sched/rte_sched.h | 23 +--
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/lib/sched/rte_sched.h b/lib/sched/rte_sche
Use function attributes to catch cases where compressdev is allocated
but not freed correctly.
Signed-off-by: Stephen Hemminger
---
lib/compressdev/rte_comp.h | 28 +++-
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/lib/compressdev/rte_comp.h b/lib/compr
23/01/2025 10:19, WanRenyong:
> On 2025/1/23 15:59, Thomas Monjalon wrote:
> > 23/01/2025 06:48, WanRenyong:
> >> On 2025/1/22 21:39, Thomas Monjalon wrote:
> +Yunsilicon xsc
> +M: WanRenyong
> +M: Na Na
> +M: Rong Qian
> +M: Xiaoxiong Zhang
> +M: Dongwei Xu
> >>>
On Mon, Jan 20, 2025 at 1:00 PM Bruce Richardson
wrote:
>
> The code for reassembling a single, multi-mbuf packet from multiple
> buffers received from the NIC is duplicated across many drivers. Rather
> than having multiple copies of this function, we can create an
> "intel/common" directory to h
With GCC 15, the compiler has changed the default behavior when
initialization is used for aggregate variables. The new default
is to follow the standard (C23) and not initialize everything by
default. This breaks assumptions in some drivers and can be
lead to other bugs.
Use the new zero initiali
On Thu, Jan 23, 2025 at 08:55:29AM +0100, Morten Brørup wrote:
> > From: Andre Muezerie [mailto:andre...@linux.microsoft.com]
> > Sent: Wednesday, 22 January 2025 22.37
> >
> > On Wed, Jan 22, 2025 at 04:12:49PM +, Bruce Richardson wrote:
> > > On Wed, Nov 27, 2024 at 05:53:57PM -0800, Andre M
On Thu, Jan 23, 2025 at 12:43:04PM +, Bruce Richardson wrote:
> On Thu, Jan 23, 2025 at 12:58:49PM +0100, David Marchand wrote:
> > On Tue, Jan 14, 2025 at 3:32 AM Andre Muezerie
> > wrote:
> > >
> > > As per guidance technical board meeting 2024/04/17. This series
> > > removes the use of VLA
Use function attributes to catch cases where telemetry data
is allocated but not freed correctly.
Signed-off-by: Stephen Hemminger
Acked-by: Bruce Richardson
---
lib/telemetry/rte_telemetry.h | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/lib/telemet
23/01/2025 15:35, Bruce Richardson:
> On Thu, Jan 23, 2025 at 03:16:40PM +0100, David Marchand wrote:
> > On the check-git-log.sh update, we will have many warnings with current
> > update.
> >
> > Wrong headline prefix:
> > net/intel/common: add pkt reassembly fn for intel drivers
> > ne
23/01/2025 15:17, David Marchand:
> On Mon, Jan 20, 2025 at 1:00 PM Bruce Richardson
> wrote:
> >
> > The code for reassembling a single, multi-mbuf packet from multiple
> > buffers received from the NIC is duplicated across many drivers. Rather
> > than having multiple copies of this function, we
On Thu, 23 Jan 2025 13:48:25 +0800
"WanRenyong" wrote:
> On 2025/1/22 21:39, Thomas Monjalon wrote:
> >> +Yunsilicon xsc
> >> +M: WanRenyong
> >> +M: Na Na
> >> +M: Rong Qian
> >> +M: Xiaoxiong Zhang
> >> +M: Dongwei Xu
> > Looking at how the names are codified in email addresses,
> > I fe
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Thursday, 23 January 2025 18.21
>
> With GCC 15, the compiler has changed the default behavior when
> initialization is used for aggregate variables. The new default
> is to follow the standard (C23) and not initialize everythin
The new impl don't support re-test, how about add a wrap:
1. rename test_multi_alloc_statistics with do_test_multi_alloc_statistics, and
make it take socket as parameter
2. create a new function test_multi_alloc_statistics {
// prepare a new malloc heap
ret = do_test_multi_alloc_statistics
> -Original Message-
> From: Vamsi Krishna
> Sent: Wednesday, January 15, 2025 6:07 PM
> To: dev@dpdk.org
> Cc: Jerin Jacob ; Vamsi Krishna Attunuru
>
> Subject: [PATCH v0 1/1] common/cnxk: fix DPI mailbox structure
>
> From: Vamsi Attunuru
>
> In the existing DPI mailbox structure, on
Series-acked-by: Chengwen Feng
On 2025/1/17 17:12, Huisong Li wrote:
> I've had some issues when I add the verification of the port id in the
> event callback, which are discussed in another patch series[1]. So this
> series clarify something about RTE_ETH_EVENT_NEW based on the previous
> discu
Improvement of logging to notably use trace point
for driver specific error logging and tracepoint.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc/acc_common.c | 8
drivers/baseband/acc/acc_common.h | 55 ++
drivers/baseband/acc/rte_vrb_pmd.c | 63 +++
Adds trace points for rte_bbdev.
Signed-off-by: Nicolas Chautru
---
lib/bbdev/bbdev_trace.h| 69 ++
lib/bbdev/bbdev_trace_points.c | 27 +
lib/bbdev/meson.build | 6 ++-
lib/bbdev/rte_bbdev.c | 17 +
lib/bbdev/rte_bbd
v2: fix build error.
Hi,
Based on previous discussion improving logging for bbdev and PMD using
notably trace points and internal logging extension.
The trace point impacting real time are not built by default.
This is added at bbdev level and also in the PMD specific
implementation.
Thanks
Nic
Adds internal buffer for more flexible logging.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc/acc_common.h | 22 +++---
drivers/baseband/acc/rte_vrb_pmd.c | 18 +-
2 files changed, 36 insertions(+), 4 deletions(-)
diff --git a/drivers/baseband/acc/acc_
> -Original Message-
> From: Shijith Thotton
> Sent: Wednesday, January 22, 2025 7:13 PM
> To: Naga Harish K, S V ; dev@dpdk.org
> Cc: Pavan Nikhilesh Bhagavatula ; Pathak,
> Pravin ; Hemant Agrawal
> ; Sachin Saxena ;
> Mattias R_nnblom ; Jerin Jacob
> ; Liang Ma ; Mccarthy, Peter
> ; V
LGTM
Acked-by: Chengwen Feng
On 2025/1/21 21:40, Morten Brørup wrote:
> When putting an mbuf back into its mempool, there are certain requirements
> to the mbuf. Specifically, some of its fields must be initialized.
>
> These requirements are in fact invariants about free mbufs, held in
> mempoo
Added TSO(Transmit Segmentation offload) support for axgbe PMD.
Signed-off-by: Jesna K E
---
doc/guides/nics/features/axgbe.ini | 1 +
drivers/net/axgbe/axgbe_common.h | 13 ++
drivers/net/axgbe/axgbe_dev.c | 12 ++
drivers/net/axgbe/axgbe_ethdev.c | 2 +
drivers/net/axgbe/axgbe_e
Acked-by: Chengwen Feng
On 2025/1/20 20:21, Ariel Otilibili wrote:
> When returning from rte_mempool_set_ops_byname(), rte_errno is not set
> for error exits.
>
> The API requires rte_errno to be set in that case.
>
> Bugzilla ID: 1559
> Fixes: c2c6b2f41305 ("mempool: fix default ops for an emp
On Thu, 23 Jan 2025 14:55:19 -0800
Nicolas Chautru wrote:
> Adds internal buffer for more flexible logging.
>
> Signed-off-by: Nicolas Chautru
Inventing another device specific error log seems like a short sighted concept.
Why doesn't existing DPDK logging work well enough?
Hi,
Based on previous discussion improving logging for bbdev and
PMD using notably trace points and internal logging extension.
The trace point impacting real time are not built by default.
This is added at bbdev level and also in the PMD specific
implementation.
Thanks
Nic
Nicolas Chautru (3):
Adds internal buffer for more flexible logging.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc/acc_common.h | 22 +++---
drivers/baseband/acc/rte_vrb_pmd.c | 18 +-
2 files changed, 36 insertions(+), 4 deletions(-)
diff --git a/drivers/baseband/acc/acc_
Improvement of logging to notably use trace point
for driver specific error logging and tracepoint.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc/acc_common.c | 8
drivers/baseband/acc/acc_common.h | 55 ++
drivers/baseband/acc/rte_vrb_pmd.c | 63 +++
Adds trace points for rte_bbdev.
Signed-off-by: Nicolas Chautru
---
lib/bbdev/bbdev_trace.h| 69 ++
lib/bbdev/bbdev_trace_points.c | 27 +
lib/bbdev/meson.build | 6 ++-
lib/bbdev/rte_bbdev.c | 16
lib/bbdev/rte_bbde
64 matches
Mail list logo
