RE: [EXTERNAL] graph: dispatch mode with libevent for control plane

2024-12-16 Thread Jerin Jacob
> -Original Message- > From: Robin Jarry > Sent: Monday, December 9, 2024 2:58 PM > To: Nitin Saxena ; dev@dpdk.org; gr...@dpdk.org > Cc: Jerin Jacob ; David Marchand > ; Christophe Fontaine ; > Nitin Saxena > Subject: [EXTERNAL] graph: dispatch mode with libevent for control plane >

Re: [PATCH v2 4/6] drivers: fix exported headers

2024-12-16 Thread David Marchand
On Fri, Dec 13, 2024 at 2:46 PM David Marchand wrote: > > > diff --git a/drivers/raw/cnxk_bphy/rte_pmd_bphy.h > > > b/drivers/raw/cnxk_bphy/rte_pmd_bphy.h > > > index f668e6ea82..c200c935ff 100644 > > > --- a/drivers/raw/cnxk_bphy/rte_pmd_bphy.h > > > +++ b/drivers/raw/cnxk_bphy/rte_pmd_bphy.h >

Re: [PATCH 1/3] random: defer seeding to EAL init

2024-12-16 Thread Burakov, Anatoly
On 12/5/2024 6:57 PM, David Marchand wrote: The RNG is documented as being seeded as part of EAL init. /** * Seed the pseudo-random generator. * * The generator is automatically seeded by the EAL init with a timer * value. It may need to be re-seeded by the user with a real random * va

Re: [PATCH 0/3] Defer lcore variables allocation

2024-12-16 Thread Burakov, Anatoly
On 12/5/2024 6:57 PM, David Marchand wrote: As I had reported in rc2, the lcore variables allocation have a noticeable impact on applications consuming DPDK, even when such applications does not use DPDK, or use features associated to some lcore variables. While the amount has been reduced in a

Re: [PATCH 0/3] Defer lcore variables allocation

2024-12-16 Thread David Marchand
On Mon, Dec 16, 2024 at 10:42 AM Burakov, Anatoly wrote: > > On 12/5/2024 6:57 PM, David Marchand wrote: > > As I had reported in rc2, the lcore variables allocation have a > > noticeable impact on applications consuming DPDK, even when such > > applications does not use DPDK, or use features asso

Re: [PATCH] net/af_packet: allow disabling packet fanout

2024-12-16 Thread Tudor Cornea
> Controlling fanout more is a good idea but not sure what this patch > is trying to do with it. I am maintaining a DPDK application which should run on a large number of setups. Unfortunately, I do not have a lot of control over the environment the application runs on (e.g kernel). The problem I

Re: [PATCH 2/3] power: defer lcore variable allocation

2024-12-16 Thread David Marchand
On Fri, Dec 13, 2024 at 7:58 AM Mattias Rönnblom wrote: > On 2024-12-12 08:57, David Marchand wrote: > > clb_multiwait, clb_pause and clb_scale_freq callbacks can only be > > reached after a successful call to > > rte_power_ethdev_pmgmt_queue_enable. > > Triggering an allocation in them means we a

Re: [PATCH 0/3] Defer lcore variables allocation

2024-12-16 Thread Burakov, Anatoly
On 12/10/2024 10:41 AM, Mattias Rönnblom wrote: Maybe the DAG is available on the build (meson) level, and thus the code can be generated out of that? There is in fact a patchset that produces just that kind of graph: https://patches.dpdk.org/project/dpdk/list/?series=34055 It's currentl

Re: [PATCH v5 6/8] build: reduce driver dependencies

2024-12-16 Thread David Marchand
On Wed, Nov 27, 2024 at 5:20 PM Burakov, Anatoly wrote: > > On 11/27/2024 3:56 PM, Anatoly Burakov wrote: > > From: Bruce Richardson > > > > Remove any unnecessary dependencies from the driver dependency lists. > > This will give each driver a near-minimum set of required dependencies. > > > > Si

[PATCH v2] eventdev: add port attribute for independent enqueue

2024-12-16 Thread pravin . pathak
From: Pravin Pathak Independent Enqueue support is added to DPDK 24.11. Adding support for RTE_EVENT_PORT_ATTR_INDEPENDENT_ENQ attribute to rte_event_port_attr_get() which was missing Signed-off-by: Pravin Pathak --- lib/eventdev/rte_eventdev.c | 8 lib/eventdev/rte_eventdev.h | 4 +++

Re: [PATCH v2 2/6] drivers: drop export of driver headers

2024-12-16 Thread Andrew Rybchenko
On 12/13/24 14:03, Bruce Richardson wrote: On Fri, Dec 13, 2024 at 11:50:06AM +0100, David Marchand wrote: Many classes are exposing driver only headers as public headers. Move them to the driver_sdk_headers list. Signed-off-by: David Marchand --- LGTM. The names of most of the headers are p

Re: [RFC] eventdev: add atomic queue to test-eventdev app

2024-12-16 Thread Luka Jankovic
Thank you for the feedback. I will re-implement the test by not checking port-flow-queue combination and generally clean-up the code based on your comments. On Tue, 2024-12-10 at 11:37 +0100, Mattias Rönnblom wrote: > > > +{ > > +   struct rte_event_dev_info dev_info; > > + > > +   rte_

Re: [PATCH v6] graph: mcore: optimize graph search

2024-12-16 Thread David Marchand
Salut Dodji, On Mon, Dec 16, 2024 at 2:44 AM Huichao Cai wrote: > diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore > index 21b8cd6113..a92ee29512 100644 > --- a/devtools/libabigail.abignore > +++ b/devtools/libabigail.abignore > @@ -33,3 +33,8 @@ > ;;;

Re: [PATCH 13/21] drivers/net: use portable variadic macros

2024-12-16 Thread Andrew Rybchenko
On 12/11/24 05:05, Andre Muezerie wrote: 1) Use portable variadic macros Many places are using a GCC extension related to variadic macros, where a name prepends the ellipsis. This results in a warning like the one below when compiling the code with MSVC: app\test-pmd\testpmd.h(1314): error C260

[PATCH] net/sfc: avoid duplicate configuration restore

2024-12-16 Thread Andrew Rybchenko
MAC address, promiscuous and all-multicast modes are restored correctly upon device start by the PMD itself. ethdev layer should not duplicate it. Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ethdev.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/sfc/sfc_eth

RE: 21.11.9 patches review and test

2024-12-16 Thread Ali Alnubani
> -Original Message- > From: Kevin Traynor > Sent: Wednesday, December 4, 2024 5:59 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; Ali > Alnubani ; David Christensen ; > Hemant Agrawal ; Ian Stokes > ; Jerin Jacob ; John McNamara > ; Ju-Hyoung Lee ; Kevin > Traynor ; Luca

Re: [PATCH v2 1/5] ethdev: check that device supports deferred start

2024-12-16 Thread Stephen Hemminger
On Sun, 15 Dec 2024 11:56:55 +0300 Andrew Rybchenko wrote: > On 12/14/24 21:07, Stephen Hemminger wrote: > > The check for supporting deferred start should be handled at > > the ethdev level for all devices. > > It is a good idea to check it on ethdev level. > > Strictly speaking presence of

[PATCH v3 3/6] net/dpaa: remove unnecessary deferred start check

2024-12-16 Thread Stephen Hemminger
This check is now done in ethdev layer. Signed-off-by: Stephen Hemminger --- drivers/net/dpaa/dpaa_ethdev.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index e8d34e5898..ce48f0 100644 --- a/drivers/net/dpaa/dp

[PATCH v3 2/6] doc: fix feature flags for queue start/stop

2024-12-16 Thread Stephen Hemminger
Several drivers have mismatch between the ethdev ops for queue start/stop and the documentation. The gve driver does implement queue start/stop support. The mana, netvsc, virtio and vmxnet3 drivers do not implement the rx_queue_start callback. Signed-off-by: Stephen Hemminger --- doc/guides/nics

[PATCH v3 5/6] net/enetfec: remove unneeded deferred start check

2024-12-16 Thread Stephen Hemminger
Already checked in ethdev now. Signed-off-by: Stephen Hemminger --- drivers/net/enetfec/enet_ethdev.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/net/enetfec/enet_ethdev.c b/drivers/net/enetfec/enet_ethdev.c index 91c0f60490..9835532595 100644 -

[PATCH v3 1/6] ethdev: check that device supports deferred start

2024-12-16 Thread Stephen Hemminger
The check for supporting deferred start should be handled at the ethdev level for all devices. Signed-off-by: Stephen Hemminger Acked-by: Andrew Rybchenko --- lib/ethdev/rte_ethdev.c | 16 1 file changed, 16 insertions(+) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_e

[PATCH v3 0/6] queue start/stop and deferred checks

2024-12-16 Thread Stephen Hemminger
Recent zxdh driver review raised the question of why should drivers have to check rx_conf for deferred start support. This can be better handled across all drivers at ethdev level. Also found some drivers were incorrect in feature flags about handling of queue start/stop. v3 - fix doc about queue

[PATCH v3 6/6] net/virtio: remove unneeded deferred start check

2024-12-16 Thread Stephen Hemminger
Already checked in ethdev now. Signed-off-by: Stephen Hemminger --- drivers/net/virtio/virtio_rxtx.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index b67f063b31..6ae3a6eb12 100644 --- a/drivers/net/virtio/vir

[PATCH v3 4/6] net/dpaa2: remove unneeded deferred start check

2024-12-16 Thread Stephen Hemminger
Already checked in ethdev now. Signed-off-by: Stephen Hemminger --- drivers/net/dpaa2/dpaa2_ethdev.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index a9bce854c3..8624bba0ce 100644 --- a/drivers/net/dpaa2/

Re: [PATCH v2 1/5] ethdev: check that device supports deferred start

2024-12-16 Thread Andrew Rybchenko
On 12/16/24 21:58, Stephen Hemminger wrote: On Sun, 15 Dec 2024 11:56:55 +0300 Andrew Rybchenko wrote: On 12/14/24 21:07, Stephen Hemminger wrote: The check for supporting deferred start should be handled at the ethdev level for all devices. It is a good idea to check it on ethdev level. S

RE: 23.11.3 patches review and test

2024-12-16 Thread Xu, HailinX
> -Original Message- > From: Xueming Li > Sent: Tuesday, December 10, 2024 10:49 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Ali Alnubani ; David Christensen > ; Hemant Agrawal ; > Stokes, Ian ; Jerin Jacob ; > Mcnamara, John ; Ju-Hyoung Lee > ; Kevin Traynor ; Luca >