[PATCH 11/21] drivers/event: use portable variadic macros

2024-12-10 Thread Andre Muezerie
Many places are using a GCC extension related to variadic macros, where a name prepends the ellipsis. This results in a warning like the one below when compiling the code with MSVC: app\test-pmd\testpmd.h(1314): error C2608: invalid token '...' in macro parameter list Variadic macros became a

[PATCH 14/21] drivers/raw: use portable variadic macros

2024-12-10 Thread Andre Muezerie
Many places are using a GCC extension related to variadic macros, where a name prepends the ellipsis. This results in a warning like the one below when compiling the code with MSVC: app\test-pmd\testpmd.h(1314): error C2608: invalid token '...' in macro parameter list Variadic macros became a

[PATCH v1 1/2] dts: add new testpmd shell functions

2024-12-10 Thread Thomas Wilks
Add support for setting Mac address, set flow control, VF mode in the testpmd shell. Signed-off-by: Thomas Wilks Reviewed-by: Paul Szczepanek --- dts/framework/remote_session/testpmd_shell.py | 120 ++ 1 file changed, 120 insertions(+) diff --git a/dts/framework/remote_session/

[PATCH v1 2/2] dts: add port restart configuration persistency test

2024-12-10 Thread Thomas Wilks
Added test that sets various port settings and verifies that they persist after a port restart. Signed-off-by: Thomas Wilks Reviewed-by: Paul Szczepanek --- ...stSuite_port_restart_config_persistency.py | 117 ++ 1 file changed, 117 insertions(+) create mode 100644 dts/tests/Te

[RFC 2/8] net/ioring: implement link state

2024-12-10 Thread Stephen Hemminger
Add hooks to set kernel link up/down and report state. Signed-off-by: Stephen Hemminger --- doc/guides/nics/features/ioring.ini | 1 + drivers/net/ioring/rte_eth_ioring.c | 84 + 2 files changed, 85 insertions(+) diff --git a/doc/guides/nics/features/ioring.ini b/d

Re: [PATCH 16/21] lib/log: ensure code structure does not change

2024-12-10 Thread Stephen Hemminger
On Tue, 10 Dec 2024 18:05:46 -0800 Andre Muezerie wrote: > Add "do { } while (0)" to macros used to remove logging calls, to > ensure there's no code structure change when enabling/disabling > logging. > > Signed-off-by: Andre Muezerie > --- > lib/log/rte_log.h | 2 +- > 1 file changed, 1 inse

[DPDK/meson Bug 1594] [dpdk-21.11.9-rc1] unit_tests_eal/link_bonding: link_bonding_autotest test failed

2024-12-10 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1594 Bug ID: 1594 Summary: [dpdk-21.11.9-rc1] unit_tests_eal/link_bonding: link_bonding_autotest test failed Product: DPDK Version: 21.11 Hardware: x86 OS: All

[DPDK/ethdev Bug 1592] AF_PACKET PMD loops back packets on veth with tc

2024-12-10 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1592 Stephen Hemminger (step...@networkplumber.org) changed: What|Removed |Added Resolution|--- |INVALID

Re: [PATCH v3 5/6] net/macb: fix tab errors in meson.build file

2024-12-10 Thread Stephen Hemminger
On Tue, 10 Dec 2024 07:08:35 + Wencheng Li wrote: > Replace tabs with spaces to resolve indentation > issues in meson.build file. > > Fixes: 97fd6a929cf8 ("net/macb: add new driver") > Cc: liwench...@phytium.com.cn > > Signed-off-by: Wencheng Li Since this is a new driver, please fix this

Re: [RFC 5/6] build: install indirect headers to a dedicated directory

2024-12-10 Thread David Marchand
On Wed, Nov 27, 2024 at 12:43 PM Bruce Richardson wrote: > > diff --git a/buildtools/pkg-config/meson.build > > b/buildtools/pkg-config/meson.build > > index b36add17e3..809706fe3e 100644 > > --- a/buildtools/pkg-config/meson.build > > +++ b/buildtools/pkg-config/meson.build > > @@ -27,12 +27,18

23.11.3 patches review and test

2024-12-10 Thread Xueming Li
Hi all, Here is a list of patches targeted for stable release 23.11.3. The planned date for the final release is 17th December. Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported valida

[PATCH 1/3] lib/eal: add rte_atomic128_cmp_exchange compatible with MSVC

2024-12-10 Thread Andre Muezerie
MSVC does not support inline assembly, which is used by the implementation of rte_atomic128_cmp_exchange and is needed by lib/stack. Error printed by MSVC: stack_rte_stack_lf.c.obj : error LNK2019: unresolved external symbol rte_atomic128_cmp_exchange referenced in function __rte_stack_lf

Re: [PATCH 0/3] Defer lcore variables allocation

2024-12-10 Thread Stephen Hemminger
On Fri, 06 Dec 2024 16:55:30 +0100 Thomas Monjalon wrote: > 06/12/2024 12:01, Mattias Rönnblom: > > On 2024-12-05 18:57, David Marchand wrote: > > In retrospect, maybe the offset between lcore variable instances could > > have been encoded into the handle, and thus one could use > > different-s

[PATCH 3/3] lib/stack: enable build with MSVC

2024-12-10 Thread Andre Muezerie
Now that the issues preventing the code needed to build lib/stack have been addressed, it can be enabled so that it also gets built when using the MSVC compiler. Signed-off-by: Andre Muezerie --- lib/stack/meson.build | 6 -- 1 file changed, 6 deletions(-) diff --git a/lib/stack/meson.build

[PATCH 2/3] app/test: add basic test for rte_atomic128_cmp_exchange

2024-12-10 Thread Andre Muezerie
A basic test for rte_atomic128_cmp_exchange that can also be compiled with MSVC and run on Windows is being added. This is relevant as rte_atomic128_cmp_exchange uses a different implementation when compiled with MSVC and the existing tests for this function are not compatible with MSVC. Signed-o

[PATCH 0/3] enable build of lib/stack when using MSVC

2024-12-10 Thread Andre Muezerie
MSVC does not support inline assembly, which is used by the implementation of rte_atomic128_cmp_exchange and is needed by lib/stack. An implementation for rte_atomic128_cmp_exchange compatible with MSVC using an intrinsic function is added. For other compilers the existing implementation continues

Re: [RFC] eventdev: add atomic queue to test-eventdev app

2024-12-10 Thread Mattias Rönnblom
On 2024-12-05 14:29, Luka Jankovic wrote: From 753273ab9af49e16d7f7b577d6263e3db51257d7 Mon Sep 17 00:00:00 2001 From: Luka Jankovic Date: Thu, 5 Dec 2024 13:05:35 + Subject: [RFC] eventdev: add atomic queue to test-eventdev app Add an atomic queue test based on the order queue test but us

[PATCH 0/3] dts: enable types of Scapy

2024-12-10 Thread Luca Vizzarro
Hi there, sending in a could of patches which update our current dependencies, therefore enabling typed Scapy. Updated mypy also suggested to add missing stubs, which were add appropriately. Depends-on: series-34127 ("dts: add Ruff and docstring linting") Best regards, Luca Luca Vizzarro (3):

[DPDK/DTS Bug 1389] Investigate automatically building config schema documentation

2024-12-10 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1389 Luca Vizzarro (luca.vizza...@arm.com) changed: What|Removed |Added CC||luca.vizza...@arm.com

[PATCH 2/3] dts: add missing type stubs

2024-12-10 Thread Luca Vizzarro
The invoke and paramiko libraries were missing the type stubs. These are added under the dev dependencies as the only scope in which they are used is through mypy static checking. For the same reason, move the PyYAML subs under the dev dependencies. Signed-off-by: Luca Vizzarro Reviewed-by: Paul

[PATCH 3/3] dts: resolve mypy type errors

2024-12-10 Thread Luca Vizzarro
The addition of scapy types yielded new errors in mypy, which could not previously be checked. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- .../interactive_remote_session.py | 4 ++-- .../single_active_interactive_shell.py| 2 +- dts/framework/remote_sessi

[PATCH v2 0/3] dts: enable types of Scapy

2024-12-10 Thread Luca Vizzarro
From: Luca Vizzarro Hi there, made a small mistake earlier... v2: - fixed typo in Paul's email Depends-on: series-34127 ("dts: add Ruff and docstring linting") Best regards, Luca Luca Vizzarro (3): dts: update dependencies dts: add missing type stubs dts: resolve mypy type errors ...

[PATCH v2 3/3] dts: resolve mypy type errors

2024-12-10 Thread Luca Vizzarro
From: Luca Vizzarro The addition of scapy types yielded new errors in mypy, which could not previously be checked. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- .../interactive_remote_session.py | 4 ++-- .../single_active_interactive_shell.py| 2 +- dts/

[PATCH v2 2/3] dts: add missing type stubs

2024-12-10 Thread Luca Vizzarro
From: Luca Vizzarro The invoke and paramiko libraries were missing the type stubs. These are added under the dev dependencies as the only scope in which they are used is through mypy static checking. For the same reason, move the PyYAML subs under the dev dependencies. Signed-off-by: Luca Vizza

Re: [PATCH v8 17/47] net/bnxt: tf_ulp: support for Thor2 ulp layer

2024-12-10 Thread David Marchand
Hello, On Thu, Nov 7, 2024 at 3:09 PM Sriharsha Basavapatna wrote: > > From: Shuanglin Wang > > This patch includes the support for following features that enable > Thor2 support in the ULP layer: > > 1. Added support for ulp initialization on Thor2 platform. This involved > breaking the functio

[PATCH 3/6] dts: fix docstring linter errors

2024-12-10 Thread Luca Vizzarro
The addition of Ruff pydocstyle and pydoclint rules has raised new problems in the docstrings which require to be fixed. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- .../single_active_interactive_shell.py| 11 +++- dts/framework/runner.py | 48

[PATCH 2/6] dts: enable Ruff preview pydoclint rules

2024-12-10 Thread Luca Vizzarro
DTS requires a linter for docstrings but the current selection is limited. The most promising docstring linter is pydoclint. On the other hand, Ruff is currently in the process of implementing pydoclint rules. This would spare the project from supporting yet another linter, without any loss of bene

[PATCH 0/6] dts: add Ruff and docstring linting

2024-12-10 Thread Luca Vizzarro
Hi there, sending a new patchset to cover the replacement of all the current linters with Ruff. The configuration of Ruff was attempted to be 1:1, but there are slight differences meaning that Ruff did not purposely implement all the rules. Either way, at the moment it should be a near perfect mat

[PATCH 1/6] dts: add Ruff as linter and formatter

2024-12-10 Thread Luca Vizzarro
To improve and streamline the development process, Ruff presents itself as a very fast all-in-one linter that is able to apply fixes and formatter compatible with Black. Ruff implements all the rules that DTS currently use and expands on them, leaving space to easily enable more checks in the futur

[PATCH] devtools: enhance the license check

2024-12-10 Thread David Marchand
Reformat the license/exceptions.txt file to make it easier to build a list of exempted files. Display all files committed in DPDK that are non compliant with BSD-3 license. Signed-off-by: David Marchand --- devtools/check-spdx-tag.sh | 59 +++--- license/exception

[PATCH 4/6] dts: apply Ruff formatting

2024-12-10 Thread Luca Vizzarro
While Ruff formatting is Black-compatible and is near-identical, it still requires formatting for a small set of elements. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/params/eal.py | 5 +- dts/framework/remote_session/dpdk_shell.py| 1 - d

[PATCH 6/6] dts: remove old linters and formatters

2024-12-10 Thread Luca Vizzarro
Since the addition of Ruff, all the previously used linters and formatters are no longer used, therefore remove. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/poetry.lock| 170 + dts/pyproject.toml | 24 --- 2 files change

[PATCH 5/6] dts: update dts-check-format to use Ruff

2024-12-10 Thread Luca Vizzarro
Replace the current linters and formatter in favour of Ruff in the dts-check-format tool. Bugzilla ID: 1358 Bugzilla ID: 1455 Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- devtools/dts-check-format.sh | 30 +++--- 1 file changed, 15 insertions(+), 15 del

Re: [PATCH 0/3] Defer lcore variables allocation

2024-12-10 Thread Mattias Rönnblom
On 2024-12-09 18:40, David Marchand wrote: On Mon, Dec 9, 2024 at 4:39 PM Mattias Rönnblom wrote: On 2024-12-09 12:03, David Marchand wrote: On Fri, Dec 6, 2024 at 12:02 PM Mattias Rönnblom wrote: On 2024-12-05 18:57, David Marchand wrote: As I had reported in rc2, the lcore variables alloc

[PATCH v2] MAINTAINERS: change maintainer for next-net

2024-12-10 Thread Stephen Hemminger
Change of maintainers for next-net tree. Signed-off-by: Stephen Hemminger Acked-by: Ferruh Yigit --- MAINTAINERS | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 60bdcce543..0f940ad713 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -28,8 +28,7

[RFC 0/8] ioring: network driver

2024-12-10 Thread Stephen Hemminger
This is first draft of new simplified TAP device that uses the Linux kernel ioring API to provide a read/write ring with kernel. This is split from tap device because there are so many unnecessary things in existing tap, and supporting ioring is better without ifdefs etc. The default name of the t

[RFC 1/8] net/ioring: introduce new driver

2024-12-10 Thread Stephen Hemminger
Add basic driver initialization, documentation, and device creation and basic documentation. Signed-off-by: Stephen Hemminger --- doc/guides/nics/features/ioring.ini | 9 + doc/guides/nics/index.rst | 1 + doc/guides/nics/ioring.rst | 66 +++ drivers/net/ioring/meson.

[RFC 6/8] net/ioring: implement receive and transmit

2024-12-10 Thread Stephen Hemminger
Use io_uring to read and write from TAP device. Signed-off-by: Stephen Hemminger --- drivers/net/ioring/rte_eth_ioring.c | 364 +++- 1 file changed, 363 insertions(+), 1 deletion(-) diff --git a/drivers/net/ioring/rte_eth_ioring.c b/drivers/net/ioring/rte_eth_ioring.c i

[RFC 5/8] net/ioring: implement primary secondary fd passing

2024-12-10 Thread Stephen Hemminger
Add support for communicating fd's from primary to secondary. Signed-off-by: Stephen Hemminger --- doc/guides/nics/features/ioring.ini | 1 + drivers/net/ioring/rte_eth_ioring.c | 136 +++- 2 files changed, 135 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics

[RFC 4/8] net/ioring: implement management functions

2024-12-10 Thread Stephen Hemminger
Add start, stop, configure and info functions. Signed-off-by: Stephen Hemminger --- drivers/net/ioring/rte_eth_ioring.c | 72 ++--- 1 file changed, 66 insertions(+), 6 deletions(-) diff --git a/drivers/net/ioring/rte_eth_ioring.c b/drivers/net/ioring/rte_eth_ioring.c in

[RFC 3/8] net/ioring: implement control functions

2024-12-10 Thread Stephen Hemminger
These internal ops, just force changes to kernel visible net device. Signed-off-by: Stephen Hemminger --- doc/guides/nics/features/ioring.ini | 3 ++ drivers/net/ioring/rte_eth_ioring.c | 69 + 2 files changed, 72 insertions(+) diff --git a/doc/guides/nics/features/

[RFC 7/8] net/ioring: add VLAN support

2024-12-10 Thread Stephen Hemminger
Add support for VLAN insert and stripping. Signed-off-by: Stephen Hemminger --- drivers/net/ioring/rte_eth_ioring.c | 45 +++-- 1 file changed, 43 insertions(+), 2 deletions(-) diff --git a/drivers/net/ioring/rte_eth_ioring.c b/drivers/net/ioring/rte_eth_ioring.c index

[RFC 8/8] net/ioring: implement statistics

2024-12-10 Thread Stephen Hemminger
Add support for basic statistics Signed-off-by: Stephen Hemminger --- drivers/net/ioring/rte_eth_ioring.c | 57 + 1 file changed, 57 insertions(+) diff --git a/drivers/net/ioring/rte_eth_ioring.c b/drivers/net/ioring/rte_eth_ioring.c index a2bfefec45..f58740197d 100

[PATCH 03/21] app/test-mldev: use portable variadic macros

2024-12-10 Thread Andre Muezerie
Many places are using a GCC extension related to variadic macros, where a name prepends the ellipsis. This results in a warning like the one below when compiling the code with MSVC: app\test-pmd\testpmd.h(1314): error C2608: invalid token '...' in macro parameter list Variadic macros became a

[PATCH 00/21] use portable variadic macros

2024-12-10 Thread Andre Muezerie
1) Use portable variadic macros Many places are using a GCC extension related to variadic macros, where a name prepends the ellipsis. This results in a warning like the one below when compiling the code with MSVC: app\test-pmd\testpmd.h(1314): error C2608: invalid token '...' in macro paramet

[PATCH 07/21] drivers/common: use portable variadic macros

2024-12-10 Thread Andre Muezerie
1) Use portable variadic macros Many places are using a GCC extension related to variadic macros, where a name prepends the ellipsis. This results in a warning like the one below when compiling the code with MSVC: app\test-pmd\testpmd.h(1314): error C2608: invalid token '...' in macro paramet

[PATCH 05/21] drivers/baseband: ensure code structure does not change

2024-12-10 Thread Andre Muezerie
Add "do { } while (0)" to macros used to remove logging calls, to ensure there's no code structure change when enabling/disabling logging. Signed-off-by: Andre Muezerie --- drivers/baseband/acc/acc100_pmd.h | 2 +- drivers/baseband/acc/vrb_pmd.h| 2 +- 2 files changed, 2 insertions(+), 2 del

[PATCH 08/21] drivers/compress: use portable variadic macros

2024-12-10 Thread Andre Muezerie
Many places are using a GCC extension related to variadic macros, where a name prepends the ellipsis. This results in a warning like the one below when compiling the code with MSVC: app\test-pmd\testpmd.h(1314): error C2608: invalid token '...' in macro parameter list Variadic macros became a

[PATCH 06/21] drivers/bus: use portable variadic macros

2024-12-10 Thread Andre Muezerie
1) Use portable variadic macros Many places are using a GCC extension related to variadic macros, where a name prepends the ellipsis. This results in a warning like the one below when compiling the code with MSVC: app\test-pmd\testpmd.h(1314): error C2608: invalid token '...' in macro paramet

[PATCH 02/21] app/test-eventdev: use portable variadic macros

2024-12-10 Thread Andre Muezerie
Many places are using a GCC extension related to variadic macros, where a name prepends the ellipsis. This results in a warning like the one below when compiling the code with MSVC: app\test-pmd\testpmd.h(1314): error C2608: invalid token '...' in macro parameter list Variadic macros became a

[PATCH 01/21] app/test-acl: use portable variadic macros

2024-12-10 Thread Andre Muezerie
Many places are using a GCC extension related to variadic macros, where a name prepends the ellipsis. This results in a warning like the one below when compiling the code with MSVC: app\test-pmd\testpmd.h(1314): error C2608: invalid token '...' in macro parameter list Variadic macros became a

[PATCH 12/21] drivers/mempool: use portable variadic macros

2024-12-10 Thread Andre Muezerie
Many places are using a GCC extension related to variadic macros, where a name prepends the ellipsis. This results in a warning like the one below when compiling the code with MSVC: app\test-pmd\testpmd.h(1314): error C2608: invalid token '...' in macro parameter list Variadic macros became a

[PATCH 04/21] app/test-pmd: use portable variadic macros

2024-12-10 Thread Andre Muezerie
Many places are using a GCC extension related to variadic macros, where a name prepends the ellipsis. This results in a warning like the one below when compiling the code with MSVC: app\test-pmd\testpmd.h(1314): error C2608: invalid token '...' in macro parameter list Variadic macros became a

[PATCH 13/21] drivers/net: use portable variadic macros

2024-12-10 Thread Andre Muezerie
1) Use portable variadic macros Many places are using a GCC extension related to variadic macros, where a name prepends the ellipsis. This results in a warning like the one below when compiling the code with MSVC: app\test-pmd\testpmd.h(1314): error C2608: invalid token '...' in macro paramet

[PATCH 09/21] drivers/crypto: use portable variadic macros

2024-12-10 Thread Andre Muezerie
1) Use portable variadic macros Many places are using a GCC extension related to variadic macros, where a name prepends the ellipsis. This results in a warning like the one below when compiling the code with MSVC: app\test-pmd\testpmd.h(1314): error C2608: invalid token '...' in macro paramet

[PATCH 15/21] drivers/vdpa: use portable variadic macros

2024-12-10 Thread Andre Muezerie
Many places are using a GCC extension related to variadic macros, where a name prepends the ellipsis. This results in a warning like the one below when compiling the code with MSVC: app\test-pmd\testpmd.h(1314): error C2608: invalid token '...' in macro parameter list Variadic macros became a

[PATCH 10/21] drivers/dma: use portable variadic macros

2024-12-10 Thread Andre Muezerie
Many places are using a GCC extension related to variadic macros, where a name prepends the ellipsis. This results in a warning like the one below when compiling the code with MSVC: app\test-pmd\testpmd.h(1314): error C2608: invalid token '...' in macro parameter list Variadic macros became a

[PATCH 18/21] lib/port: ensure code structure does not change

2024-12-10 Thread Andre Muezerie
Add "do { } while (0)" to macros used to remove logging calls, to ensure there's no code structure change when enabling/disabling logging. Signed-off-by: Andre Muezerie --- lib/port/rte_swx_port_ethdev.c | 2 +- lib/port/rte_swx_port_fd.c | 2 +- lib/port/rte_swx_port_ring.c

[PATCH 20/21] lib/rcu: ensure code structure does not change

2024-12-10 Thread Andre Muezerie
Add "do { } while (0)" to macros used to remove logging calls, to ensure there's no code structure change when enabling/disabling logging. Signed-off-by: Andre Muezerie --- lib/rcu/rte_rcu_qsbr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu

[PATCH 16/21] lib/log: ensure code structure does not change

2024-12-10 Thread Andre Muezerie
Add "do { } while (0)" to macros used to remove logging calls, to ensure there's no code structure change when enabling/disabling logging. Signed-off-by: Andre Muezerie --- lib/log/rte_log.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/log/rte_log.h b/lib/log/rte_log.h

[PATCH 17/21] lib/pipeline: ensure code structure does not change

2024-12-10 Thread Andre Muezerie
Add "do { } while (0)" to macros used to remove logging calls, to ensure there's no code structure change when enabling/disabling logging. Signed-off-by: Andre Muezerie --- lib/pipeline/rte_swx_pipeline_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/pipeline/r

[PATCH 19/21] lib/power: ensure code structure does not change

2024-12-10 Thread Andre Muezerie
Add "do { } while (0)" to macros used to remove logging calls, to ensure there's no code structure change when enabling/disabling logging. Signed-off-by: Andre Muezerie --- lib/power/power_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/power/power_common.h b/lib

[PATCH 21/21] lib/vhost: ensure code structure does not change

2024-12-10 Thread Andre Muezerie
Add "do { } while (0)" to macros used to remove logging calls, to ensure there's no code structure change when enabling/disabling logging. Signed-off-by: Andre Muezerie --- lib/vhost/vhost_crypto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/vhost/vhost_crypto.c b/lib