From: Konstantin Ananyev
../lib/gro/rte_gro.c:182:34: warning:
variable length array used [-Wvla]
../lib/gro/rte_gro.c:363:34: warning:
variable length array used [-Wvla]
In both cases the pattern is the same: we use unprocess_pkts[nb_pkts] to
collect un-used by GRO packets, and then cop
Members Attending
-
Aaron Conole
Bruce Richardson
Hemant Agrawal
Jerin Jacob
Kevin Traynor
Konstantin Ananyev
Maxime Coquelin
Morten Brørup
Stephen Hemminger
Thomas Monjalon
NOTE: The technical board meetings are on every second Wednesday at 3pm
UTC. Meetings are public,
Recheck-request: iol-intel-Performance
https://bugs.dpdk.org/show_bug.cgi?id=1588
Bug ID: 1588
Summary: sched: potential issue with memcmp of padding
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
https://bugs.dpdk.org/show_bug.cgi?id=1585
Bug ID: 1585
Summary: Company's blog decided to conduct static analysis DPDK
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity
The buffer used to construct headers (which contain 32 bit values)
was declared as uint8_t which can lead to unaligned access.
Change to declare buffer as uint32_t.
Signed-off-by: Stephen Hemminger
---
lib/pcapng/rte_pcapng.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff
https://bugs.dpdk.org/show_bug.cgi?id=1587
Bug ID: 1587
Summary: lpm: undefined right shift
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority:
https://bugs.dpdk.org/show_bug.cgi?id=1585
Stephen Hemminger (step...@networkplumber.org) changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
https://bugs.dpdk.org/show_bug.cgi?id=1586
Bug ID: 1586
Summary: Drivers are doing useless check for pthread_mutex_init
return value
Product: DPDK
Version: 24.11
Hardware: All
OS: All
Status: UNC
On Wed, Nov 20, 2024 at 9:01 AM Ajit Khaparde
wrote:
>
> From: Kishore Padmanabha
>
> The mbuf offload flags were not reset before the flags were
> populated with the received packet details. This causes certain
> applications to act differently on the offload flags. That can
> cause application
Recheck-request: iol-intel-Performance
Hello all,
I will not be available to host the DPDK CI meeting on Thursday November
28, as it is the American Thanksgiving holiday.
To account for this, I would like to discuss CI topics as an extra agenda
item at the December 5 DTS meeting. Please let me know if anyone takes
issue with this. If
Thanks Luca, Thomas,
I see Thomas just applied it to main, but I'll mention I tested with meson
werror and I think this fix is appropriate.
This is a good reminder for us to always build with --werror
On Wed, Nov 20, 2024 at 10:54 AM Thomas Monjalon
wrote:
> 20/11/2024 16:05, Thomas Monjalon:
>
> 20/03/2024 02:40, Vipin Varghese:
> > In case incorrect NUMA configuration, the current commit shares
> > 1) either `source or destination numa is greater`
> > 2) instead of `actual NUMA` it is `acture NUMA`
> > 3) uses `printf` instead of PRINT_ERR
> >
> > current patch changes the above t
This patch set provides further fixes:
Feature DSCP:
The issue with the modification of the DSCP field
for IPV4 and IPV6 is fixed by adding
copying the DSCP value to the flow handler.
Feature MTU:
Supplement existing toggle-like macros
with respective opposites for the correct enablemen
On Tue, Nov 19, 2024 at 05:54:29PM -0800, Andre Muezerie wrote:
> From: Konstantin Ananyev
>
> 1) ./lib/ethdev/rte_ethdev.c:3244:16
> : warning: ISO C90 forbids variable length array ‘xstats_names’
> 2) ./lib/ethdev/rte_ethdev.c:3345:17
> : warning: ISO C90 forbids variable length array ‘
On Tue, Nov 19, 2024 at 05:54:30PM -0800, Andre Muezerie wrote:
> From: Konstantin Ananyev
>
> 1) ./lib/hash/rte_cuckoo_hash.c:2362:9
> : warning: ISO C90 forbids variable length array ‘positions’
> 2) ../lib/hash/rte_cuckoo_hash.c:2478:9
> : warning: ISO C90 forbids variable length array
19/11/2024 16:57, Bruce Richardson:
> When using a secondary process, e.g. pdump, not all PCI devices will be
> probed correctly if the primary process has allowlisted devices using
> the shortened syntax, omitting the initial ":" domain. This is due
> to the strcmp failing to match a full addr
In the testpmd command, we have to stop the port firstly before configuring
the DCB. However, some PMDs may execute a hardware reset during the port
stop, such as ixgbe. Some kind of reset operations of PMD could clear the
configurations of RSS in the hardware register. This would cause the loss
of
20/03/2024 02:40, Vipin Varghese:
> In case incorrect NUMA configuration, the current commit shares
> 1) either `source or destination numa is greater`
> 2) instead of `actual NUMA` it is `acture NUMA`
> 3) uses `printf` instead of PRINT_ERR
>
> current patch changes the above to
> 1) identify
Hi Stephen,
Sorry for the delay.
On Thur, Oct 10 at 2024 6:30AM, Stephen Hemminger wrote:
On Wed, 12 Apr 2023 17:52:39 +0800
Min Zhou wrote:
In the testpmd command, we have to stop the port firstly before configuring
the DCB. However, some PMDs may execute a hardware reset during the port
st
Hi Andre,
On 20/11/2024 03:13, Andre Muezerie wrote:
MSVC does not support VLAs, replace VLAs with standard C arrays.
Signed-off-by: Andre Muezerie
---
lib/hash/rte_thash_gf2_poly_math.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/lib/hash/rte_thash_gf2_poly_ma
> -Original Message-
> From: Luca Vizzarro
> Sent: Friday, November 8, 2024 1:40 PM
> To: dev@dpdk.org
> Cc: Paul Szczepanek ; Patrick Robb
> ; Luca Vizzarro ; Nicholas Pratte
>
> Subject: [PATCH v6 2/9] dts: add TestSuiteSpec class and discovery
>
> Currently there is a lack of a defini
> -Original Message-
> From: Luca Vizzarro
> Sent: Friday, November 8, 2024 1:40 PM
> To: dev@dpdk.org
> Cc: Paul Szczepanek ; Patrick Robb
> ; Luca Vizzarro ; Nicholas Pratte
>
> Subject: [PATCH v6 4/9] dts: use pydantic in the configuration
>
> This change brings in pydantic in place o
16/10/2024 08:32, Dmitry Kozlyuk:
> 2024-10-15 16:04 (UTC-0700), Stephen Hemminger:
> > This looks ok, but I know nothing about windows drivers.
> > Could we get a review by Dmitry?
>
> v3 got Reviewed-by almost a year ago, v4 only did a bit of renaming:
>
> http://inbox.dpdk.org/dev/202311
On Tue, Nov 19, 2024 at 05:54:43PM -0800, Andre Muezerie wrote:
> From: Tyler Retzlaff
>
> MSVC does not support optional C11 VLAs. When building for Windows
> enable -Wvla so that mingw and clang also fail if a VLA is used.
>
> Signed-off-by: Tyler Retzlaff
Acked-by: Bruce Richardson
On Tue, Nov 19, 2024 at 07:13:05PM -0800, Andre Muezerie wrote:
> From: Konstantin Ananyev
>
> 1) ./lib/hash/rte_cuckoo_hash.c:2362:9
> : warning: ISO C90 forbids variable length array ‘positions’
> 2) ../lib/hash/rte_cuckoo_hash.c:2478:9
> : warning: ISO C90 forbids variable length array
On Tue, Nov 19, 2024 at 07:13:18PM -0800, Andre Muezerie wrote:
> From: Tyler Retzlaff
>
> MSVC does not support optional C11 VLAs. When building for Windows
> enable -Wvla so that mingw and clang also fail if a VLA is used.
>
> Signed-off-by: Tyler Retzlaff
> ---
Resending from v9:
Acked-by:
Acked-by: Vladimir Medvedkin
On 20/11/2024 03:13, Andre Muezerie wrote:
From: Konstantin Ananyev
1) ./lib/hash/rte_cuckoo_hash.c:2362:9
: warning: ISO C90 forbids variable length array ‘positions’
2) ../lib/hash/rte_cuckoo_hash.c:2478:9
: warning: ISO C90 forbids variable length arr
> The current port ID validation logic in the routes add code has
> two issues:
>
> - It can pass if port ID in route is 31+.
> - It silently skips rules with disabled or invalid
>port IDs
>
> This patch is:
> - Improving the enabled port IDs check logic.
> - Introducing a user option,
Hi Andre,
On 20/11/2024 03:13, Andre Muezerie wrote:
From: Konstantin Ananyev
1) ./lib/hash/rte_thash.c:774:9
: warning: ISO C90 forbids variable length array ‘tmp_tuple’
From my understanding, tuple size here should never exceed
sizeof(union rte_thash_tuple), so it should be safe to rep
Hi Ali,
this warning has been fixed by the following patch:
dts: fix custom enum behaviour with docs
so at the top of the tree it shouldn't present itself. If it's a
critical problem, the fix can be rearranged to appear before.
Luca
Hi Ali,
thank you for reporting this promptly. We are aware of the warnings –
which are inevitable in the build conditions set, but unfortunately
missed the optional -W flag being added. I'll resolve this ASAP.
Best,
Luca
Sphinx-autodoc issues warnings about some symbols due to bad autodoc
"automock"ing when optional dependencies are missing.
The current meson setup allows to treat warnings as errors, halting the
process and exiting early. Given these warnings should be ignored, this
patch removes this behavior. Un
The test makes temporary files for parsing and then cleans up.
It was not checking the return value from the remove step
which makes Coverity unhappy.
Coverity ID: 451207
Coverity ID: 451209
Coverity ID: 451212
Coverity ID: 451213
Coverity ID: 451215
Coverity ID: 451217
Coverity ID: 451222
Coverit
20/11/2024 15:41, Luca Vizzarro:
> Sphinx-autodoc issues warnings about some symbols due to bad autodoc
> "automock"ing when optional dependencies are missing.
>
> The current meson setup allows to treat warnings as errors, halting the
> process and exiting early. Given these warnings should be ig
20/11/2024 14:53, Luca Vizzarro:
> Hi Ali,
>
> thank you for reporting this promptly. We are aware of the warnings –
> which are inevitable in the build conditions set, but unfortunately
> missed the optional -W flag being added. I'll resolve this ASAP.
Please don't remove all the context in yo
20/11/2024 15:04, Luca Vizzarro:
> Hi Ali,
>
> this warning has been fixed by the following patch:
>
>dts: fix custom enum behaviour with docs
>
> so at the top of the tree it shouldn't present itself. If it's a
> critical problem, the fix can be rearranged to appear before.
Too late, the
On Tue, 19 Nov 2024 17:54:43 -0800
Andre Muezerie wrote:
> From: Tyler Retzlaff
>
> MSVC does not support optional C11 VLAs. When building for Windows
> enable -Wvla so that mingw and clang also fail if a VLA is used.
>
> Signed-off-by: Tyler Retzlaff
> ---
It would be good to catch VLA's in
On Tue, 19 Nov 2024 19:13:03 -0800
Andre Muezerie wrote:
> From: Konstantin Ananyev
>
> 1) ../lib/eal/common/eal_common_proc.c:695:15
> : warning: variable length array used
>
> As msg->num_fds should not exceed RTE_MP_MAX_FD_NUM, replaced
> it with fixed size array.
>
> Signed-off-by: Ko
>-Original Message-
>From: Ankur Dwivedi
>Sent: Tuesday, November 5, 2024 12:37 PM
>To: Stephen Hemminger
>Cc: dev@dpdk.org; tho...@monjalon.net; Jerin Jacob
>Subject: RE: [EXTERNAL] Re: [PATCH v6 0/2] devtools: add tracepoint check in
>checkpatch
>
>
>
>>-Original Message-
>>Fr
From: Kishore Padmanabha
The mbuf offload flags were not reset before the flags were
populated with the received packet details. This causes certain
applications to act differently on the offload flags. That can
cause applaction to assert at many locations.
Fixes: 65d2b0557ba3 ("net/bnxt: suppor
On Tue, 19 Nov 2024 19:13:01 -0800
Andre Muezerie wrote:
> From: Tyler Retzlaff
>
> Include alloca.h for Linux and malloc.h for Windows to get declaration
> of alloca().
>
> Signed-off-by: Tyler Retzlaff
> ---
> lib/eal/linux/include/rte_os.h | 1 +
> lib/eal/windows/include/rte_os.h | 1 +
20/11/2024 16:05, Thomas Monjalon:
> 20/11/2024 15:41, Luca Vizzarro:
> > Sphinx-autodoc issues warnings about some symbols due to bad autodoc
> > "automock"ing when optional dependencies are missing.
> >
> > The current meson setup allows to treat warnings as errors, halting the
> > process and e
From: Danylo Vodopianov
The issue with modification of the DSCP field
for IPV4 and IPV6 is fixed by adding
copying the DSCP value to the flow handler.
Fixes: 6fec9a9a12e1 ("net/ntnic: add infrastructure for flow actions and items")
Signed-off-by: Danylo Vodopianov
---
.../nthw/flow_api/profil
From: Oleksandr Kolomeiets
Supplement existing toggle-like macros with respective opposites:
* DISABLE_FRAGMENTATION -> ENABLE_FRAGMENTATION
* IPV4_DF_DROP -> IPV4_DF_FORWARD
* IPV6_DROP -> IPV6_FRAGMENT
Fixes: 6019656d6f68 ("net/ntnic: add MTU configuration")
Signed-off-by
From: Oleksandr Kolomeiets
Move rte_pmd_ntnic.h to drivers/net/ntnic and specify it in meson file.
Fixes: e7e49ce6c760 ("net/ntnic: add flow statistics")
Signed-off-by: Oleksandr Kolomeiets
---
drivers/net/ntnic/meson.build| 3 +++
drivers/net/ntnic/{nthw => }/rte_pmd_ntnic.h
47 matches
Mail list logo
