Re: [PATCH V3 1/7] mailmap: update user name

2024-10-31 Thread Raslan Darawsheh
Hi, From: Minggang(Gavin) Li Sent: Tuesday, October 29, 2024 4:31 PM To: Slava Ovsiienko; Matan Azrad; Ori Kam; NBU-Contact-Thomas Monjalon (EXTERNAL) Cc: dev@dpdk.org; Raslan Darawsheh Subject: [PATCH V3 1/7] mailmap: update user name Signed-off-by: Minggang Li(Gavin) --- .mailmap | 2 +- 1

Re: [PATCH 0/3] net/mlx5: fix mingw link issues

2024-10-31 Thread Raslan Darawsheh
Hi, From: Dariusz Sosnowski Sent: Wednesday, October 30, 2024 12:54 PM To: Raslan Darawsheh; Slava Ovsiienko; Bing Zhao; Ori Kam; Suanming Mou; Matan Azrad Cc: dev@dpdk.org Subject: [PATCH 0/3] net/mlx5: fix mingw link issues This patchset fixes link issues with MinGW which appear in next-net-m

[PATCH] crypto/qat: fix ecdsa session handling

2024-10-31 Thread Arkadiusz Kusztal
Fixed a problem with setting the key in the session in the ECDSA alghoritm. Fixes: badc0c6f6d6a ("cryptodev: set private and public keys in EC session") Cc: sta...@dpdk.org Signed-off-by: Arkadiusz Kusztal --- drivers/crypto/qat/qat_asym.c | 42 +++ 1 file change

[PATCH] crypto/qat: fix an unset length of modexp/inv

2024-10-31 Thread Arkadiusz Kusztal
This commit fixes an unset length in modular algorithms in QAT asymmetric crypto PMD. Fixes: 3b78aa7b2317 ("crypto/qat: refactor asymmetric crypto functions") Cc: sta...@dpdk.org Signed-off-by: Arkadiusz Kusztal --- drivers/crypto/qat/qat_asym.c | 2 ++ 1 file changed, 2 insertions(+) diff --g

RE: [PATCH v6 2/3] crypto/qat: add sm2 encryption/decryption function

2024-10-31 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, October 23, 2024 2:47 AM > To: Kusztal, ArkadiuszX > Cc: dev@dpdk.org; gak...@marvell.com; Dooley, Brian > > Subject: Re: [PATCH v6 2/3] crypto/qat: add sm2 encryption/decryption function > > On Tue, 22 Oct 2024 20:05:

Re: [PATCH v4 1/8] dts: add pydantic dependency

2024-10-31 Thread Nicholas Pratte
Reviewed-by: Nicholas Pratte On Mon, Oct 28, 2024 at 1:51 PM Luca Vizzarro wrote: > > As part of configuration validation and deserialization improvements, > this adds pydantic as a project dependency. Pydantic is a library that > caters to all of the aforementioned needs, while improving the pr

Re: [PATCH v4 2/8] dts: add TestSuiteSpec class and discovery

2024-10-31 Thread Nicholas Pratte
Reviewed-by: Nicholas Pratte On Mon, Oct 28, 2024 at 1:51 PM Luca Vizzarro wrote: > > Currently there is a lack of a definition which identifies all the test > suites available to test. This change intends to simplify the process to > discover all the test suites and idenfity them. > > Signed-of

Re: [PATCH v3 01/18] net/r8169: add PMD driver skeleton

2024-10-31 Thread Stephen Hemminger
On Thu, 31 Oct 2024 07:47:51 + 王颢 wrote: > Dear Stephen, > > I have modified the code related to braces in the latest patch. Recently, I > was reviewing the DPDK Coding Style and found the reason why I initially > removed the redundant braces. If symmetrical braces are required, it would b

[PATCH v1 1/2] app/testpmd: fix flow update

2024-10-31 Thread Danylo Vodopianov
The testpmd command “flow update…“ provides a nullptr as the context variable. Thus "flow aged destroy" command can not execute successfully. Fix was done with next steps 1. Generate new port flow entry to add/replace action(s). 2. Set age contest if exists. 3. Replace flow in the flow list. Fix

[PATCH v1 2/2] app/testpmd: fix flow destroy

2024-10-31 Thread Danylo Vodopianov
Avoid removal of additional flows after requested number of flows has been already removed. Issue with removal of multiple flows is internal testpmd bug at port_flow_destroy(). This function goes through all flows and compares given flow ‘id’ with them. However in some cases it can advance pointer

[PATCH v1 0/2] Testpmd flow update/destroy fixes

2024-10-31 Thread Danylo Vodopianov
These patches provide next fixes: 1. The testpmd command “flow update…“ provides a nullptr as the context variable. 2. Avoid removal of additional flows after requested number of flows has been already removed. Danylo Vodopianov (2): app/testpmd: fix flow up

Re: [PATCH v7] testpmd: add hairpin map parameter

2024-10-31 Thread Stephen Hemminger
On Thu, 31 Oct 2024 06:58:17 +0200 Gregory Etelson wrote: > Hairpin offloads packet forwarding between ports. > Packet is expected on Rx port , Rx queue and is forwarded > to Tx port Tx queue . > > Testpmd implements a static hairpin configuration scheme. > > The new parameter allows explicit

[PATCH 1/1] Cn10K crypto Tests: Added Marvell Cn10K specific crypto Tests to TestCryptoPerfCryptodevPerf

2024-10-31 Thread Gnanesh
Changes included in this patch: -- New TestCases are added for Cn10K CPT Hardware crypto accelerator. -- when Testing newly added Testcases it is found Necessary to make Below Changes 1> tests/cryptodev_common.py --> bind_qat_device function is updated to gener

来自Huichao Cai的邮件

2024-10-31 Thread Huichao Cai
From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB02345C14; Wed, 30 Oct 2024 13:13:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpd

[PATCH v02] net/af_packet: add rollover and defrag options

2024-10-31 Thread Gur Stavi
net_af_packet PMD multi "queue" support relies on Linux FANOUT capability. Linux FANOUT is a SW based load balancer that is similar to HW RSS which is more common for DPDK PMDs. Instead of multiple HW descriptor queues, AF PACKET uses multiple sockets. HW RSS will typically drop a packet if its sel

RE: RFC - Tap io_uring PMD

2024-10-31 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, 30 October 2024 22.57 > > The current tap device is slow both due to architectural choices and > the > overhead of Linux system calls. Yes; but isn't it only being used for (low volume) management traffic? Is the TAP

Re: [PATCH v2] Revert "eal/unix: fix thread creation"

2024-10-31 Thread David Marchand
On Thu, Oct 31, 2024 at 1:58 PM Luca Boccassi wrote: > > On Thu, 31 Oct 2024 at 12:52, David Marchand > wrote: > > > > On Thu, Oct 31, 2024 at 1:47 PM David Marchand > > wrote: > > > Could you share a backtrace when hitting this deadlock? > > > > If the backtrace is not possible, running with >

Re: [PATCH v2] Revert "eal/unix: fix thread creation"

2024-10-31 Thread Luca Boccassi
On Thu, 31 Oct 2024 at 13:04, David Marchand wrote: > > On Thu, Oct 31, 2024 at 1:58 PM Luca Boccassi wrote: > > > > On Thu, 31 Oct 2024 at 12:52, David Marchand > > wrote: > > > > > > On Thu, Oct 31, 2024 at 1:47 PM David Marchand > > > wrote: > > > > Could you share a backtrace when hitting

Re: [PATCH 0/6] reduce number of warnings being disabled

2024-10-31 Thread Bruce Richardson
On Wed, Oct 30, 2024 at 06:17:12PM +, Konstantin Ananyev wrote: > > > > -Original Message- > > From: Bruce Richardson > > Sent: Wednesday, October 30, 2024 5:38 PM > > To: dev@dpdk.org > > Cc: Bruce Richardson > > Subject: [PATCH 0/6] reduce number of warnings being disabled > > >

Re: [PATCH] graph: fix memory leak in node clone

2024-10-31 Thread Huichao Cai
There is one more place in the node_clone function that needs to be modified: if (clone_name(reg->name, node->name, name)) //goto free; goto free_xstat; 从 Windows 版邮件发送

Re: [PATCH v2] Revert "eal/unix: fix thread creation"

2024-10-31 Thread David Marchand
Hello Luca, > > This commit introduced a regression on arm64, causing a deadlock. > lcores_autotest gets stuck and never terminates: > > [ 1077s] EAL: Detected CPU lcores: 4 > [ 1077s] EAL: Detected NUMA nodes: 1 > [ 1077s] EAL: Detected shared linkage of DPDK > [ 1077s] EAL: Multi-process socket

[PATCH v9 3/9] net/zxdh: add zxdh device pci init implementation

2024-10-31 Thread Junlong Wang
Add device pci init implementation, to obtain PCI capability and read configuration, etc. Signed-off-by: Junlong Wang --- drivers/net/zxdh/meson.build | 1 + drivers/net/zxdh/zxdh_ethdev.c | 43 + drivers/net/zxdh/zxdh_ethdev.h | 18 ++- drivers/net/zxdh/zxdh_pci.c| 278 +++

[PATCH v9 5/9] net/zxdh: add msg chan enable implementation

2024-10-31 Thread Junlong Wang
Add msg chan enable implementation to support send msg to backend(device side) get infos. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 6 + drivers/net/zxdh/zxdh_ethdev.h | 12 + drivers/net/zxdh/zxdh_msg.c| 647 - drivers/net/zxdh/zxdh_

[PATCH v9 0/9] net/zxdh: introduce net zxdh driver

2024-10-31 Thread Junlong Wang
v9: - fix 'v8 3/9' patch use PCI bus API, and common PCI constants according to David Marchand's comments. v8: - fix flexible arrays、Waddress-of-packed-member error. - all structs、enum、define ,etc use zxdh/ZXDH_ prefixed. - use zxdh_try/release_lock,and move loop into zxdh_timedlock,

[PATCH v9 1/9] net/zxdh: add zxdh ethdev pmd driver

2024-10-31 Thread Junlong Wang
Add basic zxdh ethdev init and register PCI probe functions Update doc files. Signed-off-by: Junlong Wang --- MAINTAINERS| 6 ++ doc/guides/nics/features/zxdh.ini | 9 +++ doc/guides/nics/index.rst | 1 + doc/guides/nics/zxdh.rst | 3

[PATCH v9 8/9] net/zxdh: add zxdh dev infos get ops

2024-10-31 Thread Junlong Wang
Add support for zxdh infos get. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 44 +- drivers/net/zxdh/zxdh_ethdev.h | 2 ++ 2 files changed, 45 insertions(+), 1 deletion(-) diff --git a/drivers/net/zxdh/zxdh_ethdev.c b/drivers/net/zxdh/zxdh_et

[PATCH v9 7/9] net/zxdh: add configure zxdh intr implementation

2024-10-31 Thread Junlong Wang
configure zxdh intr include risc,dtb. and release intr. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 301 + drivers/net/zxdh/zxdh_ethdev.h | 6 + drivers/net/zxdh/zxdh_msg.c| 188 drivers/net/zxdh/zxdh_msg.h| 16

[PATCH v9 6/9] net/zxdh: add zxdh get device backend infos

2024-10-31 Thread Junlong Wang
Add zxdh get device backend infos, use msg chan to send msg get. Signed-off-by: Junlong Wang --- drivers/net/zxdh/meson.build | 1 + drivers/net/zxdh/zxdh_common.c | 250 + drivers/net/zxdh/zxdh_common.h | 30 drivers/net/zxdh/zxdh_ethdev.c | 35 +

[PATCH v9 4/9] net/zxdh: add msg chan and msg hwlock init

2024-10-31 Thread Junlong Wang
Add msg channel and hwlock init implementation. Signed-off-by: Junlong Wang --- drivers/net/zxdh/meson.build | 1 + drivers/net/zxdh/zxdh_ethdev.c | 15 +++ drivers/net/zxdh/zxdh_ethdev.h | 1 + drivers/net/zxdh/zxdh_msg.c| 161 + drivers/net/zxdh/zxdh_

[PATCH v9 2/9] net/zxdh: add logging implementation

2024-10-31 Thread Junlong Wang
Add zxdh logging implementation. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 15 +++-- drivers/net/zxdh/zxdh_logs.h | 40 ++ 2 files changed, 53 insertions(+), 2 deletions(-) create mode 100644 drivers/net/zxdh/zxdh_logs.h diff --g

Re: [PATCH V3 3/7] net/mlx5: add new devargs to control probe optimization

2024-10-31 Thread Thomas Monjalon
29/10/2024 17:20, Stephen Hemminger: > On Tue, 29 Oct 2024 15:42:52 +0200 > "Minggang Li(Gavin)" wrote: > > > From: Rongwei Liu > > > > Add a new devarg probe_opt_en to control probe optimization > > in PMD. > > > > By default, the value is 0 and no behavior changed. > > > > Signed-off-by: Ro

Re: [PATCH v4 3/8] dts: refactor build and node info classes

2024-10-31 Thread Nicholas Pratte
It took me a second to appreciate what the goal of separating this is, but it makes complete sense to me now. This was an oversight on my end as well when I was working on the config changes in once of the patches I was assigned. Interestingly enough, I ran into a similar problem with circular depe

Re: [PATCH v2] net/vmxnet3: support per-queue stats for fewer queues

2024-10-31 Thread Ferruh Yigit
On 10/25/2024 10:27 AM, Morten Brørup wrote: > Removed the requirement that the configured number of queues to provide > statistics for (RTE_ETHDEV_QUEUE_STAT_CNTRS) cannot be less than the > driver's max number of supported transmit queues (VMXNET3_MAX_TX_QUEUES). > > Also improved support for vi

Re: RFC - Tap io_uring PMD

2024-10-31 Thread Stephen Hemminger
On Thu, 31 Oct 2024 11:27:25 +0100 Morten Brørup wrote: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Wednesday, 30 October 2024 22.57 > > > > The current tap device is slow both due to architectural choices and > > the > > overhead of Linux system calls. > > Yes;

Re: [PATCH v4 4/8] dts: use pydantic in the configuration

2024-10-31 Thread Nicholas Pratte
Reviewed-by: Nicholas Pratte On Mon, Oct 28, 2024 at 1:51 PM Luca Vizzarro wrote: > > This change brings in pydantic in place of warlock. Pydantic offers > a built-in model validation system in the classes, which allows for > a more resilient and simpler code. As a consequence of this change: >

Re: [PATCH v4 6/8] dts: add autodoc pydantic

2024-10-31 Thread Nicholas Pratte
Definitely a set in the right direction here! Just a small typo, but otherwise: Reviewed-by: Nicholas Pratte > --- a/doc/guides/tools/dts.rst > +++ b/doc/guides/tools/dts.rst > @@ -204,9 +204,10 @@ node, and then run the tests with the newly built > binaries. > Configuring DTS >

RE: [PATCH v2 07/13] net/txgbe: add Tx descriptor error statistics

2024-10-31 Thread Jiawen Wu
> > @@ -4980,6 +4982,7 @@ txgbe_tx_queue_clear_error(void *param) > > if (!txq->resetting) > > continue; > > > > + txq->desc_error++; > > > > Why error value is increased in this function, which resets the Tx queue? > Is the intention to reset the error va

Re: [PATCH v4 0/7] refactor kvargs test

2024-10-31 Thread lihuisong (C)
For this series, Acked-by: Huisong Li 在 2024/10/30 16:54, Chengwen Feng 写道: When developing patchset [1], I found the kvargs test is hard to understand when tried to add some testcase. So refactor kvargs by: 1. introduce UT suite framework. 2. extract big test_valid_kvargs() to five part. 3. ad

Re: [PATCH v2 07/13] net/txgbe: add Tx descriptor error statistics

2024-10-31 Thread Ferruh Yigit
On 11/1/2024 2:06 AM, Jiawen Wu wrote: >>> @@ -4980,6 +4982,7 @@ txgbe_tx_queue_clear_error(void *param) >>> if (!txq->resetting) >>> continue; >>> >>> + txq->desc_error++; >>> >> >> Why error value is increased in this function, which resets the Tx queue?

Re: [PATCH v2 06/13] net/txgbe: check length of Tx packets

2024-10-31 Thread Ferruh Yigit
On 11/1/2024 1:52 AM, Jiawen Wu wrote: > On Fri, Nov 1, 2024 9:23 AM, Ferruh Yigit wrote: >> On 10/28/2024 2:31 AM, Jiawen Wu wrote: >>> Add checking of the Tx packet length to avoid TDM fatal error as far as >>> possible. Set the pkt_len=1518 for invalid packet in simple Tx code path, >>> and drop

Re: [PATCH v7] testpmd: add hairpin map parameter

2024-10-31 Thread Ferruh Yigit
On 10/31/2024 3:51 PM, Stephen Hemminger wrote: > On Thu, 31 Oct 2024 06:58:17 +0200 > Gregory Etelson wrote: > >> Hairpin offloads packet forwarding between ports. >> Packet is expected on Rx port , Rx queue and is forwarded >> to Tx port Tx queue . >> >> Testpmd implements a static hairpin co

Re: [PATCH v2 06/13] net/txgbe: check length of Tx packets

2024-10-31 Thread Stephen Hemminger
On Fri, 1 Nov 2024 01:22:47 + Ferruh Yigit wrote: > Hi Jiawen, > > Above are generic checks, we may add this function to ethdev driver > header (ethdev_driver.h) so that any PMD can use it, what do you think? This is in the fastpath, and additional checks should not be added there. Or at le

[PATCH v3 1/4] net/nfp: fix port index problem

2024-10-31 Thread Chaoyong He
Fix one port index problem imported by mistake. Fixes: 97b6825d9a7b ("net/nfp: extract function to allocate PHY") Fixes: fd1ec7bc8f0a ("net/nfp: extract function to initialize PF") Fixes: bb9f9fdcbe00 ("net/nfp: extract function to allocate PF") Fixes: c8e29c168c20 ("net/nfp: extract function to a

[PATCH v3 2/4] net/nfp: extract function to check physical reprsentor

2024-10-31 Thread Chaoyong He
Extract a helper function to check the physical representor port. Signed-off-by: Chaoyong He --- .../net/nfp/flower/nfp_flower_representor.c| 18 -- .../net/nfp/flower/nfp_flower_representor.h| 1 + 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/

[PATCH v3 3/4] net/nfp: add support for EEPROM functions

2024-10-31 Thread Chaoyong He
Add support for the following EEPROM function callbacks: .get_eeprom_len Get the maximum size of the device EEPROM data. .get_eeprom Get the device EEPROM data at a certain offset and length. .set_eeprom Set the device EEPROM data at a certain offset and length. Note that for an nfp NIC, the "d

[PATCH v3 0/4] NFP PMD enhancement

2024-10-31 Thread Chaoyong He
This patch series fix one problem imported by mistake and add support of two new APIs. --- v3: * Adapt to the multiple PF firmware. v2: * add one missing commit. --- Chaoyong He (4): net/nfp: fix port index problem net/nfp: extract function to check physical reprsentor net/nfp: add support

RE: [PATCH v2 07/13] net/txgbe: add Tx descriptor error statistics

2024-10-31 Thread Jiawen Wu
> -Original Message- > From: Ferruh Yigit > Sent: Friday, November 1, 2024 10:46 AM > To: Jiawen Wu ; dev@dpdk.org > Subject: Re: [PATCH v2 07/13] net/txgbe: add Tx descriptor error statistics > > On 11/1/2024 2:06 AM, Jiawen Wu wrote: > >>> @@ -4980,6 +4982,7 @@ txgbe_tx_queue_clear_e

[PATCH v3 4/4] net/nfp: add support for port identify

2024-10-31 Thread Chaoyong He
Implement the necessary functions to allow user to visually identify a physical port associated with a netdev by blinking an LED on that port. Signed-off-by: James Hershaw Signed-off-by: Chaoyong He --- .../net/nfp/flower/nfp_flower_representor.c | 30 drivers/net/nfp/nfp_eth

Re: [PATCH v2] Revert "eal/unix: fix thread creation"

2024-10-31 Thread Stephen Hemminger
On Thu, 31 Oct 2024 14:05:16 + Luca Boccassi wrote: > On Thu, 31 Oct 2024 at 13:04, David Marchand > wrote: > > > > On Thu, Oct 31, 2024 at 1:58 PM Luca Boccassi > > wrote: > > > > > > On Thu, 31 Oct 2024 at 12:52, David Marchand > > > wrote: > > > > > > > > On Thu, Oct 31, 2024 at

Re: [PATCH] net/hns3: remove roh devices

2024-10-31 Thread Ferruh Yigit
On 10/31/2024 6:30 AM, Jie Hai wrote: > On 2024/10/26 14:38, Jie Hai wrote: >> From: Dengdui Huang >> >> The devices added in commit 3f1436d7006c ("net/hns3: support new device") >> is no longer available, so revert it. >> >> Fixes: 3f1436d7006c ("net/hns3: support new device") >> Cc: sta...@dpdk.

Re: [PATCH v3 1/4] net/nfp: fix port index problem

2024-10-31 Thread Stephen Hemminger
On Fri, 1 Nov 2024 10:57:10 +0800 Chaoyong He wrote: > @@ -1022,6 +1025,7 @@ nfp_flower_pf_repr_alloc(struct nfp_net_hw_priv > *hw_priv, > > /* Create a rte_eth_dev for PF vNIC representor */ > flower_repr->repr_type = NFP_REPR_TYPE_PF; > + flower_repr->idx = 0; That initiali

答复: [PATCH v3 01/18] net/r8169: add PMD driver skeleton

2024-10-31 Thread 王颢
Dear Stephen, I have modified the code related to braces in the latest patch. Recently, I was reviewing the DPDK Coding Style and found the reason why I initially removed the redundant braces. If symmetrical braces are required, it would be better to update the DPDK Coding Style accordingly. i

[PATCH v2] doc: add mlx5 xstats send scheduling counters description

2024-10-31 Thread Viacheslav Ovsiienko
The mlx5 provides the scheduling send on time capability. To check the operating status of this feature the extended statistics counters are provided. This patch adds the counter descriptions and provides some meaningful information how to interpret the counter values in runtime. Signed-off-by: Vi

RE: [PATCH 1/1] net/ena: add histogram support

2024-10-31 Thread Brandes, Shai
> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, October 29, 2024 6:23 PM > To: Brandes, Shai > Cc: ferruh.yi...@amd.com; dev@dpdk.org; Bernstein, Amit > > Subject: RE: [EXTERNAL] [PATCH 1/1] net/ena: add histogram support > > CAUTION: This email originated from outsid

Re: [PATCH v2] Revert "eal/unix: fix thread creation"

2024-10-31 Thread David Marchand
On Thu, Oct 31, 2024 at 1:47 PM David Marchand wrote: > Could you share a backtrace when hitting this deadlock? If the backtrace is not possible, running with --log-level=lib.eal:debug may help. -- David Marchand

RE: [PATCH 0/1] net/ena: adding a histogram framework to 2.11.0

2024-10-31 Thread Brandes, Shai
> -Original Message- > From: Morten Brørup > Sent: Tuesday, October 29, 2024 10:55 AM > To: Brandes, Shai ; ferruh.yi...@amd.com > Cc: dev@dpdk.org > Subject: RE: [EXTERNAL] [PATCH 0/1] net/ena: adding a histogram framework > to 2.11.0 > > CAUTION: This email originated from outside of

Re: [PATCH v2] Revert "eal/unix: fix thread creation"

2024-10-31 Thread Luca Boccassi
On Thu, 31 Oct 2024 at 12:52, David Marchand wrote: > > On Thu, Oct 31, 2024 at 1:47 PM David Marchand > wrote: > > Could you share a backtrace when hitting this deadlock? > > If the backtrace is not possible, running with > --log-level=lib.eal:debug may help. I cannot get backtraces. This runs

Re: [PATCH v2 06/13] net/txgbe: check length of Tx packets

2024-10-31 Thread Ferruh Yigit
On 10/28/2024 2:31 AM, Jiawen Wu wrote: > Add checking of the Tx packet length to avoid TDM fatal error as far as > possible. Set the pkt_len=1518 for invalid packet in simple Tx code path, > and drop it directly in featured Tx code path. > > Signed-off-by: Jiawen Wu > --- > drivers/net/txgbe/tx

Re: [PATCH] graph: fix memory leak in node clone

2024-10-31 Thread Huichao cai
There is one more place in the node_clone function that needs to be modified: if (clone_name(reg->name, node->name, name)) //goto free; goto free_xstat;

Re: [PATCH v2 07/13] net/txgbe: add Tx descriptor error statistics

2024-10-31 Thread Ferruh Yigit
On 10/28/2024 2:31 AM, Jiawen Wu wrote: > Count the number of packets not sent due to Tx descriptor error. > > Signed-off-by: Jiawen Wu > --- > drivers/net/txgbe/txgbe_ethdev.c | 6 ++ > drivers/net/txgbe/txgbe_rxtx.c | 3 +++ > drivers/net/txgbe/txgbe_rxtx.h | 1 + > 3 files changed, 10

[RFC] kvargs: add free attribute annotation

2024-10-31 Thread Stephen Hemminger
Pointers created from parsing kvargs must be freed via rte_kvargs_free. Use compiler attributes to catch misuse. Signed-off-by: Stephen Hemminger --- lib/kvargs/rte_kvargs.c | 10 -- lib/kvargs/rte_kvargs.h | 40 2 files changed, 32 insertions(+),

Re: [PATCH v4 5/8] dts: remove warlock dependency

2024-10-31 Thread Nicholas Pratte
Reviewed-by: Nicholas Pratte On Mon, Oct 28, 2024 at 1:51 PM Luca Vizzarro wrote: > > Since pydantic has completely replaced warlock, there is no more need to > keep it as a dependency. This removes it. > > Signed-off-by: Luca Vizzarro > Reviewed-by: Paul Szczepanek > --- > dts/poetry.lock

Re: [PATCH v4 2/8] dts: add TestSuiteSpec class and discovery

2024-10-31 Thread Nicholas Pratte
On Mon, Oct 28, 2024 at 1:51 PM Luca Vizzarro wrote: > > Currently there is a lack of a definition which identifies all the test > suites available to test. This change intends to simplify the process to > discover all the test suites and idenfity them. Noticed this in the corner of my eye. 'iden

RE: [PATCH v2 06/13] net/txgbe: check length of Tx packets

2024-10-31 Thread Jiawen Wu
On Fri, Nov 1, 2024 9:23 AM, Ferruh Yigit wrote: > On 10/28/2024 2:31 AM, Jiawen Wu wrote: > > Add checking of the Tx packet length to avoid TDM fatal error as far as > > possible. Set the pkt_len=1518 for invalid packet in simple Tx code path, > > and drop it directly in featured Tx code path. > >