Hi,
I'm not sure about the proper way to do a code review here, feel free to
educate me if there is a better way to do it. I couldn't find the actual
patches text in the mail and patchwork has no interface to write comments
on the line itself but I may very well have missed something.
https://pat
This patchset refactors the power management library, addressing both
core and uncore power management. The primary changes involve the
creation of dedicated directories for each driver within
'drivers/power/core/*' and 'drivers/power/uncore/*'.
This refactor significantly improves code organizati
This patch introduces a comprehensive refactor to the core power
management library. The primary focus is on improving modularity
and organization by relocating specific driver implementations
from the 'lib/power' directory to dedicated directories within
'drivers/power/core/*'. The adjustment of m
Update maintainers for drivers/power/*.
Signed-off-by: Sivaprasad Tummala
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 6ea7850093..7e29931be9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1744,6 +1744,7 @@ M: Anatoly Burakov
M: David Hunt
iThis patch refactors the power management library, addressing uncore
power management. The primary changes involve the creation of dedicated
directories for each driver within 'drivers/power/uncore/*'. The
adjustment of meson.build files enables the selective activation
of individual drivers.
Thi
This patch introduces driver support for power management of uncore
components in AMD EPYC processors.
v2:
- fixed typo in comments section.
- added fabric frequency get support for legacy platforms.
Signed-off-by: Sivaprasad Tummala
---
drivers/power/amd_uncore/amd_uncore.c | 329 +++
This patchset refactors the power management library, addressing both
core and uncore power management. The primary changes involve the
creation of dedicated directories for each driver within
'drivers/power/core/*' and 'drivers/power/uncore/*'.
This refactor significantly improves code organizati
After refactoring the power library, power management operations are now
consistently supported regardless of the operating environment, making
function pointer checks unnecessary and thus removed from applications.
v2:
- removed function pointer validation in l3fwd-power app.
Signed-off-by: Siv
> From: Vignesh PS
>
> Add support to bonding PMD to allow user callback function registration for
> TX transmit policy.
>
> Signed-off-by: Vignesh PS
> ---
> .mailmap| 1 +
> drivers/net/bonding/eth_bond_private.h | 6 ++
> drivers/net/bonding/rte_eth_bo
From: Peng Zhang
Extract the helper function to allocate the PHY representor port.
Signed-off-by: Peng Zhang
Reviewed-by: Chaoyong He
Reviewed-by: Long Wu
---
.../net/nfp/flower/nfp_flower_representor.c | 86 ---
1 file changed, 53 insertions(+), 33 deletions(-)
diff --git
This patch series add support of the multiple PF flower firmware.
Peng Zhang (9):
net/nfp: extract the function to allocate the PHY
net/nfp: extract the function to initialize the PF
net/nfp: extract the function to allocate PF
net/nfp: extract the function to allocate the VF
net/nfp: re
From: Peng Zhang
Extract the helper function to allocate the VF representor ports.
Signed-off-by: Peng Zhang
Reviewed-by: Chaoyong He
Reviewed-by: Long Wu
---
.../net/nfp/flower/nfp_flower_representor.c | 85 +++
1 file changed, 49 insertions(+), 36 deletions(-)
diff --git
From: Peng Zhang
Extract the helper function to initialize the basic information
of the PF representor port.
The logic of check VF is updated because of changing the order
of some logics in the initialization function.
Signed-off-by: Peng Zhang
Reviewed-by: Chaoyong He
Reviewed-by: Long Wu
-
From: Peng Zhang
When using the multiple PF firmware, there is no PF representor port,
so we also need not care about the corresponding control messages anymore.
Signed-off-by: Peng Zhang
Reviewed-by: Chaoyong He
Reviewed-by: Long Wu
---
drivers/net/nfp/flower/nfp_flower_ctrl.c | 10 +++-
From: Peng Zhang
Extract the helper function to allocate the PF representor port.
Signed-off-by: Peng Zhang
Reviewed-by: Chaoyong He
Reviewed-by: Long Wu
---
.../net/nfp/flower/nfp_flower_representor.c | 58 ---
1 file changed, 38 insertions(+), 20 deletions(-)
diff --git
From: Peng Zhang
When using the multiple PF firmware, there is no need to
create the PF representor port anymore.
Signed-off-by: Peng Zhang
Reviewed-by: Chaoyong He
Reviewed-by: Long Wu
---
drivers/net/nfp/flower/nfp_flower_representor.c | 12 +---
1 file changed, 9 insertions(+), 3
From: Peng Zhang
When using multiple PF firmware, add the process of initialize
the representor port and revise the corresponding logic in the
close function.
Signed-off-by: Peng Zhang
Reviewed-by: Chaoyong He
Reviewed-by: Long Wu
---
.../net/nfp/flower/nfp_flower_representor.c | 80 ++
From: Peng Zhang
Update the Tx function and Rx function for multiple PF and simplify the
Rx function to enhance the performance.
In the RX function, the packets are processed according the firmware type.
Signed-off-by: Peng Zhang
Reviewed-by: Chaoyong He
Reviewed-by: Long Wu
---
drivers/net/
From: Peng Zhang
When using the multiple PF firmware, add the new
operations and update the port start and stop
function.
Signed-off-by: Peng Zhang
Reviewed-by: Chaoyong He
Reviewed-by: Long Wu
---
drivers/net/nfp/flower/nfp_flower.c | 21
drivers/net/nfp/flower/nfp_fl
The patch fixes variable type in case of data trunction.
Fixes: dd4b8bba785f ("net/hns3: support reporting names of registers")
Cc: sta...@dpdk.org
Signed-off-by: Jie Hai
---
drivers/net/hns3/hns3_regs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/hns3/hn
Here is the updated RFC
https://inbox.dpdk.org/dev/20241021015246.304431-1-wathsala.vithan...@arm.com/#t
Thanks
--wathsal
>
> Subject: DPDK - PCIe Steering Tags Meeting on 10/23/24
>
> Hi all,
>
> This is an invitation to discuss adding PCIe steering tags support to DPDK.
> We have had brief
> On Fri, 18 Oct 2024 05:50:20 +
> Chaoyong He wrote:
>
> > > On Fri, 18 Oct 2024 03:21:28 +
> > > Chaoyong He wrote:
> > >
> > > > > RTE_PKTMBUF_HEADROOM); }
> > > > > > +
> > > > >
> > > > > Not sure why this is needed? What is the problem with the original
> code?
> > > > > Are you tr
On Sat, 19 Oct 2024 19:42:03 -0700
Jie Liu wrote:
> Adding a minimum maintainable directory structure for the
> network driver and request maintenance of the sxe driver.
>
> Signed-off-by: Jie Liu
Even the minimum version patch has to compile cleanly, this one doesn't.
Please fix and resubmit
On Sun, 20 Oct 2024 09:22:29 +
Sivaprasad Tummala wrote:
> diff --git a/lib/power/rte_power_uncore.c b/lib/power/rte_power_uncore.c
> index 48c75a5da0..f11238cc34 100644
> --- a/lib/power/rte_power_uncore.c
> +++ b/lib/power/rte_power_uncore.c
> @@ -10,100 +10,53 @@
>
> #include "power_com
On Sun, 20 Oct 2024 09:22:29 +
Sivaprasad Tummala wrote:
> +uint32_t
> +rte_power_get_uncore_freq(unsigned int pkg, unsigned int die)
> +{
> + RTE_ASSERT(global_uncore_ops != NULL);
All these RTE_ASSERT calls seem like a good idea, they really don't help.
If RTE_ASSERT fails it prints a
On 2024/10/19 0:41, Stephen Hemminger wrote:
> On Fri, 18 Oct 2024 14:19:41 +0800
> Jie Hai wrote:
>
>> @@ -306,11 +324,16 @@ hns3_parse_devargs(struct rte_eth_dev *dev)
>> &hns3_parse_dev_caps_mask, &dev_caps_mask);
>> (void)rte_kvargs_process(kvlist, HNS3_DEVARG_MBX
Extend the PCI driver and the library to extract the Steering Tag (ST)
for a given Processor/Processor Container and Cache ID pair and validate
a Processing Hint from a TPH _DSM associated with a root port device.
The rte_pci_device structure passed into the rte_pci_extract_tph_st()
function could
Extend the ethdev library to enable the stashing of different data
objects, such as the ones listed below, into CPU caches directly
from the NIC.
- Rx/Tx queue descriptors
- Rx packets
- Packet headers
- packet payloads
- Data of a packet at an offset from the start of the packet
The APIs are des
DPDK applications benefit from Direct Cache Access (DCA) features like
Intel DDIO and Arm's write-allocate-to-SLC. However, those features do
not allow fine-grained control of direct cache access, such as stashing
packets into upper-level caches (L2 caches) of a processor or the shared
cache of a c
From: Satheesh Paul
ROC changes to support NPC flow on cn20k.
Signed-off-by: Satheesh Paul
Reviewed-by: Kiran Kumar K
---
drivers/common/cnxk/roc_mbox.h | 144 +-
drivers/common/cnxk/roc_nix.h | 18 +-
drivers/common/cnxk/roc_nix_mcast.c | 40 +-
drivers/common/cn
From: Satheesh Paul
Support for rte flow in cn20k.
Signed-off-by: Satheesh Paul
Reviewed-by: Kiran Kumar K
---
drivers/net/cnxk/cn10k_ethdev.c| 8 +-
drivers/net/cnxk/cn10k_flow.h | 21 --
drivers/net/cnxk/cn20k_ethdev.c| 4 +
drivers/net/cnxk/cnxk_ethdev_devargs
This patch introduces driver support for power management of uncore
components in AMD EPYC processors.
v2:
- fixed typo in comments section.
- added fabric frequency get support for legacy platforms.
Signed-off-by: Sivaprasad Tummala
---
drivers/power/amd_uncore/amd_uncore.c | 329 +++
This patch introduces a comprehensive refactor to the core power
management library. The primary focus is on improving modularity
and organization by relocating specific driver implementations
from the 'lib/power' directory to dedicated directories within
'drivers/power/core/*'. The adjustment of m
This patchset refactors the power management library, addressing both
core and uncore power management. The primary changes involve the
creation of dedicated directories for each driver within
'drivers/power/core/*' and 'drivers/power/uncore/*'.
This refactor significantly improves code organizati
iThis patch refactors the power management library, addressing uncore
power management. The primary changes involve the creation of dedicated
directories for each driver within 'drivers/power/uncore/*'. The
adjustment of meson.build files enables the selective activation
of individual drivers.
Thi
This patchset refactors the power management library, addressing both
core and uncore power management. The primary changes involve the
creation of dedicated directories for each driver within
'drivers/power/core/*' and 'drivers/power/uncore/*'.
This refactor significantly improves code organizati
Update maintainers for drivers/power/*.
Signed-off-by: Sivaprasad Tummala
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 6ea7850093..7e29931be9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1744,6 +1744,7 @@ M: Anatoly Burakov
M: David Hunt
After refactoring the power library, power management operations are now
consistently supported regardless of the operating environment, making
function pointer checks unnecessary and thus removed from applications.
v2:
- removed function pointer validation in l3fwd-power app.
Signed-off-by: Siv
This email address is bouncing, remove it from MAINTAINERS.
Signed-off-by: Jie Hai
---
MAINTAINERS | 1 -
1 file changed, 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 6ea785009341..cd78bc7db172 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -750,7 +750,6 @@ F: doc/guides/nics/featu
39 matches
Mail list logo
