On 9/18/2024 10:21 AM, Dariusz Sosnowski wrote:
> Hi all,
>
> We have been working on optimizing the latency of calls to
> rte_eth_dev_start(),
> on ports spawned by mlx5 PMD. Most of the work requires changes in the
> implementation of
> .dev_start() PMD callback, but I also wanted to start a d
The previous version of statistics store only the last test run
attribute and result. In this patch we are adding header for each
test run and overall summary of test runs at the end. This is
represented as textual summaries with basic information and json
result with more detailed information.
Si
Dear technical team:
I hope this email finds you well.i am Gary huang from China.i am reaching out
to you to seek guidance on some technical matters.
Here are some questions i would like to address:
In the virtio_pci.c file,a del_vq interface is provided for modern device which
is call modern_d
On 9/29/24 18:34, Stephen Hemminger wrote:
If compiler detection of use-after-free is enabled then this drivers
debug messages will cause warnings. Change to move debug message
before the object is freed.
Bugzilla ID: 1551
Fixes: 55c1238246d5 ("net/sfc: add more debug messages to transfer flows"
On 9/18/2024 3:38 AM, Chaoyong He wrote:
> From: James Hershaw
>
> There is currently no means to test the .set_eeprom function callback of
> a given PMD in drivers/net/. This patch adds functionality to allow a
> user to set device eeprom from the testpmd cmdline.
>
> Usage:
> testpmd> set po
On Sun, 29 Sep 2024 23:05:05 +0800
Hanxiao Li wrote:
> This patch adds documents and release notes
> about compressdev and cryptodev.
>
> Signed-off-by: Hanxiao Li
> ---
> doc/guides/compressdevs/features/zsda.ini | 15 ++
> doc/guides/compressdevs/index.rst | 1 +
> doc/guides/comp
On 9/18/2024 3:38 AM, Chaoyong He wrote:
> From: James Hershaw
>
> Add command to change the state of a controllable LED on an ethdev port
> to on/off. This is for the purpose of identifying which physical port is
> associated with an ethdev.
>
> Usage:
> testpmd> set port led
>
> Signed-of
On 9/17/2024 12:51 PM, Isaac Boukris wrote:
> Normally, the MAC address of the kernel interface is the same as in the
> interface in dpdk, as they represent the same interface. It is useful
> to allow viewing them as separate connected interfaces (like ip's veth).
>
> This solves a problem I have
This patch adds documents and release notes
about compressdev and cryptodev.
This patch is used to replace
https://patches.dpdk.org/project/dpdk/patch/20240927131000.738277-8-li.hanx...@zte.com.cn/
Signed-off-by: Hanxiao Li
---
doc/guides/compressdevs/features/zsda.ini | 15 ++
doc/guides/comp
If compiler detection of use-after-free is enabled then this drivers
debug messages will cause warnings. Change to move debug message
before the object is freed.
Bugzilla ID: 1551
Fixes: 55c1238246d5 ("net/sfc: add more debug messages to transfer flows")
Signed-off-by: Stephen Hemminger
Reviewed-
With proper annotation, GCC discovers that this driver is
calling rte_free() on an object that was not allocated
(it is part of array in another object).
In function ‘cpfl_flow_js_mr_layout’,
inlined from ‘cpfl_flow_js_mr_action’ at
../drivers/net/cpfl/cpfl_flow_parser.c:848:9,
inlined fr
The pointer bdev is allocated with rte_zmalloc() and then
incorrectly freed with free() which will lead pool corruption.
Bugzilla ID: 1553
Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample")
Cc: jin...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Stephen Hemminger
---
exa
The code to cleanup in case of error was passing incorrect
value to rte_free. The ports[] entry was allocated with
rte_malloc and that should be used instead of the offset
in that object.
Fixes: 97a05c1fe634 ("event/cnxk: add port config")
Cc: sthot...@marvell.com
Cc: sta...@dpdk.org
Signed-off-b
If conversion of cBF to eBPF fails then an object allocated with
rte_malloc() would be passed to free().
[908/3201] Compiling C object lib/librte_bpf.a.p/bpf_bpf_convert.c.o
../lib/bpf/bpf_convert.c: In function ‘rte_bpf_convert’:
../lib/bpf/bpf_convert.c:559:17: warning: ‘free’ called on pointer
The driver cleanup code was freeing the filter object
then dereferencing it.
Bugzilla ID: 1550
Fixes: 6a4d050e2855 ("net/igb: flush all the filter")
Cc: wei.zh...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Stephen Hemminger
---
drivers/net/e1000/igb_ethdev.c | 4 ++--
1 file changed, 2 insert
The driver would refer to the mempool object after it was freed.
Bugzilla ID: 1554
Fixes: 7ea187184a51 ("common/cnxk: support 1-N pool-aura per NIX LF")
Cc: rbhans...@marvell.com
Cc: sta...@dpdk.org
Signed-off-by: Stephen Hemminger
---
drivers/net/cnxk/cnxk_ethdev_sec.c | 2 +-
1 file changed,
The data structure is allocated with rte_malloc and incorrectly
freed in cleanup logic using free.
Bugzilla ID: 1549
Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe")
Cc: kevin.la...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Stephen Hemminger
---
drivers/dma/idxd/idxd_pc
Recent versions of Gcc have some additonal function attributes that can
help with DPDK performance and stability.
The alloc_align attribute tells the compiler what the alignment
of the allocation will be, and the optimizer can use this to produce
better code (especially memcpy and structure copies
Using the freed value for tracing is not a good idea.
Although it is harmless for tracing, it will cause analyzers to flag
this as unsafe.
Signed-off-by: Stephen Hemminger
---
lib/eal/common/eal_common_memzone.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/eal/common
The device structure is allocated with rte_malloc() and then
incorrectly freed with free(). This will lead to corrupt malloc pool.
Bugzilla ID: 1552
Fixes: c8e79da7c676 ("crypto/bcmfs: introduce BCMFS driver")
Cc: vikas.gu...@broadcom.com
Cc: sta...@dpdk.org
Signed-off-by: Stephen Hemminger
---
The macro in this driver was redefining LIST_FOR_EACH_ENTRY_SAFE
as a simple LIST_FOR_EACH macro. But they are not the same
the _SAFE variant guarantees that there will not be use after free.
One other place was using LIST_FOR_EACH_ENTRY_SAFE() incorrectly.
Fixes: fb4ac04e9bfa ("common/idpf: intr
Use the GCC function attribute to detect cases where
memory is allocated with rte_malloc and freed incorrectly
with libc version of free (and vice versa). Also will detect
some other pointer mismatches.
Signed-off-by: Stephen Hemminger
---
doc/guides/rel_notes/release_24_11.rst | 8
lib/ea
The allocation functions take a alignment argument that
can be useful to hint the compiler optimizer.
This is supported by Gcc and Clang but only useful with
Gcc because Clang gives warning if alignment is 0.
Recent versions of GCC have a malloc attribute that can
be used to find mismatches betwe
Checking return value of rte_memzone_free() is pointless
and if it failed then it was because the pointer was null.
Fixes: 7b1374b1e6e7 ("common/qat: limit configuration to primary process")
Cc: arkadiuszx.kusz...@intel.com
Signed-off-by: Stephen Hemminger
---
drivers/common/qat/qat_device.c |
The TAILQ_FOREACH() macro would refer to info after it
had been freed. Fix by introducing TAILQ_FOREACH_SAFE here.
Fixes: 4a19f89104f8 ("raw/ifpga/base: support multiple cards")
Cc: tianfei.zh...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Stephen Hemminger
---
drivers/raw/ifpga/base/opae_inte
The raw ifpga driver redefines malloc to be opae_malloc
and free to be opae_free; which is a bad idea.
This leads to case where interrupt efd array is allocated
with calloc() and then passed to rte_free. The workaround
is to allocate the array with rte_calloc() instead.
Fixes: d61138d4f0e2 ("driv
It is possible that the info pointer (hp) could get freed twice.
Fix by nulling after free.
In function 'setup_la12xx_dev',
inlined from 'la12xx_bbdev_create' at
../drivers/baseband/la12xx/bbdev_la12xx.c:1029:8,
inlined from 'la12xx_bbdev_probe' at
../drivers/baseband/la12xx/bbdev_la12xx.c:1075:
Calling rte_free twice on same object will corrupt the heap.
Warning is:
In function 'nfp_pre_tun_table_check_del',
inlined from 'nfp_flow_destroy' at
../drivers/net/nfp/flower/nfp_flower_flow.c:5143:9:
../drivers/net/nfp/flower/nfp_flower_flow.c:3830:9: error: pointer 'entry' used
after 'rte_fre
From: Pavan Nikhilesh
Unregister SSO device and NPA IRQs before resizing
IRQs to cleanup stale IRQ handles.
Fixes: 993107f0f440 ("common/cnxk: limit SSO interrupt allocation count")
Cc: sta...@dpdk.org
Signed-off-by: Pavan Nikhilesh
---
v2 Changes:
- Reorder npa interrupt un-registration.
v3 C
Introduce common function and log macro for ZSDA which
can help accelerate storage data process.
Signed-off-by: Hanxiao Li
---
drivers/common/zsda/meson.build | 14 ++
drivers/common/zsda/zsda_common.c | 167 +++
drivers/common/zsda/zsda_common.h | 326
*** BLURB HERE ***
v8:
- fix some errors in cryptodevs/features/zsda.ini.
v7:
- add release notes and some documentations.
- add MAINTAINERS context in the patch where the file/folder is added.
- add files in meason.build which are included in the patch only.
- add a check for unsupported on Wind
add support of sm4 xts .
Signed-off-by: Hanxiao Li
---
lib/cryptodev/rte_crypto_sym.h | 4 +++-
lib/cryptodev/rte_cryptodev.c | 3 ++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/lib/cryptodev/rte_crypto_sym.h b/lib/cryptodev/rte_crypto_sym.h
index 53b18b9412..b34d041fe0 1006
Add drivers and some interfaces of zsda compressdev.
Signed-off-by: Hanxiao Li
---
MAINTAINERS | 4 +
drivers/common/zsda/meson.build | 12 +-
drivers/compress/zsda/zsda_comp.c | 392 ++
drivers/compress/zsda/zsda_comp.h | 52 +++
d
Add queue initialization, release, enqueue, dequeue and other interface.
Signed-off-by: Hanxiao Li
---
drivers/common/zsda/meson.build | 1 +
drivers/common/zsda/zsda_qp.c | 780
drivers/common/zsda/zsda_qp.h | 159 +++
3 files changed, 940 insertions(+
This patch adds documents and release notes
about compressdev and cryptodev.
Signed-off-by: Hanxiao Li
---
doc/guides/compressdevs/features/zsda.ini | 15 ++
doc/guides/compressdevs/index.rst | 1 +
doc/guides/compressdevs/zsda.rst | 45
doc/guides/cryptodevs/features/z
Add support for zsdadev operations such as dev_start and dev_stop.
Signed-off-by: Hanxiao Li
---
config/rte_config.h | 4 +
drivers/common/zsda/meson.build | 1 +
drivers/common/zsda/zsda_device.c | 444 ++
drivers/common/zsda/zsda_device.h | 117 +
add support of sm4 xts test.
Signed-off-by: Hanxiao Li
---
app/test/test_cryptodev_blockcipher.c | 3 +-
app/test/test_cryptodev_sm4_test_vectors.h | 58 ++
2 files changed, 60 insertions(+), 1 deletion(-)
diff --git a/app/test/test_cryptodev_blockcipher.c
b/app/test/
On Sat, Sep 28, 2024 at 12:18 PM Thomas Monjalon wrote:
>
> Cc Ajit for ack
>
>
> 28/09/2024 18:53, Stephen Hemminger:
> > This email address is bouncing remove from MAINTAINERS.
> >
> > Signed-off-by: Stephen Hemminger
Acked-by: Ajit Khaparde
> > ---
> > MAINTAINERS | 1 -
> > 1 file changed,
In the case when PMD cannot support the full process of the SM2,
but elliptic curve computation only, additional fields
are needed to handle such a case.
Points C1, kP therefore were added to the SM2 crypto operation struct.
Signed-off-by: Arkadiusz Kusztal
---
lib/cryptodev/rte_crypto_asym.h |
On 9/29/2024 2:31 AM, lihuisong (C) wrote:
>
> 在 2024/9/26 4:42, Ferruh Yigit 写道:
>> On 9/24/2024 8:24 AM, lihuisong (C) wrote:
>>> Hi Ferruh,
>>>
>>>
>>> 在 2024/9/23 6:23, Ferruh Yigit 写道:
On 1/30/2024 3:58 AM, Huisong Li wrote:
> Currently, the PTP feature is a little messy and has some
40 matches
Mail list logo
