[PATCH 2/2] timer/linux: override TSC freq if no tsc_known_freq

2024-09-21 Thread Isaac Boukris
If the tsc_known_freq cpu flag is missing, it means the kernel doesn't trust it and calculates its own. We should do the same to avoid drift. Signed-off-by: Isaac Boukris --- lib/eal/common/eal_common_timer.c | 3 +- lib/eal/common/eal_private.h | 2 +- lib/eal/freebsd/eal_timer.c |

[PATCH 1/2] timer/linux: lower rounding of tsc estimation to 10KHz

2024-09-21 Thread Isaac Boukris
In practice, the estimation result is just a couple of KHz away from the kernel's tsc_khz value, so it should suffice. Roundin to 10MHz can cause a significant drift from real time, up to a second per 10 minutes. See also bugzilla: 959 Signed-off-by: Isaac Boukris --- lib/eal/linux/eal_timer.c

Re: [PATCH v3 19/19] net/xsc: add dev basic stats ops

2024-09-21 Thread WanRenyong
On 2024/9/20 3:04, Stephen Hemminger wrote: > On Wed, 18 Sep 2024 14:09:36 +0800 > "WanRenyong" wrote: > >> >> +static int >> +xsc_ethdev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) >> +{ >> +struct xsc_ethdev_priv *priv = TO_XSC_ETHDEV_PRIV(dev); >> +uint32_t rxqs_n

Re: [PATCH v3 19/19] net/xsc: add dev basic stats ops

2024-09-21 Thread WanRenyong
On 2024/9/20 3:05, Stephen Hemminger wrote: > On Wed, 18 Sep 2024 14:09:36 +0800 > "WanRenyong" wrote: > >> @@ -166,6 +169,7 @@ xsc_rx_burst(void *dpdk_rxq, struct rte_mbuf **pkts, >> uint16_t pkts_n) >> /* Fill wqe */ >> wqe->va = rte_cpu_to_le_64(rte_pktmbuf_iova(rep))

RE: [PATCH v2 00/18] NXP DPAA ETH driver enhancement and fixes

2024-09-21 Thread Hemant Agrawal
Series Acked-by: Hemant Agrawal > -Original Message- > From: Ferruh Yigit > Sent: Sunday, September 22, 2024 8:43 AM > To: Hemant Agrawal ; dev@dpdk.org > Cc: ferruh.yi...@intel.com > Subject: Re: [PATCH v2 00/18] NXP DPAA ETH driver enhancement and fixes > > On 8/23/2024 8:32 AM, Heman

RE: [PATCH v2 14/18] net/dpaa: add Tx rate limiting DPAA PMD API

2024-09-21 Thread Hemant Agrawal
HI Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Sunday, September 22, 2024 8:44 AM > To: Hemant Agrawal ; dev@dpdk.org > Cc: ferruh.yi...@intel.com; Vinod Pullabhatla ; > Rohit Raj > Subject: Re: [PATCH v2 14/18] net/dpaa: add Tx rate limiting DPAA PMD API > Importance: High

Re: [PATCH v2 00/18] NXP DPAA ETH driver enhancement and fixes

2024-09-21 Thread Ferruh Yigit
On 8/23/2024 8:32 AM, Hemant Agrawal wrote: > v2: address review comments > - improve commit message > - add documentarion for new functions > - make IEEE1588 config runtime > > This series adds several enhancement to the NXP DPAA Ethernet driver. > > Primarily: > 1. timestamp and IEEE 1588 su

Re: [PATCH v2 14/18] net/dpaa: add Tx rate limiting DPAA PMD API

2024-09-21 Thread Ferruh Yigit
On 8/23/2024 8:32 AM, Hemant Agrawal wrote: > diff --git a/drivers/net/dpaa/version.map b/drivers/net/dpaa/version.map > index 3fdb63caf3..24a28ce649 100644 > --- a/drivers/net/dpaa/version.map > +++ b/drivers/net/dpaa/version.map > @@ -6,6 +6,13 @@ DPDK_25 { > local: *; > }; > > +EXPERIME

Re: [PATCH v3] net/af_packet: add timestamp offloading support

2024-09-21 Thread Ferruh Yigit
On 9/20/2024 8:14 AM, Stefan Laesser wrote: > Add the packet timestamp from TPACKET_V2 to the mbuf > dynamic rx timestamp register if offload RTE_ETH_RX_OFFLOAD_TIMESTAMP > is enabled. > > TPACKET_V2 provides the timestamp with nanosecond resolution > and UNIX origo, i.e. time since 1-JAN-1970 UTC

[PATCH v5 1/1] testpmd: add hairpin-map parameter

2024-09-21 Thread Gregory Etelson
Hairpin offloads packet forwarding between ports. Packet is expected on Rx port , Rx queue and is forwarded to Tx port Tx queue . Testpmd implements a static hairpin configuration scheme. The new parameter allows explicit selection of Rx and Tx ports and queues in hairpin configuration. The new

Re: [PATCH v3] ethdev: optimize the activation of fast-path tracepoints

2024-09-21 Thread Ferruh Yigit
On 9/19/2024 5:37 PM, Jerin Jacob wrote: > On Thu, Sep 19, 2024 at 12:16 AM Adel Belkhiri > wrote: >> >> From: Adel Belkhiri >> >> Split the tracepoints rte_ethdev_trace_rx_burst and >> rte_eth_trace_call_rx_callbacks into two separate ones >> for empty and non-empty calls to avoid saturating >>

Re: [PATCH] net/ena: revert redefining memcpy

2024-09-21 Thread Ferruh Yigit
On 9/12/2024 6:12 AM, Tyler Retzlaff wrote: > On Mon, Aug 12, 2024 at 08:34:17AM -0700, Stephen Hemminger wrote: >> Redefining memcpy as rte_memcpy has no performance gain on >> current compilers, and introduced bugs like this one where >> rte_memcpy() will be detected as referencing past the desti

Re: [PATCH v3 0/3] net/enic: support VF and fix minor issues

2024-09-21 Thread Ferruh Yigit
On 8/9/2024 8:07 AM, Hyong Youb Kim wrote: > This series contains minor updates for net/enic. The first patch > supports SR-IOV VF, which now requires the use of admin channel. The > other patches are not related to VF, but included here to ease review. > > --- > > v3: > * add spdx, doc, rel_note

Re: [PATCH 0/5] Increase minimum meson version

2024-09-21 Thread Ferruh Yigit
On 9/20/2024 1:57 PM, Bruce Richardson wrote: > This patchset proposed increasing the minimum meson version to 0.57 > and makes changes to update our build files appropriately for that > change: replacing deprecated functions, removing unnecessary version > checks and taking advantage of some new c

Re: [PATCH] net/mana: support rdma-core via pkg-config in meson

2024-09-21 Thread Ferruh Yigit
On 9/20/2024 6:14 PM, Long Li wrote: >> Subject: [PATCH] net/mana: support rdma-core via pkg-config in meson >> >> Currently building with custom rdma-core installed in /opt/rdma-core after >> setting PKG_CONFIG_PATH=/opt/rdma-core/lib64/pkgconfig/ results in the below >> meson logs: >> Run-time de

Re: [PATCH] net/gve: add ptype parsing to DQ format

2024-09-21 Thread Ferruh Yigit
On 9/18/2024 9:33 PM, Joshua Washington wrote: > Currently, the packet type is parsed as part of adding the > checksum-related ol_flags for a received packet, but the parsed > information is not added to the mbuf. > > This change adds the parsed ptypes to the mbuf and updates the RX > checksum val

Re: [PATCH] netvsc: optimize stats counters performance

2024-09-21 Thread Ferruh Yigit
On 9/19/2024 7:06 PM, Long Li wrote: >> Subject: RE: [PATCH] netvsc: optimize stats counters performance >> >>> From: Stephen Hemminger [mailto:step...@networkplumber.org] >>> Sent: Friday, 2 August 2024 19.33 >>> >>> On Fri, 2 Aug 2024 19:28:26 +0200 >>> Morten Brørup wrote: > > Reviewed-by: Lon