> -Original Message-
> From: Shani Peretz
> Sent: Tuesday, September 10, 2024 09:41
> To: dev@dpdk.org
> Cc: Shani Peretz ; Maayan Kashani
> ; Raslan Darawsheh ; Dariusz
> Sosnowski ; Slava Ovsiienko
> ; Bing Zhao ; Ori Kam
> ; Suanming Mou ; Matan
> Azrad ; Anatoly Burakov
> Subject: [PA
On Wed, Sep 11, 2024 at 4:08 AM WanRenyong wrote:
>
> Add log macro to print runtime messages and trace functions.
>
> Signed-off-by: WanRenyong
> ---
> drivers/net/xsc/xsc_ethdev.c | 11 +
> drivers/net/xsc/xsc_log.h| 44
> 2 files changed, 55 in
Introduce driver support for ZSDA which can
help to accelerate storage data process.
v6: modify code for ci compile
Signed-off-by: Hanxiao Li
---
MAINTAINERS | 4 +
config/rte_config.h | 4 +
drivers/common/zsda/meson.build | 25 +++
drivers/common/zsd
Add new file zsda_sym_pmd.c, zsda_sym_pmd.h in drivers/crypto/zsda
Signed-off-by: Hanxiao Li
---
drivers/crypto/zsda/zsda_sym_capabilities.h | 112 +
drivers/crypto/zsda/zsda_sym_pmd.c | 429
drivers/crypto/zsda/zsda_sym_pmd.h | 35 ++
3 files changed,
Add support for zsdadev operations such as dev_start and dev_stop.
Signed-off-by: Hanxiao Li
---
drivers/common/zsda/zsda_device.c | 476 ++
drivers/common/zsda/zsda_device.h | 103 +++
2 files changed, 579 insertions(+)
create mode 100644 drivers/common/zsda/zsd
Add new file zsda_sym_session.c, zsda_symsession.h
and modify drivers/common/zsda/meson.build
Signed-off-by: Hanxiao Li
---
drivers/common/zsda/meson.build| 16 +-
drivers/crypto/zsda/zsda_sym_session.c | 503 +
drivers/crypto/zsda/zsda_sym_session.h | 82
Add new file zsda_sym.c, zsda_sym.h in drivers/crypto/zsda
Signed-off-by: Hanxiao Li
---
drivers/crypto/zsda/zsda_sym.c | 286 +
drivers/crypto/zsda/zsda_sym.h | 25 +++
2 files changed, 311 insertions(+)
create mode 100644 drivers/crypto/zsda/zsda_sym.c
create
It is necessary to make necessary modifications to
existing files based on the newly introduced content
Signed-off-by: Hanxiao Li
---
MAINTAINERS | 3 ++
drivers/common/zsda/zsda_common.h | 50 +++
drivers/common/zsda/zsda_device.c | 42 +++-
Add zsda compressdev driver and enqueue, dequeue interface.
Signed-off-by: Hanxiao Li
---
drivers/common/zsda/meson.build | 2 +-
drivers/compress/zsda/zsda_comp.c | 358
drivers/compress/zsda/zsda_comp.h | 27 ++
drivers/compress/zsda/zsda_comp_pmd.c | 453
Add queue initialization, release, enqueue, dequeue and other interface.
Signed-off-by: Hanxiao Li
---
drivers/common/zsda/zsda_qp.c | 720 ++
drivers/common/zsda/zsda_qp.h | 160
2 files changed, 880 insertions(+)
create mode 100644 drivers/common/zsda/
Add implementation for hardware registers access routines.
Signed-off-by: Howard Wang
---
drivers/net/r8169/meson.build| 1 +
drivers/net/r8169/r8169_base.h | 389 +++
drivers/net/r8169/r8169_ethdev.c | 1 +
drivers/net/r8169/r8169_ethdev.h | 1 +
drivers/
Add implementation for hardware registers access routines.
Signed-off-by: Howard Wang
---
drivers/net/r8169/meson.build| 1 +
drivers/net/r8169/r8169_base.h | 389 +++
drivers/net/r8169/r8169_ethdev.h | 1 +
drivers/net/r8169/r8169_hw.c | 94
d
On 9/11/2024 3:07 AM, WanRenyong wrote:
> This xsc PMD (**librte_net_xsc**) provides poll mode driver for
> Yunsilicon metaScale serials NICs.
>
> Features:
> -
> - MTU update
> - TSO
> - RSS hash
> - RSS key update
> - RSS reta update
> - L3 checksum offload
> - L4 checksum offload
> - I
On 2024/9/11 16:51, Ferruh Yigit wrote:
> Hi WanRenyong,
>
> Thanks for upstreaming the driver,
> I did not had a chance to check in detail yet, but when sending next
> version can you please send patch series as threaded, with following
> git-send-email arguments:
> `--thread --no-chain-reply-to`
> +static void *lcore_buffer;
[...]
> + lcore_buffer = aligned_alloc(RTE_CACHE_LINE_SIZE,
> + LCORE_BUFFER_SIZE);
Since lcore_buffer is never freed again, it is easy to support Windows:
#ifdef RTE_EXEC_ENV_WINDOWS
#include
#endif
#ifndef RTE_
> From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru]
> Sent: Sunday, 8 September 2024 10.33
>
> On 9/7/24 23:55, Morten Brørup wrote:
> >> From: Morten Brørup [mailto:m...@smartsharesystems.com]
> >> Sent: Friday, 6 September 2024 21.38
> >>
> >> Maxime, Chenbo,
> >>
> >> If the virtio
On 10/09/2024 20:12, Ali Alnubani wrote:
>> -Original Message-
>> From: Kevin Traynor
>> Sent: Friday, September 6, 2024 12:53 PM
>> To: Ali Alnubani ; sta...@dpdk.org
>> Cc: dev@dpdk.org; Abhishek Marathe ;
>> David Christensen ; Hemant Agrawal
>> ; Ian Stokes ; Jerin Jacob
>> ; John McNa
> -Original Message-
> From: Kevin Traynor
> Sent: Wednesday, September 11, 2024 3:20 PM
> To: Ali Alnubani ; sta...@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe ;
> Hemant Agrawal ; Ian Stokes
> ; Jerin Jacob ; John McNamara
> ; Ju-Hyoung Lee ; Luca
> Boccassi ; Pei Zhang ; Raslan
> Dara
11/09/2024 14:17, Morten Brørup:
> From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru]
> > On 9/7/24 23:55, Morten Brørup wrote:
> > >> From: Morten Brørup [mailto:m...@smartsharesystems.com]
> > >> dev_info->rx_offload_capa |= RTE_ETH_RX_OFFLOAD_RSS_HASH;
> > >
> > > Or perhaps
On 9/11/2024 2:20 PM, Thomas Monjalon wrote:
> 11/09/2024 14:17, Morten Brørup:
>> From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru]
>>> On 9/7/24 23:55, Morten Brørup wrote:
> From: Morten Brørup [mailto:m...@smartsharesystems.com]
> dev_info->rx_offload_capa |= RTE_E
On 9/11/2024 3:02 PM, Ferruh Yigit wrote:
> On 9/11/2024 2:20 PM, Thomas Monjalon wrote:
>> 11/09/2024 14:17, Morten Brørup:
>>> From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru]
On 9/7/24 23:55, Morten Brørup wrote:
>> From: Morten Brørup [mailto:m...@smartsharesystems.com]
>>
> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com]
> Sent: Wednesday, 11 September 2024 16.02
>
> On 9/11/2024 2:20 PM, Thomas Monjalon wrote:
> > 11/09/2024 14:17, Morten Brørup:
> >> From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru]
> >>> On 9/7/24 23:55, Morten Brørup wrote:
> >
On 2024-09-11 12:32, Morten Brørup wrote:
+static void *lcore_buffer;
[...]
+ lcore_buffer = aligned_alloc(RTE_CACHE_LINE_SIZE,
+LCORE_BUFFER_SIZE);
Since lcore_buffer is never freed again, it is easy to support Windows:
#ifdef RTE_EX
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se]
> Sent: Wednesday, 11 September 2024 17.05
>
> On 2024-09-11 12:32, Morten Brørup wrote:
> >> +static void *lcore_buffer;
> > [...]
> >> + lcore_buffer = aligned_alloc(RTE_CACHE_LINE_SIZE,
> >> +
Hi Dean,
Thank you! This looks good. You only missed to update the command line
in the doc page under `doc/guides/tools/dst.rst`. This aside,
Reviewed-by: Luca Vizzarro
From: Jeremy Spewock
Currently the runner target in the Dockerfile attempts to run the
`poetry install` command when building the image, but this fails due to
poetry not being found in the container. Poetry is installed in a
previous step with pipx, but doing so adds the binary to use poetry to
~
Reviewed-by: Luca Vizzarro
On 2024-09-11 05:26, Varghese, Vipin wrote:
[AMD Official Use Only - AMD Internal Distribution Only]
On 2024-09-09 16:22, Varghese, Vipin wrote:
[AMD Official Use Only - AMD Internal Distribution Only]
Thank you Mattias for the comments and question, please let me try
to explain the s
On Wed, 22 Nov 2023 20:26:27 -0500
David Young wrote:
> -Glossary Introduction Formatting: Refined the introduction's formatting for
> clarity.
> -Directive Implementation: Used .. glossary:: directive for structured term
> definitions.
> -Term Definitions and Linking: Expanded definitions for
The variable `pending_deq_ops` was incorrectly used
instead of `pending_enq_ops`.
This causes the program to crash
when the worker PMD accesses the session
Bugzilla ID: 1537
Fixes: 6812b9bf470e ("crypto/scheduler: use unified session")
Cc: roy.fan.zh...@intel.com
Signed-off-by: Yong Liang <126969
On Wed, 11 Sep 2024 15:54:25 +0800
Hanxiao Li wrote:
> +void
> +zsda_stats_reset(void **queue_pairs, const uint32_t nb_queue_pairs)
> +{
> + enum zsda_service_type type;
> + uint32_t i;
> + struct zsda_qp *qp;
> +
> + if (queue_pairs == NULL) {
> + ZSDA_LOG(ERR, E_NULL
On Wed, Sep 11, 2024 at 03:26:20AM +, Varghese, Vipin wrote:
> [AMD Official Use Only - AMD Internal Distribution Only]
>
>
>
> >
> > On 2024-09-09 16:22, Varghese, Vipin wrote:
> > > [AMD Official Use Only - AMD Internal Distribution Only]
> > >
> > >
> > >
> > >>>
> > >>>
> > >>> Thank y
Hi Ferruh,
I will work with Stephen on this. For the tone of the list, I believe we
can try different ways to make the tone more friendly, while still being
concise.
What about something like this:
- Avoid including unused headers (process-iwyu.py).
- Keep compiler warnings enabled in the build f
The RTE flex item can represent tunnel header itself,
and split inner and outer items, it should be reflected
in the item flags while PMD is processing the item array.
Fixes: 8c0ca7527bc8 ("net/mlx5/hws: support flex item matching")
Cc: sta...@dpdk.org
Signed-off-by: Viacheslav Ovsiienko
---
dr
The RTE flex item can represent the tunnel header and
split the inner and outer layer items. HWS did not
support this flex item specifics.
Fixes: 8c0ca7527bc8 ("net/mlx5/hws: support flex item matching")
Cc: sta...@dpdk.org
Signed-off-by: Viacheslav Ovsiienko
---
drivers/net/mlx5/hws/mlx5dr_def
The hardware supports up to 8 flex parser configurations.
Some of them can be utilized internally by firmware, depending on
the configured profile ("FLEX_PARSER_PROFILE_ENABLE" in NV-setting).
The firmware does not report in capabilities how many flex parser
configuration is remaining available (th
There was a leftover of "flow flex init" command used
for debug purposes and had no useful functionality in
the production code.
Signed-off-by: Viacheslav Ovsiienko
---
app/test-pmd/cmdline_flow.c | 12
1 file changed, 12 deletions(-)
diff --git a/app/test-pmd/cmdline_flow.c b/app/
Once parsing the RTE item array the PMD needs to know
whether the flex item represents the tunnel header.
The appropriate tunnel mode query API is added.
Signed-off-by: Viacheslav Ovsiienko
---
drivers/net/mlx5/mlx5.h | 2 ++
drivers/net/mlx5/mlx5_flow_flex.c | 27
If the sample field in flex item did not cover the entire
32-bit word (width was not verified 32 bits) or was not aligned
on the byte boundary the match on this sample in flows
happened to be ignored or wrongly missed. The field mask
"def" was build in wrong endianness, and non-byte aligned
shifts
There are hardware imposed limitations on the header length
field description for the mask and shift combinations in the
FIELD_MODE_OFFSET mode.
The patch updates:
- parameter check for FIELD_MODE_OFFSET for the header length
field
- check whether length field crosses dword boundaries in h
Add support for input IPv4 and for ESP output flex parser arcs.
Signed-off-by: Viacheslav Ovsiienko
---
drivers/net/mlx5/mlx5_flow_flex.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/drivers/net/mlx5/mlx5_flow_flex.c
b/drivers/net/mlx5/mlx5_flow_flex.c
index 8a0224
On the flow validation some items may check the preceding protocols.
In case of flex item the next protocol is opaque (or can be multiple
ones) we should set neutral value and allow successful validation,
for example, for the combination of flex and following ESP items.
Fixes: a23e9b6e3ee9 ("net/m
The variable `pending_deq_ops` was incorrectly used
instead of `pending_enq_ops`.
This causes the program to crash
when the worker PMD accesses the session
Bugzilla ID: 1537
Fixes: 6812b9bf470e ("crypto/scheduler: use unified session")
Cc: roy.fan.zh...@intel.com
Signed-off-by: Yong Liang <126969
On 9/11/2024 3:59 PM, Morten Brørup wrote:
>> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com]
>> Sent: Wednesday, 11 September 2024 16.02
>>
>> On 9/11/2024 2:20 PM, Thomas Monjalon wrote:
>>> 11/09/2024 14:17, Morten Brørup:
From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru]
>
> On Sep 11, 2024, at 10:55 AM, Mattias Rönnblom wrote:
>
> On 2024-09-11 05:26, Varghese, Vipin wrote:
>> [AMD Official Use Only - AMD Internal Distribution Only]
>>
>>>
>>> On 2024-09-09 16:22, Varghese, Vipin wrote:
[AMD Official Use Only - AMD Internal Distribution Only]
Replace keeping PRNG state in a RTE_MAX_LCORE-sized static array of
cache-aligned and RTE_CACHE_GUARDed struct instances with keeping the
same state in a more cache-friendly lcore variable.
Signed-off-by: Mattias Rönnblom
Acked-by: Morten Brørup
--
RFC v3:
* Remove cache alignment on unregist
Keep per-lcore power intrinsics state in a lcore variable to reduce
cache working set size and avoid any CPU next-line-prefetching causing
false sharing.
Signed-off-by: Mattias Rönnblom
Acked-by: Morten Brørup
---
lib/eal/x86/rte_power_intrinsics.c | 17 +++--
1 file changed, 11 ins
Replace static array of cache-aligned structs with an lcore variable,
to slightly benefit code simplicity and performance.
Signed-off-by: Mattias Rönnblom
Acked-by: Morten Brørup
--
RFC v3:
* Replace for loop with FOREACH macro.
---
lib/power/rte_power_pmd_mgmt.c | 34 ---
Add test suite to exercise the API.
Signed-off-by: Mattias Rönnblom
Acked-by: Morten Brørup
--
RFC v5:
* Adapt tests to reflect the removal of the GET() and SET() macros.
RFC v4:
* Check all lcore id's values for all variables in the many variables
test case.
* Introduce test case for
Replace static array of cache-aligned structs with an lcore variable,
to slightly benefit code simplicity and performance.
Signed-off-by: Mattias Rönnblom
Acked-by: Morten Brørup
--
RFC v6:
* Remove a now-redundant lcore variable value memset().
RFC v5:
* Fix lcore value pointer bug introdu
This patch set introduces a new API for static
per-lcore id data allocation.
Please refer to the API documentation for both a
rationale for this new API, and a comparison to the alternatives
available.
The adoption of this API would affect many different DPDK modules, but
the author updated onl
Introduce DPDK per-lcore id variables, or lcore variables for short.
An lcore variable has one value for every current and future lcore
id-equipped thread.
The primary use case is for statically allocating
small, frequently-accessed data structures, for which one instance
should exist for each l
Reviewed-by: Patrick Robb
added the following methods to testpmd shell class:
vlan set filter on/off, rx vlan add/rm,
vlan set strip on/off, port stop/start all/port,
tx vlan set/reset, set promisc/verbose
fixed bug in vlan_offload for
show port info, removed $ at end of regex
Signed-off-by: Dean Marx
Reviewed-by: Jeremy
Port over VLAN capabilities test suite from old DTS. This test
suite verifies that VLAN filtering, stripping, and header
insertion all function as expected. When a VLAN ID is in the
filter list, all packets with that ID should be forwarded
and all others should be dropped. While stripping is enable
Test suite for verifying VLAN filtering, stripping, and insertion
functionality on Poll Mode Driver.
Depends-on: Patch-143966 ("dts: add VLAN methods to testpmd shell")
Signed-off-by: Dean Marx
Reviewed-by: Jeremy Spewock
---
dts/framework/config/conf_yaml_schema.json | 3 +-
dts/tests/TestS
Correct docstring error in conf.yaml showing incorrect
example pci address for TG nodes.
Fixes: 55442c14297c ("dts: improve documentation")
Signed-off-by: Dean Marx
Reviewed-by: Nicholas Pratte
Reviewed-by: Luca Vizzarro
Reviewed-by: Jeremy Spewock
Reviewed-by: Juraj Linkeš
---
dts/conf.yam
This series enables importing Linux Kernel uAPI headers
into the DPDK repository. It aims at solving alignment
issues between the build system and the system applications
linked ot DPDK libraries are run on.
It can also help simplify spaghetti code done to support
different versions of the Linux K
This patch introduces uAPI headers import into the DPDK
repository. This import is possible thanks to Linux Kernel
licence exception for syscalls:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/exceptions/Linux-syscall-note
Header files are have to be explicitly
Import VDUSE headers to be included in the Vhost library.
Set header version to v6.10 Linux Kernel release.
Signed-off-by: Maxime Coquelin
---
linux-headers/uapi/linux/vduse.h | 353 +++
linux-headers/uapi/version | 2 +-
2 files changed, 354 insertions(+), 1
This patch makes use of the imported VDUSE headers.
The VDUSE support is now systematically built on Linux
systems, even if the build system does not support its
ioctl().
Signed-off-by: Maxime Coquelin
---
lib/vhost/meson.build | 5 +
lib/vhost/vduse.c | 2 +-
lib/vhost/vduse.h | 2
On 9/7/24 16:34, David Marchand wrote:
On Fri, Sep 6, 2024 at 5:23 PM Maxime Coquelin
wrote:
[snip]
diff --git a/devtools/check-linux-uapi.sh b/devtools/check-linux-uapi.sh
new file mode 100755
index 00..76111d78ce
--- /dev/null
+++ b/devtools/check-linux-uapi.sh
@@ -0,0 +1,74 @@
+
> > > >>> Thank you Mattias for the comments and question, please let me try
> > > >>> to explain the same below
> > > >>>
> > > We shouldn't have a separate CPU/cache hierarchy API instead?
> > > >>>
> > > >>> Based on the intention to bring in CPU lcores which share same L3
> > > >>> (for
The function strtok is not thread safe, better to use strtok_r.
This patch was found by running semgrep on the DPDK repository.
Signed-off-by: Stephen Hemminger
---
app/graph/graph.c | 6 +++---
app/graph/utils.c | 18 +-
2 files changed, 12 insertions(+), 12 deletions(-)
diff
[AMD Official Use Only - AMD Internal Distribution Only]
>
> On Wed, 11 Sep 2024 03:13:14 +
> "Varghese, Vipin" wrote:
>
> > > Agreed. This one of those cases where the existing project hwloc
> > > which is part of open-mpi is more complete and well supported. It
> > > supports multiple OS'
On 2024/9/10 17:32, lihuisong (C) wrote:
> Hi Chengwen,
>
> Thanks for your review.
>
> 在 2024/9/10 10:00, fengchengwen 写道:
>> Hi Huisong
>>
>> Please see comments inline.
>>
>> Thanks
>>
>> On 2024/8/9 17:50, Huisong Li wrote:
>>> The deeper the idle state, the lower the power consumption, but t
On 2024/9/10 20:07, lihuisong (C) wrote:
> Hi chengwen,
>
> 在 2024/9/10 10:26, fengchengwen 写道:
>> Hi Huisong,
>>
>> On 2024/8/9 17:50, Huisong Li wrote:
>>> Add PM QoS configuration to declease the delay after sleep in case of
>>> entering deeper idle state.
>>>
>>> Signed-off-by: Huisong Li
>>>
On 2024/9/11 15:40, David Marchand wrote:
> On Wed, Sep 11, 2024 at 4:08 AM WanRenyong wrote:
>> Add log macro to print runtime messages and trace functions.
>>
>> Signed-off-by: WanRenyong
>> ---
>> drivers/net/xsc/xsc_ethdev.c | 11 +
>> drivers/net/xsc/xsc_log.h| 44
Acked-by: Chengwen Feng
There are many strtok invoking in DPDK current, and Hai Jie already submitted a
patchset [1], and it seemed interrupted.
Perhaps it's time to re-submit.
[1] https://inbox.dpdk.org/dev/20231114110006.91148-1-haij...@huawei.com/
On 2024/9/12 8:55, Stephen Hemminger wrote:
[Public]
Snipped
>
>
>
> >>
> >>
> >> Thank you Mattias for the comments and question, please let me
> >> try to explain the same below
> >>
> >>> We shouldn't have a separate CPU/cache hierarchy API instead?
> >>
> >> Based on the intention to bri
A new version should be submitted which will apply onto next-dts.
Mostly looks good barring 1 or 2 nits and some overlap with Luca's
pktgen/testpmd series which was merged to next-dts the other day.
On Wed, Sep 11, 2024 at 1:37 PM Dean Marx wrote:
>
> added the following methods to testpmd shell
[Public]
> > > >
> > > >
> > > >>>
> > > >>>
> > > >>> Thank you Mattias for the comments and question, please let me
> > > >>> try to explain the same below
> > > >>>
> > > We shouldn't have a separate CPU/cache hierarchy API instead?
> > > >>>
> > > >>> Based on the intention to bring
[Public]
> > What use case do you have in mind? What's on top of my list is a scenario
> where a DPDK app gets a bunch of cores (e.g., -l ) and tries to figure
> out how best make use of them. It's not going to "skip" (ignore, leave unused)
> SMT siblings, or skip non-boosted cores, it would ju
On 2024/9/12 1:04, Mattias Rönnblom wrote:
> Introduce DPDK per-lcore id variables, or lcore variables for short.
>
> An lcore variable has one value for every current and future lcore
> id-equipped thread.
>
> The primary use case is for statically allocating
> small, frequently-accessed data s
[AMD Official Use Only - AMD Internal Distribution Only]
> >
> > For the naming, would "rte_get_next_sibling_core" (or lcore if you
> > prefer) be a clearer name than just adding "ex" on to the end of the
> > existing function?
> >
> > Looking logically, I'm not sure about the BOOST_ENABLED and
The deeper the idle state, the lower the power consumption, but the longer
the resume time. Some service are delay sensitive and very except the low
resume time, like interrupt packet receiving mode.
And the "/sys/devices/system/cpu/cpuX/power/pm_qos_resume_latency_us" sysfs
interface is used to s
The deeper the idle state, the lower the power consumption, but the longer
the resume time. Some service are delay sensitive and very except the low
resume time, like interrupt packet receiving mode.
And the "/sys/devices/system/cpu/cpuX/power/pm_qos_resume_latency_us" sysfs
interface is used to s
Add PM QoS configuration to declease the delay after sleep in case of
entering deeper idle state.
Signed-off-by: Huisong Li
Acked-by: Morten Brørup
---
examples/l3fwd-power/main.c | 24
1 file changed, 24 insertions(+)
diff --git a/examples/l3fwd-power/main.c b/example
Series-reviewed-by: Chengwen Feng
On 2024/9/12 10:38, Huisong Li wrote:
> The deeper the idle state, the lower the power consumption, but the longer
> the resume time. Some service are delay sensitive and very except the low
> resume time, like interrupt packet receiving mode.
>
> And the "/sys/
Looks good other than updating the testpmd_shell method names
Reviewed-by: Patrick Robb
On Wed, Jul 24, 2024 at 1:13 PM wrote:
> +class TestDualVlan(TestSuite):
> +"""DPDK Dual VLAN test suite.
> +
> +This suite tests the behavior of VLAN functions and properties in the
> presence of t
On 2024/9/11 11:47, Stephen Hemminger wrote:
> On Wed, 11 Sep 2024 10:07:25 +0800
> "WanRenyong" wrote:
>
>> +
>> +sprintf(path, "%s/device/uevent", dev_path);
> better to use snprintf for safety
OK, will fix it in next version.
>> +while (fgets(line, sizeof(line), file) == line) {
>> +
Just noting in attempting to test the latest version of this patch I
see it does not cleanly apply.
On 2024/9/11 11:48, Stephen Hemminger wrote:
> On Wed, 11 Sep 2024 10:07:26 +0800
> "WanRenyong" wrote:
>
>> +hdr = rte_zmalloc(NULL, alloc_len, RTE_CACHE_LINE_SIZE);
>> +if (hdr == NULL) {
>> +PMD_DRV_LOG(ERR, "Failed to allocate xsc ioctl cmd memory");
>> +return
On 2024/9/11 11:49, Stephen Hemminger wrote:
> On Wed, 11 Sep 2024 10:07:26 +0800
> "WanRenyong" wrote:
>
>> +if (data_in != NULL && in_len > 0)
>> +rte_memcpy(hdr + 1, data_in, in_len);
>> +
>> +ret = ioctl(dev->ctrl_fd, cmd, hdr);
>> +if (ret == 0) {
>> +if (h
On 2024/9/11 11:50, Stephen Hemminger wrote:
> On Wed, 11 Sep 2024 10:07:26 +0800
> "WanRenyong" wrote:
>
>> +#define XSC_IOCTL_CHECK_FIELD 0x01234567
>> +
>> +#define XSC_IOCTL_MAGIC 0x1b
>> +#define XSC_IOCTL_CMDQ \
>> +_IOWR(XSC_IOCTL_MAGIC, 1, struct xsc_ioctl_hdr)
>> +#define XS
On Fri, Aug 09, 2024 at 10:14:35PM +0200, Mattias R??nnblom wrote:
> Introduce a set of functions and macros that operate on sets of bits,
> kept in arrays of 64-bit words.
>
> RTE bitset is designed for bitsets which are larger than what fits in
> a single machine word (i.e., 64 bits). For very l
On Fri, Aug 09, 2024 at 10:14:36PM +0200, Mattias R??nnblom wrote:
> Add test suite exercising .
>
> Signed-off-by: Mattias R??nnblom
>
> --
>
> RFC v5:
> * Parameterize tests to allow reuse across both atomic and non-atomic
>functions.
>
> RFC v4:
> * Fix signed char issue in test cases
On Fri, Aug 09, 2024 at 10:14:37PM +0200, Mattias R??nnblom wrote:
> Extend the bitset API with atomic versions of the most basic bitset
> operations.
>
> Signed-off-by: Mattias R??nnblom
> ---
Acked-by: Tyler Retzlaff
On Fri, Aug 09, 2024 at 10:14:38PM +0200, Mattias R??nnblom wrote:
> Extend bitset tests to cover the basic operation of the
> rte_bitset_atomic_*() family of functions.
>
> Signed-off-by: Mattias R??nnblom
> ---
Tyler Retzlaff
On Fri, Aug 09, 2024 at 10:14:39PM +0200, Mattias R??nnblom wrote:
> Use a multi-word bitset to track which services are mapped to which
> lcores, allowing the RTE_SERVICE_NUM_MAX compile-time constant to be >
> 64.
>
> Replace array-of-bytes service-currently-active flags with a more
> compact mu
On Fri, Aug 09, 2024 at 10:14:40PM +0200, Mattias R??nnblom wrote:
> Switch from using an open-coded, single-word bitset to using
> to represent which event ports are linked to a
> particular event queue.
>
> Besides the cleaner code, this also allow the user to extend the
> maximum port count be
On Mon, Aug 12, 2024 at 08:34:17AM -0700, Stephen Hemminger wrote:
> Redefining memcpy as rte_memcpy has no performance gain on
> current compilers, and introduced bugs like this one where
> rte_memcpy() will be detected as referencing past the destination.
>
> Bugzilla ID: 1510
> Fixes: 142778b37
On Mon, Aug 12, 2024 at 02:56:09PM -0700, Stephen Hemminger wrote:
> Only in one place does the power library need un-constify a pointer
> and this can be done by casting to uintptr_t first. Better, to have
> the warning enabled across the rest of the code.
>
> Signed-off-by: Stephen Hemminger
>
https://bugs.dpdk.org/show_bug.cgi?id=1512
hpoth...@marvell.com changed:
What|Removed |Added
Resolution|--- |FIXED
Status|UNCONFIRMED
On 2024-09-12 04:33, fengchengwen wrote:
On 2024/9/12 1:04, Mattias Rönnblom wrote:
Introduce DPDK per-lcore id variables, or lcore variables for short.
An lcore variable has one value for every current and future lcore
id-equipped thread.
The primary use case is for statically allocating
sma
On Thu, 12 Sep 2024 12:14:08 +0800
"WanRenyong" wrote:
> >
> >> +};
> >> +
> > Does this device driver depend on some upstr
> Yes, it depends on linux kernel driver of the device.
>
> Hello, Stephen,
>
> Thanks for your review, please see above.
What is the driver? I don't see in the cu
On Fri, Sep 06, 2024 at 02:27:57PM +0100, Bruce Richardson wrote:
> The "movdiri" instruction is given as a series of bytes in rte_io.h so
> that it works on compilers/assemblers which are unaware of the
> instruction. The REX prefix (0x40) on this instruction is invalid for
> 32-bit code, causing
This patch series aims to add two commands for the testpmd application:
- set port eeprom magic value
offset
- set port led
James Hershaw (2):
app/testpmd: add support for setting device EEPROM
app/testpmd: add set dev led on/off command
app/test-pmd/cmdline.c |
From: James Hershaw
There is currently no means to test the .set_eeprom function callback of
a given PMD in drivers/net/. This patch adds functionality to allow a
user to set device eeprom from the testpmd cmdline.
usage:
testpmd> set port eeprom magic value
offset
- is a decimal
- is
From: James Hershaw
Add command to change the state of a controllable LED on an ethdev port
to on/off. This is for the purpose of identifying which physical port is
associated with an ethdev.
usage:
testpmd> set port led
Signed-off-by: James Hershaw
Reviewed-by: Chaoyong He
---
app/test-
1 - 100 of 104 matches
Mail list logo
