Re: [PATCH v1 1/1] usertools: add DPDK build directory setup script

2024-09-05 Thread David Marchand
On Wed, Sep 4, 2024 at 5:17 PM Anatoly Burakov wrote: > > Currently, the only way to set up a build directory for DPDK development > is through running Meson directly. This has a number of drawbacks. > > For one, the default configuration is very "fat", meaning everything gets > enabled and built

Re: [PATCH 1/4] ethdev: verify queue ID when Tx done cleanup

2024-09-05 Thread Andrew Rybchenko
On 9/5/24 09:46, Jie Hai wrote: From: Chengwen Feng Verify queue_id for rte_eth_tx_done_cleanup API. If I'm not mistaken the function is considered data path API (fast). If so, it should not validate it's parameters as in rte_eth_tx_burst(). It may be done under RTE_ETHDEV_DEBUG_TX only. May

[PATCH 02/11] crypto/cnxk: add multi segment support for Rx inject

2024-09-05 Thread Tejasree Kondoj
From: Vidya Sagar Velumuri Add support for multi segmented packet in Rx inject. Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 53 ++- drivers/crypto/cnxk/cnxk_cryptodev_ops.h | 9 +++- 2 files changed, 50 insertions(+), 12 deletions(-

[PATCH 03/11] common/cnxk: ensure CPTR is 128B aligned

2024-09-05 Thread Tejasree Kondoj
From: Anoob Joseph Make sure CPTR is 128B aligned. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/roc_cpt.c | 5 + drivers/common/cnxk/roc_platform.h | 1 + 2 files changed, 6 insertions(+) diff --git a/drivers/common/cnxk/roc_cpt.c b/drivers/common/cnxk/roc_cpt.c index aba2a49d

[PATCH 04/11] common/cnxk: rearrange to remove hole

2024-09-05 Thread Tejasree Kondoj
From: Anoob Joseph Rearrange fields to remove hole. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/roc_se.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/cnxk/roc_se.h b/drivers/common/cnxk/roc_se.h index 50741a0b81..ede8d69c0e 100644 --- a/drivers/com

[PATCH 00/11] fixes and improvements to cnxk crypto PMD

2024-09-05 Thread Tejasree Kondoj
Adding new PMD APIs and improvements to cnxk crypto PMD. Anoob Joseph (9): common/cnxk: ensure CPTR is 128B aligned common/cnxk: rearrange to remove hole common/cnxk: remove abort from flush API common/cnxk: move algo enums to common crypto/cnxk: use opaque pointer for PMD APIs crypto/

[PATCH 01/11] crypto/cnxk: align passthrough data for SM ciphers

2024-09-05 Thread Tejasree Kondoj
From: Vidya Sagar Velumuri Add required padding to make passthrough data length multiple of 16 bytes for SM ciphers Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cnxk_se.h | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/drivers/

[PATCH 05/11] common/cnxk: remove abort from flush API

2024-09-05 Thread Tejasree Kondoj
From: Anoob Joseph Instead of calling abort() return error code so that the caller can handle as required. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/roc_cpt.c | 2 +- drivers/crypto/cnxk/cn10k_ipsec.c | 12 ++-- drivers/crypto/cnxk/cn10k_tls.c | 12 ++-- 3 file

[PATCH 06/11] common/cnxk: move algo enums to common

2024-09-05 Thread Tejasree Kondoj
From: Anoob Joseph The enums are same between 9k & 10k. Move to common. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/cnxk_security.c | 106 ++- drivers/common/cnxk/roc_ie.h | 22 + drivers/common/cnxk/roc_ie_on.h | 22 - drivers/co

[PATCH 07/11] crypto/cnxk: use opaque pointer for PMD APIs

2024-09-05 Thread Tejasree Kondoj
From: Anoob Joseph Use opaque pointer instead of void * for PMD APIs. Usage of forward declaration and opaque pointer would allow compiler to prevent unintended usage which cannot be prevented with void *. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 12 ++---

[PATCH 10/11] crypto/cnxk: add CPTR read and write

2024-09-05 Thread Tejasree Kondoj
From: Anoob Joseph Add PMD API for CPTR read and write. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 71 +++ drivers/crypto/cnxk/rte_pmd_cnxk_crypto.h | 52 + drivers/crypto/cnxk/version.map | 2 + 3 files changed, 1

[PATCH 11/11] crypto/cnxk: add PMD API to get qp stats

2024-09-05 Thread Tejasree Kondoj
From: Anoob Joseph Add PMD API to get CPT LF(QP) stats. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 32 + drivers/crypto/cnxk/rte_pmd_cnxk_crypto.h | 34 +++ drivers/crypto/cnxk/version.map | 1 + 3 files change

[PATCH 08/11] crypto/cnxk: add PMD API for getting CPTR

2024-09-05 Thread Tejasree Kondoj
From: Anoob Joseph CPTR address is the context address used by hardware. Add PMD API to retrieve the hardware address from rte_cryptodev/rte_security session. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 49 +++ drivers/crypto/cnxk/rte_pmd_cnx

[PATCH 09/11] crypto/cnxk: add PMD API to flush CTX

2024-09-05 Thread Tejasree Kondoj
From: Anoob Joseph Add PMD API to flush CPT CTX entry. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 24 ++ drivers/crypto/cnxk/rte_pmd_cnxk_crypto.h | 25 +++ drivers/crypto/cnxk/version.map | 1 + 3 files change

Re: [PATCH 0/3] eal: mark API's as stable

2024-09-05 Thread David Marchand
On Wed, Sep 4, 2024 at 8:10 PM Stephen Hemminger wrote: > > The API's in ethtool from before 23.11 should be marked stable. EAL* ? > Should probably include the trace api's but that is more complex change. On the trace API itself it should be ok. The problem is with the tracepoint variables the

Re: [PATCH v3 03/12] dts: add test case decorators

2024-09-05 Thread Juraj Linkeš
On 26. 8. 2024 18:50, Jeremy Spewock wrote: On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš wrote: class DTSRunner: @@ -232,9 +231,9 @@ def _get_test_suites_with_cases( for test_suite_config in test_suite_configs: test_suite_class = self._get_test_suite_class(test_

Re: [PATCH v3 0/5] Improve EAL bit operations API

2024-09-05 Thread David Marchand
Hello, On Tue, Aug 20, 2024 at 7:05 PM Mattias Rönnblom wrote: > > On 2024-08-12 14:49, Mattias Rönnblom wrote: > > This patch set represent an attempt to improve and extend the RTE > > bitops API, in particular for functions that operate on individual > > bits. > > > > Is there anyone else that

RE: [PATCH 0/3] eal: mark API's as stable

2024-09-05 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Thursday, 5 September 2024 09.59 > > On Wed, Sep 4, 2024 at 8:10 PM Stephen Hemminger > wrote: > > > > The API's in ethtool from before 23.11 should be marked stable. > > EAL* ? > > > Should probably include the trace api's but t

DPDK Release Status Meeting 2024-09-05

2024-09-05 Thread Mcnamara, John
Release status meeting minutes 2024-09-05 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * AMD * ARM * Intel * Marvell * Nvidia * Red Hat Release Dates - The following are the current/updated working dat

Re: [PATCH 0/3] eal: mark API's as stable

2024-09-05 Thread David Marchand
On Thu, Sep 5, 2024 at 10:55 AM Morten Brørup wrote: > > > From: David Marchand [mailto:david.march...@redhat.com] > > Sent: Thursday, 5 September 2024 09.59 > > > > On Wed, Sep 4, 2024 at 8:10 PM Stephen Hemminger > > wrote: > > > > > > The API's in ethtool from before 23.11 should be marked st

RE: [EXTERNAL] [PATCH v2] doc: add new driver guidelines

2024-09-05 Thread Akhil Goyal
Few crypto specific suggestions. > > v2 - review feedback >- add co-author and reviewed-by > > doc/guides/contributing/index.rst | 1 + > doc/guides/contributing/new_driver.rst | 202 + > 2 files changed, 203 insertions(+) > create mode 100644 doc/guides/cont

Re: [PATCH v3 04/12] dts: add mechanism to skip test cases or suites

2024-09-05 Thread Juraj Linkeš
On 26. 8. 2024 18:52, Jeremy Spewock wrote: On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš wrote: --- a/dts/framework/test_result.py +++ b/dts/framework/test_result.py @@ -75,6 +75,20 @@ def create_config(self) -> TestSuiteConfig: test_cases=[test_case.__name__ for test_case in

Re: DPDK Summit Montreal - Schedule

2024-09-05 Thread Ferruh Yigit
On 8/13/2024 7:13 PM, Thomas Monjalon wrote: > The next DPDK Summit will be hosted in Montreal, Canada on September 24-25. > > > We will talk about the future of DPDK, the best userland networking libraries > having an incredible hardware support from our large community. > It will be an opportun

[PATCH 0/3] add frequency adjustment support for PTP

2024-09-05 Thread Mingjin Ye
[1/3] ethdev: add frequency adjustment API [2/3] net/ice: add frequency adjustment support for PTP [3/3] examples/ptpclient: add frequency adjustment support Mingjin Ye (3): ethdev: add frequency adjustment API net/ice: add frequency adjustment support for PTP examples/ptpclient: add frequen

[PATCH 1/3] ethdev: add frequency adjustment API

2024-09-05 Thread Mingjin Ye
This patch adds freq adjustment API for PTP high accuracy. Signed-off-by: Simei Su Signed-off-by: Mingjin Ye --- doc/guides/nics/features.rst | 4 +++- lib/ethdev/ethdev_driver.h | 5 + lib/ethdev/ethdev_trace.h| 9 + lib/ethdev/ethdev_trace_points.c | 3 +++ l

[PATCH 2/3] net/ice: add frequency adjustment support for PTP

2024-09-05 Thread Mingjin Ye
Add ice support for new ethdev API to adjust frequency for IEEE1588 PTP. Also, this patch reworks code for converting software update to hardware update. Signed-off-by: Simei Su Signed-off-by: Mingjin Ye --- doc/guides/nics/ice.rst | 15 +++ drivers/net/ice/ice_ethdev.c | 177

[PATCH 3/3] examples/ptpclient: add frequency adjustment support

2024-09-05 Thread Mingjin Ye
This patch adds PI servo algorithm to support frequency adjustment API for IEEE1588 PTP. For example, the command for starting ptpclient with PI algorithm is: ./build/examples/dpdk-ptpclient -a :81:00.0 -c 1 -n 3 -- -T 0 -p 0x1 --controller=pi Signed-off-by: Simei Su Signed-off-by: Wenjun Wu

[PATCH v4 0/7] fix race-condition of proactive error handling mode

2024-09-05 Thread Chengwen Feng
This patch fixes race-condition of proactive error handling mode, the discussion thread [1]. [1] http://patchwork.dpdk.org/project/dpdk/patch/20230220060839.1267349-2-ashok.k.kal...@intel.com/ Chengwen Feng (7): ethdev: fix race-condition of proactive error handling mode net/hns3: replace fp

[PATCH v4 2/7] net/hns3: replace fp ops config function

2024-09-05 Thread Chengwen Feng
This patch replace hns3_eth_dev_fp_ops_config() with rte_eth_fp_ops_setup(). Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Acked-by: Dongdong Liu Acked-by: Konstantin Ananyev Acked-by: Huisong Li --- drivers/net/hns3/hns3_rxtx.c | 21 +++-- 1 file changed, 3 insertions(+),

[PATCH v4 4/7] net/bnxt: use fp ops setup function

2024-09-05 Thread Chengwen Feng
Use rte_eth_fp_ops_setup() instead of directly manipulating rte_eth_fp_ops variable. Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Acked-by: Konstantin Ananyev Acked-by: Ajit Khaparde Acked-by: Huisong Li --- drivers/net/bnxt/bnxt_cpr.c| 5 + drivers/net/bnxt/bnxt_ethdev.c | 5 +--

[PATCH v4 7/7] doc: testpmd support event handling section

2024-09-05 Thread Chengwen Feng
Add new section of event handling, which documented the ethdev and device events. Signed-off-by: Chengwen Feng --- doc/guides/testpmd_app_ug/event_handling.rst | 81 doc/guides/testpmd_app_ug/index.rst | 1 + 2 files changed, 82 insertions(+) create mode 100644 do

[PATCH v4 3/7] net/bnxt: fix race-condition when report error recovery

2024-09-05 Thread Chengwen Feng
If set data path functions to dummy functions before reports error recovering event, there maybe a race-condition with data path threads, this patch fixes it by setting data path functions to dummy functions only after reports such event. Fixes: e11052f3a46f ("net/bnxt: support proactive error han

[PATCH v4 5/7] app/testpmd: add error recovery usage demo

2024-09-05 Thread Chengwen Feng
This patch adds error recovery usage demo which will: 1. stop packet forwarding when the RTE_ETH_EVENT_ERR_RECOVERING event is received. 2. restart packet forwarding when the RTE_ETH_EVENT_RECOVERY_SUCCESS event is received. 3. prompt the ports that fail to recovery and need to be removed whe

[PATCH v4 6/7] app/testpmd: extract event handling to event.c

2024-09-05 Thread Chengwen Feng
This patch extract event handling (including eth-event and dev-event) to a new file 'event.c'. Signed-off-by: Chengwen Feng Acked-by: Huisong Li --- app/test-pmd/event.c | 390 ++ app/test-pmd/meson.build | 1 + app/test-pmd/parameters.c | 36 +--- a

[PATCH v4 1/7] ethdev: fix race-condition of proactive error handling mode

2024-09-05 Thread Chengwen Feng
In the proactive error handling mode, the PMD will set the data path pointers to dummy functions and then try recovery, in this period the application may still invoking data path API. This will introduce a race-condition with data path which may lead to crash [1]. Although the PMD added delay aft

Re: [PATCH v3 05/12] dts: add support for simpler topologies

2024-09-05 Thread Juraj Linkeš
On 26. 8. 2024 18:54, Jeremy Spewock wrote: I just had one question below, otherwise: Reviewed-by: Jeremy Spewock On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš wrote: diff --git a/dts/framework/testbed_model/topology.py b/dts/framework/testbed_model/topology.py new file mode 100644 inde

RE: [PATCH 0/3] eal: mark API's as stable

2024-09-05 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Thursday, 5 September 2024 11.03 > > On Thu, Sep 5, 2024 at 10:55 AM Morten Brørup > wrote: > > > > > From: David Marchand [mailto:david.march...@redhat.com] > > > Sent: Thursday, 5 September 2024 09.59 > > > > > > On Wed, Sep 4, 2

Re: [PATCH v1 1/1] usertools: add DPDK build directory setup script

2024-09-05 Thread Burakov, Anatoly
On 9/5/2024 9:29 AM, David Marchand wrote: On Wed, Sep 4, 2024 at 5:17 PM Anatoly Burakov wrote: Currently, the only way to set up a build directory for DPDK development is through running Meson directly. This has a number of drawbacks. For one, the default configuration is very "fat", meanin

Re: [EXTERNAL] [PATCH v2] doc: add new driver guidelines

2024-09-05 Thread Ferruh Yigit
On 9/5/2024 10:16 AM, Akhil Goyal wrote: > Few crypto specific suggestions. > >> >> v2 - review feedback >>- add co-author and reviewed-by >> >> doc/guides/contributing/index.rst | 1 + >> doc/guides/contributing/new_driver.rst | 202 + >> 2 files changed, 203 i

[PATCH 0/3] add frequency adjustment support for PTP

2024-09-05 Thread Mingjin Ye
[1/3] ethdev: add frequency adjustment API [2/3] net/ice: add frequency adjustment support for PTP [3/3] examples/ptpclient: add frequency adjustment support Mingjin Ye (3): ethdev: add frequency adjustment API net/ice: add frequency adjustment support for PTP examples/ptpclient: add frequen

[PATCH 1/3] ethdev: add frequency adjustment API

2024-09-05 Thread Mingjin Ye
This patch adds freq adjustment API for PTP high accuracy. Signed-off-by: Simei Su Signed-off-by: Mingjin Ye --- doc/guides/nics/features.rst | 4 +++- lib/ethdev/ethdev_driver.h | 5 + lib/ethdev/ethdev_trace.h| 9 + lib/ethdev/ethdev_trace_points.c | 3 +++ l

[PATCH 2/3] net/ice: add frequency adjustment support for PTP

2024-09-05 Thread Mingjin Ye
Add ice support for new ethdev API to adjust frequency for IEEE1588 PTP. Also, this patch reworks code for converting software update to hardware update. Signed-off-by: Simei Su Signed-off-by: Mingjin Ye --- doc/guides/nics/ice.rst | 15 +++ drivers/net/ice/ice_ethdev.c | 177

[PATCH 3/3] examples/ptpclient: add frequency adjustment support

2024-09-05 Thread Mingjin Ye
This patch adds PI servo algorithm to support frequency adjustment API for IEEE1588 PTP. For example, the command for starting ptpclient with PI algorithm is: ./build/examples/dpdk-ptpclient -a :81:00.0 -c 1 -n 3 -- -T 0 -p 0x1 --controller=pi Signed-off-by: Simei Su Signed-off-by: Wenjun Wu

Re: [PATCH v3 06/12] dst: add basic capability support

2024-09-05 Thread Juraj Linkeš
On 26. 8. 2024 18:56, Jeremy Spewock wrote: Just one comment about adding something to a doc-string, otherwise looks good to me: Reviewed-by: Jeremy Spewock On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš wrote: diff --git a/dts/framework/test_result.py b/dts/framework/test_result.py index

Re: [PATCH v3 06/12] dst: add basic capability support

2024-09-05 Thread Juraj Linkeš
On 3. 9. 2024 18:03, Dean Marx wrote: On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš wrote: A test case or suite may require certain capabilities to be present in the tested environment. Add the basic infrastructure for checking the support status of capabilities: * The Capab

RE: [EXTERNAL] [PATCH v2] doc: add new driver guidelines

2024-09-05 Thread Akhil Goyal
> >> +Additional Suggestions > >> +-- > >> + > > .ini file shall be updated for each of the new feature added in the same > > patch as > code. > > > > This is mentioned above as: > "Update relevant documentation and .ini file with each patch." Ok. I missed that.

Re: [PATCH 0/3] add frequency adjustment support for PTP

2024-09-05 Thread Ferruh Yigit
On 9/5/2024 10:26 AM, Mingjin Ye wrote: > [1/3] ethdev: add frequency adjustment API > [2/3] net/ice: add frequency adjustment support for PTP > [3/3] examples/ptpclient: add frequency adjustment support > > Mingjin Ye (3): > ethdev: add frequency adjustment API > net/ice: add frequency adjust

[PATCH] [RFC] cryptodev: replace LIST_END enumerators with APIs

2024-09-05 Thread Akhil Goyal
Replace *_LIST_END enumerators from asymmetric crypto lib to avoid ABI breakage for every new addition in enums with inline APIs. Signed-off-by: Akhil Goyal --- This patch was discussed in ML long time back. https://patches.dpdk.org/project/dpdk/patch/20211008204516.3497060-1-gak...@marvell.com/

[PATCH 0/3] add frequency adjustment support for PTP

2024-09-05 Thread Mingjin Ye
[1/3] ethdev: add frequency adjustment API [2/3] net/ice: add frequency adjustment support for PTP [3/3] examples/ptpclient: add frequency adjustment support Mingjin Ye (3): ethdev: add frequency adjustment API net/ice: add frequency adjustment support for PTP examples/ptpclient: add frequen

[PATCH 1/3] ethdev: add frequency adjustment API

2024-09-05 Thread Mingjin Ye
This patch adds freq adjustment API for PTP high accuracy. Signed-off-by: Simei Su Signed-off-by: Mingjin Ye --- doc/guides/nics/features.rst | 4 +++- doc/guides/rel_notes/release_24_11.rst | 30 +++--- lib/ethdev/ethdev_driver.h | 5 + lib/ethde

[PATCH 2/3] net/ice: add frequency adjustment support for PTP

2024-09-05 Thread Mingjin Ye
Add ice support for new ethdev API to adjust frequency for IEEE1588 PTP. Also, this patch reworks code for converting software update to hardware update. Signed-off-by: Simei Su Signed-off-by: Mingjin Ye --- doc/guides/nics/ice.rst | 15 +++ drivers/net/ice/ice_ethdev.c | 177

[PATCH 3/3] examples/ptpclient: add frequency adjustment support

2024-09-05 Thread Mingjin Ye
This patch adds PI servo algorithm to support frequency adjustment API for IEEE1588 PTP. For example, the command for starting ptpclient with PI algorithm is: ./build/examples/dpdk-ptpclient -a :81:00.0 -c 1 -n 3 -- -T 0 -p 0x1 --controller=pi Signed-off-by: Simei Su Signed-off-by: Wenjun Wu

[PATCH v2 0/3] add frequency adjustment support for PTP

2024-09-05 Thread Mingjin Ye
[1/3] ethdev: add frequency adjustment API [2/3] net/ice: add frequency adjustment support for PTP [3/3] examples/ptpclient: add frequency adjustment support Mingjin Ye (3): ethdev: add frequency adjustment API net/ice: add frequency adjustment support for PTP examples/ptpclient: add frequen

[PATCH v2 1/3] ethdev: add frequency adjustment API

2024-09-05 Thread Mingjin Ye
This patch adds freq adjustment API for PTP high accuracy. Signed-off-by: Simei Su Signed-off-by: Mingjin Ye --- v2: rte_eth_timesync_adjust_freq marked as experimental --- doc/guides/nics/features.rst | 4 +++- doc/guides/rel_notes/release_24_11.rst | 30 +++---

[PATCH v2 2/3] net/ice: add frequency adjustment support for PTP

2024-09-05 Thread Mingjin Ye
Add ice support for new ethdev API to adjust frequency for IEEE1588 PTP. Also, this patch reworks code for converting software update to hardware update. Signed-off-by: Simei Su Signed-off-by: Mingjin Ye --- doc/guides/nics/ice.rst | 15 +++ drivers/net/ice/ice_ethdev.c | 177

[PATCH v2 3/3] examples/ptpclient: add frequency adjustment support

2024-09-05 Thread Mingjin Ye
This patch adds PI servo algorithm to support frequency adjustment API for IEEE1588 PTP. For example, the command for starting ptpclient with PI algorithm is: ./build/examples/dpdk-ptpclient -a :81:00.0 -c 1 -n 3 -- -T 0 -p 0x1 --controller=pi Signed-off-by: Simei Su Signed-off-by: Wenjun Wu

Re: [PATCH v3 08/12] dts: add NIC capability support

2024-09-05 Thread Juraj Linkeš
On 26. 8. 2024 19:11, Jeremy Spewock wrote: On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš wrote: @dataclass class TestPmdPort(TextParser): """Dataclass representing the result of testpmd's ``show port info`` command.""" @@ -962,3 +1043,96 @@ def _close(self) -> None: se

21.11.8 patches review and test

2024-09-05 Thread Kevin Traynor
Hi all, Here is a list of patches targeted for stable release 21.11.8. The planned date for the final release is 18th September. Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported valid

[DPDK/other Bug 1533] testpmd performance drops with Mellanox ConnectX6 when using 8 cores 8 queues

2024-09-05 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1533 Bug ID: 1533 Summary: testpmd performance drops with Mellanox ConnectX6 when using 8 cores 8 queues Product: DPDK Version: 23.11 Hardware: All OS: Linux

Crash in tap pmd when using more than 8 rx queues

2024-09-05 Thread Edwin Brossette
Hello, I have recently stumbled into an issue with my DPDK-based application running the failsafe pmd. This pmd uses a tap device, with which my application fails to start if more than 8 rx queues are used. This issue appears to be related to this patch: https://git.dpdk.org/dpdk/commit/?id=c36ce7

Bug 1531

2024-09-05 Thread Kevin Traynor
Hello Jianwen, In reference to https://bugs.dpdk.org/show_bug.cgi?id=1531#c3 reported by Yopper, is there is a fix needed for dpdk main branch or LTS branches ? Also, if you could register in bugzilla, then we could track txgbe issues in one place, which makes it easier. thanks, Kevin.

Re: [RFC 0/2] introduce LLC aware functions

2024-09-05 Thread Ferruh Yigit
On 9/3/2024 9:50 AM, Burakov, Anatoly wrote: > On 9/2/2024 5:33 PM, Varghese, Vipin wrote: >> > I recently looked into how Intel's Sub-NUMA Clustering would work > within > DPDK, and found that I actually didn't have to do anything, because > the > SNC "clusters" present t

Re: [PATCH 0/3] add frequency adjustment support for PTP

2024-09-05 Thread Ferruh Yigit
On 9/5/2024 11:08 AM, Mingjin Ye wrote: > [1/3] ethdev: add frequency adjustment API > [2/3] net/ice: add frequency adjustment support for PTP > [3/3] examples/ptpclient: add frequency adjustment support > > Mingjin Ye (3): > ethdev: add frequency adjustment API > net/ice: add frequency adjust

RE: 21.11.8 patches review and test

2024-09-05 Thread Ali Alnubani
> -Original Message- > From: Kevin Traynor > Sent: Thursday, September 5, 2024 3:38 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; Ali > Alnubani ; David Christensen ; > Hemant Agrawal ; Ian Stokes > ; Jerin Jacob ; John McNamara > ; Ju-Hyoung Lee ; Kevin > Traynor ; Luca

[PATCH v2 1/6] cryptodev: add EDDSA asymmetric crypto algorithm

2024-09-05 Thread Gowrishankar Muthukrishnan
Add support for asymmetric EDDSA in cryptodev, as referenced in RFC: https://datatracker.ietf.org/doc/html/rfc8032 Signed-off-by: Gowrishankar Muthukrishnan --- doc/guides/cryptodevs/features/default.ini | 1 + doc/guides/prog_guide/cryptodev_lib.rst| 2 +- lib/cryptodev/rte_crypto_asym.h

[PATCH v2 1/6] cryptodev: add EDDSA asymmetric crypto algorithm

2024-09-05 Thread Gowrishankar Muthukrishnan
Add support for asymmetric EDDSA in cryptodev, as referenced in RFC: https://datatracker.ietf.org/doc/html/rfc8032 Signed-off-by: Gowrishankar Muthukrishnan --- doc/guides/cryptodevs/features/default.ini | 1 + doc/guides/prog_guide/cryptodev_lib.rst| 2 +- lib/cryptodev/rte_crypto_asym.h

[PATCH v2 2/6] crypto/openssl: support EDDSA

2024-09-05 Thread Gowrishankar Muthukrishnan
Support EDDSA crypto algorithm in OpenSSL PMD. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/openssl/openssl_pmd_private.h | 13 ++ drivers/crypto/openssl/rte_openssl_pmd.c | 223 +++ drivers/crypto/openssl/rte_openssl_pmd_ops.c | 131 +++ 3 files chan

[PATCH v2 3/6] crypto/cnxk: support EDDSA

2024-09-05 Thread Gowrishankar Muthukrishnan
Support EDDSA crypto algorithm in CNXK PMD. Signed-off-by: Gowrishankar Muthukrishnan --- doc/guides/cryptodevs/features/cn10k.ini | 1 + drivers/common/cnxk/hw/cpt.h | 3 +- drivers/common/cnxk/roc_ae.c | 52 +- drivers/common/cnxk/roc_ae.h

[PATCH v2 4/6] test/crypto: add asymmetric EDDSA test cases

2024-09-05 Thread Gowrishankar Muthukrishnan
Add test cases to validate EDDSA sign and verify ops, as per RFC 8032. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 357 +++- app/test/test_cryptodev_ecdh_test_vectors.h | 94 +++- app/test/test_cryptodev_ecdsa_test_vectors.h | 4 + app

[PATCH v2 5/6] examples/fips_validation: support EDDSA

2024-09-05 Thread Gowrishankar Muthukrishnan
Add EDDSA support in fips_validation app. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation.c| 2 + examples/fips_validation/fips_validation.h| 23 ++ .../fips_validation/fips_validation_eddsa.c | 307 + examples/fips_validation/m

[PATCH v2 6/6] app/crypto-perf: support EDDSA

2024-09-05 Thread Gowrishankar Muthukrishnan
Added support for EDDSA 25519 curve SIGN and VERIFY operations. Signed-off-by: Gowrishankar Muthukrishnan --- app/test-crypto-perf/cperf_ops.c | 52 app/test-crypto-perf/cperf_options.h | 2 + app/test-crypto-perf/cperf_options_parsing.c | 9 +++- app/t

Re: [PATCH 0/3] add frequency adjustment support for PTP

2024-09-05 Thread Bruce Richardson
On Thu, Sep 05, 2024 at 02:14:36PM +0100, Ferruh Yigit wrote: > On 9/5/2024 11:08 AM, Mingjin Ye wrote: > > [1/3] ethdev: add frequency adjustment API > > [2/3] net/ice: add frequency adjustment support for PTP > > [3/3] examples/ptpclient: add frequency adjustment support > > > > Mingjin Ye (3):

Re: [PATCH 0/3] eal: mark API's as stable

2024-09-05 Thread Jerin Jacob
On Thu, Sep 5, 2024 at 3:14 PM Morten Brørup wrote: > > > From: David Marchand [mailto:david.march...@redhat.com] > > Sent: Thursday, 5 September 2024 11.03 > > > > On Thu, Sep 5, 2024 at 10:55 AM Morten Brørup > > wrote: > > > > > > > From: David Marchand [mailto:david.march...@redhat.com] > > >

Re: 21.11.8 patches review and test

2024-09-05 Thread Kevin Traynor
On 05/09/2024 14:29, Ali Alnubani wrote: >> -Original Message- >> From: Kevin Traynor >> Sent: Thursday, September 5, 2024 3:38 PM >> To: sta...@dpdk.org >> Cc: dev@dpdk.org; Abhishek Marathe ; Ali >> Alnubani ; David Christensen ; >> Hemant Agrawal ; Ian Stokes >> ; Jerin Jacob ; John McN

RE: [PATCH 0/3] eal: mark API's as stable

2024-09-05 Thread Morten Brørup
> From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Thursday, 5 September 2024 16.02 > > On Thu, Sep 5, 2024 at 3:14 PM Morten Brørup > wrote: > > > > > From: David Marchand [mailto:david.march...@redhat.com] > > > Sent: Thursday, 5 September 2024 11.03 > > > > > > On Thu, Sep 5, 2024 at

[PATCH v3 1/1] dts: add methods for modifying MTU to testpmd shell

2024-09-05 Thread jspewock
From: Jeremy Spewock There are methods within DTS currently that support updating the MTU of ports on a node, but the methods for doing this in a linux session rely on the ip command and the port being bound to the kernel driver. Since test suites are run while bound to the driver for DPDK, there

[PATCH v3 0/1] dts: allow for updating MTU with testpmd

2024-09-05 Thread jspewock
From: Jeremy Spewock v3: * add if-statement to pass the formatting script since the ports parameter for testpmd is technically optional, but it will not be None unless the user deliberately sets it to be. Jeremy Spewock (1): dts: add methods for modifying MTU to testpmd shell dts/fram

[PATCH 1/2] vhost: add logging mechanism for reconnection

2024-09-05 Thread Maxime Coquelin
This patch introduces a way for backend to keep track of the needed information to be able to reconnect without frontend cooperation. It will be used for VDUSE, which does not provide interface for the backend to save and later recover local virtqueues metadata needed to reconnect. Vhost-user sup

[PATCH 0/2] vhost: add VDUSE reconnection support

2024-09-05 Thread Maxime Coquelin
This series adds support for VDUSE reconnection. First patch introduces the reconnection file layout and track the virtqueues available index updates in the datapath and control queue. Second patch adds VDUSE reconnect intialization and some sanity checks to prevent incompatible reconnections. T

[PATCH 2/2] vhost: add reconnection support to VDUSE

2024-09-05 Thread Maxime Coquelin
This patch enables VDUSE reconnection support making use of the newly introduced reconnection mechanism in Vhost library. At DPDK VDUSE device creation time, there are two possibilities: 1. The Kernel VDUSE device does not exist: a. A reconnection file named after the VUDSE device name is

Re: [RFC 0/2] introduce LLC aware functions

2024-09-05 Thread Burakov, Anatoly
On 9/5/2024 3:05 PM, Ferruh Yigit wrote: On 9/3/2024 9:50 AM, Burakov, Anatoly wrote: On 9/2/2024 5:33 PM, Varghese, Vipin wrote: Hi Ferruh, I feel like there's a disconnect between my understanding of the problem space, and yours, so I'm going to ask a very basic question: Assuming th

[PATCH 0/6] vhost: add asymmetric crypto support

2024-09-05 Thread Gowrishankar Muthukrishnan
This series of patches add asymmetric crypto support in vhost library and virtio PMD, specifically for RSA. To verify functionality in QEMU, you would need: https://github.com/qemu/qemu/commit/5c33f9783ace0b5e077060b220978d94fecb3e81 There is VirtIO specification change proposed for RSA support,

[PATCH 1/6] cryptodev: move RSA padding information into xform

2024-09-05 Thread Gowrishankar Muthukrishnan
RSA padding information could be a xform entity rather than part of crypto op, as it seems associated with hashing algorithm used for the entire crypto session, where this algorithm is used in message digest itself. Even in virtIO standard spec, this info is associated in the asymmetric session cre

[PATCH 2/6] cryptodev: fix RSA xform for ASN.1 syntax

2024-09-05 Thread Gowrishankar Muthukrishnan
As per ASN.1 syntax (RFC 3447 Appendix A.1.2), RSA private key would need specification of quintuple along with private exponent. It is up to the implementation to internally handle, but not at RTE itself to make them exclusive each other. Removing union on them allows asymmetric implementation in

[PATCH 3/6] vhost: add asymmetric RSA support

2024-09-05 Thread Gowrishankar Muthukrishnan
Support asymmetric RSA crypto operations in vhost-user. Signed-off-by: Gowrishankar Muthukrishnan --- lib/cryptodev/cryptodev_pmd.h | 6 + lib/vhost/rte_vhost_crypto.h | 14 +- lib/vhost/vhost.c | 11 +- lib/vhost/vhost.h | 1 + lib/vhost/vhost_crypto.c | 550

[PATCH 4/6] crypto/virtio: add asymmetric RSA support

2024-09-05 Thread Gowrishankar Muthukrishnan
Asymmetric RSA operations (SIGN, VERIFY, ENCRYPT and DECRYPT) are supported in virtio PMD. Signed-off-by: Gowrishankar Muthukrishnan --- .../virtio/virtio_crypto_capabilities.h | 19 + drivers/crypto/virtio/virtio_cryptodev.c | 388 +++--- drivers/crypto/virtio/virtio_rxt

[PATCH 5/6] examples/vhost_crypto: add asymmetric support

2024-09-05 Thread Gowrishankar Muthukrishnan
Add symmetric support. Signed-off-by: Gowrishankar Muthukrishnan --- examples/vhost_crypto/main.c | 50 +--- 1 file changed, 29 insertions(+), 21 deletions(-) diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c index 558c09a60f..bed7fc637d 10

[PATCH 6/6] app/test: add asymmetric tests for virtio pmd

2024-09-05 Thread Gowrishankar Muthukrishnan
Add asymmetric tests for Virtio PMD. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 42 +++--- app/test/test_cryptodev_rsa_test_vectors.h | 26 ++ 2 files changed, 64 insertions(+), 4 deletions(-) diff --git a/app/test/test

[PATCH 1/2] net: add thread-safe crc api

2024-09-05 Thread Arkadiusz Kusztal
The current net CRC API is not thread-safe, this patch solves this by adding another, thread-safe API functions. These functions are not safe when using between different processes, though. Signed-off-by: Arkadiusz Kusztal --- lib/net/rte_net_crc.c | 40 +---

[PATCH 2/2] crypto/qat: fix thread-safety issue in the crc

2024-09-05 Thread Arkadiusz Kusztal
This patch fixes CRC thread-safety issue in the QAT PMD. Signed-off-by: Arkadiusz Kusztal --- drivers/crypto/qat/qat_sym.h | 3 +-- drivers/crypto/qat/qat_sym_session.c | 3 +++ drivers/crypto/qat/qat_sym_session.h | 2 ++ 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/dr

RE: [PATCH] [RFC] cryptodev: replace LIST_END enumerators with APIs

2024-09-05 Thread Morten Brørup
> +++ b/app/test/test_cryptodev_asym.c > @@ -581,7 +581,7 @@ static inline void print_asym_capa( > rte_cryptodev_asym_get_xform_string(capa->xform_type)); > printf("operation supported -"); > > - for (i = 0; i < RTE_CRYPTO_ASYM_OP_LIST_END; i++) { > + for (i = 0

Re: [PATCH v3 03/12] dts: add test case decorators

2024-09-05 Thread Jeremy Spewock
On Thu, Sep 5, 2024 at 4:07 AM Juraj Linkeš wrote: > > > > On 26. 8. 2024 18:50, Jeremy Spewock wrote: > > On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš > > wrote: > > > >> class DTSRunner: > >> @@ -232,9 +231,9 @@ def _get_test_suites_with_cases( > >> > >> for test_suite_config in t

RE: [PATCH] [RFC] cryptodev: replace LIST_END enumerators with APIs

2024-09-05 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Morten Brørup > Sent: Thursday, September 5, 2024 5:09 PM > To: Akhil Goyal ; dev@dpdk.org > Cc: tho...@monjalon.net; Marchand, David ; > hemant.agra...@nxp.com; ano...@marvell.com; De Lara Guarch, Pablo > ; Trahe, Fiona ; > Doherty, Declan ; ma...@nvidia.co

Re: [PATCH v3 06/12] dst: add basic capability support

2024-09-05 Thread Jeremy Spewock
On Thu, Sep 5, 2024 at 5:50 AM Juraj Linkeš wrote: > >> @@ -63,6 +65,12 @@ class is to hold a subset of test cases (which could be > >> all test cases) because > >> > >> test_suite_class: type[TestSuite] > >> test_cases: list[type[TestCase]] > >> +required_capabilities: set[Capab

Re: [PATCH v3 04/12] dts: add mechanism to skip test cases or suites

2024-09-05 Thread Jeremy Spewock
On Thu, Sep 5, 2024 at 5:23 AM Juraj Linkeš wrote: > >> +def _mark_results(self, result) -> None: > > > > Is it worth adding the type annotation for `result` here and to the > > other places where this is implemented? I guess it doesn't matter that > > much since it is a private method. > > >

Re: [PATCH v3 08/12] dts: add NIC capability support

2024-09-05 Thread Jeremy Spewock
On Thu, Sep 5, 2024 at 7:56 AM Juraj Linkeš wrote: > > > > On 26. 8. 2024 19:11, Jeremy Spewock wrote: > > On Wed, Aug 21, 2024 at 10:53 AM Juraj Linkeš > > wrote: > > > >> @dataclass > >> class TestPmdPort(TextParser): > >> """Dataclass representing the result of testpmd's ``show port

Re: [RFC 0/2] introduce LLC aware functions

2024-09-05 Thread Ferruh Yigit
On 9/5/2024 3:45 PM, Burakov, Anatoly wrote: > On 9/5/2024 3:05 PM, Ferruh Yigit wrote: >> On 9/3/2024 9:50 AM, Burakov, Anatoly wrote: >>> On 9/2/2024 5:33 PM, Varghese, Vipin wrote: >> > > Hi Ferruh, > >>> >>> I feel like there's a disconnect between my understanding of the problem >>

net/failsafe: segfault happens on hotplug alarm.

2024-09-05 Thread Edwin Brossette
Hello, I recently ran into an issue when using DPDK's failsafe pmd on a Microsoft Azure setup. On this setup, I have the failsafe pmd managing a netvsc interface with a Mellanox nic (which can be used through the hardware acceleration feature). A segfault is sometimes seen whenever I unplug the Me

Re: [PATCH v1] dts: fix testpmd port device error handling mode

2024-09-05 Thread Jeremy Spewock
Reviewed-by: Jeremy Spewock

Re: [PATCH v1] dts: add testpmd port information caching

2024-09-05 Thread Jeremy Spewock
Seems like a good change to me! Reviewed-by: Jeremy Spewock

  1   2   >