RE: [PATCH v1] net/cpfl: fix invalid action types

2024-08-23 Thread Shetty, Praveen
> In case of CPFL PMD, port_representor action is used for the local > vport and represented_port action is used for the remote port(remote > port in this case is either the idpf pf or the vf port that is being > represeted by the cpfl pmd). > Any mismatch in either of the cases PMD will throw a

RE: [PATCH v2] net/cpfl: fix cpfl parser issue

2024-08-23 Thread Shetty, Praveen
> CPFL parser was incorrectly parsing the mask value of the > next_proto_id field from recipe.json file as a string instead of > unsigned integer. > > Fixes: 41f20298ee8c ("net/cpfl: parse flow offloading hint from JSON") > Cc: sta...@dpdk.org > > Signed-off-by: Praveen Shetty > > --- > v2: >

[PATCH v2 00/18] NXP DPAA ETH driver enhancement and fixes

2024-08-23 Thread Hemant Agrawal
v2: address review comments - improve commit message - add documentarion for new functions - make IEEE1588 config runtime This series adds several enhancement to the NXP DPAA Ethernet driver. Primarily: 1. timestamp and IEEE 1588 support 2. OH and ONIC based virtual port config in DPAA 3. fram

[PATCH v2 01/18] bus/dpaa: fix PFDRs leaks due to FQRNIs

2024-08-23 Thread Hemant Agrawal
From: Gagandeep Singh When a Retire FQ command is executed on a FQ in the Tentatively Scheduled or Parked states, in that case FQ is retired immediately and a FQRNI (Frame Queue Retirement Notification Immediate) message is generated. Software must read this message from MR and consume it to free

[PATCH v2 02/18] net/dpaa: fix typecasting ch ID to u32

2024-08-23 Thread Hemant Agrawal
From: Rohit Raj Avoid typecasting ch_id to u32 and passing it to another API since it can corrupt other data. Instead, create new u32 variable and typecase it back to u16 after it gets updated by the API. Fixes: 0c504f6950b6 ("net/dpaa: support push mode") Cc: hemant.agra...@nxp.com Cc: sta...@d

[PATCH v2 03/18] bus/dpaa: fix VSP for 1G fm1-mac9 and 10

2024-08-23 Thread Hemant Agrawal
No need to classify interface separately for 1G and 10G Note that VSP or Virtual storage profile are DPAA equivalent for SRIOV config to logically divide a physical ports in virtual ports. Fixes: e0718bb2ca95 ("bus/dpaa: add virtual storage profile port init") Cc: sta...@dpdk.org Signed-off-by: H

[PATCH v2 04/18] bus/dpaa: fix the fman details status

2024-08-23 Thread Hemant Agrawal
Fix the incorrect placing of brackets to calculate stats. This corrects the "(a | b) << 32" to "a | (b << 32)" Fixes: e62a3f4183f1 ("bus/dpaa: fix statistics reading") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/fman/fman_hw.c | 9 + 1 file changed, 5

[PATCH v2 05/18] bus/dpaa: add port buffer manager stats

2024-08-23 Thread Hemant Agrawal
Add BMI statistics and improving the existing extended statistics Signed-off-by: Hemant Agrawal Signed-off-by: Gagandeep Singh --- drivers/bus/dpaa/base/fman/fman_hw.c | 61 drivers/bus/dpaa/include/fman.h | 4 +- drivers/bus/dpaa/include/fsl_fman.h | 12

[PATCH v2 06/18] net/dpaa: support Tx confirmation to enable PTP

2024-08-23 Thread Hemant Agrawal
From: Vanshika Shukla TX confirmation provides dedicated confirmation queues for transmitted packets. These queues are used by software to get the status and release transmitted packets buffers. This patch also changes the IEEE1588 support as devargs Signed-off-by: Vanshika Shukla Acked-by: He

[PATCH v2 07/18] net/dpaa: add support to separate Tx conf queues

2024-08-23 Thread Hemant Agrawal
From: Vanshika Shukla This patch separates Tx confirmation queues for kernel and DPDK so as to support the VSP case. Signed-off-by: Vanshika Shukla Acked-by: Hemant Agrawal --- drivers/bus/dpaa/include/fsl_qman.h | 4 ++- drivers/net/dpaa/dpaa_ethdev.c | 45 +

[PATCH v2 08/18] net/dpaa: share MAC FMC scheme and CC parse

2024-08-23 Thread Hemant Agrawal
From: Jun Yang For Shared MAC: 1) Allocate RXQ from VSP scheme. (Virtual Storage Profile) 2) Allocate RXQ from Coarse classifiation (CC) rules to VSP. 2) Remove RXQ allocated which is reconfigured without VSP. 3) Don't alloc default queue and err queues. Signed-off-by: Jun Yang Acked-by: Hemant

[PATCH v2 09/18] net/dpaa: support Rx/Tx timestamp read

2024-08-23 Thread Hemant Agrawal
From: Vanshika Shukla This patch implements Rx/Tx timestamp read operations for DPAA1 platform. Signed-off-by: Vanshika Shukla --- doc/guides/nics/features/dpaa.ini| 1 + drivers/bus/dpaa/base/fman/fman.c| 21 +++- drivers/bus/dpaa/base/fman/fman_hw.c | 6 ++- drivers/bus/dpaa/in

[PATCH v2 10/18] net/dpaa: support IEEE 1588 PTP

2024-08-23 Thread Hemant Agrawal
From: Vanshika Shukla This patch adds the support for the ethdev APIs to enable/disable and read/write/adjust IEEE1588 PTP timestamps for DPAA platform. Signed-off-by: Vanshika Shukla --- doc/guides/nics/dpaa.rst | 1 + doc/guides/nics/features/dpaa.ini | 2 + drivers/bus/dpaa/base/

[PATCH v2 11/18] net/dpaa: implement detailed packet parsing

2024-08-23 Thread Hemant Agrawal
This patch implements the detailed packet parsing using the annotation info from the hardware. decode parser to set RX muf packet type by dpaa_slow_parsing. Support to identify the IPSec ESP, GRE and SCTP packets. Signed-off-by: Jun Yang Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_

[PATCH v2 12/18] net/dpaa: enhance DPAA frame display

2024-08-23 Thread Hemant Agrawal
This patch enhances the received packet debugging capability. This help displaying the full packet parsing output. Signed-off-by: Jun Yang Signed-off-by: Hemant Agrawal --- doc/guides/nics/dpaa.rst | 5 ++ drivers/net/dpaa/dpaa_ethdev.c | 9 +++ drivers/net/dpaa/dpaa_rxtx.c | 138 ++

[PATCH v2 13/18] net/dpaa: support mempool debug

2024-08-23 Thread Hemant Agrawal
From: Gagandeep Singh This patch adds support to compile time debug the mempool corruptions in dpaa driver. Signed-off-by: Gagandeep Singh --- drivers/net/dpaa/dpaa_rxtx.c | 40 1 file changed, 40 insertions(+) diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/d

[PATCH v2 14/18] net/dpaa: add Tx rate limiting DPAA PMD API

2024-08-23 Thread Hemant Agrawal
From: Vinod Pullabhatla Add support to set Tx rate on DPAA platform through PMD APIs Signed-off-by: Vinod Pullabhatla Signed-off-by: Rohit Raj --- .mailmap | 1 + drivers/net/dpaa/dpaa_flow.c | 95 +--- drivers/net/dpaa/fmlib/fm_lib

[PATCH v2 15/18] bus/dpaa: add OH port mode for dpaa eth

2024-08-23 Thread Hemant Agrawal
From: Rohit Raj NXP DPAA architecture supports the concept of DPAA port as Offline Port - meaning - not connected to an actual MAC. This is an hardware assited IPC mechanism for communiting between two applications. Offline(O/H) port is a type of hardware port which is able to dequeue and enqueu

[PATCH v2 16/18] bus/dpaa: add ONIC port mode for the DPAA eth

2024-08-23 Thread Hemant Agrawal
From: Rohit Raj The OH ports can also be used by two application, processing contexts to communicate to each other. This patch enables this mode for dpaa-eth OH port as ONIC port, so that application can use the dpaa-eth to communicate to each other on the same SoC. Again,this properties is driv

[PATCH v2 17/18] net/dpaa: improve the dpaa port cleanup

2024-08-23 Thread Hemant Agrawal
From: Gagandeep Singh During DPAA cleanup in FMCLESS mode, application can see segmentation fault in device close API and in DPAA destructor execution. Segmentation fault in device close is because driver reducing the number of queues initialised during device configuration without releasing the

[PATCH v2 18/18] net/dpaa: improve dpaa errata A010022 handling

2024-08-23 Thread Hemant Agrawal
From: Jun Yang This patch improves the errata handling for "RTE_LIBRTE_DPAA_ERRATA_LS1043_A010022" Signed-off-by: Jun Yang --- drivers/net/dpaa/dpaa_rxtx.c | 40 1 file changed, 32 insertions(+), 8 deletions(-) diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/d

Re: [PATCH 03/17] bus/dpaa: fix VSP for 1G fm1-mac9 and 10

2024-08-23 Thread Hemant Agrawal
On 07-08-2024 21:08, Ferruh Yigit wrote: On 8/1/2024 11:52 AM, Hemant Agrawal wrote: No need to classify interface separately for 1G and 10G Fixes: e0718bb2ca95 ("bus/dpaa: add virtual storage profile port init") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal Can you please briefly exp

Re: [PATCH 04/17] bus/dpaa: add port buffer manager stats

2024-08-23 Thread Hemant Agrawal
On 07-08-2024 21:08, Ferruh Yigit wrote: On 8/1/2024 11:53 AM, Hemant Agrawal wrote: Add BMI statistics and improving the existing extended statistics Signed-off-by: Hemant Agrawal Signed-off-by: Gagandeep Singh --- drivers/bus/dpaa/base/fman/fman_hw.c | 65 +++-

Re: [PATCH 05/17] net/dpaa: support Tx confirmation to enable PTP

2024-08-23 Thread Hemant Agrawal
On 07-08-2024 21:08, Ferruh Yigit wrote: On 8/1/2024 11:53 AM, Hemant Agrawal wrote: From: Vanshika Shukla TX confirmation provides dedicated confirmation queues for transmitted packets. These queues are used by software to get the status and release transmitted packets buffers. Signed-off-

Re: [PATCH 07/17] net/dpaa: share MAC FMC scheme and CC parse

2024-08-23 Thread Hemant Agrawal
On 07-08-2024 21:09, Ferruh Yigit wrote: On 8/1/2024 11:53 AM, Hemant Agrawal wrote: From: Jun Yang For Shared MAC: 1) Allocate RXQ from VSP scheme. 2) Allocate RXQ from CC directed to VSP. What is CC, please explain in the commit log. Coarse Classification to determine VSP (VF) 2) Remov

Re: [PATCH 10/17] net/dpaa: implement detailed packet parsing

2024-08-23 Thread Hemant Agrawal
On 07-08-2024 21:09, Ferruh Yigit wrote: On 8/1/2024 11:53 AM, Hemant Agrawal wrote: This patch implements the detailed packet parsing using the annotation info from the hardware. decode parser to set RX muf packet type by dpaa_slow_parsing. Support to identify the IPSec ESP, GRE and SCTP pac

Re: [PATCH 13/17] net/dpaa: add Tx rate limiting DPAA PMD API

2024-08-23 Thread Hemant Agrawal
On 07-08-2024 21:10, Ferruh Yigit wrote: On 8/1/2024 11:53 AM, Hemant Agrawal wrote: From: Vinod Pullabhatla Add support to set Tx rate on DPAA platform through PMD APIs Signed-off-by: Vinod Pullabhatla Signed-off-by: Rohit Raj <...> diff --git a/drivers/net/dpaa/rte_pmd_dpaa.h b/drive

Re: [PATCH 14/17] bus/dpaa: add OH port mode for dpaa eth

2024-08-23 Thread Hemant Agrawal
On 07-08-2024 21:10, Ferruh Yigit wrote: On 8/1/2024 11:53 AM, Hemant Agrawal wrote: From: Rohit Raj NXP DPAA architecture supports the concept of DPAA port as Offline Port - meaning - not connected to an actual MAC. This is an virtual port to be used by application for exchanging data. Is

Re: [PATCH 17/17] net/dpaa: improve dpaa errata A010022 handling

2024-08-23 Thread Hemant Agrawal
On 07-08-2024 21:11, Ferruh Yigit wrote: On 8/1/2024 11:53 AM, Hemant Agrawal wrote: From: Jun Yang This patch improves the errata handling for "RTE_LIBRTE_DPAA_ERRATA_LS1043_A010022" Signed-off-by: Jun Yang --- drivers/net/dpaa/dpaa_rxtx.c | 40 1 f

Re: [PATCH 09/17] net/dpaa: support IEEE 1588 PTP

2024-08-23 Thread Hemant Agrawal
On 07-08-2024 21:09, Ferruh Yigit wrote: On 8/1/2024 11:53 AM, Hemant Agrawal wrote: From: Vanshika Shukla This patch adds the support for the ethdev APIs to enable/disable and read/write/adjust IEEE1588 PTP timestamps for DPAA platform. Signed-off-by: Vanshika Shukla --- doc/guides/nics

Re: [PATCH 11/17] net/dpaa: enhance DPAA frame display

2024-08-23 Thread Hemant Agrawal
On 07-08-2024 21:09, Ferruh Yigit wrote: On 8/1/2024 11:53 AM, Hemant Agrawal wrote: This patch enhances the received packet debugging capability. This help displaying the full packet parsing output. Signed-off-by: Jun Yang Signed-off-by: Hemant Agrawal --- doc/guides/nics/dpaa.rst

[PATCH v1] dts: add testpmd port information caching

2024-08-23 Thread Juraj Linkeš
When using port information multiple times in a testpmd shell instance lifespan, it's desirable to not get the information each time, so caching is added. In case the information changes, there's a way to force the update with either TestPmdShell.show_port_info() or TestPmdShell.show_port_info_all(

[PATCH v1] dts: fix testpmd port device error handling mode

2024-08-23 Thread Juraj Linkeš
Make device_error_handling_mode of testpmd port optional as it may not be present, e.g. in VM ports. Fixes: 61d5bc9bf974 ("dts: add port info command to testpmd shell") Signed-off-by: Juraj Linkeš --- dts/framework/remote_session/testpmd_shell.py | 4 ++-- 1 file changed, 2 insertions(+), 2 del

Re: [PATCH v2] app/testpmd: show output of commands read from file

2024-08-23 Thread Bruce Richardson
On Thu, Aug 22, 2024 at 10:09:09PM +0100, Ferruh Yigit wrote: > On 8/22/2024 6:18 PM, Bruce Richardson wrote: > > On Thu, Aug 22, 2024 at 06:14:55PM +0100, Bruce Richardson wrote: > >> On Thu, Aug 22, 2024 at 05:53:27PM +0100, Ferruh Yigit wrote: > >>> On 8/22/2024 11:41 AM, Bruce Richardson wrote:

[PATCH v1 1/3] fbarray: rename tests to be more meaningful

2024-08-23 Thread Anatoly Burakov
Some tests reference internal implementation details of fbarray, as well as equivocate between mask and index. Most other test names are not very descriptive. Rename them, and adjust comments to explain things in terms of what the tests actually do, instead of referring to internal implementation d

[PATCH v1 2/3] fbarray: rework find_next_n to flatten the loop

2024-08-23 Thread Anatoly Burakov
Currently, find_next_n() is implemented as a nested loop due to lookahead functionality. This is not very efficient because when doing lookahead, we essentially scan some of the indices twice, and in general the lookahead functionality has been a source of bugs because it is overcomplicated. The bi

[PATCH v1 3/3] fbarray: rework find_prev_n to flatten the loop

2024-08-23 Thread Anatoly Burakov
Currently, find_prev_n() is implemented as a nested loop due to lookbehind functionality. This is not very efficient because when doing lookbehind, we essentially scan some of the indices twice, and in general the lookbehind functionality has been a source of bugs because it is overcomplicated. The

Re: [PATCH v2 1/5] dts: add ability to send/receive multiple packets

2024-08-23 Thread Juraj Linkeš
This is a nice improvement. The comment below won't necessarily results in any changes, so: Reviewed-by: Juraj Linkeš diff --git a/dts/framework/test_suite.py b/dts/framework/test_suite.py @@ -303,6 +329,40 @@ def verify_packets(self, expected_packet: Packet, received_packets: list[Packet]

Re: [PATCH v2 2/5] dts: add random generation seed setting

2024-08-23 Thread Juraj Linkeš
This is a great idea. I originally didn't think the config file option would be very useful, but thinking a bit more about it, when debugging and trying to find a solution the devs need to run with the same seed over and over, so it's going to have a place. Reviewed-by: Juraj Linkeš On 6. 8.

[PATCH v3 00/12] Align ICE shared code with Base driver

2024-08-23 Thread Soumyadeep Hore
Updating the latest shared code patches to ICE base driver. --- v3: - Addressed comments givn by reviewer --- v2: - Addressed comments given by reviewer - Corrected errors in Camel Case --- Dan Nowlin (2): net/ice: correct Tx Scheduler AQ command RD bit for E825C net/ice: support optional fla

[PATCH v3 01/12] net/ice: use correct format specifiers for unsigned ints

2024-08-23 Thread Soumyadeep Hore
From: Yogesh Bhosale Firmware was giving a number for the MSIX vectors that was way too big and obviously not right. Because of the wrong format specifier, this big number ended up looking like a tiny negative number in the logs. This was fixed by using the right format specifier everywhere it's

[PATCH v3 02/12] net/ice: updates for ptp init in E825C

2024-08-23 Thread Soumyadeep Hore
From: Norbert Zulinski The implementation was done incorrectly assuming the TS PLL parameters would be similar to E822/E823 devices. Fix it by using proper values. Define access to SB (sideband) for second PHY and CGU devices in case of E825C devices. In E825C soft straps of CGU cannot be read

[PATCH v3 03/12] net/ice: add new tag definitions

2024-08-23 Thread Soumyadeep Hore
From: Paul Greenwalt Add E830_GLTCLAN_TSYN_REG_RANGE_ENFORCE* defines to unified_manual.inc to make them available externally. Signed-off-by: Paul Greenwalt Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_hw_autogen.h | 14 ++ 1 file changed, 14 insertions(+) diff --g

[PATCH v3 04/12] net/ice: avoid reading past end of PFA

2024-08-23 Thread Soumyadeep Hore
From: Jacob Keller The ice_get_pfa_module_tlv() function iterates over the Preserved Fields Area to read data from the Shadow RAM, including the Part Board Assembly data, among others. If the specific TLV being requested is not found in the current NVM, the code will read past the end of the PFA

[PATCH v3 05/12] net/ice: update PTP init

2024-08-23 Thread Soumyadeep Hore
From: Norbert Zulinski Add Bit macro to init PHY 1 for E825C devices. Signed-off-by: Norbert Zulinski Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_ptp_hw.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/base/ice_ptp_hw.c b/drivers/net

[PATCH v3 06/12] net/ice: address compilation errors

2024-08-23 Thread Soumyadeep Hore
From: Oleg Akhrem Visual Studio C++ compiler does not pass 32->16 or 16->8 bits conversions because of possible loss of data. Signed-off-by: Oleg Akhrem Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_ptp_hw.c | 31 --- 1 file changed, 4 insertions(+),

[PATCH v3 07/12] net/ice: fix link speed for 200G

2024-08-23 Thread Soumyadeep Hore
From: Paul Greenwalt When setting PHY configuration during driver initialization, 200G link speed is not being advertised even when the PHY is capable. This is because the get PHY capabilities link speed response is being masked by ICE_AQ_LINK_SPEED_M, which does not include 200G link speed bit.

[PATCH v3 08/12] net/ice: update iteration of TLVs in Preserved Fields Area

2024-08-23 Thread Soumyadeep Hore
From: Fabio Pricoco Correct the logic for determining the maximum PFA offset to include the extra last word. Additionally, make the driver robust against overflows by using check_add_overflow. This ensures that even if the NVM provides bogus data, the driver will not overflow, and will instead lo

[PATCH v3 09/12] net/ice: correct Tx Scheduler AQ command RD bit for E825C

2024-08-23 Thread Soumyadeep Hore
From: Dan Nowlin In E825C, regarding the Get Tx Topology AQ command, there is a change in the way that the RD bit must be set. For E825C, the RD bit must be cleared for the Get Tx Topology operation, whereas for E810 devices, the RD bit must be set. Signed-off-by: Dan Nowlin Signed-off-by: Soum

[PATCH v3 10/12] net/ice: support optional flags in signature segment header

2024-08-23 Thread Soumyadeep Hore
From: Dan Nowlin An optional flag field has been added to the signature segment header. The flags field contains two flags, a valid flag, and a last segment flag that indicates whether the segment is the last segment that will be downloaded to firmware. If the flag field's valid bit is NOT set,

[PATCH v3 11/12] net/ice: update E830 50G branding strings

2024-08-23 Thread Soumyadeep Hore
From: Paul Greenwalt Update E830 50G branding strings from "E830-XXV" to "E830-L". Signed-off-by: Paul Greenwalt Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_common.c | 6 +++--- drivers/net/ice/base/ice_devids.h | 12 ++-- drivers/net/ice/ice_ethdev.c | 6 +++---

[PATCH v3 12/12] net/ice: add support for FEC auto-detect for E830

2024-08-23 Thread Soumyadeep Hore
From: Przemyslaw Gierszynski Extends the functionality of the function responsible for checking if the firmware supports FEC (Forward Error Correction) disable in Auto FEC mode. It now includes an additional check to determine if the adapter is a E830 model. With this change, the function will en

Re: [PATCH v8 2/3] eventdev: add support for independent enqueue

2024-08-23 Thread Mattias Rönnblom
On 2024-08-12 22:00, Abdullah Sevincer wrote: This commit adds support for independent enqueue feature and updates Event Device and PMD feature list. A new capability RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ is introduced to support independent enqueue to support PMD to enqueue in any order even the un

Re: [PATCH v8 3/3] event/dsw: add capability for independent enqueue

2024-08-23 Thread Mattias Rönnblom
On 2024-08-12 22:00, Abdullah Sevincer wrote: To use independent enqueue capability applications need to set flag RTE_EVENT_PORT_CFG_INDEPENDENT_ENQ during port setup only if the capability RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ exists. Hence, this commit adds the capability of independent enqueue to

[PATCH v3] net/cpfl: fix cpfl parser issue

2024-08-23 Thread Praveen Shetty
CPFL parser was incorrectly parsing the mask value of the next_proto_id field from recipe.json file as a string instead of unsigned integer. Fixes: 41f20298ee8c ("net/cpfl: parse flow offloading hint from JSON") Cc: sta...@dpdk.org Signed-off-by: Praveen Shetty --- v2: * Fixed CI issues. v3: *

[PATCH v1] net/ice: fix incorrect reading of PHY timestamp

2024-08-23 Thread Soumyadeep Hore
In E830 adapters, PHY timestamp for Tx packets should be read once the ready status of PHY timestamp registers is 1. Fixes: 881169950d80 ("net/ice/base: implement initial PTP support for E830") Cc: sta...@dpdk.org Signed-off-by: Soumyadeep Hore --- drivers/net/ice/base/ice_ptp_hw.c | 68 +++

Re: [PATCH v2 3/5] dts: add random packet generator

2024-08-23 Thread Juraj Linkeš
On 6. 8. 2024 14:46, Luca Vizzarro wrote: Add a basic utility that can create random L3 and L4 packets with random payloads and port numbers (if L4). Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek Reviewed-by: Alex Chapman I believe this is to be used with a method that fills in

Re: [PATCH v2 4/5] dts: add ability to start/stop testpmd ports

2024-08-23 Thread Juraj Linkeš
As Jeremy mentioned, adding the verify argument may be worthwhile, but maybe only if we actually identify a usecase where we wouldn't want to do the verification. I also have two other points: 1. Do we want a decorator that does both - starting and stopping? Is the idea to have all methods tha

Re: [PATCH v2 5/5] dts: add testpmd set ports queues

2024-08-23 Thread Juraj Linkeš
On 6. 8. 2024 14:46, Luca Vizzarro wrote: Add a facility to update the number of TX/RX queues during the runtime of testpmd. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/remote_session/testpmd_shell.py | 16 1 file changed, 16 insertions(+)

Re: [PATCH v2 0/2] dts: port over checksum offload suite

2024-08-23 Thread Jeremy Spewock
Hey Dean, Thanks for the series! Looks good to me in general, I just left some comments with a few thoughts I had about some ways to potentially move some stuff around or swap implementations, but the functionality all looks good to me. Let me know what you think! Thanks, Jeremy On Wed, Aug 21,

Re: [PATCH v2 1/2] dts: add csum HW offload to testpmd shell

2024-08-23 Thread Jeremy Spewock
On Wed, Aug 21, 2024 at 12:25 PM Dean Marx wrote: > > add csum_set_hw method to testpmd shell class. Port over > set_verbose and port start/stop from queue start/stop suite. Since we had that discussion in a DTS meeting about there not really being a rule against multiple dependencies or anything

Re: [PATCH v2 2/2] dts: checksum offload test suite

2024-08-23 Thread Jeremy Spewock
On Wed, Aug 21, 2024 at 12:25 PM Dean Marx wrote: > > test suite for verifying layer 3/4 checksum offload > features on poll mode driver. > > Depends-on: patch-143033 > ("dts: add text parser for testpmd verbose output") > Depends-on: patch-142691 > ("dts: add send_packets to test suites and rewor

[PATCH v2 0/1] Device queue initialization

2024-08-23 Thread Hernan Vargas
Reworded commit message for cosmetic queue initialization change. Hernan Vargas (1): drivers/baseband: device queues initialization drivers/baseband/acc/rte_acc100_pmd.c | 1 + drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 2 ++ drivers/baseband/fpga_lte_fec/fpga_lte_fec.c

[PATCH v2 1/1] drivers/baseband: device queues initialization

2024-08-23 Thread Hernan Vargas
Cosmetic change to keep code consistency in PMD for queue initialization set to zero. No functional impact. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 1 + drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 2 ++ drivers/baseband/fpga_lte_fec/fpga_lte

[PATCH] app/test-pmd: remove unnecessary cast

2024-08-23 Thread Stephen Hemminger
The list of builtin cmdline commands has unnecessary cast which blocks compiler type checking. Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c | 458 - 1 file changed, 229 insertions(+), 229 deletions(-) diff --git a/app/test-pmd/cmdline.c b/a

[PATCH v1 0/2] dts: port over unified packet type suite

2024-08-23 Thread Dean Marx
Port over unified packet type flag testing suite from old DTS. According to DPDK documentation, each Poll Mode Driver should reserve 32 bits of packet headers for unified packet type flags. These flags serve as an identifier for user applications, and are divided into subcategories: L2, L3, L4, tu

[PATCH v1 1/2] dts: add VXLAN port method to testpmd shell

2024-08-23 Thread Dean Marx
Add rx_vxlan_port add/rm method to testpmd shell for adding or removing a vxlan id to the specified port filter list. Port over set_verbose method from queue start/stop suite. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 47 +++ 1 file changed, 47

[PATCH v1 2/2] dts: port over unified packet suite

2024-08-23 Thread Dean Marx
Port over unified packet testing suite from old DTS. This suite tests the ability of the PMD to recognize valid or invalid packet flags. Depends-on: Patch-143033 ("dts: add text parser for testpmd verbose output") Depends-on: Patch-142691 ("dts: add send_packets to test suites and rework packet ad

[PATCH v2 0/2] dts: port over unified packet type suite

2024-08-23 Thread Dean Marx
Port over unified packet type flag testing suite from old DTS. According to DPDK documentation, each Poll Mode Driver should reserve 32 bits of packet headers for unified packet type flags. These flags serve as an identifier for user applications, and are divided into subcategories: L2, L3, L4, tu

[PATCH v2 1/2] dts: add VXLAN port method to testpmd shell

2024-08-23 Thread Dean Marx
Add rx_vxlan_port add/rm method to testpmd shell for adding or removing a vxlan id to the specified port filter list. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 23 +++ 1 file changed, 23 insertions(+) diff --git a/dts/framework/remote_session/t

[PATCH v2 2/2] dts: port over unified packet suite

2024-08-23 Thread Dean Marx
Port over unified packet testing suite from old DTS. This suite tests the ability of the PMD to recognize valid or invalid packet flags. Depends-on: Patch-143033 ("dts: add text parser for testpmd verbose output") Depends-on: Patch-142691 ("dts: add send_packets to test suites and rework packet ad

[PATCH v14 0/2] dts: port over VLAN test suite

2024-08-23 Thread Dean Marx
Port over VLAN capabilities test suite from old DTS. This test suite verifies that VLAN filtering, stripping, and header insertion all function as expected. When a VLAN ID is in the filter list, all packets with that ID should be forwarded and all others should be dropped. While stripping is enable

[PATCH v14 1/2] dts: add VLAN methods to testpmd shell

2024-08-23 Thread Dean Marx
added the following methods to testpmd shell class: vlan set filter on/off, rx vlan add/rm, vlan set strip on/off, port stop/start all/port, tx vlan set/reset, set promisc/verbose fixed bug in vlan_offload for show port info, removed $ at end of regex Signed-off-by: Dean Marx --- dts/framework/

[PATCH v14 2/2] dts: VLAN test suite implementation

2024-08-23 Thread Dean Marx
Test suite for verifying VLAN filtering, stripping, and insertion functionality on Poll Mode Driver. Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.json | 3 +- dts/tests/TestSuite_vlan.py| 167 + 2 files changed, 169 insertions(+), 1 del