Re: [PATCH v8 5/5] dts: add API doc generation

2024-08-05 Thread Juraj Linkeš
On 2. 8. 2024 15:53, Thomas Monjalon wrote: 02é x/08/2024 12:48, Juraj Linkeš: On 1. 8. 2024 17:07, Thomas Monjalon wrote: 01/08/2024 15:03, Juraj Linkeš: On 30. 7. 2024 15:51, Thomas Monjalon wrote: 12/07/2024 10:57, Juraj Linkeš: +dts_root = environ.get('DTS_ROOT') Why does it need to

[PATCH] net/virtio-user: reset used index counter in dev reset

2024-08-05 Thread Kommula Shiva Shankar
When the virtio device is reinitialized during ethdev reconfiguration, all the virtio rings are recreated and repopulated on the device. Accordingly, reset the used index counter value back to zero. Signed-off-by: Kommula Shiva Shankar --- drivers/net/virtio/virtio_user_ethdev.c | 1 + 1 file ch

Re: 22.11.6 patches review and test

2024-08-05 Thread Luca Boccassi
On Mon, 5 Aug 2024 at 06:45, YangHang Liu wrote: > > RedHat QE tested below 18 scenarios on RHEL 9.2 and didn't find any new dpdk > issues. > > VM with device assignment(PF) throughput testing(1G hugepage size): PASS > VM with device assignment(PF) throughput testing(2M hugepage size) : PASS > VM

Re: [PATCH v2 1/1] dts: add text parser for testpmd verbose output

2024-08-05 Thread Nicholas Pratte
> I like the sound of this idea a lot actually since it would remove the > chance of the output just completely being thrown away. In my own test > suite I managed to dance around this by strategically placing my > testpmd commands, but this could save people some headache in the > future. I feel l

[v1,1/5] raw/zxdh: introduce zxdh raw device driver

2024-08-05 Thread Yong Zhang
Introduce rawdev driver support for ZXDH which can help to connect two separate hosts with each other. Signed-off-by: Yong Zhang --- MAINTAINERS| 5 + doc/guides/rawdevs/index.rst | 1 + doc/guides/rawdevs/zxdh.rst| 29 + drivers/raw/meson.build| 1 +

[v1,2/5] raw/zxdh: add support for queue setup operation

2024-08-05 Thread Yong Zhang
Add queue initialization and release interface. Signed-off-by: Yong Zhang --- drivers/raw/zxdh/zxdh_rawdev.c | 241 + drivers/raw/zxdh/zxdh_rawdev.h | 19 +++ 2 files changed, 260 insertions(+) diff --git a/drivers/raw/zxdh/zxdh_rawdev.c b/drivers/raw/zxdh/zxdh_

[v1,3/5] raw/zxdh: add support for standard rawdev operations

2024-08-05 Thread Yong Zhang
Add support for rawdev operations such as dev_start and dev_stop. Signed-off-by: Yong Zhang --- drivers/raw/zxdh/zxdh_rawdev.c | 136 - drivers/raw/zxdh/zxdh_rawdev.h | 10 +++ 2 files changed, 145 insertions(+), 1 deletion(-) diff --git a/drivers/raw/zxdh/zxdh_

[v1,4/5] raw/zxdh: add support for enqueue operation

2024-08-05 Thread Yong Zhang
Add rawdev enqueue operation for zxdh devices. Signed-off-by: Yong Zhang --- drivers/raw/zxdh/zxdh_rawdev.c | 220 + drivers/raw/zxdh/zxdh_rawdev.h | 19 +++ 2 files changed, 239 insertions(+) diff --git a/drivers/raw/zxdh/zxdh_rawdev.c b/drivers/raw/zxdh/zxdh_r

[v1,5/5] raw/zxdh: add support for dequeue operation

2024-08-05 Thread Yong Zhang
Add rawdev dequeue operation for zxdh devices. Signed-off-by: Yong Zhang --- drivers/raw/zxdh/zxdh_rawdev.c | 113 + 1 file changed, 113 insertions(+) diff --git a/drivers/raw/zxdh/zxdh_rawdev.c b/drivers/raw/zxdh/zxdh_rawdev.c index 76b8f7f728..2019bd3704 100644

[PATCH] app/dma-perf: per device config support

2024-08-05 Thread Amit Prakash Shukla
Add support to configure device specific config parameters for a testcase. Example: lcore_dma0=lcore=11,dev=:00:04.1,dir=mem2dev,raddr=0x3, coreid=1,pfid=2,vfid=3 lcore_dma1=lcore=12,dev=:00:04.2,dir=dev2mem,raddr=0x2, coreid=3,pfid=2,vfid=1 Signed-off-by: Amit Prakash Shu

[PATCH v11 0/5] dts: API docs generation

2024-08-05 Thread Juraj Linkeš
The generation is done with Sphinx, which DPDK already uses, with slightly modified configuration of the sidebar present in an if block. DTS dependencies do not need to be installed, but there is the option to install doc build dependencies with Poetry: poetry install --with docs The build itself

[PATCH v11 1/5] dts: update params and parser docstrings

2024-08-05 Thread Juraj Linkeš
Address a few errors reported by Sphinx when generating documentation: framework/params/__init__.py:docstring of framework.params.modify_str:3: WARNING: Inline interpreted text or phrase reference start-string without end-string. framework/params/eal.py:docstring of framework.params.eal.Eal

[PATCH v11 2/5] dts: add doc generation dependencies

2024-08-05 Thread Juraj Linkeš
Sphinx imports every Python module (through the autodoc extension) when generating documentation from docstrings, meaning all DTS dependencies, including Python version, should be satisfied. This is not a hard requirement, as imports from dependencies may be mocked in the autodoc_mock_imports autod

[PATCH v11 3/5] dts: add API doc sources

2024-08-05 Thread Juraj Linkeš
These sources could be generated with the sphinx-apidoc utility, but that doesn't give us enough flexibility, such as sorting the order of modules or changing the headers of the modules. The sources included in this patch were in fact generated by said utility, but modified to improve the look of

[PATCH v11 4/5] doc: meson doc API build dir variable

2024-08-05 Thread Juraj Linkeš
The three instances of the path 'dpdk_build_root/doc/api' are replaced with a variable, moving the definition to one place. Signed-off-by: Juraj Linkeš Reviewed-by: Luca Vizzarro Reviewed-by: Jeremy Spewock Acked-by: Bruce Richardson Tested-by: Luca Vizzarro Tested-by: Nicholas Pratte --- d

[PATCH v11 5/5] dts: add API doc generation

2024-08-05 Thread Juraj Linkeš
The tool used to generate DTS API docs is Sphinx, which is already in use in DPDK. The same configuration is used to preserve style with one DTS-specific configuration (so that the DPDK docs are unchanged) that modifies how the sidebar displays the content. Sphinx generates the documentation from

Re: [v1,1/5] raw/zxdh: introduce zxdh raw device driver

2024-08-05 Thread Stephen Hemminger
On Mon, 5 Aug 2024 21:34:53 +0800 Yong Zhang wrote: > +struct zxdh_gdma_buff_desc { > + uint SrcAddr_L; > + uint DstAddr_L; > + uint Xpara; > + uint ZY_para; > + uint ZY_SrcStep; > + uint ZY_DstStep; > + uint ExtAddr; > + uint LLI_Addr_L; > + uint LLI_Addr_H;

[RFC v1 0/2] dts: Ethertype ethdev api test suite

2024-08-05 Thread Nicholas Pratte
Some general input would be helpful in understanding the validity of certain test cases within this suite. Each test case is based on the old DTS test plan. As it currently exists, none of the NICs available for testing (Intel, Broadcom, Mellanox) properly interface with ethdev api functions relate

[RFC v1 1/2] dts: add additional vlan configuration to testpmd shell class

2024-08-05 Thread Nicholas Pratte
The ethertype test suite requires many different internal runtime vlan offload options to test ethertype configuration. The following patch adds a new RxVlanOffloadOptions class that contains all the different vlan configuration options available within testpmd. Additionally, an extra method has b

[RFC v1 2/2] dts: port ethertype ethdev api test suite to new dts framework

2024-08-05 Thread Nicholas Pratte
Based off the test cases from the old DTS test suite, the following test suite assess the behavior of ethertype configuration options found within the ethdev api. Bugzilla-ID: 1505 depends-on: 142696 ("dts: add VLAN methods to testpmd shell") depends-on: 142762 ("dts: add text parser for testpmd

[DPDK/testpmd Bug 1514] mlx5 NIC reports checksum unknown when an invalid checksum is present

2024-08-05 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1514 Bug ID: 1514 Summary: mlx5 NIC reports checksum unknown when an invalid checksum is present Product: DPDK Version: unspecified Hardware: All OS: All Sta

[PATCH] net/iavf: fix core dump when the link is unstable

2024-08-05 Thread Kaiwen Deng
Physical link instability may cause a core dump. Unstable physical links can result in a large number of link change events.Link change events captured by vf before vf resources are allocated will result in a core dump. This commit will check if vf_res is invalid before calling it. Fixes: 5e03e31

[v2 0/3] L3fwd changes

2024-08-05 Thread Gagandeep Singh
v2 changes: * Handled a comment to enhance the invalid port ID logic and added a user option to decide exit or silently skip in case invalid port in the rules list. Gagandeep Singh (3): examples/l3fwd: support single route file examples/l3fwd: fix return value on rules add examples/l

[v2 1/3] examples/l3fwd: support single route file

2024-08-05 Thread Gagandeep Singh
IPv6 rules file needs to be specified together with IPv4 rules file to configure user given rules. But if user want to give only IPv4 or only IPv6 rules, application returns error: "Missing 1 or more rule files" With this patch application can accept only IPv4, only IPv6 or both IP rules. Signed-

[v2 2/3] examples/l3fwd: fix return value on rules add

2024-08-05 Thread Gagandeep Singh
fix return value on adding the EM or LPM rules. Fixes: e7e6dd643092 ("examples/l3fwd: support config file for EM") Fixes: 52def963fc1c ("examples/l3fwd: support config file for LPM/FIB") Cc: sean.morris...@intel.com Cc: sta...@dpdk.org Signed-off-by: Gagandeep Singh --- examples/l3fwd/em_route_

[v2 3/3] examples/l3fwd: enhance valid ports checking

2024-08-05 Thread Gagandeep Singh
The current port ID validation logic in the routes add code has two issues: - It can pass if port ID in route is 31+. - It silently skips rules with disabled or invalid port IDs This patch is: - Improving the enabled port IDs check logic. - Introducing a user option, "exit_on_failure", to

Re: Portable alternative to inet_ntop?

2024-08-05 Thread Tyler Retzlaff
On Wed, Jul 24, 2024 at 09:21:13AM -0700, Stephen Hemminger wrote: > The function inet_ntop is useful to make printable addresses for debugging. > It is available on Linux and FreeBSD but not on Windows. i know my reply is late. but the following wasn't usable? https://learn.microsoft.com/en-us/wi

Re: [RFC] ethdev: convert string initialization

2024-08-05 Thread Tyler Retzlaff
On Thu, Aug 01, 2024 at 02:27:22AM -0700, Ferruh Yigit wrote: > gcc 15 experimental [1], with -Wextra flag, gives warning in variable > initialization as string [2]. > > The warning has a point when initialized variable is intended to use as > string, since assignment is missing the required null

[PATCH v12 0/5] dts: API docs generation

2024-08-05 Thread Juraj Linkeš
The generation is done with Sphinx, which DPDK already uses, with slightly modified configuration of the sidebar present in an if block. DTS dependencies do not need to be installed, but there is the option to install doc build dependencies with Poetry: poetry install --with docs The build itself

[PATCH v12 1/5] dts: update params and parser docstrings

2024-08-05 Thread Juraj Linkeš
Address a few errors reported by Sphinx when generating documentation: framework/params/__init__.py:docstring of framework.params.modify_str:3: WARNING: Inline interpreted text or phrase reference start-string without end-string. framework/params/eal.py:docstring of framework.params.eal.Eal

[PATCH v12 2/5] dts: add doc generation dependencies

2024-08-05 Thread Juraj Linkeš
Sphinx imports every Python module (through the autodoc extension) when generating documentation from docstrings, meaning all DTS dependencies, including Python version, should be satisfied. This is not a hard requirement, as imports from dependencies may be mocked in the autodoc_mock_imports autod

[PATCH v12 3/5] dts: add API doc sources

2024-08-05 Thread Juraj Linkeš
These sources could be generated with the sphinx-apidoc utility, but that doesn't give us enough flexibility, such as sorting the order of modules or changing the headers of the modules. The sources included in this patch were in fact generated by said utility, but modified to improve the look of

[PATCH v12 4/5] doc: meson doc API build dir variable

2024-08-05 Thread Juraj Linkeš
The three instances of the path 'dpdk_build_root/doc/api' are replaced with a variable, moving the definition to one place. Signed-off-by: Juraj Linkeš Reviewed-by: Luca Vizzarro Reviewed-by: Jeremy Spewock Acked-by: Bruce Richardson Tested-by: Luca Vizzarro Tested-by: Nicholas Pratte --- d

[PATCH v12 5/5] dts: add API doc generation

2024-08-05 Thread Juraj Linkeš
The tool used to generate DTS API docs is Sphinx, which is already in use in DPDK. The same configuration is used to preserve style with one DTS-specific configuration (so that the DPDK docs are unchanged) that modifies how the sidebar displays the content. Sphinx generates the documentation from