On Thu, Aug 01, 2024 at 12:04:42PM -0700, Stephen Hemminger wrote:
> Some tests for new packet dissector.
>
> Signed-off-by: Stephen Hemminger
> ---
> app/test/meson.build| 1 +
> app/test/test_dissect.c | 245
> 2 files changed, 246 insertions(+)
>
Hi,
> -Original Message-
> From: Konstantin Ananyev
> Sent: Wednesday, July 24, 2024 1:32 PM
> To: Konstantin Ananyev ; Gagandeep
> Singh ; dev@dpdk.org; Konstantin Ananyev
> ; Sean Morrissey
>
> Cc: sta...@dpdk.org
> Subject: RE: [PATCH 3/3] examples/l3fwd: fix maximum acceptable port I
On 1. 8. 2024 17:07, Thomas Monjalon wrote:
01/08/2024 15:03, Juraj Linkeš:
On 30. 7. 2024 15:51, Thomas Monjalon wrote:
12/07/2024 10:57, Juraj Linkeš:
The tool used to generate DTS API docs is Sphinx, which is already in
use in DPDK. The same configuration is used to preserve style with o
> From: lihuisong (C) [mailto:lihuis...@huawei.com]
> Sent: Friday, 2 August 2024 04.23
>
> 在 2024/8/2 0:03, Morten Brørup 写道:
> > void
> > -virtio_update_packet_stats(struct virtnet_stats *stats, struct
> rte_mbuf *mbuf)
> > +virtio_update_packet_stats(struct virtnet_stats *const stats,
> > +
As part of the meson build, we can record the dependencies for each
component as we process it, logging them to a file. This file can be
used as input to a number of other scripts and tools, for example, to
graph the dependencies, or to allow higher-level build-config tools to
automatically enable
As meson processes our DPDK source tree it manages dependencies
specified by each individual driver. To enable future analysis of the
dependency links between components, log the dependencies of each DPDK
component as it gets processed. This could potentially allow other tools
to automatically enab
While not a serious problem, DPDK components often list more
dependencies than are actually necessary to build, due to the use of
recursive dependencies. In extreme cases, such as with core libraries,
this can lead to longer configuration times due to meson having to
deduplicate long lists of depen
The kvargs library is used by EAL, and therefore is implicitly a
dependency of every DPDK driver. Remove it from the minimum set of
dependencies for each driver class as it's unnecessary to call it out
there.
Signed-off-by: Bruce Richardson
---
drivers/event/meson.build | 2 +-
drivers/net/meson
Rather than having each library depend up on EAL + any extra libs, we
can take advantage of recursive dependency support in meson and
just assign the dependencies of each directory directly, rather than
appending to the array. For libraries which only depend upon EAL, keep
that as a default, but fo
Remove any unnecessary dependencies from the driver dependency lists.
This will give each driver a near-minimum set of required dependencies.
Signed-off-by: Bruce Richardson
---
drivers/baseband/fpga_5gnr_fec/meson.build | 2 +-
drivers/baseband/fpga_lte_fec/meson.build | 2 +-
drivers/baseband
Remove any unnecessary dependencies from the app dependency lists.
This will give each app a near-minimum set of required dependencies.
Signed-off-by: Bruce Richardson
---
app/dumpcap/meson.build | 2 +-
app/graph/meson.build| 2 +-
app/pdump/meson.build| 2 +-
a
Rather than the single monolithic graph that would be output from the
deps.dot file in a build directory, we can post-process that to generate
simpler graphs for different tasks. This new "draw_dependency_graphs"
script takes the "deps.dot" as input and generates an output file that
has the nodes c
> From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> Sent: Friday, 2 August 2024 14.44
>
> As part of the meson build, we can record the dependencies for each
> component as we process it, logging them to a file. This file can be
> used as input to a number of other scripts and tools, fo
01/08/2024 21:39, Patrick Robb:
> * Do we want to add DTS items to release notes?
>* What is the process for building the release notes? Should the
> people working on DTS aggregate the updates and submit them? Patrick
> Robbshould check the website for the release notes process, or email
> the
On Thu, Aug 1, 2024 at 4:41 AM Luca Vizzarro wrote:
>
> Great work Jeremy! Just a couple of minor passable improvement points.
>
> On 30/07/2024 14:34, jspew...@iol.unh.edu wrote:
>
> > +@dataclass
> > +class TestPmdVerbosePacket(TextParser):
> > +"""Packet information provided by verbose outp
On Thu, Aug 1, 2024 at 4:43 AM Luca Vizzarro wrote:
>
> On 30/07/2024 22:33, Jeremy Spewock wrote:
> > On Tue, Jul 30, 2024 at 9:37 AM wrote:
> >
> >> +class VerboseOLFlag(Flag):
> >> +"""Flag representing the OL flags of a packet from Testpmd verbose
> >> output."""
> >> +
> >> +#:
> >
02é x/08/2024 12:48, Juraj Linkeš:
> On 1. 8. 2024 17:07, Thomas Monjalon wrote:
> > 01/08/2024 15:03, Juraj Linkeš:
> >> On 30. 7. 2024 15:51, Thomas Monjalon wrote:
> >>> 12/07/2024 10:57, Juraj Linkeš:
> +dts_root = environ.get('DTS_ROOT')
> >>>
> >>> Why does it need to be passed as an env
> On Aug 2, 2024, at 8:34 AM, Thomas Monjalon wrote:
>
> 01/08/2024 21:39, Patrick Robb:
>> * Do we want to add DTS items to release notes?
>> * What is the process for building the release notes? Should the
>> people working on DTS aggregate the updates and submit them? Patrick
>> Robbshould
Optimized the performance of updating the statistics counters by reducing
the number of branches.
Ordered the packet size comparisons according to the probability with
typical internet traffic mix.
Signed-off-by: Morten Brørup
---
lib/vhost/virtio_net.c | 40 ++--
Optimized the performance of updating the statistics counters by reducing
the number of branches.
Ordered the packet size comparisons according to the probability with
typical internet traffic mix.
Signed-off-by: Morten Brørup
---
drivers/net/netvsc/hn_rxtx.c | 32 ++
02/08/2024 16:31, Honnappa Nagarahalli:
>
> > On Aug 2, 2024, at 8:34 AM, Thomas Monjalon wrote:
> >
> > 01/08/2024 21:39, Patrick Robb:
> >> * Do we want to add DTS items to release notes?
> >> * What is the process for building the release notes? Should the
> >> people working on DTS aggrega
> From: Morten Brørup [mailto:m...@smartsharesystems.com]
> Sent: Thursday, 1 August 2024 22.38
>
> > From: Stephen Hemminger [mailto:step...@networkplumber.org]
> > Sent: Thursday, 1 August 2024 18.18
> >
> > On Thu, 1 Aug 2024 16:03:12 +
> > Morten Brørup wrote:
> >
> > > Optimized the per
> You're right that in most cases it would come from the stop output,
> but the output from that stop command has one other thing as well that
> I would consider valuable which is statistics of packets handled by
> ports specifically for the duration of the packet forwarding you are
> stopping. It
I saw there was one fail for this series for the Marvell MVNETA container.
I thought I should also mention that the build did fail when our
automation tried to run DTS on the Octeon CN10K DPU (which is also
Marvell). So, that is why you won't get a report for the CN10K DTS
results.
Let me know if
On Fri, Aug 02, 2024 at 11:05:58AM -0400, Patrick Robb wrote:
> I saw there was one fail for this series for the Marvell MVNETA container.
>
> I thought I should also mention that the build did fail when our
> automation tried to run DTS on the Octeon CN10K DPU (which is also
> Marvell). So, that
On Thu, Aug 01, 2024 at 10:29:08AM -0700, Stephen Hemminger wrote:
> Simple script to read a file and make it into a initialized
> C string in a header file.
>
> Signed-off-by: Stephen Hemminger
> ---
> buildtools/gen-header.py | 36
> buildtools/meson.build
On Thu, Aug 01, 2024 at 10:29:09AM -0700, Stephen Hemminger wrote:
> This API was used only for cfgfile tests and was never built
> after the conversion to meson. Will be replaced by simpler
> method of doing cfgfile tests.
>
> Signed-off-by: Stephen Hemminger
> ---
It's always there in git hist
On Thu, Aug 01, 2024 at 10:29:10AM -0700, Stephen Hemminger wrote:
> These tests were not built since the conversion to meson.
> Instead of using embedded resource functions, put data in include
> file and generate temporary file before the test.
>
> Signed-off-by: Stephen Hemminger
> ---
> app/
The cfgfile tests did not get built since conversion to meson
and they used an awkward way to manage the test data.
This patchset converts the tests to use a helper to take
text file and make it into a C header. Then use the C header
to generate temporary files as needed.
v5 - rearrange tests inp
Simple script to read a file and make it into a initialized
C string in a header file.
Signed-off-by: Stephen Hemminger
Acked-by: Bruce Richardson
---
buildtools/gen-header.py | 36
buildtools/meson.build | 2 +-
2 files changed, 37 insertions(+), 1 delet
This API was used only for cfgfile tests and was never built
after the conversion to meson. Will be replaced by simpler
method of doing cfgfile tests.
Signed-off-by: Stephen Hemminger
Acked-by: Bruce Richardson
---
app/test/meson.build | 2 -
app/test/resource.c | 276 ---
These tests were not built since the conversion to meson.
Instead of using embedded resource functions, put data in include
file and generate temporary file before the test.
The changes to app/test/meson.build are to handle auto-generated
files (resources) differently. Don't scan these files to lo
The input files don't need to be in a separate subdirectory.
Signed-off-by: Stephen Hemminger
---
app/test/test_cfgfiles/{etc => }/empty.ini | 0
.../test_cfgfiles/{etc => }/empty_key_value.ini | 0
.../test_cfgfiles/{etc => }/invalid_section.ini | 0
.../test_cfgfiles/{etc => }/line_
> Subject: [PATCH] netvsc: optimize stats counters performance
>
> Optimized the performance of updating the statistics counters by reducing the
> number of branches.
>
> Ordered the packet size comparisons according to the probability with typical
> internet traffic mix.
>
> Signed-off-by: Mort
On Fri, Aug 02, 2024 at 09:45:03AM -0700, Stephen Hemminger wrote:
> The input files don't need to be in a separate subdirectory.
>
> Signed-off-by: Stephen Hemminger
Small suggestion - I'd move this up to be patch 3, rather than patch 4,
which would save editing the list in the meson.build file
On Fri, Aug 02, 2024 at 09:45:02AM -0700, Stephen Hemminger wrote:
> These tests were not built since the conversion to meson.
> Instead of using embedded resource functions, put data in include
> file and generate temporary file before the test.
>
> The changes to app/test/meson.build are to hand
On 8/2/2024 1:44 PM, Bruce Richardson wrote:
> As part of the meson build, we can record the dependencies for each
> component as we process it, logging them to a file. This file can be
> used as input to a number of other scripts and tools, for example, to
> graph the dependencies, or to allow hig
> From: Long Li [mailto:lon...@microsoft.com]
> Sent: Friday, 2 August 2024 18.49
>
> > Subject: [PATCH] netvsc: optimize stats counters performance
> >
> > Optimized the performance of updating the statistics counters by
> reducing the
> > number of branches.
> >
> > Ordered the packet size compa
From: Jeremy Spewock
This series ports over the functionality of the stats_checks test suite
from old DTS, but I left it as an RFC just because the verification is
different than other test suites that we have written. Mainly because
verifying the accuracy of the port statistics while accounting
From: Jeremy Spewock
Methods currently exist for querying the statistics of a port in
testpmd, but there weren't methods added for clearing the current
statistics on a port. This patch adds methods that allow you to clear
the statistics of a single port or all ports to account for situations
wher
From: Jeremy Spewock
This patch adds a new test suite to DTS that validates the accuracy of
the port statistics using testpmd. The functionality is tested by
sending a packet of a fixed side to the SUT and verifying that the
statistic for packets received, received bytes, packets sent, and sent
b
From: Jeremy Spewock
Adding the test suite to the yaml schema allows for users to specify it
in their conf.yaml files and run the suite in their test runs.
Signed-off-by: Jeremy Spewock
---
dts/framework/config/conf_yaml_schema.json | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
On Fri, Aug 2, 2024 at 10:54 AM Nicholas Pratte wrote:
>
>
> > You're right that in most cases it would come from the stop output,
> > but the output from that stop command has one other thing as well that
> > I would consider valuable which is statistics of packets handled by
> > ports specifica
While debugging TAP rte_flow discovered that test pmd verbose output
was confusing and unhelpful. Instead, made a simple dissector that
prints one line per packet like this in test-pmd with verbose level 4.
v6 - validate result of rte_dissect for simple packet
v5 - breakout the additional ICMP ty
Add more defines for additional defined ICMP types.
Signed-off-by: Stephen Hemminger
---
lib/net/rte_icmp.h | 22 ++
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git a/lib/net/rte_icmp.h b/lib/net/rte_icmp.h
index 4bf64d70ad..b51b60a6d2 100644
--- a/lib/net/rte_ic
The function rte_dissect_mbuf is used to decode the contents
of an mbuf into ah uman readable format similar to what tshark uses.
For now, handles IP, IPv6, TCP, UDP, ICMP and ARP.
Signed-off-by: Stephen Hemminger
---
lib/net/meson.build | 2 +
lib/net/rte_dissect.c | 416 ++
Add some tests for new packet dissector.
Signed-off-by: Stephen Hemminger
---
app/test/meson.build| 1 +
app/test/test_dissect.c | 253
2 files changed, 254 insertions(+)
create mode 100644 app/test/test_dissect.c
diff --git a/app/test/meson.build
The existing verbose levels 1..3 provide a messy multi-line
output per packet. I found this unhelpful when diagnosing many
types of problems like packet flow.
This patch keeps the previous levels and adds two new levels:
4: one line per packet is printed in a format resembling
tshark output. Wi
Hi All,
We are facing issue with X710 + SRIOV.
Some how packets coming to queue 0 only . Same Nic sriov are shared between
a vm using dpdk and other vm using Linux interfaces. Can anyone provide
any direction?
We are using vpp 2106 with dpdk 2102. I know it’s old but any hint
might help.
Thank
Hey Nick,
Looks good to me, I just had one comment about what looks like a
mistake in a merge, and then another more general question.
On Fri, Jul 26, 2024 at 10:13 AM Nicholas Pratte wrote:
>
> Testpmd offers mtu configuration options that omit ethernet overhead
> calculations when set. This pa
Just some very light comments here as well, mostly about doc-string
but also a few questions/suggestions.
On Fri, Jul 26, 2024 at 10:14 AM Nicholas Pratte wrote:
> diff --git a/dts/tests/TestSuite_jumboframes.py
> b/dts/tests/TestSuite_jumboframes.py
> new file mode 100644
> index 00..d
While debugging TAP rte_flow discovered that test pmd verbose output
was confusing and unhelpful. Instead, made a simple dissector that
prints one line per packet like this in test-pmd with verbose level 4.
v7 - change rte_dissect to return number of characters that would
be printed (same as
Add more defines for additional defined ICMP types.
Signed-off-by: Stephen Hemminger
---
lib/net/rte_icmp.h | 22 ++
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git a/lib/net/rte_icmp.h b/lib/net/rte_icmp.h
index 4bf64d70ad..b51b60a6d2 100644
--- a/lib/net/rte_ic
The function rte_dissect_mbuf is used to decode the contents
of an mbuf into ah uman readable format similar to what tshark uses.
For now, handles IP, IPv6, TCP, UDP, ICMP and ARP.
Signed-off-by: Stephen Hemminger
---
lib/net/meson.build | 2 +
lib/net/rte_dissect.c | 428 ++
Add some tests for new packet dissector.
Signed-off-by: Stephen Hemminger
---
app/test/meson.build| 1 +
app/test/test_dissect.c | 302
2 files changed, 303 insertions(+)
create mode 100644 app/test/test_dissect.c
diff --git a/app/test/meson.build
The existing verbose levels 1..3 provide a messy multi-line
output per packet. I found this unhelpful when diagnosing many
types of problems like packet flow.
This patch keeps the previous levels and adds two new levels:
4: one line per packet is printed in a format resembling
tshark output. Wi
On Fri, Jul 26, 2024 at 12:39 PM Nicholas Pratte wrote:
>
> New methods have been added to TestPMDShell in order to produce the mac
> filter's individual test cases:
> - set_mac_addr
> - set_multicast_mac_addr
>
> set_mac_addr and set_multicast_addr were created for the mac filter test
> suite,
On Fri, Jul 26, 2024 at 12:39 PM Nicholas Pratte wrote:
>
> The mac address filter test suite, whose test cases are based on old
> DTS's test cases, has been refactored to interface with the new DTS
> framework.
>
> In porting over this test suite into the new framework, some
> adjustments were ma
Just a few small comments, otherwise:
Reviewed-by: Jeremy Spewock
On Fri, Jul 26, 2024 at 12:46 PM Nicholas Pratte wrote:
>
> The mac address filter test suite, whose test cases are based on old
> DTS's test cases, has been refactored to interface with the new DTS
> framework.
>
> In porting ov
Oops, I just reviewed an older version without realizing this one
existed, haha. Although, seeing the full diff again I saw a few
documentation nit-picks that I put below.
On Fri, Jul 26, 2024 at 12:45 PM Nicholas Pratte wrote:
>
> New methods have been added to TestPMDShell in order to produce t
Apologies, sent reviews in the wrong order so I am sending another
reply to this one just to make sure it appears second in people's
inboxes for less confusion.
I think Luca made some great points and I agree with what he said, I
just had one other though as well. Great work!
On Fri, Jul 26, 2024 at 10:22 AM Dean Marx wrote:
> +
> class TestPmdShell(DPDKShell):
> """Testpmd interactive shell.
>
> @@ -804,6 +841,25 @@ def show_port_stats(self, port
On Thu, Aug 1, 2024 at 5:24 AM Luca Vizzarro wrote:
>
> Hi Dean, thank you for your work! Some minor comments.
>
> On 26/07/2024 15:15, Dean Marx wrote:
> > add dataclass for passing in flow rule creation arguments, as well as a
> > __str__ method for converting to a sendable testpmd command. Add
63 matches
Mail list logo
