[DPDK/core Bug 1501] rte_cpu_get_flag_enabled() segmentation fault

2024-07-26 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1501 Bug ID: 1501 Summary: rte_cpu_get_flag_enabled() segmentation fault Product: DPDK Version: 21.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[PATCH V2] doc: add tested Intel platforms with Intel NICs

2024-07-26 Thread Lingli Chen
Add tested Intel platforms with Intel NICs to v24.07 release note. Signed-off-by: Lingli Chen --- doc/guides/rel_notes/release_24_07.rst | 137 + 1 file changed, 137 insertions(+) diff --git a/doc/guides/rel_notes/release_24_07.rst b/doc/guides/rel_notes/release_24_07.r

[V1] doc: announce deprecation of flow item VXLAN-GPE

2024-07-26 Thread Gavin Li
Adding the deprecation notice as reminder for removing RTE_FLOW_ITEM_TYPE_VXLAN_GPE and its related structures, eg. rte_vxlan_gpe_hdr, rte_flow_item_vxlan_gpe, etc. The proposed time of the removal is DPDK release 25.11. Signed-off-by: Gavin Li --- doc/guides/rel_notes/deprecation.rst | 7 +

[DPDK/examples Bug 1502] [dpdk-24.07] l3fwdacl/l3fwdacl_acl_rule: core dump when receiving packets

2024-07-26 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1502 Bug ID: 1502 Summary: [dpdk-24.07] l3fwdacl/l3fwdacl_acl_rule: core dump when receiving packets Product: DPDK Version: 24.07 Hardware: x86 OS: Linux Sta

Re: [PATCH v2] net/gve: Fix TX/RX queue setup and stop

2024-07-26 Thread Tathagat Priyadarshi
Hi @Ferruh Yigit I have updated v2 https://patches.dpdk.org/project/dpdk/patch/1721914264-2394611-1-git-send-email-tathagat.d...@gmail.com/ and sent it in reply to the previous message id ( https://patches.dpdk.org/project/dpdk/patch/1721828129-2393364-1-git-send-email-tathagat.d...@gmail.com/) ,

Re: [PATCH v6 0/3] Improve interactive shell output gathering and logging

2024-07-26 Thread Juraj Linkeš
For series: Reviewed-by: Juraj Linkeš On 24. 7. 2024 20:39, jspew...@iol.unh.edu wrote: From: Jeremy Spewock v6: * Fix error catch for retries. This series changed the error that is thrown in the case of a timeout, but it was originally overlooked that the context manager patch adde

Re: [V1] doc: announce deprecation of flow item VXLAN-GPE

2024-07-26 Thread Ferruh Yigit
On 7/26/2024 9:51 AM, Gavin Li wrote: > Adding the deprecation notice as reminder for removing > RTE_FLOW_ITEM_TYPE_VXLAN_GPE and its related structures, > eg. rte_vxlan_gpe_hdr, rte_flow_item_vxlan_gpe, etc. > > The proposed time of the removal is DPDK release 25.11. > > Signed-off-by: Gavin Li

Re: [PATCH v2] net/gve: Fix TX/RX queue setup and stop

2024-07-26 Thread Ferruh Yigit
On 7/26/2024 11:37 AM, Tathagat Priyadarshi wrote: > Hi @Ferruh Yigit   > > I have updated v2 https://patches.dpdk.org/project/dpdk/ > patch/1721914264-2394611-1-git-send-email-tathagat.d...@gmail.com/ >

RE: Portable alternative to inet_ntop?

2024-07-26 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, 24 July 2024 18.21 > > The function inet_ntop is useful to make printable addresses for > debugging. > It is available on Linux and FreeBSD but not on Windows. > > There are some alternatives: > - add yet another O

[RFC PATCH v1 0/1] Add Visual Studio Code configuration script

2024-07-26 Thread Anatoly Burakov
Lots of developers (myself included) uses Visual Studio Code as their primary IDE for DPDK development. I have been successfully using various incarnations of this script internally to quickly set up my development trees whenever I need a new configuration, so this script is being shared in hopes t

[RFC PATCH v1 1/1] devtools: add vscode configuration generator

2024-07-26 Thread Anatoly Burakov
A lot of developers use Visual Studio Code as their primary IDE. This script generates a configuration file for VSCode that sets up basic build tasks, launch tasks, as well as C/C++ code analysis settings that will take into account compile_commands.json that is automatically generated by meson. F

[PATCH v1] dts: add flow rule dataclass to testpmd shell

2024-07-26 Thread Dean Marx
add dataclass for passing in flow rule creation arguments, as well as a __str__ method for converting to a sendable testpmd command. Add flow_create method to TestPmdShell class for intializing flow rules. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 66 ++

[RFC PATCH v3 0/2] Initial Implementation For Jumbo Frames

2024-07-26 Thread Nicholas Pratte
v3: * Refactored to use TestPMDShell context manager. NOTE: Assessing the boundaries and discern the correct assumption for ethernet overhead is still to be discussed. Thus, while each individual test case may pass, the test cases may not yet be precise. Nicholas Pratte (2): dts: add port con

[RFC PATCH v3 1/2] dts: add port config mtu options to testpmd shell

2024-07-26 Thread Nicholas Pratte
Testpmd offers mtu configuration options that omit ethernet overhead calculations when set. This patch adds easy-of-use methods to leverage these runtime options. Bugzilla ID: 1421 Signed-off-by: Nicholas Pratte --- dts/framework/remote_session/testpmd_shell.py | 20 ++- 1 file

[RFC PATCH v3 2/2] dts: Initial Implementation For Jumbo Frames Test Suite

2024-07-26 Thread Nicholas Pratte
The following test suite reflects the fundamental outline for how the jumbo frames test suite may be designed. The test suite consists of five individual test cases, each of which assesses the behavior of packet transmissions for both 1518 byte and 9000 byte frames. The edge cases are ripped direc

[RFC PATCH v3 0/2] Initial Implementation For Jumbo Frames

2024-07-26 Thread Nicholas Pratte
v3: * Refactored to use TestPMDShell context manager. NOTE: Assessing the boundaries and discern the correct assumption for ethernet overhead is still to be discussed. Thus, while each individual test case may pass, the test cases may not yet be precise. Nicholas Pratte (2): dts: add port con

[PATCH v2] dts: add flow rule dataclass to testpmd shell

2024-07-26 Thread Dean Marx
add dataclass for passing in flow rule creation arguments, as well as a __str__ method for converting to a sendable testpmd command. Add flow_create method to TestPmdShell class for initializing flow rules. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 58 +

[PATCH v1] dts: add flow rule dataclass to testpmd shell

2024-07-26 Thread Dean Marx
add dataclass for passing in flow rule creation arguments, as well as a __str__ method for converting to a sendable testpmd command. Add flow_create method to TestPmdShell class for initializing flow rules. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 58 +

Re: [PATCH v3 1/4] dts: add send_packets to test suites and rework packet addressing

2024-07-26 Thread Nicholas Pratte
This is great, I'll be using this in-favor of the boolean solution that I implemented! Just to bring this to your attention. I am currently working on some Generic Routing Encapsulation suites the require multiple IP layers at packet creation; they look something like: Ether() / IP() / GRE() / IP(

[DPDK/DTS Bug 1503] Port over vxlan gpe support suite from old DTS

2024-07-26 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1503 Bug ID: 1503 Summary: Port over vxlan gpe support suite from old DTS Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

Re: [RFC PATCH v1 1/1] devtools: add vscode configuration generator

2024-07-26 Thread Stephen Hemminger
On Fri, 26 Jul 2024 13:42:56 +0100 Anatoly Burakov wrote: > A lot of developers use Visual Studio Code as their primary IDE. This > script generates a configuration file for VSCode that sets up basic build > tasks, launch tasks, as well as C/C++ code analysis settings that will > take into accoun

Re: [RFC PATCH v1 1/1] devtools: add vscode configuration generator

2024-07-26 Thread Burakov, Anatoly
On 7/26/2024 5:36 PM, Stephen Hemminger wrote: On Fri, 26 Jul 2024 13:42:56 +0100 Anatoly Burakov wrote: A lot of developers use Visual Studio Code as their primary IDE. This script generates a configuration file for VSCode that sets up basic build tasks, launch tasks, as well as C/C++ code an

[PATCH] doc: announce fib configuration structure changes

2024-07-26 Thread Vladimir Medvedkin
Announce addition of the flags field into rte_fib_conf structure. Signed-off-by: Vladimir Medvedkin --- doc/guides/rel_notes/deprecation.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 6948641ff6..d4d6

Re: How does CI system get updated?

2024-07-26 Thread Patrick Robb
Okay I understand better now how we ended up with an older mingw64 version. The DPDK Docs for windows compile direct folks over to (https://sourceforge.net/projects/mingw-w64/files/) to get the prebuilt binaries, but the latest toolchain published there is Mingw64 v8.*, whereas the current version

Re: [PATCH] doc: announce fib configuration structure changes

2024-07-26 Thread Robin Jarry
Vladimir Medvedkin, Jul 26, 2024 at 18:13: Announce addition of the flags field into rte_fib_conf structure. Signed-off-by: Vladimir Medvedkin Acked-by: Robin Jarry

[PATCH v4 0/2] Mac Filter Port to New DTS

2024-07-26 Thread Nicholas Pratte
v4: * Refactored test suite to use context manager. * Added dependencies for vlan testpmd methods and adjust addresses. Nicholas Pratte (2): dts: add methods for setting mac and multicast addresses dts: mac filter test suite refactored for new dts dts/framework/config/conf_yaml_schem

[PATCH v4 1/2] dts: add methods for setting mac and multicast addresses

2024-07-26 Thread Nicholas Pratte
New methods have been added to TestPMDShell in order to produce the mac filter's individual test cases: - set_mac_addr - set_multicast_mac_addr set_mac_addr and set_multicast_addr were created for the mac filter test suite, enabling users to both add or remove mac and multicast addresses based o

[PATCH v4 2/2] dts: mac filter test suite refactored for new dts

2024-07-26 Thread Nicholas Pratte
The mac address filter test suite, whose test cases are based on old DTS's test cases, has been refactored to interface with the new DTS framework. In porting over this test suite into the new framework, some adjustments were made, namely in the EAL and TestPMD parameter provided before executing

[PATCH v4 1/2] dts: add methods for setting mac and multicast addresses

2024-07-26 Thread Nicholas Pratte
New methods have been added to TestPMDShell in order to produce the mac filter's individual test cases: - set_mac_addr - set_multicast_mac_addr set_mac_addr and set_multicast_addr were created for the mac filter test suite, enabling users to both add or remove mac and multicast addresses based o

[PATCH v4 2/2] dts: mac filter test suite refactored for new dts

2024-07-26 Thread Nicholas Pratte
The mac address filter test suite, whose test cases are based on old DTS's test cases, has been refactored to interface with the new DTS framework. In porting over this test suite into the new framework, some adjustments were made, namely in the EAL and TestPMD parameter provided before executing

[PATCH v4 2/4] config/arm: adds Arm Neoverse N3 SoC

2024-07-26 Thread Wathsala Vithanage
Add Arm Neoverse N3 part number to build configuration. Signed-off-by: Wathsala Vithanage Reviewed-by: Dhruv Tripathi --- config/arm/meson.build | 31 ++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/config/arm/meson.build b/config/arm/meson.build i

[PATCH v4 3/4] eal: add Arm WFET in power management intrinsics

2024-07-26 Thread Wathsala Vithanage
Wait for event with timeout (WFET) puts the CPU in a low power mode and stays there until an event is signalled (SEV), loss of an exclusive monitor or a timeout. WFET is enabled selectively by checking FEAT_WFxT in Linux auxiliary vector. If FEAT_WFxT is not available power management will fallback

[PATCH v4 4/4] eal: describe Arm CPU features including WFXT

2024-07-26 Thread Wathsala Vithanage
Add descriptive comments to each Arm feature listed in rte_cpu_flag_t. Signed-off-by: Wathsala Vithanage Reviewed-by: Honnappa Nagarahalli Reviewed-by: Dhruv Tripathi --- lib/eal/arm/include/rte_cpuflags_64.h | 48 +++ 1 file changed, 48 insertions(+) diff --git a/lib

[PATCH v4 1/4] eal: expand the availability of WFE and related instructions

2024-07-26 Thread Wathsala Vithanage
The availability of __RTE_ARM_WFE, __RTE_ARM_SEV, __RTE_ARM_SEVL, and __RTE_ARM_LOAD_EXC_* macros for other applications, such as PMD power management, should not depend on the choice of use of these instructions in rte_wait_until_equal_N functions. Therefore, this patch moves these macros out of

Re: How does CI system get updated?

2024-07-26 Thread Stephen Hemminger
On Fri, 26 Jul 2024 12:34:25 -0400 Patrick Robb wrote: > Okay I understand better now how we ended up with an older mingw64 > version. The DPDK Docs for windows compile direct folks over to > (https://sourceforge.net/projects/mingw-w64/files/) to get the > prebuilt binaries, but the latest toolch

RE: [PATCH] eal: add support for TRNG with Arm RNG feature

2024-07-26 Thread Shunzhi Wen
> I'm missing a rationale here. Why is this useful? > This creates an API for HW that supports cryptographically secure random number generation. > If you want to extend with a cryptographically secure > random number generator, that's fine. > > To have an API that's only available on certain AR

Re: [PATCH v3 1/4] dts: add send_packets to test suites and rework packet addressing

2024-07-26 Thread Nicholas Pratte
I'll make sure to look over the other parts of this series and leave reviews at some point next week, but I prioritized this since I will be using this patch at some point in my GRE suites. > diff --git a/dts/framework/test_suite.py b/dts/framework/test_suite.py > index 694b2eba65..0b678ed62d 100

Re: [PATCH] eal: add support for TRNG with Arm RNG feature

2024-07-26 Thread Stephen Hemminger
On Fri, 26 Jul 2024 18:34:44 + Shunzhi Wen wrote: > > I'm missing a rationale here. Why is this useful? > > > This creates an API for HW that supports cryptographically secure random > number generation. > > > If you want to extend with a cryptographically secure > > random number genera

Re: [PATCH v3 1/4] dts: add send_packets to test suites and rework packet addressing

2024-07-26 Thread Jeremy Spewock
Thanks for the comments, I just had one clarifying question about them, but otherwise I will address them in the next version. On Fri, Jul 26, 2024 at 3:00 PM Nicholas Pratte wrote: > > I'll make sure to look over the other parts of this series and leave > reviews at some point next week, but I p

Re: [PATCH v8 1/3] dts: add functions to testpmd shell

2024-07-26 Thread Jeremy Spewock
On Wed, Jul 24, 2024 at 2:32 PM Dean Marx wrote: > > added set promisc, set verbose, and port stop > commands to testpmd shell. > > Signed-off-by: Dean Marx Reviewed-by: Jeremy Spewock

Re: [PATCH v8 3/3] dts: queue suite conf schema

2024-07-26 Thread Jeremy Spewock
On Wed, Jul 24, 2024 at 2:32 PM Dean Marx wrote: > > Configuration schema for the queue_start_stop suite. > > Signed-off-by: Dean Marx Reviewed-by: Jeremy Spewock

Re: [PATCH v8 2/3] dts: initial queue start/stop suite implementation

2024-07-26 Thread Jeremy Spewock
On Wed, Jul 24, 2024 at 2:32 PM Dean Marx wrote: > > This suite tests the ability of the Poll Mode Driver to enable > and disable Rx/Tx queues on a port. > > Signed-off-by: Dean Marx Reviewed-by: Jeremy Spewock

Re: [PATCH v5 2/3] dts: dynamic config conf schema

2024-07-26 Thread Jeremy Spewock
On Wed, Jul 24, 2024 at 3:21 PM Dean Marx wrote: > > configuration schema to run dynamic configuration test suite. > > Signed-off-by: Dean Marx Reviewed-by: Jeremy Spewock

Re: [PATCH v5 3/3] dts: dynamic config test suite

2024-07-26 Thread Jeremy Spewock
On Wed, Jul 24, 2024 at 3:21 PM Dean Marx wrote: > > Suite for testing ability of Poll Mode Driver to turn promiscuous > mode on/off, allmulticast mode on/off, and show expected behavior > when sending packets with known, unknown, broadcast, and multicast > destination MAC addresses. > > Depends-o

[PATCH] examples/l3fwd: fix read beyond array bondaries

2024-07-26 Thread Konstantin Ananyev
From: Konstantin Ananyev ASAN report: ERROR: AddressSanitizer: unknown-crash on address 0x7ef92e32 at pc 0x0053d1e9 bp 0x7ef92c00 sp 0x7ef92bf8 READ of size 16 at 0x7ef92e32 thread T0 #0 0x53d1e8 in _mm_loadu_si128 /usr/lib64/gcc/x86_64-suse-linux/11/include/emmintrin.h:

RE: [RFC v2] ethdev: an API for cache stashing hints

2024-07-26 Thread Wathsala Wathawana Vithanage
> rte_eth_X_get_capability() > rte_eth_dev_stashing_hints_discover is somewhat similar. > Instead of adding RTE_ETH_DEV_CAPA_ macro and contaminating > 'rte_eth_dev_info' with this edge use case, what do you think follow above > design and have dedicated get capability API? I think it's better

RE: [PATCH] eal: add support for TRNG with Arm RNG feature

2024-07-26 Thread Wathsala Wathawana Vithanage
> > If you decide to rte_csrand() it should fallback to get_random or get_entropy. > > Note: many people don't fully trust RDRAND or ARM CPU instructions. > That is why the Linux entropy calls do not use only the HW instructions. Thanks Stephen. I understand the concern, would it be acceptable f

Re: [RFC v1 1/3] dts: add UDP tunnel command to testpmd shell

2024-07-26 Thread Jeremy Spewock
Hey Dean, these changes look good to me, I just had a few minor comments/suggestions. One thing I did notice was that the methods added here don't have type-hints for their return-types, obviously functionally it makes no difference since they don't return anything, but just adding the note that s

Re: [RFC v1 2/3] dts: VXLAN gpe support test suite

2024-07-26 Thread Jeremy Spewock
This all makes sense to me and looks good to me, I just had one suggestion about verification below. On Thu, Jul 25, 2024 at 12:23 PM Dean Marx wrote: > > Test suite for verifying vxlan gpe support on NIC, as well as expected > behavior while sending vxlan packets through tunnel > > Signed-off-by

Re: [PATCH] eal: add support for TRNG with Arm RNG feature

2024-07-26 Thread Mattias Rönnblom
On 2024-07-26 20:34, Shunzhi Wen wrote: I'm missing a rationale here. Why is this useful? This creates an API for HW that supports cryptographically secure random number generation. If you want to extend with a cryptographically secure random number generator, that's fine. To have an API t