The registers can be dumped through the API rte_eth_dev_get_reg_info.
However, only register values are exported, which is inconvenient for
users to interpret. Therefore, an extension of the structure
"rte_dev_reg_info" and a new API rte_eth_dev_get_reg_info_ext is added
to support the capability o
This patch adds a telemetry command for registers dump,
and supports obtaining the registers of a specified module.
In one way, the number of registers that can be exported
is limited by the number of elements carried by dict and
container. In another way, the length of the string
exported by tele
For security reasons, some address registers are not suitable
to be exposed, remove them.
Cc: sta...@dpdk.org
Signed-off-by: Jie Hai
Acked-by: Huisong Li
---
drivers/net/hns3/hns3_regs.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/net/hns3/hns3_regs
Since the driver dumps the queue interrupt registers according
to the intr_tqps_num, the counter should be the same.
Fixes: acb3260fac5c ("net/hns3: fix dump register out of range")
Fixes: 936eda25e8da ("net/hns3: support dump register")
Cc: sta...@dpdk.org
Signed-off-by: Jie Hai
Acked-by: Huiso
Since the driver is going to support reporting names of
all registers, remove the counter and insert of separators
between different register modules.
Signed-off-by: Jie Hai
Reviewed-by: Huisong Li
Acked-by: Chengwen Feng
---
drivers/net/hns3/hns3_regs.c | 68 ++
This patch adds "filter" and "names" fields to "rte_dev_reg_info"
structure. Names of registers in data fields can be reported and
the registers can be filtered by their module names.
The new API rte_eth_dev_get_reg_info_ext() is added to support
reporting names and filtering by modules. And the o
This patch refactors codes dumping registers from firmware.
Signed-off-by: Jie Hai
---
drivers/net/hns3/hns3_regs.c | 203 ---
1 file changed, 115 insertions(+), 88 deletions(-)
diff --git a/drivers/net/hns3/hns3_regs.c b/drivers/net/hns3/hns3_regs.c
index c8e3fb
This patch support dumping registers which name contains the
`filter` string. The module names are in lower case and so is
the `filter`. Available module names are cmdq, common_pf,
common_vf, ring, tqp_intr, 32_bit_dfx, 64_bit_dfx, bios, igu_egu,
ssu, ppp, rpu, ncsi, rtc, rcb, etc.
Signed-off-by:
This patch adds names for register lists, and support report
names of registers. Some registers has different names on
different platform, use names of HIP08 as default names.
Signed-off-by: Jie Hai
---
drivers/net/hns3/hns3_regs.c | 1090 +-
1 file changed, 957 i
> -Original Message-
> From: Ferruh Yigit
> Sent: Saturday, July 20, 2024 4:25 AM
> To: Minggang(Gavin) Li ; Matan Azrad ;
> Slava Ovsiienko ; Ori Kam ; NBU-
> Contact-Thomas Monjalon (EXTERNAL) ; Aman Singh
>
> Cc: dev@dpdk.org; Raslan Darawsheh
> Subject: Re: [V1] app/testpmd: restore
This patch fixes possible memory leak inside the
ice_hash_parse_raw_pattern() due to the lack of a call to rte_free()
for previously allocated pkt_buf and msk_buf.
Fixes: 1b9c68120a1c ("net/ice: enable protocol agnostic flow offloading in RSS")
Cc: sta...@dpdk.org
Reported-by: Michael Theodore St
Replace strlen with more secure strnlen in ice_hash_parse_raw_pattern.
Signed-off-by: Vladimir Medvedkin
---
drivers/net/ice/ice_hash.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c
index cdce1d0ea2..d63e673b25 1
If the parser was not initialized when calling ice_hash_parse_raw_pattern()
-rte_errno was returned. Replace returning rte_errno with ENOTSUP since
rte_errno is meaningless in the context of ice_hash_parse_raw_pattern().
Fixes: 1b9c68120a1c ("net/ice: enable protocol agnostic flow offloading in RS
> Vladimir Medvedkin, Jul 18, 2024 at 23:25:
> > I think alignment should be 1 since in FIB6 users usually don't copy IPv6
> > address and just provide a pointer to the memory inside the packet. Current
> > vector implementation loads IPv6 addresses using unaligned access (
> > _mm512_loadu_si512
Hi Stephen,
Thanks for your response.
As our application has limitations while using RSS,
I would prefer a similar approach to RTE_ACTION_TYPE_QUEUE.
Since flow director supports only one RXQ index, I could not be able to achieve
desired outcome.
Please suggest if any approach like RTE_ACTION_T
> From: Robin Jarry [mailto:rja...@redhat.com]
> Sent: Sunday, 21 July 2024 23.51
>
> Hi Morten, Stephen,
>
> Morten Brørup, Jul 21, 2024 at 18:12:
> > If the IPv6 address type you tested with was a struct containing
> > a union of different types (other than an array of 16 bytes), then
> > those
On 7/22/2024 8:10 AM, Minggang(Gavin) Li wrote:
>> -Original Message-
>> From: Ferruh Yigit
>> Sent: Saturday, July 20, 2024 4:25 AM
>> To: Minggang(Gavin) Li ; Matan Azrad ;
>> Slava Ovsiienko ; Ori Kam ; NBU-
>> Contact-Thomas Monjalon (EXTERNAL) ; Aman Singh
>>
>> Cc: dev@dpdk.org; Ras
When allocating memory for an ethdev, the rte_malloc_socket call used
only allocates memory on the NUMA node/socket local to the device. This
means that even if the user wanted to, they could never use a remote NIC
without also having memory on that NIC's socket.
For example, if we change examples
On Sun, Jul 21, 2024 at 11:56:08PM +0100, Ferruh Yigit wrote:
> On 7/19/2024 5:10 PM, Bruce Richardson wrote:
> > On Fri, Jul 19, 2024 at 04:31:11PM +0100, Ferruh Yigit wrote:
> >> On 7/19/2024 2:22 PM, Bruce Richardson wrote:
> >>> On Fri, Jul 19, 2024 at 12:10:24PM +0100, Ferruh Yigit wrote:
> >>
On Mon, Jul 22, 2024 at 08:28:34AM +, Vladimir Medvedkin wrote:
> This patch fixes possible memory leak inside the
> ice_hash_parse_raw_pattern() due to the lack of a call to rte_free()
> for previously allocated pkt_buf and msk_buf.
>
> Fixes: 1b9c68120a1c ("net/ice: enable protocol agnostic
On 20/07/2024 17:50, Sivaprasad Tummala wrote:
After refactoring the power library, power management operations are now
consistently supported regardless of the operating environment, making
function pointer checks unnecessary and thus removed from applications.
Signed-off-by: Sivaprasad Tummal
Build error:
.../app/test-pmd/config.c: In function 'icmp_echo_config_setup':
.../app/test-pmd/config.c:5159:30:
error: comparison between signed and unsigned integer expressions
[-Werror=sign-compare]
if ((nb_txq * nb_fwd_ports) < nb_fwd_lcores)
^
All '
This patch fixes possible memory leak inside the
ice_hash_parse_raw_pattern() due to the lack of a call to rte_free()
for previously allocated pkt_buf and msk_buf.
Fixes: 1b9c68120a1c ("net/ice: enable protocol agnostic flow offloading in RSS")
Cc: sta...@dpdk.org
Reported-by: Michael Theodore St
Replace strlen with more secure strnlen in ice_hash_parse_raw_pattern.
Signed-off-by: Vladimir Medvedkin
---
drivers/net/ice/ice_hash.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c
index 6b3095e2c5..506ea261e8 1
If the parser was not initialized when calling ice_hash_parse_raw_pattern()
-rte_errno was returned. Replace returning rte_errno with ENOTSUP since
rte_errno is meaningless in the context of ice_hash_parse_raw_pattern().
Fixes: 1b9c68120a1c ("net/ice: enable protocol agnostic flow offloading in RS
-Original Message-
From: Richardson, Bruce
Sent: Monday, July 22, 2024 11:42 AM
To: Medvedkin, Vladimir
Cc: dev@dpdk.org; sta...@dpdk.org; Stolarchuk, Michael
Subject: Re: [PATCH v3 1/3] net/ice: fix possible memory leak
On Mon, Jul 22, 2024 at 08:28:34AM +, Vladimir Medvedkin
Fixing Typo in updating the TX queue state
Signed-off-by: Tathagat Priyadarshi
---
drivers/net/gve/gve_tx.c | 2 +-
drivers/net/gve/gve_tx_dqo.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/gve/gve_tx.c b/drivers/net/gve/gve_tx.c
index 70d3ef0..500ae31 1
On 7/15/2024 11:11 PM, Wathsala Vithanage wrote:
> An application provides cache stashing hints to the ethernet devices to
> improve memory access latencies from the CPU and the NIC. This patch
> introduces three distinct hints for this purpose.
>
> The RTE_ETH_DEV_STASH_HINT_HOST_WILLNEED hint in
On Mon, Jul 22, 2024 at 10:59:49AM +, Vladimir Medvedkin wrote:
> Replace strlen with more secure strnlen in ice_hash_parse_raw_pattern.
>
> Signed-off-by: Vladimir Medvedkin
> ---
> drivers/net/ice/ice_hash.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/dr
On Fri, Jul 19, 2024 at 02:44:27PM +0100, Ian Stokes wrote:
> From: Bruce Richardson
>
> E830 introduces a new version of Get Link Status Data
> which increases the size of struct ice_aqc_get_link_status_data
> from 32 bytes to 56. When initializing DCF, attempt to get
> link status data using bo
From: Jun Yang
Support multiple processes for dpaa2 dma.
1) Move queue configuration procedure from init function to
device configuration function which is called by user.
2) Instances of dpaa2_dpdmai_dev and qdma_device are allocated
from primary process and shared between multiple processes.
From: Jun Yang
1) Support DMA single copy and SG copy.
2) Silent mode support.
Add index combined with length field.
For Silent mode, this index is used to notify DMA driver
which inner descriptor should be used.
For none silent mode, this index is used to notify user
which descriptor is complet
From: Jun Yang
Make sure the SG entry number doesn't overflow.
Signed-off-by: Jun Yang
---
drivers/dma/dpaa2/dpaa2_qdma.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/dpaa2/dpaa2_qdma.c b/drivers/dma/dpaa2/dpaa2_qdma.c
index 44b82c139e..7f6ebcb46b
From: Jun Yang
Multiple DQ storages are used among multiple cores, the single dq
storage of first union is leak if multiple storages are allocated.
It does not make sense to keep the single dq storage of union,
remove it and reuse the first dq storage of multiple storages
for this case.
Signed-o
From: Jun Yang
Short FD can be used for single transfer scenario which shows higher
performance than FLE.
1) Save index context in FD att field for short and FLE(NonSG).
2) Identify FD type by att of FD.
3) Force 48 bits address for source address and fle according to spec.
Signed-off-by: Jun Ya
From: Jun Yang
For non-SG format, the index is saved in FD with
DPAA2_QDMA_FD_ATT_TYPE_OFFSET(13) bits width.
The max descriptor number of ring is power of 2, so the
eventual max number is:
((1 << DPAA2_QDMA_FD_ATT_TYPE_OFFSET) / 2)
Signed-off-by: Jun Yang
---
drivers/dma/dpaa2/dpaa2_qdma.h |
From: Jun Yang
The return value of DMA copy/sg copy should be index of
descriptor copied in success.
Signed-off-by: Jun Yang
---
drivers/dma/dpaa2/dpaa2_qdma.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/dma/dpaa2/dpaa2_qdma.c b/drivers/dma/dpaa2
From: Jun Yang
Include rte_pmd_dpaax_qdma.h instead of rte_pmd_dpaa2_qdma.h
and change code accordingly.
Signed-off-by: Jun Yang
---
doc/api/doxy-api-index.md | 2 +-
doc/api/doxy-api.conf.in | 2 +-
drivers/common/dpaax/meson.build | 3 +-
drivers/
This patch add support to use multiple dma channel in the driver.
Signed-off-by: Gagandeep Singh
---
drivers/dma/dpaa/dpaa_qdma.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/dma/dpaa/dpaa_qdma.c b/drivers/dma/dpaa/dpaa_qdma.c
index 10e65ef1d7..24ad7ad019 1
The check shall be end instead of equal.
Fixes: 7da29a644c51 ("dma/dpaa: support DMA operations")
Cc: sta...@dpdk.org
Signed-off-by: Gagandeep Singh
---
drivers/dma/dpaa/dpaa_qdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/dpaa/dpaa_qdma.c b/drivers/dma/dp
From: Vanshika Shukla
This patch improves the dpaa qdma driver and
adds dpaa_qdma_burst_capacity API which returns the
remaining space in the descriptor ring.
Signed-off-by: Vanshika Shukla
---
drivers/dma/dpaa/dpaa_qdma.c | 34 +-
drivers/dma/dpaa/dpaa_qdma.h |
ERR050757 on LS104x indicates:
For outbound PCIe read transactions, a completion buffer is used
to store the PCIe completions till the data is passed back to the
initiator. At most 16 outstanding transactions are allowed and
maximum read request is 256 bytes. The completion buffer size
inside the
From: Jun Yang
To support multiple command queues of each block, status queue
need support to notify which command queue of block is completed.
The multiple command queues are balanced to blocks in setup.
If multiple command queues are enabled in one block,
de-queue status is performed instead o
From: Jun Yang
Perform SG operation by copy_sg callback of DMA lib or
burst request from application.
Perform Simple operation if burst number is 1.
Signed-off-by: Jun Yang
---
drivers/dma/dpaa/dpaa_qdma.c | 856 ++-
drivers/dma/dpaa/dpaa_qdma.h | 184 +---
From: Jun Yang
The congestion issue occurs frequently on low speed device(PCIe).
We should drain the command queue to make dma work when congestion occurs.
Signed-off-by: Jun Yang
---
drivers/dma/dpaa/dpaa_qdma.c | 157 +++
1 file changed, 85 insertions(+), 72 d
From: Jun Yang
Perform block dequeue to identify which queue of this block is completed.
Signed-off-by: Jun Yang
---
drivers/dma/dpaa/dpaa_qdma.c | 252 ---
1 file changed, 116 insertions(+), 136 deletions(-)
diff --git a/drivers/dma/dpaa/dpaa_qdma.c b/drivers/
From: Jun Yang
Burst operation used for SG copy as default until SG issue is fixed.
Signed-off-by: Jun Yang
---
drivers/dma/dpaa/dpaa_qdma.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/dma/dpaa/dpaa_qdma.c b/drivers/dma/dpaa/dpaa_qdma.c
index eaa5f81f6d..8492d
From: Jun Yang
Fix issue of ERRATA 050757/050265 workaround which is not effective
in burst mode.
SDF/DDF is referred by first entry of compound frame table, move the DF to
compound frame table description which is suitable to adapt single copy
and SG/burst copy.
Fix SG issue which was caused b
From: Jun Yang
Don't save eq context in silent mode, check HW status only to
identify if queue is full.
Signed-off-by: Jun Yang
---
drivers/dma/dpaa/dpaa_qdma.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/dpaa/dpaa_qdma.c b/drivers/dma/dpaa/d
From: Jun Yang
Split burst copies to multiple SG copies if burst number exceeds
max number of SG entries.
Signed-off-by: Jun Yang
---
drivers/dma/dpaa/dpaa_qdma.c | 180 +++
drivers/dma/dpaa/dpaa_qdma.h | 2 +-
2 files changed, 98 insertions(+), 84 deletions(-
From: Jun Yang
SG transaction is not helpful for performance of large transaction size.
Start single transaction for size > max SG entry size in SG copy.
Default MAX SG entry size is 2000 bytes which is experiment data of
mem to mem, user can change it according to experiment:
export DPAA_QDMA_S
From: Hemant Agrawal
Add BMI statistics and fixing the existing extended
statistics
Signed-off-by: Hemant Agrawal
Signed-off-by: Gagandeep Singh
---
drivers/bus/dpaa/base/fman/fman_hw.c | 65 +++-
drivers/bus/dpaa/include/fman.h | 4 +-
drivers/bus/dpaa/include/f
From: Jun Yang
Initialize and Configure queues of dma device according to hw queues
supported from mc bus.
Because multiple queues per device are supported, virt queues
implementation are dropped.
Signed-off-by: Jun Yang
---
drivers/dma/dpaa2/dpaa2_qdma.c | 312 +++-
From: Jun Yang
Include dpaa2_hw_pvt.h and dpaa2_hw_dpio.h files
Signed-off-by: Jun Yang
---
drivers/dma/dpaa2/dpaa2_qdma.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/dma/dpaa2/dpaa2_qdma.h b/drivers/dma/dpaa2/dpaa2_qdma.h
index 743a43fa14..eb02bff08f 100644
--- a/drivers/dm
From: Jun Yang
For copy_sg: pass job index lists.
For copy: pass job index.
Signed-off-by: Jun Yang
---
drivers/dma/dpaa2/dpaa2_qdma.c | 92 ++
drivers/dma/dpaa2/dpaa2_qdma.h | 7 ++
drivers/dma/dpaa2/rte_pmd_dpaa2_qdma.h | 15 -
3 files changed, 68
V2 changes:
* fix compilation issue on ubuntu 22.04
Gagandeep Singh (6):
dma/dpaa: support multi channels
dma/dpaa: fix job enqueue
dma/dpaa: add workaround for ERR050757
dma/dpaa: qdma stall workaround for ERR050265
dma/dpaa: remove unwanted desc
dma/dpaa: data path optimization
Hema
remove unwanted descriptor list maintenance
and channels overhead.
Signed-off-by: Gagandeep Singh
---
drivers/dma/dpaa/dpaa_qdma.c | 594 +--
drivers/dma/dpaa/dpaa_qdma.h | 43 +--
2 files changed, 221 insertions(+), 416 deletions(-)
diff --git a/drivers/dma/dpa
Remove unnessary status read before every send.
Signed-off-by: Gagandeep Singh
---
drivers/dma/dpaa/dpaa_qdma.c | 186 ++-
drivers/dma/dpaa/dpaa_qdma.h | 7 ++
2 files changed, 101 insertions(+), 92 deletions(-)
diff --git a/drivers/dma/dpaa/dpaa_qdma.c b/drive
From: Jun Yang
struct {
uint64_t coreid : 4; /**--rbp.sportid / rbp.dportid*/
uint64_t pfid : 8; /**--rbp.spfid / rbp.dpfid*/
uint64_t vfen : 1; /**--rbp.svfa / rbp.dvfa*/
uint64_t vfid : 16; /**--rbp.svfid / rbp.dvfid*/
.
} pcie;
Signed-off-by: Jun Ya
From: Jun Yang
Return complete index instead of total complete counter
in complete callback.
Signed-off-by: Jun Yang
---
drivers/dma/dpaa/dpaa_qdma.c | 534 ++-
drivers/dma/dpaa/dpaa_qdma.h | 109 +++
2 files changed, 330 insertions(+), 313 deletions(-)
dif
Non-prefetchable read setting in the source descriptor may be
required for targets other than local memory. Prefetchable read
setting will offer better performance for misaligned transfers
in the form of fewer transactions and should be set if possible.
This patch also fixes QDMA stall issue due to
Hi,
> -Original Message-
> From: Alexander Kozyrev
> Sent: Wednesday, November 1, 2023 15:57
> To: dev@dpdk.org
> Cc: Suanming Mou ; Slava Ovsiienko
> ; Raslan Darawsheh
> Subject: [PATCH v2] net/mlx5: replenish MPRQ buffers for miniCQEs
>
> Keep unzipping if the next CQE is the miniCQE
On 7/16/2024 11:53 AM, Mingjin Ye wrote:
In secondary processes, insert_vdev() may be called multiple times on the
same device due to multi-process hot-plugging of the vdev bus and EAL
parameters to add the same vdev.
In this case, when rte_devargs_insert() is called, the devargs->name
reference
22/07/2024 11:36, Ferruh Yigit:
> On 7/22/2024 8:10 AM, Minggang(Gavin) Li wrote:
> > From: Ferruh Yigit
> >> On 7/17/2024 8:11 AM, Gavin Li wrote:
> >>> VXLAN-GPE support was removed from testpmd recently. Drivers which are
> >>> not migrated are still using VXLAN-GPE in tests.
> >>>
> >>> This c
Reviewed-by: Juraj Linkeš
Thanks for catching this.
On 19. 7. 2024 17:34, Alex Chapman wrote:
When running DTS with a git revision specified the following error occurs:
$ ./main.py --revision HEAD
[...]
FileNotFoundError: [Errno 2] No such file or directory:
'dts/'
Fix by casting DPDKGi
>
>
+This test suite ensures proper and expected behavior of Allowlist filtering
> via mac
> +addresses on devices bound to the Poll Mode Driver. If a packet received
> on a device
> +contains a mac address not contained with its mac address pool, the
> packet should
> +be dropped. Alternatively
I think Jeremy already mentioned this but just make sure you update
vlan_set_filter_on/off to the new version that has an on boolean arg.
Reviewed-by: Dean Marx
On Thu, Jul 18, 2024 at 3:12 PM Nicholas Pratte wrote:
> Several new methods have been added to TestPMDShell in order to produce
> th
Reviewed-by: Dean Marx
On Tue, Jul 2, 2024 at 3:25 PM Nicholas Pratte wrote:
> Various test cases in the mac filter test suite called for granular
> manipulation of destination mac addresses to properly test mac address
> filtering functionality. To compensate, there is now an
> adjust_addresse
On 7/22/2024 11:02 AM, Bruce Richardson wrote:
> When allocating memory for an ethdev, the rte_malloc_socket call used
> only allocates memory on the NUMA node/socket local to the device. This
> means that even if the user wanted to, they could never use a remote NIC
> without also having memory on
On 7/22/2024 11:52 AM, Ferruh Yigit wrote:
> Build error:
> .../app/test-pmd/config.c: In function 'icmp_echo_config_setup':
> .../app/test-pmd/config.c:5159:30:
>error: comparison between signed and unsigned integer expressions
> [-Werror=sign-compare]
> if ((nb_txq * nb_fwd_ports)
On 7/22/2024 2:04 PM, Thomas Monjalon wrote:
> 22/07/2024 11:36, Ferruh Yigit:
>> On 7/22/2024 8:10 AM, Minggang(Gavin) Li wrote:
>>> From: Ferruh Yigit
On 7/17/2024 8:11 AM, Gavin Li wrote:
> VXLAN-GPE support was removed from testpmd recently. Drivers which are
> not migrated are st
This patch fixes possible memory leak inside the
ice_hash_parse_raw_pattern() due to the lack of a call to rte_free()
for previously allocated pkt_buf and msk_buf.
Fixes: 1b9c68120a1c ("net/ice: enable protocol agnostic flow offloading in RSS")
Cc: sta...@dpdk.org
Reported-by: Michael Theodore St
Replace strlen with more secure strnlen in ice_hash_parse_raw_pattern.
Signed-off-by: Vladimir Medvedkin
tmp
---
drivers/net/ice/ice_hash.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c
index 6b3095e2c5..a
If the parser was not initialized when calling ice_hash_parse_raw_pattern()
-rte_errno was returned. Replace returning rte_errno with ENOTSUP since
rte_errno is meaningless in the context of ice_hash_parse_raw_pattern().
Fixes: 1b9c68120a1c ("net/ice: enable protocol agnostic flow offloading in RS
-Original Message-
From: Richardson, Bruce
Sent: Monday, July 22, 2024 12:25 PM
To: Medvedkin, Vladimir
Cc: dev@dpdk.org
Subject: Re: [PATCH v4 2/3] net/ice: refactor raw pattern parsing function
On Mon, Jul 22, 2024 at 10:59:49AM +, Vladimir Medvedkin wrote:
> Replace strlen wit
On 7/22/2024 12:10 PM, Tathagat Priyadarshi wrote:
> Fixing Typo in updating the TX queue state
>
> Signed-off-by: Tathagat Priyadarshi
>
Good catch, thanks Tathagat.
I think impact is more than just typo, so let me update the patch title as:
net/gve: fix Tx queue state on queue start
Also ne
Thanks Ferruh.
On Mon, Jul 22, 2024 at 7:41 PM Ferruh Yigit wrote:
> On 7/22/2024 12:10 PM, Tathagat Priyadarshi wrote:
> > Fixing Typo in updating the TX queue state
> >
> > Signed-off-by: Tathagat Priyadarshi
> >
>
> Good catch, thanks Tathagat.
>
> I think impact is more than just typo, so l
On 7/17/2024 8:11 AM, Gavin Li wrote:
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index a76b44bf39..51a8d4993e 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -423,6 +423,12 @@ enum index {
> ITEM_GENEVE_VNI,
> ITEM_GENE
Announce the additions in cryptodev ABI to support EDDSA algorithm.
Signed-off-by: Gowrishankar Muthukrishnan
--
RFC:
https://patches.dpdk.org/project/dpdk/patch/0ae6a1afadac64050d80b0fd7712c4a6a8599e2c.1701273963.git.gmuthukri...@marvell.com/
---
doc/guides/rel_notes/deprecation.rst | 4
On 4/4/2024 12:38 AM, Stephen Hemminger wrote:
> On Thu, 4 Apr 2024 00:08:41 +0200
> Marek Pazdan wrote:
>
>> I can remove this part (rte_eth_config), but the new API provides other
>> link information which is not available from the existing API, like
>> supported/advertising/partner_advertising
Announce cryptodev changes to offload RSA asymmetric operation in
VirtIO PMD.
Signed-off-by: Gowrishankar Muthukrishnan
--
RFC:
https://patches.dpdk.org/project/dpdk/patch/20230928095300.1353-2-gmuthukri...@marvell.com/
https://patches.dpdk.org/project/dpdk/patch/20230928095300.1353-3-gmuth
Announce vhost ABI changes to modify few functions to support
asymmetric crypto operation.
Signed-off-by: Gowrishankar Muthukrishnan
--
RFC:
https://patches.dpdk.org/project/dpdk/patch/20230928095300.1353-4-gmuthukri...@marvell.com/
---
doc/guides/rel_notes/deprecation.rst | 7 +++
1 file
Hi,
From: Alexander Kozyrev
Sent: Wednesday, November 1, 2023 4:57 PM
To: dev@dpdk.org
Cc: Suanming Mou; Slava Ovsiienko; Raslan Darawsheh
Subject: [PATCH v2] net/mlx5: replenish MPRQ buffers for miniCQEs
Keep unzipping if the next CQE is the miniCQE array in
rxq_cq_decompress_v() routine only f
On Mon, Jul 22, 2024 at 01:50:44PM +, Vladimir Medvedkin wrote:
> This patch fixes possible memory leak inside the
> ice_hash_parse_raw_pattern() due to the lack of a call to rte_free()
> for previously allocated pkt_buf and msk_buf.
>
> Fixes: 1b9c68120a1c ("net/ice: enable protocol agnostic
On Mon, Jul 22, 2024 at 01:50:45PM +, Vladimir Medvedkin wrote:
> Replace strlen with more secure strnlen in ice_hash_parse_raw_pattern.
>
> Signed-off-by: Vladimir Medvedkin
>
I believe there are quite a number of other small things in this function
that could do with improvement e.g. the p
On Mon, Jul 22, 2024 at 01:50:46PM +, Vladimir Medvedkin wrote:
> If the parser was not initialized when calling ice_hash_parse_raw_pattern()
> -rte_errno was returned. Replace returning rte_errno with ENOTSUP since
> rte_errno is meaningless in the context of ice_hash_parse_raw_pattern().
>
>
On Mon, Jul 22, 2024 at 04:09:15PM +0100, Bruce Richardson wrote:
> On Mon, Jul 22, 2024 at 01:50:44PM +, Vladimir Medvedkin wrote:
> > This patch fixes possible memory leak inside the
> > ice_hash_parse_raw_pattern() due to the lack of a call to rte_free()
> > for previously allocated pkt_buf
The number of uncore frequencies was defined in three places,
and two of them were too small leading to test failures.
All places should be using RTE_MAX_UNCORE_FREQS.
Bugzilla ID: 1499
Fixes: 60b8a661a957 ("power: add Intel uncore frequency control")
Signed-off-by: Stephen Hemminger
---
v2 - dro
On 7/22/2024 11:52 AM, Ferruh Yigit wrote:
> Build error:
> .../app/test-pmd/config.c: In function 'icmp_echo_config_setup':
> .../app/test-pmd/config.c:5159:30:
>error: comparison between signed and unsigned integer expressions
> [-Werror=sign-compare]
> if ((nb_txq * nb_fwd_ports)
V3 changes:
* fix 32 bit compilation issue
V2 changes:
* fix compilation issue on ubuntu 22.04
Gagandeep Singh (6):
dma/dpaa: support multi channels
dma/dpaa: fix job enqueue
dma/dpaa: add workaround for ERR050757
dma/dpaa: qdma stall workaround for ERR050265
dma/dpaa: remove unwanted d
From: Jun Yang
struct {
uint64_t coreid : 4; /**--rbp.sportid / rbp.dportid*/
uint64_t pfid : 8; /**--rbp.spfid / rbp.dpfid*/
uint64_t vfen : 1; /**--rbp.svfa / rbp.dvfa*/
uint64_t vfid : 16; /**--rbp.svfid / rbp.dvfid*/
.
} pcie;
Signed-off-by: Jun Ya
From: Jun Yang
Initialize and Configure queues of dma device according to hw queues
supported from mc bus.
Because multiple queues per device are supported, virt queues
implementation are dropped.
Signed-off-by: Jun Yang
---
drivers/dma/dpaa2/dpaa2_qdma.c | 312 +++-
From: Jun Yang
1) Support DMA single copy and SG copy.
2) Silent mode support.
Add index combined with length field.
For Silent mode, this index is used to notify DMA driver
which inner descriptor should be used.
For none silent mode, this index is used to notify user
which descriptor is complet
From: Jun Yang
Support multiple processes for dpaa2 dma.
1) Move queue configuration procedure from init function to
device configuration function which is called by user.
2) Instances of dpaa2_dpdmai_dev and qdma_device are allocated
from primary process and shared between multiple processes.
From: Jun Yang
Make sure the SG entry number doesn't overflow.
Signed-off-by: Jun Yang
---
drivers/dma/dpaa2/dpaa2_qdma.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/dpaa2/dpaa2_qdma.c b/drivers/dma/dpaa2/dpaa2_qdma.c
index 44b82c139e..7f6ebcb46b
From: Jun Yang
Include dpaa2_hw_pvt.h and dpaa2_hw_dpio.h files
Signed-off-by: Jun Yang
---
drivers/dma/dpaa2/dpaa2_qdma.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/dma/dpaa2/dpaa2_qdma.h b/drivers/dma/dpaa2/dpaa2_qdma.h
index 743a43fa14..eb02bff08f 100644
--- a/drivers/dm
From: Jun Yang
For copy_sg: pass job index lists.
For copy: pass job index.
Signed-off-by: Jun Yang
---
drivers/dma/dpaa2/dpaa2_qdma.c | 92 ++
drivers/dma/dpaa2/dpaa2_qdma.h | 7 ++
drivers/dma/dpaa2/rte_pmd_dpaa2_qdma.h | 15 -
3 files changed, 68
From: Jun Yang
Multiple DQ storages are used among multiple cores, the single dq
storage of first union is leak if multiple storages are allocated.
It does not make sense to keep the single dq storage of union,
remove it and reuse the first dq storage of multiple storages
for this case.
Signed-o
From: Jun Yang
Short FD can be used for single transfer scenario which shows higher
performance than FLE.
1) Save index context in FD att field for short and FLE(NonSG).
2) Identify FD type by att of FD.
3) Force 48 bits address for source address and fle according to spec.
Signed-off-by: Jun Ya
From: Jun Yang
For non-SG format, the index is saved in FD with
DPAA2_QDMA_FD_ATT_TYPE_OFFSET(13) bits width.
The max descriptor number of ring is power of 2, so the
eventual max number is:
((1 << DPAA2_QDMA_FD_ATT_TYPE_OFFSET) / 2)
Signed-off-by: Jun Yang
---
drivers/dma/dpaa2/dpaa2_qdma.h |
1 - 100 of 140 matches
Mail list logo
