Re: [PATCH v3] vfio: combine container_create and group_bind

2024-07-10 Thread BillXiang
> From: "David Marchand" > Date:  Tue, Jul 9, 2024, 16:49 > Subject:  Re: [PATCH v3] vfio: combine container_create and group_bind > To: "BillXiang" > Cc: "Tyler Retzlaff", "Anatoly > Burakov", > On Thu, Jul 4, 2024 at 9:48 AM BillXiang wrote: > > > > From: BillXiang > > > > For multi-devices

Re: [PATCH v9] eal/x86: improve rte_memcpy const size 16 performance

2024-07-10 Thread David Marchand
On Tue, Jul 9, 2024 at 3:28 PM Morten Brørup wrote: > > When the rte_memcpy() size is 16, the same 16 bytes are copied twice. > In the case where the size is known to be 16 at build time, omit the > duplicate copy. > > Reduced the amount of effectively copy-pasted code by using #ifdef > inside fun

[v5 0/8] DPAA specific fixes

2024-07-10 Thread vanshika . shukla
From: Vanshika Shukla This series includes fixes for NXP DPAA drivers. V5 changes: Added CID for "remove redundant file descriptor check" patch. Note: Other patches are bug fixes reported by our internal coverity tool. V4 changes: Removed \n from debug prints in "cache free optimization" patch.

[v5 1/8] bus/dpaa: fix bus scan for DMA devices

2024-07-10 Thread vanshika . shukla
From: Gagandeep Singh if there is no sec devices available, code is not scanning QDMA dev This patch fix this problem by adding a goto statement instead of return in case no sec device available. Fixes: 583f3732974f ("dma/dpaa: introduce DPAA DMA driver skeleton") Cc: sta...@dpdk.org Signed-off

[v5 2/8] bus/dpaa: fix resource leak in variable dev

2024-07-10 Thread vanshika . shukla
From: Apeksha Gupta Resource leak: variable dev is going out of scope leaks the storage. Coverity issue: CID 373703 Fixes: d61138d4f0e2 ("drivers: remove direct access to interrupt handle") Cc: hka...@marvell.com Cc: sta...@dpdk.org Signed-off-by: Apeksha Gupta Signed-off-by: Vanshika Shukla

[v5 3/8] common/dpaax: fix IOVA table cleanup

2024-07-10 Thread vanshika . shukla
From: Gagandeep Singh Fixes incorrect structure free Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table") Cc: sta...@dpdk.org Signed-off-by: Gagandeep Singh Signed-off-by: Vanshika Shukla --- drivers/common/dpaax/dpaax_iova_table.c | 7 ++- 1 file changed, 2 inse

[v5 4/8] common/dpaax: fix array overrun issue

2024-07-10 Thread vanshika . shukla
From: Apeksha Gupta Out-of-bounds read, Overrunning dynamic array nodes at offset corresponding to index variable j. Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table") Cc: sta...@dpdk.org Signed-off-by: Apeksha Gupta Signed-off-by: Vanshika Shukla --- drivers/commo

[v5 5/8] bus/dpaa: remove redundant file descriptor check

2024-07-10 Thread vanshika . shukla
From: Rohit Raj This patch removes the redundant file descriptor check Coverity issue: CID 425715 Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table") Cc: sta...@dpdk.org Signed-off-by: Rohit Raj Signed-off-by: Vanshika Shukla --- drivers/bus/dpaa/base/qbman/process.

[v5 6/8] bus/dpaa: remove unused code

2024-07-10 Thread vanshika . shukla
From: Gagandeep Singh The slow poll code is not being used in DPDK DPAA driver sub-system. Signed-off-by: Gagandeep Singh Signed-off-by: Vanshika Shukla --- drivers/bus/dpaa/base/qbman/qman.c | 31 - drivers/bus/dpaa/include/fsl_qman.h | 31 ---

[v5 7/8] net/dpaa: restrict MTU config for shared intf

2024-07-10 Thread vanshika . shukla
From: Rohit Raj Since DPDK was able to configure mtu in VSP/Shared interface mode, it was causing misconfiguration of the hw which further caused crashes. This patch allow only kernel to config MTU in such cases Fixes: e4abd4ff183c ("net/dpaa: support virtual storage profile") Cc: jun.y...@nxp

[v5 8/8] mempool/dpaax: cache free optimization

2024-07-10 Thread vanshika . shukla
From: Sachin Saxena - Updates the cache threshold value as per the platform specific optimal value. Signed-off-by: Sachin Saxena Signed-off-by: Vanshika Shukla --- drivers/mempool/dpaa/dpaa_mempool.c | 16 +++- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 15 +++

RE: [PATCH] test: fix option block

2024-07-10 Thread Stokes, Ian
> -Original Message- > From: Ye, MingjinX > Sent: Friday, July 5, 2024 2:39 AM > To: Stokes, Ian ; dev@dpdk.org > Subject: RE: [PATCH] test: fix option block > > > > > -Original Message- > > From: Stokes, Ian > > Sent: Thursday, July 4, 2024 8:02 PM > > To: Ye, MingjinX ; de

Re: [PATCH v4] ethdev: Add link_speed lanes support

2024-07-10 Thread Ferruh Yigit
On 7/9/2024 10:20 PM, Damodharam Ammepalli wrote: > On Tue, Jul 9, 2024 at 4:10 AM Ferruh Yigit wrote: >> >> On 7/9/2024 12:22 AM, Damodharam Ammepalli wrote: >>> Update the eth_dev_ops structure with new function vectors >>> to get, get capabilities and set ethernet link speed lanes. >>> Update t

Re: 答复: [PATCH v2] r8125: add r8125 ethernet poll mode driver

2024-07-10 Thread Ferruh Yigit
On 7/8/2024 6:43 AM, 王颢 wrote: > Dear Ferruh, > > I'm delighted to receive your email. I'd like to address some of the > questions you raised. > > The drivers supported by the PMD uploaded by Realtek will include all > in-market Realtek PCIe network card chips. Currently, we plan to first uploa

[PATCH v1 1/1] fbarray: fix find_next_n for unaligned length

2024-07-10 Thread Anatoly Burakov
When array length is not aligned on a power of 2, we need to mask out the unaligned bits from the mask whenever we reach the last mask. However, when both ignore mask (e.g. due to starting at unaligned bit) and last index ignore mask are specified, we combine them with an OR, which is incorrect. Fi

Re: [PATCH v1 2/2] dts: improve starting and stopping interactive shells

2024-07-10 Thread Dean Marx
For the whole series: Tested-by: Dean Marx

Re: [PATCH v5 03/23] net/ntnic: add minimal initialization for PCI device

2024-07-10 Thread Serhii Iliushyk
Hi Ferruh, Please find our explanation for your comment according to device initialization by function nthw_pci_dev_init. Our NIC handles multiple ports within the same PCI Bus Device Function (BDF) - hence, we need to create several ETH devices during the probe init. Allocation of multiple eth

[PATCH] net/cpfl: fix build error for debian 32-bit

2024-07-10 Thread Bruce Richardson
When building for debian 11 32-bit, errors were reported with cpfl driver[1]. The error is due to comparing signed and unsigned values: ../drivers/net/cpfl/cpfl_flow_parser.c:1699:29: error: comparison of integer expressions of different signedness: 'long int' and 'uint32_t' {aka 'unsigned int

Re: [PATCH v5 03/23] net/ntnic: add minimal initialization for PCI device

2024-07-10 Thread Ferruh Yigit
On 7/10/2024 3:30 PM, Serhii Iliushyk wrote: > Hi Ferruh, > > Please find our explanation for your comment according to device > initializationby function nthw_pci_dev_init. > > Our NIC handles multiple ports within the same PCI Bus Device Function > (BDF) - hence, we need to create several ETH d

Re: [PATCH v3 1/3] net/virtio_user: convert cq descriptor IOVA address to Virtual address

2024-07-10 Thread David Marchand
Hello Srujana, Jerin, On Wed, Jul 3, 2024 at 12:04 PM Srujana Challa wrote: > > This patch modifies the code to convert descriptor buffer IOVA > addresses to virtual addresses during the processing of shadow > control queue when IOVA mode is PA. This change enables Virtio-user > to operate with I

Re: [PATCH] net/cpfl: fix build error for debian 32-bit

2024-07-10 Thread David Marchand
On Wed, Jul 10, 2024 at 4:54 PM Bruce Richardson wrote: > > When building for debian 11 32-bit, errors were reported with cpfl > driver[1]. The error is due to comparing signed and unsigned values: > > ../drivers/net/cpfl/cpfl_flow_parser.c:1699:29: error: comparison of > integer expressions of

Re: [PATCH v5 1/3] dts: add functions to testpmd shell

2024-07-10 Thread Jeremy Spewock
All of the code here looks good to me, if you end up putting in a new version for adding the comment that I mentioned on the other commit it might be worth changing the name of this commit again to something like add queue functions to testpmd, but I'm not sure this is super critical since you expl

Re: [PATCH v5 2/3] dts: initial queue start/stop suite implementation

2024-07-10 Thread Jeremy Spewock
Hey Dean, everything looks good here to me, but I had one thought about how we do the verification below. On Wed, Jul 3, 2024 at 2:08 PM Dean Marx wrote: > + > +def test_rx_queue_start_stop(self) -> None: > +"""Verify packets are not received by port 0 when Rx queue is > disabled. >

Re: [PATCH v5 3/3] dts: queue suite conf schema

2024-07-10 Thread Jeremy Spewock
On Wed, Jul 3, 2024 at 2:08 PM Dean Marx wrote: > > Configuration schema for the queue_start_stop suite. > > Signed-off-by: Dean Marx > --- Reviewed-by: Jeremy Spewock

Re: [PATCH v10 3/3] dts: config schema

2024-07-10 Thread Jeremy Spewock
On Wed, Jul 3, 2024 at 12:51 PM Dean Marx wrote: > > Configuration to run vlan test suite > > Signed-off-by: Dean Marx > --- Reviewed-by: Jeremy Spewock

[PATCH v6 2/3] dts: initial queue start/stop suite implementation

2024-07-10 Thread Dean Marx
This suite tests the ability of the Poll Mode Driver to enable and disable Rx/Tx queues on a port. Signed-off-by: Dean Marx --- dts/tests/TestSuite_queue_start_stop.py | 94 + 1 file changed, 94 insertions(+) create mode 100644 dts/tests/TestSuite_queue_start_stop.py di

[PATCH v6 3/3] dts: queue suite conf schema

2024-07-10 Thread Dean Marx
Configuration schema for the queue_start_stop suite. Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/config/conf_yaml_schema.json index f02a31

[PATCH v6 1/3] dts: add functions to testpmd shell

2024-07-10 Thread Dean Marx
added set promisc, set verbose, and port stop commands to testpmd shell. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 194 +- 1 file changed, 193 insertions(+), 1 deletion(-) diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framew

Re: [PATCH] net/cpfl: fix build error for debian 32-bit

2024-07-10 Thread Bruce Richardson
On Wed, Jul 10, 2024 at 05:07:30PM +0200, David Marchand wrote: > On Wed, Jul 10, 2024 at 4:54 PM Bruce Richardson > wrote: > > > > When building for debian 11 32-bit, errors were reported with cpfl > > driver[1]. The error is due to comparing signed and unsigned values: > > > > ../drivers/net/cpf

Re: [PATCH v3 2/4] dts: add toggle option to send and capture

2024-07-10 Thread Jeremy Spewock
This makes sense to me, but we should probably have more discussion about whether to use this method with the boolean flag or if we should use the other method in the dynamic queue suite that adjusts everything except things that the user changes. I'd be interested to hear what Juraj or Luca think

Re: [PATCH v2 1/4] dts: add multicast set function to shell

2024-07-10 Thread Jeremy Spewock
On Mon, Jul 8, 2024 at 3:19 PM Dean Marx wrote: > > added set multicast function for changing allmulticast mode within testpmd. > > Signed-off-by: Dean Marx > --- > dts/framework/remote_session/testpmd_shell.py | 46 +++ > 1 file changed, 46 insertions(+) > > diff --git a/dts/fra

Re: [PATCH v3 3/4] dts: dynamic config conf schema

2024-07-10 Thread Jeremy Spewock
On Mon, Jul 8, 2024 at 3:30 PM Dean Marx wrote: > > configuration schema to run dynamic configuration test suite. > > Signed-off-by: Dean Marx > --- Reviewed-by: Jeremy Spewock

Re: [PATCH v3 4/4] dts: dynamic config test suite

2024-07-10 Thread Jeremy Spewock
On Mon, Jul 8, 2024 at 3:30 PM Dean Marx wrote: > > Suite for testing ability of Poll Mode Driver to turn promiscuous > mode on/off, allmulticast mode on/off, and show expected behavior > when sending packets with known, unknown, broadcast, and multicast > destination MAC addresses. > > Signed-off

[PATCH v6] eal: verify mmu type for DPDK support (ppc64le)

2024-07-10 Thread David Christensen
IBM POWER systems support more than one type of memory management unit (MMU). The Power ISA 3.0 specification, which applies to P9 and later CPUs, defined a new Radix MMU which, among other things, allows an anonymous memory page mapping to be converted into a hugepage mapping at a specific addres

[PATCH v7] eal: verify mmu type for DPDK support (ppc64le)

2024-07-10 Thread David Christensen
IBM POWER systems support more than one type of memory management unit (MMU). The Power ISA 3.0 specification, which applies to P9 and later CPUs, defined a new Radix MMU which, among other things, allows an anonymous memory page mapping to be converted into a hugepage mapping at a specific addres

RE: [PATCH v3 2/2] eventdev: add support for enqueue reorder

2024-07-10 Thread Pathak, Pravin
>+ Add a device-level >+ RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ >+ as well. >+ The documentation of that flag should probably house the detailed >description of this feature. So, this capability will be advertised by DSW and DLB devices with detailed documentation. What about DPAA and OPDL devices