[PATCH v3 0/3] Introduce UADK compression driver

Introduce a new compress PMD for hardware accelerators based on UADK [1]. UADK is a framework for user applications to access hardware accelerators. UADK relies on IOMMU SVA (Shared Virtual Address) feature, which share the same page table between IOMMU and MMU. Thereby user application can direct

[PATCH v3 1/3] compress/uadk: Introduce UADK compression driver

Introduce a new compression & decompression PMD for hardware accelerators based on UADK [1]. UADK is a framework for user applications to access hardware accelerators. UADK relies on IOMMU SVA (Shared Virtual Address) feature, which shares the same page table between IOMMU and MMU. Thereby user ap

[PATCH v3 2/3] compress/uadk: support basic operations

Support the basic dev control operations: configure, close, start, stop, infos_get, and queue pairs operations, etc. Signed-off-by: Zhangfei Gao --- drivers/compress/uadk/uadk_compress_pmd.c | 279 +- .../compress/uadk/uadk_compress_pmd_private.h | 16 + 2 files changed, 294

[PATCH v3 3/3] compress/uadk: support burst enqueue/dequeue

This commit adds the burst enqueue and dequeue operations, Test: sudo dpdk-test --vdev=compress_uadk RTE>>compressdev_autotest RTE>>quit Signed-off-by: Zhangfei Gao --- doc/guides/compressdevs/uadk.rst | 19 + doc/guides/rel_notes/release_24_07.rst| 5 ++ drivers/compress/uadk

Re: [PATCH v2 4/4] net/virtio-user: fix control queue allocation

On Thu, Mar 28, 2024 at 2:08 PM Maxime Coquelin wrote: > > It is possible to have the control queue without the > device advertising VIRTIO_NET_F_MQ. > > Rely on the VIRTIO_NET_F_CTRL_VQ feature being advertised > instead. > > Fixes: 6fdf32d1e318 ("net/virtio-user: remove max queues limitation") >

Re: [PATCH v3 2/4] dts: add context manager for interactive shells

On 10. 6. 2024 22:06, Jeremy Spewock wrote: Overall, my thoughts are that it's definitely an interesting idea to make the normal shell subclass the critical. I explain more below, but basically I think it makes sense as long as we are fine with the normal shells having a context manager which

Re: [PATCH v3 4/4] dts: add test case that utilizes offload to pmd_buffer_scatter

On 10. 6. 2024 22:08, Jeremy Spewock wrote: On Mon, Jun 10, 2024 at 11:22 AM Juraj Linkeš wrote: diff --git a/dts/tests/TestSuite_pmd_buffer_scatter.py b/dts/tests/TestSuite_pmd_buffer_scatter.py index 41f6090a7e..76eabb51f6 100644 --- a/dts/tests/TestSuite_pmd_buffer_scatter.py +++ b/dts

Re: [RFC PATCH v2] dts: skip test cases based on capabilities

While working on my blocklist patch, I've just realised I forgot to add another comment. I think it would be ideal to make capabilities a generic class, and NicCapability a child of this. When collecting capabilities we could group these by the final class, and let this final class create the e

Re: [RFC PATCH v1 2/2] dts: Remove XML-RPC server for Scapy TG and instead us ScapyShell

diff --git a/dts/framework/testbed_model/traffic_generator/scapy.py b/dts/framework/testbed_model/traffic_generator/scapy.py index 5676235119..2b299ad02f 100644 --- a/dts/framework/testbed_model/traffic_generator/scapy.py +++ b/dts/framework/testbed_model/traffic_generator/scapy.py class S

Re: Input length paramter in DPDK-BBdev

Hello Nicolas, Yes, this resolves the issue. I've been using Python scripts to generate random data for input rather than using MCS table. I have one additional question related to the vector files. I notice that DPDK-BBdev vector files have very specific names, like ldpc_enc_v2342.data and ld

Re: Multiple paramters of input and output in DPDK-BBdev

Hello Nicolas, Thanks a lot for your support in resolving this query. Best Regards, Avijit Pandey Cloud SME | VoerEir AB +91 9598570190 [Title: LinkedIn - Description: image of LinkedIn icon] [Image] From: Chautru, Nicolas Date: Tue

Re: [RFC PATCH v1 1/2] dts: Add interactive shell for managing Scapy

diff --git a/dts/framework/remote_session/scapy_shell.py b/dts/framework/remote_session/scapy_shell.py new file mode 100644 index 00..fa647dc870 --- /dev/null +++ b/dts/framework/remote_session/scapy_shell.py @@ -0,0 +1,175 @@ +# SPDX-License-Identifier: BSD-3-Clause +# Copyright(c) 20

Re: [PATCH v4 0/4] non template pmd code changes

Hi, From: Maayan Kashani Sent: Thursday, June 6, 2024 1:06 PM To: dev@dpdk.org Cc: Maayan Kashani; Dariusz Sosnowski; Raslan Darawsheh Subject: [PATCH v4 0/4] non template pmd code changes Code changes applied after review. Maayan Kashani (4): net/mlx5: reorganize main structures net/mlx5:

Re: [PATCH v4 0/7] HWS non-template fixes

Hi, From: Maayan Kashani Sent: Thursday, June 6, 2024 12:55 PM To: dev@dpdk.org Cc: Maayan Kashani; Dariusz Sosnowski; Raslan Darawsheh Subject: [PATCH v4 0/7] HWS non-template fixes Series of fixes in hws code for the non template. Yevgeny Kliteynik (7): net/mlx5/hws: fix bug in matcher disc

Re: [PATCH v5 1/6] net/mlx5: update NTA rule pattern and actions flags

Hi, From: Maayan Kashani Sent: Monday, June 10, 2024 11:50 AM To: dev@dpdk.org Cc: Maayan Kashani; Dariusz Sosnowski; Raslan Darawsheh; Gregory Etelson; Slava Ovsiienko; Ori Kam; Suanming Mou; Matan Azrad Subject: [PATCH v5 1/6] net/mlx5: update NTA rule pattern and actions flags From: Gregory

Re: [PATCH v3] mempool: dump includes list of memory chunks

在 2024/6/11 14:51, Morten Brørup 写道: Added information about the memory chunks holding the objects in the mempool when dumping the status of the mempool to a file. Signed-off-by: Morten Brørup Acked-by: Paul Szczepanek Acked-by: Andrew Rybchenko Acked-by: Konstantin Ananyev --- v3: * Fix o

Re: [PATCH v3 5/5] vhost: manage FD with epoll

Hi Chenbo, On 4/28/24 05:22, Chenbo Xia wrote: Hi Maxime, On Apr 9, 2024, at 19:48, Maxime Coquelin wrote: External email: Use caution opening links or attachments From: David Marchand Switch to epoll so that the concern over the poll() fd array is removed. Add a simple list of used entr

[PATCH v15 1/6] lib: allow libraries with no sources

Allow header only libraries. Signed-off-by: Paul Szczepanek Reviewed-by: Honnappa Nagarahalli Acked-by: Bruce Richardson --- lib/meson.build | 16 1 file changed, 16 insertions(+) diff --git a/lib/meson.build b/lib/meson.build index 179a272932..7c90602bf5 100644 --- a/lib/mes

[PATCH v15 0/6] add pointer compression API

This patchset is proposing adding a new header only library with utility functions that allow compression of arrays of pointers. Since this is a header only library a patch needed to be added to amend the build system to allow adding libraries without source files. When passing caches full of poi

[PATCH v15 2/6] mempool: add functions to get extra mempool info

Add two functions: - rte_mempool_get_mem_range - get virtual memory range of the objects in the mempool, - rte_mempool_get_obj_alignment - get alignment of objects in the mempool. Add two tests that test these new functions. Signed-off-by: Paul Szczepanek Reviewed-by: Jack Bond-Preston Reviewed

[PATCH v15 3/6] ptr_compress: add pointer compression library

Add a new utility header for compressing pointers. The provided functions can store pointers as 32-bit or 16-bit offsets. The compression takes advantage of the fact that pointers are usually located in a limited memory region (like a mempool). We can compress them by converting them to offsets fr

[PATCH v15 5/6] docs: add pointer compression guide

Documentation added in the prog guide for the new utility functions for pointer compression showing example code and potential usecases. Signed-off-by: Paul Szczepanek Reviewed-by: Honnappa Nagarahalli Reviewed-by: Nathan Brown Reviewed-by: Jack Bond-Preston --- MAINTAINERS

[PATCH v15 4/6] test: add pointer compress tests to ring perf test

Add a test that runs a zero copy burst enqueue and dequeue on a ring of raw pointers and compressed pointers at different burst sizes to showcase performance benefits of newly added pointer compression APIs. Refactored threading code to pass more parameters to threads to reuse existing code. Added

[PATCH v15 6/6] test: add unit test for ptr compression

Test compresses and decompresses pointers with various combinations of memory regions and alignments and verifies the pointers are recovered correctly. Additionally tests helper macros perform calculations correctly. Signed-off-by: Paul Szczepanek Reviewed-by: Honnappa Nagarahalli Reviewed-by: N

Re: [PATCH v14 2/6] mempool: add functions to get extra mempool info

On 10/06/2024 15:24, Konstantin Ananyev wrote: [snip] > > With that changes in place: > Acked-by: Konstantin Ananyev > I have applied your comments in v15. [snip] >> + >> +size_t rte_mempool_get_obj_alignment(const struct rte_mempool *mp) >> +{ >> +if (mp == NULL) >> +retur

Re: [PATCH v14 3/6] ptr_compress: add pointer compression library

On 10/06/2024 16:18, David Marchand wrote: > Hello, > > On Fri, Jun 7, 2024 at 5:10 PM Paul Szczepanek > wrote: >> >> Add a new utility header for compressing pointers. The provided >> functions can store pointers as 32-bit or 16-bit offsets. >> >> The compression takes advantage of the fact

[PATCH v4 1/5] vhost: rename polling mutex

This trivial patch fixes a typo in fd's manager polling mutex name. Reviewed-by: David Marchand Signed-off-by: Maxime Coquelin --- lib/vhost/fd_man.c | 8 lib/vhost/fd_man.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/vhost/fd_man.c b/lib/vhost/fd_man.c i

[PATCH v4 0/5] vhost: FD manager improvements

This series aims at improving the Vhost FD manager. The fdset internals is hidden from its callers, the notification/synchronization is made systematic for every FD add/del operations and finally the code is reworked to make use of epoll insteal of poll which reduces the complexity (less locks in

[PATCH v4 2/5] vhost: make use of FD manager init function

Instead of statically initialize the fdset, this patch converts VDUSE and Vhost-user to use fdset_init() function, which now also initialize the mutexes. This is preliminary rework to hide FDs manager pipe from its users. Signed-off-by: Maxime Coquelin --- lib/vhost/fd_man.c | 10 +++--- li

[PATCH v4 3/5] vhost: hide synchronization within FD manager

This patch forces synchronization for all FDs additions or deletions in the FD set. With that, it is no more necessary for the user to know about the FD set pipe, so hide its initialization in the FD manager. Signed-off-by: Maxime Coquelin --- lib/vhost/fd_man.c | 180 ---

[PATCH v4 4/5] vhost: improve fdset initialization

This patch heavily reworks fdset initialization: - fdsets are now dynamically allocated by the FD manager - the event dispatcher is now created by the FD manager - struct fdset is now opaque to VDUSE and Vhost Signed-off-by: Maxime Coquelin --- lib/vhost/fd_man.c | 171 +++

[PATCH v4 5/5] vhost: manage FD with epoll

From: David Marchand Switch to epoll so that the concern over the poll() fd array is removed. Add a simple list of used entries and track the next free entry. epoll() is thread safe, we no more need a synchronization mechanism and so can remove the notification pipe. Signed-off-by: David Marcha

Re: [PATCH v4 0/5] vhost: FD manager improvements

On Tue, Jun 11, 2024 at 3:40 PM Maxime Coquelin wrote: > > > This series aims at improving the Vhost FD manager. > The fdset internals is hidden from its callers, the > notification/synchronization is made systematic for > every FD add/del operations and finally the code is > reworked to make use

Re: [PATCH v8 1/3] app/testpmd: fix the testpmd field string sequence

On 6/7/2024 3:02 PM, Rongwei Liu wrote: > The field string should be in the same order as the rte_flow_field_id > enumration definitions > > Fixes: bfc007802 ("ethdev: allow modifying IPv6 FL and TC fields") > Cc: michae...@nvidia.com > Cc: sta...@dpdk.org > Fixes: d66aa38f431d ("ethdev: allow

Re: [PATCH v8 2/3] ethdev: add VXLAN last reserved field

On 6/7/2024 3:02 PM, Rongwei Liu wrote: > diff --git a/lib/net/rte_vxlan.h b/lib/net/rte_vxlan.h > index 997fc784fc..57300fb442 100644 > --- a/lib/net/rte_vxlan.h > +++ b/lib/net/rte_vxlan.h > @@ -41,7 +41,10 @@ struct rte_vxlan_hdr { > uint8_tflags;/**< Should be 8 (I

Re: [V3 0/2] net: extend VXLAN header to support more extensions

On 6/5/2024 9:09 AM, Gavin Li wrote: > In this patch series, all the VXLAN extension header will be merged with > VXLAN as union if the overlapped field has different format among > protocols. The existing VXLAN-GPE will be marked as deprecated and new > extensions of VXLAN should be added to VXLAN

Re: [PATCH v8 0/3] support VXLAN last reserved byte modification

On 6/7/2024 3:02 PM, Rongwei Liu wrote: > v8: enhance commit log and remap testpmd "last_rsvd" to new union. > v7: squash, add more commit logs. > v6: add union into vxlan header. > v5: change the field enumeration naming. > v4: specify the limitation with exact port number. > v3: squash testpmd an

Re: Coding Style for local variables

On 6/10/2024 4:10 PM, Morten Brørup wrote: > The coding style guide says: > > "Variables should be declared at the start of a block of code rather than in > the middle. The exception to this is when the variable is const in which case > the declaration must be at the point of first use/assignmen

Re: [PATCH v5 0/6] more replacement of zero length array

On Wed, Mar 6, 2024 at 9:14 PM Tyler Retzlaff wrote: > > Replace some missed zero length arrays not captured in the > original series. > https://patchwork.dpdk.org/project/dpdk/list/?series=30410&state=* > > Zero length arrays are a GNU extension that has been > superseded by flex arrays. > > http

Re: [PATCH v3 2/4] dts: add context manager for interactive shells

On Tue, Jun 11, 2024 at 5:17 AM Juraj Linkeš wrote: > > > > On 10. 6. 2024 22:06, Jeremy Spewock wrote: > > Overall, my thoughts are that it's definitely an interesting idea to > > make the normal shell subclass the critical. I explain more below, but > > basically I think it makes sense as long a

Re: [PATCH v3 4/4] dts: add test case that utilizes offload to pmd_buffer_scatter

On Tue, Jun 11, 2024 at 5:22 AM Juraj Linkeš wrote: > > > > On 10. 6. 2024 22:08, Jeremy Spewock wrote: > > On Mon, Jun 10, 2024 at 11:22 AM Juraj Linkeš > > wrote: > >> > >>> diff --git a/dts/tests/TestSuite_pmd_buffer_scatter.py > >>> b/dts/tests/TestSuite_pmd_buffer_scatter.py > >>> index 41f

Re: Coding Style for local variables

On Tue, 11 Jun 2024 16:10:33 +0100 Ferruh Yigit wrote: > On 6/10/2024 4:10 PM, Morten Brørup wrote: > > The coding style guide says: > > > > "Variables should be declared at the start of a block of code rather than > > in the middle. The exception to this is when the variable is const in which

[PATCH v2 0/2] VLAN test suite

This patch contains the initial implemenation of a VLAN test suite that ensures the correct functionality of VLAN filtering, stripping, and header insertion on the poll mode driver. VLAN filtering is a useful feature for separating one Ethernet network into multiple logical networks, which enhances

[PATCH v2 1/2] Initial implementation for VLAN test suite

--- dts/tests/TestSuite_vlan.py | 172 1 file changed, 172 insertions(+) create mode 100644 dts/tests/TestSuite_vlan.py diff --git a/dts/tests/TestSuite_vlan.py b/dts/tests/TestSuite_vlan.py new file mode 100644 index 00..121766de3b --- /dev/null +++

[PATCH v2 2/2] conf schema

--- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/config/conf_yaml_schema.json index 4731f4511d..eca8244f27 100644 --- a/dts/framework/config/conf_yaml_schema.json +++ b/d

Re: [RFC 0/2] ethdev: update GENEVE option item structure

On 4/17/2024 8:23 AM, Michael Baum wrote: > The "rte_flow_item_geneve_opt" structure describes the GENEVE TLV option > header according to RFC 8926 [1]: > > struct rte_flow_item_geneve_opt { > rte_be16_t option_class; > uint8_t option_type; > uint8_t option_len; > uint32_t

Re: [PATCH v3 3/7] app/testpmd: fix outer IP checksum offload

On 4/18/2024 9:20 AM, David Marchand wrote: > Resetting the outer IP checksum to 0 is not something mandated by the > mbuf API and is done by rte_eth_tx_prepare(), or per driver if needed. > > Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation") > Cc: sta...@dpdk.org > > Signed-off-by: David Marcha

Re: [PATCH v3 0/7] Fix outer UDP checksum for Intel nics

On 5/27/2024 7:06 PM, Ali Alnubani wrote: >> -Original Message- >> From: David Marchand >> Sent: Thursday, April 18, 2024 11:20 AM >> To: dev@dpdk.org >> Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; >> ferruh.yi...@amd.com >> Subject: [PATCH v3 0/7] Fix outer UDP checksum for Intel nics >>

Re: [PATCH v3] app/testpmd: fix lcore ID restriction

On 6/6/2024 12:27 PM, Sivaprasad Tummala wrote: > With modern CPUs, it is possible to have higher > CPU count thus we can have higher RTE_MAX_LCORES. > In testpmd application, the current config forwarding > cores option "--nb-cores" is hard limited to 255. > > The patch fixes this constraint and

Re: [PATCH v2 0/4] Add support for link speed lanes

On 6/2/2024 3:45 AM, Damodharam Ammepalli wrote: > NIC adapters can support speeds with different lanes configuration. > > This patchset will allow users: > - get the Lanes capability per speed supported by the ethernet > controller. > - set the lanes configuration using a new CLI > - Display th

Re: [PATCH v2 1/4] lib/ethdev: Add link_speed lanes support into rte lib

On 6/2/2024 3:45 AM, Damodharam Ammepalli wrote: > Update the eth_dev_ops structure with new function vectors > to get and set number of speed lanes. This will help user to > configure the same fixed speed with different number of lanes > based on the physical carrier type. > > Signed-off-by: Dam

Re: [PATCH v2 2/4] testpmd: Add speed lanes to testpmd config and show command

On 6/2/2024 3:45 AM, Damodharam Ammepalli wrote: > Add speed lanes configuration and display commands support > to testpmd. Also provide display the lanes info show device info. > > testpmd> > testpmd> port stop 0 > testpmd> port config 0 speed_lanes 4 > testpmd> port config 0 speed 20 duplex

Re: [PATCH v2 3/4] lib/ethdev: add support for displaying lanes capability

On 6/2/2024 3:45 AM, Damodharam Ammepalli wrote: > Add new rte_lib callback to display ethernet controller's > supporting speeds and bitmap of supported lanes per speed. > > The new command display looks like this. > > testpmd> show port 0 speed_lanes capabilities > > Supported speeds V

Re: [PATCH v2 4/4] testpmd: add support for displaying lanes capability

On 6/2/2024 3:45 AM, Damodharam Ammepalli wrote: > Add a new api support that displays the speeds and bitmap of > supported lanes configuration by the ethernet controller. > This patch adds support in the testpmd cli chain. > > Signed-off-by: Damodharam Ammepalli > --- > app/test-pmd/cmdline.c

Re: [RFC 1/4] gro: fix overwrite unprocessed packets

On 5/23/2024 5:26 PM, Konstantin Ananyev wrote: > From: Konstantin Ananyev > > gro_vxlan_tcp4_tbl_timeout_flush() is called without taking into account > that first entries in pkts[] can be already occupied by > un-processed packets. > > Fixes: 74080d7dcf31 ("gro: support IPv6 for TCP") > Cc: st

Re: [RFC 2/4] gro: remove use of VLAs

On 5/23/2024 5:26 PM, Konstantin Ananyev wrote: > From: Konstantin Ananyev > > ../lib/gro/rte_gro.c:182:34: warning: variable length array used [-Wvla] > ../lib/gro/rte_gro.c:363:34: warning: variable length array used [-Wvla] > > In both cases the pattern is the same: we use unprocess_pkts[nb_p

Re: [RFC 3/4] net/ixgbe: remove use of VLAs

On 5/23/2024 5:26 PM, Konstantin Ananyev wrote: > From: Konstantin Ananyev > > 1) ../drivers/net/ixgbe/ixgbe_ethdev.c:3556:46: warning: variable length > array used [-Wvla] > 2) ../drivers/net/ixgbe/ixgbe_ethdev.c:3739:23: warning: variable length > array used [-Wvla] > 3) ../drivers/net/ixgbe/

Re: [RFC 4/4] net/ice: remove use of VLAs

On 5/23/2024 5:26 PM, Konstantin Ananyev wrote: > From: Konstantin Ananyev > > ../drivers/net/ice/ice_rxtx.c:1871:29: warning: variable length array used > [-Wvla] > > Here VLA is used as a temp array for mbufs that will be used as a split > RX data buffers. > As at any given time only one thre

Re: [RFC 0/4] remove use of VLA

On 5/23/2024 5:26 PM, Konstantin Ananyev wrote: > From: Konstantin Ananyev > > To continue further work on VLA replacement for these series: > https://patches.dpdk.org/project/dpdk/list/?series=31887 > extra few patches to remove VLA for gro lib and ixgbe and ice PMDs. > DISCLAIMER: I don't have

RE: [PATCH v8 2/3] ethdev: add VXLAN last reserved field

BR Rongwei > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, June 11, 2024 22:53 > To: rongwei liu ; dev@dpdk.org; Matan Azrad > ; Slava Ovsiienko ; Ori Kam > ; Suanming Mou ; NBU- > Contact-Thomas Monjalon (EXTERNAL) > Cc: Dariusz Sosnowski ; Aman Singh > ; Yuying Zhang ; > A

Re: [PATCH 0/2] NFP extend stats

On 5/23/2024 3:49 AM, Chaoyong He wrote: > This patch series related with NFP xstats logic: > - Fix one bug about xstats when using coreNIC firmware with multi-PF. > - Add the support of xstats for flower firmware. > > Chaoyong He (2): > net/nfp: fix xstats problem for multi PF firmware > net/

[PATCH v3 00/22] Update MEV TS Base Driver

These patches integrate the latest changes in MEV TS IDPF Base driver. --- v3: - Removed additional whitespace changes - Fixed warnings of CI - Updated documentation relating to MEV TS FW release --- Soumyadeep Hore (22): common/idpf: added NVME CPF specific code with defines common/idpf: upd

[PATCH v3 01/22] common/idpf: added NVME CPF specific code with defines

Removes NVME dependency on memory allocations and uses a prepared buffer instead. The changes do not affect other components. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_controlq.c | 23 +++- drivers/common/idpf/base/idpf_controlq_api.h | 7 +- 2 fi

[PATCH v3 02/22] common/idpf: updated IDPF VF device ID

Update IDPF VF device id to 145C. Also added device ID for S-IOV device. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_devids.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/common/idpf/base/idpf_devids.h b/drivers/common/idpf/base/idpf_d

[PATCH v3 03/22] common/idpf: added new virtchnl2 capability and vport flag

Removed unused VIRTCHNL2_CAP_ADQ capability and use that bit for VIRTCHNL2_CAP_INLINE_FLOW_STEER capability. Added VIRTCHNL2_VPORT_INLINE_FLOW_STEER_ENA port flag to allow enable/disable per vport. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 7 --- 1 file chang

[PATCH v3 04/22] common/idpf: moved the idpf HW into API header file

There is an issue of recursive header file includes in accessing the idpf_hw structure. The controlq.h has the structure definition and osdep header file needs that. The problem is the controlq.h also needs the osdep header file contents, basically both dependent on each other. Moving the definiti

[PATCH v3 05/22] common/idpf: avoid defensive programming

Based on the upstream feedback, driver should not use any defensive programming strategy by checking for NULL pointers and other conditional checks unnecessarily in the code flow to fall back, instead fail and fix the bug in a proper way. Some of the checks are identified and removed/wrapped in th

[PATCH v3 06/22] common/idpf: use BIT ULL for large bitmaps

For bitmaps greater than 32 bits, use BIT_ULL instead of BIT macro as reported by compiler. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 70 ++-- 1 file changed, 35 insertions(+), 35 deletions(-) diff --git a/drivers/common/idpf/base/virtchnl

[PATCH v3 07/22] common/idpf: convert data type to 'le'

'u32' data type is used for the struct members in 'virtchnl2_version_info' which should be '__le32'. Make the change accordingly. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/idpf/ba

[PATCH v3 08/22] common/idpf: compress RXDID mask definitions

Instead of using the long RXDID definitions, introduce a macro which uses common part of the RXDID definitions i.e. VIRTCHNL2_RXDID_ and the bit passed to generate a mask. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2_lan_desc.h | 31 ++- 1 file changed, 1

[PATCH v3 09/22] common/idpf: refactor size check macro

Instead of using 'divide by 0' to check the struct length, use the static_assert macro Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/common/idpf/base/virtchnl2.h b/drivers/common/

[PATCH v3 10/22] common/idpf: update mask of Rx FLEX DESC ADV FF1 M

Mask for VIRTCHNL2_RX_FLEX_DESC_ADV_FF1_M was defined wrongly and this patch fixes it. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2_lan_desc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/idpf/base/virtchnl2_lan_desc.h b/drivers/com

[PATCH v3 11/22] common/idpf: use 'pad' and 'reserved' fields appropriately

'pad' naming is used if the field is actually a padding byte and is also used for bytes meant for future addition of new fields, whereas 'reserved' is only used if the field is reserved and cannot be used for any other purpose. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl

[PATCH v3 12/22] common/idpf: move related defines into enums

Changes all groups of related defines to enums. The names of the enums are chosen to follow the common part of the naming pattern as much as possible. Replaced the common labels from the comments with the enum names. While at it, modify header description based on upstream feedback. Some variabl

[PATCH v3 13/22] common/idpf: avoid variable 0-init

Don't initialize the variables if not needed. Also use 'err' instead of 'status', 'ret_code', 'ret' etc. for consistency and change the return label 'sq_send_command_out' to 'err_unlock'. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_controlq.c | 63 +--

[PATCH v3 14/22] common/idpf: update in PTP message validation

When the message for getting timestamp latches is sent by the driver, number of latches is equal to 0. Current implementation of message validation function incorrectly notifies this kind of message length as invalid. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 4 ++

[PATCH v3 15/22] common/idpf: rename INLINE FLOW STEER to FLOW STEER

This capability bit indicates both inline as well as side band flow steering capability. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/idpf/base/virtchnl2.h b/drivers/common/idpf/base/vi

[PATCH v3 16/22] common/idpf: add wmb before tail

Introduced through customer's feedback in their attempt to address some bugs this introduces a memory barrier before posting ctlq tail. This makes sure memory writes have a chance to take place before HW starts messing with the descriptors. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/

[PATCH v3 17/22] drivers: add flex array support and fix issues

With the internal Linux upstream feedback that is received on IDPF driver and also some references available online, it is discouraged to use 1-sized array fields in the structures, especially in the new Linux drivers that are going to be upstreamed. Instead, it is recommended to use flex array fie

[PATCH v3 18/22] common/idpf: enable flow steer capability for vports

Added virtchnl2_flow_types to be used for flow steering. Added flow steer cap flags for vport create. Add flow steer flow types and action types for vport create. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 60 ++-- 1 file changed, 57 inser

[PATCH v3 19/22] common/idpf: add a new Tx context descriptor structure

Adding a new structure for the context descriptor that contains the support for timesync packets, where the index for timestamping is set. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_lan_txrx.h | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff

[PATCH v3 21/22] drivers: adding type to idpf vc queue switch

Adding an argument named type to define queue type in idpf_vc_queue_switch(). This solves the issue of improper queue type in virtchnl2 message. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/idpf_common_virtchnl.c | 8 ++-- drivers/common/idpf/idpf_common_virtchnl.h | 2 +- driver

[PATCH v3 20/22] common/idpf: remove idpf common file

The file is redundant in our implementation and is not required further. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_common.c | 382 - drivers/common/idpf/base/meson.build | 1 - 2 files changed, 383 deletions(-) delete mode 100644 drivers/common

[PATCH v3 22/22] doc: updated the documentation for cpfl PMD

Updated the latest support for CPFL PMD in MEV TS firmware version 1.4. Signed-off-by: Soumyadeep Hore --- doc/guides/nics/cpfl.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/guides/nics/cpfl.rst b/doc/guides/nics/cpfl.rst index 9b7a99c894..528c809819 100644 --- a/doc/guides/nics/