> From: Du, Frank [mailto:frank...@intel.com]
> Sent: Wednesday, 22 May 2024 03.25
>
> > From: Ferruh Yigit
> > Sent: Wednesday, May 22, 2024 1:58 AM
> >
> > On 5/11/2024 6:26 AM, Frank Du wrote:
> > > The current calculation assumes that the mbufs are contiguous.
> > > However, this assumption i
https://bugs.dpdk.org/show_bug.cgi?id=1447
Bug ID: 1447
Summary: segfault while running dpdk app test (
event_crypto_adapter_autotest )
Product: DPDK
Version: 22.11
Hardware: All
OS: All
Status:
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Tuesday, 21 May 2024 22.17
>
> This header implements 64 bit counters using atomic
> operations but with a weak memory ordering so that
> they are safe against load/store splits on 32 bit platforms.
>
> Signed-off-by: Stephen H
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Wednesday, 22 May 2024 04.21
>
> On Tue, 21 May 2024 17:02:14 -0700
> Tyler Retzlaff wrote:
>
> > MSVC does not support inline asm so replace crc32 inline function
> > implementations with intrinsics compatible with all toolch
Hi Akhil,
2 acked for this patch but it's still not yet accepted.
Anything more required for this patch?
Thanks,
Ganapati
> -Original Message-
> From: Power, Ciara
> Sent: Wednesday, April 17, 2024 5:11 PM
> To: Kundapura, Ganapati ; dev@dpdk.org
> Cc: Gujjar, Abhinandan S ;
> gak...@ma
> Subject: [EXTERNAL] RE: [PATCH v1] crypto: fix build issues on crypto
> callbacks
> macro undefined
>
> Hi Akhil,
> 2 acked for this patch but it's still not yet accepted.
> Anything more required for this patch?
>
Hi Ganapati,
I haven't started picking patches on crypto tree yet. Will start
On 5/22/2024 2:25 AM, Du, Frank wrote:
>> -Original Message-
>> From: Ferruh Yigit
>> Sent: Wednesday, May 22, 2024 1:58 AM
>> To: Du, Frank ; dev@dpdk.org; Andrew Rybchenko
>> ; Morten Brørup
>>
>> Cc: Loftus, Ciara ; Burakov, Anatoly
>>
>> Subject: Re: [PATCH v2] net/af_xdp: fix umem m
On 5/22/2024 8:26 AM, Morten Brørup wrote:
>> From: Du, Frank [mailto:frank...@intel.com]
>> Sent: Wednesday, 22 May 2024 03.25
>>
>>> From: Ferruh Yigit
>>> Sent: Wednesday, May 22, 2024 1:58 AM
>>>
>>> On 5/11/2024 6:26 AM, Frank Du wrote:
The current calculation assumes that the mbufs are
> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com]
> Sent: Wednesday, 22 May 2024 12.01
>
> On 5/22/2024 2:25 AM, Du, Frank wrote:
> >> From: Ferruh Yigit
> >> Sent: Wednesday, May 22, 2024 1:58 AM
> >>
> >> Isn't there a mempool flag that can help us figure out mempool is not IOVA
> >> contiguou
Reviewed-by: Patrick Robb
The enqueue/dequeue callback test cases were using the
test_null_burst_operation() for doing enqueue/dequeue.
But this function is only designed to be run for NULL PMD.
Hence for other PMDs, the callback was not getting called.
Now, used a function test_AES_CBC_HMAC_SHA1_encrypt_digest()
which is n
> Subject: RE: [PATCH v1] crypto: fix build issues on crypto callbacks macro
> undefined
>
> > Subject: [EXTERNAL] RE: [PATCH v1] crypto: fix build issues on crypto
> > callbacks
> > macro undefined
> >
> > Hi Akhil,
> > 2 acked for this patch but it's still not yet accepted.
> > Anything more re
Reviewed-by: Patrick Robb
I don't have any comments beyond Luca's suggestions, but saw the typo below.
On Tue, May 14, 2024 at 4:15 PM wrote:
> +def __exit__(self, type: BaseException, value: BaseException, traceback:
> TracebackType) -> None:
> +"""Exit the context block.
> +
> +
On 5/21/2024 4:44 PM, Stephen Hemminger wrote:
> On Mon, 20 May 2024 18:51:37 +0100
> Ferruh Yigit wrote:
>
>> On 5/2/2024 10:31 PM, Stephen Hemminger wrote:
>>> The names of Linux network devices are IFNAMSIZ(16) not the
>>> same as DPDK which has up to 64 characters. Don't need to
>>> hold onto
On 5/22/2024 12:03 PM, Morten Brørup wrote:
>> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com]
>> Sent: Wednesday, 22 May 2024 12.01
>>
>> On 5/22/2024 2:25 AM, Du, Frank wrote:
From: Ferruh Yigit
Sent: Wednesday, May 22, 2024 1:58 AM
Isn't there a mempool flag that can help u
Hi Akhil,
My patch addresses build issue on setting RTE_CRYPTO_CALLBACKS to 0 and
Checks for callback registered or not from the next node instead of head node
as callback head node is always valid pointer.
Thanks,
Ganapati
> -Original Message-
> From: Akhil Goyal
> Sent: Wednesday,
From: Pavan Nikhilesh
Add support to configure higher chunk size by using the new
OPEN_V2 mailbox, this improves performance as the number of
mempool allocs are reduced.
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Amit Prakash Shukla
---
drivers/common/cnxk/roc_dpi.c | 39 +
Hi Juraj,
Here's my review. Excuse me for the unordinary format, but I thought
it would have just been easier to convey my suggestions through code.
Apart from the smaller suggestions, the most important one I think is
that we should make sure to enforce type checking (and hinting).
Overall I lik
On Wed, 22 May 2024 10:31:39 +0200
Morten Brørup wrote:
> > +/**
> > + * @warning
> > + * @b EXPERIMENTAL: this API may change without prior notice.
> > + *
> > + * On native 64 bit platform, counter is implemented as basic
> > + * 64 bit unsigned integer that only increases.
> > + */
> > +typede
On Wed, 22 May 2024 10:31:39 +0200
Morten Brørup wrote:
> > +/* On 32 bit platform, need to use atomic to avoid load/store tearing */
> > +typedef RTE_ATOMIC(uint64_t) rte_counter64_t;
>
> As shown by Godbolt experiments discussed in a previous thread [2],
> non-tearing 64 bit counters can be
On 5/21/2024 9:12 PM, Stephen Hemminger wrote:
> The support of doing RSS for rte_flow_action was a cool idea
> but it has been broken for several releases of DPDK as the
> underlying kernel and BPF infrastructure changed.
>
> This series cleans up the BPF program, implements several
> features th
In addition to the pmd_scatter suite, I refactored my jumboframes
suite to use this new module for testing purposes; everything works
great, and the format looks much better too.
Tested-by: Nicholas Pratte
Reviewed-by: Nicholas Pratte
On Thu, May 9, 2024 at 7:21 AM Luca Vizzarro wrote:
>
> He
Reviewed-by: Patrick Robb
Adds common code for collecting basic statistics used by many
SW based PMD's such as af_packet, af_xdp, null, tap and ring.
This version uses two counters (current and offset) to implement
SMP safe reset on 64 bit platforms; this avoids having to do locked
operation in the fast path. On 32 bit pl
This header implements 64 bit counters that can be reset.
The counter increment in the fast path requires no locked
operations. Reading and resetting the counter is handled
by keeping track of a zero offset.
Signed-off-by: Stephen Hemminger
Acked-by: Morten Brørup
---
lib/eal/include/meson.buil
Introduce common helper routines for keeping track of per-queue
statistics in SW PMD's. The code in several drivers had
copy/pasted the same code for this, but had common issues
with 64 bit counters on 32 bit platforms.
Signed-off-by: Stephen Hemminger
---
lib/ethdev/ethdev_swstats.c | 102 +
Use the new generic SW stats.
Add a note about how errors and kernel full should be handled.
Signed-off-by: Stephen Hemminger
---
drivers/net/af_packet/rte_eth_af_packet.c | 78 +--
1 file changed, 17 insertions(+), 61 deletions(-)
diff --git a/drivers/net/af_packet/rte_eth_
Use common code for all SW stats.
Signed-off-by: Stephen Hemminger
---
drivers/net/af_xdp/rte_eth_af_xdp.c | 85 -
1 file changed, 22 insertions(+), 63 deletions(-)
diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c
b/drivers/net/af_xdp/rte_eth_af_xdp.c
index 6ba455bb
Use common statistics for SW drivers.
Signed-off-by: Stephen Hemminger
---
drivers/net/pcap/pcap_ethdev.c | 100 -
1 file changed, 22 insertions(+), 78 deletions(-)
diff --git a/drivers/net/pcap/pcap_ethdev.c b/drivers/net/pcap/pcap_ethdev.c
index bfec085045..468
Use generic per-queue infrastructure.
Signed-off-by: Stephen Hemminger
---
drivers/net/ring/rte_eth_ring.c | 63 +++--
1 file changed, 20 insertions(+), 43 deletions(-)
diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
index b16f5d55f2..3
Use new common sw statistics.
Signed-off-by: Stephen Hemminger
---
drivers/net/tap/rte_eth_tap.c | 75 ++-
drivers/net/tap/rte_eth_tap.h | 15 ++-
2 files changed, 16 insertions(+), 74 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/
Use the new common code for statistics.
This also fixes the bug that this driver was not accounting
for bytes.
Signed-off-by: Stephen Hemminger
---
drivers/net/null/rte_eth_null.c | 83 +
1 file changed, 21 insertions(+), 62 deletions(-)
diff --git a/drivers/net/
On Tue, 21 May 2024 13:12:54 -0700
Stephen Hemminger wrote:
> The names of Linux network devices are IFNAMSIZ(16) not the
> same as DPDK which has up to 64 characters. Don't need to
> hold onto the whole ifreq to save the remote interface flags.
>
> Make sure packet and byte counters are read on
rte_free accepts only non-cva qualified arguments so cast away
RTE_ATOMIC qualification for tbl_chng_cnt and h->tbl_chng_cnt when
calling rte_free.
Without this change using enable_stdatomic=true with LLVM or MSVC will
result in a warning being emitted for discarding the atomic
qualification.
v2:
rte_free accepts only non-cva qualified arguments so cast away
RTE_ATOMIC qualification for tbl_chng_cnt and h->tbl_chng_cnt when
calling rte_free.
Without this change using enable_stdatomic=true with LLVM or MSVC will
result in a warning being emitted for discarding the atomic
qualification.
Sig
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Wednesday, 22 May 2024 17.38
>
> On Wed, 22 May 2024 10:31:39 +0200
> Morten Brørup wrote:
>
> > > +/* On 32 bit platform, need to use atomic to avoid load/store
> tearing */
> > > +typedef RTE_ATOMIC(uint64_t) rte_counter64_t
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Wednesday, 22 May 2024 17.33
>
> On Wed, 22 May 2024 10:31:39 +0200
> Morten Brørup wrote:
>
> > > +/**
> > > + * @warning
> > > + * @b EXPERIMENTAL: this API may change without prior notice.
> > > + *
> > > + * On native 64 b
> Hi Akhil,
>My patch addresses build issue on setting RTE_CRYPTO_CALLBACKS to 0 and
> Checks for callback registered or not from the next node instead of head node
> as
> callback head node is always valid pointer.
>
Agreed but your patch cannot be verified without the fix as the callbacks a
On Wed, May 22, 2024 at 07:57:01PM +0200, Morten Brørup wrote:
> > From: Stephen Hemminger [mailto:step...@networkplumber.org]
> > Sent: Wednesday, 22 May 2024 17.38
> >
> > On Wed, 22 May 2024 10:31:39 +0200
> > Morten Brørup wrote:
> >
> > > > +/* On 32 bit platform, need to use atomic to avoi
On Wed, 22 May 2024 12:01:12 -0700
Tyler Retzlaff wrote:
> On Wed, May 22, 2024 at 07:57:01PM +0200, Morten Brørup wrote:
> > > From: Stephen Hemminger [mailto:step...@networkplumber.org]
> > > Sent: Wednesday, 22 May 2024 17.38
> > >
> > > On Wed, 22 May 2024 10:31:39 +0200
> > > Morten Brørup
On Wed, 22 May 2024 20:09:23 +0200
Morten Brørup wrote:
> > There are no size_bins in the current version of the patch.
> > And the number of counters in ethdev part are small so it is less of a
> > concern.
> > The code is easier to maintain if the counter object is self contained.
>
> I agre
On 4/1/2024 11:29 PM, Damodharam Ammepalli wrote:
> On Mon, Apr 1, 2024 at 1:07 PM Thomas Monjalon wrote:
>>
>> 30/03/2024 12:38, huangdengdui:
>>> But, there are different solutions for the device to report the setting
>>> lane capability, as following:
>>> 1. Like the current patch, reporting de
On 5/16/2024 1:48 PM, huangdengdui wrote:
> Hi, Ferruh
> Sorry for replying your email very late.
> The answers to your questions are as follows. Please correct me if I am wrong.
>
> On 2024/4/4 21:58, Ferruh Yigit wrote:
>>
>> Hi Dengdui, Damodharam,
>>
>> As details of the implementation under d
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Wednesday, 22 May 2024 21.54
>
> On Wed, 22 May 2024 20:09:23 +0200
> Morten Brørup wrote:
>
> > > There are no size_bins in the current version of the patch.
> > > And the number of counters in ethdev part are small so it is
On 3/22/2024 10:25 PM, Damodharam Ammepalli wrote:
> BRCM576xx NIC modules support speeds with different lanes configuration.
> This is an alternate proposal to
> https://patchwork.dpdk.org/project/dpdk/list/?series=31593
>
> Please provide your review. Broadcom driver patches will follow.
>
> Da
When using multi PF firmware, the other ports always get the
xstats of the first port.
Fix it by adding the offset for other ports.
Fixes: 8ad2cc8fec37 ("net/nfp: add flag for multiple PFs support")
Cc: peng.zh...@corigine.com
Cc: sta...@dpdk.org
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
Add support the extend stats for flower firmware, include the stats for
each queue.
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
Reviewed-by: Peng Zhang
---
.../net/nfp/flower/nfp_flower_representor.c | 47 ++-
.../net/nfp/flower/nfp_flower_representor.h | 4 ++
drivers/net
This patch series related with NFP xstats logic:
- Fix one bug about xstats when using coreNIC firmware with multi-PF.
- Add the support of xstats for flower firmware.
Chaoyong He (2):
net/nfp: fix xstats problem for multi PF firmware
net/nfp: add support of xstats for flower firmware
.../ne
Check whether CPFL PMD runs on Host or ACC
Signed-off-by: Shaiq Wani
---
drivers/net/cpfl/cpfl_ethdev.c | 21 +
drivers/net/cpfl/cpfl_ethdev.h | 5 -
2 files changed, 25 insertions(+), 1 deletion(-)
diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_eth
> -Original Message-
> From: Morten Brørup
> Sent: Wednesday, May 22, 2024 3:27 PM
> To: Du, Frank ; Ferruh Yigit ;
> dev@dpdk.org; Andrew Rybchenko ; Burakov,
> Anatoly
> Cc: Loftus, Ciara
> Subject: RE: [PATCH v2] net/af_xdp: fix umem map size for zero copy
>
> > From: Du, Frank [mail
50 matches
Mail list logo
