Re: [PATCH v5 31/45] baseband/acc: use rte stdatomic API

On Mon, May 13, 2024 at 9:05 PM Morten Brørup wrote: > > Tyler, it looks like the line continuations in > /drivers/baseband/acc/rte_vrb_pmd.c are indented with four spaces instead of > double . For Tyler defence, indentation is a nice mess in a lot of DPDK code (for legacy, superficial reviews

Re: [PATCH v4] devtools: add .clang-format file

On Mon, May 13, 2024 at 09:11:32PM +0200, Morten Brørup wrote: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Monday, 13 May 2024 17.55 > > > > On Mon, 13 May 2024 14:08:07 +0100 > > Ferruh Yigit wrote: > > > > > 2. Double tab indentation vs parenthesis align > > >

RE: [PATCH 2/3] net/af_xdp: Fix mbuf alloc failed statistic

> > On Fri, 10 May 2024 10:03:57 + > Ciara Loftus wrote: > > > diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c > b/drivers/net/af_xdp/rte_eth_af_xdp.c > > index fee0d5d5f3..968bbf6d45 100644 > > --- a/drivers/net/af_xdp/rte_eth_af_xdp.c > > +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c > > @@ -

[PATCH v2 0/4] AF_XDP PMD Bugfixes

Series of fixes for the AF_XDP PMD. Ciara Loftus (4): net/af_xdp: fix port ID not set in Rx mbuf net/af_xdp: fix mbuf alloc failed statistic net/af_xdp: fix stats reset net/af_xdp: remove unused local statistic drivers/net/af_xdp/rte_eth_af_xdp.c | 30 + 1 fil

[PATCH v2 1/4] net/af_xdp: fix port ID not set in Rx mbuf

Record the port id in the af_xdp rx queue structure and use it to set the port id of the mbuf of a received packed. Bugzilla ID: 1428 Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") cc: sta...@dpdk.org Reported-by: Stephen Hemminger Signed-off-by: Ciara Loftus Acked-by: Maryam Tahhan

[PATCH v2 2/4] net/af_xdp: fix mbuf alloc failed statistic

Failures to allocate mbufs in the receive path were not being accounted for in the ethdev statistics. Fix this. Bugzilla ID: 1429 Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") cc: sta...@dpdk.org Reported-by: Stephen Hemminger Signed-off-by: Ciara Loftus --- v2: * Fixed typo in commi

[PATCH v2 3/4] net/af_xdp: fix stats reset

The imissed statistic was not properly reset because it was read directly from the kernel statistics. To fix this, take note of the kernel statistic when the stats are reset and deduct this value from the kernel statistic read during statistics get. Bugzilla ID: 1430 Fixes: f1debd77efaf ("net/af_x

[PATCH v2 4/4] net/af_xdp: remove unused local statistic

The rx_dropped statistic is never incremented so its existence is pointless. Remove it. Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") cc: sta...@dpdk.org Reported-by: Stephen Hemminger Signed-off-by: Ciara Loftus --- drivers/net/af_xdp/rte_eth_af_xdp.c | 2 -- 1 file changed, 2 dele

[PATCH v5] This patch introduces a new flag RTE_VHOST_USER_ASYNC_CONNECT, which in combination with the flag RTE_VHOST_USER_CLIENT makes rte_vhost_driver_start connect asynchronously to the vhost serv

Signed-off-by: Daniil Ushkov --- Rerun checks. lib/vhost/rte_vhost.h | 1 + lib/vhost/socket.c| 28 2 files changed, 17 insertions(+), 12 deletions(-) diff --git a/lib/vhost/rte_vhost.h b/lib/vhost/rte_vhost.h index db92f05344..b0434c4b8d 100644 --- a/lib/vhost/

[PATCH v6] lib/vhost: add flag for async connection in client mode

This patch introduces a new flag RTE_VHOST_USER_ASYNC_CONNECT, which in combination with the flag RTE_VHOST_USER_CLIENT makes rte_vhost_driver_start connect asynchronously to the vhost server. Signed-off-by: Daniil Ushkov --- * Rerun checks. * Fix commit message. lib/vhost/rte_vhost.h | 1 + li

Re: [PATCH 1/2] dts: update mypy static checker

On 13/05/2024 17:02, Juraj Linkeš wrote: def _filter_test_cases( self, test_suite_class: type[TestSuite], test_cases_to_run: Sequence[str] -) -> tuple[list[MethodType], list[MethodType]]: +) -> tuple[list[FunctionType], list[FunctionType]]: Does changing inspect.getmemb

Re: [PATCH 2/2] dts: clean up config types

On 13/05/2024 17:12, Juraj Linkeš wrote: diff --git a/dts/framework/testbed_model/traffic_generator/__init__.py b/dts/framework/testbed_model/traffic_generator/__init__.py @@ -39,8 +39,8 @@ def create_traffic_generator( Returns: A traffic generator capable of capturing received p

[PATCH v2 0/2] dts: update mypy and clean up

v2: - apply fix to error formatting bug in framework/testbed_model/traffic_generator/__init__.py Luca Vizzarro (2): dts: update mypy static checker dts: clean up config types dts/framework/config/__init__.py | 49 ++- dts/framework/logger.py | 4

[PATCH v2 1/2] dts: update mypy static checker

Update the mypy static checker to the latest version and fix all the reported errors. Bugzilla ID: 1433 Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/config/__init__.py | 2 +- dts/framework/logger.py | 4 +- .../interactive_re

[PATCH v2 2/2] dts: clean up config types

Clean up types used with the configuration classes, and use Self from the newly added typing_extensions module. Methods that instantiate their own class should be @classmethod instead of @staticmethod. Bugzilla ID: 1433 Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framewo

[PATCH v3 1/3] dts: rework arguments framework

The existing argument handling in the code relies on basic argparse functionality and a custom argparse action to integrate environment variables. This commit improves the current handling by augmenting argparse. This rework implements the following improvements: - There are duplicate expressions

[PATCH v3 0/3] error and usage improvements

v3: - amended arguments rework so that it retains the original functional style - re-implemetend functionalities in v2 by augmenting argparse classes and functions v2: - complete rework of the arguments handling, to retain the environment variables and gain control over them - prefixing 'Std

[PATCH v3 2/3] dts: constrain DPDK source argument

DTS needs an input to gather the DPDK source code from. This is then built on the remote target. This commit makes sure that this input is more constrained, separating the Git revision ID – used to create a tarball using Git – and providing tarballed source code directly, while retaining mutual exc

[PATCH v3 3/3] dts: store stderr in RemoteCommandExecutionError

Store the stderr of an executed command in RemoteCommandExecutionError. Consequently, when the exception is logged the error message includes the stderr. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/exception.py | 13 ++--- dts/framewor

[PATCH v3] dts: rework arguments framework

The existing argument handling in the code relies on basic argparse functionality and a custom argparse action to integrate environment variables. This commit improves the current handling by augmenting argparse. This rework implements the following improvements: - There are duplicate expressions

[PATCH v4 0/3] error and usage improvements

Hi, please ignore v3 as I sent it by mistake and also forgot to checkpatch. v4: - fix spelling typo v3: - amended arguments rework so that it retains the original functional style - re-implemetend functionalities in v2 by augmenting argparse classes and functions v2: - complete rework of the

[PATCH v4 1/3] dts: update mypy static checker

Update the mypy static checker to the latest version and fix all the reported errors. Bugzilla ID: 1433 Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/config/__init__.py | 2 +- dts/framework/logger.py | 4 +- .../interactive_re

[PATCH v4 2/3] dts: clean up config types

Clean up types used with the configuration classes, and use Self from the newly added typing_extensions module. Methods that instantiate their own class should be @classmethod instead of @staticmethod. Bugzilla ID: 1433 Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framewo

[PATCH v4 3/3] dts: rework arguments framework

The existing argument handling in the code relies on basic argparse functionality and a custom argparse action to integrate environment variables. This commit improves the current handling by augmenting argparse. This rework implements the following improvements: - There are duplicate expressions

[PATCH v5 0/3] error and usage improvements

Hi again, apologies again. Looks like it's not my good day as I sent the wrong patches in the series... v5: - re-sent correct patches v4: - fix spelling typo v3: - amended arguments rework so that it retains the original functional style - re-implemetend functionalities in v2 by augmenting argp

[PATCH v5 1/3] dts: rework arguments framework

The existing argument handling in the code relies on basic argparse functionality and a custom argparse action to integrate environment variables. This commit improves the current handling by augmenting argparse. This rework implements the following improvements: - There are duplicate expressions

[PATCH v5 3/3] dts: store stderr in RemoteCommandExecutionError

Store the stderr of an executed command in RemoteCommandExecutionError. Consequently, when the exception is logged the error message includes the stderr. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/exception.py | 13 ++--- dts/framewor

[PATCH v5 2/3] dts: constrain DPDK source argument

DTS needs an input to gather the DPDK source code from. This is then built on the remote target. This commit makes sure that this input is more constrained, separating the Git revision ID – used to create a tarball using Git – and providing tarballed source code directly, while retaining mutual exc

[PATCH v1 1/1] net/e1000/base: fix link power down

Current code is a result of work to reduce duplication between various device models. However, the logic that was replaced did not exactly match the new logic, and as a result the link power down was not working correctly for some NICs, and the link remained up even when the interface is down. Fix

Re: [PATCH v5 0/3] error and usage improvements

Depends-on: series-31920 ("dts: update mypy and clean up")

Re: [PATCH v2 0/4] AF_XDP PMD Bugfixes

On Tue, 14 May 2024 08:41:51 + Ciara Loftus wrote: > Series of fixes for the AF_XDP PMD. > > Ciara Loftus (4): > net/af_xdp: fix port ID not set in Rx mbuf > net/af_xdp: fix mbuf alloc failed statistic > net/af_xdp: fix stats reset > net/af_xdp: remove unused local statistic > > dr

[PATCH v3 0/7] Generic SW counters

Adds common code for collecting basic statistics used by many SW based PMD's such as af_packet, af_xdp, tap and ring. Solves the problem where counters could tear because of 32 bit load/store on 32 bit platforms. v3 - fix missing const on 32 bit - add some docbook comments - get rid of unus

[PATCH v3 1/7] eal: generic 64 bit counter

This header implements 64 bit counters that are NOT atomic but are safe against load/store splits on 32 bit platforms. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup --- lib/eal/include/meson.build | 1 + lib/eal/include/rte_counter.h | 91 +++ 2 fil

[PATCH v3 2/7] ethdev: add internal helper of SW driver statistics

Introduce common helper routines for keeping track of per-queue statistics in SW PMD's. The code in several drivers had copy/pasted the same code for this, but had common issues with 64 bit counters on 32 bit platforms. Signed-off-by: Stephen Hemminger --- lib/ethdev/ethdev_swstats.c | 106 +

[PATCH v3 3/7] net/af_packet: use SW stats helper

Use the new generic SW stats. Signed-off-by: Stephen Hemminger --- drivers/net/af_packet/rte_eth_af_packet.c | 82 --- 1 file changed, 14 insertions(+), 68 deletions(-) diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c index

[PATCH v3 4/7] net/af_xdp: use generic SW stats

Use common code for all SW stats. Signed-off-by: Stephen Hemminger --- drivers/net/af_xdp/rte_eth_af_xdp.c | 98 - 1 file changed, 25 insertions(+), 73 deletions(-) diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c index 268a130c

[PATCH v3 5/7] net/pcap: use generic SW stats

Use common statistics for SW drivers. Signed-off-by: Stephen Hemminger --- drivers/net/pcap/pcap_ethdev.c | 125 +++-- 1 file changed, 26 insertions(+), 99 deletions(-) diff --git a/drivers/net/pcap/pcap_ethdev.c b/drivers/net/pcap/pcap_ethdev.c index bfec085045..b1a

[PATCH v3 6/7] net/ring: use generic SW stats

Use generic per-queue infrastructure. Signed-off-by: Stephen Hemminger --- drivers/net/ring/rte_eth_ring.c | 71 + 1 file changed, 28 insertions(+), 43 deletions(-) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index 48953dd7a0..8

[PATCH v3 7/7] net/tap: use generic SW stats

Use new common sw statistics. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 88 ++- drivers/net/tap/rte_eth_tap.h | 15 ++ 2 files changed, 18 insertions(+), 85 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/r

Re: [PATCH v5 31/45] baseband/acc: use rte stdatomic API

On Tue, May 14, 2024 at 09:31:18AM +0200, David Marchand wrote: > On Mon, May 13, 2024 at 9:05 PM Morten Brørup > wrote: > > > > Tyler, it looks like the line continuations in > > /drivers/baseband/acc/rte_vrb_pmd.c are indented with four spaces instead > > of double . > > For Tyler defence, i

Updated DTS 24.07 Roadmap

When we sent this out originally we missed some patches Luca Vizzarro has been working on for this release, so here is an updated version. Thanks Luca. 1) Write ethdev testsuites: Jumboframes: https://git.dpdk.org/tools/dts/tree/test_plans/jumboframes_test_plan.rst Mac Filter: https://git.dpdk.

[PATCH v6 00/45] use stdatomic API

This series converts all non-generic built atomics to use the rte_atomic macros that allow optional enablement of standard C11 atomics. Use of generic atomics for non-scalar types are not converted in this change and will be evaluated as a part of a separate series. Specifically conversion of lib/

[PATCH v6 02/45] net/ixgbe: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/ixgbe/ixgbe_ethdev.c | 14 -- drivers/net/ixgbe/ixgbe_ethdev.h | 2 +- drivers/net/ixgbe/ix

[PATCH v6 01/45] net/mlx5: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/mlx5/linux/mlx5_ethdev_os.c | 6 +- drivers/net/mlx5/linux/mlx5_verbs.c | 9 ++- drivers/net/mlx

[PATCH v6 03/45] net/iavf: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/iavf/iavf.h | 16 drivers/net/iavf/iavf_rxtx.c | 4 ++-- driver

[PATCH v6 04/45] net/ice: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/ice/base/ice_osdep.h | 4 ++-- drivers/net/ice/ice_dcf.c| 6 +++--- drivers/net/ice/ice_dcf.h

[PATCH v6 05/45] net/i40e: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/i40e/i40e_ethdev.c| 4 ++-- drivers/net/i40e/i40e_rxtx.c | 6 +++--- drivers/net/i40e/i

[PATCH v6 06/45] net/hns3: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/hns3/hns3_cmd.c | 18 ++-- drivers/net/hns3/hns3_dcb.c | 2 +- drivers/net/hns3/hns

[PATCH v6 07/45] net/bnxt: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/bnxt/bnxt_cpr.h | 4 ++-- drivers/net/bnxt/bnxt_rxq.h | 2 +- drivers/net/bnxt/bnx

[PATCH v6 08/45] net/cpfl: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/cpfl/cpfl_ethdev.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/n

[PATCH v6 10/45] net/octeon_ep: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/octeon_ep/cnxk_ep_rx.h| 5 +++-- drivers/net/octeon_ep/cnxk_ep_tx.c| 5 +++-- drivers/net/octeon

[PATCH v6 09/45] net/af_xdp: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/af_xdp/rte_eth_af_xdp.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) dif

[PATCH v6 11/45] net/octeontx: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/octeontx/octeontx_ethdev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/d

[PATCH v6 12/45] net/cxgbe: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/cxgbe/clip_tbl.c | 12 ++-- drivers/net/cxgbe/clip_tbl.h | 2 +- drivers/net/cxgbe/cxgbe_ma

[PATCH v6 13/45] net/gve: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/gve/base/gve_osdep.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net

[PATCH v6 14/45] net/memif: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/memif/memif.h | 4 ++-- drivers/net/memif/rte_eth_memif.c | 50 +++-

[PATCH v6 15/45] net/thunderx: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/thunderx/nicvf_rxtx.c | 9 + drivers/net/thunderx/nicvf_struct.h | 4 ++-- 2 files changed, 7

[PATCH v6 17/45] net/hinic: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/hinic/hinic_pmd_rx.c | 2 +- drivers/net/hinic/hinic_pmd_rx.h | 2 +- 2 files changed, 2 insertions(+),

[PATCH v6 16/45] net/virtio: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/virtio/virtio_ring.h | 4 +-- drivers/net/virtio/virtio_user/virtio_user_dev.c | 12 +++

[PATCH v6 18/45] net/idpf: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/idpf/idpf_ethdev.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/ne

[PATCH v6 19/45] net/qede: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/qede/base/bcm_osal.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/n

[PATCH v6 21/45] vdpa/mlx5: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/vdpa/mlx5/mlx5_vdpa.c | 24 +- drivers/vdpa/mlx5/mlx5_vdpa.h | 14 +-

[PATCH v6 20/45] net/ring: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/ring/rte_eth_ring.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/

[PATCH v6 22/45] raw/ifpga: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/raw/ifpga/ifpga_rawdev.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/driver

[PATCH v6 23/45] event/opdl: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/event/opdl/opdl_ring.c | 80 +- 1 file changed, 40 insertions(+), 40

[PATCH v6 24/45] event/octeontx: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/event/octeontx/timvf_evdev.h | 8 drivers/event/octeontx/timvf_worker.h | 36 +---

[PATCH v6 25/45] event/dsw: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger Reviewed-by: Mattias Rönnblom --- drivers/event/dsw/dsw_evdev.h | 6 +++--- drivers/event/dsw/dsw_event.c | 47 +

[PATCH v6 26/45] dma/skeleton: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/dma/skeleton/skeleton_dmadev.c | 5 +++-- drivers/dma/skeleton/skeleton_dmadev.h | 2 +- 2 files changed, 4

[PATCH v6 27/45] crypto/octeontx: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/crypto/octeontx/otx_cryptodev_ops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/

[PATCH v6 28/45] common/mlx5: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/common/mlx5/linux/mlx5_nl.c | 5 +-- drivers/common/mlx5/mlx5_common.h | 2 +- drivers/common/ml

[PATCH v6 30/45] common/iavf: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/common/iavf/iavf_impl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/comm

[PATCH v6 29/45] common/idpf: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/common/idpf/idpf_common_device.h | 6 +++--- drivers/common/idpf/idpf_common_rxtx.c| 14 ++

[PATCH v6 31/45] baseband/acc: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/baseband/acc/rte_acc100_pmd.c | 36 +-- drivers/baseband/acc/rte_vrb_pmd.c| 47 +

[PATCH v6 32/45] net/txgbe: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/txgbe/txgbe_ethdev.c| 12 +++- drivers/net/txgbe/txgbe_ethdev.h| 2 +- drivers/net/txgb

[PATCH v6 33/45] net/null: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/null/rte_eth_null.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/dri

[PATCH v6 34/45] event/dlb2: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/event/dlb2/dlb2.c| 34 +- drivers/event/dlb2/dlb2_priv.h | 13

[PATCH v6 35/45] dma/idxd: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/dma/idxd/idxd_internal.h | 2 +- drivers/dma/idxd/idxd_pci.c | 9 + 2 files changed, 6 insertio

[PATCH v6 36/45] crypto/ccp: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/crypto/ccp/ccp_dev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/cry

[PATCH v6 37/45] common/cpt: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/common/cpt/cpt_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/c

[PATCH v6 38/45] bus/vmbus: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/bus/vmbus/rte_vmbus_reg.h | 2 +- drivers/bus/vmbus/vmbus_channel.c | 8 2 files changed, 5 inserti

[PATCH v6 39/45] examples: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- examples/bbdev_app/main.c | 13 + examples/l2fwd-event/l2fwd_common.h

[PATCH v6 40/45] app/dumpcap: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- app/dumpcap/main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/app/dumpcap/main

[PATCH v6 41/45] app/test: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- app/test/test_bpf.c| 46 - app/test/test_distributor.c| 114 +++

[PATCH v6 42/45] app/test-eventdev: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- app/test-eventdev/test_order_atq.c| 4 ++-- app/test-eventdev/test_order_common.c | 5 +++-- app/test-eventdev/t

[PATCH v6 44/45] app/test-compress-perf: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- app/test-compress-perf/comp_perf_test_common.h | 2 +- app/test-compress-perf/comp_perf_test_cyclecount.c | 4

[PATCH v6 43/45] app/test-crypto-perf: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- app/test-crypto-perf/cperf_test_latency.c| 6 +++--- app/test-crypto-perf/cperf_test_pmd_cyclecount.c | 10

[PATCH v6 45/45] app/test-bbdev: use rte stdatomic API

Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- app/test-bbdev/test_bbdev_perf.c | 183 +++ 1 file changed, 110 insertions(+), 7

Re: [PATCH v4] devtools: add .clang-format file

On Tue, May 14, 2024 at 08:56:49AM +0100, Bruce Richardson wrote: > On Mon, May 13, 2024 at 09:11:32PM +0200, Morten Brørup wrote: > > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > > Sent: Monday, 13 May 2024 17.55 > > > > > > On Mon, 13 May 2024 14:08:07 +0100 > > > Ferruh Yig

RE: 23.11.1 patches review and test

> -Original Message- > From: Xueming Li > Sent: Tuesday, May 7, 2024 10:32 AM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Ali Alnubani ; David Christensen > ; Hemant Agrawal ; > Ian Stokes ; Jerin Jacob ; John > McNamara ; Ju-Hyoung Lee > ; Kevin Traynor ; Luca > Boccass

Fw: [dpdk lib issues] |FAILURE| pw(140073) sid(31926) job(PER_PATCH_BUILD11874) [v3,7/7] net/tap: use generic SW stats

CentOS7 is end-of-life, can we please remove it from DTS? Begin forwarded message: Date: 14 May 2024 08:59:19 -0700 From: sys_...@intel.com To: tingtingx.l...@intel.com, step...@networkplumber.org Cc: Subject: [dpdk lib issues] |FAILURE| pw(140073) sid(31926) job(PER_PATCH_BUILD11874) [v3,7/7

[PATCH v1 0/4] Add second scatter test case

From: Jeremy Spewock The current test suite for testing the scatter gather capabilities of a NIC currently does not support Mellanox NICs since these NICs require that you first enable the scattered_rx offload when you start testpmd, but some other PMDs do not. This patch series adds an expansion

[PATCH v1 1/4] dts: improve starting and stopping interactive shells

From: Jeremy Spewock The InteractiveShell class currently relies on being cleaned up and shutdown at the time of garbage collection, but this cleanup of the class does no verification that the session is still running prior to cleanup. So, if a user were to call this method themselves prior to ga

[PATCH v1 2/4] dts: add context manager for interactive shells

From: Jeremy Spewock Interactive shells are managed in a way currently where they are closed and cleaned up at the time of garbage collection. Due to there being no guarantee of when this garbage collection happens in Python, there is no way to consistently know when an application will be closed

[PATCH v1 3/4] dts: add methods for modifying MTU to testpmd shell

From: Jeremy Spewock There are methods within DTS currently that support updating the MTU of ports on a node, but the methods for doing this in a linux session rely on the ip command and the port being bound to the kernel driver. Since test suites are run while bound to the driver for DPDK, there

[PATCH v1 4/4] dts: add test case that utilizes offload to pmd_buffer_scatter

From: Jeremy Spewock Some NICs tested in DPDK allow for the scattering of packets without an offload and others enforce that you enable the scattered_rx offload in testpmd. The current version of the suite for testing support of scattering packets only tests the case where the NIC supports testin

Re: [PATCH v3] lib/hash: setting the maximum reclamation size

> On May 13, 2024, at 11:35 AM, Abdullah Ömer Yamaç > wrote: > > Set the maximum reclamation size to user provided value > > Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation") > Cc: sta...@dpdk.org > Cc: dharmik.thak...@arm.com > Cc: Honnappa Nagarahalli > Cc: Yipeng Wang > C

Reminder - DPDK Tech Board Meeting - Tomorrow Wed. May 15, 2024 - 8am Pacific/11am Eastern/1500h UTC

A copy of the agenda (read-only) can be found here: https://annuel.framapad.org/p/r.0c3cc4d1e011214183872a98f6b5c7db Thanks,

Re: 23.11.1 patches review and test

Hi Ali, Thanks for the verification. Best Regards, Xueming From: Ali Alnubani Sent: Wednesday, May 15, 2024 1:36 AM To: Xueming Li ; sta...@dpdk.org Cc: dev@dpdk.org ; Abhishek Marathe ; David Christensen ; Hemant Agrawal ; Ian Stokes ; Jerin Jacob ; John McN