RE: [PATCH] eal/arm: replace RTE_BUILD_BUG on non-constant

2024-05-11 Thread Wathsala Wathawana Vithanage
> Subject: [PATCH] eal/arm: replace RTE_BUILD_BUG on non-constant > > The ARM implementation of rte_pause uses RTE_BUILD_BUG_ON to check > memorder, which is not constant. This causes compile errors when it is > enabled with RTE_ARM_USE_WFE. eg. Use of wfe based rte_wait_until_equal_ implementati

RE: [PATCH v2] eal/arm: replace RTE_BUILD_BUG on non-constant

2024-05-11 Thread Wathsala Wathawana Vithanage
> ../lib/eal/arm/include/rte_pause_64.h: In function ‘rte_wait_until_equal_16’: > ../lib/eal/include/rte_common.h:530:56: error: expression in static assertion > is not constant > 530 | #define RTE_BUILD_BUG_ON(condition) do { > static_assert(!(condition), #condition); } while (0) > |

[PATCH] bpf: don't verify classic bpfs

2024-05-11 Thread Yoav Winstein
Signed-off-by: Yoav Winstein --- app/test/test_bpf.c | 2 ++ lib/bpf/bpf_convert.c | 1 + lib/bpf/bpf_load.c| 7 +-- lib/bpf/rte_bpf.h | 1 + 4 files changed, 9 insertions(+), 2 deletions(-) diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c index 53e3a31123..7aae290c1a 100644

[PATCH] bpf: don't verify classic bpfs

2024-05-11 Thread Yoav Winstein
I noticed that when classic BPFs with lots of branching instructions are compiled, __rte_bpf_bpf_validate runs way too slow. A simple bpf such as: 'ether host a0:38:6d:af:17:eb or b3:a3:ff:b6:c1:ef or ...' 12 times results in ~1 minute of bpf validation. This patch makes __rte_bpf_bpf_validate b

[PATCH] bpf: don't verify classic bpfs

2024-05-11 Thread Yoav Winstein
When classic BPFs with lots of branching instructions are compiled, __rte_bpf_bpf_validate runs way too slow. A simple bpf such as: 'ether host a0:38:6d:af:17:eb or b3:a3:ff:b6:c1:ef or ...' 12 times results in ~1 minute of bpf validation. This patch makes __rte_bpf_bpf_validate be aware of bpf_pr

[PATCH] bpf: don't verify classic bpfs

2024-05-11 Thread Yoav Winstein
When classic BPFs with lots of branching instructions are compiled, __rte_bpf_bpf_validate runs way too slow. A simple bpf such as: 'ether host a0:38:6d:af:17:eb or b3:a3:ff:b6:c1:ef or ...' 12 times results in ~1 minute of bpf validation. This patch makes __rte_bpf_bpf_validate be aware of bpf_pr