Hi Robin,
I've tested your patch and this is all good for me.
The errors are better handled.
The most common one is when the socket telemetry is closed and you
get:
2024-04-19 15:22:00 ERROR 192.168.122.116 GET /metrics HTTP/1.1: telemetry
socket not available
Traceback (most recent call las
RedHat QE tested below 18 scenarios on RHEL 9.4 and didn't find any new
dpdk issues.
-
- VM with device assignment(PF) throughput testing(1G hugepage size):
PASS
- VM with device assignment(PF) throughput testing(2M hugepage size) :
PASS
- VM with device assignment(VF) throughput
On 4/22/2024 7:38 AM, Chengwen Feng wrote:
> Fix a problem introduced by a compiler upgrade (from gcc10 to gcc12.3),
> which will lead the hns3 NIC can't link up. The root cause is strict
> aliasing violation in rte_eth_linkstatus_set() with hns3 driver, see
> [1] for more details.
>
> This commit
On Apr 19, 2024, at 3:53 PM, Boyer, Andrew wrote:
diff --git a/drivers/crypto/ionic/ionic_crypto_main.c
b/drivers/crypto/ionic/ionic_crypto_main.c
new file mode 100644
index 00..7b26080bd1
--- /dev/null
+++ b/drivers/crypto/ionic/ionic_crypto_main.c
@@ -0,0 +1,42 @@
+/* SPDX-License-Ide
Hello,
Good day~
I hope this message finds you well. I am writing to submit a patch for
consideration, which primarily adds enhanced error handling for affinity sets
within the eal/linux of DPDK. Unfortunately, my current environment does not
support git send-email, so I am sending this patch a
From: Jianyue Wu
Improve the robustness of setting thread affinity in DPDK
by adding detailed error logging.
Changes:
1. Set `errno` to 0 before calling `pthread_setaffinity_np()` to ensure
clean error status.
2. Check the return value of `pthread_setaffinity_np()` and log an error
if the call f
On 4/22/2024 2:23 PM, Jianyue Wu (NSB) wrote:
> Hello,
>
>
>
> Good day~
>
> I hope this message finds you well. I am writing to submit a patch for
> consideration, which primarily adds enhanced error handling for affinity
> sets within the eal/linux of DPDK. Unfortunately, my current environm
Introduce a new compress PMD for hardware accelerators based on UADK [1].
UADK is a framework for user applications to access hardware accelerators.
UADK relies on IOMMU SVA (Shared Virtual Address) feature, which share
the same page table between IOMMU and MMU.
Thereby user application can direct
Introduce a new compression & decompression PMD for hardware accelerators
based on UADK [1].
UADK is a framework for user applications to access hardware accelerators.
UADK relies on IOMMU SVA (Shared Virtual Address) feature, which shares
the same page table between IOMMU and MMU.
Thereby user ap
Support the basic dev control operations: configure, close,
start, stop, infos_get, and queue pairs operations, etc.
Signed-off-by: Zhangfei Gao
---
drivers/compress/uadk/uadk_compress_pmd.c | 325 +-
.../compress/uadk/uadk_compress_pmd_private.h | 16 +
2 files changed, 330
This commit adds the burst enqueue and dequeue operations.
Signed-off-by: Zhangfei Gao
---
drivers/compress/uadk/uadk_compress_pmd.c | 88 ++-
1 file changed, 86 insertions(+), 2 deletions(-)
diff --git a/drivers/compress/uadk/uadk_compress_pmd.c
b/drivers/compress/uadk/uad
On 19/04/2024 11:13, Ferruh Yigit wrote:
On 4/8/2024 2:09 PM, Maryam Tahhan wrote:
diff --git a/doc/guides/howto/af_xdp_cni.rst b/doc/guides/howto/af_xdp_cni.rst
deleted file mode 100644
index a1a6d5b99c..00
--- a/doc/guides/howto/af_xdp_cni.rst
+++ /dev/null
@@ -1,253 +0,0 @@
-.. SPDX-L
On 4/12/2024 1:52 PM, Venkat Kumar Ande wrote:
> The comm_owned field can hide logic where double locking is attempted
> and prevent multiple threads for the same device from accessing the
> mutex properly. Remove the comm_owned field and use the mutex API
> exclusively for gaining ownership.
>
>
On Sat, 20 Apr 2024 09:48:24 +0200
Morten Brørup wrote:
> > From: Stephen Hemminger [mailto:step...@networkplumber.org]
> > Sent: Saturday, 20 April 2024 02.08
> >
> > The macro RTE_LOG_REGISTER_DEFAULT emits code for an initialization
> > function. If a driver (and most do) adds a semicolon aft
On 4/12/2024 1:52 PM, Venkat Kumar Ande wrote:
> The XGBE hardware has support for performing MDIO operations using an
> MDIO command request. The driver mistakenly uses the mdio port address
> as the MDIO command request device address instead of the MDIO command
> request port address. Additional
Latencystats uses variable length array and floating point when they
are not necessary to acheive the same result. While testing also noticed
that the code was computing wrong values on my test system, and that
include files were missing.
v5 - use scaled values for latency and jitter
- add more
The temporary array latencystats is not needed if the algorithm
is converted into one pass.
Signed-off-by: Stephen Hemminger
Acked-by: Morten Brørup
Acked-by: Tyler Retzlaff
---
lib/latencystats/rte_latencystats.c | 31 +++--
1 file changed, 16 insertions(+), 15 deletio
The TSC frequency is not always an integral number of nanoseconds.
For examples, cycles per nanoseconds on my test system is 2.8.
Fix by using floating point where needed and calculate value once.
Signed-off-by: Stephen Hemminger
---
lib/latencystats/rte_latencystats.c | 17 ++---
1
The cycle counts do not need to be stored as floating point.
Instead keep track of latency in cycles, and convert to
nanoseconds when read.
Use scaled math with exponential Weighted Moving Average weight
of .25 to avoid use of floating point for that.
The average latency took too long to "warm up
All messages that because of an error should be at log level
NOTICE or above. Do not break log messages across lines.
Reword message for the case where getting info about a port
fails and it is skipped.
Signed-off-by: Stephen Hemminger
Acked-by: Tyler Retzlaff
---
lib/latencystats/rte_latencyst
ISO C does not allow casting function pointer to void *.
Resolve by enforcing the reserved argument.
The user_cb argument for rte_latencystats_init() was not
implemented, and had to be NULL anyway.
The log type is local to this function and therefore
can be local to this file.
Signed-off-by: Step
Include what is used here.
Signed-off-by: Stephen Hemminger
---
lib/latencystats/rte_latencystats.c | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/lib/latencystats/rte_latencystats.c
b/lib/latencystats/rte_latencystats.c
index c0ac60134f..bd8fde2f0c 100
Keeping track of the number of samples is useful when doing
debug and testing to make sure that samples are actually happening.
Signed-off-by: Stephen Hemminger
---
lib/latencystats/rte_latencystats.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/lib/l
Look at the number of samples, min, max and average
numbers to make sure they look correct.
Forward for to make sure multiple samples are taken.
Signed-off-by: Stephen Hemminger
---
app/test/test_latencystats.c | 62 +---
1 file changed, 50 insertions(+), 12 delet
No need for loop and memset() here. Just use structure
initialization. Remove unnecessary initializations.
Signed-off-by: Stephen Hemminger
---
app/test/test_latencystats.c | 22 +++---
1 file changed, 7 insertions(+), 15 deletions(-)
diff --git a/app/test/test_latencystats.c b
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Monday, 22 April 2024 17.14
>
> On Sat, 20 Apr 2024 09:48:24 +0200
> Morten Brørup wrote:
>
> > > From: Stephen Hemminger [mailto:step...@networkplumber.org]
> > > Sent: Saturday, 20 April 2024 02.08
> > >
> > > The macro RTE_
On Mon, 22 Apr 2024 13:23:50 +
"Jianyue Wu (NSB)" wrote:
> +/* Function to convert cpu_set_t to a string. */
> +static void cpuset_to_string(const cpu_set_t *cpuset,
> + char *cpus_str, size_t cpus_str_size) {
> + int cpu;
> + // Track the current position in the s
On Mon, 22 Apr 2024 13:23:50 +
"Jianyue Wu (NSB)" wrote:
> + char cpus_str[RTE_MAX_LCORE + 1] = {'\0'};
> + char thread_name[RTE_MAX_THREAD_NAME_LEN] = {'\0'};
> +
You don't need '\0' here, just doing { } will have same effect.
On Mon, 22 Apr 2024 13:23:50 +
"Jianyue Wu (NSB)" wrote:
> + EAL_LOG(ERR, "Cannot set affinity for thread %s with cpus %s, "
> + "ret: %d, errno: %d, error description: %s",
> + thread_name, cpus_str,
> + ret, errno, stre
This series targeting 24.07 removes unused/dead code, memory barrier
improvements, cosmetic log changes.
Hernan Vargas (5):
baseband/acc: remove ACC100 unused code
baseband/acc: remove ACC100 HARQ pruning
baseband/acc: move memory barrier
baseband/acc: improve error description
baseband
Remove dead code and unused function in ACC100 driver.
Signed-off-by: Hernan Vargas
---
drivers/baseband/acc/rte_acc100_pmd.c | 213 --
1 file changed, 68 insertions(+), 145 deletions(-)
diff --git a/drivers/baseband/acc/rte_acc100_pmd.c
b/drivers/baseband/acc/rte_acc10
Moving memory barrier so that dequeue thread can be in sync with enqueue
thread.
Signed-off-by: Hernan Vargas
---
drivers/baseband/acc/acc_common.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/baseband/acc/acc_common.h
b/drivers/baseband/acc/acc_common.h
inde
Remove dead code for error and update description of one error print.
Signed-off-by: Hernan Vargas
---
drivers/baseband/acc/rte_acc100_pmd.c | 19 +--
1 file changed, 1 insertion(+), 18 deletions(-)
diff --git a/drivers/baseband/acc/rte_acc100_pmd.c
b/drivers/baseband/acc/rte_a
HARQ pruning is not an ACC100 feature. Removing in effect dead code.
Signed-off-by: Hernan Vargas
---
drivers/baseband/acc/rte_acc100_pmd.c | 33 +--
1 file changed, 6 insertions(+), 27 deletions(-)
diff --git a/drivers/baseband/acc/rte_acc100_pmd.c
b/drivers/baseband/a
Minor cosmetic log change.
No functional impact.
Signed-off-by: Hernan Vargas
---
drivers/baseband/acc/rte_acc100_pmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/baseband/acc/rte_acc100_pmd.c
b/drivers/baseband/acc/rte_acc100_pmd.c
index 8ec521675f34..c0305e1e6
On 4/22/2024 3:53 PM, Maryam Tahhan wrote:
> On 19/04/2024 11:13, Ferruh Yigit wrote:
>> On 4/8/2024 2:09 PM, Maryam Tahhan wrote:
>>> diff --git a/doc/guides/howto/af_xdp_cni.rst
>>> b/doc/guides/howto/af_xdp_cni.rst
>>> deleted file mode 100644
>>> index a1a6d5b99c..00
>>> --- a/doc/guide
On Mon, 22 Apr 2024 17:24:43 +0200
Morten Brørup wrote:
> #define RTE_LOG_REGISTER_IMPL(type, name, level)\
> - int type; \
> + extern int type;
>
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Monday, 22 April 2024 18.20
>
> On Mon, 22 Apr 2024 17:24:43 +0200
> Morten Brørup wrote:
>
> > #define RTE_LOG_REGISTER_IMPL(type, name, level) \
> > - int type;
Basically it will just provide incorrect information. With the enum being
misaligned due to missing command, GET_DCR0_REG and GET_MAX_CAPABILITIES
will just lead to incorrect commands being issued.
Thanks,
Ronak
On Fri, Apr 19, 2024 at 1:35 AM Ferruh Yigit wrote:
> On 4/18/2024 7:36 AM, Ronak
Vmxnet3 uses capability registers to advertise the supported
capabilities of UPT device. It uses DCR0_REG command register
for this purpose. However, the register command enum misses
one command which technically is not used by dpdk vmxnet3
driver yet. This can cause issue for commands added later.
Recent patch set for rte_memcpy, discovered that the some
mail addresses could not be found.
Signed-off-by: Stephen Hemminger
Acked-by: Bruce Richardson
---
v3 - remove lijan...@intel.com as well (suggested by Bruce)
MAINTAINERS| 5 -
dts/pyproject.toml | 1 -
2 files changed, 6 de
On Mon, Apr 22, 2024 at 11:39:07AM -0700, Stephen Hemminger wrote:
> Recent patch set for rte_memcpy, discovered that the some
> mail addresses could not be found.
>
> Signed-off-by: Stephen Hemminger
> Acked-by: Bruce Richardson
> ---
Acked-by: Tyler Retzlaff
This series targets test-bbdev changes for 24.07.
It includes test fixes, iter-max argument change (after deprecation notice in
previous releases) and general test improvements.
Hernan Vargas (9):
test/bbdev: fix TB logic
test/bbdev: fix MLD output size computation
test/bbdev: fix interrupt
Fix discrepancy in logic when using large fake mbuf.
Fixes: fd96ef3787f1 ("test/bbdev: extend support for large TB")
Cc: sta...@dpdk.org
Signed-off-by: Hernan Vargas
---
app/test-bbdev/test_bbdev_perf.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/app/test-bbdev/test_bb
For perf tests, the operation size for the MLD-TS was incorrect.
Fixed so that the performance numbers are correct.
Largely cosmetic only.
Fixes: 95f192a40e35 ("test/bbdev: add MLD cases")
Cc: sta...@dpdk.org
Signed-off-by: Hernan Vargas
---
app/test-bbdev/test_bbdev_perf.c | 10 --
1 f
Fix possible error with regards to setting the burst size from the
enqueue thread.
Fixes: b2e2aec3239e ("app/bbdev: enhance interrupt test")
Cc: sta...@dpdk.org
Signed-off-by: Hernan Vargas
---
app/test-bbdev/test_bbdev_perf.c | 98
1 file changed, 49 insertions
-t --iter-max used for max number of iterations.
-T --timeout used for test timeout value.
Signed-off-by: Hernan Vargas
---
app/test-bbdev/test-bbdev.py | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/app/test-bbdev/test-bbdev.py b/app/test-bbdev/test-bbdev.
Print more info and format message for test timeouts.
No functional impact.
Signed-off-by: Hernan Vargas
---
app/test-bbdev/test-bbdev.py | 22 ++
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git a/app/test-bbdev/test-bbdev.py b/app/test-bbdev/test-bbdev.py
index
Add vector parsing capability for soft output vectors.
Signed-off-by: Hernan Vargas
---
app/test-bbdev/test_bbdev_vector.c | 4
1 file changed, 4 insertions(+)
diff --git a/app/test-bbdev/test_bbdev_vector.c
b/app/test-bbdev/test_bbdev_vector.c
index 42fa630041e9..b3e9d4bb7504 100644
---
Add check for FFT window width.
Signed-off-by: Hernan Vargas
---
app/test-bbdev/test_bbdev_perf.c | 26 ++
app/test-bbdev/test_bbdev_vector.c | 14 ++
app/test-bbdev/test_bbdev_vector.h | 2 ++
3 files changed, 38 insertions(+), 4 deletions(-)
diff --git a
Update check for FFT measurement output to better account for tolerance.
Signed-off-by: Hernan Vargas
---
app/test-bbdev/test_bbdev_perf.c | 52 +++-
1 file changed, 51 insertions(+), 1 deletion(-)
diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_b
Remove unnecesary line of code.
No functional impact.
Signed-off-by: Hernan Vargas
---
app/test-bbdev/test_bbdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/app/test-bbdev/test_bbdev.c b/app/test-bbdev/test_bbdev.c
index cf224dca5d04..0bbce6ca923b 100644
--- a/app/test-bbdev/test_bbdev.
Hello,
Please disregard this email; I will use a different mailbox instead.
Thank you~
Best regards,
Dave
From: Jianyue Wu (NSB)
Sent: 2024年4月22日 21:24
To: 'roret...@linux.microsoft.com' ;
'tho...@monjalon.net' ; 'david.march...@redhat.com'
Cc: 'dev@dpdk.org'
Subject: [PATCH] eal/linux: enha
Hi, are you using the latest LTS?
If so, all bug fixes were ported there by the stable branch maintainer.
I will ask the aws team to check this and update.
Can you please share your instance id and timeframe when the rx missed were
observed, so we can look into our logs?
All the Best!
Shai
בתארי
54 matches
Mail list logo
