RE: [PATCH 1/2] net/txgbe: add vectorized functions for Rx/Tx

2024-04-07 Thread Jiawen Wu
> >>> @@ -2198,8 +2220,15 @@ txgbe_set_tx_function(struct rte_eth_dev *dev, > >>> struct txgbe_tx_queue *txq) > >>> #endif > >>> txq->tx_free_thresh >= RTE_PMD_TXGBE_TX_MAX_BURST) { > >>> PMD_INIT_LOG(DEBUG, "Using simple tx code path"); > >>> - dev->tx_pkt_bur

Re: [PATCH 0/4] RFC samples converting VLA to alloca

2024-04-07 Thread Mattias Rönnblom
On 2024-04-04 19:15, Tyler Retzlaff wrote: This series is not intended for merge. It insteat provides examples of converting use of VLAs to alloca() would look like. what's the advantages of VLA over alloca()? * sizeof(array) works as expected. * multi-dimensional arrays are still arrays inst

Re: [PATCH 1/4] latencystats: use alloca instead of vla trivial

2024-04-07 Thread Mattias Rönnblom
On 2024-04-06 17:28, Morten Brørup wrote: From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] Sent: Thursday, 4 April 2024 19.15 RFC sample illustrating simple conversion of VLA to alloca(). Signed-off-by: Tyler Retzlaff --- [...] --- a/lib/latencystats/rte_latencystats.c +++ b/lib/

RE: [PATCH 0/4] RFC samples converting VLA to alloca

2024-04-07 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Sunday, 7 April 2024 11.32 > > On 2024-04-04 19:15, Tyler Retzlaff wrote: > > This series is not intended for merge. It insteat provides examples > of > > converting use of VLAs to alloca() would look like. > > > > what's the advanta

[PATCH 0/1] net/ena/base: bug fix for 23.11 stable only

2024-04-07 Thread shaibran
From: Shai Brandes Hi, the fix is for a bug that was introduced in 23.11. The fix was already merged into 24.03 indirectly as part of c8a1898f82f8 ("net/ena: improve style and readability") and the entire function was later restructured in patch bcb1753156ac ("net/ena/base: modify customer met

[PATCH 1/1] net/ena/base: fix metrics excessive memory consumption

2024-04-07 Thread shaibran
From: Shai Brandes [ upstream commit c8a1898f82f8c04cbe1d3e2d0eec0705386c23f7 ] The driver accidentally allocates a huge memory buffer for the customer metrics because it uses an uninitialized variable for the buffer length. This can lead to excessive memory footprint for the driver which can ev

Re: [PATCH 1/4] latencystats: use alloca instead of vla trivial

2024-04-07 Thread Stephen Hemminger
On Sun, 7 Apr 2024 11:36:59 +0200 Mattias Rönnblom wrote: > On 2024-04-06 17:28, Morten Brørup wrote: > >> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > >> Sent: Thursday, 4 April 2024 19.15 > >> > >> RFC sample illustrating simple conversion of VLA to alloca(). > >> > >> Signed-of

Re: [PATCH 0/4] RFC samples converting VLA to alloca

2024-04-07 Thread Stephen Hemminger
On Sun, 7 Apr 2024 13:07:06 +0200 Morten Brørup wrote: > > From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > > Sent: Sunday, 7 April 2024 11.32 > > > > On 2024-04-04 19:15, Tyler Retzlaff wrote: > > > This series is not intended for merge. It insteat provides examples > > of > > > c

Re: [PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-04-07 Thread Stephen Hemminger
On Sat, 6 Apr 2024 19:30:38 -0600 Ashish Sadanandan wrote: > On Wed, Apr 3, 2024 at 8:52 AM Thomas Monjalon wrote: > > > 02/04/2024 18:03, Ashish Sadanandan: > > > Hi everyone, > > > I've made the updates as suggested. Could someone please review the > > latest > > > patchset? Not sure if

Re: 22.11.5 patches review and test

2024-04-07 Thread YangHang Liu
RedHat QE tested below 18 scenarios on RHEL9.4 and didn't find any new dpdk issues. - Guest with device assignment(PF) throughput testing(1G hugepage size): PASS - Guest with device assignment(PF) throughput testing(2M hugepage size) : PASS - Guest with device assignment(VF) through

Re: Error in rte_eal_init() when multiple PODs over single node of K8 cluster

2024-04-07 Thread Avijit Pandey
Hello Bruce, Thank a lot for your constant support in resolving this query. Best Regards, Avijit Pandey Cloud SME | VoerEirAB +919598570190 From: Bruce Richardson Date: Tuesday, 2 April 2024 at 14:43 To: Avijit Pandey Cc: dev@dpdk.org Subject: Re: Error in rte_eal_init() when multiple PODs

Re: [PATCH] app/testpmd: handle IEEE1588 init fail

2024-04-07 Thread huangdengdui
On 2024/4/6 0:44, Stephen Hemminger wrote: > On Sat, 30 Mar 2024 15:44:09 +0800 > Dengdui Huang wrote: > >> When the port's timestamping function failed to initialize >> (for example, the device does not support PTP), the packets >> received by the hardware do not contain the timestamp. >> In

[PATCH] net/mlx5/hws: add fragment packet ID matching support

2024-04-07 Thread Michael Baum
Add HWS support of IPv4 fragment packet id field matching. Signed-off-by: Michael Baum Reviewed-by: Alex Vesker Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_definer.c | 11 ++- drivers/net/mlx5/hws/mlx5dr_definer.h | 2 ++ 2 files changed, 12 insertions(+), 1 deletion(-) dif

[PATCH] compress/mlx5: add VF device ID

2024-04-07 Thread Michael Baum
This adds the Virtual Function device ID to the list of supported NVIDIA devices that run the MLX5 compress PMD. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/compress/mlx5/mlx5_compress.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/compress/mlx5/mlx5_compres