Re: [PATCH] app/testpmd: fix auto completion for indirect list action

2024-03-23 Thread Gregory Etelson
Hello Ferruh, > But I guess it won't catch this issue, as it uses full flow commands. > This issue is related to the testpmd command parsing code. I wonder if > we can find a way to verify testpmd parsing code? What if flow command validation program breaks a tested command into tokens and then

Re: meson option to customize RTE_PKTMBUF_HEADROOM patch

2024-03-23 Thread Garrett D'Amore
So we right now (at WEKA) have a somewhat older version of DPDK that we have customized heavily, and I am going to to need to to make the headroom *dynamic* (passed in at run time, and per port.) We have this requirement because we need payload to be at a specific offset, but have to deal with

[PATCH v11 0/9] Logging unification and enhancements

2024-03-23 Thread Stephen Hemminger
Improvements and unification of logging library (for 24.07 release). This version works on all platforms: Linux, Windows and FreeBSD. This is update to rework patch set. It adds several new features to the console log output. * Putting a timestamp on console output which is useful for analy

[PATCH v11 1/9] windows: make getopt functions have const properties

2024-03-23 Thread Stephen Hemminger
Having different prototypes on different platforms can lead to lots of unnecessary workarounds. Looks like the version of getopt used from windows was based on an older out of date version from FreeBSD. This patch changes getopt, getopt_long, etc to have the same const attributes as Linux and Fre

[PATCH v11 2/9] eal: make eal_log_level_parse common

2024-03-23 Thread Stephen Hemminger
The code to parse for log-level option should be same on all OS variants. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_options.c | 46 + lib/eal/common/eal_options.h| 1 + lib/eal/freebsd/eal.c | 42 --

[PATCH v11 3/9] eal: do not duplicate rte_init_alert() messages

2024-03-23 Thread Stephen Hemminger
The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger --- lib/eal/freebsd/eal.c | 3 +-- lib/eal/linux/eal.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --g

[PATCH v11 4/9] eal: change rte_exit() output to match rte_log()

2024-03-23 Thread Stephen Hemminger
The rte_exit() output format confuses the timestamp and coloring options. Change it to use be a single line with proper prefix. Before: [ 0.006481] EAL: Error - exiting with code: 1 Cause: [ 0.006489] Cannot init EAL: Permission denied After: [ 0.006238] EAL: Error - exiting with co

[PATCH v11 5/9] log: drop syslog support, and make code common

2024-03-23 Thread Stephen Hemminger
This patch removes syslog support from logging. Which allows the logging code to all be common across Linux, Windows and FreeBSD. It also initializes log subsystem much earlier in the init process so that all messages get processed. It drops syslog was only used on Linux. Modern Linux systems have

[PATCH v11 6/9] log: add hook for printing log messages

2024-03-23 Thread Stephen Hemminger
This is useful for when decorating log output for console or journal. Provide basic version in this patch. No functional changes in this patch, just infrastructure addition. Signed-off-by: Stephen Hemminger --- lib/log/log.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions

[PATCH v11 7/9] log: add timestamp option

2024-03-23 Thread Stephen Hemminger
When debugging driver or startup issues, it is useful to have a timestamp on each message printed. The messages in syslog already have a timestamp, but often syslog is not available during testing. There are multiple timestamp formats similar to Linux dmesg. The default is time relative since star

[PATCH v11 8/9] log: add support for systemd journal

2024-03-23 Thread Stephen Hemminger
If DPDK application is being run as a systemd service, then it can use the journal protocol which allows putting more information in the log such as priority and other information. The use of journal protocol is automatically detected and handled. Rather than having a dependency on libsystemd, ju

[PATCH v11 9/9] log: colorize log output

2024-03-23 Thread Stephen Hemminger
Like dmesg, colorize the log output (unless redirected to file). Timestamp is green, the subsystem is in yellow and the message is red if urgent, boldface if an error, and normal for info and debug messages. Signed-off-by: Stephen Hemminger --- doc/guides/prog_guide/log_lib.rst | 14 ++- lib/