Hello,
Is there any other comment on this?
On Wed, Mar 6, 2024 at 1:13 PM Abdullah Ömer Yamaç
wrote:
> This patch adds a new feature to the hash library to allow the user to
> reclaim the defer queue. This is useful when the user wants to force
> reclaim resources that are not being used. This A
This patch series fix some coverity issues, includes:
- 414936
- 414937
- 414938
- 414939
- 414941
- 414942
- 415042
- 415051
Chaoyong He (6):
net/nfp: fix return value check
net/nfp: fix string overflow
net/nfp: fix unreachable control flow
net/nfp: fix check return value
net/nfp: fix u
CI found calling 'rte_eth_switch_domain_free()' without checking return
value.
Coverity issue: 414936
Fixes: 20eaa8e2ebae ("net/nfp: free switch domain ID on close")
Cc: long...@corigine.com
Cc: sta...@dpdk.org
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
Reviewed-by: Peng Zhang
---
driver
CI found in the logic of 'nfp_sync_pci_inner_handle_alloc()', use
'strcpy()' may cause string overflow, fix it by use 'rte_strlcpy()'.
Coverity issue: 414937
Fixes: 6b4273a03779 ("net/nfp: add synchronization module")
Cc: long...@corigine.com
Cc: sta...@dpdk.org
Signed-off-by: Chaoyong He
Review
CI found there has unreachable control flow, fix it by remove the
missing delete 'return' statement.
Coverity issue: 414938
Fixes: 369945667251 ("net/nfp: fix resource leak for device initialization")
Cc: sta...@dpdk.org
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
Reviewed-by: Peng Zhang
-
CI found in 'nfp_service_disable()', not check the return value of API
'rte_service_map_lcore_set()'.
Coverity issue: 414939
Fixes: 600f6d2c7704 ("net/nfp: add service module")
Cc: long...@corigine.com
Cc: sta...@dpdk.org
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
Reviewed-by: Peng Zhang
CI found the loop flow in 'nfp_net_flow_calculate_items()' will never
execute more than once.
Coverity issue: 414941
Fixes: c91c6512d876 ("net/nfp: support Ethernet flow item")
Cc: sta...@dpdk.org
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
Reviewed-by: Peng Zhang
---
drivers/net/nfp/nfp_
CI found there are null pointer dereference in 'nfp_flow_merge_l4()'.
Coverity issue: 414942
Fixes: 94438b093702 ("net/nfp: support TCP/UDP/SCTP flow items")
Cc: sta...@dpdk.org
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
Reviewed-by: Peng Zhang
---
drivers/net/nfp/nfp_net_flow.c | 5
From: Peng Zhang
CI found in the logic of 'nfp_elf_read_first_symtab()' has
dereference after null check problem.
Coverity issue: 415042
Fixes: c82ca09c441c ("net/nfp: add ELF module")
Cc: sta...@dpdk.org
Signed-off-by: Peng Zhang
Reviewed-by: Chaoyong He
---
drivers/net/nfp/nfpcore/nfp_elf.
From: Peng Zhang
Passing tainted expression 'ectx->fw_info_strtab_sz' to
'nfp_elf_fwinfo_lookup()', which uses it as a loop boundary.
Replace tainted expression with a temp variable to avoid
the tainted scalar coverity warning.
Coverity issue: 415051
Fixes: c82ca09c441c ("net/nfp: add ELF modul
This patch series fix some coverity issues, includes:
- 414936
- 414937
- 414938
- 414939
- 414941
- 414942
- 415042
- 415051
---
v2:
* Fix one imported uninitialized pointer problem.
---
Chaoyong He (6):
net/nfp: fix return value check
net/nfp: fix string overflow
net/nfp: fix unreachable
CI found calling 'rte_eth_switch_domain_free()' without checking return
value.
Coverity issue: 414936
Fixes: 20eaa8e2ebae ("net/nfp: free switch domain ID on close")
Cc: long...@corigine.com
Cc: sta...@dpdk.org
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
Reviewed-by: Peng Zhang
---
driver
CI found in the logic of 'nfp_sync_pci_inner_handle_alloc()', use
'strcpy()' may cause string overflow, fix it by use 'rte_strlcpy()'.
Coverity issue: 414937
Fixes: 6b4273a03779 ("net/nfp: add synchronization module")
Cc: long...@corigine.com
Cc: sta...@dpdk.org
Signed-off-by: Chaoyong He
Review
CI found there has unreachable control flow, fix it by remove the
missing delete 'return' statement.
Coverity issue: 414938
Fixes: 369945667251 ("net/nfp: fix resource leak for device initialization")
Cc: sta...@dpdk.org
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
Reviewed-by: Peng Zhang
-
CI found in 'nfp_service_disable()', not check the return value of API
'rte_service_map_lcore_set()'.
Coverity issue: 414939
Fixes: 600f6d2c7704 ("net/nfp: add service module")
Cc: long...@corigine.com
Cc: sta...@dpdk.org
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
Reviewed-by: Peng Zhang
CI found the loop flow in 'nfp_net_flow_calculate_items()' will never
execute more than once.
Coverity issue: 414941
Fixes: c91c6512d876 ("net/nfp: support Ethernet flow item")
Cc: sta...@dpdk.org
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
Reviewed-by: Peng Zhang
---
drivers/net/nfp/nfp_
CI found there are null pointer dereference in 'nfp_flow_merge_l4()'.
Coverity issue: 414942
Fixes: 94438b093702 ("net/nfp: support TCP/UDP/SCTP flow items")
Cc: sta...@dpdk.org
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
Reviewed-by: Peng Zhang
---
drivers/net/nfp/nfp_net_flow.c | 5
From: Peng Zhang
CI found in the logic of 'nfp_elf_read_first_symtab()' has
dereference after null check problem.
Coverity issue: 415042
Fixes: c82ca09c441c ("net/nfp: add ELF module")
Cc: sta...@dpdk.org
Signed-off-by: Peng Zhang
Reviewed-by: Chaoyong He
---
drivers/net/nfp/nfpcore/nfp_elf.
From: Peng Zhang
Passing tainted expression 'ectx->fw_info_strtab_sz' to
'nfp_elf_fwinfo_lookup()', which uses it as a loop boundary.
Replace tainted expression with a temp variable to avoid
the tainted scalar coverity warning.
Coverity issue: 415051
Fixes: c82ca09c441c ("net/nfp: add ELF modul
Add the following features
1. Multi segmented packet for TLS
2. Padding verification for TLS
3. SHA384 & ChaChaPoly for TLS
Aakash Sasidharan (1):
crypto/cnxk: add support for oop processing in TLS
Anoob Joseph (1):
crypto/cnxk: avoid branches in datapath
Vidya Sagar Velumuri (10):
crypto/
Add support for Scatter-Gather mode for block ciphers in TLS-1.2
Signed-off-by: Vidya Sagar Velumuri
---
drivers/crypto/cnxk/cn10k_cryptodev_sec.h | 3 +-
drivers/crypto/cnxk/cn10k_tls.c | 5 +++
drivers/crypto/cnxk/cn10k_tls_ops.h | 48 ++-
3 files changed,
Enable SHA384-HMAC support for TLS & DTLS 1.2.
Signed-off-by: Vidya Sagar Velumuri
---
drivers/crypto/cnxk/cn10k_tls.c | 16 +++---
drivers/crypto/cnxk/cnxk_cryptodev.h | 4 ++--
.../crypto/cnxk/cnxk_cryptodev_capabilities.c | 21 +++
3 files chang
Add session update support for TLS
Signed-off-by: Vidya Sagar Velumuri
---
drivers/crypto/cnxk/cn10k_cryptodev_sec.c | 3 +++
drivers/crypto/cnxk/cn10k_tls.c | 17 +
drivers/crypto/cnxk/cn10k_tls.h | 4
3 files changed, 24 insertions(+)
diff --git a/dr
From: Anoob Joseph
Avoid branches in datapath.
Signed-off-by: Anoob Joseph
---
drivers/crypto/cnxk/cn10k_ipsec_la_ops.h | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/crypto/cnxk/cn10k_ipsec_la_ops.h
b/drivers/crypto/cnxk/cn10k_ipsec_la_ops.h
index a30b8e4
In security session, move PMD metadata to second cacheline. Also
optimize the fields to minimize the memory usage.
Signed-off-by: Anoob Joseph
---
drivers/crypto/cnxk/cn10k_cryptodev_sec.h | 10 ++
drivers/crypto/cnxk/cn10k_ipsec.c | 4 ++--
drivers/crypto/cnxk/cn10k_tls.c
Microcode reports one extra byte in response len specifically for
AES-GCM in TLS-1.3. Handle the extra byte in PMD by decreasing
the length by 1 byte.
Signed-off-by: Vidya Sagar Velumuri
---
drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 9 ++---
drivers/crypto/cnxk/cn10k_cryptodev_sec.h | 3 ++
For TLS-1.2:
- Verify that the padding bytes are having pad len as the
value.
- Report error in case of discrepancies.
- Trim the padding and MAC from the tls-1.2 records
For TLS-1.3:
- Find the content type as the last non-zero byte in the record.
- Return the content type as the inner content
From: Aakash Sasidharan
Add support for out-of-place processing in TLS.
Signed-off-by: Aakash Sasidharan
---
drivers/crypto/cnxk/cn10k_tls_ops.h | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/cnxk/cn10k_tls_ops.h
b/drivers/crypto/cnxk/cn10k_tls_o
Keep the record context for TLS-1.3 in sync with microcode
structure.
Report error if optional padding is enabled for AEAD
case in both TLS-1.2 and DTLS-1.2.
Signed-off-by: Vidya Sagar Velumuri
---
drivers/common/cnxk/roc_ie_ot_tls.h | 17 -
drivers/crypto/cnxk/cn10k_tls.c |
Use the proper offset for calculating the context size in case of TLS-1.3.
Signed-off-by: Vidya Sagar Velumuri
---
drivers/crypto/cnxk/cn10k_tls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/cnxk/cn10k_tls.c b/drivers/crypto/cnxk/cn10k_tls.c
index fbf45c464
Enable CHACHA20-POLY1305 support for TLS-1.3.
Signed-off-by: Vidya Sagar Velumuri
---
drivers/common/cnxk/roc_ie_ot_tls.h | 1 +
drivers/crypto/cnxk/cn10k_tls.c | 40 ---
drivers/crypto/cnxk/cnxk_cryptodev.h | 4 +-
.../crypto/cnxk/cnxk_cryptode
Microcode is updating the rlen properly for TLS-1.3
Remove the rlen handling for the same in PMD.
Signed-off-by: Vidya Sagar Velumuri
---
drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/crypto/cnxk/cn10k_cryptodev_ops.c
b/drivers/crypto/cnx
On 3/13/2024 5:57 PM, Long Li wrote:
>> Subject: [PATCH v3 1/1] net/mana: add vlan tagging support
>>
>> For tx path, use LONG_PACKET_FORMAT if vlan tag is present. For rx, extract
>> vlan
>> id from oob, put into mbuf and set the vlan flags in mbuf.
>>
>> Signed-off-by: Wei Hu
> Acked-by: Long L
This is a cleanup I had in store for ages but never sent.
The idea is to reuse the conventions from EAL and examples when it
comes to using getopt API.
--
David Marchand
Changes since v1:
- following Ferruh review, added 2 more cleanup patches,
David Marchand (6):
app/testpmd: fix stats-perio
Rather than silently ignore an invalid value, raise an error for
stats-period user input.
Fixes: cfea1f3048d1 ("app/testpmd: print statistics periodically")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
Acked-by: Ferruh Yigit
---
app/test-pmd/parameters.c | 2 +-
1 file changed, 1 insertio
"""
The variable optind is the index of the next element to be processed in
argv. The system initializes this value to 1. The caller can reset it
to 1 to restart scanning of the same argv, or when scanning a new
argument vector.
"""
Hence, if an invalid option is passed through testpmd cmdline,
rte_eth_dev_info_get() is not supposed to fail for a valid port_id, but
for the theoretical case when it would fail, raise an error rather than
skip subsequent options.
Fixes: 6f51deb903b2 ("app/testpmd: check status of getting ethdev info")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
---
Checking the number of rxq/txq in the middle of option parsing is
confusing.
Besides, a check on nb_rxq / nb_txq check already exists after
option parsing.
Only keep this latter check and make testpmd quit in this case.
Signed-off-by: David Marchand
---
Changes since v1:
- moved the check and ter
The cmdline library is always enabled with meson.
Remove traces of a time when it may have been possible to disable it.
Signed-off-by: David Marchand
---
app/test-pmd/parameters.c | 19 +--
app/test-pmd/testpmd.c| 5 +
2 files changed, 2 insertions(+), 22 deletions(-)
d
This is a cleanup similar to previous ones in EAL and examples.
Instead of using strcmp for every long options while getopt_long already
did such parsing, rely on getopt_long return value.
Note for reviewers: this patch is best reviewed once applied locally and
displayed with git show -w.
Signed-
On 3/14/2024 9:17 AM, David Marchand wrote:
> rte_eth_dev_info_get() is not supposed to fail for a valid port_id, but
> for the theoretical case when it would fail, raise an error rather than
> skip subsequent options.
>
> Fixes: 6f51deb903b2 ("app/testpmd: check status of getting ethdev info")
>
On 3/14/2024 9:17 AM, David Marchand wrote:
> """
> The variable optind is the index of the next element to be processed in
> argv. The system initializes this value to 1. The caller can reset it
> to 1 to restart scanning of the same argv, or when scanning a new
> argument vector.
> """
>
> Hen
On 3/14/2024 9:17 AM, David Marchand wrote:
> Checking the number of rxq/txq in the middle of option parsing is
> confusing.
> Besides, a check on nb_rxq / nb_txq check already exists after
> option parsing.
> Only keep this latter check and make testpmd quit in this case.
>
> Signed-off-by: David
https://bugs.dpdk.org/show_bug.cgi?id=1401
Bug ID: 1401
Summary: [dpdk-24.03][asan] cbdma: ERROR: AddressSanitizer:
SEGV on unknown address in rte_rwlock_write_lock when
launch dpdk-dma
Product: DPDK
Version: unsp
> Subject: [PATCH 00/12] Add TLS features
>
> Add the following features
> 1. Multi segmented packet for TLS
> 2. Padding verification for TLS
> 3. SHA384 & ChaChaPoly for TLS
>
> Aakash Sasidharan (1):
> crypto/cnxk: add support for oop processing in TLS
>
> Anoob Joseph (1):
> crypto/cnxk:
revert 2 patches and fix insert vdev core dump.
Mingjin Ye (3):
bus/vdev: revert fix devargs in secondary process
bus/vdev: revert fix devargs after multi-process bus scan
net/vdev: fix insert vdev core dump
drivers/bus/vdev/vdev.c | 34 ++
1 file changed, 6
The asan tool detected a memory leak in the vdev driver
alloc_devargs. The previous commit was that when inserting
a vdev device, the primary process alloc devargs and the
secondary process looks for devargs. This causes the
device to not be created if the secondary process does
not initialise the
The asan tool detected a memory leak in the vdev driver alloc_devargs.
The previous commit does not insert device arguments into devargs_list
when attaching a device during a bus scan of a secondary process.
This resulted in an existing memory leak when removing a vdev device,
since rte_devargs_rem
Inserting a vdev device when the device arguments are already stored
in devargs_list, the rte_devargs_insert function replaces the supplied
new devargs with the found devargs and frees the new devargs. As a
result, the use of free devargs results in a core dump.
This patch fixes the issue by using
The options allow (-a) and block (-b) cannot be used at the same time.
Therefore, allow (-a) will not be added when block (-b) is present.
Fixes: b3ce7891ad38 ("test: fix probing in secondary process")
Cc: sta...@dpdk.org
Signed-off-by: Mingjin Ye
---
app/test/process.h | 17 ++---
https://bugs.dpdk.org/show_bug.cgi?id=1402
Bug ID: 1402
Summary: net/ice: vlan stripping is broken
Product: DPDK
Version: 23.07
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority
Release status meeting minutes 2024-03-14
=
Agenda:
* Release Dates
* Subtrees
* Roadmaps
* LTS
* Defects
* Opens
Participants:
* AMD
* ARM
* Debian/Microsoft
* Intel
* Marvell
* Nvidia
* Red Hat
Release Dates
-
The following are the current/u
The Intel IPsec Multi-buffer version is set to be bumped to a minimum
version of 1.4 for the 24.11 LTS release.
Signed-off-by: Brian Dooley
---
doc/guides/rel_notes/deprecation.rst | 4
1 file changed, 4 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst
b/doc/guides/rel_note
SW PMDs documentation is updated to remove details of unsupported IPsec
Multi-buffer versions. DPDK older than 20.11 is end of life. So, older
DPDK versions are removed from the Crypto library version table.
Signed-off-by: Sivaramakrishnan Venkat
Signed-off-by: Brian Dooley
Acked-by: Pablo de La
On 1/29/2024 10:22 AM, Chaoyong He wrote:
From: Zerun Fu
For the primary process, the logic loops all BARs and will skip
the map of BAR with an invalid physical address (0), also will
assign 'uio_res->nb_maps' with the real mapped BARs number. But
for the secondary process, instead of loops all
On 3/14/2024 7:05 AM, Chaoyong He wrote:
> This patch series fix some coverity issues, includes:
> - 414936
> - 414937
> - 414938
> - 414939
> - 414941
> - 414942
> - 415042
> - 415051
>
> Chaoyong He (6):
> net/nfp: fix return value check
> net/nfp: fix string overflow
> net/nfp: fix unreac
During flow pattern validation in DV, the next protocol type
should be calculated if and only if protocol mask is defined.
Fixes: 1d7b7ec3a236 ("net/mlx5: remove code duplications")
Cc: getel...@nvidia.com
Signed-off-by: Dariusz Sosnowski
Acked-by: Ori Kam
---
drivers/net/mlx5/mlx5_flow_dv.c |
On 3/14/2024 10:58 AM, Ferruh Yigit wrote:
> On 3/14/2024 7:05 AM, Chaoyong He wrote:
>> This patch series fix some coverity issues, includes:
>> - 414936
>> - 414937
>> - 414938
>> - 414939
>> - 414941
>> - 414942
>> - 415042
>> - 415051
>>
>> Chaoyong He (6):
>> net/nfp: fix return value check
On 3/14/2024 7:40 AM, Chaoyong He wrote:
> This patch series fix some coverity issues, includes:
> - 414936
> - 414937
> - 414938
> - 414939
> - 414941
> - 414942
> - 415042
> - 415051
>
> ---
> v2:
> * Fix one imported uninitialized pointer problem.
> ---
>
> Chaoyong He (6):
> net/nfp: fix re
On 1/29/2024 10:22 AM, Chaoyong He wrote:
From: Zerun Fu
In the previous logic the 'fd' was only saved in the primary process,
but for some devices this value is also used in the secondary logic.
For example, the call of 'rte_pci_find_ext_capability()' will fail in
the secondary process.
Fix
Hi,
> -Original Message-
> From: Dariusz Sosnowski
> Sent: Thursday, March 14, 2024 12:59 PM
> To: Slava Ovsiienko ; Ori Kam ;
> Suanming Mou ; Matan Azrad
> ; Gregory Etelson
> Cc: dev@dpdk.org; Raslan Darawsheh
> Subject: [PATCH] net/mlx5: fix next L3 protocol fetching
>
> During flo
On 3/14/2024 9:17 AM, David Marchand wrote:
> The cmdline library is always enabled with meson.
> Remove traces of a time when it may have been possible to disable it.
>
> Signed-off-by: David Marchand
>
Acked-by: Ferruh Yigit
From: Pavan Nikhilesh
The compiler options march and mtune are a subset
of mcpu and will lead to conflicts if improper march
is chosen for a given mcpu.
To avoid conflicts, discard part number march when
mcpu is available and is supported by the compiler.
Example:
march = armv9-a
From: Pavan Nikhilesh
Some older compilers don't recognize crypto march feature
for thunderxt83 mcpu.
Explicitly add it to march feature list.
Signed-off-by: Pavan Nikhilesh
---
config/arm/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/config/arm/meson.build b/
From: Pavan Nikhilesh
Add armv9-a as supported march flag for ARM neoverse
class of processors.
Update supported march list to include armv9-a.
Signed-off-by: Pavan Nikhilesh
---
config/arm/meson.build | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/config/arm/meson.buil
From: Pavan Nikhilesh
Some ARM CPUs have specific march requirements and
are not compatible with the supported march list.
Add fallback march in case the mcpu and the march
advertised in the part_number_config are not supported
by the compiler.
Example
mcpu = neoverse-n2
march =
From: Pavan Nikhilesh
Allow RTE_ARM_USE_WFE to be enabled at meson configuration
time by passing it via c_args instead of modifying
`config/arm/meson.build`.
Example usage:
meson build -Dc_args='-DRTE_ARM_USE_WFE' \
--cross-file config/arm/arm64_cn10k_linux_gcc
Signed-off-by: Pavan Nik
From: Erez Shitrit
When the user tries to create a matcher and if failed with specific
errno (E2BIG) the message will be in debug level and not in warning.
It is a part of a feature when the user re-try to insert a new matching
depends on that errno, no need the annoying message.
Fixes: c55c2bf
From: Yevgeny Kliteynik
Fix wrong reserved size and add helpful comment
Fixes: 365cdf5f8ce ("net/mlx5/hws: add command layer")
Signed-off-by: Yevgeny Kliteynik
Acked-by: Matan Azrad
---
drivers/common/mlx5/mlx5_prm.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/d
From: Yevgeny Kliteynik
Remove comment that documents parameter that doesn't exist.
Fixes: 3eb748869d2d ("net/mlx5/hws: add send layer")
Signed-off-by: Yevgeny Kliteynik
Acked-by: Matan Azrad
---
drivers/net/mlx5/hws/mlx5dr_send.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/
From: Yevgeny Kliteynik
The following caps were never in use:
- wire_regc
- metadata_c
- metadata_c_mask
Also send ring's reg_addr field wasn't in use.
Removing these caps and fields from structs and removing
the code that queried them.
Signed-off-by: Yevgeny Kliteynik
Acked-by: Matan Azrad
From: Yevgeny Kliteynik
mlx5dr_rule_create returns -ret, so internal functions should return
rte_errno on failure. Fix return values of the function that creates
rule in root table.
Signed-off-by: Yevgeny Kliteynik
Acked-by: Matan Azrad
---
drivers/net/mlx5/hws/mlx5dr_rule.c | 2 +-
1 file ch
From: Yevgeny Kliteynik
Add missing spinlock destruction in error flow.
Fixes: b0290e56dd08 ("net/mlx5/hws: add context object")
Signed-off-by: Yevgeny Kliteynik
Acked-by: Matan Azrad
---
drivers/net/mlx5/hws/mlx5dr_context.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/mlx
From: Yevgeny Kliteynik
Small simplification to the send_queues_close code
Signed-off-by: Yevgeny Kliteynik
Acked-by: Matan Azrad
---
drivers/net/mlx5/hws/mlx5dr_send.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/net/mlx5/hws/mlx5dr_send.c
b/drivers/n
On 3/14/2024 9:17 AM, David Marchand wrote:
> This is a cleanup similar to previous ones in EAL and examples.
> Instead of using strcmp for every long options while getopt_long already
> did such parsing, rely on getopt_long return value.
>
> Note for reviewers: this patch is best reviewed once ap
From: Yevgeny Kliteynik
Instead of passing 0 as an enum parameter, define flag NONE.
This resolves the following code analysis error: "enumerated
type mixed with another type".
This value is currently used in tests only, and will later
be used in backward-compatible steering API.
Fixes: 5cadd74f
From: Yevgeny Kliteynik
Simplify the code that does CQ poll - have DB record
update as part of CQ polling.
Signed-off-by: Yevgeny Kliteynik
Acked-by: Matan Azrad
---
drivers/net/mlx5/hws/mlx5dr_send.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/net/mlx
From: Alex Vesker
The check to detect if a rule is in resize was done incorrectly,
this can lead to an incorrect function call upon completion for
rules which are not in resize (move).
Since the resize_info is in a union we cannot rely only on the
pointer value but also need to make sure the matc
From: Alex Vesker
Requesting the user for number of action resources is
not defined well enough, instead the user should provide
an initial action template which should contain the
future attached action templates.
Signed-off-by: Alex Vesker
Acked-by: Matan Azrad
---
drivers/net/mlx5/hws/mlx5
From: Erez Shitrit
Save the exact tag when matching over jumbo masking.
Fixes: 348cdeec6472 ("net/mlx5/hws: add FW WQE rule creation logic")
Signed-off-by: Erez Shitrit
Acked-by: Matan Azrad
---
drivers/net/mlx5/hws/mlx5dr_rule.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
From: Erez Shitrit
In root tables matcher and rule need to have their port-id, otherwise
the translate function that done in dpdk layer will not get the right
attributes.
For that whenever the matcher is matching the source-port we need to get
the relevant port-id before calling the translate fun
On Thu, Mar 14, 2024 at 5:09 PM wrote:
>
> From: Pavan Nikhilesh
>
> Some older compilers don't recognize crypto march feature
> for thunderxt83 mcpu.
> Explicitly add it to march feature list.
>
> Signed-off-by: Pavan Nikhilesh
Acked-by: Jerin Jacob
> ---
> config/arm/meson.build | 2 +-
>
> -Original Message-
> From: Brian Dooley
> Sent: Thursday, March 14, 2024 10:38 AM
> Cc: dev@dpdk.org; gak...@marvell.com; De Lara Guarch, Pablo
> ; Dooley, Brian
> Subject: [PATCH v7 2/2] doc: announce Intel IPsec MB version bump
>
> The Intel IPsec Multi-buffer version is set to be
On Thu, Mar 7, 2024 at 1:36 PM Anoob Joseph wrote:
>
> Add march & fallback march for Neoverse V2 to support build with older
> compilers that doesn't support mcpu = 'neoverse-v2'.
>
> Signed-off-by: Anoob Joseph
Acked-by: Jerin Jacob
> ---
>
> Depends-on: series-31402 ("config/arm: avoid mcp
Gvnic's DQO format allows offloading IPv4 checksum.
Made changes to Tx and Rx path to translate DPDK flags
to descriptor for offloading (and vice-versa).
Add ptype adminq support to only add this flags for
supported L3/L4 packet-types.
Signed-off-by: Rushil Gupta
Reviewed-by: Joshua Washington
-
On 3/14/2024 9:17 AM, David Marchand wrote:
> This is a cleanup I had in store for ages but never sent.
> The idea is to reuse the conventions from EAL and examples when it
> comes to using getopt API.
>
>
> Changes since v1:
> - following Ferruh review, added 2 more cleanup patches,
>
> David M
> > Subject: RE: [EXTERNAL] [PATCH] app/crypto-perf-test: fix unset crc
> > algorithm
> >
> > > Because net crc api is not thread-safe, setting crc algorithm by the
> > > application will prevent race condition in the calc function.
> > > Race condition still may occur when any of the threads will
v2:
* squashed the related patches
Aakash Sasidharan (1):
crypto/cnxk: add support for oop processing in TLS
Anoob Joseph (1):
crypto/cnxk: avoid branches in datapath
Vidya Sagar Velumuri (6):
crypto/cnxk: multi seg support block ciphers in tls
crypto/cnxk: enable sha384 and chachapoly f
Add support for Scatter-Gather mode for block ciphers in TLS-1.2
Signed-off-by: Vidya Sagar Velumuri
---
drivers/crypto/cnxk/cn10k_cryptodev_sec.h | 3 +-
drivers/crypto/cnxk/cn10k_tls.c | 5 +++
drivers/crypto/cnxk/cn10k_tls_ops.h | 48 ++-
3 files changed,
Enable SHA384-HMAC support for TLS & DTLS 1.2.
Enable CHACHA20-POLY1305 support for TLS-1.3.
Signed-off-by: Vidya Sagar Velumuri
---
drivers/common/cnxk/roc_ie_ot_tls.h | 1 +
drivers/crypto/cnxk/cn10k_tls.c | 56 +--
drivers/crypto/cnxk/cnxk_cryptodev.h
Add session update support for TLS
Signed-off-by: Vidya Sagar Velumuri
---
drivers/crypto/cnxk/cn10k_cryptodev_sec.c | 3 +++
drivers/crypto/cnxk/cn10k_tls.c | 17 +
drivers/crypto/cnxk/cn10k_tls.h | 4
3 files changed, 24 insertions(+)
diff --git a/dr
From: Anoob Joseph
Avoid branches in datapath.
Signed-off-by: Anoob Joseph
---
drivers/crypto/cnxk/cn10k_ipsec_la_ops.h | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/crypto/cnxk/cn10k_ipsec_la_ops.h
b/drivers/crypto/cnxk/cn10k_ipsec_la_ops.h
index a30b8e4
In security session, move PMD metadata to second cacheline. Also
optimize the fields to minimize the memory usage.
Signed-off-by: Anoob Joseph
Signed-off-by: Vidya Sagar Velumuri
---
drivers/crypto/cnxk/cn10k_cryptodev_sec.h | 10 ++
drivers/crypto/cnxk/cn10k_ipsec.c | 4 ++--
For TLS-1.2:
- Verify that the padding bytes are having pad len as the
value.
- Report error in case of discrepancies.
- Trim the padding and MAC from the tls-1.2 records
For TLS-1.3:
- Find the content type as the last non-zero byte in the record.
- Return the content type as the inner content
From: Aakash Sasidharan
Add support for out-of-place processing in TLS.
Signed-off-by: Aakash Sasidharan
---
drivers/crypto/cnxk/cn10k_tls_ops.h | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/cnxk/cn10k_tls_ops.h
b/drivers/crypto/cnxk/cn10k_tls_o
Keep the record context for TLS-1.3 in sync with microcode
structure.
Report error if optional padding is enabled for AEAD
case in both TLS-1.2 and DTLS-1.2.
Use the proper offset for calculating the context size in case of TLS-1.3.
Signed-off-by: Vidya Sagar Velumuri
---
drivers/common/cnxk/r
On Fri, Mar 8, 2024 at 7:54 PM Stephen Hemminger
wrote:
>
> The current limit of file descriptors is too low, it should have
> been set to the maximum possible to send across an unix domain
> socket.
>
> This is an attempt to allow increasing it without breaking ABI.
> But in the process it expose
Recheck-request: iol-broadcom-Performance
Sorry, you had a false failure in CI, so triggering a retest to
correct that. We need to tune this system to reduce performance
variance - I am asking Broadcom if we can make the fail threshold less
sensitive in the interim.
On Fri, 8 Mar 2024 12:36:39 -0800
Stephen Hemminger wrote:
> Both XDP and TAP device are limited in the number of queues
> because of limitations on the number of file descriptors that
> are allowed. The original choice of 8 was too low; the allowed
> maximum is 253 according to unix(7) man page
On Thu, Mar 14, 2024 at 4:23 PM Stephen Hemminger
wrote:
> Rather than mess with versioning everything, probably better to just
> hold off to 24.11 release and do the change there.
>
> It will limit xdp and tap PMD's to 8 queues but no user has been
> demanding more yet.
IIUC, this limitation onl
1 - 100 of 144 matches
Mail list logo
