RE: [EXTERNAL] Re: [EXT] Re: [PATCH v10 4/4] app/dma-perf: add SG copy support

2024-03-01 Thread Gowrishankar Muthukrishnan
Hi Fengcheng, > >>> -output_result(uint8_t scenario_id, uint32_t lcore_id, char > >>> *dma_name, > >> uint16_t ring_size, > >>> - uint16_t kick_batch, uint64_t ave_cycle, uint32_t > >> buf_size, uint32_t nr_buf, > >>> - float memory, float bandwidth, float mops, bo

RE: [PATCH 01/71] cocci/rte_memcpy: add script to eliminate fixed size rte_memcpy

2024-03-01 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, 29 February 2024 23.58 > > Rte_memcpy should not be used for the simple case of copying > a fix size structure because it is slower and will hide problems > from code analysis tools. Coverity, fortify and other analyze

RE: [PATCH v4 5/6] lpm: replace zero length array with flex array

2024-03-01 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Thursday, 29 February 2024 23.59 > > Zero length arrays are GNU extension. Replace with > standard flex array. > > Signed-off-by: Tyler Retzlaff > --- Reviewed-by: Morten Brørup

RE: [PATCH v4 6/6] table: replace zero length array with flex array

2024-03-01 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Thursday, 29 February 2024 23.59 > > Zero length arrays are GNU extension. Replace with > standard flex array. > > Signed-off-by: Tyler Retzlaff > --- Reviewed-by: Morten Brørup

RE: [EXTERNAL] [PATCH] crypto/ipsec_mb: update Arm IPsec-MB library tag

2024-03-01 Thread Akhil Goyal
> Updates the tag of Arm IPsec-MB library to SECLIB-IPSEC-2023.10.13 > in snow3g and zuc documentation. Tag SECLIB-IPSEC-2023.10.13 updates > IPSec-MB library version to 1.4. > > Signed-off-by: Wathsala Vithanage > Reviewed-by: Ruifeng Wang > Reviewed-by: Honnappa Nagarahalli > Reviewed-by: Jac

RE: [EXTERNAL] Re: [EXT] Re: [PATCH v2] app/dma-perf: support bi-directional transfer

2024-03-01 Thread Amit Prakash Shukla
Hi Chengwen, If I'm not wrong, your concern was about config file additions and not about the test as such. If the config file is getting complicated and there are better alternatives, we can minimize the config file changes with this patch and just provide minimum functionality as required and

Re: [PATCH 00/71] replace use of fixed size rte_memcpy

2024-03-01 Thread Bruce Richardson
On Thu, Feb 29, 2024 at 02:57:47PM -0800, Stephen Hemminger wrote: > The DPDK has a lot of "cargo cult" usage of rte_memcpy. > This patch set replaces cases where rte_memcpy is used with a fixed > size constant size. > > Typical example is: > rte_memcpy(mac_addrs, mac.addr_bytes, RTE_ETHER_A

[PATCH v2 0/3] reload the firmware as needed

2024-03-01 Thread Chaoyong He
Add the necessary logic to get firmware version from firmware file, and only reload the firmware when the firmware version changed. Also add a device argument which can force reload the firmware and ignore the firmware version. --- v2: * Update commit log to explain what 'MIP' is. * Document abou

[PATCH v2 1/3] net/nfp: add the elf module

2024-03-01 Thread Chaoyong He
From: Peng Zhang Add the 'nfp_elf' module, which can get new MIP(Microcode Information Page) information from the firmware ELF file. Signed-off-by: Peng Zhang Reviewed-by: Chaoyong He Reviewed-by: Long Wu --- drivers/net/nfp/meson.build |1 + drivers/net/nfp/nfpcore/nfp_elf.c | 107

[PATCH v2 2/3] net/nfp: reload the firmware only when firmware changed

2024-03-01 Thread Chaoyong He
From: Peng Zhang Add the interfaces of getting firmware version from BSP and ELF file, only reloading the firmware when the version is different, which means the firmware has changed. This will accelerate the average startup time for both multi-PF and single-PF firmware. Signed-off-by: Peng Zha

[PATCH v2 3/3] net/nfp: add force reload firmware option

2024-03-01 Thread Chaoyong He
From: Peng Zhang Add an option to force reload the firmware. This option can be ignored in some case, for example: When using a 2 port NFP card and both with this reload firmware option, only the first one will cause the firmware reload and the second one will be ignored. Signed-off-by: Peng Zh

[PATCH] net/mlx5: set correct priority for meter policy

2024-03-01 Thread Shun Hao
Currently a meter policy's flows are always using the same priority for all colors, so the red color flow might be before green/yellow ones. This will impact the performance cause green/yellow packets will check red flow first and got miss, then match green/yellow flows, introducing more hops. Thi

Re: [EXTERNAL] Re: [EXT] Re: [PATCH v2] app/dma-perf: support bi-directional transfer

2024-03-01 Thread fengchengwen
Hi Amit, On 2024/3/1 16:31, Amit Prakash Shukla wrote: > Hi Chengwen, > > If I'm not wrong, your concern was about config file additions and not about > the test as such. If the config file is getting complicated and there are > better alternatives, we can minimize the config file changes with

Re: [PATCH v4 02/23] net/cnxk: implementing eswitch device

2024-03-01 Thread Jerin Jacob
On Wed, Feb 28, 2024 at 12:46 AM Harman Kalra wrote: > > Eswitch device is a parent or base device behind all the representors, > acting as transport layer between representors and representees > > Signed-off-by: Harman Kalra > --- > drivers/net/cnxk/cnxk_eswitch.c | 378

Re: [PATCH v4 23/23] net/cnxk: other flow operations

2024-03-01 Thread Jerin Jacob
On Wed, Feb 28, 2024 at 12:55 AM Harman Kalra wrote: > > Implementing other flow operations - validate, destroy, query, > flush, dump for representor ports > > Signed-off-by: Harman Kalra Please also update doc/guides/rel_notes/release_24_03.rst's PMD section for the port representor feature.

Re: [EXTERNAL] Re: [EXT] Re: [PATCH v10 4/4] app/dma-perf: add SG copy support

2024-03-01 Thread fengchengwen
On 2024/3/1 16:06, Gowrishankar Muthukrishnan wrote: > Hi Fengcheng, > > > -output_result(uint8_t scenario_id, uint32_t lcore_id, char > *dma_name, uint16_t ring_size, > - uint16_t kick_batch, uint64_t ave_cycle, uint32_t buf_size, uint32_t nr_buf, > -

[PATCH v4] net/cnxk: support Tx queue descriptor count

2024-03-01 Thread skoteshwar
From: Satha Rao Added CNXK APIs to get used txq descriptor count. Signed-off-by: Satha Rao --- Depends-on: series-30833 ("ethdev: support Tx queue used count") v2: Updated release notes and fixed API for CPT queues. v3: Addressed review comments doc/guides/nics/features/cnxk.ini |

[PATCH v5] net/i40e: add diagnostic support in TX path

2024-03-01 Thread Mingjin Ye
Implemented a Tx wrapper to perform a thorough check on mbufs, categorizing and counting invalid cases by types for diagnostic purposes. The count of invalid cases is accessible through xstats_get. Also, the devarg option "mbuf_check" was introduced to configure the diagnostic parameters to enable

[PATCH v3] net/ice: add diagnostic support in TX path

2024-03-01 Thread Mingjin Ye
Implemented a Tx wrapper to perform a thorough check on mbufs, categorizing and counting invalid cases by types for diagnostic purposes. The count of invalid cases is accessible through xstats_get. Also, the devarg option "mbuf_check" was introduced to configure the diagnostic parameters to enable

[PATCH v7 1/4] eal: add pointer compression functions

2024-03-01 Thread Paul Szczepanek
Add a new utility header for compressing pointers. The provided functions can store pointers in 32-bit offsets. The compression takes advantage of the fact that pointers are usually located in a limited memory region (like a mempool). We can compress them by converting them to offsets from a base

[PATCH v7 0/4] add pointer compression API

2024-03-01 Thread Paul Szczepanek
This patchset is proposing adding a new EAL header with utility functions that allow compression of arrays of pointers. When passing caches full of pointers between threads, memory containing the pointers is copied multiple times which is especially costly between cores. A compression method will

[PATCH v7 2/4] test: add pointer compress tests to ring perf test

2024-03-01 Thread Paul Szczepanek
Add a test that runs a zero copy burst enqueue and dequeue on a ring of raw pointers and compressed pointers at different burst sizes to showcase performance benefits of newly added pointer compression APIs. Refactored threading code to pass more parameters to threads to reuse existing code. Added

[PATCH v7 3/4] docs: add pointer compression to the EAL guide

2024-03-01 Thread Paul Szczepanek
Documentation added in the EAL guide for the new utility functions for pointer compression showing example code and potential usecases. Signed-off-by: Paul Szczepanek Reviewed-by: Honnappa Nagarahalli --- .../prog_guide/env_abstraction_layer.rst | 142 ++ 1 file changed, 14

[PATCH v7 4/4] test: add unit test for ptr compression

2024-03-01 Thread Paul Szczepanek
Test compresses and decompresses pointers with various combinations of memory regions and alignments and verifies the pointers are recovered correctly. Signed-off-by: Paul Szczepanek --- app/test/meson.build | 1 + app/test/test_eal_ptr_compress.c | 108

Re: [PATCH 1/4] dts: constrain DPDK source flag

2024-03-01 Thread Juraj Linkeš
On Fri, Feb 23, 2024 at 8:09 PM Luca Vizzarro wrote: > > Hi Juraj, > > Thank you for your review! > > On 29/01/2024 11:47, Juraj Linkeš wrote: > > I didn't see the mutual exclusion being enforced in the code. From > > what I can tell, I could pass both --tarball FILEPATH and --revision > > and the

Re: [PATCH v5] net/i40e: add diagnostic support in TX path

2024-03-01 Thread Bruce Richardson
On Fri, Mar 01, 2024 at 09:44:21AM +, Mingjin Ye wrote: > Implemented a Tx wrapper to perform a thorough check on mbufs, > categorizing and counting invalid cases by types for diagnostic > purposes. The count of invalid cases is accessible through xstats_get. > > Also, the devarg option "mbuf_

Re: [PATCH v2] ethdev: add Linux ethtool link mode conversion

2024-03-01 Thread Thomas Monjalon
29/02/2024 18:38, Stephen Hemminger: > On Thu, 29 Feb 2024 17:58:13 +0100 > Morten Brørup wrote: > > > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > > Sent: Thursday, 29 February 2024 17.45 > > > > > > On Thu, 29 Feb 2024 16:42:56 +0100 > > > Thomas Monjalon wrote: > > >

Re: [PATCH] net/ice: fix null pointer dereferences

2024-03-01 Thread Bruce Richardson
On Fri, Mar 01, 2024 at 01:20:29PM +0800, Wenwu Ma wrote: > This patch fixes two null pointer dereferences detected by > coverity scan. > > Coverity issue: 414096 > Fixes: 6ccef90ff5d3 ("net/ice: support VSI level bandwidth config") > > Signed-off-by: Wenwu Ma > --- > drivers/net/ice/ice_tm.c |

Re: [RFC PATCH 1/2] power: refactor core power management library

2024-03-01 Thread Hunt, David
On 01/03/2024 02:56, lihuisong (C) wrote: 在 2024/2/20 23:33, Sivaprasad Tummala 写道: This patch introduces a comprehensive refactor to the core power management library. The primary focus is on improving modularity and organization by relocating specific driver implementations from the 'lib/po

RE: DPDK testpmd with E823 link status is down

2024-03-01 Thread JackyCT . Chen
Hi Zhichao, Do you have any update ? Q: As you said “We are tracking this issue, it is a firmware issue that has been reported to the hardware team and the fix will take some time.“ Could you descript more detail ? 2-1 The “firmware issue” that mean the LEK firmware-version: 3.26 0x8001b733 1.34

[PATCH v4 0/7] test case blocking and logging

2024-03-01 Thread Juraj Linkeš
We currently don't record test case results that couldn't be executed because of a previous failure, such as when a test suite setup failed, resulting in no executed test cases. In order to record the test cases that couldn't be executed, we must know the lists of test suites and test cases ahead

[PATCH v4 1/7] dts: convert dts.py methods to class

2024-03-01 Thread Juraj Linkeš
The dts.py module deviates from the rest of the code without a clear reason. Converting it into a class and using better naming will improve organization and code readability. Signed-off-by: Juraj Linkeš --- dts/framework/dts.py| 338 dts/framework/ru

[PATCH v4 2/7] dts: move test suite execution logic to DTSRunner

2024-03-01 Thread Juraj Linkeš
Move the code responsible for running the test suite from the TestSuite class to the DTSRunner class. This restructuring decision was made to consolidate and unify the related logic into a single unit. Signed-off-by: Juraj Linkeš --- dts/framework/runner.py | 175

[PATCH v4 3/7] dts: filter test suites in executions

2024-03-01 Thread Juraj Linkeš
We're currently filtering which test cases to run after some setup steps, such as DPDK build, have already been taken. This prohibits us to mark the test suites and cases that were supposed to be run as blocked when an earlier setup fails, as that information is not available at that time. To reme

[PATCH v4 4/7] dts: reorganize test result

2024-03-01 Thread Juraj Linkeš
The current order of Result classes in the test_suite.py module is guided by the needs of type hints, which is not as intuitively readable as ordering them by the occurrences in code. The order goes from the topmost level to lowermost: BaseResult DTSResult ExecutionResult BuildTargetResult TestSuit

[PATCH v4 5/7] dts: block all test cases when earlier setup fails

2024-03-01 Thread Juraj Linkeš
In case of a failure before a test suite, the child results will be recursively recorded as blocked, giving us a full report which was missing previously. Signed-off-by: Juraj Linkeš --- dts/framework/runner.py | 21 ++-- dts/framework/test_result.py | 186 +

[PATCH v4 6/7] dts: refactor logging configuration

2024-03-01 Thread Juraj Linkeš
Remove unused parts of the code and add useful features: 1. Add DTS execution stages such as execution and test suite to better identify where in the DTS lifecycle we are when investigating logs, 2. Logging to separate files in specific stages, which is mainly useful for having test suite log

[PATCH v4 7/7] dts: improve test suite and case filtering

2024-03-01 Thread Juraj Linkeš
The two places where we specify which test suite and test cases to run are complimentary and not that intuitive to use. A unified way provides a better user experience. The syntax in test run configuration file has not changed, but the environment variable and the command line arguments was change

RE: [EXTERNAL] Re: [EXT] Re: [PATCH v2] app/dma-perf: support bi-directional transfer

2024-03-01 Thread Amit Prakash Shukla
Hi Chengwen, Please find my reply in-line. Thanks, Amit Shukla > Hi Amit, > > On 2024/3/1 16:31, Amit Prakash Shukla wrote: > > Hi Chengwen, > > > > If I'm not wrong, your concern was about config file additions and not > > about the test as such. If the config file is getting complicated and >

RE: [PATCH 00/71] replace use of fixed size rte_memcpy

2024-03-01 Thread Hemant Agrawal
For DPAAx Series- Acked-by: Hemant Agrawal smime.p7s Description: S/MIME cryptographic signature

Re: [PATCH] net/hns3: fix Rx packet truncation when KEEP CRC enabled

2024-03-01 Thread Ferruh Yigit
On 3/1/2024 6:55 AM, huangdengdui wrote: > > > On 2024/2/29 17:25, Ferruh Yigit wrote: >> On 2/29/2024 3:58 AM, huangdengdui wrote: >>> >>> >>> On 2024/2/28 21:07, Ferruh Yigit wrote: On 2/28/2024 2:27 AM, huangdengdui wrote: > > > On 2024/2/27 0:43, Ferruh Yigit wrote: >> On

RE: [PATCH v5 0/4] add pointer compression API

2024-03-01 Thread Morten Brørup
> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Thursday, 22 February 2024 17.16 > > > For some reason your email is not visible to me, even though it's in the > > archive. > > No worries. > > > > > On 02/11/202416:32,Konstantin Ananyev konstantin.v.ananyev wrote: > >

Re: [PATCH] app/testpmd: fix async flow create failure handling

2024-03-01 Thread Ferruh Yigit
On 2/28/2024 6:57 PM, Dariusz Sosnowski wrote: > In case of an error when an asynchronous flow create operation was > enqueued, test-pmd attempted to enqueue a flow destroy operation > of that flow rule. > However, this was incorrect because: > > - Flow rule index was used to enqueue a flow destro

Re: [PATCH v5] event/cnxk: use WFE LDP loop for getwork routine

2024-03-01 Thread Jerin Jacob
On Tue, Feb 27, 2024 at 1:42 PM wrote: > > From: Pavan Nikhilesh > > Use WFE LDP loop while polling for GETWORK completion for better > power savings. > Disabled by default and can be enabled by configuring meson with > 'RTE_ARM_USE_WFE' enabled. > > Signed-off-by: Pavan Nikhilesh 1) Changed su

[PATCH] crypto/mlx5: add virtual function device ID

2024-03-01 Thread Suanming Mou
This adds the virtual function device ID to the list of supported NVIDIA devices that run the MLX5 compress PMD. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/d

[PATCH] crypto/mlx5: add max segment assert

2024-03-01 Thread Suanming Mou
Currently, for multi-segment mbuf, before crypto WQE an extra UMR WQE will be introduced to build the contiguous memory space. Crypto WQE uses that contiguous memory space key as input. This commit adds assert for maximum supported segments in debug mode in case the segments exceed UMR's limitatio

Re: [PATCH v5 00/22] stop using variadic argument pack extension

2024-03-01 Thread David Marchand
On Thu, Feb 29, 2024 at 10:32 PM Tyler Retzlaff wrote: > > RTE_LOG_LINE cannot be augmented with a prefix format and arguments > without the user of RTE_LOG_LINE using the args... and ## args compiler > extension to conditionally remove trailing comma when the macro receives > only a single argume

Re: [PATCH] common/cnxk: fix link cfg for sdp

2024-03-01 Thread Jerin Jacob
On Wed, Feb 28, 2024 at 12:25 AM Harman Kalra wrote: > > Link configure registers are invalid and should not be accessed > for SDP ports. But while on txq release which does SQ flush calls > backpressure disable API which configures these link registers. > > Fixes: 58debb813a8d ("common/cnxk: enab

RE: [PATCH 00/71] replace use of fixed size rte_memcpy

2024-03-01 Thread Konstantin Ananyev
> The DPDK has a lot of "cargo cult" usage of rte_memcpy. > This patch set replaces cases where rte_memcpy is used with a fixed > size constant size. > > Typical example is: > rte_memcpy(mac_addrs, mac.addr_bytes, RTE_ETHER_ADDR_LEN); > which can be replaced with: > memcpy(mac_addrs

RE: [PATCH v2] app/eventdev: support DMA adapter test

2024-03-01 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Amit Prakash Shukla > Sent: Wednesday, February 28, 2024 11:31 AM > To: Jerin Jacob > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > ; Vamsi Krishna Attunuru > ; Nithin Kumar Dabilpuram > ; Anoob Joseph ; Aakash > Sasidharan ; Amit Prakash Shukla > > Subj

Re: [PATCH v2] ethdev: add Linux ethtool link mode conversion

2024-03-01 Thread Ferruh Yigit
On 2/29/2024 3:42 PM, Thomas Monjalon wrote: > Speed capabilities of a NIC may be discovered through its Linux > kernel driver. It is especially useful for bifurcated drivers, > so they don't have to duplicate the same logic in the DPDK driver. > > Parsing ethtool speed capabilities is made easy t

[DPDK/examples Bug 1390] examples/l3fwd: in event mode tries to RX for not ready port

2024-03-01 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1390 Bug ID: 1390 Summary: examples/l3fwd: in event mode tries to RX for not ready port Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCO

[DPDK/examples Bug 1391] examples/l3fwd: in event-mode hash.txadapter.txq is not always updated

2024-03-01 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1391 Bug ID: 1391 Summary: examples/l3fwd: in event-mode hash.txadapter.txq is not always updated Product: DPDK Version: unspecified Hardware: All OS: All St

Re: [RFC 0/5] crypto/ionic: introduce AMD Pensando ionic crypto driver

2024-03-01 Thread Boyer, Andrew
> On Feb 22, 2024, at 1:40 PM, Boyer, Andrew wrote: > > This patchset introduces a new crypto PMD for AMD Pensando hardware > accelerators. It allows applications running directly on the AMD Pensando > DSC to offload cryptographic operations to hardware cryptographic blocks. > > Depends-on: s

RE: [RFC 0/5] crypto/ionic: introduce AMD Pensando ionic crypto driver

2024-03-01 Thread Akhil Goyal
> -Original Message- > From: Boyer, Andrew > Sent: Friday, March 1, 2024 6:54 PM > To: Akhil Goyal > Cc: dev@dpdk.org > Subject: [EXTERNAL] Re: [RFC 0/5] crypto/ionic: introduce AMD Pensando ionic > crypto driver > > Prioritize security for external emails: Confirm sender and content

Re: [PATCH v1] eventdev/crypto: fix enqueueing invalid ops

2024-03-01 Thread Jerin Jacob
On Wed, Feb 28, 2024 at 10:42 PM Gujjar, Abhinandan S wrote: > > > > > -Original Message- > > From: Kundapura, Ganapati > > Sent: Wednesday, February 28, 2024 4:09 PM > > To: dev@dpdk.org; jer...@marvell.com; Jayatheerthan, Jay > > > > Cc: Naga Harish K, S V ; Gujjar, Abhinandan S > > >

Re: [PATCH v2] ethdev: add Linux ethtool link mode conversion

2024-03-01 Thread Thomas Monjalon
01/03/2024 14:12, Ferruh Yigit: > On 2/29/2024 3:42 PM, Thomas Monjalon wrote: > > Speed capabilities of a NIC may be discovered through its Linux > > kernel driver. It is especially useful for bifurcated drivers, > > so they don't have to duplicate the same logic in the DPDK driver. > > > > Parsi

[DPDK/ethdev Bug 1392] mlx5: random superfluous setting mbuf:hash.fdir.hi

2024-03-01 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1392 Bug ID: 1392 Summary: mlx5: random superfluous setting mbuf:hash.fdir.hi Product: DPDK Version: unspecified Hardware: x86 OS: All Status: UNCONFIRMED Severity: mi

Re: [PATCH v4] net/cnxk: support Tx queue descriptor count

2024-03-01 Thread Jerin Jacob
On Fri, Mar 1, 2024 at 3:19 PM wrote: > > From: Satha Rao > > Added CNXK APIs to get used txq descriptor count. > > Signed-off-by: Satha Rao > --- > > Depends-on: series-30833 ("ethdev: support Tx queue used count") Following build issue clang [1734/2932] Generating drivers/rte_net_ice.sym_c

Re: [PATCH 00/71] replace use of fixed size rte_memcpy

2024-03-01 Thread David Marchand
Hello Stephen, On Fri, Mar 1, 2024 at 12:00 AM Stephen Hemminger wrote: > > The DPDK has a lot of "cargo cult" usage of rte_memcpy. > This patch set replaces cases where rte_memcpy is used with a fixed > size constant size. > > Typical example is: > rte_memcpy(mac_addrs, mac.addr_bytes, R

[DPDK/examples Bug 1393] examples/l3fwd: in eventmode RX queue setup doesn't obey numa

2024-03-01 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1393 Bug ID: 1393 Summary: examples/l3fwd: in eventmode RX queue setup doesn't obey numa Product: DPDK Version: 23.11 Hardware: All OS: All Status: UNCONFIRM

Re: Email based retest request process: proposal for new pull/re-apply feature

2024-03-01 Thread zhoumin
On Wed, Feb 21, 2024 at 2:24AM, Patrick Robb wrote: On Tue, Feb 20, 2024 at 1:12 PM Aaron Conole > wrote: Why not something like: Recheck-request: [attribute-list],[test-list]... For example, then we can do: Recheck-request: rebase=[identifier],.

RE: [PATCH v2] app/eventdev: support DMA adapter test

2024-03-01 Thread Amit Prakash Shukla
Hi Pavan, Thanks for the review and feedback. I will send next version with suggested changes. Thanks, Amit Shukla > > diff --git a/app/test-eventdev/test_perf_common.c b/app/test- > > eventdev/test_perf_common.c index 5e0255cfeb..509d3f9232 100644 > > --- a/app/test-eventdev/test_perf_common

Re: [PATCH v2] ethdev: add Linux ethtool link mode conversion

2024-03-01 Thread Ferruh Yigit
On 3/1/2024 1:37 PM, Thomas Monjalon wrote: > 01/03/2024 14:12, Ferruh Yigit: >> On 2/29/2024 3:42 PM, Thomas Monjalon wrote: >>> Speed capabilities of a NIC may be discovered through its Linux >>> kernel driver. It is especially useful for bifurcated drivers, >>> so they don't have to duplicate th

[PATCH v5] common/qat: add virtual qat device (vQAT)

2024-03-01 Thread Arkadiusz Kusztal
This commit adds virtual QAT device to the Intel QuickAssist Technology PMD. There are three kinds of virtual QAT device defined which offer different QAT service to the customers: symmetric crypto, asymmetric crypto and compression. Signed-off-by: Arkadiusz Kusztal --- v2: - added symmetric cryp

Re: [PATCH v2] ethdev: add Linux ethtool link mode conversion

2024-03-01 Thread Thomas Monjalon
01/03/2024 16:08, Ferruh Yigit: > On 3/1/2024 1:37 PM, Thomas Monjalon wrote: > > 01/03/2024 14:12, Ferruh Yigit: > >> On 2/29/2024 3:42 PM, Thomas Monjalon wrote: > >>> Speed capabilities of a NIC may be discovered through its Linux > >>> kernel driver. It is especially useful for bifurcated drive

Re: [PATCH v4] vhost: enhance virtqueue access lock asserts

2024-03-01 Thread Maxime Coquelin
On 2/27/24 11:39, David Marchand wrote: A simple comment in vhost_user_msg_handler() is not that robust. Add a lock_all_qps property to message handlers so that their implementation can add a build check and assert a vq is locked. Signed-off-by: David Marchand Reviewed-by: Maxime Coquelin

RE: [EXTERNAL] [PATCH v5] common/qat: add virtual qat device (vQAT)

2024-03-01 Thread Akhil Goyal
> --- a/doc/guides/rel_notes/release_24_03.rst > +++ b/doc/guides/rel_notes/release_24_03.rst > @@ -146,6 +146,10 @@ New Features > to support TLS v1.2, TLS v1.3 and DTLS v1.2. >* Added PMD API to allow raw submission of instructions to CPT. > > +* **Updated Intel QuickAssist Technology d

RE: [v11 2/3] net/af_xdp: fix multi interface support for K8s

2024-03-01 Thread Loftus, Ciara
snip > @@ -1695,17 +1699,16 @@ xsk_configure(struct pmd_internals *internals, > struct pkt_rx_queue *rxq, > } > > if (internals->use_cni) { > - int err, fd, map_fd; > + int err, map_fd; > > - /* get socket fd from CNI plugin */ > - map_

Re: [PATCH v5] common/qat: add virtual qat device (vQAT)

2024-03-01 Thread Ji, Kai
Acked-by: Kai Ji From: Arkadiusz Kusztal Sent: 01 March 2024 15:19 To: dev@dpdk.org Cc: gak...@marvell.com ; Power, Ciara ; Kusztal, ArkadiuszX Subject: [PATCH v5] common/qat: add virtual qat device (vQAT) This commit adds virtual QAT device to the Intel Qui

[PATCH v5 1/3] common/qat: isolate parser arguments configuration

2024-03-01 Thread Arkadiusz Kusztal
This commit isolates qat device arguments from the common code. Now arguments are defined per service, and only appear in the application if the service is compiled-in. Depends-on: patch-137678 ("common/qat: add virtual qat device (vQAT)") Signed-off-by: Arkadiusz Kusztal --- v2: - added pmd iso

[PATCH v5 2/3] common/qat: decouple pmds from the common code

2024-03-01 Thread Arkadiusz Kusztal
Service specific functions were moved to services files. Weak symbols for device create/destroy were removed, named private devs were replaced by an opaque array. Signed-off-by: Arkadiusz Kusztal --- drivers/common/qat/qat_device.c | 112 ++-- drivers/common/q

[PATCH v5 3/3] common/qat: fix incorrectly placed legacy flag

2024-03-01 Thread Arkadiusz Kusztal
This commit fixes a legacy flag, which was placed in a file that may not be included in a building process. Fixes: cffb726b7797 ("crypto/qat: enable insecure algorithms") Signed-off-by: Arkadiusz Kusztal --- drivers/common/qat/qat_device.c | 1 + drivers/crypto/qat/qat_sym.c| 1 - 2 files c

[RFC PATCH v1] dts: skip test cases based on capabilities

2024-03-01 Thread Juraj Linkeš
The devices under test may not support the capabilities required by various test cases. Add support for: 1. Marking test suites and test cases with required capabilities, 2. Getting which required capabilities are supported by the device under test, 3. And then skipping test suites and test case

RE: [PATCH v5 1/3] common/qat: isolate parser arguments configuration

2024-03-01 Thread Dooley, Brian
Hi Arek, > -Original Message- > From: Arkadiusz Kusztal > Sent: Friday, March 1, 2024 3:53 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Power, Ciara ; Kusztal, > ArkadiuszX > Subject: [PATCH v5 1/3] common/qat: isolate parser arguments configuration > > This commit isolates qat devic

RE: [PATCH v5 2/3] common/qat: decouple pmds from the common code

2024-03-01 Thread Dooley, Brian
> -Original Message- > From: Arkadiusz Kusztal > Sent: Friday, March 1, 2024 3:53 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Power, Ciara ; Kusztal, > ArkadiuszX > Subject: [PATCH v5 2/3] common/qat: decouple pmds from the common > code > > Service specific functions were moved t

RE: [PATCH v5 3/3] common/qat: fix incorrectly placed legacy flag

2024-03-01 Thread Dooley, Brian
> -Original Message- > From: Arkadiusz Kusztal > Sent: Friday, March 1, 2024 3:53 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Power, Ciara ; Kusztal, > ArkadiuszX > Subject: [PATCH v5 3/3] common/qat: fix incorrectly placed legacy flag > > This commit fixes a legacy flag, which wa

Re: [PATCH] crypto/mlx5: add max segment assert

2024-03-01 Thread Patrick Robb
The Community Lab had an infra failure this morning and some patches including yours were affected with false failures. The issue is now resolved and we are rerunning the tests in question for all patches submitted today. On Fri, Mar 1, 2024 at 7:43 AM Suanming Mou wrote: > Currently, for multi-

Re: [PATCH] crypto/mlx5: add virtual function device ID

2024-03-01 Thread Patrick Robb
The Community CI Testing Lab had an infra failure this morning and some patches including yours were affected with false failures. The issue is now resolved and we are rerunning the tests in question for all patches submitted today. On Fri, Mar 1, 2024 at 7:31 AM Suanming Mou wrote: > This adds

Re: [PATCH v4 0/7] test case blocking and logging

2024-03-01 Thread Patrick Robb
The Community CI Testing Lab had an infra failure this morning and some patches including yours were affected with false failures. The issue is now resolved and we are rerunning the tests in question for all patches submitted today. On Fri, Mar 1, 2024 at 5:55 AM Juraj Linkeš wrote: > We current

Re: [PATCH v5 0/4] add pointer compression API

2024-03-01 Thread Patrick Robb
The Community CI Testing Lab had an infra failure this morning and some patches including yours were affected with false failures. The issue is now resolved and we are rerunning the tests in question for all patches submitted today. On Fri, Mar 1, 2024 at 6:16 AM Morten Brørup wrote: > > From: K

Re: [PATCH v5] net/i40e: add diagnostic support in TX path

2024-03-01 Thread Patrick Robb
The Community CI Testing Lab had an infra failure this morning and some patches including yours were affected with false failures. The issue is now resolved and we are rerunning the tests in question for all patches submitted today. On Fri, Mar 1, 2024 at 5:25 AM Bruce Richardson wrote: > On Fri

Re: [PATCH v3] net/ice: add diagnostic support in TX path

2024-03-01 Thread Patrick Robb
The Community CI Testing Lab had an infra failure this morning and some patches including yours were affected with false failures. The issue is now resolved and we are rerunning the tests in question for all patches submitted today. On Fri, Mar 1, 2024 at 5:11 AM Mingjin Ye wrote: > Implemented

Re: [PATCH] net/mlx5: set correct priority for meter policy

2024-03-01 Thread Patrick Robb
The Community CI Testing Lab had an infra failure this morning and some patches including yours were affected with false failures. The issue is now resolved and we are rerunning the tests in question for all patches submitted today. On Fri, Mar 1, 2024 at 3:46 AM Shun Hao wrote: > Currently a me

[PATCH 0/7] add Nitrox compress device support

2024-03-01 Thread Nagadheeraj Rottela
Add the Nitrox PMD to support Nitrox compress device. --- v4: * Fixed checkpatch warnings. * Updated release notes. v3: * Fixed ABI compatibility issue. v2: * Reformatted patches to minimize number of changes. * Removed empty file with only copyright. * Updated all feature flags in nitrox.ini fil

[PATCH v4 1/7] crypto/nitrox: move common code

2024-03-01 Thread Nagadheeraj Rottela
A new compressdev Nitrox PMD will be added in next few patches. This patch moves some of the common code which is shared across Nitrox crypto and compress drivers to drivers/common/nitrox folder. Signed-off-by: Nagadheeraj Rottela --- MAINTAINERS| 1 + driver

[PATCH v4 2/7] drivers/compress: add Nitrox driver

2024-03-01 Thread Nagadheeraj Rottela
Introduce Nitrox compressdev driver. This patch implements below operations - dev_configure - dev_close - dev_infos_get - private_xform_create - private_xform_free Signed-off-by: Nagadheeraj Rottela --- MAINTAINERS | 7 + doc/guides/compressdevs/features/nitrox

[PATCH v4 3/7] common/nitrox: add compress hardware queue management

2024-03-01 Thread Nagadheeraj Rottela
Added compress device hardware ring initialization. Signed-off-by: Nagadheeraj Rottela --- drivers/common/nitrox/nitrox_csr.h | 12 +++ drivers/common/nitrox/nitrox_hal.c | 116 + drivers/common/nitrox/nitrox_hal.h | 115 drivers/common/n

[PATCH v4 4/7] crypto/nitrox: set queue type during queue pair setup

2024-03-01 Thread Nagadheeraj Rottela
Set queue type as SE to initialize symmetric hardware queue. Signed-off-by: Nagadheeraj Rottela --- drivers/crypto/nitrox/nitrox_sym.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/nitrox/nitrox_sym.c b/drivers/crypto/nitrox/nitrox_sym.c index 1244317438..03652d3ade 100644

[PATCH v4 5/7] compress/nitrox: add software queue management

2024-03-01 Thread Nagadheeraj Rottela
Added software queue management code corresponding to queue pair setup and release functions. Signed-off-by: Nagadheeraj Rottela --- drivers/compress/nitrox/nitrox_comp.c | 115 +++--- drivers/compress/nitrox/nitrox_comp.h | 1 + 2 files changed, 105 insertions(+), 11 delet

[PATCH v4 6/7] compress/nitrox: support stateless request

2024-03-01 Thread Nagadheeraj Rottela
Implement enqueue and dequeue burst operations for stateless request support. Signed-off-by: Nagadheeraj Rottela --- drivers/compress/nitrox/meson.build | 1 + drivers/compress/nitrox/nitrox_comp.c| 91 ++- drivers/compress/nitrox/nitrox_comp_reqmgr.c | 792 ++

[PATCH v4 7/7] compress/nitrox: support stateful request

2024-03-01 Thread Nagadheeraj Rottela
Implement enqueue and dequeue burst operations for stateful request support. Signed-off-by: Nagadheeraj Rottela --- drivers/compress/nitrox/nitrox_comp.c| 97 +++- drivers/compress/nitrox/nitrox_comp.h| 1 + drivers/compress/nitrox/nitrox_comp_reqmgr.c | 550 --

[PATCH] examples/l3fwd: fix Rx over not ready port

2024-03-01 Thread Konstantin Ananyev
From: Konstantin Ananyev Running l3fwd in event mode with SW eventdev, service cores can start RX before main thread is finished with PMD installation. to reproduce: ./dpdk-l3fwd --lcores=49,51 -n 6 -a ca:00.0 -s 0x8 \ --vdev event_sw0 -- \ -L -P -p 1 --mode eventdev --eventq-sched=o

RE: [EXTERNAL] [PATCH] examples/l3fwd: fix Rx over not ready port

2024-03-01 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Konstantin Ananyev > Sent: Friday, March 1, 2024 10:10 PM > To: dev@dpdk.org > Cc: Jerin Jacob ; Pavan Nikhilesh Bhagavatula > ; Konstantin Ananyev > ; sta...@dpdk.org > Subject: [EXTERNAL] [PATCH] examples/l3fwd: fix Rx over not ready port > > Prioritize s

Re: [v11 2/3] net/af_xdp: fix multi interface support for K8s

2024-03-01 Thread Maryam Tahhan
On 01/03/2024 15:43, Loftus, Ciara wrote: snip @@ -1695,17 +1699,16 @@ xsk_configure(struct pmd_internals *internals, struct pkt_rx_queue *rxq, } if (internals->use_cni) { - int err, fd, map_fd; + int err, map_fd; - /* get socket fd fr

Re: [PATCH] lib/hash: fix the return value description of rte_hash

2024-03-01 Thread Vladimir Medvedkin
I believe this patch requires fixline and cc stable@ Fixes: af75078fece3 ("first public release") Apart from it Acked-by: Vladimir Medvedkin чт, 6 июл. 2023 г. в 23:58, Stephen Hemminger : > On Mon, 27 Jun 2022 21:11:21 +0800 > Chenming C wrote: > > > The rte_hash lookup can return ZERO whic

RE: [EXTERNAL] [PATCH] examples/l3fwd: fix Rx over not ready port

2024-03-01 Thread Konstantin Ananyev
> > From: Konstantin Ananyev > > Sent: Friday, March 1, 2024 10:10 PM > > To: dev@dpdk.org > > Cc: Jerin Jacob ; Pavan Nikhilesh Bhagavatula > > ; Konstantin Ananyev > > ; sta...@dpdk.org > > Subject: [EXTERNAL] [PATCH] examples/l3fwd: fix Rx over not ready port > > > > Prioritize security for

Re: [PATCH v2] ethdev: add Linux ethtool link mode conversion

2024-03-01 Thread Ferruh Yigit
On 3/1/2024 3:20 PM, Thomas Monjalon wrote: > 01/03/2024 16:08, Ferruh Yigit: >> On 3/1/2024 1:37 PM, Thomas Monjalon wrote: >>> 01/03/2024 14:12, Ferruh Yigit: On 2/29/2024 3:42 PM, Thomas Monjalon wrote: > Speed capabilities of a NIC may be discovered through its Linux > kernel drive

Re: [PATCH] hash: fix segfault by adding param name NULL check

2024-03-01 Thread Vladimir Medvedkin
+cc stable@ Acked-by: Vladimir Medvedkin чт, 6 июл. 2023 г. в 16:26, Conor Fogarty : > Add NULL pointer check to params->name, which is later > copied into the hash datastructure. Without this check > the code segfaults on the strlcpy() of a NULL pointer. > > Fixes: 48a399119619 ("hash: replace

[PATCH v2 01/71] cocci/rte_memcpy: add script to eliminate fixed size rte_memcpy

2024-03-01 Thread Stephen Hemminger
Rte_memcpy should not be used for the simple case of copying a fix size structure because it is slower and will hide problems from code analysis tools. Coverity, fortify and other analyzers special case memcpy(). Gcc (and Clang) are smart enough to inline copies which will be faster. Signed-off-b

  1   2   3   >