On 2024/2/19 2:11, Thomas Monjalon wrote:
09/11/2023 11:20, Jie Hai:
Field 'flags' of struct rte_ring is defined as int type. However,
it is used as unsigned int. To ensure consistency, change the
type of flags to unsigned int. Since these two types has the
same byte size, this change is not an
This patch supports dump of ring information by its name.
An example using this command is shown below:
--> /ring/info,MP_mb_pool_0
{
"/ring/info": {
"name": "MP_mb_pool_0",
"socket": 0,
"flags": 0,
"producer_type": "MP",
"consumer_type": "MC",
"size": 262144,
"mask":
Add a telemetry command to list the rings used in the system.
An example using this command is shown below:
--> /ring/list
{
"/ring/list": [
"HT_:7d:00.2",
"MP_mb_pool_0"
]
}
Signed-off-by: Jie Hai
Acked-by: Konstantin Ananyev
Reviewed-by: Honnappa Nagarahalli
Acked-by: Huisong
This patch set supports telemetry cmd to list rings and dump information
of a ring by its name.
v1->v2:
1. Add space after "switch".
2. Fix wrong strlen parameter.
v2->v3:
1. Remove prefix "rte_" for static function.
2. Add Acked-by Konstantin Ananyev for PATCH 1.
3. Introduce functions to return
The previous netvsc code incorrectly parsed the VLAN ID and priority.
If the 16-bits of VLAN ID and priority/CFI on the wire was
0123456789ABCDEF the code parsed it as 456789ABCDEF3012. This patch
fixes netvsc parsing code and adds common macros for extracting and
setting parts of the VLAN tag.
A
Add common macros for extracting parts of VLAN tag.
Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device")
Cc: sthem...@microsoft.com
Cc: sta...@dpdk.org
Signed-off-by: Alan Elder
---
v7:
* Split patches for lib and driver
v6:
* Line length can be 100 - un-split lines
v5:
* Move the VL
The previous code incorrectly parsed the VLAN ID and priority.
If the 16-bits of VLAN ID and priority/CFI on the wire was
0123456789ABCDEF the code parsed it as 456789ABCDEF3012. There
were macros defined to handle this conversion but they were not
used.
Fixes: 4e9c73e96e83 ("net/netvsc: add Hype
On 2/19/2024 2:44 AM, Rushil Gupta wrote:
> This was causing failure for testpmd runs (for queues >=15)
> presumably due to flooding of logs due to descriptor ring being
> overwritten.
>
> Fixes: a01854 ("net/gve: fix dqo bug for chained descriptors")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Rush
On 2/16/2024 11:40 AM, Ferruh Yigit:
> I missed v6 but put some comment on v5, briefly can you please split the
> patch for lib/net and driver?
I've tried to split the patch - hopefully got the formatting right - please let
me know if not (it's my first time submitting a patch and I don't have a
This RFC presents a new API for static per-lcore id
data allocation.
Please refer to the API documentation for both a
rationale for this new API, and a comparison to the alternatives
available.
The adoption of this API would affect many different DPDK modules, but
the author updated only a few,
Replace keeping PRNG state in a RTE_MAX_LCORE-sized static array of
cache-aligned and RTE_CACHE_GUARDed struct instances with keeping the
same state in a more cache-friendly lcore variable.
Signed-off-by: Mattias Rönnblom
---
lib/eal/common/rte_random.c | 30 ++
1 fil
Signed-off-by: Mattias Rönnblom
---
lib/power/rte_power_pmd_mgmt.c | 27 ++-
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/lib/power/rte_power_pmd_mgmt.c b/lib/power/rte_power_pmd_mgmt.c
index 591fc69f36..bb20e564de 100644
--- a/lib/power/rte_power_pmd_mg
RFC v2:
* Improve alignment-related test coverage.
Signed-off-by: Mattias Rönnblom
---
app/test/meson.build | 1 +
app/test/test_lcore_var.c | 408 ++
2 files changed, 409 insertions(+)
create mode 100644 app/test/test_lcore_var.c
diff --git a/app/te
Introduce DPDK per-lcore id variables, or lcore variables for short.
An lcore variable has one value for every current and future lcore
id-equipped thread.
The primary use case is for statically allocating
small chunks of often-used data, which is related logically, but where
there are performan
Signed-off-by: Mattias Rönnblom
---
lib/eal/common/rte_service.c | 119 ---
1 file changed, 68 insertions(+), 51 deletions(-)
diff --git a/lib/eal/common/rte_service.c b/lib/eal/common/rte_service.c
index d959c91459..de205c5da5 100644
--- a/lib/eal/common/rte_serv
> Jie Hai (2):
> ring: add telemetry cmd to list rings
> ring: add telemetry cmd for ring info
Applied, thanks.
Implemented a Tx wrapper to perform a thorough check on mbufs,
categorizing and counting invalid cases by types for diagnostic
purposes. The count of invalid cases is accessible through xstats_get.
Also, the devarg option "mbuf_check" was introduced to configure the
diagnostic parameters to enable
On 2/19/2024 2:44 AM, Rushil Gupta wrote:
> This was causing failure for testpmd runs (for queues >=15)
> presumably due to flooding of logs due to descriptor ring being
> overwritten.
>
> Fixes: a01854 ("net/gve: fix dqo bug for chained descriptors")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Rush
On Sun, Feb 18, 2024 at 11:05:35AM +0100, Morten Brørup wrote:
> > From: Stephen Hemminger [mailto:step...@networkplumber.org]
> > Sent: Saturday, 17 February 2024 19.11
> >
> > On Sat, 17 Feb 2024 19:02:30 +0100
> > Morten Brørup wrote:
> >
> > > Not formally... it follows the official DPDK Cod
On 2/19/2024 10:26 AM, Bruce Richardson wrote:
> On Sun, Feb 18, 2024 at 11:05:35AM +0100, Morten Brørup wrote:
>>> From: Stephen Hemminger [mailto:step...@networkplumber.org]
>>> Sent: Saturday, 17 February 2024 19.11
>>>
>>> On Sat, 17 Feb 2024 19:02:30 +0100
>>> Morten Brørup wrote:
>>>
No
05/12/2023 10:45, David Marchand:
> +#define VHOST_USER_ASSERT_LOCK(dev, vq, id) do { \
> + RTE_BUILD_BUG_ON(!vhost_message_handlers[id].lock_all_qps); \
> + vq_assert_lock(dev, vq); \
> +} while (0)
Since "eal: enhance compile-time checks using C11 assert",
it is not allowed to have non-c
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se]
> Sent: Monday, 19 February 2024 08.49
>
> On 2024-02-09 14:04, Morten Brørup wrote:
> >> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se]
> >> Sent: Friday, 9 February 2024 12.46
> >>
> >> On 2024-02-09 09:25, Morten Brørup wrote:
> >>>
On 2/19/2024 9:31 AM, Alan Elder wrote:
> Add common macros for extracting parts of VLAN tag.
>
> Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Alan Elder
>
Reviewed-by: Ferruh Yigit
On 2/19/2024 9:31 AM, Alan Elder wrote:
> The previous code incorrectly parsed the VLAN ID and priority.
> If the 16-bits of VLAN ID and priority/CFI on the wire was
> 0123456789ABCDEF the code parsed it as 456789ABCDEF3012. There
> were macros defined to handle this conversion but they were not
>
On 2/19/2024 11:12 AM, Ferruh Yigit wrote:
> On 2/19/2024 9:31 AM, Alan Elder wrote:
>> Add common macros for extracting parts of VLAN tag.
>>
>> Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device")
>> Cc: sta...@dpdk.org
>>
>> Signed-off-by: Alan Elder
>>
>
> Reviewed-by: Ferruh Yigit
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com]
> Sent: Monday, 19 February 2024 10.41
>
> Replace keeping PRNG state in a RTE_MAX_LCORE-sized static array of
> cache-aligned and RTE_CACHE_GUARDed struct instances with keeping the
> same state in a more cache-friendly lcore variabl
On 2/17/2024 4:47 PM, Stephen Hemminger wrote:
> On Sat, 17 Feb 2024 09:54:10 +0800
> Chaoyong He wrote:
>
>> Add the support of UDP fragmentation offload feature.
>>
>> Signed-off-by: Chaoyong He
>> Reviewed-by: Long Wu
>> Reviewed-by: Peng Zhang
>> ---
>> drivers/common/nfp/nfp_common_ctrl.
On 2/17/2024 1:54 AM, Chaoyong He wrote:
> Add the support of UDP fragmentation offload feature.
>
> Signed-off-by: Chaoyong He
> Reviewed-by: Long Wu
> Reviewed-by: Peng Zhang
<...>
> diff --git a/drivers/net/nfp/nfp_net_common.c
> b/drivers/net/nfp/nfp_net_common.c
> index 72c9a41b00..99c3
On 2024-02-19 12:22, Morten Brørup wrote:
From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com]
Sent: Monday, 19 February 2024 10.41
Replace keeping PRNG state in a RTE_MAX_LCORE-sized static array of
cache-aligned and RTE_CACHE_GUARDed struct instances with keeping the
same state in a m
On 2/17/2024 1:54 AM, Chaoyong He wrote:
> Add the support of UDP fragmentation offload feature.
>
> Signed-off-by: Chaoyong He
> Reviewed-by: Long Wu
> Reviewed-by: Peng Zhang
>
Applied to dpdk-next-net/main, thanks.
On 2024-02-19 12:10, Morten Brørup wrote:
From: Mattias Rönnblom [mailto:hof...@lysator.liu.se]
Sent: Monday, 19 February 2024 08.49
On 2024-02-09 14:04, Morten Brørup wrote:
From: Mattias Rönnblom [mailto:hof...@lysator.liu.se]
Sent: Friday, 9 February 2024 12.46
On 2024-02-09 09:25, Morten B
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se]
> Sent: Monday, 19 February 2024 15.32
>
> On 2024-02-19 12:10, Morten Brørup wrote:
> >> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se]
> >> Sent: Monday, 19 February 2024 08.49
> >>
> >> On 2024-02-09 14:04, Morten Brørup wrote:
> >>
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se]
> Sent: Monday, 19 February 2024 15.04
>
> On 2024-02-19 12:22, Morten Brørup wrote:
> >> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com]
> >> Sent: Monday, 19 February 2024 10.41
> >>
> >> Replace keeping PRNG state in a RTE_MA
On 2/16/2024 5:07 PM, Andrew Boyer wrote:
> Add support for running DPDK applications directly on AMD Pensando
> embedded HW. The platform exposes the device BARs through UIO. The
> UIO code in the common/ionic library walks the sysfs filesystem
> to identify the relevant BARs and map them into pro
On Mon, 19 Feb 2024 02:44:35 +
Rushil Gupta wrote:
> This was causing failure for testpmd runs (for queues >=15)
> presumably due to flooding of logs due to descriptor ring being
> overwritten.
>
> Fixes: a01854 ("net/gve: fix dqo bug for chained descriptors")
> Cc: sta...@dpdk.org
>
> Sign
Hi Abdullah,
Could you please tell more about use cases where this API may be useful?
a new API to get the hidden key count in the hash table if the rcu qsbr is
enabled
Here in commit message and down below in doxygen comments, I think this
statement should be more specific because rcu can
Hello,
Let me explain a use case;
I have a hash table whose key value is IP addresses, and data (let's say
the username of the IP) is related to the IP address. The key point is
matching these data with flows. Flows are dynamic, and this hash table is
dynamic, as well; both can change anytime. Fo
On Feb 19, 2024, at 10:24 AM, Yigit, Ferruh wrote:
On 2/16/2024 5:07 PM, Andrew Boyer wrote:
Add support for running DPDK applications directly on AMD Pensando
embedded HW. The platform exposes the device BARs through UIO. The
UIO code in the common/ionic library walks the sysfs filesystem
to i
Hi Andrew,
I think that this barrier may have been added to ensure any writes to
q->hw_index
and q->head_idx complete before ionic_q_flush computes val. Dependency chains
can also prevent reordering if that's the case this barrier is not required.
However, I have the following concern.
> diff --
19/02/2024 20:50, Stephen Hemminger:
> On Fri, 12 Jan 2024 10:02:05 +0200
> Gavin Li wrote:
>
> > Previously, VXLAN-GPE in DPDK only supports VNI and next protocol header
> > fields. This patch series add support for flags and reserved field 0 and
> > 1.
> >
> > Below is the VXLAN-GPE header def
> On Feb 19, 2024, at 3:28 PM, Abdullah Ömer Yamaç wrote:
>
> Hello,
>
> Let me explain a use case;
>
> I have a hash table whose key value is IP addresses, and data (let's say the
> username of the IP) is related to the IP address. The key point is matching
> these data with flows. Flows a
Add Arm Neoverse V2 CPU part number
Signed-off-by: Honnappa Nagarahalli
Acked-by: Ruifeng Wang
Reviewed-by: Wathsala Vithanage
---
config/arm/meson.build | 10 ++
1 file changed, 10 insertions(+)
diff --git a/config/arm/meson.build b/config/arm/meson.build
index 36f21d2259..18b595ead1
Add generic V2 CPU SoC. This will allow for compiling a binary
that will run on any SoC that uses V2 CPU.
Signed-off-by: Honnappa Nagarahalli
Reviewed-by: Wathsala Vithanage
---
config/arm/arm64_v2_linux_gcc | 16
config/arm/meson.build| 9 +
2 files changed, 2
Add meson build configuration for NVIDIA Grace platform
with 64-bit Arm Neoverse V2 cores.
Signed-off-by: Honnappa Nagarahalli
Acked-by: Ruifeng Wang
Reviewed-by: Wathsala Vithanage
---
config/arm/arm64_grace_linux_gcc | 16
config/arm/meson.build | 10 ++
2
Add meson build configuration for AWS Graviton4 platform
with 64-bit Arm Neoverse V2 cores.
Signed-off-by: Honnappa Nagarahalli
Reviewed-by: Wathsala Vithanage
---
config/arm/arm64_graviton4_linux_gcc | 16
config/arm/meson.build | 14 ++
2 files chang
> -Original Message-
> From: Wathsala Wathawana Vithanage
> Sent: Monday, February 19, 2024 4:17 PM
> To: Andrew Boyer ; dev@dpdk.org
> Cc: Neel Patel ; nd ; Honnappa
> Nagarahalli ; nd
> Subject: RE: [PATCH 2/3] net/ionic: remove duplicate barriers
>
> Hi Andrew,
>
> I think that th
> On Feb 16, 2024, at 11:07 AM, Andrew Boyer wrote:
>
> Add support for running DPDK applications directly on AMD Pensando
> embedded HW. The platform exposes the device BARs through UIO. The
> UIO code in the common/ionic library walks the sysfs filesystem
> to identify the relevant BARs and m
In the original implementation, the max_frame_size could be zero, but
commit ("examples/dma: replace getopt with argparse") treat zero as an
error. This commit fixes it.
Also, since unsigned doesn't < 0, adjust "<= 0" judgement to "== 0".
Fixes: 8d85afb19af7 ("examples/dma: replace getopt with ar
https://bugs.dpdk.org/show_bug.cgi?id=1381
Bug ID: 1381
Summary: TAP device can not support 17 queues
Product: DPDK
Version: 23.11
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Prior
I agree.
This bug has manifested for a while before I fixed it partially in "[PATCH]
net/gve: fix dqo bug for chained descriptors"
However, for higher queue counts (> 13); we still see this behavior. I'll
add a statistic.
On Mon, Feb 19, 2024, 10:56 PM Stephen Hemminger
wrote:
> On Mon, 19 Feb 2
Hi, Ferruh,
Thanks for your review.
On 2024/2/7 22:15, Ferruh Yigit wrote:
On 2/6/2024 1:10 AM, Jie Hai wrote:
From: Dengdui Huang
When KEEP_CRC offload is enabled, some packets will be truncated and
the CRC is still be stripped in following cases:
1. For HIP08 hardware, the packet type is T
When I was trying to debug a problem introduced by config.ini in
test-dma-perf, I found the cfgfile library should enhance error
detecting, so got this patchset.
Chengwen Feng (4):
cfgfile: remove dead code
cfgfile: support verify name and value
cfgfile: verify add section and entry result
The rte_cfgfile_add_section() and _add_entry()'s result were not
verified, so that potential errors may not be detected.
This commit adds the verification.
Cc: sta...@dpdk.org
Signed-off-by: Chengwen Feng
---
lib/cfgfile/rte_cfgfile.c | 19 ++-
1 file changed, 14 insertions(+),
This memchr() will never return NULL because rte_cfgfile_load() function
will skip lines without useful content.
Fixes: 74e0d3a17461 ("cfgfile: fix null pointer dereference in parsing")
Cc: sta...@dpdk.org
Signed-off-by: Chengwen Feng
---
lib/cfgfile/rte_cfgfile.c | 6 --
1 file changed, 6
This patch supports verify section's name, entry's name and entry's
value validity.
Cc: sta...@dpdk.org
Signed-off-by: Chengwen Feng
---
lib/cfgfile/rte_cfgfile.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/lib/cfgfile/rte_cfgfile.c b/lib/cfgfile/rte_cfgfile.c
index d
The cfgfile supports duplicate section name and entry name when parsing
config file, which may confused and hard to debug when accidentally set
duplicate name.
So add unique name flag, it will treat as error if encounter duplicate
section name or entry name.
Cc: sta...@dpdk.org
Signed-off-by: Ch
> -Original Message-
> From: Ferruh Yigit
> Sent: Saturday, February 10, 2024 12:06 AM
> To: Wei Hu ; andrew.rybche...@oktetlabs.ru; Thomas
> Monjalon ; Long Li
> Cc: dev@dpdk.org
> Subject: Re: [PATCH 1/1] net/mana: add vlan tagging support
>
> On 2/9/2024 8:52 AM, Wei Hu wrote:
> > F
> -Original Message-
> From: Long Li
> Sent: Saturday, February 10, 2024 2:48 AM
> To: Wei Hu ; ferruh.yi...@amd.com;
> andrew.rybche...@oktetlabs.ru; Thomas Monjalon
> ; Alan Elder
> Cc: dev@dpdk.org
> Subject: RE: [PATCH 1/1] net/mana: add vlan tagging support
>
> > + if (
> On 2/17/2024 1:54 AM, Chaoyong He wrote:
> > Add the support of UDP fragmentation offload feature.
> >
> > Signed-off-by: Chaoyong He
> > Reviewed-by: Long Wu
> > Reviewed-by: Peng Zhang
>
> <...>
>
> > diff --git a/drivers/net/nfp/nfp_net_common.c
> > b/drivers/net/nfp/nfp_net_common.c
> >
59 matches
Mail list logo
