From: Alex Vesker
Align GRE, GTPU and VXLAN tunnel protocols to fail
in case the packet is already tunneled. Also use local
defines for protocol UDP ports for better layering of
mlx5dr API.
Fixes: c55c2bf35333 ("net/mlx5/hws: add definer layer")
Fixes: 5bf14a4beb1a ("net/mlx5/hws: support matchi
Add HWS support for both GENEVE and GENEVE TLV option headers.
This patchset supports:
- Add HW support for "RTE_FLOW_ITEM_TYPE_GENEVE" flow item.
- Add HW support for "RTE_FLOW_ITEM_TYPE_GENEVE_OPT" flow item.
- Add HW support for "RTE_FLOW_FIELD_GENEVE_VNI" for modify field flow
action.
-
General object types support is indicated in bitmap general_obj_types,
which is part of HCA capabilities list.
This bitmap was read multiple times, and each time a different bit was
extracted.
Previous patch optimized the code, reading the bitmap once into a local
variable, and then extracting the
GENEVE header has field named "opt_len" describing the total length of
all GENEVE options in 4-byte granularity.
In SW sreering implementation, only single option with single DW data is
supported. When matching on GENEVE option data is requested, matching on
"opt_len" field is added according to g
Query sample info operation might be used by either Geneve TLV option or
parse graph. Each operations can be supported regardless to another
according the configured profile.
In current implementation, the query sample info capability is turn on
only when parse graph operation is supported adding
Add GENEVE TLV sample fields in 2 places:
1. New HCA capabilities indicating GENEVE TLV sample is supported.
2. New fields in "mlx5_ifc_geneve_tlv_option_bits" structure.
Signed-off-by: Michael Baum
---
drivers/common/mlx5/mlx5_devx_cmds.c | 18 --
drivers/common/mlx5/mlx5_devx_c
The "flow_dv_translate_item_geneve_opt()" function is called twice per
flow rule, for either matcher focusing the mask or value focusing the
spec.
The spec is always provided and its field "option_len" indicates the
data size for both spec and mask. For using it, function has another
pointer "genev
Add to the "system_image_guid" filed describing uniquely the physical
device into "mlx5_hca_attr" structure.
Signed-off-by: Michael Baum
---
drivers/common/mlx5/mlx5_devx_cmds.c | 10 ++
drivers/common/mlx5/mlx5_devx_cmds.h | 1 +
2 files changed, 7 insertions(+), 4 deletions(-)
diff -
Add structure describing physical device, and manage physical device
global list.
Signed-off-by: Michael Baum
---
drivers/net/mlx5/mlx5.c | 77 -
drivers/net/mlx5/mlx5.h | 13 +++
2 files changed, 82 insertions(+), 8 deletions(-)
diff --git a/drivers/
Add a new structure "mlx5_devx_geneve_tlv_option_attr" to use in GENEVE
TLV option creation.
Later this structure will be used by GENEVE TLV option query operation
as well.
Signed-off-by: Michael Baum
---
drivers/common/mlx5/mlx5_devx_cmds.c | 28 +---
drivers/common/mlx5
This patch adds the GENEVE option sample ID into HCA attribute
structure.
This sample ID is used as the input of
"mlx5_devx_cmd_match_sample_info_query" function when flex parser
profile is 1.
Signed-off-by: Michael Baum
---
drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++
drivers/common/mlx5/mlx5_d
Move "mlx5_devx_cmd_match_sample_info_query()" function to use
"DEVX_DRV_LOG" in case of "devx_general_cmd" failure.
This macro contains syndrome report and used by all other function
calling "devx_general_cmd".
Signed-off-by: Michael Baum
---
drivers/common/mlx5/mlx5_devx_cmds.c | 9 -
Add a new function to query information about GENEVE TLV option parser.
Signed-off-by: Michael Baum
---
drivers/common/mlx5/mlx5_devx_cmds.c | 50
drivers/common/mlx5/mlx5_devx_cmds.h | 6
drivers/common/mlx5/mlx5_prm.h | 5 +++
drivers/common/mlx5/versi
Add a new API to expose GENEVE option FW information to DR layer.
Signed-off-by: Michael Baum
---
drivers/net/mlx5/mlx5_flow.h| 28 +
drivers/net/mlx5/mlx5_flow_geneve.c | 94 +
2 files changed, 122 insertions(+)
diff --git a/drivers/net/mlx5/mlx5_flo
From: Alex Vesker
In some cases we rely on header layout DW offset from FW caps,
this is done in case of future HW which may support current
flex fields natively, for this we must increase header layout to
255 DWs, which is the limit in current definer creation.
Signed-off-by: Alex Vesker
---
Add a new private API to create/destroy parser for GENEVE TLV options.
Signed-off-by: Michael Baum
Signed-off-by: Viacheslav Ovsiienko
---
doc/guides/nics/mlx5.rst| 122 ++
doc/guides/platform/mlx5.rst| 6 +-
drivers/net/mlx5/meson.build| 1 +
drivers/net/mlx
From: Alex Vesker
Add matching for GENEVE tunnel header.
Signed-off-by: Alex Vesker
---
drivers/net/mlx5/hws/mlx5dr_definer.c | 91 +++
drivers/net/mlx5/hws/mlx5dr_definer.h | 19 ++
2 files changed, 110 insertions(+)
diff --git a/drivers/net/mlx5/hws/mlx5dr_define
From: Alex Vesker
Add support for matching multiple GENEVE options. Options
header introduces new complexities since there can be more
than one GENEVE option. This requires us to track the total
DWs used for matching. Current code supports 8DWs for data
including type, class, length. There is als
Add GENEVE TLV parser support for mlx5 testpmd using following commands:
1. Add single option to the global option list:
testpmd> mlx5 set tlv_option class (class) type (type) len (length) \
offset (sample_offset) sample_len (sample_len) \
class_mode (ignore|fixed|match
Add support for matching and modifying GENEVE option for
FLEX_PARSER_PROFILE_ENABLE=0.
Before this patch it is supported when FLEX_PARSER_PROFILE_ENABLE=8 in
HW steering and when FLEX_PARSER_PROFILE_ENABLE=0 in SW steering.
Signed-off-by: Michael Baum
---
doc/guides/nics/mlx5.rst|
Add support for HWS GENEVE options for flex parser profile 0 and group
0.
This patch avoids parser creation during matcher/flow preparation for HW
steering (MLX5_SET_MATCHER_HS) and removes some logic done in
"flow_dev_geneve_tlv_option_resource_*()" functions when dv_flow_en=2.
After this change
Add support for GENEVE VNI field modification.
The support is only using HW steering.
Signed-off-by: Michael Baum
---
doc/guides/nics/mlx5.rst | 6 +-
doc/guides/rel_notes/release_24_03.rst | 1 +
drivers/net/mlx5/mlx5_flow_dv.c| 4 +---
drivers/net/mlx5/mlx5_flow_hw
Add HW steering support for both "RTE_FLOW_ITEM_TYPE_GENEVE" and
"RTE_FLOW_ITEM_TYPE_GENEVE_OPT".
Signed-off-by: Michael Baum
---
doc/guides/nics/mlx5.rst | 15 ++-
doc/guides/rel_notes/release_24_03.rst | 5 +
drivers/net/mlx5/mlx5_flow.h | 21 +
drivers/net/mlx5
Add support for GENEVE option fields modification.
Only fields configured in parser creation can be modified.
Signed-off-by: Michael Baum
---
doc/guides/nics/mlx5.rst | 4 +
doc/guides/rel_notes/release_24_03.rst | 3 +
drivers/net/mlx5/mlx5_flow.h | 21 +
driver
This patch series fix some resource leak problems in NFP PMD.
---
V2:
* Add a new commit to change the process private data.
* Fix the secondary process problem found by reviewer.
---
Chaoyong He (8):
net/nfp: modify the process private data
net/nfp: fix resource leak for device initializatio
Modify the process private data from 'struct nfp_cpp *' into
'struct nfp_pf_dev *'.
Signed-off-by: Chaoyong He
---
drivers/net/nfp/flower/nfp_flower.c | 2 +-
drivers/net/nfp/nfp_ethdev.c| 27 +--
drivers/net/nfp/nfp_net_common.c| 8 +---
3 files changed
Fix the resource leak problem in the abnormal logic of device
initialize function.
Fixes: f26e82397f6d ("net/nfp: implement xstats")
Fixes: 547137405be7 ("net/nfp: initialize IPsec related content")
Cc: james.hers...@corigine.com
Cc: chang.m...@corigine.com
Cc: sta...@dpdk.org
Signed-off-by: Chao
Fix the resource leak problem in the logic of CoreNIC firmware
application.
Fixes: 646ea79ce481 ("net/nfp: move PF functions into its own file")
Cc: sta...@dpdk.org
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
Reviewed-by: Peng Zhang
---
drivers/net/nfp/nfp_ethdev.c | 17 ++---
Fix the resource leak problem in the abnormal logic of PF initialize
function.
Fixes: 646ea79ce481 ("net/nfp: move PF functions into its own file")
Fixes: 8ba461d1eecc ("net/nfp: introduce keepalive mechanism for multiple PF")
Cc: peng.zh...@corigine.com
Cc: sta...@dpdk.org
Signed-off-by: Chaoyon
Fix the resource leak problem in the logic of flower firmware
application.
Fixes: e1124c4f8a45 ("net/nfp: add flower representor framework")
Cc: sta...@dpdk.org
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
Reviewed-by: Peng Zhang
---
.../net/nfp/flower/nfp_flower_representor.c | 89 +
Fix the resource leak problem in the exit logic of CoreNIC firmware.
Fixes: 646ea79ce481 ("net/nfp: move PF functions into its own file")
Cc: sta...@dpdk.org
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
Reviewed-by: Peng Zhang
---
drivers/net/nfp/nfp_ethdev.c | 91 +
Fix the resource leak problem in the exit logic of flower firmware.
Fixes: e1124c4f8a45 ("net/nfp: add flower representor framework")
Cc: sta...@dpdk.org
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
Reviewed-by: Peng Zhang
---
drivers/net/nfp/flower/nfp_flower.c | 73
Fix the resource leak problem in the logic of VF.
Fixes: f26e82397f6d ("net/nfp: implement xstats")
Cc: james.hers...@corigine.com
Cc: sta...@dpdk.org
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
Reviewed-by: Peng Zhang
---
drivers/net/nfp/nfp_ethdev_vf.c | 10 +++---
1 file changed, 7
For 'rte_pktmbuf_prefree_seg' function, 'rte_mbuf_refcnt_read(m) == 1'
and '__rte_mbuf_refcnt_update(m, -1) == 0' are the same cases where
mbuf's refcnt value should be 1. Thus we can simplify the code and
remove the redundant part.
Furthermore, according to [1], when the mbuf is stored inside the
When the vf starts to request multiple queues, the pf sends a reset
command to the vf. During the reset process, adminq sends an abnormal
message to pf for an unknown reason, and the resource request fails
resulting in a coredump.
This patch fixes the issue by checking the reset state before reset
> From: Feifei Wang [mailto:feifei.wa...@arm.com]
> Sent: Monday, 4 December 2023 03.39
>
> For 'rte_pktmbuf_prefree_seg' function, 'rte_mbuf_refcnt_read(m) == 1'
> and '__rte_mbuf_refcnt_update(m, -1) == 0' are the same cases where
> mbuf's refcnt value should be 1. Thus we can simplify the code
This commit supports verify argument config.
Signed-off-by: Chengwen Feng
---
lib/argparse/rte_argparse.c | 310 +++-
1 file changed, 309 insertions(+), 1 deletion(-)
diff --git a/lib/argparse/rte_argparse.c b/lib/argparse/rte_argparse.c
index bf14c56858..eff504a
Introduce argparse library (which was inspired by the thread [1]),
compared with getopt, it makes it easy to write user-friendly
command-like program.
Note: the [1/6] commit contains usage examples.
[1]
https://patchwork.dpdk.org/project/dpdk/patch/20231105054539.22303-2-fengcheng...@huawei.com/
This commit adds verify argument config test.
Signed-off-by: Chengwen Feng
---
app/test/meson.build | 1 +
app/test/test_argparse.c | 327 +++
2 files changed, 328 insertions(+)
create mode 100644 app/test/test_argparse.c
diff --git a/app/test/meson.bu
Replace getopt with argparse.
Signed-off-by: Chengwen Feng
---
examples/dma/dmafwd.c| 288 ++-
examples/dma/meson.build | 2 +-
2 files changed, 131 insertions(+), 159 deletions(-)
diff --git a/examples/dma/dmafwd.c b/examples/dma/dmafwd.c
index f27317a
This commit supports parse parameters which described in [argc, argv].
Signed-off-by: Chengwen Feng
---
lib/argparse/rte_argparse.c | 295 +++-
1 file changed, 292 insertions(+), 3 deletions(-)
diff --git a/lib/argparse/rte_argparse.c b/lib/argparse/rte_argparse.
Introduce argparse library (which was inspired by the thread [1]). This
commit provides public API and doc.
[1]
https://patchwork.dpdk.org/project/dpdk/patch/20231105054539.22303-2-fengcheng...@huawei.com/
Signed-off-by: Chengwen Feng
---
doc/api/doxy-api-index.md | 1 +
doc/api
This commit adds parse parameters test.
Signed-off-by: Chengwen Feng
---
app/test/test_argparse.c | 437 +++
1 file changed, 437 insertions(+)
diff --git a/app/test/test_argparse.c b/app/test/test_argparse.c
index d38ffb5775..3e4f4a2cfa 100644
--- a/app/test/
43 matches
Mail list logo
