Re: [PATCH v6 1/2] bus/pci: add function to enable/disable PASID

2023-11-07 Thread Ruifeng Wang
On 2023/11/6 9:16 AM, Chenbo Xia wrote: Sorry I missed all previous versions… +ARM guy Thanks for CCing. On Nov 4, 2023, at 02:29, Abdullah Sevincer wrote: External email: Use caution opening links or attachments This commit implements an internal api to enable and disable PASID for

[PATCH] net/cpfl: refactor flow parser

2023-11-07 Thread wenjing . qiao
From: Wenjing Qiao Use strncpy instead of memcpy for string copy and rename macro. Coverity issue: 405350 Fixes: 6cc97c9971d7 ("net/cpfl: build action mapping rules from JSON") Signed-off-by: Wenjing Qiao --- drivers/net/cpfl/cpfl_flow_parser.c | 34 +++-- drivers/net/cpfl/cpf

Re: [PATCH 00/11] Add basic flow support for corenic firmware

2023-11-07 Thread Ferruh Yigit
On 11/7/2023 1:42 AM, Chaoyong He wrote: >> On 11/3/2023 6:25 AM, Chaoyong He wrote: >>> Add the very basic rte_flow support for corenic firmware. >>> >>> Chaoyong He (11): >>> net/nfp: move some source files >>> drivers: add the structures and functions for flow offload >>> net/nfp: add the

RE: [PATCH 00/11] Add basic flow support for corenic firmware

2023-11-07 Thread Chaoyong He
> On 11/7/2023 1:42 AM, Chaoyong He wrote: > >> On 11/3/2023 6:25 AM, Chaoyong He wrote: > >>> Add the very basic rte_flow support for corenic firmware. > >>> > >>> Chaoyong He (11): > >>> net/nfp: move some source files > >>> drivers: add the structures and functions for flow offload > >>> n

Get up to speed with the latest DPDK Newsletter ⚡

2023-11-07 Thread DPDK
The latest developments, news, releases, events and highlights from the global DPDK community. View in browser (https://email.linuxfoundation.org/e3t/Ctc/RI+113/cZw--04/VWBP8Z97SzMnW23V82h3Cy0kzW50jS-p55xNdSN2x86ys5m_5PW7lCGcx6lZ3mQW5NtFDQ12zWhSW4Yf_Pc10597pW4CJdFn8y2njPW1Lmwkl8Qg8cmW2QS34x7R8yF

RE: [PATCH v2 1/2] bus/cdx: add support for devices without MSI

2023-11-07 Thread Agarwal, Nikhil
[AMD Official Use Only - General] Hi Nipun, > -Original Message- > > diff --git a/drivers/bus/cdx/cdx_vfio.c b/drivers/bus/cdx/cdx_vfio.c > > index 8a3ac0b995..8cac79782e 100644 > > --- a/drivers/bus/cdx/cdx_vfio.c > > +++ b/drivers/bus/cdx/cdx_vfio.c > > @@ -101,13 +101,12 @@ cdx_vfio_un

Re: Updating examples which use coremask parameters

2023-11-07 Thread Bruce Richardson
On Mon, Nov 06, 2023 at 09:37:31PM +, Konstantin Ananyev wrote: > > > > > > > > > looking to start a discussion and get some input here. > > > > > > > > There are a number of our examples in DPDK which still track core usage > > > > via > > > > a 64-bit bitmask, and, as such, cannot run on co

Re: [PATCH v3 0/2] app/testpmd: fix UDP cksum error for UFO enable

2023-11-07 Thread Ferruh Yigit
On 11/7/2023 4:11 AM, Huisong Li wrote: > 1. remove useless code. > 2. fix UDP cksum error for UFO enable. > For detail message, please see the commit log. > > --- > v3: > - separate the useless code from patch v2. > - fix some comments and use 'printf' to replace 'fprintf'. > > v2: add han

[PATCH] raw/cnxk_gpio: fix resource leak

2023-11-07 Thread Tomasz Duszynski
Fix resource leak. Coverity issue: 405118 Fixes: ef2a3f3b4c9e ("raw/cnxk_gpio: support multi-process") Signed-off-by: Tomasz Duszynski --- drivers/raw/cnxk_gpio/cnxk_gpio.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.c b/drivers/raw

[PATCH v6] net/ice: fix crash on closing representor ports

2023-11-07 Thread Mingjin Ye
The data resource in struct rte_eth_dev is cleared and points to NULL when the DCF port is closed. If the DCF representor port is closed after the DCF port is closed, a segmentation fault occurs because the representor port accesses the data resource released by the DCF port. This patch fixes thi

RE: [EXT] [dpdk-dev] [PATCH] common/cnxk: fix setting channel mask for SDP interfaces

2023-11-07 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: psathe...@marvell.com > Sent: Tuesday, November 7, 2023 12:10 PM > To: Nithin Kumar Dabilpuram ; Kiran Kumar > Kokkilagadda ; Sunil Kumar Kori > ; Satha Koteswara Rao Kottidi > ; Satheesh Paul Antonysamy > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [EXT] [

RE: [PATCH v6] net/ice: fix crash on closing representor ports

2023-11-07 Thread Zhang, Qi Z
> -Original Message- > From: Ye, MingjinX > Sent: Tuesday, November 7, 2023 6:12 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Ye, MingjinX > ; sta...@dpdk.org; Zhang, Qi Z > > Subject: [PATCH v6] net/ice: fix crash on closing representor ports > > The data resource in struct rte_eth_dev

RE: [PATCH] config/x86: config support for AMD EPYC processors

2023-11-07 Thread Konstantin Ananyev
> -Original Message- > From: Sivaprasad Tummala > Sent: Monday, September 25, 2023 4:10 PM > To: bruce.richard...@intel.com; konstantin.v.anan...@yandex.ru > Cc: dev@dpdk.org; Sivaprasad Tummala > Subject: [PATCH] config/x86: config support for AMD EPYC processors > > From: Sivaprasad

[PATCH v3 0/4] hash: add SVE support for bulk key lookup

2023-11-07 Thread Yoan Picchi
This patchset adds SVE support for the signature comparison in the cuckoo hash lookup and improves the existing NEON implementation. These optimizations required changes to the data format and signature of the relevant functions to support dense hitmasks (no padding) and having the primary and seco

[PATCH v3 2/4] hash: optimize compare signature for NEON

2023-11-07 Thread Yoan Picchi
Upon a successful comparison, NEON sets all the bits in the lane to 1 We can skip shifting by simply masking with specific masks. Signed-off-by: Yoan Picchi Reviewed-by: Ruifeng Wang Reviewed-by: Nathan Brown --- lib/hash/rte_cuckoo_hash.c | 16 +++- 1 file changed, 7 insertions(+)

[PATCH v3 1/4] hash: pack the hitmask for hash in bulk lookup

2023-11-07 Thread Yoan Picchi
Current hitmask includes padding due to Intel's SIMD implementation detail. This patch allows non Intel SIMD implementations to benefit from a dense hitmask. Signed-off-by: Yoan Picchi Reviewed-by: Ruifeng Wang Reviewed-by: Nathan Brown --- .mailmap | 2 + lib/hash/rte_cuck

[PATCH v3 3/4] test/hash: check bulk lookup of keys after collision

2023-11-07 Thread Yoan Picchi
This patch adds unit test for rte_hash_lookup_bulk(). It also update the test_full_bucket test to the current number of entries in a hash bucket. Signed-off-by: Yoan Picchi Signed-off-by: Harjot Singh Reviewed-by: Ruifeng Wang Reviewed-by: Nathan Brown --- app/test/test_hash.c | 99 ++

[PATCH v3 4/4] hash: add SVE support for bulk key lookup

2023-11-07 Thread Yoan Picchi
- Implemented SVE code for comparing signatures in bulk lookup. - Added Defines in code for SVE code support. - Optimise NEON code - New SVE code is ~5% slower than optimized NEON for N2 processor. Signed-off-by: Yoan Picchi Signed-off-by: Harjot Singh Reviewed-by: Nathan Brown Reviewed-by: Rui

RE: rte_timer_reset related issues in DPDK 20.05

2023-11-07 Thread Jayasvi Battu
TCS Confidential Hi Stephen, Thank you for your reply. Please find my answers inline. 1.Do you have threads fighting over timer? No , we are running the thread on only one core so there is no deadlock here. But as discussed earlier the thread is getting stuck in an infinite while loop with

RE: [PATCH] config/x86: config support for AMD EPYC processors

2023-11-07 Thread Konstantin Ananyev
> > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Monday, 6 November 2023 22.05 > > > > 17/10/2023 12:27, Morten Brørup: > > > > >> From: Tummala, Sivaprasad > > > > >>> From: David Marchand > > > > >>> On Mon, Sep 25, 2023 at 5:11 PM Sivaprasad Tummala > > > > From: Siva

RE: [PATCH] config/x86: config support for AMD EPYC processors

2023-11-07 Thread Morten Brørup
> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Tuesday, 7 November 2023 14.14 > > > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > Sent: Monday, 6 November 2023 22.05 > > > > > > 17/10/2023 12:27, Morten Brørup: > > > > > >> From: Tummala, Sivaprasad > >

Re: [PATCH] raw/cnxk_gpio: fix resource leak

2023-11-07 Thread Jerin Jacob
On Tue, Nov 7, 2023 at 3:30 PM Tomasz Duszynski wrote: > > Fix resource leak. > > Coverity issue: 405118 > Fixes: ef2a3f3b4c9e ("raw/cnxk_gpio: support multi-process") > > Signed-off-by: Tomasz Duszynski Applied to dpdk-next-net-mrvl/for-next-net. Thanks

Re: [PATCH 2/2] crypto/openssl: remove unnecessary NULL checks before free

2023-11-07 Thread Ji, Kai
Acked-by: Kai Ji From: Stephen Hemminger Sent: 02 November 2023 23:02 To: dev@dpdk.org Cc: Stephen Hemminger ; Ji, Kai Subject: [PATCH 2/2] crypto/openssl: remove unnecessary NULL checks before free Found with nullfree.cocci Signed-off-by: Stephen Hemminger -

Re: [PATCH v2 2/2] bus/cdx: add bus master enable/disable APIs

2023-11-07 Thread Gupta, Nipun
On 11/3/2023 4:50 PM, Shubham Rohila wrote: Define rte_cdx_vfio_bm_enable and rte_cdx_vfio_bm_disable to enable or disable bus master functionality for cdx devices. Signed-off-by: Shubham Rohila --- v2 - Fix indentations and alphabetical orderings. - Wrap checks in parenthesis for read

Re: [PATCH v2 1/2] bus/cdx: add support for devices without MSI

2023-11-07 Thread Gupta, Nipun
On 11/3/2023 4:50 PM, Shubham Rohila wrote: From: Nikhil Agarwal Update the cleanup routine for cdx device to support device without MSI. Also, set vfio_dev_fd for such devices This fd can be used for BME reload operations. Signed-off-by: Nikhil Agarwal Signed-off-by: Shubham Rohila Ack

RE: [PATCH] config/x86: config support for AMD EPYC processors

2023-11-07 Thread Konstantin Ananyev
> > > > > > >> From: Tummala, Sivaprasad > > > > > > >>> From: David Marchand > > > > > > >>> On Mon, Sep 25, 2023 at 5:11 PM Sivaprasad Tummala > > > > > > From: Sivaprasad Tummala > > > > > > > > > > > > By default, max lcores are limited to 128 for x86 > > platforms. > > > > >

Re: [PATCH v5 03/23] dts: add basic developer docs

2023-11-07 Thread Yoan Picchi
On 11/6/23 17:15, Juraj Linkeš wrote: Expand the framework contribution guidelines and add how to document the code with Python docstrings. Signed-off-by: Juraj Linkeš --- doc/guides/tools/dts.rst | 73 1 file changed, 73 insertions(+) diff --git a/d

[PATCH] net/mlx5: fix the validation of the sample encap action

2023-11-07 Thread Jiawei Wang
The flow sample/mirror action includes sub-actions for the duplicated packet. In SW steering case, dv_flow_en=1, there is a FW limitation that forces configuring also encap action when port action for the wire port is configured in the duplicated packet's sub-actions. The driver did a wrong valida

[PATCH] doc: clarify mirroring limitations in mlx5 guide

2023-11-07 Thread Jiawei Wang
Update the description of flow mirroring to make clear what are the limitations of the mlx5 driver. Signed-off-by: Jiawei Wang Acked-by: Thomas Monjalon --- doc/guides/nics/mlx5.rst | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/doc/guides/nics/mlx5.

[PATCH] eal/x86: fix segfaults in waitpkg power intrinsics

2023-11-07 Thread Bruce Richardson
From: David Hunt The code was recently enhanced to allow the use of the waitpkg intrinsics rather than the raw assembly in the rte_power functions. However, the parameters to the intrinsics, while compiling fine, were incorrect, and would segfault when run on the appropriate hardware. This patch

[PATCH] event/dlb2: fix name check in selftest

2023-11-07 Thread Bruce Richardson
When running the dlb2 selftests the driver name check was incorrect, causing all checks to be skipped for a dlb2 device. We use the "event_dlb2" only as a prefix check, as driver may have suffixes, e.g. appear as "event_dlb2_pf". Fixes: 6f1b82886e8a ("event/dlb2: add self-tests") Cc: sta...@dpdk.o

[PATCH] test/eventdev: avoid configuring port or queue twice

2023-11-07 Thread Bruce Richardson
In the basic sanity tests of eventdev for queue and port setup, queue 0 was configured separately before running a loop to configure the rest of the queues. This loop started from 0, so reconfigured queue 0, and a similar reconfiguration happens with port 0 in the later port setup test. While most

Re: [PATCH] dumpcap: fix mbuf pool ring type

2023-11-07 Thread Stephen Hemminger
On Tue, 7 Nov 2023 08:22:37 +0100 Morten Brørup wrote: > > > > > > Or are you saying that if they want to use dumpcap, they must choose > > a thread safe pool type for their application (regardless if the > > application is single-threaded or not)? > > > > There is no command line of EAL natur

Re: [PATCH 00/11] Add basic flow support for corenic firmware

2023-11-07 Thread Patrick Robb
Recheck-request: iol-compile-amd64-testing, iol-unit-amd64-testing Weird. I will dig up the original job which polled for the previous retest request, and see whether this new one runs through properly.

Re: [PATCH] dumpcap: fix mbuf pool ring type

2023-11-07 Thread Stephen Hemminger
On Tue, 7 Nov 2023 08:22:37 +0100 Morten Brørup wrote: > > > Or are you saying that if they want to use dumpcap, they must choose > > a thread safe pool type for their application (regardless if the > > application is single-threaded or not)? > > > > There is no command line of EAL nature in d

Re: [PATCH 00/11] Add basic flow support for corenic firmware

2023-11-07 Thread Patrick Robb
Sorry, now I understand what is causing confusion. When a retest is requested, that retest is done on the original dpdk artifact we created for the patchseries. We don't pull again, re-apply, and then rerun the testing. I think that is the behavior you were expecting, Ferruh. We have discussed whe

RE: [PATCH] event/dlb2: fix name check in selftest

2023-11-07 Thread Sevincer, Abdullah
Acked-by: Abdullah Sevincer

RE: [EXT] [PATCH] test/eventdev: avoid configuring port or queue twice

2023-11-07 Thread Pavan Nikhilesh Bhagavatula
> In the basic sanity tests of eventdev for queue and port setup, queue 0 > was configured separately before running a loop to configure the rest of > the queues. This loop started from 0, so reconfigured queue 0, and a > similar reconfiguration happens with port 0 in the later port setup > test.

RE: [PATCH] dumpcap: fix mbuf pool ring type

2023-11-07 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, 7 November 2023 17.41 > > On Tue, 7 Nov 2023 08:22:37 +0100 > Morten Brørup wrote: > > > > > > > > > Or are you saying that if they want to use dumpcap, they must > choose > > > a thread safe pool type for their appli

Re: [PATCH v5 02/23] dts: add docstring checker

2023-11-07 Thread Yoan Picchi
On 11/6/23 17:15, Juraj Linkeš wrote: Python docstrings are the in-code way to document the code. The docstring checker of choice is pydocstyle which we're executing from Pylama, but the current latest versions are not complatible due to [0], so pin the pydocstyle version to the latest working ve

[PATCH v2 0/5] use abstracted bit count functions

2023-11-07 Thread Tyler Retzlaff
The first set of conversions missed the long 'l' versions of the builtins that were being used. This series completes the conversion of remaining libraries from __builtin_ctzl and __builtin_clzl. v2: be explicit and use appropriate 32-bit and 64-bit leading and trailing counting functions depe

[PATCH v2 3/5] member: use abstracted bit count functions

2023-11-07 Thread Tyler Retzlaff
Use rte_ctz32 or rte_ctz64 respectively instead of __builtin_ctzl depending on the resultant type of the expression passed as an argument Fixes: 18898c4d06f9 ("eal: use abstracted bit count functions") Signed-off-by: Tyler Retzlaff --- lib/member/rte_member_vbf.c | 12 ++-- lib/member/r

[PATCH v2 2/5] hash: use abstracted bit count functions

2023-11-07 Thread Tyler Retzlaff
Use rte_ctz32 or rte_ctz64 respectively instead of __builtin_ctzl depending on the resultant type of the expression passed as an argument Fixes: 18898c4d06f9 ("eal: use abstracted bit count functions") Signed-off-by: Tyler Retzlaff --- lib/hash/rte_cuckoo_hash.c | 16 1 file ch

[PATCH v2 4/5] rcu: use abstracted bit count functions

2023-11-07 Thread Tyler Retzlaff
Use rte_ctz32 or rte_ctz64 respectively instead of __builtin_ctzl depending on the resultant type of the expression passed as an argument Fixes: 18898c4d06f9 ("eal: use abstracted bit count functions") Signed-off-by: Tyler Retzlaff --- lib/rcu/rte_rcu_qsbr.c | 4 ++-- lib/rcu/rte_rcu_qsbr.h | 2

[PATCH v2 1/5] distributor: use abstracted bit count functions

2023-11-07 Thread Tyler Retzlaff
Use rte_ctz32 or rte_ctz64 respectively instead of __builtin_ctzl depending on the resultant type of the expression passed as an argument Fixes: 18898c4d06f9 ("eal: use abstracted bit count functions") Signed-off-by: Tyler Retzlaff --- lib/distributor/rte_distributor_single.c | 2 +- 1 file cha

[PATCH v2 5/5] table: use abstracted bit count functions

2023-11-07 Thread Tyler Retzlaff
Use rte_clz32 or rte_clz64 respectively instead of __builtin_clzl depending on the resultant type of the expression passed as an argument Use rte_ctz32 or rte_ctz64 respectively instead of __builtin_ctzl depending on the resultant type of the expression passed as an argument Fixes: 18898c4d06f9 (

RFC acceptable handling of VLAs across toolchains

2023-11-07 Thread Tyler Retzlaff
hi folks, i'm seeking advice. we have use of VLAs which are now optional in standard C. some toolchains provide a conformant implementation and msvc does not (and never will). we seem to have a few options, just curious about what people would prefer. * use alloca * use dynamically allocated st

[PATCH] eal: fix msvc conditional compile of rte atomic thread fence

2023-11-07 Thread Tyler Retzlaff
MSVC does not expose legacy atomics. When the legacy atomics were excluded rte_atomic_thread_fence was also unintentionally excluded Adjust the conditional compilation check to expose rte_atomic_thread_fence. Fixes: 27da6a123414 ("eal: hide legacy atomics API for MSVC") Signed-off-by: Tyler Retz

Re: [PATCH 00/11] Add basic flow support for corenic firmware

2023-11-07 Thread Ferruh Yigit
On 11/7/2023 5:04 PM, Patrick Robb wrote: > Sorry, now I understand what is causing confusion. When a retest is > requested, that retest is done on the original dpdk artifact we created > for the patchseries. We don't pull again, re-apply, and then rerun the > testing. I think that is the behavior

Re: [PATCH 00/11] Add basic flow support for corenic firmware

2023-11-07 Thread Patrick Robb
On Tue, Nov 7, 2023 at 3:19 PM Ferruh Yigit wrote: > > I am also not sure if this is the common usecase, lets record the need, > we can decide what to support based on it. > > > And as a generic approach, what about following syntax: > Recheck-request,attribute=value: ... > > And for above case,

[PATCH] mbuf: remove use of now unnecessary extension keyword

2023-11-07 Thread Tyler Retzlaff
Remove the use of __extension__ on nameless struct and union members they are no longer necessary as they are standard in C11 Signed-off-by: Tyler Retzlaff --- lib/mbuf/rte_mbuf_core.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h index

Re: [PATCH] mbuf: remove use of now unnecessary extension keyword

2023-11-07 Thread Tyler Retzlaff
this series will be withdrawn since the keyword was also applied to the bitfields. sorry for the noise On Tue, Nov 07, 2023 at 02:14:44PM -0800, Tyler Retzlaff wrote: > Remove the use of __extension__ on nameless struct and union members > they are no longer necessary as they are standard in C11

[PATCH v3 0/7] use abstracted bit count functions

2023-11-07 Thread Tyler Retzlaff
The first set of conversions missed the long 'l' versions of the builtins that were being used. This series completes the conversion of remaining libraries from __builtin_ctzl, __builtin_clzl and __builtin_popcountl. v3: * add missing include of rte_bitops.h * add 2 patches to cover use of __b

[PATCH v3 1/7] distributor: use abstracted bit count functions

2023-11-07 Thread Tyler Retzlaff
Use rte_ctz32 or rte_ctz64 respectively instead of __builtin_ctzl depending on the resultant type of the expression passed as an argument Fixes: 18898c4d06f9 ("eal: use abstracted bit count functions") Signed-off-by: Tyler Retzlaff --- lib/distributor/rte_distributor_single.c | 2 +- 1 file cha

[PATCH v3 4/7] rcu: use abstracted bit count functions

2023-11-07 Thread Tyler Retzlaff
Use rte_ctz32 or rte_ctz64 respectively instead of __builtin_ctzl depending on the resultant type of the expression passed as an argument Fixes: 18898c4d06f9 ("eal: use abstracted bit count functions") Signed-off-by: Tyler Retzlaff --- lib/rcu/rte_rcu_qsbr.c | 4 ++-- lib/rcu/rte_rcu_qsbr.h | 2

[PATCH v3 3/7] member: use abstracted bit count functions

2023-11-07 Thread Tyler Retzlaff
Use rte_ctz32 or rte_ctz64 respectively instead of __builtin_ctzl depending on the resultant type of the expression passed as an argument Fixes: 18898c4d06f9 ("eal: use abstracted bit count functions") Signed-off-by: Tyler Retzlaff --- lib/member/rte_member_vbf.c | 12 ++-- lib/member/r

[PATCH v3 2/7] hash: use abstracted bit count functions

2023-11-07 Thread Tyler Retzlaff
Use rte_ctz32 or rte_ctz64 respectively instead of __builtin_ctzl depending on the resultant type of the expression passed as an argument Fixes: 18898c4d06f9 ("eal: use abstracted bit count functions") Signed-off-by: Tyler Retzlaff --- lib/hash/rte_cuckoo_hash.c | 16 1 file ch

[PATCH v3 7/7] hash: use abstracted bit count functions

2023-11-07 Thread Tyler Retzlaff
Use rte_popcount64 instead of __builtin_popcountl where the argument type passed to the intrinsic was 64-bits. Signed-off-by: Tyler Retzlaff --- lib/hash/rte_cuckoo_hash.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_has

[PATCH v3 6/7] distributor: use abstracted bit count functions

2023-11-07 Thread Tyler Retzlaff
Use rte_popcount64 instead of __builtin_popcountl where the argument type passed to the intrinsic was 64-bits. Signed-off-by: Tyler Retzlaff --- lib/distributor/rte_distributor_single.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/distributor/rte_distributor_single.c

[PATCH v3 5/7] table: use abstracted bit count functions

2023-11-07 Thread Tyler Retzlaff
Use rte_clz32 or rte_clz64 respectively instead of __builtin_clzl depending on the resultant type of the expression passed as an argument Use rte_ctz32 or rte_ctz64 respectively instead of __builtin_ctzl depending on the resultant type of the expression passed as an argument Fixes: 18898c4d06f9 (

[PATCH] ethdev: account for smaller MTU when setting default

2023-11-07 Thread Joshua Washington
Currently, if not specified in the user configuration, rte_eth_dev_configure() sets the MTU of the device to RTE_EHTER_MTU. This value could potentially be larger than the MTU that the device supports. This change updates the configured MTU to be the minimum of the maximum suported MTU and the defa

Re: [PATCH v3 6/7] Added link to Getting Started Guide in index.rst

2023-11-07 Thread Dave Young
I can have it added in patch 1. In the v3 patchset it's added in 0006-Added-link-to-Getting-Started-Guide-in-index.rst.patch Thanks! David Young Professional Copywriter/Technical Writer Young Copy +1 (678) 500-9550 https://www.youngcopy.com On Fri, Nov 3, 2023 at 10:22 AM Bruce Richardson wrote

Re: [PATCH v3 6/7] Added link to Getting Started Guide in index.rst

2023-11-07 Thread Dave Young
Hi Bruce, Disregard my previous email. It looks like getting_started_guide/index was somehow deleted but I've added it back. Thanks! David Young Professional Copywriter/Technical Writer Young Copy +1 (678) 500-9550 https://www.youngcopy.com On Tue, Nov 7, 2023 at 8:47 PM Dave Young wrote: > I

Re: [PATCH v2 7/7] doc: testpmd support event handling section

2023-11-07 Thread lihuisong (C)
在 2023/11/6 20:39, fengchengwen 写道: Hi Huisong, On 2023/11/6 17:28, lihuisong (C) wrote: 在 2023/10/20 18:07, Chengwen Feng 写道: Add new section of event handling, which documented the ethdev and device events. Signed-off-by: Chengwen Feng ---   doc/guides/testpmd_app_ug/event_handling.rst

Re: [PATCH v3 7/7] doc: testpmd support event handling section

2023-11-07 Thread lihuisong (C)
Acked-by: Huisong Li 在 2023/11/6 21:11, Chengwen Feng 写道: Add new section of event handling, which documented the ethdev and device events. Signed-off-by: Chengwen Feng --- doc/guides/testpmd_app_ug/event_handling.rst | 81 doc/guides/testpmd_app_ug/index.rst

Re: [PATCH v7 0/3] add telemetry cmds for ring

2023-11-07 Thread lihuisong (C)
lgtm, for series, Acked-by: Huisong Li 在 2023/7/4 17:04, Jie Hai 写道: This patch set supports telemetry cmd to list rings and dump information of a ring by its name. v1->v2: 1. Add space after "switch". 2. Fix wrong strlen parameter. v2->v3: 1. Remove prefix "rte_" for static function. 2. Add

Re: [PATCH] eal/x86: fix segfaults in waitpkg power intrinsics

2023-11-07 Thread Tyler Retzlaff
On Tue, Nov 07, 2023 at 04:19:01PM +, Bruce Richardson wrote: > From: David Hunt > > The code was recently enhanced to allow the use of the waitpkg > intrinsics rather than the raw assembly in the rte_power functions. > However, the parameters to the intrinsics, while compiling fine, were > i

Re: RFC acceptable handling of VLAs across toolchains

2023-11-07 Thread Tyler Retzlaff
On Tue, Nov 07, 2023 at 06:31:14PM -0800, Stephen Hemminger wrote: > On Tue, 7 Nov 2023 11:32:20 -0800 > Tyler Retzlaff wrote: > > > hi folks, > > > > i'm seeking advice. we have use of VLAs which are now optional in > > standard C. some toolchains provide a conformant implementation and msvc >

[dpdk-dev] [PATCH] common/cnxk: add ROC API to get MKEX capability

2023-11-07 Thread psatheesh
From: Satheesh Paul Added ROC API to get MKEX capability. Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar K --- drivers/common/cnxk/roc_npc.c | 24 drivers/common/cnxk/roc_npc.h | 1 + drivers/common/cnxk/version.map | 1 + 3 files changed, 26 insertions(+

[Bug 1308] meson_tests/driver:link_bonding_rssconf_autotest test failed

2023-11-07 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1308 Bug ID: 1308 Summary: meson_tests/driver:link_bonding_rssconf_autotest test failed Product: DPDK Version: 23.11 Hardware: x86 OS: Linux Status: UNCONFIR

[PATCH 1/5] net/hns3: fix sync mailbox failure forever

2023-11-07 Thread Jie Hai
From: Dengdui Huang Currently, hns3 VF driver uses the following points to match the response and request message for the mailbox synchronous message between VF and PF. 1. req_msg_data which is consist of message code and subcode, is used to match request and response. 2. head means the number

[PATCH 0/5] net/hns3: fix and refactor mailbox code

2023-11-07 Thread Jie Hai
This patchset fixes failure on sync mailbox and refactors some codes on mailbox. Dengdui Huang (5): net/hns3: fix sync mailbox failure forever net/hns3: refactor VF mailbox message struct net/hns3: refactor PF mailbox message struct net/hns3: refactor send mailbox function net/hns3: refa

[PATCH 4/5] net/hns3: refactor send mailbox function

2023-11-07 Thread Jie Hai
From: Dengdui Huang The 'hns3_send_mbx_msg' function has following problem: 1. the name is vague, missing caller indication 2. too many input parameters because the filling messages are placed in commands the send command. Therefore, a common interface is encapsulated to fill in the mailbox m

[PATCH 3/5] net/hns3: refactor PF mailbox message struct

2023-11-07 Thread Jie Hai
From: Dengdui Huang The data region in PF to VF mbx memssage command is used to communicate with VF driver. And this data region exists as an array. As a result, some complicated feature commands, like mailbox response, link change event, close promisc mode, reset request and update pvid state, h

[PATCH 2/5] net/hns3: refactor VF mailbox message struct

2023-11-07 Thread Jie Hai
From: Dengdui Huang The data region in VF to PF mbx memssage command is used to communicate with PF driver. And this data region exists as an array. As a result, some complicated feature commands, like setting promisc mode, map/unmap ring vector and setting VLAN id, have to use magic number to se

[PATCH 5/5] net/hns3: refactor handle mailbox function

2023-11-07 Thread Jie Hai
From: Dengdui Huang The mailbox messages of the PF and VF are processed in the same function. The PF and VF call the same function to process the messages. This code is excessive coupling and isn't good for maintenance. Therefore, this patch separates the interfaces that handle PF mailbox message

Re: [RFC] eal: RFC to refactor rte_eal_init into sub-functions

2023-11-07 Thread Rahul Gupta
On (11/02/23 11:37), Stephen Hemminger wrote: > Date: Thu, 2 Nov 2023 11:37:59 -0700 > From: Stephen Hemminger > To: Rahul Gupta > Cc: dev@dpdk.org, tho...@monjalon.net, sovar...@linux.microsoft.com, > ok...@kernel.org, sujithsan...@microsoft.com, > sowmini.varad...@microsoft.com, rahulrgupt...

[PATCH v1 1/1] devtools: update sources in build tags script

2023-11-07 Thread Srikanth Yalavarthi
As part of deprecating kmods meson option, 'kernel/linux' directory is removed from the repository. This patch removes non-existing 'kernel/linux' directory from linux_sources of build tags script. Signed-off-by: Srikanth Yalavarthi --- devtools/build-tags.sh | 1 - 1 file changed, 1 deletion(-

[PATCH v2] ethdev: account for smaller MTU when setting default

2023-11-07 Thread Joshua Washington
Currently, if not specified in the user configuration, rte_eth_dev_configure() sets the MTU of the device to RTE_EHTER_MTU. This value could potentially be larger than the MTU that the device supports. This change updates the configured MTU to be the minimum of the maximum suported MTU and the defa