[PATCH] examples/l2fwd-event: fix missing unlock issue

The function l2fwd_get_free_event_port acquires a lock on 'evt_rsrc->evp.lock' at the beginning. This lock is expected to be released at the first return statement, when no free event port is available. Fixes: 080f57bceca4 ("examples/l2fwd-event: add eventdev main loop") Cc: sta...@dpdk.org Signe

[PATCH] examples/l3fwd: fix missing unlock issue

The function l3fwd_get_free_event_port acquires a lock on 'evt_rsrc->evp.lock' at the beginning. This lock is expected to be released at the first return statement, when no free event port is available. Fixes: aaf58cb85b62 ("examples/l3fwd: add event port and queue setup") Cc: sta...@dpdk.org Sig

Re: [PATCH v6 1/2] bus/pci: add function to enable/disable PASID

On Sat, Nov 4, 2023 at 4:47 AM Abdullah Sevincer wrote: > > This commit implements an internal api to enable and disable PASID for > a device e.g. device driver event/dlb2. git comment can be reworded when apply. > > For kernels when PASID enabled by default it breaks DLB functionality, > hence

[PATCH] net/sfc: fix null dereference in syslog

When ctx->sa is null, sfc_err(ctx->sa, ...) will triger a null dereference in the macro of sfc_err. Use SFC_GENERIC_LOG(ERR, ...) to avoid that. Fixes: 44db08d53be3 ("net/sfc: maintain controller to EFX interface mapping") Cc: sta...@dpdk.org Signed-off-by: Weiguo Li --- drivers/net/sfc/sfc_eth

RE: [EXT] [PATCH] examples/l2fwd-event: fix missing unlock issue

> -Original Message- > From: Weiguo Li > Sent: Saturday, November 4, 2023 12:52 PM > To: Sunil Kumar Kori ; Pavan Nikhilesh Bhagavatula > > Cc: dev@dpdk.org; sta...@dpdk.org; Weiguo Li > Subject: [EXT] [PATCH] examples/l2fwd-event: fix missing unlock issue > > External Email > > ---

Re: [PATCH v6 1/2] bus/pci: add function to enable/disable PASID

04/11/2023 08:32, Jerin Jacob: > On Sat, Nov 4, 2023 at 4:47 AM Abdullah Sevincer > wrote: > > > > This commit implements an internal api to enable and disable PASID for > > a device e.g. device driver event/dlb2. > > git comment can be reworded when apply. What do you mean Jerin? > > For kern

Re: [PATCH v6 1/2] bus/pci: add function to enable/disable PASID

On Fri, Nov 03, 2023 at 01:29:32PM -0500, Abdullah Sevincer wrote: > This commit implements an internal api to enable and disable PASID for > a device e.g. device driver event/dlb2. > > For kernels when PASID enabled by default it breaks DLB functionality, > hence disabling PASID is required for D

RE: [dpdk-dev] [PATCH] ring: fix unaligned memory access on aarch32

> -Original Message- > From: Morten Brørup > Sent: Friday, November 3, 2023 7:04 PM > To: Phil Yang ; Honnappa Nagarahalli > ; Ruifeng Wang > ; dev@dpdk.org > Cc: david.march...@redhat.com; olivier.m...@6wind.com; Dharmik Jayesh > Thakkar ; Gavin Hu > ; nd ; andrew.rybche...@oktetlabs.r

RE: [dpdk-dev] [PATCH] ring: fix unaligned memory access on aarch32

> From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Saturday, 4 November 2023 17.32 > > > From: Morten Brørup > > Sent: Friday, November 3, 2023 7:04 PM > > > > I have for a long time now wondered why the ring functions for > > enqueue/dequeue of 64-bit objects supports una

[RFC] mempool: CPU cache aligning mempool driver accesses

I tried a little experiment, which gave a 25 % improvement in mempool perf tests for long bursts (n_get_bulk=32 n_put_bulk=32 n_keep=512 constant_n=0) on a Xeon E5-2620 v4 based system. This is the concept: If all accesses to the mempool driver goes through the mempool cache, we can ensure that t

Re: [PATCH v6 1/2] bus/pci: add function to enable/disable PASID

On Sat, Nov 4, 2023 at 7:31 PM Bruce Richardson wrote: > > On Fri, Nov 03, 2023 at 01:29:32PM -0500, Abdullah Sevincer wrote: > > This commit implements an internal api to enable and disable PASID for > > a device e.g. device driver event/dlb2. > > > > For kernels when PASID enabled by default it

Re: [PATCH v6 1/2] bus/pci: add function to enable/disable PASID

On Sat, Nov 4, 2023 at 2:49 PM Thomas Monjalon wrote: > > 04/11/2023 08:32, Jerin Jacob: > > On Sat, Nov 4, 2023 at 4:47 AM Abdullah Sevincer > > wrote: > > > > > > This commit implements an internal api to enable and disable PASID for > > > a device e.g. device driver event/dlb2. > > > > git com

[PATCH v4 1/5] kvargs: add one new process API

The rte_kvargs_process() was used to handle key=value (e.g. socket_id=0), it also supports to handle only-key (e.g. socket_id). But many drivers's callback can only handle key=value, it will segment fault if handles only-key. so the patchset [1] was introduced. Because the patchset [1] modified to

[PATCH v4 0/5] fix segment fault when parse args

The rte_kvargs_process() was used to parse key-value (e.g. socket_id=0), it also supports to parse only-key (e.g. socket_id). But many drivers's callback can only handle key-value, it will segment fault if handles only-key. so the patchset [1] was introduced. Because the patchset [1] modified too

[PATCH v4 5/5] net/mvneta: fix possible out-of-bounds write

The mvneta_ifnames_get() function will save 'iface' value to ifnames, it will out-of-bounds write if passed many iface pairs (e.g. 'iface=xxx,iface=xxx,...'). Fixes: 4ccc8d770d3b ("net/mvneta: add PMD skeleton") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Acked-by: Ferruh Yigit --- driver

[PATCH v4 2/5] net/sfc: use new API to parse kvargs

The sfc_kvargs_process() and sfc_efx_dev_class_get() function could handle both key=value and only-key, so they should use rte_kvargs_process_opt() instead of rte_kvargs_process() to parse. Signed-off-by: Chengwen Feng --- drivers/common/sfc_efx/sfc_efx.c | 4 ++-- drivers/net/sfc/sfc_kvargs.c

[PATCH v4 3/5] net/tap: use new API to parse kvargs

Some kvargs could be key=value or only-key, it should use rte_kvargs_process_opt() instead of rte_kvargs_process() to handle these kvargs. Signed-off-by: Chengwen Feng --- drivers/net/tap/rte_eth_tap.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/tap

[PATCH v4 4/5] common/nfp: use new API to parse kvargs

The nfp_parse_class_options() function could handle both key=value and only-key, so it should use rte_kvargs_process_opt() instead of rte_kvargs_process() to parse. Signed-off-by: Chengwen Feng --- drivers/common/nfp/nfp_common_pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) dif

Re: [PATCH v3 0/5] fix segment fault when parse args

Hi Ferruh, On 2023/11/3 21:41, Ferruh Yigit wrote: > On 11/3/2023 7:38 AM, Chengwen Feng wrote: >> The rte_kvargs_process() was used to parse key-value (e.g. socket_id=0), >> it also supports to parse only-key (e.g. socket_id). But many drivers's >> callback can only handle key-value, it will segm

Re: [PATCH v3 1/5] kvargs: add one new process API

Hi Ferruh, On 2023/11/3 21:09, Ferruh Yigit wrote: > On 11/3/2023 7:38 AM, Chengwen Feng wrote: >> The rte_kvargs_process() was used to parse key-value (e.g. socket_id=0), >> it also supports to parse only-key (e.g. socket_id). But many drivers's >> callback can only handle key-value, it will segm

Re: [PATCH v3 2/5] net/af_packet: use new API to parse kvargs

Hi Ferruh, On 2023/11/3 21:11, Ferruh Yigit wrote: > On 11/3/2023 7:38 AM, Chengwen Feng wrote: >> This driver don't care about the 'iface' value, it should use >> rte_kvargs_process_opt() instead of rte_kvargs_process() to parse. >> >> Signed-off-by: Chengwen Feng >> --- >> drivers/net/af_packe

Re: [PATCH v3 4/5] net/tap: use new API to parse kvargs

Hi Ferruh, Thanks for deepin, both fix in v4. On 2023/11/3 21:34, Ferruh Yigit wrote: > On 11/3/2023 7:38 AM, Chengwen Feng wrote: >> This driver could handles both key=value and only-key kvargs, so it >> should use rte_kvargs_process_opt() instead of rte_kvargs_process() to >> parse. >> >> Sig