On 9/30/23 03:00, Andrey Ignatov wrote:
vhost device doesn't report TX errors what complicates debugging of
dropped packets. Add oerrors to port stats.
- before (testpmd `show port stats`):
TX-packets: 18328512 TX-errors: 0 TX-bytes: 1173024768
- after:
TX-packets: 1737728
On Thu, Oct 5, 2023 at 6:52 PM Bruce Richardson
wrote:
>
> On Thu, Oct 05, 2023 at 06:41:34PM +0530, Jerin Jacob wrote:
> > On Thu, Oct 5, 2023 at 6:01 PM Bruce Richardson
> > wrote:
> > >
> > > On Thu, Oct 05, 2023 at 12:51:00PM +0100, Bruce Richardson wrote:
> > > > The event structure in DPDK
On Mon, Sep 25, 2023 at 5:11 PM Sivaprasad Tummala
wrote:
>
> From: Sivaprasad Tummala
>
> By default, max lcores are limited to 128 for x86 platforms.
> On AMD EPYC processors, this limit needs to be increased to
> leverage all the cores.
>
> The patch adjusts the limit specifically for native c
On Thu, Oct 5, 2023 at 2:50 PM Elena Agostini wrote:
>
> This patch makes sense to me and actually we should update the
> drivers/gpu/cuda/devices.h with all the new GPU devices ID
>
> I don’t have an RTX 6000 GPU in my setup so I trust Cliff on the correctness
> of the ID
Elena, please work wi
On 10/5/23 21:48, Nicolas Chautru wrote:
This exposes the width of each windowing shape being configured on
the device. This allows to distinguish different version of the
flexible pointwise windowing applied to the FFT and expose
this platform configuration to the application.
This also add t
On 10/5/23 21:48, Nicolas Chautru wrote:
This allows to expose the FFT window width being introduced in
previous commit based on what is configured dynamically on the
device platform.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc/acc_common.h | 6 +
drivers/baseband/acc/rt
Hello,
On Tue, Jul 11, 2023 at 12:00 AM Bili Dong wrote:
>
> An XOR32 hash is needed in the Software Switch (SWX) Pipeline for its
> use case in P4. We implement it in this patch so it could be easily
> registered in the pipeline later.
>
> Signed-off-by: Bili Dong
> .mailmap
Hello,
On Thu, Oct 5, 2023 at 2:44 PM Elena Agostini wrote:
>
> Ack
Please, don't top post.
>
>
>
> Thanks
>
> EA
>
>
>
> From: David Marchand
> Date: Friday, 29 September 2023 at 16:58
> To: Aaron Conole , John Romein
> Cc: dev@dpdk.org , Elena Agostini ,
> levendsa...@gmail.com
> Subject
On Wed, Aug 16, 2023 at 9:00 PM Sivaprasad Tummala
wrote:
>
> mwaitx allows EPYC processors to enter a implementation dependent
> power/performance optimized state (C1 state) for a specific period
> or until a store to the monitored address range.
>
> Signed-off-by: Sivaprasad Tummala
> Acked-by:
On Fri, Aug 11, 2023 at 8:08 AM Sivaprasad Tummala
wrote:
>
> This patch removes RTE_CPUFLAG_NUMFLAGS to allow new CPU
> features without breaking ABI each time.
>
> Signed-off-by: Sivaprasad Tummala
I relooked at the API and I see one case (that I had missed in my
previous reply) where an ABI i
On Tue, Sep 26, 2023 at 10:01 PM Sivaprasad Tummala
wrote:
>
> amd-pstate introduces a new CPU frequency control mechanism for AMD
> EPYC processors using the ACPI Collaborative Performance Power Control
> feature for a finer grained frequency management.
>
> Patch to add support for amd-pstate dr
Hello Mattias,
On Thu, Oct 5, 2023 at 12:09 PM Mattias Rönnblom wrote:
> >> +
> >> +deps += ['eventdev']
> >> diff --git a/lib/dispatcher/rte_dispatcher.c
> >> b/lib/dispatcher/rte_dispatcher.c
> >> new file mode 100644
> >> index 00..0e69db2b9b
> >> --- /dev/null
> >> +++ b/lib/dispatch
On Thu, Oct 5, 2023 at 1:26 PM Mattias Rönnblom wrote:
[snip]
> >> +#define RETURN_ON_ERROR(rc) \
> >> + do {\
> >> + if (rc != TEST_SUCCESS) \
> >> + return rc; \
> >> + } while (0)
> >
> >
On Wed, Aug 16, 2023 at 12:10 PM Sivaprasad Tummala
wrote:
>
> currently the uncore power management implementation is vendor specific.
> Added new vendor agnostic uncore power interface similar to rte_power
> and rename specific implementations ("rte_power_intel_uncore") to
> "power_intel_uncore"
06/10/2023 10:46, David Marchand:
> On Thu, Oct 5, 2023 at 12:09 PM Mattias Rönnblom
> wrote:
> > >> +static int
> > >> +evd_lookup_handler_idx(struct rte_dispatcher_lcore *lcore,
> > >> + const struct rte_event *event)
> > >
> > > Wrt DPDK coding tyle, indent is a single tab
On Wed, Oct 4, 2023 at 7:13 PM Stephen Hemminger
wrote:
>
> On Mon, 2 Oct 2023 10:15:25 +0200
> David Marchand wrote:
>
> > >
> >
> > Bugzilla ID: 1291 ?
> >
> > This patch (and patch 3) updates some pcapng API, is it worth a RN update?
> >
> > > Fixes: c882eb544842 ("pcapng: fix timestamp wrappi
On Wed, Oct 4, 2023 at 1:00 PM Mattias Rönnblom
wrote:
>
> Clarify MT safety guarantees for unregistered non-EAL threads calling
> PRNG functions in rte_random.h.
>
> Clarify that rte_srand() is not MT safe in regards to calls to
> rte_rand_max() and rte_drand().
>
> Suggested-by: Stephen Hemminge
On 10/5/23 21:49, Nicolas Chautru wrote:
Adding a few functions and common code prior to
extending the VRB driver.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc/acc_common.h | 175 ++---
drivers/baseband/acc/rte_vrb_pmd.c | 58 +-
2 files chang
The event structure in DPDK is 16-bytes in size, and events are
regularly passed as parameters directly rather than being passed as
pointers. To help compiler optimize correctly, we can explicitly request
16-byte alignment for events, which means that we should be able
to do aligned vector loads/st
The event structure in DPDK is 16-bytes in size, and events are
regularly passed as parameters directly rather than being passed as
pointers. To help compiler optimize correctly, we can explicitly request
16-byte alignment for events, which means that we should be able
to do aligned vector loads/st
On Thu, Aug 10, 2023 at 3:29 PM Bruce Richardson
wrote:
>
> With the removal of the kni kernel driver, there are no longer any
> Linux kernel modules in our repository, leaving only modules for FreeBSD
> present. Since:
>
> * BSD has no issues with out-of-tree modules and
> * There are no in-tree
On 10/5/23 21:49, Nicolas Chautru wrote:
New implementation for some of the FEC features
specific to the VRB2 variant.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc/rte_vrb_pmd.c | 370 +
1 file changed, 328 insertions(+), 42 deletions(-)
diff --git
Dear Harman, Anatoly and David,
I have been looking somewhat into power management, and have a question about
rte_epoll:
Can I use rte_epoll to wait for an event (or interrupt/signal) in one EAL
thread, generated by another EAL thread?
Here's a simple use case with two EAL threads:
1. The "in
On Thu, Aug 3, 2023 at 6:25 PM Levend Sayar wrote:
>
> If gdrapi.h is available, meson sets DRIVERS_GPU_CUDA_GDRCOPY_H as 1.
> This causes gdrcopy.c build to give an error;
> because compiler can not find signature of getenv.
> stdlib.h is included for the definition of getenv function.
>
> Fixes:
On Fri, Sep 8, 2023 at 3:18 PM Artemy Kovalyov wrote:
>
> Implementing a lock annotation for rte_memseg_list_walk() to
> proactively identify bugs similar to memory_hotplug_lock deadlock during
> initialization during compile time.
>
> Signed-off-by: Artemy Kovalyov
Series applied, thanks Artemy
> From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> Sent: Friday, 6 October 2023 11.45
>
> The event structure in DPDK is 16-bytes in size, and events are
> regularly passed as parameters directly rather than being passed as
> pointers. To help compiler optimize correctly, we can explic
On Fri, Oct 6, 2023 at 3:44 PM Morten Brørup wrote:
>
> > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > Sent: Friday, 6 October 2023 11.45
> >
> > The event structure in DPDK is 16-bytes in size, and events are
> > regularly passed as parameters directly rather than being passed a
On Fri, Oct 06, 2023 at 12:13:54PM +0200, Morten Brørup wrote:
> > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > Sent: Friday, 6 October 2023 11.45
> >
> > The event structure in DPDK is 16-bytes in size, and events are
> > regularly passed as parameters directly rather than being
https://bugs.dpdk.org/show_bug.cgi?id=1133
David Marchand (david.march...@redhat.com) changed:
What|Removed |Added
Resolution|--- |FIXED
On Fri, Oct 06, 2023 at 03:46:21PM +0530, Jerin Jacob wrote:
> On Fri, Oct 6, 2023 at 3:44 PM Morten Brørup
> wrote:
> >
> > > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > > Sent: Friday, 6 October 2023 11.45
> > >
> > > The event structure in DPDK is 16-bytes in size, and event
On Fri, Oct 6, 2023 at 3:49 PM Bruce Richardson
wrote:
>
> On Fri, Oct 06, 2023 at 03:46:21PM +0530, Jerin Jacob wrote:
> > On Fri, Oct 6, 2023 at 3:44 PM Morten Brørup
> > wrote:
> > >
> > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > > > Sent: Friday, 6 October 2023 11.45
On Fri, Oct 06, 2023 at 03:54:26PM +0530, Jerin Jacob wrote:
> On Fri, Oct 6, 2023 at 3:49 PM Bruce Richardson
> wrote:
> >
> > On Fri, Oct 06, 2023 at 03:46:21PM +0530, Jerin Jacob wrote:
> > > On Fri, Oct 6, 2023 at 3:44 PM Morten Brørup
> > > wrote:
> > > >
> > > > > From: Bruce Richardson [m
The event structure in DPDK is 16-bytes in size, and events are
regularly passed as parameters directly rather than being passed as
pointers. To help compiler optimize correctly, we can explicitly request
16-byte alignment for events, which means that we should be able
to do aligned vector loads/st
> From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> Sent: Friday, 6 October 2023 12.17
ev: ensure 16-byte alignment for events
>
> On Fri, Oct 06, 2023 at 12:13:54PM +0200, Morten Brørup wrote:
> > > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > > Sent: Friday, 6 Octobe
On Fri, Oct 06, 2023 at 12:35:26PM +0200, Morten Brørup wrote:
> > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > Sent: Friday, 6 October 2023 12.17
> ev: ensure 16-byte alignment for events
> >
> > On Fri, Oct 06, 2023 at 12:13:54PM +0200, Morten Brørup wrote:
> > > > From: Bruce
Hello Sunil,
On Mon, Jul 26, 2021 at 11:09 AM wrote:
>
> From: Amaranath Somalapuram
>
> drop all the code duplicating the PCI bus driver
> developed for enable IOMMU in vdev.
>
> Signed-off-by: Amaranath Somalapuram
Looking back in history, this patch converted crypto/ccp to a PCI
driver, but
On 10/6/2023 9:27 AM, David Marchand wrote:
> On Fri, Aug 11, 2023 at 8:08 AM Sivaprasad Tummala
> wrote:
>>
>> This patch removes RTE_CPUFLAG_NUMFLAGS to allow new CPU
>> features without breaking ABI each time.
>>
>> Signed-off-by: Sivaprasad Tummala
>
> I relooked at the API and I see one cas
On 10/5/23 19:59, Chautru, Nicolas wrote:
Hi Maxime,
-Original Message-
From: Maxime Coquelin
Sent: Thursday, October 5, 2023 7:35 AM
To: Chautru, Nicolas ; dev@dpdk.org
Cc: hemant.agra...@nxp.com; david.march...@redhat.com; Vargas, Hernan
Subject: Re: [PATCH v3 09/12] baseband/acc
On 2023-10-05 13:51, Bruce Richardson wrote:
The event structure in DPDK is 16-bytes in size, and events are
regularly passed as parameters directly rather than being passed as
pointers.
When are events passed by-value, rather than by-reference? There are no
such examples in the public eventde
On 2023-10-06 11:13, David Marchand wrote:
On Wed, Oct 4, 2023 at 1:00 PM Mattias Rönnblom
wrote:
Clarify MT safety guarantees for unregistered non-EAL threads calling
PRNG functions in rte_random.h.
Clarify that rte_srand() is not MT safe in regards to calls to
rte_rand_max() and rte_drand()
On Fri, Oct 06, 2023 at 02:15:00PM +0200, Mattias Rönnblom wrote:
> On 2023-10-05 13:51, Bruce Richardson wrote:
> > The event structure in DPDK is 16-bytes in size, and events are
> > regularly passed as parameters directly rather than being passed as
> > pointers.
>
> When are events passed by-v
On 10/5/23 21:49, Nicolas Chautru wrote:
Adding the capability for the MLD-TS processing specific to
the VRB2 variant.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc/rte_vrb_pmd.c | 374 +
1 file changed, 374 insertions(+)
diff --git a/drivers/baseban
On 2023-10-06 14:19, Bruce Richardson wrote:
On Fri, Oct 06, 2023 at 02:15:00PM +0200, Mattias Rönnblom wrote:
On 2023-10-05 13:51, Bruce Richardson wrote:
The event structure in DPDK is 16-bytes in size, and events are
regularly passed as parameters directly rather than being passed as
pointer
Hi Qi,
>
> +#define ACTION_PROG_NAME_SIZE_MAX 32
> +#define ACTION_PROG_ARG_NUM_MAX 16
> +#define ACTION_PROG_ARG_VALUE_SIZE_MAX 32
Let's be a bit more generous with some of these sizes, please.
The action name might be hierarchical, i.e. include the control block and table
path separated
Hi Arek,
> -Original Message-
> From: Kusztal, ArkadiuszX
> Sent: Sunday, September 17, 2023 4:43 PM
> To: dev@dpdk.org
> Cc: gak...@marvell.com; Ji, Kai ; Power, Ciara
> ; Kusztal, ArkadiuszX
>
> Subject: [PATCH 3/3] common/qat: decouple pmds from the common code
>
> Service specific f
Rather than copy/paste everywhere how to bind a device and create VF
devices, refer to the Linux GSG section about it.
Signed-off-by: David Marchand
---
doc/guides/bbdevs/acc100.rst| 73 ++---
doc/guides/bbdevs/fpga_5gnr_fec.rst | 71 ++--
Hi Arek,
> -Original Message-
> From: Kusztal, ArkadiuszX
> Sent: Sunday, September 17, 2023 4:43 PM
> To: dev@dpdk.org
> Cc: gak...@marvell.com; Ji, Kai ; Power, Ciara
> ; Kusztal, ArkadiuszX
>
> Subject: [PATCH 3/3] common/qat: decouple pmds from the common code
>
> Service specific f
From: Arkadiusz Kusztal
Some of the API comments incorrectly limited the usage of symmetric
crypto fields to block ciphers.
Signed-off-by: Arkadiusz Kusztal
Signed-off-by: Ciara Power
---
lib/cryptodev/rte_crypto_sym.h | 19 +--
1 file changed, 5 insertions(+), 14 deletions(-)
Acked-by: Kai Ji mailto:kai...@intel.com>>
From: Power, Ciara
Sent: 06 October 2023 14:06
To: dev@dpdk.org
Cc: Ji, Kai ; Kusztal, ArkadiuszX
; Power, Ciara ; Akhil
Goyal ; Fan Zhang
Subject: [PATCH v1] cryptodev: clarify usage of the block ciphers
From: Arkad
On 06/10/2023 10:10, David Marchand wrote:
On Wed, Oct 4, 2023 at 7:13 PM Stephen Hemminger
wrote:
On Mon, 2 Oct 2023 10:15:25 +0200
David Marchand wrote:
Bugzilla ID: 1291 ?
This patch (and patch 3) updates some pcapng API, is it worth a RN update?
Fixes: c882eb544842 ("pcapng: fix t
> -Original Message-
> From: Morten Brørup
> Sent: Friday, October 6, 2023 5:04 AM
> To: Harman Kalra ; Anatoly Burakov
> ; David Hunt
> Cc: dev@dpdk.org
> Subject: How to rte_epoll_wait for IPC?
>
> Dear Harman, Anatoly and David,
>
> I have been looking somewhat into power manageme
> From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com]
> Sent: Friday, 6 October 2023 17.27
>
> > From: Morten Brørup
> > Sent: Friday, October 6, 2023 5:04 AM
> >
> > Dear Harman, Anatoly and David,
> >
> > I have been looking somewhat into power management, and have a
> question
> >
On Fri, 6 Oct 2023 12:03:46 +0200
Morten Brørup wrote:
> 2. The "processing" thread receives its packets from the rte_ring. This
> thread should sleep until packets are ready for it in the rte_ring.
>
> The "ingress" thread knows when it puts packets into the rte_ring, so it can
> signal that
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Friday, 6 October 2023 18.03
>
> On Fri, 6 Oct 2023 12:03:46 +0200
> Morten Brørup wrote:
>
> > 2. The "processing" thread receives its packets from the rte_ring.
> This thread should sleep until packets are ready for it in th
On Fri, 6 Oct 2023 18:28:10 +0200
Morten Brørup wrote:
> > From: Stephen Hemminger [mailto:step...@networkplumber.org]
> > Sent: Friday, 6 October 2023 18.03
> >
> > On Fri, 6 Oct 2023 12:03:46 +0200
> > Morten Brørup wrote:
> >
> > > 2. The "processing" thread receives its packets from the
On 9/29/23 6:48 AM, Ferruh Yigit wrote:
On 6/7/2023 7:47 PM, Ferruh Yigit wrote:
On 5/16/2023 10:55 AM, Ferruh Yigit wrote:
On 5/16/2023 2:28 AM, Stephen Hemminger wrote:
On Tue, 16 May 2023 00:35:56 +0100
Ferruh Yigit wrote:
Yes only some scripts and possible applications that hotplug t
My pleasure.
Thanks for ACKing Elena.
Thanks for applying David.
Best,
Levend
> On 6 Oct 2023, at 13:07, David Marchand wrote:
>
> On Thu, Aug 3, 2023 at 6:25 PM Levend Sayar wrote:
>>
>> If gdrapi.h is available, meson sets DRIVERS_GPU_CUDA_GDRCOPY_H as 1.
>> This causes gdrcopy.c build to g
Hi Maxime,
> -Original Message-
> From: Maxime Coquelin
> Sent: Friday, October 6, 2023 2:51 AM
> To: Chautru, Nicolas ; dev@dpdk.org
> Cc: hemant.agra...@nxp.com; david.march...@redhat.com; Vargas, Hernan
>
> Subject: Re: [PATCH v5 08/12] baseband/acc: add FEC capabilities for the VRB2
Hi Maxime,
> -Original Message-
> From: Maxime Coquelin
> Sent: Friday, October 6, 2023 12:54 AM
> To: Chautru, Nicolas ; dev@dpdk.org
> Cc: hemant.agra...@nxp.com; david.march...@redhat.com; Vargas, Hernan
>
> Subject: Re: [PATCH v5 01/12] bbdev: add FFT window width member in driver
>
Add support for changing the netvsc MTU. The MTU can only be set at nvs
initialization, therefore to change the MTU the underlying vmbus
channel(s) are torn down and the vmbus device unmapped and remapped. The
existing rx and tx queue(s) are reconnected to the new vmbus channel(s).
Signed-off-by:
On Fri, 6 Oct 2023 20:09:09 +
Sam Andrew wrote:
> +
> + if (dev->data->dev_started) {
> + PMD_DRV_LOG(ERR, "Device must be stopped before changing MTU");
> + return -EIO;
> + }
> +
According to rte_ethdev.h this should -EBUSY
Hi Maxime,
> -Original Message-
> From: Maxime Coquelin
> Sent: Friday, October 6, 2023 5:06 AM
> To: Chautru, Nicolas ; dev@dpdk.org
> Cc: hemant.agra...@nxp.com; david.march...@redhat.com; Vargas, Hernan
>
> Subject: Re: [PATCH v3 09/12] baseband/acc: add FFT support to VRB2 variant
>
This patch series try to enhance the bond framework to support the
offload feature better:
* Add new API to make the member port can access some information of the
bond port which belongs.
* Add new API to get the result of whether bond port is created by the
member port.
* Add two command line
From: Long Wu
Bonding PMD does not let member ports know the bonding port's
information, like how many member ports the bonding port has,
what mode the bonding port is in and so on.
Add the notification interface for bonding port to let member
port know it is added to a bonding port and what the
From: Long Wu
After bonding port notification, member port hardware may create the
bonding port. We want to get the result of creatition, so we add this
API to do the getting action.
Signed-off-by: Long Wu
Reviewed-by: James Hershaw
Reviewed-by: Chaoyong He
---
drivers/net/bonding/rte_eth_bo
From: Long Wu
Most of the previous interface comment format does not meet the
current standards and were not uniform.
Modify them to meet current standards.
Signed-off-by: Long Wu
Reviewed-by: James Hershaw
Reviewed-by: Chaoyong He
---
drivers/net/bonding/eth_bond_8023ad_private.h | 52 +++
From: Long Wu
Include the following new arguments for bonding ports:
- "notify_member" to enable/disable member notification.
- "dedicated_queue" to enable/disable dedicated queue.
Add these two arguments in initial argument.
Signed-off-by: Long Wu
Reviewed-by: James Hershaw
Reviewed-by: Chao
From: Long Wu
Several ports may share the same PCI address, like nfp representor.
So we cannot add this type of ports to bonding port by "--vdev"
argument in dpdk-testpmd. But the port's data name is unique between
them, we include an option to add such ports to the bonding port.
After adding th
From: Long Wu
Move the flow code to a new head file to make flow related
code more clean and make the code architecture more reasonable
in the future. There is no functional change, just moving
verbatim code around.
Signed-off-by: Long Wu
Reviewed-by: James Hershaw
Reviewed-by: Chaoyong He
--
From: Long Wu
Add API to support checking if the port id is a bonding
port id.
Signed-off-by: Long Wu
Reviewed-by: James Hershaw
Reviewed-by: Chaoyong He
---
drivers/net/bonding/rte_eth_bond.h | 13 +
drivers/net/bonding/rte_eth_bond_api.c | 7 +++
drivers/net/bonding/ve
From: Long Wu
Add some commands to support bonding port notification in
dpdk-testpmd.
1. We can enable the notification by command:
"set bonding notify_member (port_id) (enable|disable)"
2. If member port hardware try to create the bonding port after
notification we can get the status by comman
> -Original Message-
> From: Dumitrescu, Cristian
> Sent: Friday, October 6, 2023 8:36 PM
> To: Zhang, Qi Z ; Singh, Aman Deep
> ; Zhang, Yuying
> Cc: dev@dpdk.org; or...@nvidia.com; ferruh.yi...@amd.com
> Subject: RE: [PATCH v3] app/testpmd: enable cli for programmable action
>
>
> H
Parsing command line for rte_flow_action_prog.
Syntax:
"prog name [arguments \
... end]"
Use parse_string0 to parse name string.
Use parse_hex to parse hex string.
Use struct action_prog_data to store parsed result.
Example:
Action with 2 arguments:
"prog name action0 arguments field0 0
Hi Ferruh,
Thanks for the reminder.
I will send a new version as soon as possible.
Thanks.
On 2023/9/21 19:12, Ferruh Yigit wrote:
> On 3/1/2023 3:06 AM, Chengwen Feng wrote:
>> This patch fixes race-condition of proactive error handling mode, the
>> discussion thread [1].
>>
>> [1]
>> http://
This patch series aims to unify the coding style of NFP PMD, make the
logics following the same rules, to make it easier to understand and
extend.
Chaoyong He (11):
net/nfp: explicitly compare to null and 0
net/nfp: unify the indent coding style
net/nfp: unify the type of integer variable
To compliance with the coding standard, make the pointer variable
explicitly comparing to 'NULL' and the integer variable explicitly
comparing to '0'.
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
Reviewed-by: Peng Zhang
---
drivers/net/nfp/flower/nfp_flower.c | 6 +-
drivers/net/nfp/
Each parameter of function should occupy one line, and indent two TAB
character.
All the statement which span multi line should indent two TAB character.
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
Reviewed-by: Peng Zhang
---
drivers/net/nfp/flower/nfp_flower.c | 3 +-
drivers/
Unify the type of integer variable to the DPDK prefer style.
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
Reviewed-by: Peng Zhang
---
drivers/net/nfp/flower/nfp_flower.c | 2 +-
drivers/net/nfp/flower/nfp_flower_cmsg.c | 16 +-
drivers/net/nfp/nfd3/nfp_nfd3_dp.c | 6 ++-
There should only declare one local variable in each line, and the local
variable should obey the unify sequence.
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
Reviewed-by: Peng Zhang
---
drivers/net/nfp/flower/nfp_flower.c | 6 +-
drivers/net/nfp/nfd3/nfp_nfd3_dp.c | 4 +-
drivers/net/nf
Add log statement to the important control logic, and remove verbose
info log statement.
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
Reviewed-by: Peng Zhang
---
drivers/net/nfp/flower/nfp_flower_ctrl.c | 17 +++---
.../net/nfp/flower/nfp_flower_representor.c | 4 +-
drivers/net/nfp
Follow the DPDK coding style, use the kdoc comment style.
Also delete some comment which are not valid anymore and add some
comment to help understand logic.
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
Reviewed-by: Peng Zhang
---
drivers/net/nfp/flower/nfp_flower.h | 28 ++--
dr
Use space character to align instead of TAB character.
There should one blank line to split the block of logic, no more no less.
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
Reviewed-by: Peng Zhang
---
drivers/net/nfp/nfp_common.c | 39 +++--
drivers/net/nfp/nfp_common.h
Unify the guide line of header file, we choose '__FOO_BAR_H__' style.
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
Reviewed-by: Peng Zhang
---
drivers/net/nfp/flower/nfp_flower.h | 6 +++---
drivers/net/nfp/flower/nfp_flower_cmsg.h| 6 +++---
drivers/net/nfp/flower/nfp_f
Rename some parameter and variable to make the logic easier to
understand.
Also avoid the mix use of lowercase and uppercase in macro name.
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
Reviewed-by: Peng Zhang
---
drivers/net/nfp/nfp_common.h| 20 ++--
drivers/net/nfp/nfp
Adjust some logic to make it easier to understand.
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
Reviewed-by: Peng Zhang
---
drivers/net/nfp/nfp_common.c | 83 +---
drivers/net/nfp/nfp_cpp_bridge.c | 5 +-
drivers/net/nfp/nfp_ctrl.h | 2 -
drivers/net/
Make the source files follow the alphabeta sequence.
Also update the copyright header line.
Signed-off-by: Chaoyong He
Reviewed-by: Long Wu
Reviewed-by: Peng Zhang
---
drivers/net/nfp/meson.build | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/driv
Acked-by: Chengwen Feng
On 2023/8/9 1:35, Stephen Hemminger wrote:
> These were added in 20.11 time now to remove experimental flag.
>
> Signed-off-by: Stephen Hemminger
> ---
> lib/dmadev/rte_dmadev.h | 85 -
> lib/dmadev/version.map | 2 +-
> 2 files
Acked-by: Chengwen Feng
On 2023/8/3 15:50, David Marchand wrote:
> Use existing API to cleanup duplicated code.
>
> Signed-off-by: David Marchand
> ---
> drivers/bus/pci/linux/pci_uio.c| 32 +--
> drivers/bus/pci/linux/pci_vfio.c | 41 ++
>
https://bugs.dpdk.org/show_bug.cgi?id=1295
Bug ID: 1295
Summary: Virtio driver, packed mode, the first desc misses the
next flag, causing the message to be sent abnormally
Product: DPDK
Version: 23.07
Hardware: All
https://bugs.dpdk.org/show_bug.cgi?id=1281
Tyler Retzlaff (roret...@microsoft.com) changed:
What|Removed |Added
Resolution|--- |WONTFIX
Thanks for your comments, Bruce!
A few comments inline.
BR,
Jieqiang Wang
-邮件原件-
发件人: Bruce Richardson
发送时间: Monday, October 2, 2023 6:40 PM
收件人: Jieqiang Wang
抄送: Yipeng Wang ; Sameh Gobriel
; Vladimir Medvedkin ;
Honnappa Nagarahalli ; Dharmik Jayesh Thakkar
; dev@dpdk.org; nd ;
st
91 matches
Mail list logo
