RE: [PATCH v2 3/4] net/iavf: fix restart of Rx queue on reconfigure

> -Original Message- > From: Bruce Richardson > Sent: Thursday, August 31, 2023 8:34 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Wu, Jingjing > ; sta...@dpdk.org > Subject: [PATCH v2 3/4] net/iavf: fix restart of Rx queue on reconfigure > > After reconfiguring an RX queue the mbuf_

RE: [PATCH v2 3/4] net/iavf: fix restart of Rx queue on reconfigure

> -Original Message- > From: Zhang, Qi Z > Sent: Monday, September 4, 2023 9:15 AM > To: Bruce Richardson ; dev@dpdk.org > Cc: Richardson, Bruce ; Wu, Jingjing > ; sta...@dpdk.org > Subject: RE: [PATCH v2 3/4] net/iavf: fix restart of Rx queue on reconfigure > > > > > -Original Mes

Re: [PATCH 1/1] drivers/net: fix checking for Tx simple

I'm sorry, I think the checking logic is certainly right after I read more codes in other drivers. I just wanted to use the i40e_xmit_pkts() function to send packets via testpmd. I noticed that the tx_simple_allowed should be false if I want to use the function to send packets. So, I'm studying

RE: [PATCH v2 2/4] net/iavf: fix buffer leak on Tx queue stop

> -Original Message- > From: Richardson, Bruce > Sent: Thursday, August 31, 2023 8:34 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Lu, Wenzhuo > ; Wu, Jingjing ; > sta...@dpdk.org > Subject: [PATCH v2 2/4] net/iavf: fix buffer leak on Tx queue stop > > When a queue is stopped all bu

RE: [PATCH v2 2/4] net/iavf: fix buffer leak on Tx queue stop

> -Original Message- > From: Lu, Wenzhuo > Sent: Monday, September 4, 2023 10:18 AM > To: Richardson, Bruce ; dev@dpdk.org > Cc: Wu, Jingjing ; sta...@dpdk.org > Subject: RE: [PATCH v2 2/4] net/iavf: fix buffer leak on Tx queue stop > > > > > -Original Message- > > From: Rich

Re: [PATCH v4 01/32] net/sssnic: add build and doc infrastructure

Thanks for your reply, I'll fix them next version. On 2023/9/1 19:54, David Marchand wrote: On Fri, Sep 1, 2023 at 11:35 AM wrote: From: Renyong Wan Adding minimum PMD code, doc and build infrastructure for sssnic. Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- v2: * Fixed 'Tit

[PATCH v5 01/32] net/sssnic: add build and doc infrastructure

From: Renyong Wan Adding minimum PMD code, doc and build infrastructure for sssnic. Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- v2: * Fixed 'Title underline too short' in doc/guides/nics/sssnic.rst. * Removed error.h from including files. v5: * Fixed rebase mistake. * Fixed inco

[PATCH v5 02/32] net/sssnic: add log type and log macros

From: Renyong Wan Adding log macros to print runtime messages and trace functions. Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- drivers/net/sssnic/sssnic_ethdev.c | 13 drivers/net/sssnic/sssnic_log.h| 51 ++ 2 files changed, 64 insertions

[PATCH v5 03/32] net/sssnic: support probe and remove

From: Renyong Wan Register device ID for 3SNIC ethernet adapter to support PCI ethdev probe and remove. Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- drivers/net/sssnic/base/sssnic_hw.h | 11 + drivers/net/sssnic/sssnic_ethdev.c | 37 + 2 files

[PATCH v5 04/32] net/sssnic: initialize hardware base

From: Renyong Wan Initializing hardware base make hardware ready to be access. Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- drivers/net/sssnic/base/meson.build | 13 ++ drivers/net/sssnic/base/sssnic_hw.c | 207 +++ drivers/net/sssnic/base/sssnic_hw.h

[PATCH v5 05/32] net/sssnic: add event queue

From: Renyong Wan Event queue is intended for receiving event from hardware as well as mailbox response message. Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- v4: * Fixed dereferencing type-punned pointer. * Fixed coding style issue of COMPLEX_MACRO. --- drivers/net/sssnic/base/me

[PATCH v5 06/32] net/sssnic/base: add message definition and utility

From: Renyong Wan sssnic message is used to encapsulate sssnic command for transmission between driver and firmware. sssnic message is sent by driver via mail box and is received by driver via event queue. Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- v2: * Removed error.h from inc

[PATCH v5 08/32] net/sssnic/base: add work queue

From: Renyong Wan Work queue is used to maintain hardware queue information by driver, it is usually used in control queue, rx queue and tx queue. Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- v2: * Removed error.h from including files. --- drivers/net/sssnic/base/meson.build|

[PATCH v5 07/32] net/sssnic/base: add mailbox support

From: Renyong Wan Mailbox is a message channel used to communicate between PF and VF as well as driver and hardware functions. Mailbox messages are received by driver through event queue, and sent by driver through registers of mailbox. There are two transfer modes for sending mailbox message, on

[PATCH v5 09/32] net/sssnic/base: add control queue

From: Renyong Wan Control queue is used for communication between driver and datapath code of firmware. Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- v2: * Fixed variable 'cmd_len' is uninitialized when used. --- drivers/net/sssnic/base/meson.build| 2 + drivers/net/sssnic/b

[PATCH v5 11/32] net/sssnic: add dev MAC ops

From: Renyong Wan Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- doc/guides/nics/features/sssnic.ini | 2 + drivers/net/sssnic/base/sssnic_api.c | 174 + drivers/net/sssnic/base/sssnic_api.h | 4 + drivers/net/sssnic/base/sssnic_cmd.h | 25 +++ drivers/net/sssn

[PATCH v5 14/32] net/sssnic: support Rx queue setup and release

From: Renyong Wan Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- v2: * Removed error.h from including files. --- drivers/net/sssnic/meson.build| 1 + drivers/net/sssnic/sssnic_ethdev.c| 4 + drivers/net/sssnic/sssnic_ethdev.h| 2 + drivers/net/sssnic/sssnic_eth

[PATCH v5 13/32] net/sssnic: support link status event

From: Renyong Wan Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- v2: * Fixed 'EINVAL' undeclared. --- doc/guides/nics/features/sssnic.ini| 1 + drivers/net/sssnic/base/meson.build| 1 + drivers/net/sssnic/base/sssnic_exception.c | 116 + drive

[PATCH v5 12/32] net/sssnic: support dev link status

From: Renyong Wan Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- v2: * Removed error.h from including files. --- doc/guides/nics/features/sssnic.ini | 1 + drivers/net/sssnic/base/sssnic_api.c| 127 drivers/net/sssnic/base/sssnic_api.h| 14 +++

[PATCH v5 17/32] net/sssnic: support Tx queue start and stop

From: Renyong Wan Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- doc/guides/nics/features/sssnic.ini | 1 + drivers/net/sssnic/sssnic_ethdev.c| 2 + drivers/net/sssnic/sssnic_ethdev_tx.c | 155 ++ drivers/net/sssnic/sssnic_ethdev_tx.h | 4 + 4 fil

[PATCH v5 10/32] net/sssnic: add dev configure and infos get

From: Renyong Wan Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- drivers/net/sssnic/base/sssnic_api.c | 33 drivers/net/sssnic/base/sssnic_api.h | 8 +++ drivers/net/sssnic/base/sssnic_cmd.h | 14 + drivers/net/sssnic/base/sssnic_hw.c | 33 +++- drivers/ne

[PATCH v5 18/32] net/sssnic: add Rx interrupt support

From: Renyong Wan Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- doc/guides/nics/features/sssnic.ini | 1 + drivers/net/sssnic/base/sssnic_hw.c | 14 +++ drivers/net/sssnic/base/sssnic_hw.h | 2 + drivers/net/sssnic/sssnic_ethdev.c| 2 + drivers/net/sssnic/sssnic_et

[PATCH v5 15/32] net/sssnic: support Tx queue setup and release

From: Renyong Wan Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- v2: * Removed error.h from including files. v4: * Fixed coding style issue of REPEATED_WORD. --- drivers/net/sssnic/meson.build| 1 + drivers/net/sssnic/sssnic_ethdev.c| 4 + drivers/net/sssnic/sssnic_

[PATCH v5 20/32] net/sssnic: support dev close and reset

From: Renyong Wan Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- drivers/net/sssnic/sssnic_ethdev.c | 32 ++ 1 file changed, 32 insertions(+) diff --git a/drivers/net/sssnic/sssnic_ethdev.c b/drivers/net/sssnic/sssnic_ethdev.c index 8201a1e3c4..b59c4fd3

[PATCH v5 16/32] net/sssnic: support Rx queue start and stop

From: Renyong Wan Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- drivers/net/sssnic/base/sssnic_api.c | 63 + drivers/net/sssnic/base/sssnic_api.h | 2 + drivers/net/sssnic/base/sssnic_cmd.h | 49 drivers/net/sssnic/sssnic_ethdev.c| 2 + drivers/net/sssnic/sssn

[PATCH v5 19/32] net/sssnic: support dev start and stop

From: Renyong Wan Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- drivers/net/sssnic/base/sssnic_api.c | 508 ++ drivers/net/sssnic/base/sssnic_api.h | 257 + drivers/net/sssnic/base/sssnic_cmd.h | 100 + drivers/net/sssnic/base/sssnic_misc.

[PATCH v5 21/32] net/sssnic: add allmulticast and promiscuous ops

From: Renyong Wan Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- doc/guides/nics/features/sssnic.ini | 2 + drivers/net/sssnic/sssnic_ethdev.c | 72 + 2 files changed, 74 insertions(+) diff --git a/doc/guides/nics/features/sssnic.ini b/doc/guides/nics

[PATCH v5 23/32] net/sssnic: support Rx packet burst

From: Renyong Wan Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- v2: * Fixed wrong format of printing uint64_t. --- doc/guides/nics/features/sssnic.ini | 2 + drivers/net/sssnic/sssnic_ethdev.c| 2 + drivers/net/sssnic/sssnic_ethdev_rx.c | 167 ++ d

[PATCH v5 22/32] net/sssnic: add basic and extended stats ops

From: Renyong Wan Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- v2: * Removed error.h from including files. --- doc/guides/nics/features/sssnic.ini | 3 + drivers/net/sssnic/base/sssnic_api.c | 154 + drivers/net/sssnic/base/sssnic_api.h | 116 +++ driver

[PATCH v5 24/32] net/sssnic: support Tx packet burst

From: Renyong Wan Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- v2: * Fixed wrong format of printing uint64_t. --- doc/guides/nics/features/sssnic.ini | 5 + drivers/net/sssnic/sssnic_ethdev.c| 1 + drivers/net/sssnic/sssnic_ethdev_tx.c | 404 ++ d

[PATCH v5 30/32] net/sssnic: support VLAN offload and filter

From: Renyong Wan Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- doc/guides/nics/features/sssnic.ini | 2 + drivers/net/sssnic/base/sssnic_api.c | 34 +++ drivers/net/sssnic/base/sssnic_api.h | 1 + drivers/net/sssnic/base/sssnic_cmd.h | 9 +++ drivers/net/sssnic/sssnic_

[PATCH v5 25/32] net/sssnic: add RSS support

From: Renyong Wan Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- v2: * Removed error.h from including files. --- doc/guides/nics/features/sssnic.ini| 4 + drivers/net/sssnic/base/sssnic_api.c | 338 ++ drivers/net/sssnic/base/sssnic_api.h | 36 +++ dri

[PATCH v5 29/32] net/sssnic: add dev flow control ops

From: Renyong Wan Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- doc/guides/nics/features/sssnic.ini | 1 + drivers/net/sssnic/base/sssnic_api.c | 68 drivers/net/sssnic/base/sssnic_api.h | 4 ++ drivers/net/sssnic/base/sssnic_cmd.h | 11 + driver

[PATCH v5 27/32] net/sssnic: support dev queue info get

From: Renyong Wan Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- drivers/net/sssnic/sssnic_ethdev.c| 2 ++ drivers/net/sssnic/sssnic_ethdev_rx.c | 13 + drivers/net/sssnic/sssnic_ethdev_rx.h | 2 ++ drivers/net/sssnic/sssnic_ethdev_tx.c | 11 +++ drivers/ne

[PATCH v5 28/32] net/sssnic: support dev firmware version get

From: Renyong Wan Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- doc/guides/nics/features/sssnic.ini | 1 + drivers/net/sssnic/base/sssnic_api.c | 36 drivers/net/sssnic/base/sssnic_api.h | 9 +++ drivers/net/sssnic/base/sssnic_cmd.h | 8 +++

[PATCH v5 32/32] net/sssnic: add VF dev support

From: Renyong Wan In comparison to PF, VF PMD does not support the following features: 1. link up and link down set 2. promiscuous enable and disable 3. MAC stats in extend xstats Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- drivers/net/sssnic/base/sssnic_api.c | 42

[PATCH v5 31/32] net/sssnic: add generic flow ops

From: Renyong Wan Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- v2: * Fixed 'mask->hdr.src_addr' will always evaluate to 'true'. * Removed error.h from including files. --- doc/guides/nics/features/sssnic.ini | 12 + drivers/net/sssnic/base/sssnic_api.c| 264 ++ driv

[PATCH v5 26/32] net/sssnic: support dev MTU set

From: Renyong Wan Signed-off-by: Steven Song Signed-off-by: Renyong Wan --- drivers/net/sssnic/sssnic_ethdev.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/sssnic/sssnic_ethdev.c b/drivers/net/sssnic/sssnic_ethdev.c index a00e96bebe..b086e91d2d 100644 --- a/drivers/n

[PATCH v3 0/5] support setting and querying RSS algorithms

This patchset is to support setting and querying RSS algorithms. -- v3: 1. fix commit log for PATCH [1/5]. 2. make RSS ABI changes description to start the actual text at the margin. 3. move defnition of enum rte_eth_hash_function to rte_ethdev.h. 4. fix some comment codes. v2: 1. return error if

[PATCH v3 1/5] app/proc-info: fix never show RSS info

Command show-port should show RSS info (rss_key, len and rss_hf), However, the information is showned only when rss_conf.rss_key is not NULL. Since no memory is allocated for rss_conf.rss_key, rss_key will always be NULL and the rss_info will never show. This patch allocates memory for rss_conf.rss

[PATCH v3 2/5] app/proc-info: adjust the display format of RSS info

This patch splits the length and value of RSS key into two parts, removes spaces between RSS keys, and adds line breaks between RSS key and RSS hf. Before the adjustment, RSS info is shown as: - RSS -- RSS len 40 key (hex): 6d 5a 56 da 25 5b e c2 41 67 \ 25 3d 43 a3 8f b0

[PATCH v3 3/5] app/proc-info: support querying RSS hash algorithm

Display RSS hash algorithm with command show-port as below. - RSS info -- hash algorithm : toeplitz Signed-off-by: Jie Hai Signed-off-by: Dongdong Liu --- app/proc-info/main.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/app/proc-info/main.c b/app/proc-in

[PATCH v3 4/5] app/testpmd: add RSS hash algorithms display

1. Add the command "show port X rss-hash func" to display the RSS hash algorithms of port X. 2. Add the command "show port X rss-hash all" to display the RSS hash configuration of port X, including RSS hash types, key and algorithms. Signed-off-by: Jie Hai --- app/test-pmd/cmdline.c | 50 +++

[PATCH v3 5/5] app/testpmd: add RSS hash algorithms setting

Add command "port config rss-hash-func " to set RSS hash algorithms. Signed-off-by: Jie Hai --- app/test-pmd/cmdline.c | 78 -- app/test-pmd/config.c | 16 - app/test-pmd/testpmd.h | 3 +- 3 files changed, 84 insertions(+), 13 deletions(-) diff

Re: [PATCH v2 1/5] ethdev: support setting and querying RSS algorithm

On 2023/8/31 8:10, Ajit Khaparde wrote: On Wed, Aug 30, 2023 at 4:46 AM Thomas Monjalon wrote: Hello, Thanks for bringing a new capability. 26/08/2023 09:46, Jie Hai: Currently, rte_eth_rss_conf supports configuring and querying rss hash functions, rss key and it's length, but not rss hash

RE: [PATCH v11 2/4] net/i40e: implement mbufs recycle mode

> -Original Message- > From: Konstantin Ananyev > Sent: Friday, September 1, 2023 10:23 PM > To: Feifei Wang ; Konstantin Ananyev > > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli > ; Ruifeng Wang > ; Yuying Zhang ; Beilei > Xing ; nd ; nd > Subject: RE: [PATCH v11 2/4] net/i40e: implem