> -Original Message-
> From: Wu, Wenjun1
> Sent: Tuesday, July 11, 2023 1:25 PM
> To: markus.th...@tu-ilmenau.de; dev@dpdk.org
> Cc: Yang, Qiming ; Zhang, Qi Z
> ; Michael Rossberg
> Subject: RE: [PATCH] net/ice: allow setting CIR
>
> > -Original Message-
> > From: markus.th..
When running check-git-log, it showed a Bad substitution.
It is fixed by using tr to escape the open parenthesis.
Fixes: 6fd14c1b58e6 ("devtools: fix mailmap check for parentheses")
Cc: tho...@monjalon.net
Suggested-by: Thomas Monjalon
Signed-off-by: Raslan Darawsheh
---
devtools/check-git-lo
Some more comments below. I agree where I didn't reply.
On Sat, Jul 8, 2023 at 1:07 AM Jeremy Spewock wrote:
>
>
>
> On Thu, Jul 6, 2023 at 10:54 AM Juraj Linkeš
> wrote:
>>
>> There are mypy errors related to paramiko:
>> framework/remote_session/remote/interactive_remote_session.py:8: error:
> UDP header and L2 header (if any) length is included in sa->hdr_len.
> Take care of that in L3 header and pakcet length calculation.
>
> Fixes: 01eef5907fc3 ("ipsec: support NAT-T")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Xiao Liang
> Acked-by: Konstantin Ananyev
> Acked-by: Radu Nicolau
Y
> Found by devtools/cocci/nullfree.cocci
>
> Fixes: 2d970c663314 ("cryptodev: add asymmetric SM2 algorithm")
> Cc: gmuthukri...@marvell.com
> Signed-off-by: Stephen Hemminger
> ---
Applied to dpdk-next-crypto
Thanks.
> Subject: [EXT] Re: [PATCH v2] doc: announce addition of new security IPsec SA
> option
>
> On Tue, Jul 4, 2023 at 10:45 AM Nithin Dabilpuram
> wrote:
> >
> > Announce addition of new security IPsec SA option to enable
> > out of place processing in Ingress Inline inbound SA's.
> >
> > Signed-of
On 7/6/2023 3:42 AM, Stephen Hemminger wrote:
> On Wed, 5 Jul 2023 19:32:48 -0700
> Stephen Hemminger wrote:
>
>> The mailmap file is supposed to be in sorted order,
>> but several entries are in the wrong place.
>>
>> Signed-off-by: Stephen Hemminger
>> ---
>> v2 - use en_us.UTF-8 sort order
>
> Since backend and frontend message are synchronous in the same thread,
> there will be a probability of message deadlock.
> Consider each driver to determine whether to wait for response.
>
> Fixes: d90cf7d111ac ("vhost: support host notifier")
> Cc: maxime.coque...@redhat.com
> Signed-off-by: Rm
af_packet is hard coded limited to 1518 bytes so it cannot be used for jumbo
Indifferent, why is it better that pcap would NOT support api that all other
pmds do (especially if it doesn't change legacy behavior when it's not used)?
> -Original Message-
> From: Ferruh Yigit
> Sent: Monda
Just a few more comments.
On Mon, Jul 10, 2023 at 6:23 PM wrote:
>
> From: Jeremy Spewock
>
> Adds a new test suite for running smoke tests that verify general
> configuration aspects of the system under test. If any of these tests
> fail, the DTS execution terminates as part of a "fail-fast" mo
The get_user_pages_remote() API has been modified in Linux kernel v6.5
[1], "struct vm_area_struct **vmas" parameter removed from the API.
To fix KNI build with Linux kernel v6.5, version check added around the
get_user_pages_remote() API.
[1]
ca5e863233e8 ("mm/gup: remove vmas parameter from get
On 7/11/2023 12:51 AM, lon...@linuxonhyperv.com wrote:
> From: Long Li
>
> This counter should set to uint16_t, the same type as pkt_received.
> Otherwise, it may overflow when pkt_received goes over 256.
>
> Thanks Xinhao Kong for debugging this.
>
> Fixes: 517ed6e2d590 ("net/mana: add basic
On 7/11/2023 12:51 AM, lon...@linuxonhyperv.com wrote:
> From: Long Li
>
> The hardware specification specifies that WQE_COUNT should set to 0 for
> the Receive Queue. Although currently the hardware doesn't enforce the
> check, in the future releases it may check on this value.
>
> Signed-off-b
This patchset is to do some performance optimizations for hns3.
Huisong Li (5):
net/hns3: fix incorrect index to look up table in NEON Rx
net/hns3: fix the order of NEON Rx code
net/hns3: optimize free mbuf code for SVE Tx
net/hns3: optimize the rearm mbuf function for SVE Rx
net/hns3: o
From: Huisong Li
In hns3_recv_burst_vec(), the index to get packet length and data
size are reversed. Fortunately, this doesn't affect functionality
because the NEON Rx only supports single BD in which the packet
length is equal to the date size. Now this patch fixes it to get
back to the truth.
From: Huisong Li
Currently, hns3 SVE Tx checks the valid bits of all descriptors
in a batch and then determines whether to release the corresponding
mbufs. Actually, once the valid bit of any descriptor in a batch
isn't cleared, driver does not need to scan the rest of descriptors.
If we optimiz
From: Huisong Li
Use hns3_rxq_rearm_mbuf() to replace the hns3_rxq_rearm_mbuf_sve()
to optimize the performance of SVE Rx.
On the rxonly forwarding mode, the performance of a single queue
for 64B packet is improved by ~15%.
Signed-off-by: Huisong Li
Signed-off-by: Dongdong Liu
---
drivers/ne
From: Huisong Li
This patch reorders the order of the NEON Rx for better maintenance
and easier understanding.
Fixes: a3d4f4d291d7 ("net/hns3: support NEON Rx")
Cc: sta...@dpdk.org
Signed-off-by: Huisong Li
Signed-off-by: Dongdong Liu
---
drivers/net/hns3/hns3_rxtx_vec_neon.h | 78 ++
From: Huisong Li
This patch optimizes SVE Rx performance by the following ways:
1> optimize the calculation of valid BD number.
2> remove a temporary variable (key_fields)
3> use C language to parse some descriptor fields, instead of
SVE instruction.
4> small step prefetch descriptor.
On the
On 7/11/2023 11:24 AM, Dongdong Liu wrote:
> This patchset is to do some performance optimizations for hns3.
>
> Huisong Li (5):
> net/hns3: fix incorrect index to look up table in NEON Rx
> net/hns3: fix the order of NEON Rx code
> net/hns3: optimize free mbuf code for SVE Tx
> net/hns3:
On 7/11/2023 12:51 AM, lon...@linuxonhyperv.com wrote:
> From: Long Li
>
> The hardware specification specifies that WQE_COUNT should set to 0 for
> the Receive Queue. Although currently the hardware doesn't enforce the
> check, in the future releases it may check on this value.
>
> Signed-off-b
Hi, Ferruh
On 2023/7/11 18:48, Ferruh Yigit wrote:
On 7/11/2023 11:24 AM, Dongdong Liu wrote:
This patchset is to do some performance optimizations for hns3.
Huisong Li (5):
net/hns3: fix incorrect index to look up table in NEON Rx
net/hns3: fix the order of NEON Rx code
net/hns3: optimiz
On 7/11/2023 12:27 PM, Dongdong Liu wrote:
> Hi, Ferruh
> On 2023/7/11 18:48, Ferruh Yigit wrote:
>> On 7/11/2023 11:24 AM, Dongdong Liu wrote:
>>> This patchset is to do some performance optimizations for hns3.
>>>
>>> Huisong Li (5):
>>> net/hns3: fix incorrect index to look up table in NEON Rx
On 7/11/2023 11:24 AM, Dongdong Liu wrote:
> From: Huisong Li
>
> In hns3_recv_burst_vec(), the index to get packet length and data
> size are reversed. Fortunately, this doesn't affect functionality
> because the NEON Rx only supports single BD in which the packet
> length is equal to the date s
Hi,
On 7/11/23 11:25, Rma Ma wrote:
> Since backend and frontend message are synchronous in the same thread,
> there will be a probability of message deadlock.
> Consider each driver to determine whether to wait for response.
>
> Fixes: d90cf7d111ac ("vhost: support host notifier")
> Cc: m
On 7/11/2023 2:48 AM, fengchengwen wrote:
> On 2023/7/11 9:18, Kaiyu Zhang wrote:
>> sanity check is performed after a rte_eth_dev object is allocated.
>> The object is not freed if the check fails, though in the current
>> reality this never happens, but it's better programming paradigm
>> to mov
Please use 'in-reply-to' of the first submission when sending any
subsequent patches.
On 7/11/2023 11:21 AM, Abhijit Gangurde wrote:
Provide driver flag which gives an option to map the cdx
device resource before probing the device driver.
Also, make rte_cdx_map_device() API as public to map
de
The Python script is intended to analyze mlx5 PMD
datapath traces and report:
- tx_burst routine timings
- how packets are pushed to WQEs
- how packet sending is completed with timings
Signed-off-by: Viacheslav Ovsiienko
---
drivers/net/mlx5/tools/mlx5_trace.py | 307 ++
The mlx5 provides the send scheduling on specific moment of time,
and for the related kind of applications it would be extremely useful
to have extra debug information - when and how packets were scheduled
and when the actual sending was completed by the NIC hardware (it helps
application to track
The mlx5 provides the send scheduling on specific moment of time,
and for the related kind of applications it would be extremely useful
to have extra debug information - when and how packets were scheduled
and when the actual sending was completed by the NIC hardware (it helps
application to track
From: Bing Zhao
After rte_flow_shared_action_* API was replaced with
rte_flow_action_handle_* API, one input parameter of the update
interface was also changed. A generic pointer was used instead of the
"const struct rte_flow_action *" pointer.
In the entrance of mlx5 PMD callback for update, th
Skip the METER_MARK validation for the indirect action update.
The old synchronous indirect action update was left out
during the METER_MARK implementation in favor of the async way.
Allow the sync method of doing this with relaxed validation.
Fixes: 48fbb0e93d06 ("net/mlx5: support flow meter mar
The indirect action handle update for the METER_MERK action
was implemented only for the async RTE Flow API.
Allow updating the METER_MARK parameters via the old sync method.
Fixes: 9c4a0c1859a3 ("ethdev: add meter color mark flow action")
Signed-off-by: Alexander Kozyrev
---
app/test-pmd/confi
On Sat, 26 Mar 2022 00:32:07 -0700
Vipin Varghese wrote:
> +
> + output = " Socket " + str(socket).ljust(3, ' ') + " Numa " +
> str(numa).zfill(1) + " "
> + #output = " Socket " + str(socket).zfill(1) + " Numa " +
> str(numa).zfill(1) + " "
> + print(output)
> + print(format("-" * len(outpu
Provide per lcore macros that use __declspec(thread) and uses C23
typeof.
Signed-off-by: Tyler Retzlaff
---
lib/eal/include/rte_per_lcore.h | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/lib/eal/include/rte_per_lcore.h b/lib/eal/include/rte_per_lcore.h
index eaedf0
Provide MSVC compatible macros RTE_DEFINE_PER_LCORE and
RTE_DECLARE_PER_LCORE that expand appropriately for Windows/MSVC
NOTICE:
It is intentional that devtools/checkpatches.pl generates an error
about parenthesis to allow comparison with clang/gcc versions of
these macros which also do not have
11/07/2023 17:42, Stephen Hemminger:
> On Sat, 26 Mar 2022 00:32:07 -0700
> Vipin Varghese wrote:
>
> > +
> > + output = " Socket " + str(socket).ljust(3, ' ') + " Numa " +
> > str(numa).zfill(1) + " "
> > + #output = " Socket " + str(socket).zfill(1) + " Numa " +
> > str(numa).zfill(1) + " "
Inline assembly is not supported for MSVC x64. Convert code to use
__rdtsc intrinsic.
Signed-off-by: Tyler Retzlaff
Acked-by: Konstantin Ananyev
Acked-by: Morten Brørup
---
lib/eal/x86/include/rte_cycles.h | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/lib/e
In accordance with draft plan
http://mails.dpdk.org/archives/web/2023-February/002023.html
introduces conditionally compiled code to enable building with MSVC that
_does not_ require C99/C11 meaning it can be integrated now.
This series covers minimal changes for item #2 in draft plan for EAL
depe
Inline assembly is not supported for MSVC x64. Convert code to use
_xend, _xabort and _xtest intrinsics.
Signed-off-by: Tyler Retzlaff
Acked-by: Bruce Richardson
Acked-by: Konstantin Ananyev
Acked-by: Morten Brørup
---
config/x86/meson.build| 6 ++
lib/eal/x86/include/rte_rtm.h |
Inline assembly is not supported for MSVC x64 instead expand
rte_compiler_barrier as _ReadWriteBarrier and for rte_smp_mb
_m_mfence intrinsics.
Signed-off-by: Tyler Retzlaff
Acked-by: Bruce Richardson
Acked-by: Konstantin Ananyev
Acked-by: Morten Brørup
---
lib/eal/include/generic/rte_atomic.
Inline assembly is not supported for MSVC x64 instead use __cpuid
and __cpuidex intrinsics.
Signed-off-by: Tyler Retzlaff
Acked-by: Morten Brørup
---
lib/eal/x86/rte_cpuflags.c | 6 +-
lib/eal/x86/rte_cpuid.h | 7 +++
lib/eal/x86/rte_cycles.c | 36 ++
Inline assembly is not supported for MSVC x64 instead use _mm_prefetch
and _mm_cldemote intrinsics.
Signed-off-by: Tyler Retzlaff
Acked-by: Bruce Richardson
Acked-by: Morten Brørup
Acked-by: Konstantin Ananyev
---
lib/eal/x86/include/rte_prefetch.h | 25 +
1 file chang
When compiling with MSVC don't expose typedefs used as alignment
markers.
Signed-off-by: Tyler Retzlaff
Acked-by: Morten Brørup
---
lib/eal/include/rte_common.h | 4
1 file changed, 4 insertions(+)
diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h
index 15765b4..2f4
Windows does not support versioned symbols. Fortunately Windows also
doesn't have an exported stable ABI.
Export rte_tel_data_add_array_int -> rte_tel_data_add_array_int_24
and rte_tel_data_add_dict_int -> rte_tel_data_add_dict_int_v24
functions.
Windows does have a way to achieve similar version
It's discouraged to use rte_atomics APIs instead standard APIs should be
used from C11. Since MSVC is a new toolchain/platform combination block
visibility of the rte_atomic APIs from day 1.
Signed-off-by: Tyler Retzlaff
Acked-by: Morten Brørup
---
lib/eal/include/generic/rte_atomic.h | 7 +
When compiling with MSVC don't expose typedefs based on GCC vector
extensions.
Signed-off-by: Tyler Retzlaff
Acked-by: Morten Brørup
---
lib/eal/include/generic/rte_vect.h | 4
1 file changed, 4 insertions(+)
diff --git a/lib/eal/include/generic/rte_vect.h
b/lib/eal/include/generic/rte_v
Inline assembly is not supported for MSVC x64 instead use _umonitor,
_umwait and _tpause intrinsics.
Signed-off-by: Tyler Retzlaff
Acked-by: Morten Brørup
Acked-by: Konstantin Ananyev
---
lib/eal/x86/rte_power_intrinsics.c | 12
1 file changed, 12 insertions(+)
diff --git a/lib/e
For now expand a lot of common rte macros empty. The catch here is we
need to test that most of the macros do what they should but at the same
time they are blocking work needed to bootstrap of the unit tests.
Later we will return and provide (where possible) expansions that work
correctly for msv
The MSVC compiler does not target big endian platforms so define
little endian always.
Signed-off-by: Tyler Retzlaff
Acked-by: Morten Brørup
---
lib/eal/include/generic/rte_byteorder.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/eal/include/generic/rte_byteorder.h
b/lib/eal/inclu
When building with MSVC do not assume typeof is a macro and don't
define a typeof macro that conflicts with C23 typeof keyword.
Signed-off-by: Tyler Retzlaff
Acked-by: Morten Brørup
---
lib/eal/include/rte_common.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/eal/include/rte_common
Inline assembly is not supported for MSVC x64 instead expand
use _byteswap_u{ushort,ulong,uint64} intrinsics instead.
Signed-off-by: Tyler Retzlaff
Acked-by: Morten Brørup
---
lib/eal/include/generic/rte_byteorder.h | 11 +++
lib/eal/x86/include/rte_byteorder.h | 4
2 files ch
From: Pavan Nikhilesh
Use optimized rte_hash_k32_cmp_eq routine for key comparison for
x86 and ARM64.
Use CRC instructions for hash generation on ARM64.
Signed-off-by: Pavan Nikhilesh
Reviewed-by: Ruifeng Wang
Acked-by: Konstantin Ananyev
---
On Neoverse-N2, performance improved by 10% when m
From: Pavan Nikhilesh
Add reassembly perf autotest for both ipv4 and ipv6 reassembly.
Each test is performed with variable number of fragments per flow,
either ordered or unordered fragments and interleaved flows.
Signed-off-by: Pavan Nikhilesh
Reviewed-by: Amit Prakash Shukla
Tested-by: Amit
In some openSSL 3 libraries, uninitialized output variable
cause segfault. It is always nice to initialize it.
Fixes: 3b7d638fb11f ("crypto/openssl: support asymmetric SM2")
Bugzilla ID: 1250
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/crypto/openssl/rte_openssl_pmd.c | 2 +-
1 file c
In some version of openSSL 3 lib (for an instance, in linux
distribution), if SM2 is not supported, driver should return
error.
Fixes: 3b7d638fb11f ("crypto/openssl: support asymmetric SM2")
Bugzilla ID: 1250
Signed-off-by: Gowrishankar Muthukrishnan
---
drivers/crypto/openssl/rte_openssl_pmd_o
From: Long Li
hn_vf_reset() is defined but not used. Remove it.
Signed-off-by: Long Li
---
drivers/net/netvsc/hn_var.h | 1 -
drivers/net/netvsc/hn_vf.c | 5 -
2 files changed, 6 deletions(-)
diff --git a/drivers/net/netvsc/hn_var.h b/drivers/net/netvsc/hn_var.h
index 98a3b83033..e1f8e69
From: Jeremy Spewock
This version of the series addresses comments and improvements listed on
the previous non-RFC patch.
RFCs for this patch:
* v3: https://mails.dpdk.org/archives/dev/2023-June/269859.html
* v2: https://mails.dpdk.org/archives/dev/2023-May/267915.html
* v1: https://mails.dpdk.o
From: Jeremy Spewock
Adds a new test suite for running smoke tests that verify general
configuration aspects of the system under test. If any of these tests
fail, the DTS execution terminates as part of a "fail-fast" model.
Signed-off-by: Jeremy Spewock
---
dts/conf.yaml
From: Jeremy Spewock
added paramiko to the dependency files
Signed-off-by: Jeremy Spewock
---
dts/poetry.lock| 160 ++---
dts/pyproject.toml | 1 +
2 files changed, 124 insertions(+), 37 deletions(-)
diff --git a/dts/poetry.lock b/dts/poetry.lock
Hello,
I don't pull this patch in -rc3 because I feel some improvements should be done.
> On 7/7/2023 2:08 PM, Lingyu Liu wrote:
> > +echo 2 > /sys/bus/pci/devices/:ca:00.1/sriov_numvfs
> > +echo "8086 1889" > /sys/bus/pci/drivers/ice-vfio-pci/new_id
> > +echo :ca
On Tue, 11 Jul 2023 18:20:44 +0300
Alexander Kozyrev wrote:
> + case RTE_FLOW_ACTION_TYPE_METER_MARK:
> + rte_memcpy(&mtr_update.meter_mark, action->conf,
> + sizeof(struct rte_flow_action_meter_mark));
Why use rte_memcpy? memcpy of fixed size is faster.
Also,
On Tue, 11 Jul 2023 12:12:30 -0700
lon...@linuxonhyperv.com wrote:
> From: Long Li
>
> hn_vf_reset() is defined but not used. Remove it.
>
> Signed-off-by: Long Li
Acked-by: Stephen Hemminger
> > > Since backend and frontend message are synchronous in the same thread,
> > > there will be a probability of message deadlock.
> > > Consider each driver to determine whether to wait for response.
> > >
> > > Fixes: d90cf7d111ac ("vhost: support host notifier")
> > > Cc: maxime.coq
> -Original Message-
> From: Abdullah Sevincer
> Sent: 2023年7月9日 0:24
> To: dev@dpdk.org
> Cc: Pattan, Reshma ;
> step...@networkplumber.org; Sevincer, Abdullah
> ; sta...@dpdk.org
> Subject: [PATCH v1] app/procinfo: revise display eventdev xstats
>
> process_eventdev_xstats() function wa
Good evening DPDK Community,
Our next meeting will be held tomorrow, Wed., Jul. 12, 2023, at 8am
Pacific/11am Eastern.
Here is a read only link to the agenda:
https://annuel.framapad.org/p/r.0c3cc4d1e011214183872a98f6b5c7db
And you can log in at the jit.si link:
https://meet.jit.si/dpdk
See y
https://bugs.dpdk.org/show_bug.cgi?id=1253
linglix.c...@intel.com changed:
What|Removed |Added
Resolution|--- |FIXED
Status|UNCONFIRMED
The current implementation stops queue before disabling the Rx interrupt,
and when there are still unprocessed packets remaining in the queue,
this may cause the Rx ring to timeout, leading to IOMMU fault.
This patch disables the Rx interrupt before stopping the queue, ensuring
that no packets rec
>
> In some openSSL 3 libraries, uninitialized output variable cause segfault. It
> is
> always nice to initialize it.
>
> Fixes: 3b7d638fb11f ("crypto/openssl: support asymmetric SM2") Bugzilla ID:
> 1250
>
> Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Anoob Joseph
>
> In some version of openSSL 3 lib (for an instance, in linux distribution), if
> SM2
> is not supported, driver should return error.
>
> Fixes: 3b7d638fb11f ("crypto/openssl: support asymmetric SM2") Bugzilla ID:
> 1250
>
> Signed-off-by: Gowrishankar Muthukrishnan
Acked-by: Anoob Joseph
I think we're basically there, just one more point that needs to be
addressed - the send_command_no_output method.
>> >> > diff --git a/dts/framework/config/conf_yaml_schema.json
>> >> > b/dts/framework/config/conf_yaml_schema.json
>> >> > index ca2d4a1e..3f7c301a 100644
>> >> > --- a/dts/framewo
71 matches
Mail list logo
