[PATCH] net/ice: adjust timestamp mbuf register

2023-05-19 Thread Wenjing Qiao
Due to only support timestamp at port level, adjust timestamp mbuf register to dev config. Fixes: 953e74e6b73a ("net/ice: enable Rx timestamp on flex descriptor") Cc: sta...@intel.com Signed-off-by: Wenjing Qiao --- drivers/net/ice/ice_ethdev.c | 10 ++ drivers/net/ice/ice_rxtx.c | 5

[v3] net/gve: check driver compatibility

2023-05-19 Thread Rushil Gupta
Change gve_driver_info fields to report DPDK as OS type and DPDK RTE version as OS version, reserving driver_version fields for GVE driver version based on features. Signed-off-by: Rushil Gupta Signed-off-by: Joshua Washington Signed-off-by: Junfeng Guo Signed-off-by: Jeroen de Borst --- 0001

[PATCH v2] net/ice: adjust timestamp mbuf register

2023-05-19 Thread Wenjing Qiao
Due to only support timestamp at port level, adjust timestamp mbuf register to dev config. Fixes: 953e74e6b73a ("net/ice: enable Rx timestamp on flex descriptor") Cc: sta...@dpdk.org Signed-off-by: Wenjing Qiao --- drivers/net/ice/ice_ethdev.c | 10 ++ drivers/net/ice/ice_rxtx.c | 5

[PATCH] net/gve: check driver compatibility

2023-05-19 Thread Rushil Gupta
Change gve_driver_info fields to report DPDK as OS type and DPDK RTE version as OS version, reserving driver_version fields for GVE driver version based on features. Signed-off-by: Rushil Gupta Signed-off-by: Joshua Washington Signed-off-by: Junfeng Guo Signed-off-by: Jeroen de Borst --- 0001

[PATCH] net/gve: check driver compatibility

2023-05-19 Thread Rushil Gupta
Change gve_driver_info fields to report DPDK as OS type and DPDK RTE version as OS version, reserving driver_version fields for GVE driver version based on features. Signed-off-by: Rushil Gupta Signed-off-by: Joshua Washington Signed-off-by: Junfeng Guo Signed-off-by: Jeroen de Borst --- driv

Re: [PATCH] net/gve: check driver compatibility

2023-05-19 Thread Rushil Gupta
Hi Ferruh I have updated the latest patch here: http://patchwork.dpdk.org/project/dpdk/patch/20230519072600.1444309-1-rush...@google.com/ However, using calloc causes issue while executing verify-compatibility command. sudo dpdk-testpmd -a 00:04.0 -l 0-32 -- --forward-mode=rxonly --txq=16 --rxq=16

[PATCH v3 00/10] net/cpfl: add hairpin queue support

2023-05-19 Thread beilei . xing
From: Beilei Xing This patchset adds hairpin queue support. v2 changes: - change hairpin rx queus configuration sequence. - code refine. v3 changes: - Refine the patchset based on the latest code. Beilei Xing (10): net/cpfl: refine structures net/cpfl: support hairpin queue capbility ge

[PATCH v3 01/10] net/cpfl: refine structures

2023-05-19 Thread beilei . xing
From: Beilei Xing This patch refines some structures to support hairpin queue, cpfl_rx_queue/cpfl_tx_queue/cpfl_vport. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 85 +++- drivers/net/cpfl/cpfl_ethdev.h | 6 +- driver

[PATCH v3 02/10] net/cpfl: support hairpin queue capbility get

2023-05-19 Thread beilei . xing
From: Beilei Xing This patch adds hairpin_cap_get ops support. Signed-off-by: Xiao Wang Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 13 + drivers/net/cpfl/cpfl_rxtx.h | 4 2 files changed, 17 insertions(+) diff --git a/drive

[PATCH v3 03/10] common/idpf: support queue groups add/delete

2023-05-19 Thread beilei . xing
From: Beilei Xing This patch adds queue group add/delete virtual channel support. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_virtchnl.c | 66 ++ drivers/common/idpf/idpf_common_virtchnl.h | 9 +++ drivers/common/idpf/version.

[PATCH v3 04/10] net/cpfl: add haipin queue group during vport init

2023-05-19 Thread beilei . xing
From: Beilei Xing This patch adds haipin queue group during vport init. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 130 + drivers/net/cpfl/cpfl_ethdev.h | 18 + drivers/net/cpfl/cpfl_rxtx.h | 4 + 3 files

[PATCH v3 05/10] net/cpfl: support hairpin queue setup and release

2023-05-19 Thread beilei . xing
From: Beilei Xing Support hairpin Rx/Tx queue setup and release. Signed-off-by: Xiao Wang Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 6 + drivers/net/cpfl/cpfl_ethdev.h | 12 + drivers/net/cpfl/cpfl_rxtx.c| 373

[PATCH v3 06/10] net/cpfl: support hairpin queue configuration

2023-05-19 Thread beilei . xing
From: Beilei Xing This patch supports Rx/Tx hairpin queue configuration. Signed-off-by: Xiao Wang Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_virtchnl.c | 70 +++ drivers/common/idpf/idpf_common_virtchnl.h | 6 + drivers/common/idpf/ve

[PATCH v3 07/10] net/cpfl: support hairpin queue start/stop

2023-05-19 Thread beilei . xing
From: Beilei Xing This patch supports Rx/Tx hairpin queue start/stop. Signed-off-by: Xiao Wang Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_virtchnl.c | 2 +- drivers/common/idpf/idpf_common_virtchnl.h | 3 + drivers/common/idpf/version.map

[PATCH v3 08/10] net/cpfl: enable write back based on ITR expire

2023-05-19 Thread beilei . xing
From: Beilei Xing This patch enabls write back based on ITR expire (WR_ON_ITR) for hairpin queue. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_device.c | 75 drivers/common/idpf/idpf_common_device.h | 4 ++ drivers/common/

[PATCH v3 09/10] net/cpfl: support peer ports get

2023-05-19 Thread beilei . xing
From: Beilei Xing This patch supports get hairpin peer ports. Signed-off-by: Xiao Wang Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_e

[PATCH v3 10/10] net/cpfl: support hairpin bind/unbind

2023-05-19 Thread beilei . xing
From: Beilei Xing This patch supports hairpin_bind/unbind ops. Signed-off-by: Xiao Wang Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 137 + drivers/net/cpfl/cpfl_rxtx.c | 28 +++ drivers/net/cpfl/cpfl_rxtx.h | 2 + 3 files changed,

Re: [PATCH 1/3] security: introduce out of place support for inline ingress

2023-05-19 Thread Jerin Jacob
On Tue, Apr 25, 2023 at 4:11 AM Thomas Monjalon wrote: > > 18/04/2023 10:33, Jerin Jacob: > > On Tue, Apr 11, 2023 at 11:36 PM Stephen Hemminger > > wrote: > > > > > > On Tue, 11 Apr 2023 15:34:07 +0530 > > > Nithin Dabilpuram wrote: > > > > > > > diff --git a/lib/security/rte_security.h b/lib/s

[PATCH v4 0/7] fix idpf and cpfl timestamp

2023-05-19 Thread Wenjing Qiao
Using alarm to save main time to solve timestamp roll over issue. Enhance timestamp offload feature support for ACC. Ajust timestamp mbuf register to dev config. *** BLURB HERE *** Wenjing Qiao (7): common/idpf: fix 64b timestamp roll over issue net/idpf: save main time by alarm net/cpfl: s

[PATCH v4 1/7] common/idpf: fix 64b timestamp roll over issue

2023-05-19 Thread Wenjing Qiao
Reading MTS register at first packet will cause timestamp roll over issue. To support calculating 64b timestamp, need an alarm to save main time from registers every 1 second. Fixes: 8c6098afa075 ("common/idpf: add Rx/Tx data path") Cc: sta...@dpdk.org Signed-off-by: Wenjing Qiao --- drivers/co

[PATCH v4 2/7] net/idpf: save main time by alarm

2023-05-19 Thread Wenjing Qiao
Using alarm to save main time from registers every 1 second. Fixes: 8c6098afa075 ("common/idpf: add Rx/Tx data path") Cc: sta...@dpdk.org Signed-off-by: Wenjing Qiao --- drivers/net/idpf/idpf_ethdev.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/idpf/idpf_ethdev.c b/dr

[PATCH v4 3/7] net/cpfl: save main time by alarm

2023-05-19 Thread Wenjing Qiao
Using alarm to save main time from registers every 1 second. Fixes: 8c6098afa075 ("common/idpf: add Rx/Tx data path") Cc: sta...@dpdk.org Signed-off-by: Wenjing Qiao --- drivers/net/cpfl/cpfl_ethdev.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/dr

[PATCH v4 4/7] common/idpf: enhance timestamp offload feature for ACC

2023-05-19 Thread Wenjing Qiao
For ACC, getting main time from MTS registers by shared memory. Notice: it is a workaround, and it will be removed after generic solution are provided. Fixes: 8c6098afa075 ("common/idpf: add Rx/Tx data path") Cc: sta...@dpdk.org Signed-off-by: Wenjing Qiao --- drivers/common/idpf/base/idpf_osd

[PATCH v4 5/7] common/idpf: add timestamp enable flag for rxq

2023-05-19 Thread Wenjing Qiao
A rxq can be configured with timestamp offload. So, add timestamp enable flag for rxq. Fixes: 8c6098afa075 ("common/idpf: add Rx/Tx data path") Cc: sta...@dpdk.org Signed-off-by: Wenjing Qiao Suggested-by: Jingjing Wu --- drivers/common/idpf/idpf_common_rxtx.c | 11 ++- drivers/common/

[PATCH v4 6/7] net/cpfl: adjust timestamp mbuf register

2023-05-19 Thread Wenjing Qiao
Due to only support timestamp at port level, adjust timestamp mbuf register to dev config. Fixes: 8c6098afa075 ("common/idpf: add Rx/Tx data path") Cc: sta...@dpdk.org Signed-off-by: Wenjing Qiao Suggested-by: Jingjing Wu --- drivers/net/cpfl/cpfl_ethdev.c | 9 +++-- drivers/net/cpfl/cpfl_

[PATCH v4 7/7] net/idpf: adjust timestamp mbuf register

2023-05-19 Thread Wenjing Qiao
Due to only support timestamp at port level, adjust timestamp mbuf register to dev config. Fixes: 8c6098afa075 ("common/idpf: add Rx/Tx data path") Cc: sta...@dpdk.org Signed-off-by: Wenjing Qiao Suggested-by: Jingjing Wu --- drivers/net/idpf/idpf_ethdev.c | 9 +++-- drivers/net/idpf/idpf_

Re: [PATCH V9] ethdev: fix one address occupies two entries in MAC addrs

2023-05-19 Thread Ferruh Yigit
On 5/19/2023 4:00 AM, Huisong Li wrote: > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > index 99fe9e238b..09b2ff9e5e 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -4381,6 +4381,9 @@ int rte_eth_dev_mac_addr_remove(uint16_t port_id, > > /** > * S

Re: [PATCH 1/2] common/sfc_efx/base: add API to drop MAE action resource IDs

2023-05-19 Thread Ferruh Yigit
On 5/18/2023 6:21 PM, Ivan Malov wrote: > Hi Ferruh, > > Thanks for reviewing this. PSB. > > On Thu, 18 May 2023, Ferruh Yigit wrote: > >> On 4/24/2023 3:30 PM, Ivan Malov wrote: >>> When the client driver (the DPDK one, for instance) parses user flow >>> actions, it ends up with an action set s

Re: [PATCH] ethdev: fix asynchronous destroy and push tracepoints

2023-05-19 Thread Ferruh Yigit
On 5/18/2023 10:59 PM, Alexander Kozyrev wrote: > > The rte_flow_async_destroy() and rte_flow_push() API is > intended to be as fast as possible and tracepoints for > these functions must be marked as fast-path tracepoints. > > Fixes: 6679cf21d608 ("ethdev: add trace points") > > Signed-off-by:

Re: [PATCH 1/2] common/sfc_efx/base: add API to drop MAE action resource IDs

2023-05-19 Thread Ivan Malov
Hi Ferruh, On Fri, 19 May 2023, Ferruh Yigit wrote: On 5/18/2023 6:21 PM, Ivan Malov wrote: Hi Ferruh, Thanks for reviewing this. PSB. On Thu, 18 May 2023, Ferruh Yigit wrote: On 4/24/2023 3:30 PM, Ivan Malov wrote: When the client driver (the DPDK one, for instance) parses user flow acti

Re: [PATCH] doc: announce inclusive naming function name changes

2023-05-19 Thread Ferruh Yigit
On 5/19/2023 7:33 AM, Chaoyong He wrote: > In order to support inclusive naming, some of the functions in > DPDK will need to be renamed. Do this through deprecation process > now for 23.07. > > Signed-off-by: Chaoyong He > --- > doc/guides/rel_notes/deprecation.rst | 12 > 1 file c

Re: [PATCH V9] ethdev: fix one address occupies two entries in MAC addrs

2023-05-19 Thread lihuisong (C)
在 2023/5/19 16:42, Ferruh Yigit 写道: On 5/19/2023 4:00 AM, Huisong Li wrote: diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index 99fe9e238b..09b2ff9e5e 100644 --- a/lib/ethdev/rte_ethdev.h +++ b/lib/ethdev/rte_ethdev.h @@ -4381,6 +4381,9 @@ int rte_eth_dev_mac_addr_remove(uint1

[PATCH V10] ethdev: fix one address occupies two entries in MAC addrs

2023-05-19 Thread Huisong Li
The dev->data->mac_addrs[0] will be changed to a new MAC address when applications modify the default MAC address by .mac_addr_set(). However, if the new default one has been added as a non-default MAC address by .mac_addr_add(), the .mac_addr_set() didn't check this address. As a result, this MAC

Re: [RFC PATCH] power: refactor uncore power management interfaces

2023-05-19 Thread Burakov, Anatoly
On 5/3/2023 6:03 PM, Sivaprasad Tummala wrote: From: Sivaprasad Tummala currently the uncore power management implementation is vendor specific. Added new vendor agnostic uncore power interface similar to rte_power and subsequently will rename specific implementations ("rte_power_intel_uncore")

Re: [PATCH] net/gve: check driver compatibility

2023-05-19 Thread Ferruh Yigit
On 5/19/2023 8:41 AM, Rushil Gupta wrote: > Hi Ferruh > I have updated the latest patch here: > http://patchwork.dpdk.org/project/dpdk/patch/20230519072600.1444309-1-rush...@google.com/ > However, using calloc causes issue while executing verify-compatibility > command. > > sudo dpdk-testpmd -a 0

RE: [PATCH v2 09/22] app/test: add lib pdcp tests

2023-05-19 Thread Anoob Joseph
Hi Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Thursday, May 18, 2023 5:36 PM > To: Anoob Joseph ; Thomas Monjalon > ; Jerin Jacob Kollanukkaran ; > Konstantin Ananyev ; Bernard > Iremonger > Cc: Hemant Agrawal ; Mattias Rönnblom > ; Kiran K

Re: [PATCH V10] ethdev: fix one address occupies two entries in MAC addrs

2023-05-19 Thread Ferruh Yigit
On 5/19/2023 10:31 AM, Huisong Li wrote: > The dev->data->mac_addrs[0] will be changed to a new MAC address when > applications modify the default MAC address by .mac_addr_set(). However, > if the new default one has been added as a non-default MAC address by > .mac_addr_add(), the .mac_addr_set()

[PATCH v2] crypto/qat: default to IPsec MB for pre and post computes

2023-05-19 Thread Brian Dooley
Pre and post computations currently use the OpenSSL library by default. This patch changes the default option to Intel IPsec MB library version 1.4 for the required computations. If this version of IPsec is not met it will fallback to use OpenSSL. Added version checks for libipsecmb and libcrypto

Re: [PATCH 2/4] eal: simplify check condition

2023-05-19 Thread Burakov, Anatoly
On 5/19/2023 5:29 AM, Ruifeng Wang wrote: The alt_elem is initialized to null. Checking only size hint flag is sufficient to return a proper value. Removed the redundant check. Signed-off-by: Ruifeng Wang Reviewed-by: Feifei Wang --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [PATCH 4/4] test/malloc: fix case expectation

2023-05-19 Thread Burakov, Anatoly
On 5/19/2023 5:29 AM, Ruifeng Wang wrote: The case expects all stats to be equal. Therefor the conditions in check should be logically or'ed. Fixes: a40a1f8231b4 ("app: various tests update") Cc: sta...@dpdk.org Signed-off-by: Ruifeng Wang Reviewed-by: Feifei Wang --- Acked-by: Anatoly Bura

Re: [PATCH 3/4] test/malloc: fix missing free

2023-05-19 Thread Burakov, Anatoly
On 5/19/2023 5:29 AM, Ruifeng Wang wrote: Free the allocated buffer before returning. Fixes: a40a1f8231b4 ("app: various tests update") Cc: sta...@dpdk.org Signed-off-by: Ruifeng Wang Reviewed-by: Feifei Wang --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [PATCH 1/4] eal: fix list index for 256 byte element

2023-05-19 Thread Burakov, Anatoly
On 5/19/2023 5:29 AM, Ruifeng Wang wrote: Elements with 2^8B size should fall into index 1 of the list. Fixes: f62f4a375ff4 ("malloc: optimize 4K allocations") Cc: changfeng...@bytedance.com Cc: sta...@dpdk.org Signed-off-by: Ruifeng Wang --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [PATCH v6] app/testpmd: txonly multiflow port change support

2023-05-19 Thread Ferruh Yigit
On 5/19/2023 1:22 AM, Joshua Washington wrote: > Google cloud routes traffic using IP addresses without the support of MAC > addresses, so changing source IP address for txonly-multi-flow can have > negative performance implications for net/gve when using testpmd. This > patch updates txonly multif

[Bug 1234] iavf : crash observed during rte_eth_dev_stop

2023-05-19 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1234 Bug ID: 1234 Summary: iavf : crash observed during rte_eth_dev_stop Product: DPDK Version: 21.11 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: major

[PATCH v4] ethdev: add indirect list flow action

2023-05-19 Thread Gregory Etelson
Indirect API creates a shared flow action with unique action handle. Flow rules can access the shared flow action and resources related to that action through the indirect action handle. In addition, the API allows to update existing shared flow action configuration. After the update completes, ne

Re: [PATCH v3] build: announce requirement for C11

2023-05-19 Thread Aaron Conole
Resending - this time to the correct list. Bruce Richardson writes: > Add a deprecation notice informing users that we will require a C11 > compiler from 23.11 release onwards. This requirement was agreed by > technical board to enable use of newer C language features, e.g. > standard atomics. [1

Re: [PATCH 0/8] make the logic conform the coding style of DPDK

2023-05-19 Thread Ferruh Yigit
On 5/19/2023 3:59 AM, Chaoyong He wrote: > Modify some logic of nfp PMD, to make it conform the coding style > of DPDK. > > Also remove some unnecessary macro and functions which DPDK has > already provided. > > Chaoyong He (8): > net/nfp: reuse the ring buffer struct > net/nfp: modify the rx

Re: [PATCH v2] net/mana: return probe failure if there is no device found

2023-05-19 Thread Ferruh Yigit
On 5/6/2023 2:32 AM, lon...@linuxonhyperv.com wrote: > From: Long Li > > When there is no device found on this PCI device, return probe failure and > release allocated resources for this PCI device. > > Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment") > Cc: sta...@dpdk.o

Re: [PATCH] doc: announce inclusive naming function name changes

2023-05-19 Thread Stephen Hemminger
On Fri, 19 May 2023 14:33:34 +0800 Chaoyong He wrote: > In order to support inclusive naming, some of the functions in > DPDK will need to be renamed. Do this through deprecation process > now for 23.07. > > Signed-off-by: Chaoyong He Acked-by: Stephen Hemminger

Re: [PATCH] net/gve: check driver compatibility

2023-05-19 Thread Rushil Gupta
I agree. Other adminq commands like gve_adminq_report_link_speed use gve_alloc_dma_mem and gve_free_dma_mem (which use rte_memzone_reserve_aligned under the hood) so let's stick to that. On Fri, May 19, 2023 at 3:04 AM Ferruh Yigit wrote: > > On 5/19/2023 8:41 AM, Rushil Gupta wrote: > > Hi Ferr

Re: [PATCH 1/2] Memory Allocation: Fixes ignore_msk during find_next_n() in fb_array library

2023-05-19 Thread Burakov, Anatoly
Hi Vipin, On 1/13/2023 1:14 PM, Vipin P R wrote: Ignore mask ignores essential bits WHICH could have been contiguous. This commit aims to rectify that Suggested rewording: fbarray: fix incorrect lookahead ignore mask Currently, when lookahead reaches a point where we've lost the run, we set

Re: [PATCH v2] net/mana: suppress TX CQE generation whenever possible

2023-05-19 Thread Ferruh Yigit
On 5/6/2023 2:32 AM, lon...@linuxonhyperv.com wrote: > From: Long Li > > When sending TX packets, we don't need a completion for every packet sent. > If packets are sent in a series, the completion of the last packet can be > used to indicate completion of all prior packets. > > Cc: sta...@dpdk.

Re: [PATCH v2] net/mana: suppress TX CQE generation whenever possible

2023-05-19 Thread Ferruh Yigit
On 5/6/2023 2:32 AM, lon...@linuxonhyperv.com wrote: > From: Long Li > > When sending TX packets, we don't need a completion for every packet sent. > If packets are sent in a series, the completion of the last packet can be > used to indicate completion of all prior packets. > > Signed-off-by: L

Re: [PATCH 2/2] Memory Allocation: Alternative fix for ignore_msk during find_next_n() in fb_array library

2023-05-19 Thread Burakov, Anatoly
Hi, This is technically not a bug fix but an improvement to the lookahead algorithm, so I don't think this needs a Fixes: tag or a Cc to stable. On 1/13/2023 1:14 PM, Vipin P R wrote: Ignore mask ignores essential bits WHICH could have been contiguous. This commit aims to rectify that Sugg

Re: [PATCH] net/mana: implement RX CQE coalescing

2023-05-19 Thread Ferruh Yigit
On 5/6/2023 2:33 AM, lon...@linuxonhyperv.com wrote: > From: Long Li > > With RX coalescing, one CQE entry can be used to indicate up to 4 packets > on the receive queue. This saves processing time and PCI bandwidth over > the CQ. > > Signed-off-by: Long Li > Applied to dpdk-next-net/main, tha

Re: [PATCH] net/mana: implement RX CQE coalescing

2023-05-19 Thread Ferruh Yigit
On 5/6/2023 2:33 AM, lon...@linuxonhyperv.com wrote: > From: Long Li > > With RX coalescing, one CQE entry can be used to indicate up to 4 packets > on the receive queue. This saves processing time and PCI bandwidth over > the CQ. > > Cc: sta...@dpdk.org > Signed-off-by: Long Li > Backport to

[PATCH v3 00/19] Replace use "sanity check"

2023-05-19 Thread Stephen Hemminger
This set of patches removes almost all use of the term sanity check. It does not address fixing the base driver code from vendors. The term sanity-check and related formats are on the Inclusive Naming Tier 2 (Strongly Consider Replacing) word list. https://inclusivenaming.org/word-lists/tier-2/san

[PATCH v3 01/19] mbuf: replace term sanity check

2023-05-19 Thread Stephen Hemminger
Replace rte_mbuf_sanity_check() with rte_mbuf_verify() to match the similar macro RTE_VERIFY() in rte_debug.h The term sanity check is on the Tier 2 list of words that should be replaced. Signed-off-by: Stephen Hemminger --- app/test/test_mbuf.c | 30 ++-- doc/guides/pro

[PATCH v3 02/19] eal: replace use of sanity check in comments and messages

2023-05-19 Thread Stephen Hemminger
Sanity check is on the Tier 2 non-inclusive list. Replace or remove it. Acked-by: Anatoly Burakov Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_memory.c | 2 +- lib/eal/common/eal_common_proc.c | 3 ++- lib/eal/common/eal_common_trace.c | 2 +- lib/eal/common/eal_memcfg.h

[PATCH v3 03/19] test: replace use word sanity

2023-05-19 Thread Stephen Hemminger
The word "sanity" is on the not-allowed inclusive naming list. Replace the unnecessary usage in tests. Signed-off-by: Stephen Hemminger --- app/test/test_bitmap.c | 4 +-- app/test/test_bpf.c| 6 ++-- app/test/test_common.c | 2 +- app/test/test_distrib

[PATCH v3 04/19] examples: remove term sanity

2023-05-19 Thread Stephen Hemminger
Do not use non-inclusive terms. Signed-off-by: Stephen Hemminger --- examples/ipsec-secgw/event_helper.c | 2 +- examples/qos_sched/args.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/ipsec-secgw/event_helper.c b/examples/ipsec-secgw/event_helper.c i

[PATCH v3 05/19] lib: replace use of sanity check in comments and messages

2023-05-19 Thread Stephen Hemminger
Sanity check is on the Tier 2 non-inclusive list. Replace or remove it. Signed-off-by: Stephen Hemminger --- lib/graph/graph.c | 2 +- lib/graph/graph_stats.c | 2 +- lib/graph/node.c| 2 +- lib/jobstats/rte_jobstats.c | 6 +++--- lib/metrics/rte_metrics.c | 2 +- lib

[PATCH v3 06/19] doc/eventdev_pipeline: remove sanity

2023-05-19 Thread Stephen Hemminger
The word sanity check is unnecessary here. Signed-off-by: Stephen Hemminger --- doc/guides/gpus/cuda.rst | 2 +- doc/guides/sample_app_ug/eventdev_pipeline.rst | 2 +- doc/guides/tools/testbbdev.rst | 8 3 files changed, 6 insertions(+), 6 deletions

[PATCH v3 08/19] net/fm10k, net/ixgbe: remove word sanity

2023-05-19 Thread Stephen Hemminger
Remove non-inclusive term sanity from these Intel drivers. Signed-off-by: Stephen Hemminger --- drivers/net/fm10k/fm10k_ethdev.c | 2 +- drivers/net/fm10k/fm10k_rxtx.c | 2 +- drivers/net/ixgbe/ixgbe_fdir.c | 2 +- drivers/net/ixgbe/ixgbe_ipsec.c | 2 +- drivers/net/ixgbe/ixgbe_rxtx.c | 2

[PATCH v3 07/19] net/ring: replace use of sanity

2023-05-19 Thread Stephen Hemminger
Don't use term sanity check Signed-off-by: Stephen Hemminger --- drivers/net/ring/rte_eth_ring.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index e8bc9b627102..e36742fda84f 100644 --- a/drivers/net/

[PATCH v3 09/19] net/mlx[45]: remove word sanity

2023-05-19 Thread Stephen Hemminger
The term "sanity" is on non-inclusive naming list. Remove it from the Nvidia drivers. Signed-off-by: Stephen Hemminger --- drivers/common/mlx5/linux/mlx5_common_os.c | 2 +- drivers/net/mlx4/mlx4.c| 2 +- drivers/net/mlx4/mlx4_flow.c | 6 +++--- drivers/net/mlx5

[PATCH v3 10/19] net/sfc: remove term "sanity check"

2023-05-19 Thread Stephen Hemminger
Remove term sanity check in comment. Signed-off-by: Stephen Hemminger --- drivers/net/sfc/sfc_dp_rx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/sfc/sfc_dp_rx.h b/drivers/net/sfc/sfc_dp_rx.h index 246adbd87cde..c64db488f652 100644 --- a/drivers/net/sfc/sfc_dp

[PATCH v3 11/19] net/ark: replace use of term sanity

2023-05-19 Thread Stephen Hemminger
Do not use non inclusive terms. Signed-off-by: Stephen Hemminger --- drivers/net/ark/ark_ethdev.c| 8 drivers/net/ark/ark_ethdev_rx.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c index b2995427c8ca

[PATCH v3 12/19] net/bnxt: replace use of term sanity

2023-05-19 Thread Stephen Hemminger
Do not use non-inclusive terms. Signed-off-by: Stephen Hemminger --- drivers/net/bnxt/bnxt_hwrm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 51e1e2d6b39b..5370293fed8d 100644 --- a/drivers/net/bnxt/bnxt_hw

[PATCH v3 14/19] cnxk: replace term sanity

2023-05-19 Thread Stephen Hemminger
Do not use non-inclusive naming. Signed-off-by: Stephen Hemminger --- drivers/common/cnxk/roc_nix_tm_ops.c | 2 +- drivers/common/cnxk/roc_npa.c| 4 ++-- drivers/net/cnxk/cnxk_ethdev.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/common/cnxk/roc_

[PATCH v3 13/19] net/bnx2x: remove reference to sanity

2023-05-19 Thread Stephen Hemminger
Replace "sanity check" Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x.c | 2 +- drivers/net/bnx2x/bnx2x_stats.c | 8 drivers/net/bnx2x/ecore_sp.c| 2 +- drivers/net/bnx2x/elink.c | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drive

[PATCH v3 15/19] event/opdl: remove term sanity

2023-05-19 Thread Stephen Hemminger
Don't use non-inclusive term. Signed-off-by: Stephen Hemminger --- drivers/event/opdl/opdl_evdev.c | 2 +- drivers/event/opdl/opdl_evdev_init.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/event/opdl/opdl_evdev.c b/drivers/event/opdl/opdl_evdev.c index 9ce8

[PATCH v3 16/19] net/txgbe: replace term sanity

2023-05-19 Thread Stephen Hemminger
Don't use term sanity. Signed-off-by: Stephen Hemminger --- drivers/net/txgbe/txgbe_ipsec.c | 2 +- drivers/net/txgbe/txgbe_rxtx.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/txgbe/txgbe_ipsec.c b/drivers/net/txgbe/txgbe_ipsec.c index f9f8108fb894..cadb094

[PATCH v3 17/19] net/cxgbe: remove use of term sanity

2023-05-19 Thread Stephen Hemminger
Remove non-inclusive terminolgy. Signed-off-by: Stephen Hemminger --- drivers/net/cxgbe/cxgbe_ethdev.c | 10 ++ drivers/net/cxgbe/cxgbevf_main.c | 4 ++-- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c

[PATCH v3 19/19] Remove use of term sanity check

2023-05-19 Thread Stephen Hemminger
Replace non-inclusive language with better comments. Acked-by: Hemant Agrawal Signed-off-by: Stephen Hemminger --- drivers/bus/fslmc/qbman/qbman_sys_decl.h | 2 +- drivers/common/dpaax/caamflib/desc.h | 2 +- drivers/dma/idxd/idxd_pci.c | 2 +- drivers/net/bonding/rte_eth_bo

[PATCH v3 18/19] crypto/bcmfs: replace term sanity check

2023-05-19 Thread Stephen Hemminger
Do not use non-inclusive naming here. Signed-off-by: Stephen Hemminger --- drivers/crypto/bcmfs/hw/bcmfs4_rm.c | 6 +++--- drivers/crypto/bcmfs/hw/bcmfs5_rm.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/bcmfs/hw/bcmfs4_rm.c b/drivers/crypto/bcmfs/hw

[PATCH] ptp: replace terms master/slave

2023-05-19 Thread Stephen Hemminger
The IEEE has revised the naming in PTP protocol. Use these new terms to replace master and slave. Signed-off-by: Stephen Hemminger --- doc/guides/nics/bnxt.rst | 7 +-- doc/guides/sample_app_ug/img/ptpclient.svg | 4 +- doc/guides/sample_app_ug/intro.rst | 4 +- doc/

[v4] net/gve: check driver compatibility

2023-05-19 Thread Rushil Gupta
Change gve_driver_info fields to report DPDK as OS type and DPDK RTE version as OS version, reserving driver_version fields for GVE driver version based on features. Signed-off-by: Rushil Gupta Signed-off-by: Joshua Washington Signed-off-by: Junfeng Guo Signed-off-by: Jeroen de Borst --- driv

Re: [PATCH v3] build: announce requirement for C11

2023-05-19 Thread Tyler Retzlaff
On Fri, May 19, 2023 at 08:19:01AM -0400, Aaron Conole wrote: > Resending - this time to the correct list. > > Bruce Richardson writes: > > Add a deprecation notice informing users that we will require a C11 > > compiler from 23.11 release onwards. This requirement was agreed by > > technical boa

Re: [PATCH] doc: announce inclusive naming function name changes

2023-05-19 Thread Tyler Retzlaff
On Fri, May 19, 2023 at 02:33:34PM +0800, Chaoyong He wrote: > In order to support inclusive naming, some of the functions in > DPDK will need to be renamed. Do this through deprecation process > now for 23.07. > > Signed-off-by: Chaoyong He > --- Acked-by: Tyler Retzlaff

Re: [PATCH] ptp: replace terms master/slave

2023-05-19 Thread Tyler Retzlaff
On Fri, May 19, 2023 at 11:15:49AM -0700, Stephen Hemminger wrote: > The IEEE has revised the naming in PTP protocol. > Use these new terms to replace master and slave. > > Signed-off-by: Stephen Hemminger > --- Acked-by: Tyler Retzlaff

Re: [PATCH] ptp: replace terms master/slave

2023-05-19 Thread Ajit Khaparde
On Fri, May 19, 2023 at 1:06 PM Tyler Retzlaff wrote: > > On Fri, May 19, 2023 at 11:15:49AM -0700, Stephen Hemminger wrote: > > The IEEE has revised the naming in PTP protocol. > > Use these new terms to replace master and slave. > > > > Signed-off-by: Stephen Hemminger > > --- > > Acked-by: Tyl

Re: [PATCH v3 00/19] Replace use "sanity check"

2023-05-19 Thread Ajit Khaparde
On Fri, May 19, 2023 at 10:46 AM Stephen Hemminger wrote: > > This set of patches removes almost all use of the term sanity check. > It does not address fixing the base driver code from vendors. > > The term sanity-check and related formats are on the > Inclusive Naming Tier 2 (Strongly Consider R

[v4] net/gve: check driver compatibility

2023-05-19 Thread Rushil Gupta
Change gve_driver_info fields to report DPDK as OS type and DPDK RTE version as OS version, reserving driver_version fields for GVE driver version based on features. Signed-off-by: Rushil Gupta Signed-off-by: Joshua Washington Signed-off-by: Junfeng Guo Signed-off-by: Jeroen de Borst --- driv

Re: [v4] net/gve: check driver compatibility

2023-05-19 Thread Stephen Hemminger
On Fri, 19 May 2023 13:46:18 -0700 Rushil Gupta wrote: > +#include > > #include "../gve_logs.h" > > +#ifdef __linux__ > +#include > +#endif > + > typedef uint8_t u8; > typedef uint16_t u16; > typedef uint32_t u32; > @@ -73,6 +78,12 @@ typedef rte_iova_t dma_addr_t; > > #define msleep