[dpdk-dev] [PATCH 1/1] net/txgbe: fix use-after-free on remove

2023-05-18 Thread Yunjian Wang
When cleaning up NIC's interrupts, it is possible to add some alarms at the same time. However, if these alarms are not canceled, it may cause use-after-free problems. Therefore, after cleaning up NIC's interrupts, these alarms should also be canceled. Fixes: d3bb4a04eac1 ("net/txgbe: add SFP hotp

Re: [PATCH v2] drivers/net/bnx2x : Add experimental 2.5Gbps support for BCM578xx.

2023-05-18 Thread Jerin Jacob
On Thu, May 18, 2023 at 5:31 AM wrote: > > From: Julien Aube > Please also add what is the change. > This has been tested with GPON's ONU SFP but requires a specific > firmware configuration. > > Signed-off-by: Julien Aube a) Please change subject to: net/bnx2x : support 2.5Gbps i.e 1) change

Re: [PATCH v1] test/event_crypto_adapter: fix runtime parameter test

2023-05-18 Thread Jerin Jacob
On Tue, Apr 18, 2023 at 8:41 AM Gujjar, Abhinandan S wrote: > > > > -Original Message- > > From: Shijith Thotton > > Sent: Monday, April 17, 2023 11:22 PM > > To: jer...@marvell.com; Naga Harish K, S V > > Cc: Shijith Thotton ; dev@dpdk.org; > > pbhagavat...@marvell.com; sta...@dpdk.org;

RE: [PATCH v2 07/22] pdcp: add pre and post process for DL

2023-05-18 Thread Anoob Joseph
HI Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Thursday, May 18, 2023 12:17 PM > To: Anoob Joseph ; Thomas Monjalon > ; Jerin Jacob Kollanukkaran ; > Konstantin Ananyev ; Bernard > Iremonger > Cc: Hemant Agrawal ; Mattias Rönnblom > ; Kiran

RE: [PATCH v2 02/22] lib: add pdcp protocol

2023-05-18 Thread Akhil Goyal
Hi Anoob, > > > +static int > > > +pdcp_entity_priv_populate(struct entity_priv *en_priv, const struct > > > rte_pdcp_entity_conf *conf) > > > +{ > > > + struct rte_crypto_sym_xform *c_xfrm, *a_xfrm; > > > + int ret; > > > + > > > + /** > > > + * flags.is_authenticated > > > + * > > > + * MAC-I

RE: [dpdk-dev] [PATCH 1/1] net/txgbe: fix use-after-free on remove

2023-05-18 Thread Jiawen Wu
> When cleaning up NIC's interrupts, it is possible to add some alarms > at the same time. However, if these alarms are not canceled, it may > cause use-after-free problems. Therefore, after cleaning up NIC's > interrupts, these alarms should also be canceled. > > Fixes: d3bb4a04eac1 ("net/txgbe:

RE: [PATCH v2 09/22] app/test: add lib pdcp tests

2023-05-18 Thread Akhil Goyal
> diff --git a/app/test/meson.build b/app/test/meson.build > index 52d9088578..0f658aa2ab 100644 > --- a/app/test/meson.build > +++ b/app/test/meson.build > @@ -96,6 +96,7 @@ test_sources = files( > 'test_meter.c', > 'test_mcslock.c', > 'test_mp_secondary.c', > +'

RE: [PATCH v2 04/22] pdcp: add packet group

2023-05-18 Thread Anoob Joseph
Hi Akhil, Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Tuesday, May 16, 2023 9:27 PM > To: Anoob Joseph ; Thomas Monjalon > ; Jerin Jacob Kollanukkaran ; > Konstantin Ananyev ; Bernard > Iremonger > Cc: Hemant Agrawal ; Mattias Rönnblom

RE: [PATCH v4] doc: update ixgbe VF features list

2023-05-18 Thread Zhang, Qi Z
> -Original Message- > From: Mingjin Ye > Sent: Wednesday, May 17, 2023 6:04 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; sta...@dpdk.org; Zhou, YidingX > ; Ye, MingjinX ; Wu, > Wenjun1 > Subject: [PATCH v4] doc: update ixgbe VF features list > > The ixgbe VF driver is not multi-process

RE: [PATCH v2 11/22] doc: add PDCP library guide

2023-05-18 Thread Akhil Goyal
> diff --git a/doc/guides/prog_guide/pdcp_lib.rst > b/doc/guides/prog_guide/pdcp_lib.rst > new file mode 100644 > index 00..abd874f2cc > --- /dev/null > +++ b/doc/guides/prog_guide/pdcp_lib.rst > @@ -0,0 +1,246 @@ > +.. SPDX-License-Identifier: BSD-3-Clause > +Copyright(C) 2023 Marvell

RE: [PATCH v2] net/e1000/base: add new devices

2023-05-18 Thread Zhang, Qi Z
> -Original Message- > From: Qiming Yang > Sent: Wednesday, May 17, 2023 2:45 PM > To: dev@dpdk.org > Cc: Su, Simei ; Yang, Qiming ; > Efrati, Nir > Subject: [PATCH v2] net/e1000/base: add new devices > > Added new device ids for I219 NIC. > > Signed-off-by: Nir Efrati > Signed-off-

[PATCH v3] ethdev: add Tx queue flow matching item

2023-05-18 Thread kirankumark
From: Kiran Kumar K Adding support for Tx queue flow matching item. This item is valid only for egress rules. An example use case would be that application can set different vlan insert rules with different PCP values based on Tx queue number. Signed-off-by: Kiran Kumar K --- app/test-pmd/cmdl

RE: [PATCH v2 02/22] lib: add pdcp protocol

2023-05-18 Thread Anoob Joseph
Hi Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Thursday, May 18, 2023 1:10 PM > To: Anoob Joseph ; Thomas Monjalon > ; Jerin Jacob Kollanukkaran ; > Konstantin Ananyev ; Bernard > Iremonger > Cc: Hemant Agrawal ; Mattias Rönnblom > ; Kiran K

Re: [PATCH] lib/mempool : rte_mempool_avail_count, fixing return bigger than mempool size

2023-05-18 Thread Yasin CANER
Hello, I found a second free command in my code and removed it. David pointed to the right . On the other hand, do you think we need to avoid miscalculations? Is it better to patch it or not? or it needs to be aware of the second free command. Sharing more information about env. # ethtool -i m

RE: [PATCH v2 02/22] lib: add pdcp protocol

2023-05-18 Thread Akhil Goyal
> > > > > diff --git a/lib/pdcp/rte_pdcp.c b/lib/pdcp/rte_pdcp.c new file > > > > > mode > > > > > 100644 index 00..8914548dbd > > > > > --- /dev/null > > > > > +++ b/lib/pdcp/rte_pdcp.c > > > > > @@ -0,0 +1,138 @@ > > > > > +/* SPDX-License-Identifier: BSD-3-Clause > > > > > + * Copyright(

RE: [PATCH] lib/mempool : rte_mempool_avail_count, fixing return bigger than mempool size

2023-05-18 Thread Morten Brørup
From: Yasin CANER [mailto:yasinnca...@gmail.com] Sent: Thursday, 18 May 2023 10.37 Hello, I found a second free command in my code and removed it. David pointed to the right . MB: Good to hear. On the other hand, do you think we need to avoid miscalculations? Is it better to patc

[Bug 1229] rte_mempool_avail_count : returns bigger than mempool size

2023-05-18 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1229 Morten Brørup (m...@smartsharesystems.com) changed: What|Removed |Added Resolution|--- |INVALID

RE: [PATCH v2 12/22] pdcp: add control PDU handling

2023-05-18 Thread Akhil Goyal
> Subject: [PATCH v2 12/22] pdcp: add control PDU handling > > Add control PDU handling and implement status report generation. Status > report generation works only when RX_DELIV = RX_NEXT. > > Signed-off-by: Anoob Joseph > Signed-off-by: Volodymyr Fialko > --- > app/test/test_pdcp.c

RE: [EXT] [PATCH 20/20] Remove use of term sanity check

2023-05-18 Thread Devendra Singh Rawat
>-Original Message- >From: Stephen Hemminger >Sent: Wednesday, May 17, 2023 9:46 PM >To: dev@dpdk.org >Cc: Stephen Hemminger ; Hemant Agrawal >; Sachin Saxena ; Bruce >Richardson ; Kevin Laatz >; Chas Williams ; Min Hu (Connor) >; Liron Himi ; Devendra Singh >Rawat ; Alok Prasad >Subje

RE: [PATCH v2 15/22] pdcp: add timer callback handlers

2023-05-18 Thread Akhil Goyal
> +struct rte_pdcp_t_reordering { > + /** Timer pointer, stored for later use in callback functions */ > + void *timer; > + /** Timer arguments, stored for later use in callback functions */ > + void *args; > + /** Timer start callback handle */ > + rte_pdcp_t_reordering_sta

RE: [PATCH v2 16/22] pdcp: add timer expiry handle

2023-05-18 Thread Akhil Goyal
> Subject: [PATCH v2 16/22] pdcp: add timer expiry handle > > From: Volodymyr Fialko > > The PDCP protocol requires usage of timers to keep track of how long > an out-of-order packet should be buffered while waiting for missing > packets. Applications can register a desired timer implementation

RE: [PATCH v3] ethdev: add Tx queue flow matching item

2023-05-18 Thread Ori Kam
Hi Kiran, > -Original Message- > From: kirankum...@marvell.com > Sent: Thursday, May 18, 2023 11:29 AM > > From: Kiran Kumar K > > Adding support for Tx queue flow matching item. > This item is valid only for egress rules. > An example use case would be that application can > set diffe

[dpdk-dev] [PATCH 1/2] common/cnxk: fix setting channel mask for SDP interfaces

2023-05-18 Thread psatheesh
From: Satheesh Paul Channel mask for SDP interfaces are by default set to a constant value. Fix this by setting mask calculated from the channel base and channel count configured in NIX LF. Fixes: f1375660 ("common/cnxk: support setting channel mask for SDP interfaces") Cc: sta...@dpdk.org

[dpdk-dev] [PATCH 2/2] common/cnxk: fix uninitialized pointer read

2023-05-18 Thread psatheesh
From: Satheesh Paul Fix uninitialized pointer read reported in coverity scan. Coverity issue: 375811 Fixes: 84d2ea9d4fb3 ("common/cnxk: support custom pre L2 header parsing as raw") Cc: sta...@dpdk.org Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar K --- drivers/common/cnxk/roc_npc_pa

Re: [PATCH] net/nfp: fix the VLAN push flow action

2023-05-18 Thread Ferruh Yigit
On 5/12/2023 3:03 AM, Chaoyong He wrote: > When process VLAN push flow action, the former logic perform the > mask and shift operations directly on the big endian data, which > cause both the pcp and VLAN id are not correct for offloaded packets. > > Fix it by convert the data from big endian to C

RE: [PATCH 20/20] Remove use of term sanity check

2023-05-18 Thread Hemant Agrawal
> -Original Message- > From: Stephen Hemminger > Replace non-inclusive language with better comments. > > Signed-off-by: Stephen Hemminger > --- > drivers/bus/fslmc/qbman/qbman_sys_decl.h | 2 +- > drivers/common/dpaax/caamflib/desc.h | 2 +- > drivers/dma/idxd/idxd_pci.c

RE: seeking community input on adapting DPDK to P4Runtime backend

2023-05-18 Thread Zhang, Qi Z
> -Original Message- > From: Ori Kam > Sent: Wednesday, May 17, 2023 11:19 PM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: techbo...@dpdk.org; Richardson, Bruce ; > Burakov, Anatoly ; Wiles, Keith > ; Liang, Cunming ; Wu, > Jingjing ; Zhang, Helin ; > Mcnamara, John ; Xu, Rosen > > Subject: R

Re: [PATCH] net/nfp: fix the Tx descriptor free logic of nfd3

2023-05-18 Thread Ferruh Yigit
On 5/12/2023 3:07 AM, Chaoyong He wrote: > In the tx descriptor free logic of nfd3, the former logic might force > cast a negative number into a very big unsigned number, and which will > cause potential problem in the xmit loop. > > The xmit loop will continue in the place where it should break,

RE: [PATCH] net/nfp: fix the Tx descriptor free logic of nfd3

2023-05-18 Thread Chaoyong He
> On 5/12/2023 3:07 AM, Chaoyong He wrote: > > In the tx descriptor free logic of nfd3, the former logic might force > > cast a negative number into a very big unsigned number, and which will > > cause potential problem in the xmit loop. > > > > The xmit loop will continue in the place where it sho

[PATCH v2] net/nfp: fix the Tx descriptor free logic of nfd3

2023-05-18 Thread Chaoyong He
In the Tx descriptor free logic of nfd3, the former logic might force cast a negative number into a very big unsigned number, and which will cause potential problem in the xmit loop. The xmit loop will continue in the place where it should break, and will overwrite the Tx descriptor which is not f

RE: [PATCH v2 09/22] app/test: add lib pdcp tests

2023-05-18 Thread Anoob Joseph
Hi Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Thursday, May 18, 2023 1:34 PM > To: Anoob Joseph ; Thomas Monjalon > ; Jerin Jacob Kollanukkaran ; > Konstantin Ananyev ; Bernard > Iremonger > Cc: Hemant Agrawal ; Mattias Rönnblom > ; Kiran K

[PATCH 0/5] ] net/hns3: add some features and bugfixes

2023-05-18 Thread Dongdong Liu
This patchset contains some features and bugfixes for hns3. Chengwen Feng (1): net/hns3: fix receive multiple firmware reset interrupts Dengdui Huang (2): net/hns3: fix loop code variable type mismatch net/hns3: add Tx/Rx descriptor logs Huisong Li (2): net/hns3: fix never set MAC flow c

[PATCH 1/5] net/hns3: fix never set MAC flow control

2023-05-18 Thread Dongdong Liu
From: Huisong Li When some hardware and firmware support speed auto-negotiation but do not support flow control auto-negotiation, driver can never successfully set MAC flow control by flow_ctrl_set() API. So only tell user driver doesn't support flow control autoneg when user enable it. Fixes: 1

[PATCH 3/5] net/hns3: fix loop code variable type mismatch

2023-05-18 Thread Dongdong Liu
From: Dengdui Huang Loop conditions are compared with different variable types, which may cause overflow risks. Signed-off-by: Dengdui Huang Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_regs.c | 3 ++- drivers/net/hns3/hns3_stats.c | 2 +- 2 files changed, 3 insertions(+), 2 deletio

[PATCH 4/5] net/hns3: fix receive multiple firmware reset interrupts

2023-05-18 Thread Dongdong Liu
From: Chengwen Feng In the firmware (also known as IMP) reset scenario, driver interrupt processing and firmware watchdog initialization are asynchronous. If the driver interrupt processing is faster than firmware watchdog initialization (that is, the driver clears the firmware reset interrupt s

[PATCH 2/5] net/hns3: add flow control autoneg for fiber and backplane port

2023-05-18 Thread Dongdong Liu
From: Huisong Li This patch support flow control autoneg for fiber and backplane port. And it depends on the capability of firmware. Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_cmd.c| 30 +- drivers/net/hns3/hns3_cmd.h| 20 ++

[PATCH 5/5] net/hns3: add Tx/Rx descriptor logs

2023-05-18 Thread Dongdong Liu
From: Dengdui Huang Add Tx/Rx descriptor logs, controlled by 'RTE_ETHDEV_DEBUG_RX/TX' compile time flag with 'pmd.net.hns3.rx/tx' log type. Signed-off-by: Dengdui Huang Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev.c | 6 ++ drivers/net/hns3/hns3_logs.h | 18

Re: [PATCH 02/20] eal: replace use of sanity check in comments and messages

2023-05-18 Thread Burakov, Anatoly
On 5/17/2023 5:15 PM, Stephen Hemminger wrote: Sanity check is on the Tier 2 non-inclusive list. Replace or remove it. Signed-off-by: Stephen Hemminger --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [PATCH] net/nfp: implement xstats functions

2023-05-18 Thread Ferruh Yigit
On 5/17/2023 8:33 AM, Chaoyong He wrote: > From: James Hershaw > > To align the stats collected by nfp_net_xstats_get() to those collected > by the `ethtool -S` command. This includes a number of extended > statistics for both nfp_net and nfp_net_vf devices, as well as MAC > statistics for nfp_ne

RE: [PATCH v2 09/22] app/test: add lib pdcp tests

2023-05-18 Thread Akhil Goyal
> > > diff --git a/app/test/meson.build b/app/test/meson.build index > > > 52d9088578..0f658aa2ab 100644 > > > --- a/app/test/meson.build > > > +++ b/app/test/meson.build > > > @@ -96,6 +96,7 @@ test_sources = files( > > > 'test_meter.c', > > > 'test_mcslock.c', > > > 'te

[PATCH v5 0/3] Split logging functionality out of EAL

2023-05-18 Thread Bruce Richardson
There is a general desire to reduce the size and scope of EAL. To this end, this patchset makes a (very) small step in that direction by taking the logging functionality out of EAL and putting it into its own library that can be built and maintained separately. As with the first RFC for this, the

[PATCH v5 1/3] eal/windows: move fnmatch function to header file

2023-05-18 Thread Bruce Richardson
To allow the fnmatch function to be shared between libraries, without having to export it into the public namespace (since it's not prefixed with "rte"), we can convert fnmatch.c to replace fnmatch.h. This allows fnmatch function to be static and limited in scope to the current file, preventing dup

[PATCH v5 2/3] log: separate logging functions out of EAL

2023-05-18 Thread Bruce Richardson
Move the logging capability to a separate library, free from EAL. Rename files as appropriate, and use meson.build to select the correct file to be built for each operating system, rather than having a subdir per-os. Add new documentation section in programmers guide to cover logging in more detail

[PATCH v5 3/3] telemetry: use standard logging

2023-05-18 Thread Bruce Richardson
Now that logging is moved out of EAL, we don't need injection of the logtype and logging function from EAL to telemetry library, simplifying things. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup Acked-by: Tyler Retzlaff --- lib/eal/freebsd/eal.c | 6 +- lib/eal/linu

[dpdk-dev] [PATCH v1] doc: process for new library approval in principle

2023-05-18 Thread jerinj
From: Jerin Jacob Based on techboard meeting[1] action item, defining the process for a new library approval in principle. [1] https://mails.dpdk.org/archives/dev/2023-January/260035.html Signed-off-by: Jerin Jacob --- RFC..v1: - Fix the review comments by Konstantin, Keven, Thomas at http://p

Re: [PATCH] usertools: add tool to generate balanced rss traffic flows

2023-05-18 Thread Burakov, Anatoly
On 4/13/2023 9:30 PM, Robin Jarry wrote: From: 6WIND usage: dpdk-rss-flows.py [-h] [-s SPORT_RANGE] [-d DPORT_RANGE] [-r] [-k RSS_KEY] [-t RETA_SIZE] [-j] RX_QUEUES SRC DST Craft IP{v6}/{TCP/UDP} traffic flows that will evenly spread over a g

RE: [PATCH v5 1/1] devtools: add tracepoint check in checkpatch

2023-05-18 Thread Ankur Dwivedi
Hi Thomas, Please let me know if there is any feedback on this patch. Regards, Ankur >-Original Message- >From: Ankur Dwivedi >Sent: Tuesday, March 7, 2023 5:35 PM >To: dev@dpdk.org >Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ; >Ankur Dwivedi >Subject: [PATCH v5 1/1] devtools:

RE: seeking community input on adapting DPDK to P4Runtime backend

2023-05-18 Thread Ori Kam
Hi Zhang, I think we both want the same thing and share the same basic concepts. PSB, some answers, Best, Ori > -Original Message- > From: Zhang, Qi Z > Sent: Thursday, May 18, 2023 1:33 PM > > > > > -Original Message- > > From: Ori Kam > > Sent: Wednesday, May 17, 2023 11

Re: [PATCH v2] net/nfp: fix the Tx descriptor free logic of nfd3

2023-05-18 Thread Ferruh Yigit
On 5/18/2023 12:02 PM, Chaoyong He wrote: > In the Tx descriptor free logic of nfd3, the former logic might force > cast a negative number into a very big unsigned number, and which will > cause potential problem in the xmit loop. > > The xmit loop will continue in the place where it should break,

RE: seeking community input on adapting DPDK to P4Runtime backend

2023-05-18 Thread Honnappa Nagarahalli
> > > > Hi Zhang, > > > > rte_flow is an excellent candidate for implementing P4. > > We and some internal tests that shows great promise in this regard. > > > > I would be very happy to supply any needed information and have > > discussion on how to continue with this project. > > Thank you Ori

Re: [PATCH v3 1/4] vhost: change vhost_virtqueue access lock to a read/write one

2023-05-18 Thread Eelco Chaudron
On 17 May 2023, at 19:33, Maxime Coquelin wrote: > Hi Eelco, > > On 5/17/23 11:08, Eelco Chaudron wrote: >> This change will allow the vhost interrupt datapath handling to be split >> between two processed without one of them holding an explicit lock. >> > > As I had a tuned PVP benchmarking se

Re: [PATCH v3] ethdev: add Tx queue flow matching item

2023-05-18 Thread Ferruh Yigit
On 5/18/2023 10:48 AM, Ori Kam wrote: > Hi Kiran, > >> -Original Message- >> From: kirankum...@marvell.com >> Sent: Thursday, May 18, 2023 11:29 AM >> >> From: Kiran Kumar K >> >> Adding support for Tx queue flow matching item. >> This item is valid only for egress rules. >> An example u

Re: [PATCH v5 1/1] devtools: add tracepoint check in checkpatch

2023-05-18 Thread Stephen Hemminger
On Thu, 18 May 2023 13:45:29 + Ankur Dwivedi wrote: > >-Original Message- > >From: Ankur Dwivedi > >Sent: Tuesday, March 7, 2023 5:35 PM > >To: dev@dpdk.org > >Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ; > >Ankur Dwivedi > >Subject: [PATCH v5 1/1] devtools: add tracepoint c

[PATCH v2 00/20] net/ice/base: code update

2023-05-18 Thread Qiming Yang
Updated share code to 2023.02 version. Qiming Yang (20): net/ice/base: updated copyright net/ice/base: add NAC Topology device capability parser net/ice/base: add new device for E810 net/ice/base: fix incorrect defines for DCBx net/ice/base: introduce a non-atomic function net/ice/base

[PATCH v2 01/20] net/ice/base: updated copyright

2023-05-18 Thread Qiming Yang
Updated copyright to 2023. Signed-off-by: Qiming Yang --- drivers/net/ice/base/README | 2 +- drivers/net/ice/base/ice_acl.c | 2 +- drivers/net/ice/base/ice_acl.h | 2 +- drivers/net/ice/base/ice_acl_ctrl.c | 2 +- drivers/net/ice/base/ice_adminq_cmd.h|

[PATCH v2 02/20] net/ice/base: add NAC Topology device capability parser

2023-05-18 Thread Qiming Yang
Define and add parsing support for new device capability ICE_AQC_CAPS_NAC_TOPOLOGY. Signed-off-by: Grzegorz Nitka Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_common.c | 26 ++ drivers/net/ice/base/ice_type.h | 10 ++ 2 files changed, 36 insertions(+

[PATCH v2 03/20] net/ice/base: add new device for E810

2023-05-18 Thread Qiming Yang
New subsystem ID is introduced for E810 NIC Signed-off-by: Milena Olech Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_common.c | 1 + drivers/net/ice/base/ice_devids.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_c

[PATCH v2 04/20] net/ice/base: fix incorrect defines for DCBx

2023-05-18 Thread Qiming Yang
In all cases but one, CEE mode is defined as 0x01 and IEEE mode is defined as 0x02. in past these values were swapped. This is causing the DCB information sent from the FW agent to be parsed with incorrect structures and resulting in incorrect values. Change the defines to match what they are in

[PATCH v2 05/20] net/ice/base: introduce a non-atomic function

2023-05-18 Thread Qiming Yang
recipe_bitmap is not aligned to 8 bytes in ice_aqc_recipe_data_elem structure and set_bit is a atomic operation we end up with a split lock. The reason for this is that recipe_bitmap might end up being in two cache lines because it's not aligned. Fix this by introducing non-atomic function ice_set_

[PATCH v2 06/20] net/ice/base: add missing AQ flag to AQ command

2023-05-18 Thread Qiming Yang
The RD flag needs to be set when virtual port rules are added since the FW needs to read the additional buffer with the mirror rule parameters. Signed-off-by: Eric Joyner Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_switch.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drive

[PATCH v2 07/20] net/ice/base: add support for inner etype in switchdev

2023-05-18 Thread Qiming Yang
Enable support for adding TC rules that filter on the inner EtherType field of tunneled packet headers. Signed-off-by: Martyna Szapar-Mudlaw Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_protocol_type.h | 2 + drivers/net/ice/base/ice_switch.c| 270 ++- 2

[PATCH v2 08/20] net/ice/base: add support for PPPoE hardware offload

2023-05-18 Thread Qiming Yang
Add support for creating PPPoE filters in switchdev mode. Add support for parsing PPPoE and PPP-specific tc options: pppoe_sid and ppp_proto. Signed-off-by: Marcin Szycik Signed-off-by: Lukasz Plachno Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_bitops.h | 2 +- drivers/net/ice/bas

[PATCH v2 09/20] net/ice/base: remove direction metadata for switchdev

2023-05-18 Thread Qiming Yang
ICE_SW_TUN_AND_NON_TUN tunnel type is used by switchdev for default MAC rules. Currently a "special word" is added to recipes for such tunnels, specifying that rule should work only in ingress direction. Because of this, all egress traffic from VF is being dropped. To fix that, add a field add_dir

[PATCH v2 10/20] net/ice/base: reduce time to read Option data

2023-05-18 Thread Qiming Yang
Re-write ice_get_orom_civd_data to allocate memory to store the Option ROM data. This change significantly reduces the time to read the Option ROM CIVD section from ~10 seconds down to ~1 second. Signed-off-by: Jacob Keller Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_nvm.c | 50

[PATCH v2 11/20] net/ice/base: add support for VLAN TPID filters

2023-05-18 Thread Qiming Yang
Enable support for adding TC rules that filter on the VLAN tag type in switchdev mode. Signed-off-by: Martyna Szapar-Mudlaw Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_protocol_type.h | 6 ++- drivers/net/ice/base/ice_switch.c| 59 ++-- drivers/net/ice/b

[PATCH v2 12/20] net/ice/base: add C825-X device ID

2023-05-18 Thread Qiming Yang
Add the device ID for the Intel(R) Ethernet Connection C825-X. Signed-off-by: Grzegorz Nitka Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_common.c | 6 +++--- drivers/net/ice/base/ice_devids.h | 7 ++- drivers/net/ice/base/ice_type.h | 1 + drivers/net/ice/ice_ethdev.c | 4

[PATCH v2 13/20] net/ice/base: add function to get rxq context

2023-05-18 Thread Qiming Yang
This patch exports rxq context which is consumed by linux live migration driver to save device state. Signed-off-by: Yahui Cao Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_common.c | 67 --- drivers/net/ice/base/ice_common.h | 7 +++- 2 files changed, 67

[PATCH v2 14/20] net/ice/base: modify tunnel match mask

2023-05-18 Thread Qiming Yang
Tunneled packets with VLAN inside were not detected by filter. This patch fix it by modifying tunnel flag match mask. As a result both type of packets (tunneled VLAN, tunneled non-VLAN) will be detected by filter. Signed-off-by: Marcin Domagala Signed-off-by: Qiming Yang --- drivers/net/ice/bas

[PATCH v2 15/20] net/ice/base: check VSIG before disassociating VSI

2023-05-18 Thread Qiming Yang
Add checking if the VSIG group exists when iterating through all flow profiles and disassociating them from the VSI. Signed-off-by: Benjamin Mikailenko Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_flow.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git

[PATCH v2 16/20] net/ice/base: delete get field vector function

2023-05-18 Thread Qiming Yang
Currently ice_get_fv() is only used inside ice_get_sw_fv_list(). Remove ice_get_fv() and call ice_get_sw_fv_list() directly. Signed-off-by: Marcin Szycik Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_ddp.c| 3 +++ drivers/net/ice/base/ice_switch.c | 23 ++- 2

[PATCH v2 17/20] net/ice/base: update 3k-sign DDP support for E825C

2023-05-18 Thread Qiming Yang
The original DDP specification has been changed in terms of Signature Type ID definition for E825-C. Signed-off-by: Grzegorz Nitka Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_common.c | 3 ++- drivers/net/ice/base/ice_ddp.c| 4 drivers/net/ice/base/ice_ddp.h| 1 + 3 fil

[PATCH v2 18/20] net/ice/base: fix static analyzer bug

2023-05-18 Thread Qiming Yang
The default condition in the switch statement in ice_sched_get_psm_clk_freq() is an unreachable code. The variable clk_src is restricted to values 0 to 3 with the bit mask and shift values set. Fixes: 76ac9d771c97 ("net/ice/base: read PSM clock frequency from register") Signed-off-by: Vignesh Srid

[PATCH v2 19/20] net/ice/base: offer memory config for schedual node

2023-05-18 Thread Qiming Yang
Add an option to pre-allocate memory for ice_sched_node struct. Add new arguments to ice_sched_add() and ice_sched_add_elems() that allow for pre-allocation of memory for ice_sched_node struct. Signed-off-by: Michal Wilczynski Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_common.c |

[PATCH v2 20/20] net/ice/base: add new AQ ro read HW sensors

2023-05-18 Thread Qiming Yang
Adds new helper function to read from HW sensors via a new AQ command "Get Sensor Reading (0x0632)". Currently, this AQ command only supports reading the temperature from E810 devices with a supported firmware, but in the future it could be extended to read other sensors. Signed-off-by: Marcin Do

RE: [PATCH] ethdev: add flow rule actions update API

2023-05-18 Thread Ori Kam
Hi Alexander, Please add rte_flow_trace_xxx for all new functions. > -Original Message- > From: Alexander Kozyrev > Sent: Tuesday, April 18, 2023 10:58 PM > > Introduce the new rte_flow_update() API allowing users > to update the action list in the already existing rule. > Flow rules ca

Re: [PATCH v4] net/bonding: replace master/slave to main/member

2023-05-18 Thread Stephen Hemminger
On Thu, 18 May 2023 16:44:58 +0800 Chaoyong He wrote: > From: Long Wu > > This patch replaces the usage of the word 'master/slave' with more > appropriate word 'main/member' in bonding PMD as well as in its docs > and examples. Also the test app and testpmd were modified to use the > new wordin

Re: [PATCH] lib/mempool : rte_mempool_avail_count, fixing return bigger than mempool size

2023-05-18 Thread Mattias Rönnblom
On 2023-05-16 18:03, Morten Brørup wrote: From: Stephen Hemminger [mailto:step...@networkplumber.org] Sent: Tuesday, 16 May 2023 17.24 On Tue, 16 May 2023 13:41:46 + Yasin CANER wrote: From: Yasin CANER after a while working rte_mempool_avail_count function returns bigger than mempool s

RE: [PATCH v2 1/3] event/cnxk: use LMTST for enqueue new burst

2023-05-18 Thread Shijith Thotton
>From: Pavan Nikhilesh > >Use LMTST when all events in the burst are enqueue with >rte_event:op as RTE_EVENT_OP_NEW i.e. events are enqueued >with the `rte_event_enqueue_new_burst` API. > >Signed-off-by: Pavan Nikhilesh Acked-by: Shijith Thotton >--- >v2 Changes: >- Fix spell check. > > driver

RE: [EXT] [PATCH v2 2/3] app/eventdev: use enqueue new event burst routine

2023-05-18 Thread Shijith Thotton
>From: Pavan Nikhilesh > >Use the `rte_event_enqueue_new_burst` routine to enqueue events >with rte_event::op as RTE_EVENT_OP_NEW. This allows PMDs to use >optimized enqueue routines. > >Signed-off-by: Pavan Nikhilesh [] Acked-by: Shijith Thotton >--- > app/test-eventdev/evt_options.c |

RE: [EXT] [PATCH v2 3/3] app/eventdev: prevent mempool exhaustion

2023-05-18 Thread Shijith Thotton
>From: Pavan Nikhilesh > >Prevent mempool exhaustion due to elements being stuck in lcore >local caches. > >Signed-off-by: Pavan Nikhilesh Acked-by: Shijith Thotton >--- > app/test-eventdev/test_perf_common.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > >diff --git a/ap

[PATCH v2 1/5] common/cnxk: fix IPsec IPv6 tunnel address byte swap

2023-05-18 Thread Rahul Bhansali
Fix the IPsec IPv6 tunnel address bytes swap during SA configurations in session create/update. Fixes: 78d03027f2cc ("common/cnxk: add IPsec common code") Cc: sta...@dpdk.org Signed-off-by: Rahul Bhansali --- Changes in v2: update in commit message for fixes and cc tag drivers/common/cnxk/cnxk

[PATCH v2 2/5] event/cnxk: set Rx offload flags

2023-05-18 Thread Rahul Bhansali
Configure event dev Rx offload flags with rx adapter start/stop callbacks. Signed-off-by: Rahul Bhansali --- Changes in v2: No change drivers/event/cnxk/cnxk_eventdev_adptr.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/event/cnxk/cnxk_eventdev_adptr.c

[PATCH v2 3/5] event/cnxk: fix Tx adapter data pointer

2023-05-18 Thread Rahul Bhansali
Dpdk test application crashes when event inline IPsec test ran for second time onwards. In case of event device cleanup, Tx adapter data pointer is free but not set back to NULL, which causes incomplete initialization on next run. Fixes: 6a24c7c4bcd1 ("event/cnxk: add Tx adapter freeing") Cc: sta.

[PATCH v2 4/5] event/cnxk: fix mempool cookies check

2023-05-18 Thread Rahul Bhansali
Fix for mempool cookies get mark to be done before meta to mbuf processing. Fixes: 7a709964d9bb ("net/cnxk: use NPA batch burst free for meta buffers") Cc: sta...@dpdk.org Signed-off-by: Rahul Bhansali --- Changes in v2: update in commit message for fixes and cc tag drivers/event/cnxk/cn10k_wo

[PATCH v2 5/5] net/cnxk: add mempool check for frag attach

2023-05-18 Thread Rahul Bhansali
Add mempool cookies get mark to all frags in case of reassembly failure. Signed-off-by: Rahul Bhansali --- Changes in v2: No change drivers/net/cnxk/cn10k_rx.h | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/cnxk/cn10k_rx.h b/drivers/net/cnxk/cn10k_rx.h index 9fdb5565e9

Re: [PATCH V3] lib: set/get max memzone segments

2023-05-18 Thread Burakov, Anatoly
Hi, On 5/3/2023 8:26 AM, Ophir Munk wrote: In current DPDK the RTE_MAX_MEMZONE definition is unconditionally hard coded as 2560. For applications requiring different values of this parameter – it is more convenient to set the max value via an rte API - rather than changing the dpdk source code

[PATCH v2 1/3] lib: add IPv6 lookup node

2023-05-18 Thread Amit Prakash Shukla
From: Sunil Kumar Kori Similar to IPv4 lookup node, patch adds IPv6 lookup node. Signed-off-by: Sunil Kumar Kori Signed-off-by: Amit Prakash Shukla --- v2: - Performance related changes doc/guides/prog_guide/graph_lib.rst | 13 + lib/node/ip6_lookup.c | 374 +++

[PATCH v2 2/3] lib: add IPv6 rewrite node

2023-05-18 Thread Amit Prakash Shukla
Similar to IPv4 rewrite node, patch adds IPv6 rewrite node. Signed-off-by: Amit Prakash Shukla --- v2: - Performance related changes doc/guides/prog_guide/graph_lib.rst | 8 + lib/node/ethdev_ctrl.c | 13 ++ lib/node/ip6_rewrite.c | 331

[PATCH v2 3/3] examples/l3fwd-graph: add IPv6 lookup and rewrite support

2023-05-18 Thread Amit Prakash Shukla
From: Sunil Kumar Kori Similar to ipv4, to support IPv6 lookup and rewrite node routes and rewrite data needs to be added. Patch adds routes for ipv6 to validate ip6_lookup node and rewrite data to validate ip6_rewrite node. Signed-off-by: Sunil Kumar Kori Signed-off-by: Amit Prakash Shukla

Re: [PATCH 1/2] common/sfc_efx/base: add API to drop MAE action resource IDs

2023-05-18 Thread Ferruh Yigit
On 4/24/2023 3:30 PM, Ivan Malov wrote: > When the client driver (the DPDK one, for instance) parses user flow > actions, it ends up with an action set specification. Next, in case > there are any FW resource-backed actions, like COUNT or SET_DST_MAC, > the driver allocates these resources and indi

[PATCH v2 00/19] Replace use of the term sanity-check

2023-05-18 Thread Stephen Hemminger
This set of patches removes almost all use of the term sanity check in DPDK. Did not address base drivers which come from vendors. It is up to them to fix that. The term sanity-check and related formats are on the Inclusive Naming Tier 2 (Strongly Consider Replacing) word list. https://inclusive

[PATCH v2 01/19] mbuf: replace term sanity check

2023-05-18 Thread Stephen Hemminger
Replace rte_mbuf_sanity_check() with rte_mbuf_verify() to match the similar macro RTE_VERIFY() in rte_debug.h The term sanity check is on the Tier 2 list of words that should be replaced. Signed-off-by: Stephen Hemminger --- app/test/test_mbuf.c | 30 ++--- doc/guides/prog

[PATCH v2 02/19] eal: replace use of sanity check in comments and messages

2023-05-18 Thread Stephen Hemminger
Sanity check is on the Tier 2 non-inclusive list. Replace or remove it. Acked-by: Anatoly Burakov Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_memory.c | 2 +- lib/eal/common/eal_common_proc.c | 3 ++- lib/eal/common/eal_common_trace.c | 2 +- lib/eal/common/eal_memcfg.h

[PATCH v2 03/19] test: replace use word sanity

2023-05-18 Thread Stephen Hemminger
The word "sanity" is on the not-allowed inclusive naming list. Replace the unnecessary usage in tests. Signed-off-by: Stephen Hemminger --- app/test/test_bitmap.c | 4 +-- app/test/test_bpf.c| 6 ++-- app/test/test_common.c | 2 +- app/test/test_distrib

[PATCH v2 04/19] examples: remove term sanity

2023-05-18 Thread Stephen Hemminger
Do not use non-inclusive terms. Signed-off-by: Stephen Hemminger --- examples/ipsec-secgw/event_helper.c | 2 +- examples/qos_sched/args.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/ipsec-secgw/event_helper.c b/examples/ipsec-secgw/event_helper.c i

[PATCH v2 07/19] net/ring: replace use of sanity

2023-05-18 Thread Stephen Hemminger
Don't use term sanity check Signed-off-by: Stephen Hemminger --- drivers/net/ring/rte_eth_ring.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index e8bc9b627102..e36742fda84f 100644 --- a/drivers/net/

[PATCH v2 06/19] doc/eventdev_pipeline: remove sanity

2023-05-18 Thread Stephen Hemminger
The word sanity check is unnecessary here. Signed-off-by: Stephen Hemminger --- doc/guides/gpus/cuda.rst | 2 +- doc/guides/sample_app_ug/eventdev_pipeline.rst | 2 +- doc/guides/tools/testbbdev.rst | 8 3 files changed, 6 insertions(+), 6 deletions

[PATCH v2 08/19] net/fm10k, net/ixgbe: remove word sanity

2023-05-18 Thread Stephen Hemminger
Remove non-inclusive term sanity from these Intel drivers. Signed-off-by: Stephen Hemminger --- drivers/net/fm10k/fm10k_ethdev.c | 2 +- drivers/net/fm10k/fm10k_rxtx.c | 2 +- drivers/net/ixgbe/ixgbe_fdir.c | 2 +- drivers/net/ixgbe/ixgbe_ipsec.c | 2 +- drivers/net/ixgbe/ixgbe_rxtx.c | 2

[PATCH v2 09/19] net/mlx[45]: remove word sanity

2023-05-18 Thread Stephen Hemminger
The term "sanity" is on non-inclusive naming list. Remove it from the Nvidia drivers. Signed-off-by: Stephen Hemminger --- drivers/common/mlx5/linux/mlx5_common_os.c | 2 +- drivers/net/mlx4/mlx4.c| 2 +- drivers/net/mlx4/mlx4_flow.c | 6 +++--- drivers/net/mlx5

[PATCH v2 05/19] lib: replace use of sanity check in comments and messages

2023-05-18 Thread Stephen Hemminger
Sanity check is on the Tier 2 non-inclusive list. Replace or remove it. Signed-off-by: Stephen Hemminger --- lib/graph/graph.c | 2 +- lib/graph/graph_stats.c | 2 +- lib/graph/node.c| 2 +- lib/jobstats/rte_jobstats.c | 6 +++--- lib/metrics/rte_metrics.c | 2 +- lib

  1   2   >