RE: [PATCH v5 11/14] eal: expand most macros to empty when using MSVC

2023-04-15 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Friday, 14 April 2023 19.02 > > On Fri, Apr 14, 2023 at 08:45:17AM +0200, Morten Brørup wrote: > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > > Sent: Thursday, 13 April 2023 23.26 > > > > > > For now expand

[GRO] check whether ip_id continuity needs to be checked when two TCP packets are merged.

2023-04-15 Thread jiangheng (G)
Hi jiayu.hu It cannot be guaranteed that 16bit identification field of ip packets in the same tcp stream will be continuous. Please help check whether ip_id continuity needs to be checked when two TCP packets are merged? Seems to modify the following code, gro will aggregate better, and work bet

Re: [PATCH v5 11/14] eal: expand most macros to empty when using MSVC

2023-04-15 Thread Tyler Retzlaff
On Sat, Apr 15, 2023 at 09:16:21AM +0200, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Friday, 14 April 2023 19.02 > > > > On Fri, Apr 14, 2023 at 08:45:17AM +0200, Morten Brørup wrote: > > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.c

RE: [PATCH v5 11/14] eal: expand most macros to empty when using MSVC

2023-04-15 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Saturday, 15 April 2023 22.52 > > On Sat, Apr 15, 2023 at 09:16:21AM +0200, Morten Brørup wrote: > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > > Sent: Friday, 14 April 2023 19.02 > > > > > > On Fri, Apr 14,

Re: [PATCH v5 11/14] eal: expand most macros to empty when using MSVC

2023-04-15 Thread Stephen Hemminger
On Sun, 16 Apr 2023 00:41:54 +0200 Morten Brørup wrote: > > > > > > /** > > > > > > * Force a structure to be packed > > > > > > */ > > > > > > +#ifndef RTE_TOOLCHAIN_MSVC > > > > > > #define __rte_packed __attribute__((__packed__)) > > > > > > +#else > > > > > > +#define __rte_packed > > >