Re: [PATCH 0/6] add support for CDX bus

2023-04-07 Thread David Marchand
Hello, On Fri, Apr 7, 2023 at 8:02 AM Nipun Gupta wrote: > > Support AMD CDX bus, for FPGA based CDX devices. The CDX > devices are memory mapped on system bus for embedded CPUs. > > It uses sysfs interface and the vfio-cdx driver to discover > and initialize the CDX devices. > > The patches are

Re: [PATCH v2] vfio: do not coalesce DMA mappings

2023-04-07 Thread David Marchand
Hello Nipun, Anatoly, On Fri, Apr 7, 2023 at 8:13 AM Nipun Gupta wrote: > > The patch probably shouldn't include the mailmap changes :) Mailmap changes can be done by the submitter. So Nipun did nothing wrong. > > I see in "git log" that all the mailmap changes are with the patch > submitted, p

Re: [PATCH 0/6] add support for CDX bus

2023-04-07 Thread Nipun Gupta
On 4/7/2023 12:48 PM, David Marchand wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. Hello, On Fri, Apr 7, 2023 at 8:02 AM Nipun Gupta wrote: Support AMD CDX bus, for FPGA based CDX devices. The

[PATCH] doc: fix event timer adapter guide

2023-04-07 Thread pbhagavatula
From: Pavan Nikhilesh Remove incorrect spec definition from programmers guide, it is applications responsibility to set ev.event_ptr to a valid value. Fixes: 30e7fbd62839 ("doc: add event timer adapter guide") Signed-off-by: Pavan Nikhilesh --- doc/guides/prog_guide/event_timer_adapter.rst |

[PATCH] ring: fix the variable name error

2023-04-07 Thread Feifei Wang
Ring dequeue operation's parameters name should be 'cons_xx', rather than 'prod_xxx'. Fixes: 1fc73390bcf5 ("ring: refactor exported headers") Cc: sta...@dpdk.org Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang --- lib/ring/rte_ring_elem_pvt.h | 8 1 file changed, 4 insertions(+),

[PATCH 1/1] net/ixgbe: add a proper memory barrier for LoongArch

2023-04-07 Thread Min Zhou
Segmentation fault has been observed while running the ixgbe_recv_pkts_lro() function to receive packets on the Loongson 3C5000 processor which has 64 cores and 4 NUMA nodes. Reason is the read ordering of the status and the rest of the descriptor fields in this function may not be correct on the

[Bug 1212] [dpdk-21.11.8]pvp_qemu_multi_paths_port_restart:perf_pvp_qemu_vector_rx_mac: performance drop about 23.5% when send small packets

2023-04-07 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1212 Bug ID: 1212 Summary: [dpdk-21.11.8]pvp_qemu_multi_paths_port_restart:perf_p vp_qemu_vector_rx_mac: performance drop about 23.5% when send small packets Product: DPDK Ver

Re: [PATCH] common/sfc_efx/base: support link status change v2 events

2023-04-07 Thread Ferruh Yigit
On 3/30/2023 8:16 AM, Andrew Rybchenko wrote: > On 3/28/23 19:51, Ivan Malov wrote: >> FW should send link status change events in either v1 or >> v2 format depending on the preference which the driver >> can express during CMD_DRV_ATTACH stage. At the moment, >> libefx does not request v2, so v1 e

Clarify FEC capabilities

2023-04-07 Thread Denis Pryazhennikov
Hi, We are currently working on implementing the Forward Error Correction (FEC) feature in our driver, but we have encountered some difficulties in understanding the interpretation of the semantics of 'fec_capa', a bitmask of allowed FEC modes. Specifically, we are unclear about the meaning o

RE: [PATCH] app/crypto-perf: change buffer size based on optype

2023-04-07 Thread Power, Ciara
> -Original Message- > From: Tejasree Kondoj > Sent: Thursday 6 April 2023 09:16 > To: Akhil Goyal ; Fan Zhang > ; Power, Ciara > Cc: Anoob Joseph ; dev@dpdk.org > Subject: [PATCH] app/crypto-perf: change buffer size based on optype > > Adding digest size to buffer size in auth-then-c

RE: [PATCH] ring: fix the variable name error

2023-04-07 Thread Morten Brørup
> From: Feifei Wang [mailto:feifei.wa...@arm.com] > Sent: Friday, 7 April 2023 10.48 > > Ring dequeue operation's parameters name should be 'cons_xx', > rather than 'prod_xxx'. > > Fixes: 1fc73390bcf5 ("ring: refactor exported headers") > Cc: sta...@dpdk.org > > Signed-off-by: Feifei Wang > Rev

DPDK Release Status Meeting 2023-04-06

2023-04-07 Thread Mcnamara, John
Release status meeting minutes 2023-04-06 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * AMD * ARM * Debian/Microsoft * Intel * Marvell * Nvidia * Red Hat Release Dates - The following are the proposed

[Bug 1213] [Windows] BSOD when shutting down testpmd

2023-04-07 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1213 Bug ID: 1213 Summary: [Windows] BSOD when shutting down testpmd Product: DPDK Version: 22.11 Hardware: All OS: Windows Status: UNCONFIRMED Severity: major

Re: [PATCH] net/hns3: fix build warning

2023-04-07 Thread Ferruh Yigit
On 4/4/2023 9:22 AM, Dongdong Liu wrote: > Hi Jerin > > Many thanks for fixing the warning. > On 2023/4/4 14:55, jer...@marvell.com wrote: >> From: Jerin Jacob >> >> aarch64 gcc 12.2.0 build complain with below warning[1]. >> Move the new_link initialization upwards to fix the warning. >> >> Comp

Re: [PATCH v2 1/5] telemetry: fix autotest failures on Alpine

2023-04-07 Thread Tyler Retzlaff
On Wed, Apr 05, 2023 at 04:44:10PM +0100, Bruce Richardson wrote: > On Alpine linux, the telemetry_data_autotest was failing for the > test where we had dictionaries embedded in other dictionaries up > to three levels deep. Indications are that this issue is due to > excess data being stored on the

Re: [PATCH v3 1/5] telemetry: fix autotest failures on Alpine

2023-04-07 Thread Tyler Retzlaff
On Wed, Apr 05, 2023 at 05:03:22PM +0100, Bruce Richardson wrote: > On Alpine linux, the telemetry_data_autotest was failing for the > test where we had dictionaries embedded in other dictionaries up > to three levels deep. Indications are that this issue is due to > excess data being stored on the

Re: [PATCH v3 2/5] telemetry: remove variable length array in printf fn

2023-04-07 Thread Tyler Retzlaff
On Wed, Apr 05, 2023 at 05:03:23PM +0100, Bruce Richardson wrote: > The json_snprintf function, used to add json characters on to a buffer, > leaving the buffer unmodified in case of error, used a variable length > array to store the data temporarily while checking for overflow. VLAs > can be unsaf

Re: [PATCH v3 3/5] telemetry: split out body of json string format fn

2023-04-07 Thread Tyler Retzlaff
On Wed, Apr 05, 2023 at 05:03:24PM +0100, Bruce Richardson wrote: > To enable further rework to (efficiently) avoid using variable-length > arrays, we first separate out the body of the __json_format_str > function. This means that the actual VLA buffer is in the wrapper > function, and means we ca

Re: [PATCH v3 4/5] telemetry: rename local variables

2023-04-07 Thread Tyler Retzlaff
On Wed, Apr 05, 2023 at 05:03:25PM +0100, Bruce Richardson wrote: > In the newly separated out function, rename "tmp" to "buf" to have more > meaningful variable names. > > Signed-off-by: Bruce Richardson > > --- Acked-by: Tyler Retzlaff (with suggestions) > > When committing, this patch can

Re: [PATCH v3 5/5] telemetry: remove VLA in json string format function

2023-04-07 Thread Tyler Retzlaff
On Wed, Apr 05, 2023 at 05:03:26PM +0100, Bruce Richardson wrote: > Since variable length arrays (VLAs) are potentially insecure and > unsupported by some compilers, rework the code to remove their use. As > with previous changes to remove VLAs in the telemetry code, this > function uses two method

[PATCH 0/7] add setting and querying of LLRS FEC mode

2023-04-07 Thread Dongdong Liu
This patchset include some bugfixes for hns3 fec and add setting and querying of LLRS FEC mode. Jie Hai (7): net/hns3: fix fec mode for 200G ports net/hns3: fix fec mode check error net/hns3: fix missing FEC capability ethdev: introduce low latency RS FEC app/testpmd: add setting and que

[PATCH 1/7] net/hns3: fix fec mode for 200G ports

2023-04-07 Thread Dongdong Liu
From: Jie Hai The hardware does not support NOFEC for 200G ports. So delete this bit. Fixes: 9bf2ea8dbc65 ("net/hns3: support FEC") Cc: sta...@dpdk.org Signed-off-by: Jie Hai Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-

[PATCH 2/7] net/hns3: fix fec mode check error

2023-04-07 Thread Dongdong Liu
From: Jie Hai The function is_fec_mode_one_bit_set() is used to check whether the binary of the mode from user only contains one '1'. But it uses the bytes number this mode variable occupied to calculate the count. So this patch uses __builtin_popcount() to replace it. This patch also extracts t

[PATCH 3/7] net/hns3: fix missing FEC capability

2023-04-07 Thread Dongdong Liu
From: Jie Hai Currently, FEC capabilities are reported based on the device ID. And a device ID is bound to only one or two rates. So some cases hns3 driver only reports the FEC capabilities corresponding to the rate. But hns3 supports speed switching function, which causes the FEC capabilities of

[PATCH 4/7] ethdev: introduce low latency RS FEC

2023-04-07 Thread Dongdong Liu
From: Jie Hai This patch introduces LLRS (low latency Reed Solomon FEC). LLRS supports for 25 Gbps, 50 Gbps, 100 Gbps, 200 Gbps and 400 Gbps Ethernet networks. Signed-off-by: Jie Hai Signed-off-by: Dongdong Liu --- doc/guides/rel_notes/release_23_07.rst | 3 +++ lib/ethdev/rte_ethdev.h

[PATCH 5/7] app/testpmd: add setting and querying of LLRS FEC mode

2023-04-07 Thread Dongdong Liu
From: Jie Hai This patch supports setting and querying of LLRS FEC mode. Signed-off-by: Jie Hai Signed-off-by: Dongdong Liu --- app/test-pmd/cmdline.c | 5 - app/test-pmd/config.c | 4 doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +- 3 fi

[PATCH 7/7] net/hns3: support getting current FEC capability from firmware

2023-04-07 Thread Dongdong Liu
From: Jie Hai Obtain the supported FEC capability from the firmware to enhance code compatibility. Cc: sta...@dpdk.org Signed-off-by: Jie Hai Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_cmd.h| 9 - drivers/net/hns3/hns3_ethdev.c | 29 + driv

[PATCH 6/7] net/hns3: add LLRS FEC mode support for 200G ports

2023-04-07 Thread Dongdong Liu
From: Jie Hai This patch supports the query and configuration of LLRS FEC mode. Signed-off-by: Jie Hai Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_cmd.c| 1 + drivers/net/hns3/hns3_cmd.h| 2 ++ drivers/net/hns3/hns3_ethdev.c | 21 - 3 files changed, 15