RE: [PATCH v10 6/6] ethdev: add trace points for tm

2023-03-15 Thread Yuan, DukaiX
Hi Ankur, I get an error message when I launch testpmd with Asan, I need your help to confirm this issue. For more information please refer to https://bugs.dpdk.org/show_bug.cgi?id=1184. Waiting for your reply. Best regards, Dukai,Yuan > -Original Message- > From: Ankur Dwivedi > Sent:

[PATCH v1] eventdev/timer: use loop to check for timeout events

2023-03-15 Thread Shijith Thotton
Replaced sleep with a function to dequeue timer expiry events until either the expected number of events have been dequeued or the specified time has elapsed. This change closely esembles the behavior of the tested systems. Signed-off-by: Shijith Thotton --- app/test/test_event_timer_adapter.c |

Re: [PATCH v2 1/1] mldev: split bfloat16 routines to separate files

2023-03-15 Thread David Marchand
Hello, On Mon, Mar 13, 2023 at 1:03 PM Srikanth Yalavarthi wrote: > > Since bfloat16 intrinsics are not supported on all ARM platforms > that support NEON, bfloat16 routines are moved to separate files. > This would enable using scalar implementation for bfloat16 on > unsupported ARM platforms. >

[PATCH v3] net/ice: fix ice dcf control thread crash

2023-03-15 Thread Mingjin Ye
The control thread accesses the hardware resources after the resources were released, resulting in a segment error. This commit fixes the issue by waiting for all `ice-reset` threads to finish before reclaiming resources. Fixes: b71573ec2fc2 ("net/ice: retry getting VF VSI map after failure") Fix

Re: [PATCH] app/testpmd: dump private info in 'show port info'

2023-03-15 Thread Singh, Aman Deep
On 3/15/2023 8:03 AM, Chengwen Feng wrote: This patch adds dump private info in 'show port info [port_id]' cmd. Signed-off-by: Chengwen Feng Acked-by: Aman Singh --- app/test-pmd/config.c | 5 + 1 file changed, 5 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/con

[PATCH] net/iavf: fix VLAN Tx in AVX512

2023-03-15 Thread Zhichao Zeng
This patch fixes the insertion of the Vlan tci, which was broken by previous incorrect modification. Fixes: 4f8259df563a ("net/iavf: enable Tx outer checksum offload on AVX512") Signed-off-by: Zhichao Zeng --- drivers/net/iavf/iavf_rxtx_vec_avx512.c | 30 - drivers/net/i

RE: [PATCH] net/iavf: fix VLAN Tx in AVX512

2023-03-15 Thread Xu, Ke1
> -Original Message- > From: Zeng, ZhichaoX > Sent: Wednesday, March 15, 2023 4:46 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Zhou, YidingX > ; Xu, Ke1 ; Huang, ZhiminX > ; Zeng, ZhichaoX ; > Richardson, Bruce ; Konstantin Ananyev > ; Wu, Jingjing ; > Xing, Beilei > Subject: [PATCH] net/

Re: [PATCH v3 0/3] testpmd control C fixes

2023-03-15 Thread David Marchand
On Tue, Mar 14, 2023 at 11:40 PM Stephen Hemminger wrote: > > On Tue, 14 Mar 2023 10:36:45 -0700 > Stephen Hemminger wrote: > > > Resolve issues around using control-C in testpmd. > > Using cmdline_poll() is broken and won't work right so > > don't use it. Instead use cmdline_interact() and fix >

Re: [PATCH] mldev: fix identical code in conditional branches

2023-03-15 Thread David Marchand
On Mon, Mar 13, 2023 at 12:01 PM David Marchand wrote: > On Sat, Mar 11, 2023 at 3:56 PM Srikanth Yalavarthi > wrote: > > > > Fix identical code in different conditional branches in float32 > > to float16 conversion function. Issue reported in coverity scan. > > > > Coverity issue: 383651 > > Fix

Re: [PATCH] mldev: remove variable self assignment in dev init

2023-03-15 Thread David Marchand
On Mon, Mar 13, 2023 at 8:19 PM Tyler Retzlaff wrote: > > On Sat, Mar 11, 2023 at 06:57:04AM -0800, Srikanth Yalavarthi wrote: > > Fix variable self assignment in rte_ml_devinit. > > Issue reported by coverity scan. > > > > Coverity issue: 383652 > > Fixes: ea80eafbd4d8 ("mldev: add PMD functions"

Re: [PATCH v2 1/1] mldev: remove weak symbols use in type conversions

2023-03-15 Thread David Marchand
On Mon, Mar 13, 2023 at 12:37 PM Srikanth Yalavarthi wrote: > > Drop use of weak symbols to select the type conversion > functions. Select NEON implementation only on Aarch64 > builds. Enable windows build. > > Fixes: 9637de38a2e3 ("mldev: add scalar type conversion") > > Signed-off-by: Srikanth Y

RE: [PATCH v2 1/1] mldev: split bfloat16 routines to separate files

2023-03-15 Thread Ruifeng Wang
> -Original Message- > From: Srikanth Yalavarthi > Sent: Monday, March 13, 2023 8:03 PM > To: Srikanth Yalavarthi ; Ruifeng Wang > > Cc: dev@dpdk.org; sshankarn...@marvell.com; david.march...@redhat.com > Subject: [PATCH v2 1/1] mldev: split bfloat16 routines to separate files > > Since

Re: [PATCH] net/mlx5: fix build with GCC 12 and ASan

2023-03-15 Thread David Marchand
On Tue, Mar 14, 2023 at 2:00 PM Slava Ovsiienko wrote: > > Hi, David > > Thank you for the fix. > I see the quite similar strncpy() usage in mlx5_xstats_get_names() routine. > Does compiler complain about? Strangely.. no. But we could switch to strlcpy too. What is your preferrence? -- David M

RE: release candidate 23.03-rc2

2023-03-15 Thread Jiang, YuX
> -Original Message- > From: Thomas Monjalon > Sent: Sunday, March 12, 2023 11:27 PM > To: annou...@dpdk.org > Subject: release candidate 23.03-rc2 > > A new DPDK release candidate is ready for testing: > https://git.dpdk.org/dpdk/tag/?id=v23.03-rc2 > > There are 319 new patches in t

Re: [PATCH] app/testpmd: dump private info in 'show port info'

2023-03-15 Thread Ferruh Yigit
On 3/15/2023 2:33 AM, Chengwen Feng wrote: > This patch adds dump private info in 'show port info [port_id]' cmd. > > Signed-off-by: Chengwen Feng > --- > app/test-pmd/config.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index 01

Re: [Bug 1024] [dpdk-22.07][meson test] driver-tests/link_bonding_mode4_autotest bond handshake failed

2023-03-15 Thread David Marchand
On Thu, Jun 2, 2022 at 11:55 AM wrote: > > https://bugs.dpdk.org/show_bug.cgi?id=1024 > > Bug ID: 1024 >Summary: [dpdk-22.07][meson test] > driver-tests/link_bonding_mode4_autotest bond > handshake failed >Product: DPDK >

Re: [PATCH] app: fix mbuf_autotest in case of defined RTE_LIBRTE_MBUF_DEBUG

2023-03-15 Thread David Marchand
Hello, On Mon, Mar 13, 2023 at 5:57 PM Pavel Ivashchenko wrote: > > How to reproduce: > > 1. Define RTE_LIBRTE_MBUF_DEBUG > 2. MALLOC_PERTURB_=178 DPDK_TEST=mbuf_autotest gdb --args > obj-x86_64-linux-gnu/app/test/dpdk-test --file-prefix=mbuf_autotest > >PANIC in rte_mbuf_sanity_check(): >

RE: [PATCH] app/compress-perf: fix remaining data for ops

2023-03-15 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Power, Ciara > Sent: Friday, March 10, 2023 4:27 PM > Cc: dev@dpdk.org; Ji, Kai ; Kusztal, ArkadiuszX > ; michae...@nvidia.com; Power, Ciara > > Subject: [PATCH] app/compress-perf: fix remaining data for ops > > From: Arkadiusz Kusztal >

RE: [PATCH v2 1/1] mldev: split bfloat16 routines to separate files

2023-03-15 Thread Srikanth Yalavarthi
> -Original Message- > From: Ruifeng Wang > Sent: 15 March 2023 15:32 > To: Srikanth Yalavarthi > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; david.march...@redhat.com; nd > > Subject: [EXT] RE: [PATCH v2 1/1] mldev: split bfloat16 routines to separate > files > > External

[PATCH 0/5] support setting and querying RSS algorithms

2023-03-15 Thread Dongdong Liu
This patchset is to support setting and querying RSS algorithms. Huisong Li (1): net/hns3: support setting and querying RSS hash function Jie Hai (4): ethdev: support setting and querying rss algorithm app/proc-info: fix never show RSS info app/proc-info: show RSS types with strings app

[PATCH 1/5] ethdev: support setting and querying rss algorithm

2023-03-15 Thread Dongdong Liu
From: Jie Hai Currently, rte_eth_rss_conf supports configuring rss hash functions, rss key and it's length, but not rss hash algorithm. The structure ``rte_eth_rss_conf`` is extended by adding a new field, "func". This represents the RSS algorithms to apply. The following API is affected:

[PATCH 2/5] net/hns3: support setting and querying RSS hash function

2023-03-15 Thread Dongdong Liu
From: Huisong Li Support setting and querying RSS hash function by ethdev ops. Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_rss.c | 47 + 1 file changed, 27 insertions(+), 20 deletions(-) diff --git a/drivers/net/hns3/hns

[PATCH 3/5] app/proc-info: fix never show RSS info

2023-03-15 Thread Dongdong Liu
From: Jie Hai Command show-port shows rss info only if rss_conf.rss_key is not null but it will never be true. This patch allocates memory for rss_conf.rss_key and makes it possible to show rss info. Fixes: 8a37f37fc243 ("app/procinfo: add --show-port") Cc: sta...@dpdk.org Signed-off-by: Jie Ha

[PATCH 4/5] app/proc-info: show RSS types with strings

2023-03-15 Thread Dongdong Liu
From: Jie Hai show RSS types details and adjust RSS info display format as following: - RSS info -- hf: ipv4 ipv4-frag ipv4-other ipv6 ipv6-frag ipv6-other -- key len: 40 -- key (hex): 6d5a56da255b0ec24167253d43a38fb0d0ca2bcbae7b30b477cb2da38

[PATCH 5/5] app/proc-info: support querying RSS hash algorithm

2023-03-15 Thread Dongdong Liu
From: Jie Hai Display RSS hash algorithm with command show-port as below. - RSS info -- hash algorithm: toeplitz Signed-off-by: Jie Hai Signed-off-by: Dongdong Liu --- app/proc-info/main.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/app/proc-info/main.

RE: [EXT] [PATCH] crypto/openssl: support SM3/SM4 in openssl

2023-03-15 Thread Akhil Goyal
> Subject: RE: [EXT] [PATCH] crypto/openssl: support SM3/SM4 in openssl > > > Subject: [EXT] [PATCH] crypto/openssl: support SM3/SM4 in openssl > > You should update the title with version number to identify each > Version and remove confusion. > > Also, I see that there are compilation issues r

Re: [PATCH 1/5] ethdev: support setting and querying rss algorithm

2023-03-15 Thread Ivan Malov
Hi, On Wed, 15 Mar 2023, Dongdong Liu wrote: From: Jie Hai Currently, rte_eth_rss_conf supports configuring rss hash functions, rss key and it's length, but not rss hash algorithm. The structure ``rte_eth_rss_conf`` is extended by adding a new field, "func". This represents the RSS algorithm

[PATCH] vhost: fix madvise IOTLB entries pages overlap check

2023-03-15 Thread Maxime Coquelin
At removal time, when testing whether the IOTLB entry has shared pages with the previous and next entries in the cache, it checks whether the start address of the entry to be removed is on the same page as the start address of the next entry in the cache. This is not correct, as an entry could cov

Re: [PATCH] vhost: fix madvise IOTLB entries pages overlap check

2023-03-15 Thread Maxime Coquelin
On 3/15/23 12:31, Maxime Coquelin wrote: At removal time, when testing whether the IOTLB entry has shared pages with the previous and next entries in the cache, it checks whether the start address of the entry to be removed is on the same page as the start address of the next entry in the cach

[PATCH v2] vhost: fix madvise IOTLB entries pages overlap check

2023-03-15 Thread Maxime Coquelin
At removal time, when testing whether the IOTLB entry has shared pages with the previous and next entries in the cache, it checks whether the start address of the entry to be removed is on the same page as the start address of the next entry in the cache. This is not correct, as an entry could cov

Re: [PATCH] net/af_xdp: make compatible with libbpf v0.8.0

2023-03-15 Thread Kevin Traynor
On 21/12/2022 09:28, Kevin Traynor wrote: On 21/12/2022 06:09, Andrew Rybchenko wrote: Hi Kevin, On 12/20/22 17:05, Kevin Traynor wrote: On 24/06/2022 11:23, Ciara Loftus wrote: libbpf v0.8.0 deprecates the bpf_get_link_xdp_id and bpf_set_link_xdp_fd functions. Use meson to detect if libbpf >

RE: [PATCH v8] app/procinfo: display eventdev xstats

2023-03-15 Thread Pattan, Reshma
> -Original Message- > app/proc-info/main.c | 210 - > + {"edev-reset-xstats", 0, NULL, 0}, > + {"show-edev-device-xstats", 0, NULL, 0}, We should support the eventdev id as argument to this command and display stats f

Re: [PATCH v3 0/2] enhance bonding PMD to support the LACP negotiation

2023-03-15 Thread Niklas Söderlund
Hi all, A gentle ping on this series. On 2023-03-01 10:48:24 +0800, Chaoyong He wrote: > App may not support the LACP negotiation in some cases. > This patch series solves this problem and add logics to > testpmd app to support the forward of bonding port in > mode 4 with the disabled dedicated q

RE: [PATCH] net/mlx5: fix build with GCC 12 and ASan

2023-03-15 Thread Slava Ovsiienko
Hi, I would prefer to fix both. With best regards, Slava > -Original Message- > From: David Marchand > Sent: среда, 15 марта 2023 г. 12:05 > To: Slava Ovsiienko > Cc: dev@dpdk.org; sta...@dpdk.org; Matan Azrad > Subject: Re: [PATCH] net/mlx5: fix build with GCC 12 and ASan > > On Tu

RE: [PATCH] net/iavf: fix VLAN Tx in AVX512

2023-03-15 Thread Zhang, Qi Z
> -Original Message- > From: Xu, Ke1 > Sent: Wednesday, March 15, 2023 5:13 PM > To: Zeng, ZhichaoX ; dev@dpdk.org > Cc: Zhang, Qi Z ; Zhou, YidingX > ; Huang, ZhiminX ; > Richardson, Bruce ; Konstantin Ananyev > ; Wu, Jingjing ; > Xing, Beilei > Subject: RE: [PATCH] net/iavf: fix VLAN

RE: [PATCH v3] net/ice: fix ice dcf control thread crash

2023-03-15 Thread Zhang, Qi Z
> -Original Message- > From: Ye, MingjinX > Sent: Wednesday, March 15, 2023 4:20 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; sta...@dpdk.org; Zhou, YidingX > ; Ye, MingjinX ; Zhang, > Ke1X ; Zhang, Qi Z > Subject: [PATCH v3] net/ice: fix ice dcf control thread crash > > The control thr

RE: [PATCH v2 1/1] mldev: split bfloat16 routines to separate files

2023-03-15 Thread Srikanth Yalavarthi
> -Original Message- > From: Srikanth Yalavarthi > Sent: 15 March 2023 16:12 > To: Ruifeng Wang > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; david.march...@redhat.com; nd > ; Srikanth Yalavarthi ; Srikanth > Yalavarthi > Subject: RE: [PATCH v2 1/1] mldev: split bfloat16 rou

RE: [PATCH v2] net/iavf: fix iavf query stats in intr thread

2023-03-15 Thread Zhang, Qi Z
> -Original Message- > From: Deng, KaiwenX > Sent: Tuesday, March 7, 2023 10:56 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Yang, Qiming ; Zhou, YidingX > ; Deng, KaiwenX ; Wu, > Jingjing ; Xing, Beilei ; Zhang, > Qi Z > Subject: [PATCH v2] net/iavf: fix iavf query stats in intr threa

Re: [PATCH 1/5] ethdev: support setting and querying rss algorithm

2023-03-15 Thread Thomas Monjalon
15/03/2023 12:00, Dongdong Liu: > From: Jie Hai > --- a/doc/guides/rel_notes/release_23_03.rst > +++ b/doc/guides/rel_notes/release_23_03.rst > -* No ABI change that would break compatibility with 22.11. > - > +* ethdev: Added "func" field to ``rte_eth_rss_conf`` structure for RSS hash > + algori

Re: [dpdk-web] [RFC PATCH] process: new library approval in principle

2023-03-15 Thread Jerin Jacob
On Fri, Mar 3, 2023 at 11:55 PM Thomas Monjalon wrote: > > Thanks for formalizing our process. Thanks for the review. > > 13/02/2023 10:26, jer...@marvell.com: > > --- /dev/null > > +++ b/content/process/_index.md > > First question: is the website the best place for this process? > > Inside the

[PATCH 1/1] ml/cnxk: fix multiple coverity issues

2023-03-15 Thread Srikanth Yalavarthi
Added checks for null pointers. Removed logically dead code. Fix division or modulo by zero. Fix evaludation order violation issues. Coverity issue: 383658 383659, 383664, 383665 Fixes: 817e3e55bb18 ("ml/cnxk: support simulator environment") Fixes: da3325131d71 ("ml/cnxk: find OCM mask and page sl

Re: PIE static library builds

2023-03-15 Thread Bruce Richardson
On Tue, Mar 14, 2023 at 06:31:41PM +, Bruce Richardson wrote: > On Tue, Mar 14, 2023 at 07:04:19PM +0100, Mattias Rönnblom wrote: > > On 2023-03-14 17:29, Bruce Richardson wrote: > > > On Tue, Mar 14, 2023 at 05:22:02PM +0100, Mattias Rönnblom wrote: > > > > Hi. > > > > > > > > Is the "b_stati

RE: [PATCH v8] app/procinfo: display eventdev xstats

2023-03-15 Thread Pattan, Reshma
> -Original Message- > From: Sevincer, Abdullah > +static void > +get_eventdev_xstats(uint8_t dev_id, You can separate this function (basically the code inside this function) into 3 functions, one for reset and one for display stats values. And move the common code(stats storage ca

RE: [PATCH v2] reorder: fix registration of dynamic field in mbuf

2023-03-15 Thread Volodymyr Fialko
Hi, A gentle reminder, please review and ack/comment. Can we have this merged before RC3? > -Original Message- > From: Volodymyr Fialko > Sent: Monday, March 13, 2023 2:04 PM > To: dev@dpdk.org; Reshma Pattan ; David Marchand > ; Andrew Rybchenko > Cc: Jerin Jacob Kollanukkaran ; Anoob

Re: [PATCH v2] reorder: fix registration of dynamic field in mbuf

2023-03-15 Thread David Marchand
On Wed, Mar 15, 2023 at 4:29 PM Volodymyr Fialko wrote: > > Hi, > > A gentle reminder, please review and ack/comment. > Can we have this merged before RC3? I did not go into depth this time, the fix seems ok. Reshma, please review. -- David Marchand

Re: PIE static library builds

2023-03-15 Thread Mattias Rönnblom
On 2023-03-15 15:18, Bruce Richardson wrote: On Tue, Mar 14, 2023 at 06:31:41PM +, Bruce Richardson wrote: On Tue, Mar 14, 2023 at 07:04:19PM +0100, Mattias Rönnblom wrote: On 2023-03-14 17:29, Bruce Richardson wrote: On Tue, Mar 14, 2023 at 05:22:02PM +0100, Mattias Rönnblom wrote: Hi.

RE: [PATCH v2] reorder: fix registration of dynamic field in mbuf

2023-03-15 Thread Pattan, Reshma
> -Original Message- > From: David Marchand > > A gentle reminder, please review and ack/comment. > > Can we have this merged before RC3? > > I did not go into depth this time, the fix seems ok. > Reshma, please review. > > Hi David, Unfortunately do not have a bandwidth to review th

Re: PIE static library builds

2023-03-15 Thread Bruce Richardson
On Wed, Mar 15, 2023 at 04:45:26PM +0100, Mattias Rönnblom wrote: > On 2023-03-15 15:18, Bruce Richardson wrote: > > On Tue, Mar 14, 2023 at 06:31:41PM +, Bruce Richardson wrote: > > > On Tue, Mar 14, 2023 at 07:04:19PM +0100, Mattias Rönnblom wrote: > > > > On 2023-03-14 17:29, Bruce Richardso

Re: [PATCH] app: fix mbuf_autotest in case of defined RTE_LIBRTE_MBUF_DEBUG

2023-03-15 Thread Olivier Matz
Hello, On Wed, Mar 15, 2023 at 11:29:50AM +0100, David Marchand wrote: > Hello, > > On Mon, Mar 13, 2023 at 5:57 PM Pavel Ivashchenko > wrote: > > app: fix mbuf_autotest in case of defined RTE_LIBRTE_MBUF_DEBUG I suggest this title instead: test/mbuf: fix mbuf autotest when mbuf debug is enabl

Re: [PATCH v3 2/3] testpmd: use sig_atomic_t for flag

2023-03-15 Thread Stephen Hemminger
On Tue, 14 Mar 2023 10:36:47 -0700 Stephen Hemminger wrote: > Standard conforming signal handling in applications should use sig_atomic_t > for flags set by signal handler. > https://www.gnu.org/software/libc/manual/html_node/Atomic-Data-Access.html > > This is really just a fancy way of saying

[RFC v2 0/2] Add high-performance timer facility

2023-03-15 Thread Mattias Rönnblom
This patchset is an attempt to introduce a high-performance, highly scalable timer facility into DPDK. More specifically, the goals for the htimer library are: * Efficient handling of a handful up to hundreds of thousands of concurrent timers. * Make adding and canceling timers low-overhead, co

[RFC v2 1/2] eal: add bitset type

2023-03-15 Thread Mattias Rönnblom
Introduce a set of functions and macros that operate on sets of bits, kept in arrays of 64-bit elements. RTE bitset is designed for bitsets which are larger than what fits in a single machine word (i.e., 64 bits). For very large bitsets, the API may be a more appropriate choice. RFC v2: * Repla

[RFC v2 2/2] eal: add high-performance timer facility

2023-03-15 Thread Mattias Rönnblom
The htimer library attempts at providing a timer facility with roughly the same functionality, but less overhead and better scalability than DPDK timer library. The htimer library employs per-lcore hierarchical timer wheels and a message-based synchronization/MT-safety scheme. RFC v2: * Fix spel

[PATCH v4 0/2] Fix testpmd interrupt regression

2023-03-15 Thread Stephen Hemminger
Resolve issues from using control-C in testpmd. Fixes regression from recent change to use cmdline_poll(). v4 - drop sig_atomic_t. Not required requires changes on some platforms. Stephen Hemminger (2): testpmd: go back to using cmdline_interact testpmd: enable interrupt in interactive m

[PATCH v4 2/2] testpmd: enable interrupt in interactive mode

2023-03-15 Thread Stephen Hemminger
The setting in terminal handling for both Unix style and Windows was not ensuring that Ctrl-C character would cause interrupt. This is a first release bug. Testpmd interactive mode has always disabled control-c handling on Linux. Fixes: af75078fece3 ("first public release") Signed-off-by: Stephen

[PATCH v4 1/2] testpmd: go back to using cmdline_interact

2023-03-15 Thread Stephen Hemminger
The cmdline library poll function is broken on Windows and was never tested, don't use it. Instead, use sigaction() to cancel read character on Unix OS's and a new helper to cancel I/O on Windows. Fixes: 0fd1386c30c3 ("app/testpmd: cleanup cleanly from signal") Bugzilla ID: 1180 Signed-off-by: St

[Bug 1185] enic: no longer accepting 2048 descriptor size in 20.11.6

2023-03-15 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1185 Bug ID: 1185 Summary: enic: no longer accepting 2048 descriptor size in 20.11.6 Product: DPDK Version: 20.11 Hardware: All OS: All Status: UNCONFIRMED

Fwd: [Bug 1185] enic: no longer accepting 2048 descriptor size in 20.11.6

2023-03-15 Thread Kevin Traynor
Hi John/Hyong Youb, Not sure if you are monitoring dpdk bugzilla, but wanted to draw your attention to https://bugs.dpdk.org/show_bug.cgi?id=1185 Maybe you have some clues about it and if we need to backport the mentioned commit? thanks, Kevin. Forwarded Message Subject:

Re: [Bug 1185] enic: no longer accepting 2048 descriptor size in 20.11.6

2023-03-15 Thread John Daley (johndale)
Thank you, I will take a look and get back to you. -john From: Kevin Traynor Date: Wednesday, March 15, 2023 at 10:47 AM To: John Daley (johndale) , Hyong Youb Kim (hyonkim) Cc: Luca Boccassi , David Marchand , dev@dpdk.org Subject: Fwd: [Bug 1185] enic: no longer accepting 2048 descriptor si

Re: [RFC v2 1/2] eal: add bitset type

2023-03-15 Thread Mattias Rönnblom
On 2023-03-15 18:20, Stephen Hemminger wrote: > On Wed, 15 Mar 2023 18:03:41 +0100 > Mattias Rönnblom wrote: > >> Introduce a set of functions and macros that operate on sets of bits, >> kept in arrays of 64-bit elements. >> >> RTE bitset is designed for bitsets which are larger than what fits in

RE: [PATCH v8] app/procinfo: display eventdev xstats

2023-03-15 Thread Sevincer, Abdullah
From: Pattan, Reshma Sent: Wednesday, March 15, 2023 4:57 AM To: Sevincer, Abdullah ; dev@dpdk.org Cc: jer...@marvell.com Subject: RE: [PATCH v8] app/procinfo: display eventdev xstats ->Why do we need to restrict to only eventdev 0? .I guess you should support displaying stats for any even

[PATCH v2 01/16] app/test: use previous value atomic fetch operations

2023-03-15 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch adding the necessary code to allow consumption of the resulting value. Signed-off-by: Tyler Retzlaff --- app/test/test_ring_perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/t

[PATCH v2 02/16] common/cnxk: use previous value atomic fetch operations

2023-03-15 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch adding the necessary code to allow consumption of the resulting value. Signed-off-by: Tyler Retzlaff --- drivers/common/cnxk/roc_ae.c| 2 +- drivers/common/cnxk/roc_ae_fpm_tables.c | 2 +- drivers/

[PATCH v2 04/16] drivers/event: use previous value atomic fetch operations

2023-03-15 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch adding the necessary code to allow consumption of the resulting value. Signed-off-by: Tyler Retzlaff Acked-by: Pavan Nikhilesh --- drivers/event/cnxk/cnxk_tim_worker.h | 2 +- drivers/event/dsw/dsw_event.c

[PATCH v2 00/16] replace __atomic operations returning new value

2023-03-15 Thread Tyler Retzlaff
This series replaces uses of __atomic_{add,and,or,sub,xor}_fetch with __atomic_fetch_{add,and,or,sub,xor} intrinsics where the new value is used. This series is being separated from the other similar series in an effort to reduce the chance of mistakes being spotted in review since the usages in t

[PATCH v2 03/16] common/mlx5: use previous value atomic fetch operations

2023-03-15 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch adding the necessary code to allow consumption of the resulting value. Signed-off-by: Tyler Retzlaff --- drivers/common/mlx5/linux/mlx5_nl.c | 2 +- drivers/common/mlx5/mlx5_common_mr.c| 8 dr

[PATCH v2 05/16] net/af_xdp: use previous value atomic fetch operations

2023-03-15 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch adding the necessary code to allow consumption of the resulting value. Signed-off-by: Tyler Retzlaff --- drivers/net/af_xdp/rte_eth_af_xdp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --gi

[PATCH v2 06/16] net/cnxk: use previous value atomic fetch operations

2023-03-15 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch adding the necessary code to allow consumption of the resulting value. Signed-off-by: Tyler Retzlaff Acked-by: Nithin Dabilpuram --- drivers/net/cnxk/cn10k_tx.h | 4 ++-- 1 file changed, 2 insertions(+), 2 d

[PATCH v2 07/16] net/cxgbe: use previous value atomic fetch operations

2023-03-15 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch adding the necessary code to allow consumption of the resulting value. Signed-off-by: Tyler Retzlaff --- drivers/net/cxgbe/clip_tbl.c | 2 +- drivers/net/cxgbe/mps_tcam.c | 2 +- 2 files changed, 2 insertions(

[PATCH v2 11/16] raw/ifpga: use previous value atomic fetch operations

2023-03-15 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch adding the necessary code to allow consumption of the resulting value. Signed-off-by: Tyler Retzlaff --- drivers/raw/ifpga/ifpga_rawdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

[PATCH v2 08/16] net/iavf: use previous value atomic fetch operations

2023-03-15 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch adding the necessary code to allow consumption of the resulting value. Signed-off-by: Tyler Retzlaff --- drivers/net/iavf/iavf_vchnl.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v2 09/16] net/mlx5: use previous value atomic fetch operations

2023-03-15 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch adding the necessary code to allow consumption of the resulting value. Signed-off-by: Tyler Retzlaff --- drivers/net/mlx5/linux/mlx5_verbs.c | 2 +- drivers/net/mlx5/mlx5.c | 4 ++-- drivers/net/

[PATCH v2 14/16] ipsec: use previous value atomic fetch operations

2023-03-15 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch adding the necessary code to allow consumption of the resulting value. Signed-off-by: Tyler Retzlaff --- lib/ipsec/ipsec_sqn.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ipsec/ipse

[PATCH v2 12/16] bbdev: use previous value atomic fetch operations

2023-03-15 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch adding the necessary code to allow consumption of the resulting value. Signed-off-by: Tyler Retzlaff --- lib/bbdev/rte_bbdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/bbdev/

[PATCH v2 10/16] net/octeontx: use previous value atomic fetch operations

2023-03-15 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch adding the necessary code to allow consumption of the resulting value. Signed-off-by: Tyler Retzlaff --- drivers/net/octeontx/octeontx_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 13/16] eal: use previous value atomic fetch operations

2023-03-15 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch adding the necessary code to allow consumption of the resulting value. Signed-off-by: Tyler Retzlaff --- lib/eal/include/generic/rte_rwlock.h | 8 lib/eal/ppc/include/rte_atomic.h | 16 --

[PATCH v2 15/16] mbuf: use previous value atomic fetch operations

2023-03-15 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch adding the necessary code to allow consumption of the resulting value. Signed-off-by: Tyler Retzlaff --- lib/mbuf/rte_mbuf.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib

[PATCH v2 16/16] rcu: use previous value atomic fetch operations

2023-03-15 Thread Tyler Retzlaff
Use __atomic_fetch_{add,and,or,sub,xor} instead of __atomic_{add,and,or,sub,xor}_fetch adding the necessary code to allow consumption of the resulting value. Signed-off-by: Tyler Retzlaff --- lib/rcu/rte_rcu_qsbr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rcu/rte_r

[PATCH v4 1/2] eal: make cpusetp to rte thread set affinity const

2023-03-15 Thread Tyler Retzlaff
const qualify rte_cpuset_t *cpusetp parameter in the rte_thread_set_affinity API. Signed-off-by: Tyler Retzlaff --- lib/eal/common/eal_common_thread.c | 6 +++--- lib/eal/include/rte_thread.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/eal/common/eal_common_t

[PATCH v4 0/2] fix race in rte_thread_create failure path

2023-03-15 Thread Tyler Retzlaff
v4: * refactor patch to use pthread_cond_t to wait for thread start wrapper to complete work. * rename some variables to group those that are part of the wrapper synchronization. * use stack instead of heap allocation for thread start context. v3: * don't free wrapper context from

[PATCH v4 2/2] eal: fix failure path race setting new thread affinity

2023-03-15 Thread Tyler Retzlaff
In rte_thread_create setting affinity after pthread_create may fail. Such a failure should result in the entire rte_thread_create failing but doesn't. Additionally if there is a failure to set affinity a race exists where the creating thread will free ctx and depending on scheduling of the new thr

[PATCH v5 0/2] fix race in rte_thread_create failure path

2023-03-15 Thread Tyler Retzlaff
v5: * refactor patch to use pthread_cond_t to wait for thread start wrapper to complete work. * rename some variables to group those that are part of the wrapper synchronization. * use stack instead of heap allocation for thread start context. v4: * style fixes reported by CI v3:

[PATCH v5 1/2] eal: make cpusetp to rte thread set affinity const

2023-03-15 Thread Tyler Retzlaff
const qualify rte_cpuset_t *cpusetp parameter in the rte_thread_set_affinity API. Signed-off-by: Tyler Retzlaff --- lib/eal/common/eal_common_thread.c | 6 +++--- lib/eal/include/rte_thread.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/eal/common/eal_common_t

[PATCH v5 2/2] eal: fix failure path race setting new thread affinity

2023-03-15 Thread Tyler Retzlaff
In rte_thread_create setting affinity after pthread_create may fail. Such a failure should result in the entire rte_thread_create failing but doesn't. Additionally if there is a failure to set affinity a race exists where the creating thread will free ctx and depending on scheduling of the new thr

Re: [PATCH v5] lib/bpf: Rename bpf function names to avoid potential conflict with libpcap

2023-03-15 Thread Konstantin Ananyev
14/03/2023 14:20, J.J. Martzki пишет: The library libpcap has their function 'bpf_validate' either so there would be a multiple definition issue when linking with librte_bpf.a and libpcap.a statically (Same as http://dpdk.org/patch/52631). So just rename the function names to avoid such issue. S

Re: [PATCH] app/testpmd: dump private info in 'show port info'

2023-03-15 Thread fengchengwen
On 2023/3/15 18:12, Ferruh Yigit wrote: > On 3/15/2023 2:33 AM, Chengwen Feng wrote: >> This patch adds dump private info in 'show port info [port_id]' cmd. >> >> Signed-off-by: Chengwen Feng >> --- >> app/test-pmd/config.c | 5 + >> 1 file changed, 5 insertions(+) >> >> diff --git a/app/test

Reminder - DPDK CI Community Testing Meeting - Tomorrow, Mar. 16, 2023 - 6am PDT/9am EDT/1300h UTC

2023-03-15 Thread Nathan Southern
Good evening, DPDK will hold its next CI Community Testing Meeting tomorrow, March 16, 2023, at 6am PDT/9am EDT/1300h UTC. Zoom information to follow. We look forward to seeing you there. Thanks, Nathan Join Zoom Meeting *https://zoom.us/j/95952696590?pwd=b0JjVnJaWDZ3TW1XYjZKQkxmZUZuQT09*

RE: [PATCH v2] vhost: fix madvise IOTLB entries pages overlap check

2023-03-15 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, March 15, 2023 7:40 PM > To: dev@dpdk.org; m...@redhat.com; Xia, Chenbo ; > david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v2] vhost: fix madvise IOTLB entries pages overlap check > > At removal time, when

RE: [PATCH v2] net/i40e: fix MAC loopback on X722

2023-03-15 Thread Yuan, DukaiX
> -Original Message- > From: Qiao, Wenjing > Sent: 2023年3月14日 11:16 > To: Zhang, Yuying ; Xing, Beilei > > Cc: Yuan, DukaiX ; dev@dpdk.org; Qiao, Wenjing > > Subject: [PATCH v2] net/i40e: fix MAC loopback on X722 > > If enabling MAC loopback mode on X722 NIC, transmitted packets are not

RE: [PATCH v2] net/i40e: fix MAC loopback on X722

2023-03-15 Thread Zhang, Qi Z
> -Original Message- > From: Yuan, DukaiX > Sent: Thursday, March 16, 2023 10:05 AM > To: Qiao, Wenjing ; Zhang, Yuying > ; Xing, Beilei > Cc: dev@dpdk.org > Subject: RE: [PATCH v2] net/i40e: fix MAC loopback on X722 > > > -Original Message- > > From: Qiao, Wenjing > > Sent:

RE: [PATCH v2 1/1] mldev: split bfloat16 routines to separate files

2023-03-15 Thread Ruifeng Wang
> -Original Message- > From: Srikanth Yalavarthi > Sent: Wednesday, March 15, 2023 9:39 PM > To: Ruifeng Wang > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; > david.march...@redhat.com; nd ; Srikanth Yalavarthi > > Subject: RE: [PATCH v2 1/1] mldev: split bfloat16 routines

[PATCH 1/2] lib/cryptodev/: Add SM3_HMAC/SM4_CFB/SM4_OFB support in DPDK

2023-03-15 Thread Sunyang Wu
Add SM3_HMAC/SM4_CFB/SM4_OFB support in DPDK. Signed-off-by: Sunyang Wu --- lib/cryptodev/rte_crypto_sym.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/cryptodev/rte_crypto_sym.h b/lib/cryptodev/rte_crypto_sym.h index 2cfe66530c..c4572106dc 100644 --- a/lib/cryp

[PATCH 2/2] test/crypto: Add SM3/SM4 test vectors for verification in test app

2023-03-15 Thread Sunyang Wu
Add SM3/SM4 test vectors for verification in test app. Signed-off-by: Sunyang Wu --- The test results of using openssl are as follows: + SM4 Chain : 24/24 passed, 0/24 skipped, 0/24 failed, 0/24 unsupported + SM4 Cipher Only : 10/10 passed, 0/10 skipped, 0/10 failed, 0/10 unsupported + Auth O

Re: [RFC v2 2/2] eal: add high-performance timer facility

2023-03-15 Thread Tyler Retzlaff
On Wed, Mar 15, 2023 at 06:03:42PM +0100, Mattias Rönnblom wrote: > The htimer library attempts at providing a timer facility with roughly > the same functionality, but less overhead and better scalability than > DPDK timer library. > > The htimer library employs per-lcore hierarchical timer wheel