Re: [PATCH v2 2/2] test/mempool: add zero-copy API's

21/02/2023 21:18, Kamalakshitha Aligeri: > Hi Thomas, > > Do you want me to squash the unit tests in the mempool lib patch or do I have > to wait for the reviews from mempool maintainers Yes I think you can do the squash if Morten agrees. > From: Thomas Monjalon > > 10/02/2023 08:33, Morten B

[PATCH] net/iavf: fix avx512 Tx path

This patch fixes the tunneling parameters on avx512 Tx path and adjusts the path selection to fix perf drop. Fixes: 4f8259df563a ("net/iavf: enable Tx outer checksum offload on AVX512") Signed-off-by: Zhichao Zeng --- drivers/net/iavf/iavf_rxtx.c| 7 +-- drivers/net/iavf/iavf_rxtx.

RE: [PATCH v2 2/2] test/mempool: add zero-copy API's

> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, 22 February 2023 09.01 > > 21/02/2023 21:18, Kamalakshitha Aligeri: > > Hi Thomas, > > > > Do you want me to squash the unit tests in the mempool lib patch or do I > have to wait for the reviews from mempool maintainers > > Y

[PATCH v2 0/6] add flex item implementation

Implement the flex item matching and modify field in HWS. Rongwei Liu (6): net/mlx5: enable hws flex item create net/mlx5: add IPv6 protocol as flex item input net/mlx5/hws: add hws flex item matching support net/mlx5: add flex item modify field implementation net/mlx5: return error for

[PATCH v2 1/6] net/mlx5: enable hws flex item create

Enable flex item create and destroy with dv_flow_en=2 Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/linux/mlx5_os.c | 27 +++ drivers/net/mlx5/mlx5_flow_hw.c | 2 ++ 2 files changed, 17 insertions(+), 12 deletions(-) diff --git a/drive

[PATCH v2 2/6] net/mlx5: add IPv6 protocol as flex item input

Support IPv6 protocol as new flex item input link. Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_flex.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow_flex.c b/drivers/net/mlx5/mlx5_flow_flex.c inde

[PATCH v2 3/6] net/mlx5/hws: add hws flex item matching support

Support flex item matching in hws and syntax follows sws exactly. Flex item should be created in advance and follow current json mapping logic. Signed-off-by: Rongwei Liu Reviewed-by: Alex Vesker Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/hws/mlx5dr_definer.c | 83 ++

[PATCH v2 4/6] net/mlx5: add flex item modify field implementation

Add flex item modify field HWS implementation. The minimum modify boundary is one byte. Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_prm.h | 1 + drivers/net/mlx5/mlx5_flow.h| 3 + drivers/net/mlx5/mlx5_flow_dv.c | 165 +

[PATCH v2 5/6] net/mlx5: return error for sws modify field

Return unsupported error message when application tries to modify flex item field. Validation of packet modifications actions for SW Steering checked if either source or destination field of MODIFY_FIELD action was a flex item. When DEC_TTL action is used, DEC_TTL action does not have any action c

[PATCH v2 6/6] doc/mlx5: update mlx5 doc

Add flex item matching and modify field feature into mlx5 documents. Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- doc/guides/nics/mlx5.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index f182baa37e

RE: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

> -Original Message- > From: fengchengwen > Sent: Wednesday, February 22, 2023 9:07 AM > To: Stephen Hemminger ; Ruifeng Wang > > Cc: Ashok Kaladi ; jer...@marvell.com; > tho...@monjalon.net; > Honnappa Nagarahalli ; dev@dpdk.org; > s.v.naga.haris...@intel.com; erik.g.carri...@intel.com

Re: [PATCH] examples/l3fwd-power: support CPPC cpufreq

On 22/02/2023 02:13, Jie Hai wrote: Hi, David Hunt, Kindly ping. Could you please take a look at this patch? Thanks, Jie Hai On 2023/1/31 10:58, Jie Hai wrote: Currently the l3fwd-power only supports ACPI cpufreq and Pstate cpufreq, This patch adds CPPC cpufreq. Signed-off-by: Jie Hai

RE: [EXT] Re: [PATCH v2] examples/ipsec-secgw: set AES-CTR IV length to 16

Hi Tejasree, I think it will make more sense but I will let Akhil decide. -Original Message- From: Tejasree Kondoj Sent: Tuesday, February 21, 2023 4:38 PM To: Nicolau, Radu ; Akhil Goyal Cc: Anoob Joseph ; dev@dpdk.org Subject: RE: [EXT] Re: [PATCH v2] examples/ipsec-secgw: set AES-CTR

RE: [PATCH] config: added support for NVIDIA ARM implementer ID

> -Original Message- > From: cburd...@nvidia.com > Sent: Wednesday, February 22, 2023 1:34 AM > To: Ruifeng Wang > Cc: dev@dpdk.org; Cliff Burdick > Subject: [PATCH] config: added support for NVIDIA ARM implementer ID > > From: Cliff Burdick > > NVIDIA's Jetson Xavier is an ARM chip w

RE: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

> -Original Message- > From: fengchengwen > Sent: Wednesday, February 22, 2023 1:07 AM > To: Stephen Hemminger ; Ruifeng Wang > > Cc: Ashok Kaladi ; jer...@marvell.com; > tho...@monjalon.net; Honnappa Nagarahalli > ; dev@dpdk.org; s.v.naga.haris...@intel.com; > erik.g.carri...@intel.

Re: [PATCH v2 08/16] test/bbdev: add support for BLER for 4G

On 2/15/23 18:09, Hernan Vargas wrote: New feature to add BLER support for 4G in test-bbdev. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 183 ++- 1 file changed, 182 insertions(+), 1 deletion(-) diff --git a/app/test-bbdev/test_bbdev_pe

Re: [PATCH v2 09/16] test/bbdev: extend support for large TB

On 2/15/23 18:09, Hernan Vargas wrote: Add support for large TB when it cannot fit into a true mbuf. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.

Re: [PATCH v2 10/16] test/bbdev: adjustment for soft output

On 2/15/23 18:09, Hernan Vargas wrote: Extend test-bbdev for soft output check, notably due to the logic in test-bbdev to enable termination changing. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 26 +- 1 file changed, 13 insertions(+), 13 de

Re: [PATCH v2 11/16] test/bbdev: expose warning counters

On 2/15/23 18:09, Hernan Vargas wrote: Print warnings reported on queues for offload test. No functional impact. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_

Re: [PATCH v2 12/16] test/bbdev: remove check for invalid opaque data

On 2/15/23 18:09, Hernan Vargas wrote: Assert also if the opaque data is invalid. New line needed before Fixes tag. Fixes: 335c11fd276 ("app/bbdev: support HARQ validation") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 8 +++- 1 file chan

Re: [PATCH v2 13/16] test/bbdev: remove iteration count check

On 2/15/23 18:09, Hernan Vargas wrote: To make the test compatible with devices that do not support early termination, the iteration count assert can be removed. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 24 1 file changed, 8 insertions(+

Re: [PATCH v2 14/16] test/bbdev: use mbuf reset function

On 2/15/23 18:09, Hernan Vargas wrote: Use mbuf_reset function for code consistency. No functional impact. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c

Re: [PATCH v2 15/16] test/bbdev: remove max iteration from vectors

On 2/15/23 18:09, Hernan Vargas wrote: Remove iter_max from test vectors as this value is passed as an argument to the test. No functional impact. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 4 app/test-bbdev/test_bbdev_vector.c

Re: [PATCH v2 16/16] test/bbdev: remove iter count from bler test

On 2/15/23 18:09, Hernan Vargas wrote: iter_count doesn't need to be set equal to iter_max for bler tests. This is only needed in throughput and latency tests because early termination is disabled for those tests. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 16 +

Re: [PATCH v2 3/9] baseband/acc: add explicit mbuf append for soft output

On 2/10/23 18:58, Nicolas Chautru wrote: Adding an explicit mbuf append in the case of soft output mbuf being provided. Fixes: e640f6cdfa84 ("baseband/acc200: add LDPC processing") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru Reviewed-by: Maxime Coquelin I don't remember having put

[PATCH v2 0/3] Add Tx queue mapping of aggregated ports in MLX5 PMD

This patch implements RTE_FLOW_ITEM_TYPE_AGGR_AFFINITY support in MLX5 PMD. This patch adds the MLX5 PMD support for two device ops: - map_aggr_tx_affinity - count_aggr_ports This patch series relies on the preceding RTE API: http://patches.dpdk.org/project/dpdk/list/?series=27064 v2: * updat

[PATCH v2 1/3] net/mlx5: add lag Rx port affinity in PRM

This patch adds function to query hca capability via Devx for lag_rx_port_affinity. Signed-off-by: Jiawei Wang Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c | 3 +++ drivers/common/mlx5/mlx5_devx_cmds.h | 1 + drivers/common/mlx5/mlx5_prm.h | 7 +-- drivers/n

[PATCH v2 2/3] net/mlx5: add aggregated affinity item support

This patch adds the new aggregated affinity item support in PMD: RTE_FLOW_ITEM_TYPE_AGGR_AFFINITY. This patch adds the validation function for the new item, it works for NIC-RX and FDB rule on ROOT-table only. Signed-off-by: Jiawei Wang Acked-by: Viacheslav Ovsiienko --- doc/guides/nics/featur

[PATCH v2 3/3] net/mlx5: enhance the Tx queue affinity

The rte_eth_dev_map_aggr_tx_affinity() was introduced in ethdev lib, it was used to set the affinity value per Tx queue. This patch adds the MLX5 PMD support for two device ops: - map_aggr_tx_affinity - count_aggr_ports After maps a Tx queue with an aggregated port by call map_aggr_tx_affinity(

Re: [PATCH v2 2/2] test/mempool: add zero-copy API's

22/02/2023 09:24, Morten Brørup: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Wednesday, 22 February 2023 09.01 > > > > 21/02/2023 21:18, Kamalakshitha Aligeri: > > > Hi Thomas, > > > > > > Do you want me to squash the unit tests in the mempool lib patch or do I > > have to wai

RE: [EXT] Re: [PATCH v3] bus: add platform bus

>-Original Message- >From: Thomas Monjalon >Sent: Monday, February 20, 2023 11:52 AM >To: Tomasz Duszynski >Cc: dev@dpdk.org; chenbo@intel.com; Jerin Jacob Kollanukkaran >; >step...@networkplumber.org; david.march...@redhat.com >Subject: [EXT] Re: [PATCH v3] bus: add platform bus

RE: [EXT] Re: [PATCH v2] examples/ipsec-secgw: set AES-CTR IV length to 16

> Hi Tejasree, I think it will make more sense but I will let Akhil decide. > > Hi Radu, > > Shall I change AES-128-CTR iv_len field in cipher_algos struct of sa.c from 8 > to > 16 and revert below change? > It is ok to do that, but make sure to add a comment that it includes 4B nonce and 4B

Re: [PATCH v3] vhost: exclude VM hugepages from coredumps

On Tue, Feb 21, 2023 at 11:26 AM Maxime Coquelin wrote: > > Hi Mike, > > On 2/10/23 22:12, Mike Pattrick wrote: > > On Fri, Feb 10, 2023 at 10:53 AM David Marchand > > wrote: > >> > >> Hello Mike, > >> > >> On Wed, Dec 7, 2022 at 5:54 PM Mike Pattrick wrote: > >>> > >>> Currently if an applicati

[PATCH 2/2] app/testpmd: user assigned flow ID to flows

Currently, testpmd assigns its own IDs, as indices, to created flows. Later, the flow index is used as the ID for flow operations (query, destroy, dump). Allow the user to assign a user-id, to be later used as an alternative to the flow index testpmd assigns. Example: testpmd> flow create 0 ingr

[PATCH 1/2] app/testpmd: change rule type

Change rule type to be uintptr_t (instead of currently uint32_t) to be able to accomodate larger IDs, as a pre-step towards allowing user-id to flows. Signed-off-by: Eli Britstein --- app/test-pmd/cmdline_flow.c | 12 ++-- app/test-pmd/config.c | 34 ++--

[PATCH v10 00/22] Convert static log type values in libraries

This patchset removes the main uses of static LOGTYPE's in DPDK libraries. It starts with the easy one and goes on to the more complex ones. There are several options on how to treat the old static types: leave them there, mark as deprecated, or remove them. This version removes them since there i

[PATCH v10 01/22] gso: don't log message on non TCP/UDP

If a large packet is passed into GSO routines of unknown protocol then library would log a message. Better to tell the application instead of logging. Fixes: 119583797b6a ("gso: support TCP/IPv4 GSO") Reviewed-by: Jiayu Hu Signed-off-by: Stephen Hemminger --- lib/gso/rte_gso.c | 5 ++--- lib/gs

[PATCH v10 02/22] eal: drop no longer used GSO logtype

The message that used this was replaced in previous patch. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common

[PATCH v10 03/22] log: drop unused RTE_LOGTYPE_TIMER

The timer code does not use rte_log. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common_log.c index 894701e8c

[PATCH v10 04/22] efd: replace RTE_LOGTYPE_EFD with dynamic type

Replace all uses of the global logtype with a dynamic log type. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/efd/rte_efd.c | 4 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/eal/com

[PATCH v10 05/22] mbuf: replace RTE_LOGTYPE_MBUF with dynamic type

Introduce a new dynamic logtype for mbuf related messages. Since this is used in multiple files put one macro in mbuf_log.h Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/mbuf/mbuf_log.h | 4 lib/mbuf/rte_m

[PATCH v10 06/22] acl: replace LOGTYPE_ACL with dynamic type

Get rid of RTE_LOGTYPE_ACL and RTE_LOGTYPE_MALLOC. For ACL library use a dynamic type. The one message using RTE_LOGTYPE_MALLOC should have been under the ACL logtype anyway. The test code should not have been using fixed log type so just change that to stderr. Signed-off-by: Stephen Hemminger -

[PATCH v10 07/22] examples/power: replace use of RTE_LOGTYPE_POWER

Don't use static logtype in sample application. Signed-off-by: Stephen Hemminger --- examples/distributor/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/distributor/main.c b/examples/distributor/main.c index 21304d661873..542f76cf9664 100644 --- a/examples/di

[PATCH v10 08/22] examples/l3fwd-power: replace use of RTE_LOGTYPE_POWER

Convert to using a dynamic logtype for the application. Signed-off-by: Stephen Hemminger --- examples/l3fwd-power/main.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index f57c54d2b57c..76b890b76c88

[PATCH v10 09/22] power: replace RTE_LOGTYPE_POWER with dynamic type

Use dynamic log type for power library. Also replace use of RTE_LOGTYPE_USER1 with lib.power.guest. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/power/guest_channel.c | 3 ++- lib/power/power_common.c| 2 ++

[PATCH v10 10/22] ring: replace RTE_LOGTYPE_RING with dynamic type

The logtype for ring only used in library. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/ring/rte_ring.c | 3 +++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_log.c b

[PATCH v10 11/22] mempool: replace RTE_LOGTYPE_MEMPOOL with dynamic type

Convert from RTE_LOGTYPE_MEMPOOL to logtype_mempool. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/mempool/rte_mempool.c | 2 ++ lib/mempool/rte_mempool.h | 8 lib/mempool/version.map | 3 +++

[PATCH v10 12/22] lpm: replace RTE_LOGTYPE_LPM with dynamic types

Split lpm and lpm6 into separate log types since they are in different files and user may want to change log levels for IPv4 vs IPv6. For rib and fib libraries give them own types as well. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h

[PATCH v10 13/22] kni: replace RTE_LOGTYPE_KNI with dynamic type

Even though KNI will eventually disappear, fix the logtype now. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/kni/rte_kni.c | 3 +++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/eal/comm

[PATCH v10 14/22] sched: replace RTE_LOGTYPE_SCHED with dynamic type

Also can remove unused RTE_LOGTYPE_METER Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 2 -- lib/eal/include/rte_log.h | 4 ++-- lib/sched/rte_pie.c | 1 + lib/sched/rte_sched.c | 5 + lib/sched/rte_sched_log.h | 4 5 files chan

[PATCH v10 15/22] examples/ipsecgw: replace RTE_LOGTYPE_PORT

Looks like some code got copy/paste in to the IPSEC gateway example from another place. Shouldn't be using RTE_LOGTYPE_PORT here. Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload") Cc: akhil.go...@nxp.com Signed-off-by: Stephen Hemminger --- examples/ipsec-secgw/sa.c | 6 +++-

[PATCH v10 16/22] port: replace RTE_LOGTYPE_PORT with dynamic type

Split up the single static RTE_LOGTYPE_PORT into separate sub types for each component: port.ethdev, port.evendev, ... Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/port/rte_port_ethdev.c | 3 +++ lib/port/rte_port_ev

[PATCH v10 17/22] table: convert RTE_LOGTYPE_TABLE to dynamic logtype

Use logtype suffixes for various components of this library. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/table/rte_table_acl.c | 3 +++ lib/table/rte_table_array.c | 3 +++ lib/table/rte_table_hash_cuck

[PATCH v10 18/22] app/test: remove use of RTE_LOGTYPE_PIPELINE

Instead of using static type PIPELINE for logging in test application use stderr instead. If not testing RTE_LOG() better to not use it since log also goes to syslog. Signed-off-by: Stephen Hemminger --- app/test/test_table_acl.c | 50 -- app/test/test_table

[PATCH v10 19/22] pipeline: replace RTE_LOGTYPE_PIPELINE with dynamic type

Use a dynamically allocated logtype. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/pipeline/rte_pipeline.c | 3 +++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_log.c b/lib/e

[PATCH v10 20/22] hash: move rte_thash_gfni stubs out of header file

Having stubs in header file makes it harder to update RTE_LOG(). Also modify to only print warning once. Signed-off-by: Stephen Hemminger --- lib/hash/meson.build | 8 ++- lib/hash/rte_thash_gfni.c | 47 +++ lib/hash/rte_thash_gfni.h | 29 +--

[PATCH v10 21/22] hash: move rte_hash_set_alg out header

The code for setting algorithm for hash is not at all perf sensitive, and doing it inline has a couple of problems. First, it means that if multiple files include the header, then the initialization gets done multiple times. But also, it makes it harder to fix usage of RTE_LOG(). Despite what the

[PATCH v10 22/22] hash: convert RTE_LOGTYPE_HASH to dynamic type

Use dynamic type for hash and add subtypes for crc and gfni. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/hash/rte_cuckoo_hash.c | 5 + lib/hash/rte_fbk_hash.c | 5 + lib/hash/rte_thash.c|

[PATCH v4 01/19] ethdev: reword dev_info_get description.

The original comment was redundant and had duplicate word 'of'. Signed-off-by: Stephen Hemminger --- lib/ethdev/rte_ethdev.h | 32 1 file changed, 4 insertions(+), 28 deletions(-) diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index 049641d57c66.

[PATCH v4 00/19] Remove repeated words in comments and messages

This is a cleanup of comments and messages. Done by an ugly pcregrep across sources and skipping lots of false positives The idea is based of what some maintainers have been doing in netdev. Series-acked-by: Bruce Richardson v4 - rebase and skip fixing common/sfc_efx/base Stephen Hemminger (1

[PATCH v4 02/19] remove repeated word 'to'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- app/test/test_resource.c | 2 +- lib/pipeline/rte_swx_ctl.c | 2 +- lib/power/guest_channel.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/test/test_resource.c b/app/test/test_resource.c ind

[PATCH v4 03/19] remove repeated word 'is'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- lib/net/rte_ether.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/net/rte_ether.h b/lib/net/rte_ether.h index bf8a55ba06ca..b35c72c7b0e0 100644 --- a/lib/net/rte_ether.h +++ b/lib/net/rte_ether.h @

[PATCH v4 04/19] remove repeated word 'same'

The word 'same' is duplicated in comment. Signed-off-by: Stephen Hemminger Acked-by: Liron Himi --- drivers/net/mvneta/mvneta_ethdev.c | 2 +- drivers/net/mvpp2/mrvl_ethdev.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mvneta/mvneta_ethdev.c b/drivers/

[PATCH v4 05/19] remove repeated word 'on'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- drivers/net/bonding/rte_eth_bond_8023ad.h | 2 +- examples/vm_power_manager/channel_monitor.h | 2 +- examples/vm_power_manager/oob_monitor.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/driv

[PATCH v4 06/19] remove repeated word 'in'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- drivers/event/sw/sw_evdev.c| 2 +- drivers/net/hns3/hns3_ethdev.c | 2 +- drivers/net/mlx5/mlx5_flow.c | 2 +- drivers/net/sfc/sfc_ef10_tx.c | 2 +- drivers/net/sfc/sfc_tso.c | 2 +- lib/mbuf/rte_mbuf_core.h

[PATCH v4 07/19] remove repeated word 'this'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- lib/ring/rte_ring.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/ring/rte_ring.c b/lib/ring/rte_ring.c index cddaf6b2876f..8ed455043dee 100644 --- a/lib/ring/rte_ring.c +++ b/lib/ring/rte_ring.c

[PATCH v4 08/19] remove repeated word 'only'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger Acked-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x.c | 2 +- drivers/net/pcap/pcap_ethdev.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index

[PATCH v4 09/19] remove repeated word 'worker'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- lib/distributor/rte_distributor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/distributor/rte_distributor.c b/lib/distributor/rte_distributor.c index 3969b2ea7e8a..c1a721dd821d 100644 --- a/lib/

[PATCH v4 10/19] remove repeated word 'or'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- drivers/net/cxgbe/sge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/cxgbe/sge.c b/drivers/net/cxgbe/sge.c index 5b13cb5c947e..e9d45f24c419 100644 --- a/drivers/net/cxgbe/sge.c +++ b/drive

[PATCH v4 11/19] remove repeated word 'table'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- drivers/net/ixgbe/ixgbe_ipsec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_ipsec.c b/drivers/net/ixgbe/ixgbe_ipsec.c index 0c75fd36da20..d3313085560d 100644 --- a/drivers/net

[PATCH v4 12/19] remove repeated word 'that'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_ctrl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_ctrl.h b/drivers/net/nfp/nfp_ctrl.h index 1069ff948555..2269925b74cf 100644 -

[PATCH v4 13/19] remove repeated word 'override'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal ctxt_type == DPAA2_SEC_PDCP && sess->pdcp.hfn_ovd) { uint32_t hfn_ovd = *(uint32_t *)((uint8_t *)op + sess->pdcp.hfn_ovd_offset); - /

[PATCH v4 14/19] remove repeated word 'groups'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- app/test/test_ipsec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_ipsec.c b/app/test/test_ipsec.c index cf71f99b964f..c2a52ec30527 100644 --- a/app/test/test_ipsec.c +++ b/app/test/test

[PATCH v4 15/19] remove repeated word 'page'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/ecore_fw_defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnx2x/ecore_fw_defs.h b/drivers/net/bnx2x/ecore_fw_defs.h index 6fc1fce7e29c..ab1abf6b34b3 100644 --- a/driv

[PATCH v4 16/19] remove repeated word 'individual'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- drivers/net/cxgbe/cxgbe_filter.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/cxgbe/cxgbe_filter.h b/drivers/net/cxgbe/cxgbe_filter.h index 46ebf833381e..6e099a5c1cfc 100644 --- a/drivers/

[PATCH v4 17/19] remove repeated word 'expected'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- lib/bpf/rte_bpf_ethdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/bpf/rte_bpf_ethdev.h b/lib/bpf/rte_bpf_ethdev.h index 135062c9e13c..1cca2e6c95a2 100644 --- a/lib/bpf/rte_bpf_ethdev.h +++ b/l

[PATCH v4 18/19] remove repeated word 'be'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger Acked-by: Devendra Singh Rawat Acked-by: Rasesh Mody --- drivers/net/qede/qede_filter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/qede/qede_filter.c b/drivers/net/qede/qede_filter.c i

[PATCH v4 19/19] remove repeated word 'all'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/ecore_sp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnx2x/ecore_sp.h b/drivers/net/bnx2x/ecore_sp.h index 1f4d5a3ebe29..c0b4d431c879 100644 --- a/drivers/net/bnx2x/ec

RE: [PATCH v4 02/19] remove repeated word 'to'

> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, February 22, 2023 4:25 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Dumitrescu, Cristian > ; Hunt, David > Subject: [PATCH v4 02/19] remove repeated word 'to' > > Found by doing duplicate word scan. > > Signed-off-b

Re: [PATCH v4 09/19] remove repeated word 'worker'

On 22/02/2023 16:25, Stephen Hemminger wrote: Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- lib/distributor/rte_distributor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/distributor/rte_distributor.c b/lib/distributor/rte_distributor.

Re: [PATCH v4 05/19] remove repeated word 'on'

On 22/02/2023 16:25, Stephen Hemminger wrote: Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- drivers/net/bonding/rte_eth_bond_8023ad.h | 2 +- examples/vm_power_manager/channel_monitor.h | 2 +- examples/vm_power_manager/oob_monitor.h | 2 +- 3 files chang

Re: [PATCH v4 02/19] remove repeated word 'to'

On 22/02/2023 16:25, Stephen Hemminger wrote: Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- app/test/test_resource.c | 2 +- lib/pipeline/rte_swx_ctl.c | 2 +- lib/power/guest_channel.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/a

RE: [PATCH v2 2/2] test/mempool: add zero-copy API's

> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, 22 February 2023 13.41 > > 22/02/2023 09:24, Morten Brørup: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > Sent: Wednesday, 22 February 2023 09.01 > > > > > > 21/02/2023 21:18, Kamalakshitha Aligeri: > > > > Hi

Re: [PATCH v9 09/22] power: replace RTE_LOGTYPE_POWER with dynamic type

On 21/02/2023 19:01, Stephen Hemminger wrote: Use dynamic log type for power library. Also replace use of RTE_LOGTYPE_USER1 with lib.power.guest. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/power/guest_channel.c

Re: [PATCH v9 08/22] examples/l3fwd-power: replace use of RTE_LOGTYPE_POWER

On 21/02/2023 19:01, Stephen Hemminger wrote: Convert to using a dynamic logtype for the application. Signed-off-by: Stephen Hemminger --- examples/l3fwd-power/main.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/

Re: [PATCH v9 07/22] examples/power: replace use of RTE_LOGTYPE_POWER

On 21/02/2023 19:01, Stephen Hemminger wrote: Don't use static logtype in sample application. Signed-off-by: Stephen Hemminger --- examples/distributor/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/distributor/main.c b/examples/distributor/main.c index

Re: [PATCH v7 09/22] power: replace RTE_LOGTYPE_POWER with dynamic type

On 15/02/2023 17:23, Stephen Hemminger wrote: Use dynamic log type for power library. Also replace use of RTE_LOGTYPE_USER1 with lib.power.guest. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h| 2 +- lib/power/guest_channel.c

Re: [PATCH v10 09/22] power: replace RTE_LOGTYPE_POWER with dynamic type

On 22/02/2023 16:07, Stephen Hemminger wrote: Use dynamic log type for power library. Also replace use of RTE_LOGTYPE_USER1 with lib.power.guest. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/power/guest_channel.c

Re: [PATCH v10 08/22] examples/l3fwd-power: replace use of RTE_LOGTYPE_POWER

On 22/02/2023 16:07, Stephen Hemminger wrote: Convert to using a dynamic logtype for the application. Signed-off-by: Stephen Hemminger --- examples/l3fwd-power/main.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/

Re: [PATCH v10 07/22] examples/power: replace use of RTE_LOGTYPE_POWER

On 22/02/2023 16:07, Stephen Hemminger wrote: Don't use static logtype in sample application. Signed-off-by: Stephen Hemminger --- examples/distributor/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/distributor/main.c b/examples/distributor/main.c index

[PATCH v3 0/3] DPDK Coverity issue 381631, 381646

v3: Split commits further for clarity. v2: Split code unrelated to coverity fix in separate commit. v1: Upstream fix to 23.03 for potential issue of dereferencing a pointer before null check. Hernan Vargas (3): baseband/acc: fix check after deref and dead code baseband/acc: remove unused ops

[PATCH v3 2/3] baseband/acc: remove unused ops check

Remove unnecessary debug check for ops. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c index baab459436..c242f7737a 100644 --- a/drivers/b

[PATCH v3 1/3] baseband/acc: fix check after deref and dead code

Fix potential issue of dereferencing a pointer before null check. Remove null check for value that could never be null. Coverity issue: 381646, 381631 Fixes: 989dec301a9 ("baseband/acc100: add ring companion address") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin

[PATCH v3 3/3] baseband/acc: add check for empty queue

Add optimization to return early if there are no available descriptors in ring to dequeue. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c

Re: [PATCH v4 00/10] dts: add hello world testcase

On Mon, Feb 20, 2023 at 11:13:45AM +0100, Juraj Linkeš wrote: > Thanks for the comments, Bruce. > > On Fri, Feb 17, 2023 at 6:26 PM Bruce Richardson > wrote: > > > > On Mon, Feb 13, 2023 at 04:28:36PM +0100, Juraj Linkeš wrote: > > > Add code needed to run the HelloWorld testcase which just runs

RE: [PATCH v4 06/19] remove repeated word 'in'

> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, February 22, 2023 4:25 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Van Haaren, Harry > ; Dongdong Liu ; Yisen > Zhuang ; Matan Azrad ; > Viacheslav Ovsiienko ; Andrew Rybchenko > ; Matz, Olivier > Subject: [PATCH v4 06/

Re: [PATCH v4 03/10] dts: add dpdk build on sut

On Mon, Feb 13, 2023 at 04:28:39PM +0100, Juraj Linkeš wrote: > Add the ability to build DPDK and apps on the SUT, using a configured > target. > > Signed-off-by: Juraj Linkeš > --- > dts/framework/config/__init__.py | 2 + > dts/framework/exception.py| 17 ++

Re: [PATCH] net/i40e: reduce the ITR interval of multi-driver mode

On 26/12/2022 05:50, Zhang, Qi Z wrote: -Original Message- From: Qiming Yang Sent: Friday, December 16, 2022 11:12 AM To: dev@dpdk.org; Xing, Beilei Cc: Yang, Qiming Subject: [PATCH] net/i40e: reduce the ITR interval of multi-driver mode This patch change the interrupt interval fro

Re: [PATCH 2/2] app/testpmd: user assigned flow ID to flows

22/02/2023 15:11, Eli Britstein: > Currently, testpmd assigns its own IDs, as indices, to created flows. > Later, the flow index is used as the ID for flow operations (query, > destroy, dump). > > Allow the user to assign a user-id, to be later used as an alternative > to the flow index testpmd as

RE: MAC address set requires decision

Hello, Moving this discussion to the dev mailing list as per the request in Techboard meeting today. I could not find a single email with all the responses from Techboard members. So, some of the comments need to be repeated. But this is the base response. Thanks, Honnappa > -Origi

  1   2   >