RE: [EXT] Re: [PATCH v2 4/5] ethdev: remove internal tracepoints from version map

>-Original Message- >From: David Marchand >Sent: Friday, February 10, 2023 7:50 PM >To: Ankur Dwivedi >Cc: dev@dpdk.org; tho...@monjalon.net; ferruh.yi...@amd.com; Jerin >Jacob Kollanukkaran >Subject: [EXT] Re: [PATCH v2 4/5] ethdev: remove internal tracepoints from >version map > >Ext

RE: [v2 00/16] net/mlx5/hws: support range and partial hash matching

Hi, > -Original Message- > From: Alex Vesker > Sent: Wednesday, February 1, 2023 9:28 AM > To: Alex Vesker ; Slava Ovsiienko > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > > Cc: Matan Azrad ; dev@dpdk.org; Ori Kam > > Subject: [v2 00/16] net/mlx5/hws: support range and partial hash matchi

[PATCH v3] net/iavf: add debug checks for mbuf

The scalar Tx path would send wrong mbuf that causes the kernel driver to fire the MDD event. This patch adds mbuf detection in tx_prepare and enables it by defining `RTE_ETHDEV_DEBUG_TX` macro to fix this issue. If validation fails, rte_errno will be set to EINVAL and returned. Fixes: 3fd32df381

[dpdk-web] [RFC PATCH] process: new library approval in principle

From: Jerin Jacob Based on TB meeting[1] action item, defining the process for new library approval in principle. [1] https://mails.dpdk.org/archives/dev/2023-January/260035.html Signed-off-by: Jerin Jacob --- content/process/_index.md | 33 + 1 file changed, 3

RE: [PATCH v8] mempool cache: add zero-copy get and put functions

> From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Monday, 13 February 2023 05.30 > > > > > > > +/** > > > > + * @internal used by rte_mempool_cache_zc_put_bulk() and > > > > rte_mempool_do_generic_put(). > > > > + * > > > > + * Zero-copy put objects in a mempool cache ba

Re: [PATCH v8] mempool cache: add zero-copy get and put functions

Hello, Thank you for this work, and sorry for the late feedback too. On Mon, Feb 13, 2023 at 04:29:51AM +, Honnappa Nagarahalli wrote: > > > > > > +/** > > > > + * @internal used by rte_mempool_cache_zc_put_bulk() and > > > > rte_mempool_do_generic_put(). > > > > + * > > > > + * Zero-copy p

RE: [PATCH] lib/net: support UDP pseudo-header for UFO

Hi Olivier, Thanks for your comments. Yes, this patch is to support the UDP fragmentation offload feature in the iavf driver, which is planned to be fully supported in 23.07. It's my fault for not clarifying the details. In addition, is it acceptable to add the UDP_SEG flag separately now? If

RE: [PATCH v8] mempool cache: add zero-copy get and put functions

> From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Monday, 13 February 2023 10.37 > > Hello, > > Thank you for this work, and sorry for the late feedback too. Better late than never. And it's a core library, so important to get it right! > > On Mon, Feb 13, 2023 at 04:29:51AM +,

RE: [PATCH 2/5] lib: add pdcp protocol

Hi Akhil, Thanks for the review. Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Wednesday, January 18, 2023 9:57 PM > To: Anoob Joseph ; Thomas Monjalon > ; Jerin Jacob Kollanukkaran ; > Konstantin Ananyev ; Bernard > Iremonger > Cc: Hemant Agrawal ;

Re: [PATCH v1] config: make max memzones definition configurable

On Sun, Feb 12, 2023 at 10:53:19AM +0200, Ophir Munk wrote: > In current DPDK the RTE_MAX_MEMZONE definition is unconditionally hard > coded as 2560. For applications requiring different values of this > parameter – it is more convenient to set its value as part of the meson > command line rather

[PATCH v10 0/4] add support for self monitoring

This series adds self monitoring support i.e allows to configure and read performance measurement unit (PMU) counters in runtime without using perf utility. This has certain advantages when application runs on isolated cores running dedicated tasks. Events can be read directly using rte_pmu_read()

[PATCH v10 1/4] lib: add generic support for reading PMU events

Add support for programming PMU counters and reading their values in runtime bypassing kernel completely. This is especially useful in cases where CPU cores are isolated i.e run dedicated tasks. In such cases one cannot use standard perf utility without sacrificing latency and performance. Signed

[PATCH v10 2/4] pmu: support reading ARM PMU events in runtime

Add support for reading ARM PMU events in runtime. Signed-off-by: Tomasz Duszynski Acked-by: Morten Brørup --- app/test/test_pmu.c | 4 ++ lib/pmu/meson.build | 7 +++ lib/pmu/pmu_arm64.c | 94 + lib/pmu/rte_pmu.h | 4 ++

[PATCH v10 3/4] pmu: support reading Intel x86_64 PMU events in runtime

Add support for reading Intel x86_64 PMU events in runtime. Signed-off-by: Tomasz Duszynski Acked-by: Morten Brørup --- app/test/test_pmu.c | 2 ++ lib/pmu/meson.build | 1 + lib/pmu/rte_pmu.h| 2 ++ lib/pmu/rte_pmu_pmc_x86_64.h | 24 4

[PATCH v10 4/4] eal: add PMU support to tracing library

In order to profile app one needs to store significant amount of samples somewhere for an analysis latern on. Since trace library supports storing data in a CTF format lets take adventage of that and add a dedicated PMU tracepoint. Signed-off-by: Tomasz Duszynski Acked-by: Morten Brørup --- app

[PATCH v2 0/5] add IPv6 routing extension implementation

Add IPv6 routing extension matching and IPv6 protocol modify filed support. This patch relies on the preceding ethdev one: http://patches.dpdk.org/project/dpdk/patch/20230202100021.2445976-2-rongw...@nvidia.com/ Including one commit from Gregory to pass the compilation. Gregory Etelson (1): ne

[PATCH v2 1/5] net/mlx5: adopt IPv6 routing extension prm definition

Per newest PRM definition, sample_id stands for 3 parts of information instead of single uint32_t id: sample_id + modify_filed_id + format_select_dw. Also new FW capability bits have been introduces to identify the new capability. Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- d

[PATCH v2 2/5] net/mlx5/hws: Definer, add mlx5dr context to definer_conv_data

From: Gregory Etelson New mlx5dr_context member replaces mlx5dr_cmd_query_caps. Capabilities structure is a member of mlx5dr_context. Signed-off-by: Gregory Etelson Signed-off-by: Rongwei Liu Reviewed-by: Alex Vesker Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/hws/mlx5dr_definer.c |

[PATCH v2 5/5] doc/mlx5: add IPv6 routing extension matching docs

Update mlx5 related document on IPv6 routing extension header matching. Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- doc/guides/nics/features/default.ini | 1 + doc/guides/nics/features/mlx5.ini| 1 + doc/guides/nics/mlx5.rst | 2 ++ 3 files changed, 4 insertion

[PATCH v2 3/5] net/mlx5/hws: add IPv6 routing extension matching support

Add mlx5 HWS logic to match IPv6 routing extension header. Once detecting IPv6 matching extension items in pattern template create callback, PMD allocates a flex parser to sample the first dword of srv6 header. Only support next_hdr/segments_left/type for now. Signed-off-by: Rongwei Liu eviewed

[PATCH v2 4/5] net/mlx5/hws: add modify IPv6 protocol implementation

Add HWS modify IPv6 protocol implementation. Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_prm.h | 1 + drivers/net/mlx5/mlx5_flow_dv.c | 10 ++ 2 files changed, 11 insertions(+) diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx

Re: [PATCH v3 2/2] doc: add Arkville FX2 PCIe device description

On 2/11/2023 3:07 AM, Shepard Siegel wrote: > Hi Ferruh, > > I don't think the submission system will allow your request of a single > patch with both a code change and document change since they are in > different directories. I must say I'm confused by your request. In the > current v3 which is

[PATCH v9] mempool cache: add zero-copy get and put functions

Zero-copy access to mempool caches is beneficial for PMD performance, and must be provided by the mempool library to fix [Bug 1052] without a performance regression. [Bug 1052]: https://bugs.dpdk.org/show_bug.cgi?id=1052 Bugzilla ID: 1052 Signed-off-by: Morten Brørup Acked-by: Konstantin Ananye

RE: [PATCH v10 1/2] ethdev: add query and update sync and async function calls

Hello Andrew, What holds merge of https://patches.dpdk.org/project/dpdk/list/?series=26763 ? Regards, Gregory > -Original Message- > From: Gregory Etelson > Sent: Sunday, 12 February 2023 13:13 > To: Ferruh Yigit ; dev@dpdk.org; Andrew > Rybchenko > Cc: Matan Azrad ; Raslan Darawsheh >

RE: [PATCH v6 1/3] ethdev: skip congestion management configuration

> -Original Message- > From: Ferruh Yigit > Sent: Saturday, 11 February 2023 1:10 > > On 2/10/2023 8:26 AM, Rakesh Kudurumalla wrote: > > Introduce new flow action to skip congestion management configuration > > This feature helps to skip the congestion management processing > > based o

[PATCH] eal/bsd: fix spinlock not unlock in alarm callback

The spinlock should unlock when clock_gettime() failed. This patch fixes it by invoking clock_gettime() before lock. Fixes: 26021a715067 ("eal/bsd: support alarm API") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- lib/eal/freebsd/eal_alarm.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH v4 0/5] net/mlx5: sharing indirect actions between port

Adds shared indirect action support to mlx5 PMD. Erez Shitrit (2): net/mlx5/hws: free FT from RTC ID before set the new value net/mlx5/hws: fix disconnecting matcher Viacheslav Ovsiienko (3): common/mlx5: add cross port object sharing capability net/mlx5: add cross port shared mode for HW

[PATCH v4 1/5] net/mlx5/hws: free FT from RTC ID before set the new value

From: Erez Shitrit While matcher is being connect/disconnect in shared gvmi flow we set the first ft in the table to point on the first matcher, The FW is increasing the refcount on the first matcher RTC because of that no matcher if it is the same RTC that was set before, and when we will try to

[PATCH v4 3/5] common/mlx5: add cross port object sharing capability

Add query port capabilities to share steering objects between multiple ports of the same physical NIC. Signed-off-by: Viacheslav Ovsiienko Acked-by: Ori Kam --- drivers/common/mlx5/mlx5_devx_cmds.c | 13 + drivers/common/mlx5/mlx5_devx_cmds.h | 1 + 2 files changed, 14 insertions(+

[PATCH v4 2/5] net/mlx5/hws: fix disconnecting matcher

From: Erez Shitrit This patch fixes the matcher disconnection handling, by removing the RTC references from flow table if the currently removed matcher was the last one for the given table. As a result RTC in this matcher can be correctly freed, since there are no dangling references to the RTC.

[PATCH v4 4/5] net/mlx5: add cross port shared mode for HW steering

Add host port option for sharing steering objects between multiple ports of the same physical NIC. Signed-off-by: Viacheslav Ovsiienko Acked-by: Ori Kam --- drivers/net/mlx5/mlx5.c | 6 +++ drivers/net/mlx5/mlx5.h | 2 + drivers/net/mlx5/mlx5_flow_hw.c | 78 +++

[PATCH v4 5/5] net/mlx5: support counters in cross port shared mode

In the cross vHCA sharing mode the host counter pool should be used in counter related routines. The local port pool is used to store the dedicated DR action handle, per queue counter caches and query data are ignored and not allocated on local pool. Signed-off-by: Viacheslav Ovsiienko Acked-by:

[PATCH v3] net/mlx5/hws: support match on ESP item

From: Hamdan Igbaria Add the support to match on SPI and sequence number fields of ESP header. The match on ESP header in hardware steering is supported only if firmware reports the device supports IPsec offload. Signed-off-by: Hamdan Igbaria Acked-by: Viacheslav Ovsiienko --- drivers/common

Re: [PATCH 1/2] net/ark: add new device to PCIe allowlist

On 2/11/2023 2:14 PM, Shepard Siegel wrote: > This patch adds the Arkville FX2 device to the PCIe allowlist. > > Signed-off-by: Shepard Siegel Hi Shepard, Ed, The patchset looks good, I can squash them into single patch while merging. I don't know how major this new device is, if it is an impo

Re: [PATCH v6 1/3] ethdev: skip congestion management configuration

On 2/13/2023 12:34 PM, Ori Kam wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Saturday, 11 February 2023 1:10 >> >> On 2/10/2023 8:26 AM, Rakesh Kudurumalla wrote: >>> Introduce new flow action to skip congestion management configuration >>> This feature helps to skip th

Re: [PATCH v1] config: make max memzones definition configurable

13/02/2023 12:05, Bruce Richardson: > On Sun, Feb 12, 2023 at 10:53:19AM +0200, Ophir Munk wrote: > > In current DPDK the RTE_MAX_MEMZONE definition is unconditionally hard > > coded as 2560. For applications requiring different values of this > > parameter – it is more convenient to set its value

[PATCH v2] eal: cleanup alarm and multiprocess hotplug before memory detach

Alarm and multiprocess hotplug still need access hugepage memory, if alarm event processed after memory detach, it may cause SEGV. So cleanup alarm and multiprocess hotplug before memory detach. Fixes: 90b13ab8d4f7 ("alarm: remove direct access to interrupt handle") Fixes: a0cc7be20dd1 ("mem: clea

[PATCH v2] eal: cleanup alarm and multiprocess hotplug before memory detach

Alarm and multiprocess hotplug still need access hugepage memory, if alarm event processed after memory detach, it may cause SEGV. So cleanup alarm and multiprocess hotplug before memory detach. Fixes: 90b13ab8d4f7 ("alarm: remove direct access to interrupt handle") Fixes: a0cc7be20dd1 ("mem: clea

0day-bot system is shutting down for electrical work

Hi all, We are shutting down 0day-bot for scheduled electrical work in the lab. We will be back online next week the latest Best

RE: [PATCH v9] mempool cache: add zero-copy get and put functions

Patch looks good to me Acked-by: Kamalakshitha Aligeri > -Original Message- > From: Morten Brørup > Sent: Monday, February 13, 2023 4:25 AM > To: olivier.m...@6wind.com; andrew.rybche...@oktetlabs.ru; Honnappa > Nagarahalli ; Kamalakshitha Aligeri > ; bruce.richard...@intel.com; > konst

[PATCH] disable lock annotation with clang 3.4.2

Venerable RHEL7 clang 3.4.2 has (at least) two issues with lock annotations. A first one with regards to the attribute position: ../lib/vhost/vhost.h:518:2: error: GCC does not allow assert_exclusive_lock attribute in this position on a function definition [-Werror,-Wgcc-compat]

Re: [PATCH v1] config: make max memzones definition configurable

On Mon, Feb 13, 2023 at 02:55:41PM +0100, Thomas Monjalon wrote: > 13/02/2023 12:05, Bruce Richardson: > > On Sun, Feb 12, 2023 at 10:53:19AM +0200, Ophir Munk wrote: > > > In current DPDK the RTE_MAX_MEMZONE definition is unconditionally > > > hard coded as 2560. For applications requiring differ

Re: [PATCH] disable lock annotation with clang 3.4.2

On Mon, Feb 13, 2023 at 03:44:55PM +0100, David Marchand wrote: > Venerable RHEL7 clang 3.4.2 has (at least) two issues with lock > annotations. > > A first one with regards to the attribute position: > ../lib/vhost/vhost.h:518:2: error: GCC does not allow > assert_exclusive_lock attribute i

[PATCH 1/4] doc: clarify the existing net/ark guide

Add detail for the existing Arkville configurations FX0 and FX1. Corrected minor errors of omission. Signed-off-by: Shepard Siegel --- doc/guides/nics/ark.rst | 18 ++ 1 file changed, 18 insertions(+) diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst index ba00f14e8

[PATCH 2/4] net/ark: add new device to PCIe allowlist

This patch adds the Arkville FX2 device to the PCIe allowlist. Signed-off-by: Shepard Siegel --- drivers/net/ark/ark_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c index c654a229f7..b2995427c8 100644 --- a/drivers/net/ark/

[PATCH 3/4] doc: update ark guide to include new PCIe device

Add descriptions of the new FX2 device to the existing devices. Signed-off-by: Shepard Siegel --- doc/guides/nics/ark.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst index edaa02dc96..bbd7419d99 100644 --- a/doc/guides/nics/ark.rst +++

[PATCH 4/4] doc: update Release Notes

New Arkville FX2 device for PCIe Gen5x16 supported with net/ark Signed-off-by: Shepard Siegel --- doc/guides/rel_notes/release_23_03.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_23_03.rst b/doc/guides/rel_notes/release_23_03.rst index 7527c6d57f..7941

Re: [PATCH 1/2] net/ark: add new device to PCIe allowlist

Thank you Ferruh, We have rolled all changes, including your suggestion on the Release Note, into the four distinct patches in this patchset which collectively brings the ark PMD up to date for this new capability. best, Shep On Mon, Feb 13, 2023 at 8:46 AM Ferruh Yigit wrote: > On 2/11/2023

[PATCH v4 00/10] dts: add hello world testcase

Add code needed to run the HelloWorld testcase which just runs the hello world dpdk application. The patchset currently heavily refactors this original DTS code needed to run the testcase: * The whole architecture has been redone into more sensible class hierarchy * DPDK build on the System unde

[PATCH v4 01/10] dts: add node and os abstractions

The abstraction model in DTS is as follows: Node, defining and implementing methods common to and the base of SUT (system under test) Node and TG (traffic generator) Node. Remote Session, defining and implementing methods common to any remote session implementation, such as SSH Session. OSSession,

[PATCH v4 02/10] dts: add ssh command verification

This is a basic capability needed to check whether the command execution was successful or not. If not, raise a RemoteCommandExecutionError. When a failure is expected, the caller is supposed to catch the exception. Signed-off-by: Juraj Linkeš --- dts/framework/exception.py|

Re: [PATCH] eal: introduce atomics abstraction

There is a thread discussing a change to the standard [1] but I have not seen anything explicit yet about moving to C11. I am personally in favor of making the jump to C11 now as part of the 23.x branch and provided my thoughts in the linked thread (what other projects using DPDK have as minimum c

[PATCH v4 03/10] dts: add dpdk build on sut

Add the ability to build DPDK and apps on the SUT, using a configured target. Signed-off-by: Juraj Linkeš --- dts/framework/config/__init__.py | 2 + dts/framework/exception.py| 17 ++ dts/framework/remote_session/os_session.py| 90 +- dts/framewo

[PATCH v4 04/10] dts: add dpdk execution handling

Add methods for setting up and shutting down DPDK apps and for constructing EAL parameters. Signed-off-by: Juraj Linkeš --- dts/conf.yaml | 4 + dts/framework/config/__init__.py | 8 + dts/framework/config/conf_yaml_schema.json| 25 ++ dts/fr

[PATCH v4 05/10] dts: add node memory setup

Setup hugepages on nodes. This is useful not only on SUT nodes, but also on TG nodes which use TGs that utilize hugepages. The setup is opt-in, i.e. users need to supply hugepage configuration to instruct DTS to configure them. It not configured, hugepage configuration will be skipped. This is hel

[PATCH v4 06/10] dts: add test suite module

The module implements the base class that all test suites inherit from. It implements methods common to all test suites. The derived test suites implement test cases and any particular setup needed for the suite or tests. Signed-off-by: Juraj Linkeš --- dts/conf.yaml

[PATCH v4 07/10] dts: add hello world testsuite

The test suite implements test cases defined in the corresponding test plan. Signed-off-by: Juraj Linkeš --- dts/framework/remote_session/__init__.py | 2 +- dts/framework/remote_session/os_session.py| 16 - .../remote_session/remote/__init__.py | 2 +- dts/framework/testb

[PATCH v4 08/10] dts: add test suite config and runner

The config allows users to specify which test suites and test cases within test suites to run. Also add test suite running capabilities to dts runner. Signed-off-by: Juraj Linkeš --- dts/conf.yaml | 2 ++ dts/framework/config/__init__.py | 29 +

[PATCH v4 09/10] dts: add test results module

The module stores the results and errors from all executions, build targets, test suites and test cases. The result consist of the result of the setup and the teardown of each testing stage (listed above) and the results of the inner stages. The innermost stage is the case, which also contains the

[PATCH v4 10/10] doc: update DTS setup and test suite cookbook

Document how to configure and run DTS. Also add documentation related to new features: SUT setup and a brief test suite implementation cookbook. Signed-off-by: Juraj Linkeš --- doc/guides/tools/dts.rst | 145 ++- 1 file changed, 144 insertions(+), 1 deletion(-

Re: [PATCH v6 1/3] ethdev: skip congestion management configuration

On Mon, Feb 13, 2023 at 7:25 PM Ferruh Yigit wrote: > > On 2/13/2023 12:34 PM, Ori Kam wrote: > > > > > >> -Original Message- > >> From: Ferruh Yigit > >> Sent: Saturday, 11 February 2023 1:10 > >> > >> On 2/10/2023 8:26 AM, Rakesh Kudurumalla wrote: > >>> Introduce new flow action to ski

Re: [PATCH 1/4] doc: clarify the existing net/ark guide

On 2/13/2023 2:58 PM, Shepard Siegel wrote: > Add detail for the existing Arkville configurations FX0 and FX1. > Corrected minor errors of omission. > > Signed-off-by: Shepard Siegel > --- > doc/guides/nics/ark.rst | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/doc

Re: [PATCH v3 0/4] compressdev: add LZ4 support

Hi, The patchset only have library change and added performance tests. We shall have at least one PMD to support the added algorithms and unit test updated for the PMD/algorithms. Regards, Fan On 2/13/2023 6:11 AM, Michael Baum wrote: Add support for LZ4 compression algorithm for both API

Re: [PATCH 2/4] net/ark: add new device to PCIe allowlist

On 2/13/2023 2:58 PM, Shepard Siegel wrote: > This patch adds the Arkville FX2 device to the PCIe allowlist. > > Signed-off-by: Shepard Siegel > --- > drivers/net/ark/ark_ethdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.

Re: [PATCH v6 1/3] ethdev: skip congestion management configuration

On 2/13/2023 3:44 PM, Jerin Jacob wrote: > On Mon, Feb 13, 2023 at 7:25 PM Ferruh Yigit wrote: >> >> On 2/13/2023 12:34 PM, Ori Kam wrote: >>> >>> -Original Message- From: Ferruh Yigit Sent: Saturday, 11 February 2023 1:10 On 2/10/2023 8:26 AM, Rakesh Kudurumalla

Re: [PATCH] eal: introduce atomics abstraction

On Mon, Feb 13, 2023 at 10:28:40AM -0500, Ben Magistro wrote: >There is a thread discussing a change to the standard [1] but I have >not seen anything explicit yet about moving to C11. I am personally in >favor of making the jump to C11 now as part of the 23.x branch and >provided

RE: [PATCH v3 0/4] compressdev: add LZ4 support

On 2/13/2023 17:47 PM, Zhang, Fan wrote: > Hi, > > The patchset only have library change and added performance tests. > > We shall have at least one PMD to support the added algorithms and unit test > updated for the PMD/algorithms. There is another patchset which adds it in MLX5 compress PMD:

RE: [PATCH] disable lock annotation with clang 3.4.2

> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Monday, 13 February 2023 15.55 > > On Mon, Feb 13, 2023 at 03:44:55PM +0100, David Marchand wrote: > > Venerable RHEL7 clang 3.4.2 has (at least) two issues with lock > > annotations. > > > > A first one with regards to the attri

RE: [PATCH] disable lock annotation with clang 3.4.2

> -Original Message- > From: Morten Brørup > Sent: Monday, February 13, 2023 6:09 PM > To: Bruce Richardson ; David Marchand > > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Raslan Darawsheh ; > Chenbo Xia ; Maxime Coquelin > > Subject: RE: [PATCH] disable lock annotatio

Re: [PATCH] eal: introduce atomics abstraction

On Mon, Feb 13, 2023 at 10:55 AM Bruce Richardson < bruce.richard...@intel.com> wrote: > On Mon, Feb 13, 2023 at 10:28:40AM -0500, Ben Magistro wrote: > >There is a thread discussing a change to the standard [1] but I have > >not seen anything explicit yet about moving to C11. I am person

RE: [PATCH v1] config: make max memzones definition configurable

Since the new rte API was "discussed in recent years" and it is also dependent on different driver vendors acceptance - I suggest that the compilation option will be applied now. The new rte API effort will start in parallel. Once accepted - it will replace the compilation option. > -Origin

Re: [PATCH 1/4] doc: clarify the existing net/ark guide

Hi Ferruh, Yes, there will probably be next versions in the future. If you don't mind making the marker length adjustment, that would be great. Regarding MBUF (re)sizing - Arkville supports the ability to configure or reconfigure the MBUF size used on a per-queue basis. This feature is useful wh

Re: [PATCH 2/4] net/ark: add new device to PCIe allowlist

Hi Ferruh, If you dont mind squashing 2/4 3/4 4/4 together, that would be great. Thank you for correcting on the allowlist, s..b "supported PCIe ids list" instead. best, Shep On Mon, Feb 13, 2023 at 10:51 AM Ferruh Yigit wrote: > On 2/13/2023 2:58 PM, Shepard Siegel wrote: > > This patch add

Re: [PATCH 1/4] doc: clarify the existing net/ark guide

On 2/13/2023 5:09 PM, Shepard Siegel wrote: > Hi Ferruh, > > Yes, there will probably be next versions in the future. If you don't > mind making the marker length adjustment, that would be great. > > Regarding MBUF (re)sizing  - Arkville supports the ability to configure > or reconfigure the MBUF

Re: [PATCH 1/4] doc: clarify the existing net/ark guide

Yes, what is different here is that the MBUF size is communicated from the PMD to the hardware which *changes its behavior* of data motion to optimize throughput and latency as a function of that setting. And it does that per-queue. And can be done at runtime (that's the dynamic part). ... To the b

Observed issues with the FIPS sample app

Hello all, At the UNH Community Lab, we are now running CI testing for cryptodev validation using the FIPS sample application. In setting up testing we have run into issues with the sample app documentation being out of date. In places it points to dependency versions which do not work with the sa

RE: [PATCH] eal: introduce atomics abstraction

Hi Ben, Only bug fixes are backported to LTS. Not even new NIC drivers are backported. Reference: https://doc.dpdk.org/guides/contributing/stable.html#what-changes-should-be-backported -Morten

Re: [PATCH v2] ethdev: telemetry xstats support hide zero

On 2/13/2023 2:34 AM, Chengwen Feng wrote: > The number of xstats may be large, after the hide zero option is added, > only non-zero values can be displayed. > > So display xstats with hide zero: > /ethdev/xstats,0,hide_zero=true > and without hide zero (same as the original): > /ethde

[PATCH v3 0/2] Integrated mempool cache zero-copy API's

In i40e PMD, for fast_free path in Tx, freeing mbufs firstly need to do an extra memcpy due to the special structure of ‘txep’. Thus, replaced the put_bulk function with the zero-copy put API to avoid the cost of this memcpy On Ampere-altra server, for single-core DPDK l3fwd test, throughput improv

[PATCH v3 1/2] net/i40e: replace put function

Integrated zero-copy put API in mempool cache in i40e PMD. On Ampere Altra server, l3fwd single core's performance improves by 5% with the new API Signed-off-by: Kamalakshitha Aligeri Reviewed-by: Ruifeng Wang Reviewed-by: Feifei Wang --- Link: http://patches.dpdk.org/project/dpdk/patch/202302

[PATCH v3 2/2] test/mempool: add zero-copy API's

Added mempool test cases with zero-copy get and put API's Signed-off-by: Kamalakshitha Aligeri Reviewed-by: Ruifeng Wang Reviewed-by: Feifei Wang Acked-by: Morten Brørup --- Link: http://patches.dpdk.org/project/dpdk/patch/20230213122437.122858-1...@smartsharesystems.com/ app/test/test_memp

RE: [PATCH v1 09/13] test/bbdev: bbdev-test cannot compare some scenarios

Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, January 31, 2023 4:16 AM > To: Vargas, Hernan ; dev@dpdk.org; > gak...@marvell.com; Rix, Tom > Cc: Chautru, Nicolas ; Zhang, Qi Z > > Subject: Re: [PATCH v1 09/13] test/bbdev: bbdev-test cannot compare some > sce

[PATCH v4 00/19] Replace use of static logtypes

This patchset removes the main uses of static LOGTYPE's in DPDK libraries. It starts with the easy one and goes on to the more complex ones. Note: there is one patch in this series that will get flagged incorrectly as an ABI change. v4 - use simpler/shorter method for setting local LOGTYPE s

[PATCH 2/2] net/ark: add new ark PCIe device

This patch adds the Arkville FX2 to known PCIe device list Update documentation and release notes. Signed-off-by: Shepard Siegel --- doc/guides/nics/ark.rst| 3 ++- doc/guides/rel_notes/release_23_03.rst | 4 drivers/net/ark/ark_ethdev.c | 1 + 3 files changed, 7 i

[PATCH 1/2] doc: clarify the existing net/ark guide

Add detail for the existing Arkville configurations FX0 and FX1. Corrected minor errors of omission. Signed-off-by: Shepard Siegel --- doc/guides/nics/ark.rst | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rs

[PATCH v4 01/19] gso: don't log message on non TCP/UDP

If a large packet is passed into GSO routines of unknown protocol then library would log a message. Better to tell the application instead of logging. Fixes: 119583797b6a ("gso: support TCP/IPv4 GSO") Cc: jiayu...@intel.com Signed-off-by: Stephen Hemminger --- lib/gso/rte_gso.c | 5 ++--- 1 file

[PATCH v4 03/19] log: drop unused RTE_LOGTYPE_TIMER

The timer code does not use rte_log. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common_log.c index 894701e8c

[PATCH v4 02/19] eal: drop no longer used GSO logtype

The message that used this was replaced in previous patch. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common

[PATCH v4 04/19] efd: replace RTE_LOGTYPE_EFD with dynamic type

Replace all uses of the global logtype with a dynamic log type. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/efd/rte_efd.c | 3 +++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/eal/comm

[PATCH v4 06/19] acl: replace LOGTYPE_ACL with dynamic type

Get rid of RTE_LOGTYPE_ACL and RTE_LOGTYPE_MALLOC. For ACL library use a dynamic type. The one message using RTE_LOGTYPE_MALLOC should have been under the ACL logtype anyway. The test code should not have been using fixed log type so just change that to stderr. Signed-off-by: Stephen Hemminger -

[PATCH v4 05/19] mbuf: replace RTE_LOGTYPE_MBUF with dynamic type

Introduce a new dynamic logtype for mbuf related messages. Since this is used in multiple files put one macro in mbuf_log.h Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/mbuf/mbuf_log.h | 4 lib/mbuf/rte_m

[PATCH v4 07/19] power: replace RTE_LOGTYPE_POWER with dynamic type

Use dynamic log type for power library. Also replace use of RTE_LOGTYPE_USER1 with lib.power.guest. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h| 2 +- lib/power/guest_channel.c| 3 ++- lib/power/power_common.c | 2

[PATCH v4 08/19] ring: replace RTE_LOGTYPE_RING with dynamic type

The logtype for ring only used in library. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/ring/rte_ring.c | 3 +++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_log.c b

[PATCH v4 09/19] mempool: replace RTE_LOGTYPE_MEMPOOL with dynamic type

Convert from RTE_LOGTYPE_MEMPOOL to logtype_mempool. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/mempool/rte_mempool.c | 3 +++ lib/mempool/rte_mempool_log.h | 4 lib/mempool/rte_mempool_ops.c | 1 + 5 fil

[PATCH v4 11/19] kni: replace RTE_LOGTYPE_KNI with dynamic type

Even though KNI will eventually disappear, fix the logtype now. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/kni/rte_kni.c | 3 +++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/eal/comm

[PATCH v4 10/19] lpm: replace RTE_LOGTYPE_LPM with dynamic types

Split lpm and lpm6 into separate log types since they are in different files and user may want to change log levels for IPv4 vs IPv6. For rib and fib libraries give them own types as well. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h

[PATCH v4 12/19] sched: replace RTE_LOGTYPE_SCHED with dynamic type

Also can remove unused RTE_LOGTYPE_METER Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 2 -- lib/eal/include/rte_log.h | 4 ++-- lib/sched/rte_pie.c | 1 + lib/sched/rte_sched.c | 5 + lib/sched/rte_sched_log.h | 4 5 files chan

[PATCH v4 13/19] port: replace RTE_LOGTYPE_PORT with dynamic type

Split up the single static RTE_LOGTYPE_PORT into separate sub types for each component: port.ethdev, port.evendev, ... Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/port/rte_port_ethdev.c | 3 +++ lib/port/rte_port_ev

[PATCH v4 14/19] table: convert RTE_LOGTYPE_TABLE to dynamic logtype

Use logtype suffixes for various components of this library. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/table/rte_table_acl.c | 3 +++ lib/table/rte_table_array.c | 3 +++ lib/table/rte_table_hash_cuck

[PATCH v4 15/19] app/test: remove use of RTE_LOGTYPE_PIPELINE

Instead of using static type PIPELINE for logging in test application use stderr instead. If not testing RTE_LOG() better to not use it since log also goes to syslog. Signed-off-by: Stephen Hemminger --- app/test/test_table_acl.c | 50 -- app/test/test_table

  1   2   >