[PATCH v2 0/4] ethdev: add template table insertion and matching types

2023-01-26 Thread Alexander Kozyrev
Bring more flexibility and control over both flow rule insertion and packet matching mechanisms. Introduce 2 new flow table types: 1. Allow a user to specify the insertion type used in template tables. The insertion type is responsible for choosing the appropriate key value used to map inserted fl

[PATCH v2 1/4] ethdev: add template table insertion type

2023-01-26 Thread Alexander Kozyrev
Allow user to specify insertion type used in template tables. The insertion type is responsible for choosing the appropriate key value used to map inserted flow rules into a template table. Flow rules can be inserted by calculating the hash value for the pattern or inserted by index via the new cr

[PATCH v2 2/4] ethdev: add template table hash calculation function

2023-01-26 Thread Alexander Kozyrev
Allow user to specify hash calculation function used in template tables. The hash calculation type is responsible for the calculation of the flow rule index a packet would hit upon arrival at the table. Control over this is useful for applications with custom RSS algorithms, for example. An applic

[PATCH v2 4/4] app/testpmd: add template table hash calculation function

2023-01-26 Thread Alexander Kozyrev
Add testpmd CLI interface for a template table hash function. Available types are: default, linear, crc32 and crc16. flow template_table 0 create table_id 0 hash_func linear ... Signed-off-by: Alexander Kozyrev --- app/test-pmd/cmdline_flow.c | 69 - 1 file ch

[PATCH v2 3/4] app/testpmd: add template table insertion type

2023-01-26 Thread Alexander Kozyrev
Add testpmd CLI interface for specifying a template table insertion type. Available types are: pattern and index. flow template_table 0 create table_id 0 insertion_type index ... Allow specifying the rule index instead of the pattern template index: flow queue 0 create 0 template_table 0 rule_index

[PATCH 0/4] net/mlx5: add template table insertion and matching types

2023-01-26 Thread Alexander Kozyrev
Add the insertion type and hash calculation function of a template table. Support the new rte_flow_async_create_by_index() Flow API to allow flow rules insertion into a specified index of index-based template tables. Set MLX5_LINEAR_HASH_TAG_INDEX as a special id for specifiyng the index. Allow to

[PATCH 1/4] net/mlx5: add table insertion type and hash function

2023-01-26 Thread Alexander Kozyrev
Pass the insertion type and hash calculation function of a table to the mlx5 PMD driver. Create appropriate table as requested. Note that 16-bit checksum hash calculation is not supported yet. Signed-off-by: Alexander Kozyrev --- drivers/net/mlx5/mlx5_flow_hw.c | 26 +- 1

[PATCH 2/4] net/mlx5: add flow rule insertion by index

2023-01-26 Thread Alexander Kozyrev
New Flow API allows to insert flow rules into a specified index for tables with the index-based insertion type. Implement rte_flow_async_create_by_index API in mlx5 PMD. Signed-off-by: Alexander Kozyrev --- drivers/net/mlx5/mlx5_flow.c| 61 + drivers/net/mlx5/mlx5_flow.h

[PATCH 3/4] net/mlx5: add hash result metadata to modify field

2023-01-26 Thread Alexander Kozyrev
Allow copy of the hash result via modify_field Flow API. Setting this value is not allowed, it is read-only field. Signed-off-by: Alexander Kozyrev --- drivers/net/mlx5/mlx5_flow_dv.c | 12 drivers/net/mlx5/mlx5_flow_hw.c | 5 +++-- 2 files changed, 15 insertions(+), 2 deletions(-)

[PATCH 4/4] net/mlx5: define index register for linear tables

2023-01-26 Thread Alexander Kozyrev
Set MLX5_LINEAR_HASH_TAG_INDEX as a special id for the TAG item: it holds the index in a linear table for a packet to land to. This rule index in the table uses upper 16-bits of REG_C_3, handle this TAG item in the modify_field API for setting the index. Signed-off-by: Alexander Kozyrev --- driv

[PATCH] net/mlx5: fix error CQE dumping for vectorized Rx burst

2023-01-26 Thread Alexander Kozyrev
There is a dump file with debug information created for an error CQE to help with troubleshooting later. It starts with the last CQE, which, presumably is the error CQE. But this is only true for the scalar Rx burst routing since we handle CQEs there one by one and detect the error immediately. For

[PATCH] net/mlx5: ignore non-critical syndromes for Rx queue

2023-01-26 Thread Alexander Kozyrev
For non-fatal syndromes like LOCAL_LENGTH_ERR, the Rx queue reset shouldn't be triggered. Rx queue could continue with the next packets without any recovery. Only three syndromes warrant Rx queue reset: LOCAL_QP_OP_ERR, LOCAL_PROT_ERR and WR_FLUSH_ERR. Do not initiate a Rx queue reset in any other

[PATCH] net/mlx5: check compressed CQE opcode for an error

2023-01-26 Thread Alexander Kozyrev
The CQE opcode is never checked for a compressed CQE in the vectorized Rx burst routines. It is assumed that compressed CQEs are always valid and skipped error checking. This is obviously not the case and error CQEs may be compressed together as well. Need to check for the MLX5_CQE_RESP_ERR opcode

Re: [EXT] Re: [dpdk-dev] [PATCH v1 00/12] mldev: introduce machine learning device library

2023-01-26 Thread Jerin Jacob
On Fri, Jan 27, 2023 at 8:04 AM Shivah Shankar Shankar Narayan Rao wrote: > > External Email > > -- > 25/01/2023 20:01, Jerin Jacob: > > On Wed, Jan 25, 2023 at 7:50 PM Thomas Monjalon wrote: > > > 14/11/2022 13:02, jer...@marvel

RE: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-01-26 Thread Nithin Kumar Dabilpuram
Please see inline. > -Original Message- > From: Thomas Monjalon > Sent: Thursday, January 26, 2023 4:33 PM > To: Nithin Kumar Dabilpuram > Cc: Aman Singh ; Yuying Zhang > ; > Ivan Malov ; Andrew Rybchenko > ; dev@dpdk.org; Hanumanth Reddy Pothula > ; Ferruh Yigit ; > viachesl...@nvidia

Re: [PATCH 1/3] lib: dpdk spec to skip red for ingress policer

2023-01-26 Thread Jerin Jacob
On Thu, Jan 26, 2023 at 8:43 PM Ori Kam wrote: > > > > > -Original Message- > > From: Rakesh Kudurumalla > > Sent: Wednesday, 18 January 2023 10:10 > > > > > > > -Original Message- > > > From: Rakesh Kudurumalla > > > Sent: Tuesday, January 10, 2023 12:12 PM > > > To: Ori Kam ; Je

Re: [EXT] Re: [PATCH v3 0/4] implementation of ML common code

2023-01-26 Thread Jerin Jacob
On Thu, Jan 26, 2023 at 4:27 PM Thomas Monjalon wrote: > > 25/01/2023 15:59, Srikanth Yalavarthi: > > From: Thomas Monjalon > > > 25/01/2023 14:25, Srikanth Yalavarthi: > > > > From: Thomas Monjalon > > > > > 20/12/2022 18:52, Srikanth Yalavarthi: > > > > > > This patch series implements the com

<    1   2