[RFC] eal: per-thread constructors/destructors

2022-12-18 Thread Morten Brørup
This RFC introduces per-thread constructors/destructors: * Per-thread constructors are functions called as the first thing from newly created threads. This can be used to initialize variables in thread-local storage, variables depending on the (tid_t) thread id, and to call setup functions that

C++20 report error at file rte_spinlock.h

2022-12-18 Thread Zhou, Xiangyun
Dear dpdk dev, I'm using dpdk 21.11 LTS, when compile my program with CPP flag "-std=c++20", the compiler report below errors. After checking file rte_spinlock.h, I think the error report by compiler is valid, there should be a potential issue when using functions rte_spinlock_recursive_lock, r

[PATCH] eal: cleanup alarm and multiprocess hotplug before memory detach

2022-12-18 Thread Fengnan Chang
Alarm and multiprocess hotplug still need access hugepage memory, if alarm event processed after memory detach, it may cause SEGV. So cleanup alarm and multiprocess hotplug before memory detach. Signed-off-by: Fengnan Chang --- lib/eal/linux/eal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 del

Re: [External] Re: [PATCH] eal: cleanup alarm and multiprocess hotplug before memory detach

2022-12-18 Thread Fengnan Chang
Thomas Monjalon 于2022年12月13日周二 16:34写道: > > 13/12/2022 08:59, Fengnan Chang: > > Alarm and multiprocess hotplug still need access hugepage memory, > > if alarm event processed after memory detach, it may cause SEGV. > > So cleanup alarm and multiprocess hotplug before memory detach. > > > > Signed

Reminder - DTS Working Group - Tomorrow, Wed. 12/14 at 9am EST/6am PST

2022-12-18 Thread Nathan Southern
Good evening, This is a reminder that tomorrow, Wed. Dec. 14th, at 9am EST/6am PST, we will hold our DPDK DTS Working Group. Zoom information to follow. Hope to see you there Thanks, Nathan Nathan C. Southern, Project Coordinator Data Plane Development Kit The Linux Foundation 248.835.4812

[PATCH v1 1/2] mailmap: add contributor to list

2022-12-18 Thread Mohammad Iqbal Ahmad
Add contributer to mailmap. Signed-off-by: Mohammad Iqbal Ahmad --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index 75884b6fe2..464164765f 100644 --- a/.mailmap +++ b/.mailmap @@ -911,6 +911,7 @@ Mitch Williams Mit Matelske Mohamad Noor Alim Hussin Mo

[PATCH v1 2/2] app/test-flow-perf: fix division or module by zero

2022-12-18 Thread Mohammad Iqbal Ahmad
Fix division or module by zero reported by coverity scan. Coverity issue: 373870 Fixes: bf3688f1e816 ("app/flow-perf: add insertion rate calculation") Signed-off-by: Mohammad Iqbal Ahmad --- app/test-flow-perf/main.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/

RE: [PATCH] net/mlx5: fix available tag registers calculation for HWS

2022-12-18 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Dariusz Sosnowski > Sent: Tuesday, November 22, 2022 2:53 PM > To: Matan Azrad ; Slava Ovsiienko > ; Bing Zhao > Cc: dev@dpdk.org; Raslan Darawsheh ; Ori Kam > > Subject: [PATCH] net/mlx5: fix available tag registers calculation for HWS > > Before this

RE: [PATCH] net/mlx5: fix GENEVE resource overwritten

2022-12-18 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Wednesday, November 23, 2022 1:57 PM > To: Matan Azrad ; Slava Ovsiienko > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH] net/mlx5: fix GENEVE resource overwritten > > Currently, one rte_flow may be split to multiple sub ml

Re: [PATCH kmods] linux/igb_uio: fix build on Linux 5.18+

2022-12-18 Thread Ferruh Yigit
On 12/16/2022 5:18 PM, luca.bocca...@gmail.com wrote: > From: Luca Boccassi > > Reported-by: Paolo Pisati > Signed-off-by: Luca Boccassi > --- > Only build-tested. > > linux/igb_uio/igb_uio.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/linux/igb_uio/igb_uio.c b/linux/igb

Re: [PATCH dpdk-kmod] linux/igb_uio: fix build with kernel 5.18

2022-12-18 Thread Ferruh Yigit
On 12/16/2022 5:33 PM, Stephen Hemminger wrote: > On Fri, 16 Dec 2022 11:57:32 + > Ferruh Yigit wrote: > >> In Linux kernel v5.18, "pci-dma-compat.h" wrapper file is removed [1]. >> >> Some APIs in that wrapper file were used by igb_uio kernel module and >> kernel module build fails after men

RE: [PATCH v2 3/4] eventdev/crypto: change eventdev reconfig logic

2022-12-18 Thread Gujjar, Abhinandan S
> -Original Message- > From: Naga Harish K, S V > Sent: Wednesday, December 14, 2022 12:35 PM > To: jer...@marvell.com; Carrillo, Erik G ; Gujjar, > Abhinandan S > Cc: dev@dpdk.org; Jayatheerthan, Jay > Subject: [PATCH v2 3/4] eventdev/crypto: change eventdev reconfig logic > > When

[PATCH v3 1/4] eventdev/eth_rx: change eventdev reconfig logic

2022-12-18 Thread Naga Harish K S V
When rte_event_eth_rx_adapter_create() or rte_event_eth_rx_adapter_create_with_params() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_conf

[PATCH v3 2/4] eventdev/eth_tx: change eventdev reconfig logic

2022-12-18 Thread Naga Harish K S V
When rte_event_eth_tx_adapter_create() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter

[PATCH v3 3/4] eventdev/crypto: change eventdev reconfig logic

2022-12-18 Thread Naga Harish K S V
When rte_event_crypto_adapter_create() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter

[PATCH v3 4/4] eventdev/timer: change eventdev reconfig logic

2022-12-18 Thread Naga Harish K S V
When rte_event_timer_adapter_create() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter i

RE: [PATCH v2 3/4] eventdev/crypto: change eventdev reconfig logic

2022-12-18 Thread Naga Harish K, S V
> -Original Message- > From: Gujjar, Abhinandan S > Sent: Monday, December 19, 2022 9:21 AM > To: Naga Harish K, S V ; jer...@marvell.com; > Carrillo, Erik G > Cc: dev@dpdk.org; Jayatheerthan, Jay > Subject: RE: [PATCH v2 3/4] eventdev/crypto: change eventdev reconfig logic > > > >

RE: [PATCH v3 1/4] eventdev/eth_rx: change eventdev reconfig logic

2022-12-18 Thread Gujjar, Abhinandan S
Acked-by: Abhinandan Gujjar > -Original Message- > From: Naga Harish K, S V > Sent: Monday, December 19, 2022 11:03 AM > To: jer...@marvell.com; Carrillo, Erik G ; Gujjar, > Abhinandan S > Cc: dev@dpdk.org; Jayatheerthan, Jay > Subject: [PATCH v3 1/4] eventdev/eth_rx: change eventdev r

RE: [PATCH v3 2/4] eventdev/eth_tx: change eventdev reconfig logic

2022-12-18 Thread Gujjar, Abhinandan S
Acked-by: Abhinandan Gujjar > -Original Message- > From: Naga Harish K, S V > Sent: Monday, December 19, 2022 11:03 AM > To: jer...@marvell.com; Carrillo, Erik G ; Gujjar, > Abhinandan S > Cc: dev@dpdk.org; Jayatheerthan, Jay > Subject: [PATCH v3 2/4] eventdev/eth_tx: change eventdev r

RE: [PATCH v3 3/4] eventdev/crypto: change eventdev reconfig logic

2022-12-18 Thread Gujjar, Abhinandan S
Acked-by: Abhinandan Gujjar > -Original Message- > From: Naga Harish K, S V > Sent: Monday, December 19, 2022 11:03 AM > To: jer...@marvell.com; Carrillo, Erik G ; Gujjar, > Abhinandan S > Cc: dev@dpdk.org; Jayatheerthan, Jay > Subject: [PATCH v3 3/4] eventdev/crypto: change eventdev r

RE: [PATCH v3 4/4] eventdev/timer: change eventdev reconfig logic

2022-12-18 Thread Gujjar, Abhinandan S
> -Original Message- > From: Naga Harish K, S V > Sent: Monday, December 19, 2022 11:03 AM > To: jer...@marvell.com; Carrillo, Erik G ; Gujjar, > Abhinandan S > Cc: dev@dpdk.org; Jayatheerthan, Jay > Subject: [PATCH v3 4/4] eventdev/timer: change eventdev reconfig logic > > When rte_

[PATCH v4] eventdev/timer: change eventdev reconfig logic

2022-12-18 Thread Naga Harish K S V
When rte_event_timer_adapter_create() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter i

[PATCH v4 1/4] eventdev/eth_rx: change eventdev reconfig logic

2022-12-18 Thread Naga Harish K S V
When rte_event_eth_rx_adapter_create() or rte_event_eth_rx_adapter_create_with_params() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_conf

[PATCH v4 2/4] eventdev/eth_tx: change eventdev reconfig logic

2022-12-18 Thread Naga Harish K S V
When rte_event_eth_tx_adapter_create() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter

[PATCH v4 4/4] eventdev/timer: change eventdev reconfig logic

2022-12-18 Thread Naga Harish K S V
When rte_event_timer_adapter_create() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter i

[PATCH v4 3/4] eventdev/crypto: change eventdev reconfig logic

2022-12-18 Thread Naga Harish K S V
When rte_event_crypto_adapter_create() is used for creating adapter instance, eventdev is reconfigured with additional ``rte_event_dev_config::nb_event_ports`` parameter. This eventdev reconfig logic is enhanced to increment the ``rte_event_dev_config::nb_single_link_event_port_queues`` parameter

Re: [PATCH V7 7/8] test: add test cases for adding hex integer value API

2022-12-18 Thread lihuisong (C)
在 2022/12/16 17:31, Bruce Richardson 写道: On Fri, Dec 16, 2022 at 09:54:27AM +0800, Huisong Li wrote: Add test cases for adding hexadecimal unsigned integer value API. Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen Feng --- The coding style is still a little off for i

[PATCH V8 0/8] telemetry: fix data truncation and conversion error and add hex integer API

2022-12-18 Thread Huisong Li
Some lib telemetry interfaces add the 'u32' and 'u64' data by the rte_tel_data_add_dict/array_int API. This may cause data conversion error or data truncation. This patch series uses 'u64' functions to do this. In addition, this patch series introduces two APIs to store unsigned integer values as

[PATCH V8 2/8] ethdev: fix possible data truncation and conversion error

2022-12-18 Thread Huisong Li
The 'u32' and 'u64' data can not assigned to 'int' type variable. They need to use the 'u64' APIs to add. Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen Feng --- lib/ethdev/rte_eth

[PATCH V8 3/8] mempool: fix possible data truncation and conversion error

2022-12-18 Thread Huisong Li
The 'u32' and 'u64' data can not assigned to 'int' type variable. They need to use the 'u64' APIs to add. Fixes: 2f5c4025abb3 ("mempool: add telemetry endpoint") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen Feng --- lib/mempool/rte_mempool.c | 24 ++

[PATCH V8 4/8] cryptodev: fix possible data conversion error

2022-12-18 Thread Huisong Li
The 'u32' data can not assigned to 'int' type variable. The 'u32' data needs to use the 'u64' APIs to add. Fixes: d3d98f5ce9d0 ("cryptodev: support telemetry") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen Feng --- lib/cryptodev/rte_cryptodev.c | 2 +

[PATCH V8 5/8] mem: possible data truncation and conversion error

2022-12-18 Thread Huisong Li
The 'u32' and 'u64' data can not assigned to 'int' type variable. They need to use the 'u64' APIs to add. Fixes: e6732d0d6e26 ("mem: add telemetry infos") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen Feng --- lib/eal/common/eal_common_memory.c | 10

[PATCH V8 1/8] telemetry: move to header to controllable range

2022-12-18 Thread Huisong Li
The "stdint.h" header is outside '_RTE_TELEMETRY_H_' macro, which cause this header is unconditional. So this patch moves this header to inside '_RTE_TELEMETRY_H_'. Fixes: 99a2dd955fba ("lib: remove librte_ prefix from directory names") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Mor

[PATCH V8 7/8] test: add test cases for adding hex integer value API

2022-12-18 Thread Huisong Li
Add test cases for adding hexadecimal unsigned integer value API. Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen Feng Acked-by: Bruce Richardson --- app/test/test_telemetry_data.c | 150 + 1 file changed, 150 insertions(+) diff --git a/ap

[PATCH V8 6/8] telemetry: support adding integer value as hexadecimal

2022-12-18 Thread Huisong Li
Sometimes displaying a unsigned integer value as hexadecimal encoded style is more expected for human consumption, such as, offload capability and device flag. This patch introduces two APIs to add unsigned integer value as hexadecimal encoded string to array or dictionary. And user can choose whet

[PATCH V8 8/8] ethdev: display capability values in hexadecimal format

2022-12-18 Thread Huisong Li
The 'dev_flags', 'rx_offloads', 'tx_offloads' and 'rss_hf' are better displayed in hexadecimal format. Like: -->old display by input /ethdev/info,0 "dev_flags": 3, "rx_offloads": 524288, "tx_offloads": 65536, "ethdev_rss_hf": 9100 --> now display "dev_flags": "0x3",