[PATCH 1/2] net/bonding: fix bond3 and bond4 process mbuf fast free

2022-11-08 Thread Huisong Li
The RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE offload can't be used in bonding mode Broadcast and mode 8023AD. Currently, bonding driver forcibly removes from the dev->data->dev_conf.txmode.offloads and processes as success in bond_ethdev_configure(). But this still cause that rte_eth_dev_configure() fails

[PATCH 2/2] app/testpmd: remove fast free offload for bond3 and bond4

2022-11-08 Thread Huisong Li
The port configurations of bonding device need to be updated when add a slave device. But mbuf fast free offload can't be used in bonding mode Broadcast and mode 8023AD. So remove this offload for both mode in case of failing to initialize bonding device. Fixes: 76376bd9cd49 ("app/testpmd: update

[PATCH 0/2] net/bonding: fix mbuf fast free for bond3 and bond4

2022-11-08 Thread Huisong Li
This patchset fixes mbuf fast free offload for bond3 and bond4. Huisong Li (2): net/bonding: fix bond3 and bond4 process mbuf fast free app/testpmd: remove fast free offload for bond3 and bond4 app/test-pmd/testpmd.c | 8 drivers/net/bonding/rte_eth_bond_pmd.c | 6 ++

RE: [PATCH] maintainers: group service cores files

2022-11-08 Thread Van Haaren, Harry
> -Original Message- > From: Thomas Monjalon > Sent: Monday, November 7, 2022 5:20 PM > To: dev@dpdk.org > Cc: Van Haaren, Harry > Subject: [PATCH] maintainers: group service cores files > > Move example with library files, all with the same maintainer. > > Signed-off-by: Thomas Monjalo

[PATCH v1] net/mlx5: fix representor item and meter

2022-11-08 Thread Shun Hao
When creating flow matching port representor item with meter action, it will fail due to incorrect parsing the item. This patch fixes this issue by adding the correct item parse for port representor in validation. Fixes: 707d5e7d79 ("net/mlx5: support flow matching on representor ID") Cc: sta...@

Re: [PATCH v12 04/16] baseband/acc: introduce PMD for ACC200

2022-11-08 Thread Thomas Monjalon
08/11/2022 00:52, Chautru, Nicolas: > Hi Thomas, > Reminder : do you mind kindly clarifying/confirming below. Then we can update > the docs accordingly. Thanks. > > From: Chautru, Nicolas > > From: Thomas Monjalon > > > 31/10/2022 16:43, Chautru, Nicolas: > > > > From: Thomas Monjalon > > > >

RE: [PATCH] net/mlx5/hws: fix possible negative return on sq create

2022-11-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alex Vesker > Sent: Thursday, November 3, 2022 2:52 PM > To: Alex Vesker ; Slava Ovsiienko > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Suanming Mou ; > Matan Azrad > Cc: dev@dpdk.org; Ori Kam > Subject: [PATCH] net/mlx5/hws: fix possible negative retu

RE: [PATCH v2] net/mlx5/hws: fix possible action setter segmenation fault

2022-11-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alex Vesker > Sent: Monday, November 7, 2022 12:18 PM > To: Alex Vesker ; Slava Ovsiienko > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Suanming Mou ; > Matan Azrad > Cc: dev@dpdk.org; Ori Kam > Subject: [PATCH v2] net/mlx5/hws: fix possible action sett

RE: [PATCH v2] net/mlx5/hws: fix action creation check for HWS support

2022-11-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alex Vesker > Sent: Monday, November 7, 2022 1:04 PM > To: Alex Vesker ; Slava Ovsiienko > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Suanming Mou ; > Matan Azrad > Cc: dev@dpdk.org; Ori Kam > Subject: [PATCH v2] net/mlx5/hws: fix action creation check

RE: [PATCH v2] net/mlx5/hws: fix capability check to allow HWS on non esw-mngr

2022-11-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alex Vesker > Sent: Monday, November 7, 2022 1:07 PM > To: Alex Vesker ; Slava Ovsiienko > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Suanming Mou ; > Matan Azrad > Cc: dev@dpdk.org; Ori Kam > Subject: [PATCH v2] net/mlx5/hws: fix capability check to a

RE: [PATCH] net/mlx5: fix hairpin split with set VLAN VID action

2022-11-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Dariusz Sosnowski > Sent: Monday, November 7, 2022 12:29 PM > To: Matan Azrad ; Slava Ovsiienko > > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix hairpin split with set VLAN VID action > > Before this patch any f

Re: [PATCH v3] ethdev: add hint when creating async transfer table

2022-11-08 Thread Thomas Monjalon
06/11/2022 11:02, Andrew Rybchenko: > On 10/4/22 11:31, Andrew Rybchenko wrote: > > On 9/28/22 12:24, Rongwei Liu wrote: > >> The transfer domain rule is able to match traffic wire/vf > >> origin and it means two directions' underlayer resource. > >> > >> In customer deployments, they usually match

RE: [PATCH v4 3/3] mempool: use cache for frequently updated stats

2022-11-08 Thread Konstantin Ananyev
> When built with stats enabled (RTE_LIBRTE_MEMPOOL_STATS defined), the > performance of mempools with caches is improved as follows. > > When accessing objects in the mempool, either the put_bulk and put_objs or > the get_success_bulk and get_success_objs statistics counters are likely > to be i

RE: [PATCH v3] net/iavf: revert fix VLAN insertion

2022-11-08 Thread Zhou, YidingX
Hi > -Original Message- > From: Zhou, YidingX > Sent: Friday, November 4, 2022 2:10 PM > To: dev@dpdk.org > Cc: ktray...@redhat.com; Yang, Qiming ; Zhou, > YidingX > Subject: [PATCH v3] net/iavf: revert fix VLAN insertion > > The vector Tx path does not support VLAN insertion via the L

[PATCH] app/testpmd: flush flow templates when port is removed

2022-11-08 Thread Dariusz Sosnowski
From: Suanming Mou This patch adds explicit flushing of template tables, pattern and actions templates, when a port is closed or detached. Signed-off-by: Suanming Mou --- app/test-pmd/config.c | 111 + app/test-pmd/testpmd.c | 3 ++ app/test-pmd/testp

Re: [PATCH v3] ethdev: add hint when creating async transfer table

2022-11-08 Thread Andrew Rybchenko
On 11/8/22 12:19, Thomas Monjalon wrote: 06/11/2022 11:02, Andrew Rybchenko: On 10/4/22 11:31, Andrew Rybchenko wrote: On 9/28/22 12:24, Rongwei Liu wrote: The transfer domain rule is able to match traffic wire/vf origin and it means two directions' underlayer resource. In customer deployment

[PATCH v1 0/2] Fix src port match in meter hierarchy

2022-11-08 Thread Shun Hao
In meter hierarchy, if policy flow contains modify_field or port_id action, a src port matching will be added to determine the position of meter in action list. Currently the src port is static, using the port id policy belongs to. This patch set enables creation of multiple policy flows using src

[PATCH v1 1/2] net/mlx5: fix meter hierarchy with modify header

2022-11-08 Thread Shun Hao
If any meter in the hierarchy has a policy flow containing set_tag or modify_field action, the policy flow must match the src port to which the policy belongs, to determine the order of modify_hdr and meter action. But the meter hierarchy will not be able to use by user flow that matches another sr

[PATCH v1 2/2] net/mlx5: fix meter policy with port ID destination

2022-11-08 Thread Shun Hao
When a meter policy contains a fate action of port_id, the policy flow must match the src port to which the policy belongs. However, this meter cannot be used by a flow that matches another src port. This patch fixes this by adding a new policy flow matching the new src port from the user flow dyn

Re: [PATCH v3] ethdev: add hint when creating async transfer table

2022-11-08 Thread Thomas Monjalon
08/11/2022 10:35, Andrew Rybchenko: > On 11/8/22 12:19, Thomas Monjalon wrote: > > 06/11/2022 11:02, Andrew Rybchenko: > >> On 10/4/22 11:31, Andrew Rybchenko wrote: > >>> On 9/28/22 12:24, Rongwei Liu wrote: > The transfer domain rule is able to match traffic wire/vf > origin and it mean

RE: [PATCH v4 3/3] mempool: use cache for frequently updated stats

2022-11-08 Thread Morten Brørup
> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Tuesday, 8 November 2022 10.20 > > > When built with stats enabled (RTE_LIBRTE_MEMPOOL_STATS defined), the > > performance of mempools with caches is improved as follows. > > > > When accessing objects in the mempool, either

FW: [PATCH v4 3/3] mempool: use cache for frequently updated stats

2022-11-08 Thread Morten Brørup
From: Morten Brørup Sent: Tuesday, 8 November 2022 12.22 > From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Tuesday, 8 November 2022 10.20 > > > When built with stats enabled (RTE_LIBRTE_MEMPOOL_STATS defined), the > > performance of mempools with caches is improved as fol

Re: [PATCH v4] ethdev: add special flags when creating async transfer table

2022-11-08 Thread Andrew Rybchenko
On 11/4/22 13:44, Rongwei Liu wrote: The transfer domain rule is able to match traffic wire/vport origin which are corresponding to two kinds of underlayer resources. Wire means traffic arrives from the uplink port while vport means traffic initiated from VF/SF. In customer deployments, they us

Re: [PATCH v4] ethdev: add special flags when creating async transfer table

2022-11-08 Thread Andrew Rybchenko
On 11/8/22 14:39, Andrew Rybchenko wrote: On 11/4/22 13:44, Rongwei Liu wrote: diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index 8858b56428..1eab12796f 100644 --- a/lib/ethdev/rte_flow.h +++ b/lib/ethdev/rte_flow.h @@ -5186,6 +5186,34 @@ rte_flow_actions_template_destroy(uint16_t

Re: [PATCH v3] ethdev: add hint when creating async transfer table

2022-11-08 Thread Andrew Rybchenko
On 11/8/22 14:18, Thomas Monjalon wrote: 08/11/2022 10:35, Andrew Rybchenko: On 11/8/22 12:19, Thomas Monjalon wrote: 06/11/2022 11:02, Andrew Rybchenko: On 10/4/22 11:31, Andrew Rybchenko wrote: On 9/28/22 12:24, Rongwei Liu wrote: The transfer domain rule is able to match traffic wire/vf o

Re: [PATCH 1/2] common/mlx5: update log format after devx_general_cmd error

2022-11-08 Thread David Marchand
On Wed, Jun 8, 2022 at 1:58 PM Gregory Etelson wrote: > > Application can fetch syndrome value after FW operation failure > starting from Mellanox OFED-5.6. > The patch updates log data issued after devx_general_cmd error. > > Signed-off-by: Gregory Etelson > Acked-by: Matan Azrad > --- > drive

testpmd logging

2022-11-08 Thread Thomas Monjalon
Hello, I see testpmd is doing log with EAL entity. Example: RTE_LOG(ERR, EAL, "The device: %s has been added!\n" We could also discuss the log level. Please can we work on replacing these logs? We need to choose how to log (printf or registered log entity) and be consistent. What do you t

Re: [PATCH v4] ethdev: add special flags when creating async transfer table

2022-11-08 Thread Thomas Monjalon
08/11/2022 12:47, Andrew Rybchenko: > On 11/8/22 14:39, Andrew Rybchenko wrote: > > On 11/4/22 13:44, Rongwei Liu wrote: > >> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h > >> index 8858b56428..1eab12796f 100644 > >> --- a/lib/ethdev/rte_flow.h > >> +++ b/lib/ethdev/rte_flow.h > >> @@

Re: FW: [PATCH v4 3/3] mempool: use cache for frequently updated stats

2022-11-08 Thread Thomas Monjalon
08/11/2022 12:25, Morten Brørup: > From: Morten Brørup > Sent: Tuesday, 8 November 2022 12.22 > > > From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > > Sent: Tuesday, 8 November 2022 10.20 > > > > > When built with stats enabled (RTE_LIBRTE_MEMPOOL_STATS defined), the > > > perfo

Re: [PATCH v1 1/1] baseband/acc100: fix to input error related to padding

2022-11-08 Thread Maxime Coquelin
On 11/8/22 00:45, Nicolas Chautru wrote: Previous commit includes some padding for some cases, which may cause input warning from the HW which should be safely ignored to avoid false alarm. Fixes: 6f3325bbfa ("baseband/acc100: add LDPC encoder padding function") Signed-off-by: Nicolas Chautr

[PATCH] net/mlx5: fix the first segment inline length

2022-11-08 Thread Alexander Kozyrev
Packets can be split into several mbufs with various data sizes. There is no limitation on how small these segments can be. But there is a limitation on Tx side for inline configuration: send WQEs with inline headers less than the required are dropped. The very first segment must be more than minim

Re: [PATCH v4] vdpa/ifc: fix update_datapath error handling

2022-11-08 Thread Maxime Coquelin
Hi Taekyung, On 11/8/22 09:56, Taekyung Kim wrote: Stop and return the error code when update_datapath fails. update_datapath prepares resources for the vdpa device. The driver should not perform any further actions if update_datapath returns an error. Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf

RE: [PATCH v3] app/testpmd: fix protocol header display for Rx buffer split

2022-11-08 Thread Wang, YuanX
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Monday, November 7, 2022 7:31 PM > To: Wang, YuanX ; Singh, Aman Deep > ; Zhang, Yuying > Cc: Ding, Xuan ; Tang, Yaqi ; > dev@dpdk.org > Subject: Re: [PATCH v3] app/testpmd: fix protocol header display for Rx > buffer split

Re: [PATCH] maintainers: update for pmdinfo tool

2022-11-08 Thread David Marchand
On Mon, Nov 7, 2022 at 6:14 PM Thomas Monjalon wrote: > > The original maintainer of pmdinfo/pmdinfogen > did not send an email for 2 years. > > Signed-off-by: Thomas Monjalon Acked-by: David Marchand -- David Marchand

RE: FW: [PATCH v4 3/3] mempool: use cache for frequently updated stats

2022-11-08 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, 8 November 2022 14.32 > > 08/11/2022 12:25, Morten Brørup: > > From: Morten Brørup > > Sent: Tuesday, 8 November 2022 12.22 > > > > > From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > > > Sent: Tuesday, 8 Novembe

RE: testpmd logging

2022-11-08 Thread Honnappa Nagarahalli
+ Lijuan, Owen, Juraj > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, November 8, 2022 7:02 AM > To: Aman Singh ; Yuying Zhang > > Cc: david.march...@redhat.com; dev@dpdk.org > Subject: testpmd logging > > Hello, > > I see testpmd is doing log with EAL entity. Example: >

Re: [PATCH v4] ethdev: add special flags when creating async transfer table

2022-11-08 Thread Andrew Rybchenko
On 11/8/22 16:29, Thomas Monjalon wrote: 08/11/2022 12:47, Andrew Rybchenko: On 11/8/22 14:39, Andrew Rybchenko wrote: On 11/4/22 13:44, Rongwei Liu wrote: diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index 8858b56428..1eab12796f 100644 --- a/lib/ethdev/rte_flow.h +++ b/lib/ethde

Re: [PATCH v4] ethdev: add special flags when creating async transfer table

2022-11-08 Thread Thomas Monjalon
08/11/2022 15:38, Andrew Rybchenko: > On 11/8/22 16:29, Thomas Monjalon wrote: > > 08/11/2022 12:47, Andrew Rybchenko: > >> On 11/8/22 14:39, Andrew Rybchenko wrote: > >>> On 11/4/22 13:44, Rongwei Liu wrote: > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h > index 8858b56428.

Re: FW: [PATCH v4 3/3] mempool: use cache for frequently updated stats

2022-11-08 Thread Thomas Monjalon
08/11/2022 15:30, Morten Brørup: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 08/11/2022 12:25, Morten Brørup: > > > From: Morten Brørup > > > > From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > > > > Sent: Tuesday, 8 November 2022 10.20 > > > > > +#ifdef RTE_LIBRTE_ME

Re: FW: [PATCH v4 3/3] mempool: use cache for frequently updated stats

2022-11-08 Thread Bruce Richardson
On Tue, Nov 08, 2022 at 04:51:11PM +0100, Thomas Monjalon wrote: > 08/11/2022 15:30, Morten Brørup: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > 08/11/2022 12:25, Morten Brørup: > > > > From: Morten Brørup > > > > > From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] >

RE: [PATCH 1/2] common/mlx5: update log format after devx_general_cmd error

2022-11-08 Thread Gregory Etelson
Hello David, > > + if (rc || MLX5_FW_STATUS(out)) { > > + mlx5_devx_err_log(out, "read access", "NIC register", > > reg_id); > > + return MLX5_DEVX_ERR_RC(rc); > > I went back in the mailing list archive to find this change. > This patch makes the pmd spat some

[PATCH] maintainers: update for crypto and compressdev

2022-11-08 Thread Fan Zhang
Update email address. Signed-off-by: Fan Zhang --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1c9922123e..536e82fd4d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -441,7 +441,7 @@ F: doc/guides/sample_app_ug/bbdev_app.rst

Re: testpmd logging

2022-11-08 Thread Owen Hilyard
On Tue, Nov 8, 2022 at 9:37 AM Honnappa Nagarahalli < honnappa.nagaraha...@arm.com> wrote: > + Lijuan, Owen, Juraj > > > -Original Message- > > From: Thomas Monjalon > > Sent: Tuesday, November 8, 2022 7:02 AM > > To: Aman Singh ; Yuying Zhang > > > > Cc: david.march...@redhat.com; dev@d

Re: testpmd logging

2022-11-08 Thread Stephen Hemminger
On Tue, 8 Nov 2022 11:24:53 -0500 Owen Hilyard wrote: > On Tue, Nov 8, 2022 at 9:37 AM Honnappa Nagarahalli < > honnappa.nagaraha...@arm.com> wrote: > > > + Lijuan, Owen, Juraj > > > > > -Original Message- > > > From: Thomas Monjalon > > > Sent: Tuesday, November 8, 2022 7:02 AM > >

RE: [PATCH v1 0/2] Fix src port match in meter hierarchy

2022-11-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Shun Hao > Sent: Tuesday, November 8, 2022 12:04 PM > To: Slava Ovsiienko ; Matan Azrad > ; Ori Kam > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v1 0/2] Fix src port match in meter hierarchy > > In meter hierarchy, if policy flow contains modif

RE: [PATCH v1] net/mlx5: fix representor item and meter

2022-11-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Shun Hao > Sent: Tuesday, November 8, 2022 10:51 AM > To: Slava Ovsiienko ; Matan Azrad > ; Ori Kam ; Sean Zhang > (Networking SW) > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: [PATCH v1] net/mlx5: fix representor item and meter > S

RE: FW: [PATCH v4 3/3] mempool: use cache for frequently updated stats

2022-11-08 Thread Konstantin Ananyev
> > On Tue, Nov 08, 2022 at 04:51:11PM +0100, Thomas Monjalon wrote: > > 08/11/2022 15:30, Morten Brørup: > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > 08/11/2022 12:25, Morten Brørup: > > > > > From: Morten Brørup > > > > > > From: Konstantin Ananyev [mailto:konstantin.anan

RE: [PATCH v1 1/1] baseband/acc: fix check after deref and dead code

2022-11-08 Thread Chautru, Nicolas
Hi Maxime, Akhil, This patch is not applied yet. Any concern to apply this as is? Maxime, unclear whether you recommend a change for this in the context of the coverify fix. Please kindly clarify. Do you want to keep the q == null in the PMD? Thanks Nic > -Original Message- > From: Cha

Re: [PATCH 2/2] app/testpmd: remove fast free offload for bond3 and bond4

2022-11-08 Thread Stephen Hemminger
On Tue, 8 Nov 2022 16:40:38 +0800 Huisong Li wrote: > The port configurations of bonding device need to be updated when add a > slave device. But mbuf fast free offload can't be used in bonding mode > Broadcast and mode 8023AD. So remove this offload for both mode in case > of failing to initiali

[PATCH v2] testpmd: make f_quit flag volatile

2022-11-08 Thread Stephen Hemminger
Since f_quit is set in a signal handler it needs to be marked volatile. Otherwise, compiler is allowed to optimize the loop because it can assume the value never changes. The flag can also be made local to the file it is used in. Fixes: d9a191a00e81 ("app/testpmd: fix quitting in container") Sign

Re: [RFC 2/2] testpmd: cleanup cleanly from signal

2022-11-08 Thread Stephen Hemminger
On Sun, 6 Nov 2022 13:50:36 +0300 Andrew Rybchenko wrote: > On 10/14/22 20:23, Stephen Hemminger wrote: > > The original behavior of testpmd was to kill itself when > > it received a SIGINT or SIGTERM. This makes it hard to use > > testpmd in test automation where forwarding loop is started > > a

[PATCH v2] testpmd: cleanup cleanly from signal

2022-11-08 Thread Stephen Hemminger
Do clean shutdown of testpmd when a signal is received. Instead of having testpmd commit suicide when a signal is received, do a clean shutdown. This fixes problem where a signal could be received in the middle of a PMD and then the signal handler would call PMD's close routine which could cause a

[PATCH] net/mlx5/hws: fix timestamp format on Tx queue creation

2022-11-08 Thread Viacheslav Ovsiienko
The NIC since 6DX supports multiple timestamp formats in CQEs configured via firmware. If real time timestamp format has been configured the correct attributes should be specified on queue creation via DevX. These attributes setting was missed on steering queue creation and hardware steering initia

RE: [PATCH] net/mlx5: fix the first segment inline length

2022-11-08 Thread Slava Ovsiienko
> -Original Message- > From: Alexander Kozyrev > Sent: Tuesday, November 8, 2022 15:45 > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava Ovsiienko > ; Matan Azrad ; Michael Baum > > Subject: [PATCH] net/mlx5: fix the first segment inline length > > Packets can be split i

[PATCH v3] testpmd: cleanup cleanly from signal

2022-11-08 Thread Stephen Hemminger
Do clean shutdown of testpmd when a signal is received. Instead of having testpmd commit suicide when a signal is received, do a clean shutdown. This fixes problem where a signal could be received in the middle of a PMD and then the signal handler would call PMD's close routine which could cause a

[PATCH v1 0/1] doc: simplify PMD steps

2022-11-08 Thread Nicolas Chautru
Documentation update suggested by Thomas to point towards the common kernel modules steps. Nicolas Chautru (1): doc: simplify the binding steps doc/guides/bbdevs/acc100.rst | 90 +++--- doc/guides/bbdevs/acc200.rst | 92 +++ doc/guides/bbdevs/fpga_5gnr

[PATCH v1 1/1] doc: simplify the binding steps

2022-11-08 Thread Nicolas Chautru
The steps for binding to kernel modules which are generic are now only implicit and pointing towards common documentation. Minor change to the kernel documentation so that not to be too NIC centric. Signed-off-by: Nicolas Chautru --- doc/guides/bbdevs/acc100.rst | 90 +++--- d

RE: [PATCH v12 04/16] baseband/acc: introduce PMD for ACC200

2022-11-08 Thread Chautru, Nicolas
Hi Thomas, > -Original Message- > From: Thomas Monjalon > 08/11/2022 00:52, Chautru, Nicolas: > > Hi Thomas, > > Reminder : do you mind kindly clarifying/confirming below. Then we can > update the docs accordingly. Thanks. > > > > From: Chautru, Nicolas > > > From: Thomas Monjalon > > >

RE: [PATCH] net/ice/base: fix duplicate flow rules

2022-11-08 Thread Zhang, Qi Z
> -Original Message- > From: Xu, Ke1 > Sent: Wednesday, October 19, 2022 8:20 PM > To: Zhou, YidingX ; dev@dpdk.org > Cc: Zhou, YidingX ; sta...@dpdk.org > Subject: RE: [PATCH] net/ice/base: fix duplicate flow rules > > > > -Original Message- > > From: Yiding Zhou > > Sent: T

RE: [PATCH v3] net/iavf: revert fix VLAN insertion

2022-11-08 Thread Zhang, Qi Z
> -Original Message- > From: Yiding Zhou > Sent: Friday, November 4, 2022 2:10 PM > To: dev@dpdk.org > Cc: ktray...@redhat.com; Yang, Qiming ; Zhou, > YidingX > Subject: [PATCH v3] net/iavf: revert fix VLAN insertion > > The vector Tx path does not support VLAN insertion via the L2TAG

Re: [PATCH 2/2] app/testpmd: remove fast free offload for bond3 and bond4

2022-11-08 Thread lihuisong (C)
在 2022/11/9 2:01, Stephen Hemminger 写道: On Tue, 8 Nov 2022 16:40:38 +0800 Huisong Li wrote: The port configurations of bonding device need to be updated when add a slave device. But mbuf fast free offload can't be used in bonding mode Broadcast and mode 8023AD. So remove this offload for bot

RE: [PATCH] net/iavf: fix vlan offload issue

2022-11-08 Thread Zhang, Qi Z
> -Original Message- > From: Wenzhuo Lu > Sent: Wednesday, November 2, 2022 8:29 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; sta...@dpdk.org > Subject: [PATCH] net/iavf: fix vlan offload issue > > HW VLAN offload cannot be enabled because the HW capability flags are not > set correctly.

RE: [PATCH] net/i40e: fix PCTYPE configuration for X722

2022-11-08 Thread Chen, LingliX
> -Original Message- > From: Mingjin Ye > Sent: Friday, November 4, 2022 12:57 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhou, YidingX ; Ye, MingjinX > ; Zhang, Yuying ; Xing, > Beilei ; Alvin Zhang ; Zhang, > Qi Z > Subject: [PATCH] net/i40e: fix PCTYPE configuration for X722 > > T

[PATCH v4] app/testpmd: fix protocol header display for Rx buffer split

2022-11-08 Thread Yuan Wang
The "show config rxhdrs" cmd displays the configured protocol headers that are used for protocol-based buffer split. However, it shows inner-ipv6 as inner-ipv4. This patch fixes that by redefining rx_pkt_hdr_protos to hold the full ptypes, and the show and set commands therefore remain symmetrical

[PATCH] net/mlx5: remove unneeded GENEVE option length assert

2022-11-08 Thread Suanming Mou
In order to share flow items translate code, flow items translation of spec and mask was split individually. In that case, the assert for GENEVE option length with mask becomes invalid, since the length in mask is bitmask. And as memcpy around the assert already checks the GENEVE option length, th

[PATCH] net/idpf: fix TSO issue

2022-11-08 Thread beilei . xing
From: Beilei Xing This patch fixes TSO by adding Tx checksum offload. Fixes: ed5b21acc67e ("net/idpf: support Tx offloading") Signed-off-by: Beilei Xing --- drivers/net/idpf/idpf_ethdev.c | 4 drivers/net/idpf/idpf_rxtx.c | 5 + drivers/net/idpf/idpf_rxtx.h | 10 +- 3 f

RE: [PATCH v5 1/2] net/ice: fix vlan offload

2022-11-08 Thread Huang, ZhiminX
> -Original Message- > From: Mingjin Ye > Sent: Tuesday, November 8, 2022 9:28 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; sta...@dpdk.org; Zhou, YidingX > ; Ye, MingjinX ; Richardson, > Bruce ; Konstantin Ananyev > ; Zhang, Qi Z ; Lu, > Wenzhuo ; Junyu Jiang ; > Rong, Leyi ; Ajit Khaparde

RE: [PATCH v5 2/2] net/ice: fix vlan offload of rxq

2022-11-08 Thread Huang, ZhiminX
> -Original Message- > From: Mingjin Ye > Sent: Tuesday, November 8, 2022 9:28 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; sta...@dpdk.org; Zhou, YidingX > ; Ye, MingjinX ; Zhang, Qi Z > ; Ferruh Yigit ; Wu, Jingjing > ; Li, Xiaoyun ; Lu, Wenzhuo > > Subject: [PATCH v5 2/2] net/ice: fix vl

[PATCH] doc: update matching list for i40e and ice driver

2022-11-08 Thread Qiming Yang
Add recommended matching list for ice PMD in DPDK 22.07 and i40e PMD in DPDK 22.07 and 21.11. Signed-off-by: Qiming Yang --- doc/guides/nics/i40e.rst | 8 doc/guides/nics/ice.rst | 2 ++ 2 files changed, 10 insertions(+) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst

[PATCH V2] net/bonding: fix bond3 and bond4 process mbuf fast free

2022-11-08 Thread Huisong Li
The RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE offload can't be used in bonding mode Broadcast and mode 8023AD. Currently, bonding driver forcibly removes from the dev->data->dev_conf.txmode.offloads and processes as success in bond_ethdev_configure(). But this still cause that rte_eth_dev_configure() fails

RE: [PATCH] net/i40e: fix PCTYPE configuration for X722

2022-11-08 Thread Zhang, Qi Z
> -Original Message- > From: Chen, LingliX > Sent: Wednesday, November 9, 2022 9:36 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhou, YidingX ; Ye, MingjinX > ; Zhang, Yuying ; Xing, > Beilei ; Alvin Zhang ; Zhang, > Qi Z > Subject: RE: [PATCH] net/i40e: fix PCTYPE configuration for X

RE: [PATCH v4] vdpa/ifc: fix update_datapath error handling

2022-11-08 Thread Pei, Andy
> -Original Message- > From: Taekyung Kim > Sent: Tuesday, November 8, 2022 4:56 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Pei, Andy ; > kim.tae.ky...@navercorp.com; maxime.coque...@redhat.com; > sta...@dpdk.org; Wang, Xiao W > Subject: [PATCH v4] vdpa/ifc: fix update_datapath error ha

Re: [PATCH V2] net/bonding: fix bond3 and bond4 process mbuf fast free

2022-11-08 Thread Stephen Hemminger
On Wed, 9 Nov 2022 10:22:37 +0800 Huisong Li wrote: > The RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE offload can't be used in bonding > mode Broadcast and mode 8023AD. Currently, bonding driver forcibly removes > from the dev->data->dev_conf.txmode.offloads and processes as success in > bond_ethdev_config

[PATCH v4] testpmd: cleanup cleanly from signal

2022-11-08 Thread Stephen Hemminger
Do a clean shutdown of testpmd when a signal is received; instead of having testpmd kill itself. This fixes problem where a signal could be received in the middle of a PMD and then the signal handler would call PMD's close routine which could cause a deadlock. Added benefit is it gets rid of Windo

RE: FW: [PATCH v4 3/3] mempool: use cache for frequently updated stats

2022-11-08 Thread Morten Brørup
> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Tuesday, 8 November 2022 18.38 > > > > On Tue, Nov 08, 2022 at 04:51:11PM +0100, Thomas Monjalon wrote: > > > 08/11/2022 15:30, Morten Brørup: > > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > > 08/11/2022

[PATCH v2] net/ice: fix scalar Rx and Tx path segment

2022-11-08 Thread Mingjin Ye
CRC is stripped by the hardware in the scattered Rx path. If the last buffer packet length is '0', the scalar Tx path would send empty buffer that causes the Tx queue to overflow. This patch adds a judgment for the last buffer length to fix this issue, so that it would free the mbuf associated to

[PATCH] kni: fix possible alloc_q starvation when mbufs are exhausted

2022-11-08 Thread Yangchao Zhou
In some scenarios, mbufs returned by rte_kni_rx_burst are not freed immediately. So kni_allocate_mbufs may be failed, but we don't know. Even worse, when alloc_q is completely exhausted, kni_net_tx in rte_kni.ko will drop all tx packets. kni_allocate_mbufs is never called again, even if the mbufs

[Bug 1122] i40e: Rx QinQ strip does not work

2022-11-08 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1122 Bug ID: 1122 Summary: i40e: Rx QinQ strip does not work Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Pr

[PATCH v1] common/idpf: fix tainted scalar

2022-11-08 Thread Mingxia Liu
From: mingxial Passing tainted expression "msg.data_len" to "rte_memcpy", which uses it as a loop boundary. Replace tainted expression with a temp variable to avoid the tainted scalar coverity warning. Coverity issue: 381688 Fixes: fb4ac04e9bfa ("common/idpf: introduce common library") Cc: sta.

[PATCH v2] kni: fix possible alloc_q starvation when mbufs are exhausted

2022-11-08 Thread Yangchao Zhou
In some scenarios, mbufs returned by rte_kni_rx_burst are not freed immediately. So kni_allocate_mbufs may be failed, but we don't know. Even worse, when alloc_q is completely exhausted, kni_net_tx in rte_kni.ko will drop all tx packets. kni_allocate_mbufs is never called again, even if the mbufs

[PATCH v1] common/idpf: fix possible null dereference

2022-11-08 Thread Mingxia Liu
From: mingxial Coverity is reporting FORWARD_NULL issue when msg.ctx.indirect.payload is NULL. Adding NULL check for this. Coverity issue: 381689 Fixes: fb4ac04e9bfa ("common/idpf: introduce common library") Cc: sta...@dpdk.org Signed-off-by: mingxial --- drivers/common/idpf/base/idpf_common.

[PATCH] net/idpf: fix memory leak

2022-11-08 Thread beilei . xing
From: Beilei Xing This patch fixes memory leak during Tx split queue release. Fixes: 19b58dba9dc3 ("net/idpf: support queue release") Signed-off-by: Beilei Xing --- drivers/net/idpf/idpf_rxtx.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/idpf/idpf_rxtx

RE: [PATCH] net/idpf: fix TSO issue

2022-11-08 Thread Peng, Yuan
Tested-by: Peng, Yuan > -Original Message- > From: Xing, Beilei > Sent: Wednesday, November 9, 2022 9:18 AM > To: Wu, Jingjing > Cc: dev@dpdk.org; Peng, Yuan ; Xing, Beilei > > Subject: [PATCH] net/idpf: fix TSO issue > > From: Beilei Xing > > This patch fixes TSO by adding Tx check

RE: [PATCH] net/idpf: fix memory leak

2022-11-08 Thread Peng, Yuan
Tested-by: Peng, Yuan > -Original Message- > From: Xing, Beilei > Sent: Wednesday, November 9, 2022 2:29 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Peng, Yuan ; Xing, Beilei > > Subject: [PATCH] net/idpf: fix memory leak > > From: Beilei Xing > > This patch fixes memory leak during T

RE: [PATCH] net/idpf: fix TSO issue

2022-11-08 Thread Zhang, Qi Z
> -Original Message- > From: Peng, Yuan > Sent: Wednesday, November 9, 2022 3:19 PM > To: Xing, Beilei ; Wu, Jingjing > Cc: dev@dpdk.org > Subject: RE: [PATCH] net/idpf: fix TSO issue > > Tested-by: Peng, Yuan > > > -Original Message- > > From: Xing, Beilei > > Sent: Wednes

RE: [PATCH] net/idpf: fix memory leak

2022-11-08 Thread Zhang, Qi Z
> -Original Message- > From: Peng, Yuan > Sent: Wednesday, November 9, 2022 3:19 PM > To: Xing, Beilei ; Wu, Jingjing > Cc: dev@dpdk.org > Subject: RE: [PATCH] net/idpf: fix memory leak > > Tested-by: Peng, Yuan > > > -Original Message- > > From: Xing, Beilei > > Sent: Wedn

[PATCH] maintainers: update for gve

2022-11-08 Thread Junfeng Guo
Add co-maintainers from Google team for gve (Google Virtual Ethernet). Signed-off-by: Junfeng Guo --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1c9922123e..d8c1d5272b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -698,6 +698,9 @@ F: doc/gu

RE: [PATCH] net/mlx5: remove unneeded GENEVE option length assert

2022-11-08 Thread Slava Ovsiienko
> -Original Message- > From: Suanming Mou > Sent: Wednesday, November 9, 2022 3:40 > To: Matan Azrad ; Slava Ovsiienko > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH] net/mlx5: remove unneeded GENEVE option length assert > > In order to share flow items translate code, flow item

RE: [PATCH v1] common/idpf: fix tainted scalar

2022-11-08 Thread Zhang, Qi Z
> -Original Message- > From: Mingxia Liu > Sent: Wednesday, November 9, 2022 1:02 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei > ; > Wang, Xiao W ; Guo, Junfeng > ; Liu, Mingxia ; > sta...@dpdk.org > Subject: [PATCH v1] common/idpf: fix tainted scalar > > From: mingxial >

RE: [PATCH v1] common/idpf: fix possible null dereference

2022-11-08 Thread Zhang, Qi Z
> -Original Message- > From: Mingxia Liu > Sent: Wednesday, November 9, 2022 1:17 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei > ; > Wang, Xiao W ; Guo, Junfeng > ; Liu, Mingxia ; > sta...@dpdk.org > Subject: [PATCH v1] common/idpf: fix possible null dereference > > From: m

[PATCH] net/mlx5: fix assert when creating meter policy

2022-11-08 Thread Shun Hao
When creating meter policy rules, it's possible to use flow items translation to add src port match criteria. Currently the items translation process needs to get thread workspace to store vport metadata tag, but in policy creation, the thread workspace was not initialized so it will cause assert f

[PATCH v2] net/mlx5/hws: fix timestamp format on Tx queue creation

2022-11-08 Thread Viacheslav Ovsiienko
The NIC since 6DX supports multiple timestamp formats in CQEs configured via firmware. If real time timestamp format has been configured the correct attributes should be specified on queue creation via DevX. These attributes setting was missed on steering queue creation and hardware steering initia