RE: [PATCH v8 08/12] vdpa/ifc: add internal API to get device

2022-10-19 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Tuesday, October 18, 2022 8:08 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coque...@redhat.com > Subject: [PATCH v8 08/12] vdpa/ifc: add internal API to get device > > Add new internal API "find_i

Re: crypto/uadk: introduce uadk crypto driver

2022-10-19 Thread Zhangfei Gao
On 2022/10/19 下午2:55, Thomas Monjalon wrote: 18/10/2022 12:52, Zhangfei Gao: On 2022/10/18 下午6:07, Zhangfei Gao wrote: Hi, Akhil On 2022/10/17 下午3:02, Akhil Goyal wrote: Hi everyone, We have a new crypto PMD submitted on ML (http://patches.dpdk.org/project/dpdk/cover/20221008083747.6559-

[PATCH v2 1/2] app/testpmd: fix vlan offload of rxq

2022-10-19 Thread Mingjin Ye
After setting vlan offload in testpmd, the result is not updated to rxq. Therefore, the queue needs to be reconfigured after executing the "vlan offload" related commands. Fixes: a47aa8b97afe ("app/testpmd: add vlan offload support") Cc: sta...@dpdk.org Signed-off-by: Mingjin Ye --- app/test-pm

[PATCH v2 2/2] net/ice: fix vlan offload

2022-10-19 Thread Mingjin Ye
The vlan tag and flag in Rx descriptor are not processed on vector path, then the upper application cann't fetch the tci from mbuf. This commit add handling of vlan RX offloading. Fixes: c68a52b8b38c ("net/ice: support vector SSE in Rx") Fixes: ece1f8a8f1c8 ("net/ice: switch to flexible descripto

[PATCH] telemetry: support boolean type

2022-10-19 Thread David Marchand
Add the boolean type RTE_TEL_BOOL_VAL for values in arrays and dicts. Signed-off-by: David Marchand --- app/test/test_telemetry_data.c | 88 +- lib/telemetry/rte_telemetry.h | 36 ++ lib/telemetry/telemetry.c | 24 +- lib/telemetry/teleme

Re: [PATCH] trace: take live traces via telemetry

2022-10-19 Thread David Marchand
Hello Morten, Bruce, On Tue, Oct 18, 2022 at 4:34 PM Morten Brørup wrote: > > --> /trace/list,lib.ethdev.* > > {"/trace/list": {"lib.ethdev.configure": "Disabled", > > "lib.ethdev.rxq.setup": "Disabled", > > "lib.ethdev.txq.setup": "Disabled", > > "lib.ethdev.start": "Disabled", > >

[PATCH v2] net/iavf: revert fix VLAN insertion

2022-10-19 Thread Yiding Zhou
When the kernel driver tells to use the L2TAG2 field for VLAN insertion, the context descriptor needs to be used. There is an issue on the vector Tx path, because it does not support the context descriptor. The previous commit forces to select normal path to avoid the above issue, but it results i

RE: [PATCH] telemetry: support boolean type

2022-10-19 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Wednesday, 19 October 2022 09.37 > > Add the boolean type RTE_TEL_BOOL_VAL for values in arrays and dicts. > > Signed-off-by: David Marchand > --- Acked-by: Morten Brørup

RE: [PATCH] trace: take live traces via telemetry

2022-10-19 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Wednesday, 19 October 2022 09.39 > > Hello Morten, Bruce, > > On Tue, Oct 18, 2022 at 4:34 PM Morten Brørup > wrote: > > > --> /trace/list,lib.ethdev.* > > > {"/trace/list": {"lib.ethdev.configure": "Disabled", > > > "lib.ethd

Re: [PATCH] trace: take live traces via telemetry

2022-10-19 Thread David Marchand
On Wed, Oct 19, 2022 at 10:21 AM Morten Brørup wrote: > > > It seems to me that these values are Boolean, and should be true or > > false (not surrounded by quotation marks), instead of some string > > representing a Boolean value. Note: This would require expanding the > > telemetry library with

Re: [PATCH v2] IGC: Remove I225_I_PHY_ID checking

2022-10-19 Thread Kevin Traynor
On 18/10/2022 23:45, Mah, Yock Gen wrote: -Original Message- From: Kevin Traynor Sent: Tuesday, 18 October, 2022 8:54 PM To: Mah, Yock Gen ; IOTG DPDK Ref App ; Zhang, Qi Z Cc: dev@dpdk.org Subject: Re: [PATCH v2] IGC: Remove I225_I_PHY_ID checking On 12/10/2022 09:39, Kevin Traynor

Re: [PATCH V2] doc: add ice in-tree driver version for Intel NICs

2022-10-19 Thread David Marchand
On Fri, Oct 14, 2022 at 9:12 AM Yu Jiang wrote: > > doc: add ice in-tree driver version for Intel NICs > ice in-tree driver test starts from 22.07, cover > vf-tso,vf-checksum_offload,vf-rss, > vf-jumboframe,vm_hotplug etc.. basic vf function. > > Signed-off-by: Yu Jiang > --- > v2: > - add detai

Re: [PATCH v2] net/iavf: revert fix VLAN insertion

2022-10-19 Thread Kevin Traynor
On 19/10/2022 08:54, Yiding Zhou wrote: When the kernel driver tells to use the L2TAG2 field for VLAN insertion, the context descriptor needs to be used. There is an issue on the vector Tx path, because it does not support the context descriptor. The previous commit forces to select normal path

[Bug 1110] i40e: runtime Rx/Tx queue setup is unusable

2022-10-19 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1110 Bug ID: 1110 Summary: i40e: runtime Rx/Tx queue setup is unusable Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

RE: [PATCH v8 09/12] vdpa/ifc: change some driver logic

2022-10-19 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Tuesday, October 18, 2022 8:08 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coque...@redhat.com > Subject: [PATCH v8 09/12] vdpa/ifc: change some driver logic > > Insert internal list element to in

RE: [PATCH v7 10/12] vhost: add vdpa device type to rte vdpa device

2022-10-19 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Tuesday, October 18, 2022 2:20 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coque...@redhat.com > Subject: [PATCH v7 10/12] vhost: add vdpa device type to rte vdpa device > > Add vdpa_device_type t

RE: [PATCH v8 11/12] vhost: vDPA blk device gets ready when the first queue is ready

2022-10-19 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Tuesday, October 18, 2022 8:08 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coque...@redhat.com > Subject: [PATCH v8 11/12] vhost: vDPA blk device gets ready when the first > queue is ready > > Whe

RE: [PATCH v8 12/12] vhost: improve vDPA blk device configure condition

2022-10-19 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Tuesday, October 18, 2022 8:08 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coque...@redhat.com > Subject: [PATCH v8 12/12] vhost: improve vDPA blk device configure > condition > > To support multi

RE: [PATCH v8 11/12] vhost: vDPA blk device gets ready when the first queue is ready

2022-10-19 Thread Pei, Andy
Hi Chenbo, Thanks for your review. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, October 19, 2022 5:15 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v8 11/12] vhost: vDPA blk device gets ready

RE: [PATCH v8 12/12] vhost: improve vDPA blk device configure condition

2022-10-19 Thread Pei, Andy
Hi Chenbo, Thanks for your review. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, October 19, 2022 5:15 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v8 12/12] vhost: improve vDPA blk device co

RE: [PATCH v7 10/12] vhost: add vdpa device type to rte vdpa device

2022-10-19 Thread Pei, Andy
Hi Chebo, Thanks for your review. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, October 19, 2022 5:14 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v7 10/12] vhost: add vdpa device type to rte

RE: [PATCH v8 09/12] vdpa/ifc: change some driver logic

2022-10-19 Thread Pei, Andy
Hi Chenbo, Thanks for your review, I will send v9 to do this. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, October 19, 2022 5:13 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v8 09/12] vdpa/i

RE: [PATCH v6 1/2] vhost: introduce DMA vchannel unconfiguration

2022-10-19 Thread Xia, Chenbo
> -Original Message- > From: Ding, Xuan > Sent: Tuesday, October 18, 2022 11:22 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; He, Xingguang > ; Yang, YvonneX ; Jiang, > Cheng1 ; Wang, YuanX ; Ma, > WenwuX ; Ding, Xuan > Subject: [PATCH v6 1/2] vhost: in

[PATCH v9 01/12] vdpa/ifc: add new device ID for legacy network device

2022-10-19 Thread Andy Pei
From: Huang Wei Add new device id to support IFCVF_NET_TRANSITIONAL_DEVICE_ID (0x1000). Rename macro from "IFCVF_BLK_DEVICE_ID" to "IFCVF_SUBSYS_BLK_DEVICE_ID". Signed-off-by: Huang Wei Signed-off-by: Andy Pei Reviewed-by: Chenbo Xia Reviewed-by: Maxime Coquelin --- drivers/vdpa/ifc/base/if

[PATCH v9 00/12] vdpa/ifc: add multi queue support

2022-10-19 Thread Andy Pei
v9: fix some commit message. v8: change "vdpa_device_type" in "rte_vdpa_device" to "type". v7: Fill vdpa_device_type in vdpa device registration. v6: Add vdpa_device_type to rte_vdpa_device to store vDPA device type. v5: fix some commit message. rework some code logic. v4: fix some comm

[PATCH v9 02/12] vdpa/ifc: add multi-queue support

2022-10-19 Thread Andy Pei
Enable VHOST_USER_PROTOCOL_F_MQ feature. Expose IFCVF_MQ_OFFSET register to enable multi-queue. Signed-off-by: Andy Pei Signed-off-by: Huang Wei Reviewed-by: Chenbo Xia --- drivers/vdpa/ifc/base/ifcvf.c | 9 + drivers/vdpa/ifc/base/ifcvf.h | 2 ++ drivers/vdpa/ifc/ifcvf_vdpa.c | 1 + 3

[PATCH v9 03/12] vdpa/ifc: set max queues based on virtio spec

2022-10-19 Thread Andy Pei
Set max_queues according to virtio spec. For virtio BLK device, set max_queues to the value of num_queues in struct virtio_blk_config. For virtio NET device, read num_queues from struct ifcvf_pci_common_cfg, get the queue pair number using num_queues and set max_queues to it. Signed-off-by: Andy P

[PATCH v9 06/12] vdpa/ifc: support dynamic enable/disable queue

2022-10-19 Thread Andy Pei
From: Huang Wei Support dynamic enable or disable queue. For front end, like QEMU, user can use ethtool to configure queue. For example, "ethtool -L eth0 combined 3" to enable 3 queues pairs. Signed-off-by: Huang Wei Signed-off-by: Andy Pei Reviewed-by: Chenbo Xia --- drivers/vdpa/ifc/base/i

[PATCH v9 04/12] vdpa/ifc: write queue count to MQ register

2022-10-19 Thread Andy Pei
Write queue count to IFCVF_MQ_OFFSET register to enable multi-queue feature. Signed-off-by: Andy Pei Signed-off-by: Huang Wei Reviewed-by: Chenbo Xia --- drivers/vdpa/ifc/base/ifcvf.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/vdpa/ifc/base/if

[PATCH v9 05/12] vdpa/ifc: only configure enabled queue

2022-10-19 Thread Andy Pei
When configuring the hardware queue, we only configure queues which have been enabled by vhost. Signed-off-by: Andy Pei Signed-off-by: Huang Wei Reviewed-by: Chenbo Xia --- drivers/vdpa/ifc/base/ifcvf.c | 3 +++ drivers/vdpa/ifc/ifcvf_vdpa.c | 16 ++-- 2 files changed, 17 insertio

[PATCH v9 07/12] vdpa/ifc: change internal function name

2022-10-19 Thread Andy Pei
Change internal function name "find_internal_resource_by_dev" to "find_internal_resource_by_pci_dev". Signed-off-by: Andy Pei Reviewed-by: Chenbo Xia Reviewed-by: Maxime Coquelin --- drivers/vdpa/ifc/ifcvf_vdpa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/v

[PATCH v9 08/12] vdpa/ifc: add internal API to get device

2022-10-19 Thread Andy Pei
Add new internal API "find_internal_resource_by_rte_dev" to get device. Signed-off-by: Andy Pei Reviewed-by: Chenbo Xia Reviewed-by: Maxime Coquelin --- drivers/vdpa/ifc/ifcvf_vdpa.c | 28 ++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/drivers/vdpa/

[PATCH v9 09/12] vdpa/ifc: improve internal list logic

2022-10-19 Thread Andy Pei
Insert internal list element to internal list before register vdpa device, in order to call vdpa ops during vdpa device registration. Signed-off-by: Andy Pei Reviewed-by: Maxime Coquelin --- drivers/vdpa/ifc/ifcvf_vdpa.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --

[PATCH v9 10/12] vhost: add type to rte vdpa device

2022-10-19 Thread Andy Pei
Add type to rte_vdpa_device to store device type. Call vdpa ops get_dev_type to fill type when register vdpa device. Signed-off-by: Andy Pei Reviewed-by: Chenbo Xia Reviewed-by: Maxime Coquelin --- lib/vhost/socket.c | 15 +-- lib/vhost/vdpa.c| 15 +++ lib/

[PATCH v9 11/12] vhost: vDPA blk device gets ready when the first queue is ready

2022-10-19 Thread Andy Pei
When boot from virtio blk device, seabios in QEMU only enables one queue. To work in this scenario, vDPA BLK device back-end configure device when the first queue is ready. Signed-off-by: Andy Pei Signed-off-by: Huang Wei Reviewed-by: Chenbo Xia Reviewed-by: Maxime Coquelin --- lib/vhost/vhos

[PATCH v9 12/12] vhost: improve vDPA blk device configure condition

2022-10-19 Thread Andy Pei
To support multi-queue, configure device after call fd of all queues are set. Signed-off-by: Andy Pei Signed-off-by: Huang Wei Reviewed-by: Chenbo Xia Reviewed-by: Maxime Coquelin --- lib/vhost/vhost_user.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/lib

RE: [PATCH v8 08/12] vdpa/ifc: add internal API to get device

2022-10-19 Thread Pei, Andy
Hi Chenbo, Thanks for your review. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, October 19, 2022 3:04 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v8 08/12] vdpa/ifc: add internal API to get

RE: [PATCH v8 07/12] vdpa/ifc: change internal function name

2022-10-19 Thread Pei, Andy
HI Chenbo, Thanks for your review. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, October 19, 2022 2:59 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v8 07/12] vdpa/ifc: change internal functio

Re: [PATCH v2] net/bonding: make bonded device configure method re-entrant

2022-10-19 Thread Andrew Rybchenko
On 10/18/22 22:45, Ivan Malov wrote: According to the documentation, rte_eth_dev_configure() can be invoked repeatedly while in stopped state. The current implementation in the bonding driver allows for that (technically), but the user sees warnings which say that back-end devices have already be

Re: [PATCH] net/bonding: fix flow flush order on bonded device close

2022-10-19 Thread Andrew Rybchenko
On 10/17/22 15:34, Chas Williams wrote: This appears to be correct, but it needs to be coordinated with the proposed changes in net/bonding: make bonded device configure method re-entrant Ivan, could you comment and send rebased v2 version anyway. On 10/17/22 04:41, Andrew Rybchenko wrote:

[PATCH v4 00/14] add support for idpf PMD in DPDK

2022-10-19 Thread Junfeng Guo
This patchset introduced the idpf (Infrastructure Data Path Function) PMD in DPDK for Intel® IPU Ethernet ES2000 Series (Device ID: 0x1452). v2: fixed some coding style issues and did some refactors. v3: fixed some coding style issues and did some refactors. v4: fixed some coding style issues an

[PATCH v4 02/14] net/idpf: add support for device initialization

2022-10-19 Thread Junfeng Guo
Support device init and add the following dev ops skeleton: - dev_configure - dev_start - dev_stop - dev_close Signed-off-by: Beilei Xing Signed-off-by: Xiaoyun Li Signed-off-by: Xiao Wang Signed-off-by: Junfeng Guo --- MAINTAINERS| 9 + doc/guides/nics/featu

[PATCH v4 03/14] net/idpf: add queue setup and release in single queue model

2022-10-19 Thread Junfeng Guo
Add support for queue operations in single queue model: - rx_queue_setup - rx_queue_release - tx_queue_setup - tx_queue_release In the single queue model, the same descriptor queue is used by SW to post buffer descriptors to HW and by HW to post completed descriptors to SW. Signed-off-by: Bei

[PATCH v4 04/14] net/idpf: add queue setup and release in split queue model

2022-10-19 Thread Junfeng Guo
Add support for queue operations in split queue model: - rx_queue_setup - rx_queue_release - tx_queue_setup - tx_queue_release In the split queue model, "RX buffer queues" are used to pass descriptor buffers from SW to HW while Rx queues are used only to pass the descriptor completions, that i

[PATCH v4 05/14] net/idpf: add support for queue start and stop

2022-10-19 Thread Junfeng Guo
Add support for queue operations: - rx_queue_start - rx_queue_stop - tx_queue_start - tx_queue_stop Signed-off-by: Beilei Xing Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- doc/guides/nics/features/idpf.ini | 1 + drivers/net/idpf/idpf_ethdev.c| 46 + drivers/net/idpf

[PATCH v4 06/14] net/idpf: add support for device information get

2022-10-19 Thread Junfeng Guo
Add dev ops dev_infos_get. Signed-off-by: Beilei Xing Signed-off-by: Junfeng Guo --- drivers/net/idpf/idpf_ethdev.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c index c25f222c5e..d1b6797d4

[PATCH v4 07/14] net/idpf: add support for packet type get

2022-10-19 Thread Junfeng Guo
Add dev ops dev_supported_ptypes_get. Signed-off-by: Beilei Xing Signed-off-by: Wenjun Wu Signed-off-by: Junfeng Guo --- doc/guides/nics/features/idpf.ini | 1 + drivers/net/idpf/idpf_ethdev.c| 7 + drivers/net/idpf/idpf_ethdev.h| 2 + drivers/net/idpf/idpf_rxtx.c | 19 +++

[PATCH v4 08/14] net/idpf: add support for basic Rx/Tx datapath

2022-10-19 Thread Junfeng Guo
Add basic Rx & Tx support in split queue mode and single queue mode. Split queue mode is selected by default. Signed-off-by: Beilei Xing Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- drivers/net/idpf/idpf_ethdev.c | 8 +- drivers/net/idpf/idpf_rxtx.c | 667 ++

[PATCH v4 09/14] net/idpf: add support for Rx/Tx offloading

2022-10-19 Thread Junfeng Guo
Add Rx/Tx offloading support, including TSO and CHKSUM. Signed-off-by: Beilei Xing Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- doc/guides/nics/features/idpf.ini | 3 + drivers/net/idpf/idpf_ethdev.c| 10 ++ drivers/net/idpf/idpf_rxtx.c | 237 +++

[PATCH v4 10/14] net/idpf: add support for RSS

2022-10-19 Thread Junfeng Guo
Add RSS support. Signed-off-by: Beilei Xing Signed-off-by: Junfeng Guo --- drivers/net/idpf/idpf_ethdev.c | 123 - drivers/net/idpf/idpf_ethdev.h | 26 +++ drivers/net/idpf/idpf_rxtx.c | 27 drivers/net/idpf/idpf_vchnl.c | 96 ++

[PATCH v4 11/14] net/idpf: add support for MTU configuration

2022-10-19 Thread Junfeng Guo
Add dev ops mtu_set. Signed-off-by: Beilei Xing Signed-off-by: Junfeng Guo --- doc/guides/nics/features/idpf.ini | 1 + drivers/net/idpf/idpf_ethdev.c| 24 2 files changed, 25 insertions(+) diff --git a/doc/guides/nics/features/idpf.ini b/doc/guides/nics/features

[PATCH v4 12/14] net/idpf: add support for write back based on ITR expire

2022-10-19 Thread Junfeng Guo
Force write-backs by setting WB_ON_ITR bit in DYN_CTL register, so that the packets can be received once at a time. Signed-off-by: Beilei Xing Signed-off-by: Junfeng Guo --- drivers/net/idpf/idpf_ethdev.c | 119 + drivers/net/idpf/idpf_ethdev.h | 8 +++ drivers

[PATCH v4 13/14] net/idpf: add AVX512 data path for single queue model

2022-10-19 Thread Junfeng Guo
Add support of AVX512 vector data path for single queue model. Signed-off-by: Wenjun Wu Signed-off-by: Beilei Xing Signed-off-by: Junfeng Guo --- doc/guides/nics/idpf.rst| 20 + drivers/net/idpf/idpf_ethdev.h | 5 + drivers/net/idpf/idpf_rxtx.c| 144

[PATCH v4 14/14] net/idpf: add support for timestamp offload

2022-10-19 Thread Junfeng Guo
Add support for timestamp offload. Signed-off-by: Wenjing Qiao Signed-off-by: Beilei Xing Signed-off-by: Junfeng Guo --- doc/guides/nics/features/idpf.ini | 1 + drivers/net/idpf/idpf_ethdev.c| 5 +- drivers/net/idpf/idpf_ethdev.h| 3 ++ drivers/net/idpf/idpf_rxtx.c | 57 ++

[PATCH] bus: fix memleak during pci device cleanup

2022-10-19 Thread Kevin Laatz
During PCI bus device cleanup some interrupt handle pointers and the bus_info pointer are not being free'd, leading to memory leaks. This patch fixes the memory leaks by ensuring they are free'd during device cleanup on exit. Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown") Signed-off-by:

Re: [PATCH v2 02/24] net/nfp: add the structures and functions for flow offload

2022-10-19 Thread Ferruh Yigit
On 10/19/2022 3:50 AM, Chaoyong He wrote: On 10/10/2022 7:08 AM, Chaoyong He wrote: Add the structures and functions to process mask table, flow table, and flow stats id, which are used in the rte_flow offload logics. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund <...> +__rte_u

Re: [PATCH] trace: take live traces via telemetry

2022-10-19 Thread Bruce Richardson
On Tue, Oct 18, 2022 at 02:14:37PM +0100, Bruce Richardson wrote: > On Thu, Oct 13, 2022 at 09:49:28AM +0200, David Marchand wrote: > > Register telemetry commands to list and configure trace points and later > > save traces for a running DPDK application. > > > > Note: trace point names contain a

[PATCH] bus/vdev: vdev_cleanup checks dev->device.driver

2022-10-19 Thread Zhangfei Gao
The vdev_probe calls driver->probe, which may fail and dev->device.driver will still be NULL. In vdev_cleanup, drv = container_of(dev->device.driver) returns !NULL, then drv->remove will trigger Segmentation fault. Fix it by checking dev->device.driver first. Log: Thread 1 "dpdk-test" received si

[PATCH v5 00/14] add support for idpf PMD in DPDK

2022-10-19 Thread Junfeng Guo
This patchset introduced the idpf (Infrastructure Data Path Function) PMD in DPDK for Intel® IPU Ethernet ES2000 Series (Device ID: 0x1452). v2: fixed some coding style issues and did some refactors. v3: fixed some coding style issues and did some refactors. v4: fixed some coding style issues an

[PATCH v5 02/14] net/idpf: add support for device initialization

2022-10-19 Thread Junfeng Guo
Support device init and add the following dev ops skeleton: - dev_configure - dev_start - dev_stop - dev_close Signed-off-by: Beilei Xing Signed-off-by: Xiaoyun Li Signed-off-by: Xiao Wang Signed-off-by: Junfeng Guo --- MAINTAINERS| 9 + doc/guides/nics/featu

[PATCH v5 03/14] net/idpf: add queue setup and release in single queue model

2022-10-19 Thread Junfeng Guo
Add support for queue operations in single queue model: - rx_queue_setup - rx_queue_release - tx_queue_setup - tx_queue_release In the single queue model, the same descriptor queue is used by SW to post buffer descriptors to HW and by HW to post completed descriptors to SW. Signed-off-by: Bei

[PATCH v5 04/14] net/idpf: add queue setup and release in split queue model

2022-10-19 Thread Junfeng Guo
Add support for queue operations in split queue model: - rx_queue_setup - rx_queue_release - tx_queue_setup - tx_queue_release In the split queue model, "RX buffer queues" are used to pass descriptor buffers from SW to HW while Rx queues are used only to pass the descriptor completions, that i

[PATCH v5 05/14] net/idpf: add support for queue start and stop

2022-10-19 Thread Junfeng Guo
Add support for queue operations: - rx_queue_start - rx_queue_stop - tx_queue_start - tx_queue_stop Signed-off-by: Beilei Xing Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- doc/guides/nics/features/idpf.ini | 1 + drivers/net/idpf/idpf_ethdev.c| 46 + drivers/net/idpf

[PATCH v5 06/14] net/idpf: add support for device information get

2022-10-19 Thread Junfeng Guo
Add dev ops dev_infos_get. Signed-off-by: Beilei Xing Signed-off-by: Junfeng Guo --- drivers/net/idpf/idpf_ethdev.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c index c25f222c5e..d1b6797d4

[PATCH v5 07/14] net/idpf: add support for packet type get

2022-10-19 Thread Junfeng Guo
Add dev ops dev_supported_ptypes_get. Signed-off-by: Beilei Xing Signed-off-by: Wenjun Wu Signed-off-by: Junfeng Guo --- doc/guides/nics/features/idpf.ini | 1 + drivers/net/idpf/idpf_ethdev.c| 7 + drivers/net/idpf/idpf_ethdev.h| 2 + drivers/net/idpf/idpf_rxtx.c | 19 +++

[PATCH v5 08/14] net/idpf: add support for basic Rx/Tx datapath

2022-10-19 Thread Junfeng Guo
Add basic Rx & Tx support in split queue mode and single queue mode. Split queue mode is selected by default. Signed-off-by: Beilei Xing Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- drivers/net/idpf/idpf_ethdev.c | 8 +- drivers/net/idpf/idpf_rxtx.c | 667 ++

[PATCH v5 09/14] net/idpf: add support for Rx/Tx offloading

2022-10-19 Thread Junfeng Guo
Add Rx/Tx offloading support, including TSO and CHKSUM. Signed-off-by: Beilei Xing Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- doc/guides/nics/features/idpf.ini | 3 + drivers/net/idpf/idpf_ethdev.c| 10 ++ drivers/net/idpf/idpf_rxtx.c | 237 +++

[PATCH v5 10/14] net/idpf: add support for RSS

2022-10-19 Thread Junfeng Guo
Add RSS support. Signed-off-by: Beilei Xing Signed-off-by: Junfeng Guo --- drivers/net/idpf/idpf_ethdev.c | 123 - drivers/net/idpf/idpf_ethdev.h | 26 +++ drivers/net/idpf/idpf_rxtx.c | 27 drivers/net/idpf/idpf_vchnl.c | 96 ++

[PATCH v5 11/14] net/idpf: add support for MTU configuration

2022-10-19 Thread Junfeng Guo
Add dev ops mtu_set. Signed-off-by: Beilei Xing Signed-off-by: Junfeng Guo --- doc/guides/nics/features/idpf.ini | 1 + drivers/net/idpf/idpf_ethdev.c| 24 2 files changed, 25 insertions(+) diff --git a/doc/guides/nics/features/idpf.ini b/doc/guides/nics/features

[PATCH v5 12/14] net/idpf: add support for write back based on ITR expire

2022-10-19 Thread Junfeng Guo
Force write-backs by setting WB_ON_ITR bit in DYN_CTL register, so that the packets can be received once at a time. Signed-off-by: Beilei Xing Signed-off-by: Junfeng Guo --- drivers/net/idpf/idpf_ethdev.c | 119 + drivers/net/idpf/idpf_ethdev.h | 8 +++ drivers

[PATCH v5 13/14] net/idpf: add AVX512 data path for single queue model

2022-10-19 Thread Junfeng Guo
Add support of AVX512 vector data path for single queue model. Signed-off-by: Wenjun Wu Signed-off-by: Junfeng Guo --- doc/guides/nics/idpf.rst| 20 + drivers/net/idpf/idpf_ethdev.h | 5 + drivers/net/idpf/idpf_rxtx.c| 146 drivers/net/idpf/idpf_rxtx

[PATCH v5 14/14] net/idpf: add support for timestamp offload

2022-10-19 Thread Junfeng Guo
Add support for timestamp offload. Signed-off-by: Wenjing Qiao Signed-off-by: Junfeng Guo --- doc/guides/nics/features/idpf.ini | 1 + drivers/net/idpf/idpf_ethdev.c| 5 +- drivers/net/idpf/idpf_ethdev.h| 3 ++ drivers/net/idpf/idpf_rxtx.c | 57 drivers/net/

Re: [PATCH v2 03/24] net/nfp: add the flow APIs of nfp PMD

2022-10-19 Thread Ferruh Yigit
On 10/19/2022 4:00 AM, Chaoyong He wrote: On 10/10/2022 7:08 AM, Chaoyong He wrote: Add the flow validate/create/query/destroy/flush API of nfp PMD. The flow create API construct a control cmsg and send it to firmware, then add this flow to the hash table. The flow query API get flow stats fr

[PATCH v2] net/bonding: fix flow flush order on bonded device close

2022-10-19 Thread Ivan Malov
The current code first removes all back-end devices of the bonded device and then invokes flush operation to remove flows in such back-end devices, which makes no sense. Fix that by re-ordering the steps accordingly. Fixes: 49dad9028e2a ("net/bonding: support flow API") Cc: sta...@dpdk.org Signed

Re: [PATCH] net/bonding: fix flow flush order on bonded device close

2022-10-19 Thread Ivan Malov
Hi Chas, Andrew, On Wed, 19 Oct 2022, Andrew Rybchenko wrote: On 10/17/22 15:34, Chas Williams wrote: This appears to be correct, but it needs to be coordinated with the proposed changes in net/bonding: make bonded device configure method re-entrant Needs to be coordinated - in which way? A

RE: [PATCH v2 03/24] net/nfp: add the flow APIs of nfp PMD

2022-10-19 Thread Chaoyong He
> On 10/19/2022 4:00 AM, Chaoyong He wrote: > >> On 10/10/2022 7:08 AM, Chaoyong He wrote: > >>> Add the flow validate/create/query/destroy/flush API of nfp PMD. > >>> > >>> The flow create API construct a control cmsg and send it to > >>> firmware, then add this flow to the hash table. > >>> > >>

RE: [PATCH v2 05/24] net/nfp: add the offload support of basic actions

2022-10-19 Thread Chaoyong He
> On 10/10/2022 7:08 AM, Chaoyong He wrote: > > Add the offload support of very basic actions: mark, rss, count, drop > > and output. > > > > Signed-off-by: Chaoyong He > > Reviewed-by: Niklas Söderlund > > --- > > doc/guides/nics/features/nfp.ini | 6 ++ > > doc/guides/rel_notes/rel

Re: [PATCH 3/4] eventdev: have ethernet Tx adapter appropriately report idle

2022-10-19 Thread Jerin Jacob
On Tue, Oct 18, 2022 at 2:49 PM Jayatheerthan, Jay wrote: > > Looks good to me. Thanks for submitting this! > > Acked by: Jay Jayatheerthan Updated the git commit as follows and series applied to dpdk-next-net-eventdev/for-main. Thanks commit 76d97b8d05b62da1a15c0716d15f1179dd77369e (HEAD -> f

RE: [PATCH v2 08/24] net/nfp: add the offload support of IPv6 item

2022-10-19 Thread Chaoyong He
> On 10/10/2022 7:08 AM, Chaoyong He wrote: > > Add the corresponding data structure and logics, to support the > > offload of IPv6 item. > > > > Signed-off-by: Chaoyong He > > Reviewed-by: Niklas Söderlund > > --- > > doc/guides/nics/features/nfp.ini | 2 + > > doc/guides/rel_notes/r

Re: [PATCH v2 03/24] net/nfp: add the flow APIs of nfp PMD

2022-10-19 Thread Ferruh Yigit
On 10/19/2022 12:30 PM, Chaoyong He wrote: On 10/19/2022 4:00 AM, Chaoyong He wrote: On 10/10/2022 7:08 AM, Chaoyong He wrote: Add the flow validate/create/query/destroy/flush API of nfp PMD. The flow create API construct a control cmsg and send it to firmware, then add this flow to the hash

Re: [PATCH] bus/vdev: vdev_cleanup checks dev->device.driver

2022-10-19 Thread David Marchand
On Wed, Oct 19, 2022 at 12:55 PM Zhangfei Gao wrote: > > The vdev_probe calls driver->probe, which may fail > and dev->device.driver will still be NULL. > > In vdev_cleanup, drv = container_of(dev->device.driver) returns !NULL, > then drv->remove will trigger Segmentation fault. > Fix it by checki

Re: [PATCH] bus: fix memleak during pci device cleanup

2022-10-19 Thread David Marchand
On Wed, Oct 19, 2022 at 12:46 PM Kevin Laatz wrote: > > During PCI bus device cleanup some interrupt handle pointers and the > bus_info pointer are not being free'd, leading to memory leaks. > This patch fixes the memory leaks by ensuring they are free'd during > device cleanup on exit. > > Fixes:

RE: [PATCH] net/ice/base: fix duplicate flow rules

2022-10-19 Thread Xu, Ke1
> -Original Message- > From: Yiding Zhou > Sent: Thursday, October 13, 2022 2:21 PM > To: dev@dpdk.org > Cc: Zhou, YidingX ; sta...@dpdk.org > Subject: [PATCH] net/ice/base: fix duplicate flow rules > > When a vsi that already exists in the created vsi_list subscribes to the same > filt

[PATCH v2] bus: fix memleak during pci device cleanup

2022-10-19 Thread Kevin Laatz
During PCI bus device cleanup some interrupt handle pointers and the bus_info pointer are not being free'd, leading to memory leaks. This patch fixes the memory leaks by ensuring they are free'd during device cleanup on exit. Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown") Signed-off-by:

[Bug 1111] i40e: buffer size fields may overflow in Rx descriptors

2022-10-19 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id= Bug ID: Summary: i40e: buffer size fields may overflow in Rx descriptors Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRM

Re: [PATCH] eventdev: update release notes

2022-10-19 Thread Jerin Jacob
On Thu, Oct 13, 2022 at 2:48 PM wrote: > > From: Pavan Nikhilesh > > Update release notes for changes made in eventdev library. > > Fixes: 5fa63911e43b ("eventdev: replace padding type in event vector") > Fixes: 0fbb55efa542 ("eventdev: add element offset to event vector") > Fixes: d986276f9b72 (

[PATCH v4 0/6] crypto/uadk: introduce uadk crypto driver

2022-10-19 Thread Zhangfei Gao
Introduce a new crypto PMD for hardware accelerators based on UADK [1]. UADK is a framework for user applications to access hardware accelerators. UADK relies on IOMMU SVA (Shared Virtual Address) feature, which share the same page table between IOMMU and MMU. Thereby user application can directly

[PATCH v4 1/6] crypto/uadk: introduce uadk crypto driver

2022-10-19 Thread Zhangfei Gao
Introduce a new crypto PMD for hardware accelerators based on UADK [1]. UADK is a framework for user applications to access hardware accelerators. UADK relies on IOMMU SVA (Shared Virtual Address) feature, which share the same page table between IOMMU and MMU. Thereby user application can directly

[PATCH v4 2/6] crypto/uadk: support basic operations

2022-10-19 Thread Zhangfei Gao
Support the basic dev control operations: configure, close, start, stop and get info, as well as queue pairs operations. Signed-off-by: Zhangfei Gao --- drivers/crypto/uadk/uadk_crypto_pmd.c | 213 -- 1 file changed, 204 insertions(+), 9 deletions(-) diff --git a/drivers

[PATCH v4 3/6] crypto/uadk: support enqueue/dequeue operations

2022-10-19 Thread Zhangfei Gao
This commit adds the enqueue and dequeue operations. Signed-off-by: Zhangfei Gao --- drivers/crypto/uadk/uadk_crypto_pmd.c | 53 ++- 1 file changed, 51 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/uadk/uadk_crypto_pmd.c b/drivers/crypto/uadk/uadk_crypto_pmd

[PATCH v4 5/6] crypto/uadk: support auth algorithms

2022-10-19 Thread Zhangfei Gao
Hash algorithms: * ``RTE_CRYPTO_AUTH_MD5`` * ``RTE_CRYPTO_AUTH_MD5_HMAC`` * ``RTE_CRYPTO_AUTH_SHA1`` * ``RTE_CRYPTO_AUTH_SHA1_HMAC`` * ``RTE_CRYPTO_AUTH_SHA224`` * ``RTE_CRYPTO_AUTH_SHA224_HMAC`` * ``RTE_CRYPTO_AUTH_SHA256`` * ``RTE_CRYPTO_AUTH_SHA256_HMAC`` * ``RTE_CRYPTO_AUTH_SHA384`` * ``RTE_CR

[PATCH v4 4/6] crypto/uadk: support cipher algorithms

2022-10-19 Thread Zhangfei Gao
Cipher algorithms: * ``RTE_CRYPTO_CIPHER_AES_ECB`` * ``RTE_CRYPTO_CIPHER_AES_CBC`` * ``RTE_CRYPTO_CIPHER_AES_XTS`` * ``RTE_CRYPTO_CIPHER_DES_CBC`` Signed-off-by: Zhangfei Gao --- doc/guides/cryptodevs/features/uadk.ini | 10 + doc/guides/cryptodevs/uadk.rst | 6 + drivers/crypto/uad

[PATCH v4 6/6] test/crypto: add cryptodev_uadk_autotest

2022-10-19 Thread Zhangfei Gao
Example: sudo dpdk-test --vdev=crypto_uadk --log-level=6 RTE>>cryptodev_uadk_autotest RTE>>quit Signed-off-by: Zhangfei Gao --- app/test/test_cryptodev.c | 7 +++ app/test/test_cryptodev.h | 1 + 2 files changed, 8 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptod

RE: [PATCH 3/3] ethdev: add structure for indirect AGE update

2022-10-19 Thread Michael Baum
Hi Andrew and Ori, On 10/4/22 9:37, Andrew Rybchenko wrote: > > On 10/3/22 18:13, Ori Kam wrote: > > Hi Andrew, > > > >> -Original Message- > >> From: Andrew Rybchenko > >> Sent: Monday, 3 October 2022 16:18 > >> > >> On 10/3/22 11:30, Ori Kam wrote: > >>> Hi Andrew, > >>> > -O

[PATCH] bus/vdev: automatically add eth alias for net drivers

2022-10-19 Thread Bruce Richardson
For historical reasons, a number of net vdev drivers also add a driver alias using the "eth_" prefix. Since this is done on a per-driver basis, the use of the alias in inconsistent and is spread across multiple files. We can remove the per-driver aliases by just adding the alias automatically at th

[PATCH v2 0/3] ethdev: AGE action preparation

2022-10-19 Thread Michael Baum
RFC's: https://patchwork.dpdk.org/project/dpdk/patch/7a45693f478b1b721b4e05131141b526185a175c.1654063912.git.jack...@nvidia.com/ https://patchwork.dpdk.org/project/dpdk/patch/608febf8d5d3c434a1eddb2e56f425ebbd6ff0b4.1654063912.git.jack...@nvidia.com/ v2: - rebase. - Add reference to "rte_flow_upda

[PATCH v2 3/3] ethdev: add structure for indirect AGE update

2022-10-19 Thread Michael Baum
Add a new structure for indirect AGE update. This new structure enables: 1. Update timeout value. 2. Stop AGE checking. 3. Start AGE checking. 4. restart AGE checking. Signed-off-by: Michael Baum Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c| 66 ++ app/

[PATCH v2 1/3] ethdev: add strict queue to pre-configuration flow hints

2022-10-19 Thread Michael Baum
The data-path focused flow rule management can manage flow rules in more optimized way than traditional one by using hints provided by application in initialization phase. In addition to the current hints we have in port attr, more hints could be provided by application about its behaviour. One e

[PATCH v2 2/3] ethdev: add queue-based API to report aged flow rules

2022-10-19 Thread Michael Baum
When application use queue-based flow rule management and operate the same flow rule on the same queue, e.g create/destroy/query, API of querying aged flow rules should also have queue id parameter just like other queue-based flow APIs. By this way, PMD can work in more optimized way since resourc

Re: [PATCH] drivers/net: remove alias for virtual devices

2022-10-19 Thread Bruce Richardson
On Wed, Sep 21, 2022 at 04:26:11PM +0200, Thomas Monjalon wrote: > I think this patch requires a techboard vote > as it is dropping some user-facing naming. > I think a better solution is to centralize the use of aliases. I've just posted a patch to this thread to add the aliasing for net drivers

  1   2   3   4   >