crypto/uadk: introduce uadk crypto driver

2022-10-17 Thread Akhil Goyal
Hi everyone, We have a new crypto PMD submitted on ML (http://patches.dpdk.org/project/dpdk/cover/20221008083747.6559-1-zhangfei@linaro.org/) This PMD is dependent on an external library which needs to be cross compiled for ARM on x86. It mandatorily need "numactl" also cross-compiled and i

RE: [PATCH v4 8/8] vhost: improve vDPA blk device configure condition

2022-10-17 Thread Pei, Andy
Hi Chenbo, Thanks for your efforts. > -Original Message- > From: Xia, Chenbo > Sent: Monday, October 17, 2022 2:35 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v4 8/8] vhost: improve vDPA blk device config

[PATCH v3] vhost: add new `rte_vhost_vring_call_nonblock` API

2022-10-17 Thread Changpeng Liu
Vhost-user library locks all VQ's access lock when processing vring based messages, such as SET_VRING_KICK and SET_VRING_CALL, and the data processing thread may already be started, e.g: SPDK vhost-blk and vhost-scsi will start the data processing thread when one vring is ready, then deadlock may h

RE: [PATCH v2] vhost: add new `rte_vhost_vring_call_nonblock` API

2022-10-17 Thread Liu, Changpeng
> -Original Message- > From: Xia, Chenbo > Sent: Monday, October 17, 2022 2:47 PM > To: Liu, Changpeng ; dev@dpdk.org > Cc: Maxime Coquelin ; David Marchand > > Subject: RE: [PATCH v2] vhost: add new `rte_vhost_vring_call_nonblock` API > > Hi Changpeng, > > > -Original Message---

[PATCH v5 0/8] vdpa/ifc: add multi queue support

2022-10-17 Thread Andy Pei
v5: fix some commit message. rework some code logic. v4: fix some commit message. add some commets to code. fix some code to reduce confusion. v3: rename device ID macro name. fix some patch title and commit message. delete some used marco. rework some code logic. v2: fix some coding s

[PATCH v5 1/8] vdpa/ifc: add new device ID for legacy network device

2022-10-17 Thread Andy Pei
From: Huang Wei Add new device id to support IFCVF_NET_TRANSITIONAL_DEVICE_ID (0x1000). Rename macro from "IFCVF_BLK_DEVICE_ID" to "IFCVF_SUBSYS_BLK_DEVICE_ID". Signed-off-by: Huang Wei Signed-off-by: Andy Pei Reviewed-by: Chenbo Xia Reviewed-by: Maxime Coquelin --- drivers/vdpa/ifc/base/if

[PATCH v5 2/8] vdpa/ifc: add multi-queue support

2022-10-17 Thread Andy Pei
Enable VHOST_USER_PROTOCOL_F_MQ feature. Expose IFCVF_MQ_OFFSET register to enable multi-queue. Signed-off-by: Andy Pei Signed-off-by: Huang Wei Reviewed-by: Chenbo Xia --- drivers/vdpa/ifc/base/ifcvf.c | 9 + drivers/vdpa/ifc/base/ifcvf.h | 2 ++ drivers/vdpa/ifc/ifcvf_vdpa.c | 1 + 3

[PATCH v5 3/8] vdpa/ifc: set max queues based on virtio spec

2022-10-17 Thread Andy Pei
Set max_queues according to virtio spec. For virtio BLK device, set max_queues to the value of num_queues in struct virtio_blk_config. For virtio NET device, read num_queues from struct ifcvf_pci_common_cfg, get the queue pair number using num_queues and set max_queues to it. Signed-off-by: Andy P

[PATCH v5 4/8] vdpa/ifc: write queue count to MQ register

2022-10-17 Thread Andy Pei
Write queue count to IFCVF_MQ_OFFSET register to enable multi-queue feature. Signed-off-by: Andy Pei Signed-off-by: Huang Wei Reviewed-by: Chenbo Xia --- drivers/vdpa/ifc/base/ifcvf.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/vdpa/ifc/base/if

[PATCH v5 6/8] vdpa/ifc: support dynamic enable/disable queue

2022-10-17 Thread Andy Pei
From: Huang Wei Support dynamic enable or disable queue. For front end, like QEMU, user can use ethtool to configure queue. For example, "ethtool -L eth0 combined 3" to enable 3 queues pairs. Signed-off-by: Huang Wei Signed-off-by: Andy Pei Reviewed-by: Chenbo Xia --- drivers/vdpa/ifc/base/i

[PATCH v5 5/8] vdpa/ifc: only configure enabled queue

2022-10-17 Thread Andy Pei
When configuring the hardware queue, we only configure queues which have been enabled by vhost. Signed-off-by: Andy Pei Signed-off-by: Huang Wei Reviewed-by: Chenbo Xia --- drivers/vdpa/ifc/base/ifcvf.c | 3 +++ drivers/vdpa/ifc/ifcvf_vdpa.c | 16 ++-- 2 files changed, 17 insertio

[PATCH v5 7/8] vhost: vDPA blk device gets ready when the first queue is ready

2022-10-17 Thread Andy Pei
When boot from virtio blk device, seabios in QEMU only enables one queue. To work in this scenario, vDPA BLK device back-end configure device when any queue is ready. Signed-off-by: Andy Pei Signed-off-by: Huang Wei --- lib/vhost/vhost_user.c | 31 +++ 1 file changed

[PATCH v5 8/8] vhost: improve vDPA blk device configure condition

2022-10-17 Thread Andy Pei
To support multi-queue, configure device after call fd of all queues are set. Signed-off-by: Andy Pei Signed-off-by: Huang Wei Reviewed-by: Chenbo Xia --- lib/vhost/vhost_user.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/lib/vhost/vhost_user.c b/lib/vhos

RE: [PATCH] example: vdpa: support run in nested virtualization environment

2022-10-17 Thread Xia, Chenbo
> -Original Message- > From: Hao Chen > Sent: Tuesday, October 11, 2022 10:56 AM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; ho...@yusur.tech; z...@yusur.tech > Subject: [PATCH] example: vdpa: support run in nested virtualization > environment Title should be: exam

Re: [PATCH 1/2] event/sw: fix missing flow ID init in selftest

2022-10-17 Thread David Marchand
On Fri, Oct 14, 2022 at 10:38 PM Olivier Matz wrote: > > The issue is seen by unit tests: > > > root@dpdk-VF-dut247:~/dpdk# MALLOC_PERTURB_=204 \ > > DPDK_TEST=eventdev_selftest_sw \ > > /root/dpdk/x86_64-native-linuxapp-gcc/app/test/dpdk-test -c 0xff > > (...) > > *** Running XStats ID Reset

Re: [PATCH] net/virtio: add queue and port ID in some logs

2022-10-17 Thread Olivier Matz
Hi Chenbo, On Mon, Oct 17, 2022 at 06:58:59AM +, Xia, Chenbo wrote: > Hi Olivier, > > > -Original Message- > > From: Olivier Matz > > Sent: Thursday, September 29, 2022 8:22 PM > > To: dev@dpdk.org > > Cc: Maxime Coquelin ; Xia, Chenbo > > > > Subject: [PATCH] net/virtio: add queue

RE: [PATCH v3] vhost: add new `rte_vhost_vring_call_nonblock` API

2022-10-17 Thread Xia, Chenbo
Hi Changpeng, > -Original Message- > From: Liu, Changpeng > Sent: Monday, October 17, 2022 3:15 PM > To: dev@dpdk.org > Cc: Liu, Changpeng ; Maxime Coquelin > ; Xia, Chenbo ; David > Marchand > Subject: [PATCH v3] vhost: add new `rte_vhost_vring_call_nonblock` API > > Vhost-user library

Re: [PATCH v13 0/5] support error handling mode

2022-10-17 Thread Andrew Rybchenko
On 10/13/22 15:42, Chengwen Feng wrote: This patchset introduce error handling mode concept, the supported modes are as follows: 1) PASSIVE: passive error handling, after the PMD detect that a reset is required, the PMD reports RTE_ETH_EVENT_INTR_RESET event, and application invoke rte_eth_dev_r

[PATCH v3] usertools: telemetry pretty print in interactive mode

2022-10-17 Thread Chengwen Feng
Currently, the dpdk-telemetry.py show json in raw format under interactive mode, which is not good for human reading. E.g. The command '/ethdev/xstats,0' will output: {"/ethdev/xstats": {"rx_good_packets": 0, "tx_good_packets": 0, "rx_good_bytes": 0, "tx_good_bytes": 0, "rx_missed_errors": 0, "rx_

[PATCH v4] vhost: add new `rte_vhost_vring_call_nonblock` API

2022-10-17 Thread Changpeng Liu
Vhost-user library locks all VQ's access lock when processing vring based messages, such as SET_VRING_KICK and SET_VRING_CALL, and the data processing thread may already be started, e.g: SPDK vhost-blk and vhost-scsi will start the data processing thread when one vring is ready, then deadlock may h

Re: [PATCH] app/testpmd: fix slave port reset action

2022-10-17 Thread Andrew Rybchenko
On 10/13/22 20:42, Singh, Aman Deep wrote: On 10/12/2022 1:13 PM, Qiming Yang wrote: As stop action has been forbidden in secondary process, so the reset action should also not be allowed. Fixes: a550baf24af9 ("app/testpmd: support multi-process") Cc: sta...@dpdk.org Signed-off-by: Qiming Yang

RE: [PATCH v3] vhost: add new `rte_vhost_vring_call_nonblock` API

2022-10-17 Thread Liu, Changpeng
> -Original Message- > From: Xia, Chenbo > Sent: Monday, October 17, 2022 3:40 PM > To: Liu, Changpeng ; dev@dpdk.org > Cc: Maxime Coquelin ; David Marchand > > Subject: RE: [PATCH v3] vhost: add new `rte_vhost_vring_call_nonblock` API > > Hi Changpeng, > > > -Original Message---

Re: [PATCH] app/testpmd: fix incorrect flow arguments name

2022-10-17 Thread Andrew Rybchenko
On 10/11/22 09:55, Ori Kam wrote: -Original Message- From: Singh, Aman Deep Sent: Thursday, 6 October 2022 10:59 On 9/30/2022 5:09 PM, Suanming Mou wrote: There should be no spaces in flow command arguments name. This commit removes incorrect arguments name in queue based table te

RE: [PATCH v5 7/8] vhost: vDPA blk device gets ready when the first queue is ready

2022-10-17 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Monday, October 17, 2022 3:14 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coque...@redhat.com > Subject: [PATCH v5 7/8] vhost: vDPA blk device gets ready when the first > queue is ready > > When b

Re: [PATCH v2] usertools: telemetry json support pretty print

2022-10-17 Thread fengchengwen
Hi all, On 2022/10/15 0:10, Morten Brørup wrote: >> From: Bruce Richardson [mailto:bruce.richard...@intel.com] >> Sent: Friday, 14 October 2022 17.30 >> >> On Fri, Oct 14, 2022 at 08:01:11AM -0700, Stephen Hemminger wrote: >>> On Fri, 14 Oct 2022 14:02:10 +0100 >>> Bruce Richardson wrote: >>> >>>

[PATCH v2] net/virtio: add queue and port ID in some logs

2022-10-17 Thread Olivier Matz
Add the queue id and/or the port id in some logs, so it is easier to understand what happens. Signed-off-by: Olivier Matz Reviewed-by: Maxime Coquelin --- v2 * use %u instead of %d for unsigned types drivers/net/virtio/virtio_ethdev.c | 6 -- drivers/net/virtio/virtio_rxtx.c | 3 ++- 2

RE: Unsafe memory access in testpmd

2022-10-17 Thread Ruifeng Wang
> -Original Message- > From: Stephen Hemminger > Sent: Friday, October 14, 2022 7:39 AM > To: Ruifeng Wang ; Honnappa Nagarahalli > > Cc: dev@dpdk.org > Subject: Unsafe memory access in testpmd > > Noticed that test-pmd is using a signal handler to exit. > And that signal handle clears a

Re: [PATCH v3] app/testpmd: fix incorrect queues state of secondary process

2022-10-17 Thread Andrew Rybchenko
On 9/13/22 04:26, lihuisong (C) wrote: 在 2022/9/10 17:21, Zhang, Peng1X 写道: -Original Message- From: lihuisong (C) Sent: Wednesday, September 7, 2022 9:53 AM To: Zhang, Peng1X ; dev@dpdk.org Cc: andrew.rybche...@oktetlabs.ru; Singh, Aman Deep ; Zhang, Yuying ; sta...@dpdk.org Subject

[v1] examples/fips_validation: fix test output for AES GMAC decrypt

2022-10-17 Thread Gowrishankar Muthukrishnan
AES GMAC decrypt test should output only whether test passed or failed. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation_gcm.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/examples/fips_validation/fips_validation_gcm.c b/e

[PATCH] net/ice: fix the judgment order of buffer split

2022-10-17 Thread Yuan Wang
proto_hdr defines a bit mask of the protocol sequence as RTE_PTYPE_*, The last RTE_PTYPE* in the mask indicates the split position. To get the split position from hdr_proto, the order of judgement should be from inner to outer layer, so for tunneling packets the tunnel header should be placed at t

RE: [PATCH v2] net/virtio: add queue and port ID in some logs

2022-10-17 Thread Xia, Chenbo
> -Original Message- > From: Olivier Matz > Sent: Monday, October 17, 2022 4:01 PM > To: dev@dpdk.org > Cc: Maxime Coquelin ; Xia, Chenbo > > Subject: [PATCH v2] net/virtio: add queue and port ID in some logs > > Add the queue id and/or the port id in some logs, so it is easier to > unde

Re: [PATCH V3] net/bonding: add link speeds configuration

2022-10-17 Thread Andrew Rybchenko
On 9/25/22 13:35, Chas Williams wrote: Thanks for making the changes! Signed-off-by: 3ch...@gmail.com Thanks above sentence into account I treat it as: Acked-by: Chas Williams <3ch...@gmail.com> On 9/21/22 21:33, Huisong Li wrote: This patch adds link speeds configuration. ---   -v3: add

Re: [PATCH v2] net/bonding: fix error in bonding mode 4 with dedicated queues enabled

2022-10-17 Thread Andrew Rybchenko
On 10/15/22 18:28, Chas Williams wrote: Thanks for making the change, IMHO this is much clearer. Signed-off-by: Chas Williams <3ch...@gmail.com> Taking above sentence into account I treat it as: Acked-by: Chas Williams <3ch...@gmail.com> On 9/29/22 00:05, Usman Tanveer wrote: when dedicate

Re: [PATCH v3 1/1] app/testpmd: control passing Rx metadata to PMD

2022-10-17 Thread Andrew Rybchenko
On 10/6/22 21:35, Hanumanth Pothula wrote: Presently, Rx metadata is sent to PMD by default, leading to a performance drop as processing for the same in rx path takes extra cycles. Hence, introducing command line argument, 'nic-to-pmd-rx-metadata' to control passing rx metadata to PMD. By defaul

Re: [PATCH] app/testpmd: remove useless check

2022-10-17 Thread Andrew Rybchenko
On 10/14/22 12:52, Wang, YuanX wrote: Hi Singh, -Original Message- From: Singh, Aman Deep Sent: Friday, October 14, 2022 5:37 PM To: Wang, YuanX ; Zhang, Yuying Cc: dev@dpdk.org; Ding, Xuan ; Tang, Yaqi Subject: Re: [PATCH] app/testpmd: remove useless check Thanks for the patch Yuan

Re: [PATCH v5 7/8] vhost: vDPA blk device gets ready when the first queue is ready

2022-10-17 Thread Maxime Coquelin
On 10/17/22 09:54, Xia, Chenbo wrote: -Original Message- From: Pei, Andy Sent: Monday, October 17, 2022 3:14 PM To: dev@dpdk.org Cc: Xia, Chenbo ; Xu, Rosen ; Huang, Wei ; Cao, Gang ; maxime.coque...@redhat.com Subject: [PATCH v5 7/8] vhost: vDPA blk device gets ready when the first q

RE: [PATCH] power: fix resource leak by open file pointers

2022-10-17 Thread Pattan, Reshma
> -Original Message- > From: Kearney, Tadhg > Sent: Wednesday, October 12, 2022 9:29 AM > To: dev@dpdk.org > Cc: Hunt, David ; Burakov, Anatoly > ; Pattan, Reshma > ; Kearney, Tadhg > Subject: [PATCH] power: fix resource leak by open file pointers > > Close file pointers to Intel unco

RE: [PATCH] raw/cnxk_bphy: extend pffunc address access

2022-10-17 Thread Tomasz Duszynski
> -Original Message- > From: jpali...@marvell.com > Sent: Friday, October 14, 2022 9:46 PM > To: Jakub Palider ; Tomasz Duszynski > > Cc: dev@dpdk.org > Subject: [PATCH] raw/cnxk_bphy: extend pffunc address access > > From: Jakub Palider > > Allows retrieval of SSO and NPA pffunc addr

RE: [PATCH] net/ice: fix the judgment order of buffer split

2022-10-17 Thread Ding, Xuan
Hi Yuan, > -Original Message- > From: Wang, YuanX > Sent: Tuesday, October 18, 2022 12:00 AM > To: Yang, Qiming ; Zhang, Qi Z > > Cc: dev@dpdk.org; Ding, Xuan ; Tang, Yaqi > ; Wang, YuanX > Subject: [PATCH] net/ice: fix the judgment order of buffer split > > proto_hdr defines a bit mas

Re: [PATCH] net/bonding: fix descriptor limit reporting

2022-10-17 Thread Andrew Rybchenko
Chas, Cornor, could you review the patch, please. Thanks, Andrew. On 9/11/22 15:19, Ivan Malov wrote: Commit 5be3b40fea60 ("net/bonding: fix values of descriptor limits") breaks reporting of "nb_min" and "nb_align" values obtained from back-end devices' descriptor limits. This means that work d

Re: [PATCH] net/bonding: fix flow flush order on bonded device close

2022-10-17 Thread Andrew Rybchenko
Chas, Cornor, could you review the patch, please. Thanks, Andrew. On 9/11/22 15:22, Ivan Malov wrote: The current code first removes all back-end devices of the bonded device and then invokes flush operation to remove flows in such back-end devices, which makes no sense. Fix that by re-ordering

RE: [PATCH v5 7/8] vhost: vDPA blk device gets ready when the first queue is ready

2022-10-17 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Monday, October 17, 2022 4:37 PM > To: Xia, Chenbo ; Pei, Andy ; > dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; Cao, > Gang > Subject: Re: [PATCH v5 7/8] vhost: vDPA blk device gets ready when the > first queue is ready > > > > On 10/

Re: [PATCH] net/bonding: make bonded device configure method re-entrant

2022-10-17 Thread Andrew Rybchenko
Chas, Cornor, could you review the patch, please. Thanks, Andrew. On 9/11/22 15:24, Ivan Malov wrote: According to the documentation, rte_eth_dev_configure() can be invoked repeatedly while in stopped state. The current implementation in the bonding driver allows for that (technically), but the

Re: [PATCH v5 7/8] vhost: vDPA blk device gets ready when the first queue is ready

2022-10-17 Thread Maxime Coquelin
On 10/17/22 10:42, Xia, Chenbo wrote: -Original Message- From: Maxime Coquelin Sent: Monday, October 17, 2022 4:37 PM To: Xia, Chenbo ; Pei, Andy ; dev@dpdk.org Cc: Xu, Rosen ; Huang, Wei ; Cao, Gang Subject: Re: [PATCH v5 7/8] vhost: vDPA blk device gets ready when the first queue i

[PATCH v9 1/1] app/testpmd: support mulitiple mbuf pools per Rx queue

2022-10-17 Thread Hanumanth Pothula
Some of the HW has support for choosing memory pools based on the packet's size. The pool sort capability allows PMD/NIC to choose a memory pool based on the packet's length. On multiple mempool support enabled, populate mempool array accordingly. Also, print pool name on which packet is received.

RE: [PATCH] net/ice: fix the judgment order of buffer split

2022-10-17 Thread Wang, YuanX
Hi Xuan, > -Original Message- > From: Ding, Xuan > Sent: Monday, October 17, 2022 4:40 PM > To: Wang, YuanX ; Yang, Qiming > ; Zhang, Qi Z > Cc: dev@dpdk.org; Tang, Yaqi > Subject: RE: [PATCH] net/ice: fix the judgment order of buffer split > > Hi Yuan, > > > -Original Message

[Bug 1105] [dpdk-22.11] unit_tests_loopback: pmd_perf_autotest failed

2022-10-17 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1105 Bug ID: 1105 Summary: [dpdk-22.11] unit_tests_loopback: pmd_perf_autotest failed Product: DPDK Version: 22.11 Hardware: All OS: FreeBSD Status: UNCONFIR

[PATCH] app/testpmd: remove jumbo offload related code

2022-10-17 Thread Chengwen Feng
The jumbo offload was removed from patch [1], but testpmd still exist jumbo offload related code, this patch removes it, and also updates the rst file. [1] ethdev: remove jumbo offload flag Fixes: b563c1421282 ("ethdev: remove jumbo offload flag") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng

Re: [PATCH v3] usertools: telemetry pretty print in interactive mode

2022-10-17 Thread Bruce Richardson
On Mon, Oct 17, 2022 at 07:41:02AM +, Chengwen Feng wrote: > Currently, the dpdk-telemetry.py show json in raw format under > interactive mode, which is not good for human reading. > > E.g. The command '/ethdev/xstats,0' will output: > {"/ethdev/xstats": {"rx_good_packets": 0, "tx_good_packets

[PATCH v2] net/ice: fix the judgment order of buffer split

2022-10-17 Thread Yuan Wang
proto_hdr defines a bit mask of the protocol sequence as RTE_PTYPE_*, The last RTE_PTYPE* in the mask indicates the split position. To get the split position from proto_hdr, the order of judgement should be from inner to outer layer, so for tunneling packets the tunnel header should be placed at t

RE: [v1 2/2] examples/fips_validation: add ECDSA validation

2022-10-17 Thread Dooley, Brian
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Tuesday, September 27, 2022 8:31 AM > To: dev@dpdk.org > Cc: Anoob Joseph ; Zhang, Roy Fan > ; Dooley, Brian ; Akhil > Goyal ; jer...@marvell.com; Gowrishankar > Muthukrishnan > Subject: [v1 2/2] examples/fips_validation: add

[PATCH] app/testpmd: fix protocol headers display for Rx buffer split

2022-10-17 Thread Yuan Wang
The "show config rxhdrs" cmd displays the configured protocol headers that are used for protocol-based buffer split. However, it shows "inner-ipv6" as "inner-ipv4". This patch fixes that by adjusting the order of condition judgments. Signed-off-by: Yuan Wang --- app/test-pmd/config.c | 24 +

RE: [External] : Re: [dpdk-dev] [PATCH 2/2] net/failsafe: fix primary/secondary mutex

2022-10-17 Thread Madhuker Mythri
> On Wed, Jun 9, 2021, at 12:04, Andrew Rybchenko wrote: >> On 6/8/21 11:48 PM, Stephen Hemminger wrote: >> > On Tue, 8 Jun 2021 18:55:17 +0300 >> > Andrew Rybchenko wrote: >> > >> >> On 6/8/21 6:42 PM, Stephen Hemminger wrote: > >>> On Tue, 8 Jun 2021 11:00:37 +0300 > >>> Andrew Rybchenko wrot

[PATCH v6 0/8] vdpa/ifc: add multi queue support

2022-10-17 Thread Andy Pei
v6: Add vdpa_device_type to rte_vdpa_device to store vDPA device type. v5: fix some commit message. rework some code logic. v4: fix some commit message. add some commets to code. fix some code to reduce confusion. v3: rename device ID macro name. fix some patch title and commit message.

[PATCH v6 1/8] vdpa/ifc: add new device ID for legacy network device

2022-10-17 Thread Andy Pei
From: Huang Wei Add new device id to support IFCVF_NET_TRANSITIONAL_DEVICE_ID (0x1000). Rename macro from "IFCVF_BLK_DEVICE_ID" to "IFCVF_SUBSYS_BLK_DEVICE_ID". Signed-off-by: Huang Wei Signed-off-by: Andy Pei Reviewed-by: Chenbo Xia Reviewed-by: Maxime Coquelin --- drivers/vdpa/ifc/base/if

[PATCH v6 2/8] vdpa/ifc: add multi-queue support

2022-10-17 Thread Andy Pei
Enable VHOST_USER_PROTOCOL_F_MQ feature. Expose IFCVF_MQ_OFFSET register to enable multi-queue. Signed-off-by: Andy Pei Signed-off-by: Huang Wei Reviewed-by: Chenbo Xia --- drivers/vdpa/ifc/base/ifcvf.c | 9 + drivers/vdpa/ifc/base/ifcvf.h | 2 ++ drivers/vdpa/ifc/ifcvf_vdpa.c | 1 + 3

[PATCH v6 3/8] vdpa/ifc: set max queues based on virtio spec

2022-10-17 Thread Andy Pei
Set max_queues according to virtio spec. For virtio BLK device, set max_queues to the value of num_queues in struct virtio_blk_config. For virtio NET device, read num_queues from struct ifcvf_pci_common_cfg, get the queue pair number using num_queues and set max_queues to it. Signed-off-by: Andy P

[PATCH v6 4/8] vdpa/ifc: write queue count to MQ register

2022-10-17 Thread Andy Pei
Write queue count to IFCVF_MQ_OFFSET register to enable multi-queue feature. Signed-off-by: Andy Pei Signed-off-by: Huang Wei Reviewed-by: Chenbo Xia --- drivers/vdpa/ifc/base/ifcvf.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/vdpa/ifc/base/if

[PATCH v6 5/8] vdpa/ifc: only configure enabled queue

2022-10-17 Thread Andy Pei
When configuring the hardware queue, we only configure queues which have been enabled by vhost. Signed-off-by: Andy Pei Signed-off-by: Huang Wei Reviewed-by: Chenbo Xia --- drivers/vdpa/ifc/base/ifcvf.c | 3 +++ drivers/vdpa/ifc/ifcvf_vdpa.c | 16 ++-- 2 files changed, 17 insertio

[PATCH v6 7/8] vhost: vDPA blk device gets ready when the first queue is ready

2022-10-17 Thread Andy Pei
When boot from virtio blk device, seabios in QEMU only enables one queue. To work in this scenario, vDPA BLK device back-end configure device when any queue is ready. Add vdpa_device_type to rte_vdpa_device to store vDPA device type. Signed-off-by: Andy Pei Signed-off-by: Huang Wei --- lib/vhos

[PATCH v6 6/8] vdpa/ifc: support dynamic enable/disable queue

2022-10-17 Thread Andy Pei
From: Huang Wei Support dynamic enable or disable queue. For front end, like QEMU, user can use ethtool to configure queue. For example, "ethtool -L eth0 combined 3" to enable 3 queues pairs. Signed-off-by: Huang Wei Signed-off-by: Andy Pei Reviewed-by: Chenbo Xia --- drivers/vdpa/ifc/base/i

[PATCH v6 8/8] vhost: improve vDPA blk device configure condition

2022-10-17 Thread Andy Pei
To support multi-queue, configure device after call fd of all queues are set. Signed-off-by: Andy Pei Signed-off-by: Huang Wei Reviewed-by: Chenbo Xia --- lib/vhost/vhost_user.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/lib/vhost/vhost_user.c b/lib/vhos

Re: [PATCH v2] doc: fix support table for ETH and VLAN flow items

2022-10-17 Thread fengchengwen
Thanks Ilya and Eli On 2022/10/16 13:26, Eli Britstein wrote: > > >> -Original Message- >> From: Ilya Maximets >> Sent: Friday, October 14, 2022 3:37 PM >> To: fengchengwen ; dev@dpdk.org; Ori Kam >> ; NBU-Contact-Thomas Monjalon (EXTERNAL) >> ; Eli Britstein >> Cc: i.maxim...@ovn.org;

[PATCH v3] dumpcap: fix select interface

2022-10-17 Thread Arshdeep Kaur
Fixed compilation error. Fixes: a8dde09f97df ("app/dumpcap: allow help/version without primary process") Signed-off-by: Arshdeep Kaur --- app/dumpcap/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c index 11a44ecce4..143c93940d 1

RE: [EXT] [PATCH v5 1/5] examples/l3fwd: fix port group mask generation

2022-10-17 Thread Shijith Thotton
> >Fix port group mask generation in altivec, vec_any_eq returns >0 or 1 while port_groupx4 expects comparison mask result. > >Fixes: 2193b7467f7a ("examples/l3fwd: optimize packet processing on powerpc") >Cc: sta...@dpdk.org > >Signed-off-by: Pavan Nikhilesh Acked-by: Shijith Thotton >--- > v5

RE: [EXT] [PATCH v5 2/5] examples/l3fwd: split processing and send stages

2022-10-17 Thread Shijith Thotton
> >Split packet processing from packet send stage, as send stage >is not common for poll and event mode. > >Signed-off-by: Pavan Nikhilesh Acked-by: Shijith Thotton >--- > examples/l3fwd/l3fwd_em_hlm.h | 39 +++--- > examples/l3fwd/l3fwd_lpm_altivec.h | 25 ++

RE: [EXT] [PATCH v5 3/5] examples/l3fwd: use lpm vector path for event vector

2022-10-17 Thread Shijith Thotton
> >Use lpm vector path to process event vector. > >Signed-off-by: Pavan Nikhilesh Acked-by: Shijith Thotton >--- > examples/l3fwd/l3fwd_altivec.h | 29 ++ > examples/l3fwd/l3fwd_event.h | 71 >++ > examples/l3fwd/l3fwd_lpm.c | 39 +++--

RE: [EXT] [PATCH v5 4/5] examples/l3fwd: fix event vector processing in fib

2022-10-17 Thread Shijith Thotton
> >Fix stack overflow when event vector size is greater than >MAX_BURST_SIZE. >Add missing mac swap and rfc1812 stage. > >Fixes: e8adca1951d4 ("examples/l3fwd: support event vector") > >Signed-off-by: Pavan Nikhilesh Acked-by: Shijith Thotton >--- > examples/l3fwd/l3fwd_fib.c | 130

[PATCH v4] dumpcap: fix select interface

2022-10-17 Thread Arshdeep Kaur
The change to do argument process before EAL init broke the support of select-interface option. Fix by setting flag and doing select-interface later. Fixes: a8dde09f97df ("app/dumpcap: allow help/version without primary process") Signed-off-by: Arshdeep Kaur --- app/dumpcap/main.c | 8 +++-

Re: [PATCH] net/nfp: set the appropriate initialized value of flbufsz

2022-10-17 Thread Ferruh Yigit
On 10/15/2022 8:38 AM, Nole Zhang wrote: > On 10/10/2022 7:48 AM, Chaoyong He wrote: From: Peng Zhang When the testpmd app start-up with parameter max-pkt-len, it will set MTU. But the initialized value of flubfsz is inappropriate, if the value of flbufsz is smaller than the valude of max-

Re: [PATCH v3] net/nfp: add the feature of RSS based on VXLAN inner layer

2022-10-17 Thread Ferruh Yigit
On 10/15/2022 8:22 AM, Chaoyong He wrote: Add the logics to support the feature of RSS packets based on the inner layer of VXLAN tunnel. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund Applied to dpdk-next-net/main, thanks.

Re: [PATCH] net/bonding: make bonded device configure method re-entrant

2022-10-17 Thread Chas Williams
This appears to be correct. A minor comment inline. On 10/17/22 04:42, Andrew Rybchenko wrote: Chas, Cornor, could you review the patch, please. Thanks, Andrew. On 9/11/22 15:24, Ivan Malov wrote: According to the documentation, rte_eth_dev_configure() can be invoked repeatedly while in stopp

Re: [PATCH] net/bonding: fix flow flush order on bonded device close

2022-10-17 Thread Chas Williams
This appears to be correct, but it needs to be coordinated with the proposed changes in net/bonding: make bonded device configure method re-entrant On 10/17/22 04:41, Andrew Rybchenko wrote: Chas, Cornor, could you review the patch, please. Thanks, Andrew. On 9/11/22 15:22, Ivan Malov wrote:

RE: [PATCH 2/4] eventdev: have ethernet Rx adapter appropriately report idle

2022-10-17 Thread Naga Harish K, S V
> -Original Message- > From: Jerin Jacob > Sent: Friday, October 14, 2022 11:07 PM > To: mattias.ronnblom > Cc: Naga Harish K, S V ; Jayatheerthan, Jay > ; Carrillo, Erik G ; > Gujjar, Abhinandan S ; Jerin Jacob > ; dev@dpdk.org; Van Haaren, Harry > ; hof...@lysator.liu.se > Subject: Re

Re: [PATCH] net/bonding: fix descriptor limit reporting

2022-10-17 Thread Chas Williams
Acked-by: Chas Williams <3ch...@gmail.com> On 10/17/22 04:40, Andrew Rybchenko wrote: Chas, Cornor, could you review the patch, please. Thanks, Andrew. On 9/11/22 15:19, Ivan Malov wrote: Commit 5be3b40fea60 ("net/bonding: fix values of descriptor limits") breaks reporting of "nb_min" and "nb

Re: [PATCH] vhost: promote per-queue stats API to stable

2022-10-17 Thread David Marchand
On Mon, Oct 10, 2022 at 5:37 PM Maxime Coquelin wrote: > > This patch promotes the per-queue stats API to stable. > The API has been used by the Vhost PMD since v22.07, and > David Marchand posted a patch to make use of it in next > OVS release[0]. > > [0]: > http://patchwork.ozlabs.org/project/o

Re: [PATCH] gro : fix pkt length when extra bytes are padded to ethernet frame

2022-10-17 Thread kumaraparameshwaran rathinavel
Hi Jiayu, Please find the patch http://patches.dpdk.org/project/dpdk/patch/20221016144305.19249-1-kumaraparmes...@gmail.com/ I did reply with the above message ID but for some reason a new patch series was created. Not sure what was the mistake that I made. Should the commit message be the same f

RE: [PATCH v2 0/4] crypto/ccp cleanup

2022-10-17 Thread Uttarwar, Sunil Prakashrao
[Public] Hi Akhil & David, Regarding "crypto/ccp: fix PCI probing" patch, observing some issues while verifying on AMD platform(Floating point exception). It seems there are some issues with this patch. Thanks Sunil -Original Message- From: Akhil Goyal Sent: Thursday, October 13, 20

Re: [PATCH v2 0/4] crypto/ccp cleanup

2022-10-17 Thread David Marchand
Hello, On Mon, Oct 17, 2022 at 3:42 PM Uttarwar, Sunil Prakashrao wrote: > > [Public] > > Hi Akhil & David, > > Regarding "crypto/ccp: fix PCI probing" patch, observing some issues while > verifying on AMD platform(Floating point exception). > > It seems there are some issues with this patch. T

Re: [PATCH 2/2] ci: update to new API for step outputs in GHA

2022-10-17 Thread David Marchand
On Wed, Oct 12, 2022 at 6:53 PM David Marchand wrote: > > On Wed, Oct 12, 2022 at 6:30 PM David Marchand > wrote: > > > > GitHub actions deprecated use of set-output, replaced with > > GITHUB_OUTPUT. It is worth mentionning the deprecation announce: https://github.blog/changelog/2022-10-11-githu

Re: crypto/uadk: introduce uadk crypto driver

2022-10-17 Thread Zhangfei Gao
Hi, Akhil On 2022/10/17 下午3:02, Akhil Goyal wrote: Hi everyone, We have a new crypto PMD submitted on ML (http://patches.dpdk.org/project/dpdk/cover/20221008083747.6559-1-zhangfei@linaro.org/) This PMD is dependent on an external library which needs to be cross compiled for ARM on x86.

[PATCH] ci: combine static and shared linking build tests

2022-10-17 Thread David Marchand
Save some cpu time and disk by testing linking against static and shared library in single environments. The .ci/linux-build.sh is modified so it reconfigures an existing build directory: an empty DEF_LIB= means that static and shared builds are to be tested. ABI checks, documentation generation

Re: [PATCH] net/bonding: fix descriptor limit reporting

2022-10-17 Thread Andrew Rybchenko
On 10/17/22 15:40, Chas Williams wrote: On 10/17/22 04:40, Andrew Rybchenko wrote: Chas, Cornor, could you review the patch, please. Thanks, Andrew. On 9/11/22 15:19, Ivan Malov wrote: Commit 5be3b40fea60 ("net/bonding: fix values of descriptor limits") breaks reporting of "nb_min" and "nb_al

Re: [PATCH] net/bonding: make bonded device configure method re-entrant

2022-10-17 Thread Andrew Rybchenko
On 10/17/22 15:32, Chas Williams wrote: This appears to be correct. A minor comment inline. On 10/17/22 04:42, Andrew Rybchenko wrote: Chas, Cornor, could you review the patch, please. Thanks, Andrew. On 9/11/22 15:24, Ivan Malov wrote: According to the documentation, rte_eth_dev_configure()

[Bug 1106] ipsec-secgw inline test fail

2022-10-17 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1106 Bug ID: 1106 Summary: ipsec-secgw inline test fail Product: DPDK Version: 22.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Nor

[PATCH 0/2] app/testpmd: support TCP TSO in Tx only mode

2022-10-17 Thread Andrew Rybchenko
Add command-line option to generate TSO packets with specified MSS in txonly mode. I'm not sure that it is a good idea to enable TSO offload automaticaly when the options is specified, but it is convenient. Andrew Rybchenko (2): app/testpmd: prepare to support TCP in Tx only mode app/testpmd:

[PATCH 1/2] app/testpmd: prepare to support TCP in Tx only mode

2022-10-17 Thread Andrew Rybchenko
This is useful for the incoming support of TCP TSO in Tx only mode. Signed-off-by: Georgiy Levashov Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- app/test-pmd/parameters.c | 6 +-- app/test-pmd/testpmd.h| 4 +- app/test-pmd/txonly.c | 98 +--

[PATCH 2/2] app/testpmd: support TCP TSO in Tx only mode

2022-10-17 Thread Andrew Rybchenko
Add '--txonly-tso-mss=N' option that enables TSO offload and generates packets with specified MSS in txonly mode. Signed-off-by: Georgiy Levashov Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- app/test-pmd/parameters.c | 10 + app/test-pmd/testpmd.c

rte-flow: unmatched ingress traffic default action

2022-10-17 Thread Robin Jarry
Hi Ori, all, >From what I can read in the docs in the "Isolated Mode"[1] section: > The general expectation for ingress traffic is that flow rules process > it first; the remaining unmatched or pass-through traffic usually ends > up in a queue (with or without RSS, locally or in some sub-device >

RE: [PATCH 1/3] crypto/qat: make immutable parameters constant

2022-10-17 Thread Power, Ciara
Hi Arek, > -Original Message- > From: Arek Kusztal > Sent: Wednesday 17 August 2022 07:56 > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai ; Kusztal, ArkadiuszX > > Subject: [PATCH 1/3] crypto/qat: make immutable parameters constant > > All pointers passed to functions that are not

Re: [PATCH v4] dumpcap: fix select interface

2022-10-17 Thread Stephen Hemminger
On Mon, 17 Oct 2022 05:07:52 -0700 Arshdeep Kaur wrote: > The change to do argument process before EAL init broke > the support of select-interface option. Fix by setting flag > and doing select-interface later. > > Fixes: a8dde09f97df ("app/dumpcap: allow help/version without primary > process

RE: [PATCH 4/4] eventdev: have timer adapter appropriately report idle

2022-10-17 Thread Carrillo, Erik G
> -Original Message- > From: Mattias Rönnblom > Sent: Monday, October 10, 2022 9:54 AM > To: Jayatheerthan, Jay ; Carrillo, Erik G > ; Gujjar, Abhinandan S > ; Jerin Jacob > Cc: dev@dpdk.org; Van Haaren, Harry ; > hof...@lysator.liu.se; mattias.ronnblom > Subject: [PATCH 4/4] eventdev: h

RE: [PATCH] net/nfp: set the appropriate initialized value of flbufsz

2022-10-17 Thread Nole Zhang
> On 10/15/2022 8:38 AM, Nole Zhang wrote: > > > On 10/10/2022 7:48 AM, Chaoyong He wrote: > >>> From: Peng Zhang > >>> > >>> When the testpmd app start-up with parameter max-pkt-len, it will > >>> set > >> MTU. > >>> But the initialized value of flubfsz is inappropriate, if the value > >>> of

[PATCH] net/ice: support vxlan gpe tunnel offload

2022-10-17 Thread Mingjin Ye
PMD does not support VXLAN_GPE tunnel offloading, therefore, it will cause the tx queues overflow and stop working when sending such packets. This patch adds support for the vxlan gpe. Fixes: daa02b5cddbb ("mbuf: add namespace to offload flags") Cc: sta...@dpdk.org Signed-off-by: Mingjin Ye ---

[PATCH 0/3] remove more experimental tags

2022-10-17 Thread Stephen Hemminger
Remove some of the older experimental tags for 22.11 Stephen Hemminger (3): eal: remove experimental from rte_epoll_wait_interruptible eal: make rte_log_list_types not experimental rwlock: make trylock operations no longer experimental lib/eal/include/generic/rte_rwlock.h | 12 ++-

[PATCH 2/3] eal: make rte_log_list_types not experimental

2022-10-17 Thread Stephen Hemminger
This call was added in 21.05 so time to make it stable. Signed-off-by: Stephen Hemminger --- lib/eal/include/rte_log.h | 4 lib/eal/version.map | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/eal/include/rte_log.h b/lib/eal/include/rte_log.h index 25ce42cdfc4

[PATCH 1/3] eal: remove experimental from rte_epoll_wait_interruptible

2022-10-17 Thread Stephen Hemminger
This call was added in 20.11, so time to make it not experimental. Signed-off-by: Stephen Hemminger --- lib/eal/include/rte_epoll.h | 1 - lib/eal/version.map | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/eal/include/rte_epoll.h b/lib/eal/include/rte_epoll.h i

[PATCH 3/3] rwlock: make trylock operations no longer experimental

2022-10-17 Thread Stephen Hemminger
These have been in for since 19.02, time to take off the experimental tag. Signed-off-by: Stephen Hemminger --- lib/eal/include/generic/rte_rwlock.h | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/lib/eal/include/generic/rte_rwlock.h b/lib/eal/include/generic/r

[PATCH 1/2] license/README: fix pathnames and add MIT

2022-10-17 Thread Stephen Hemminger
The pathnames in the license directory README are incorrect. The current repository puts license text in license/ not licenses/. Also, MIT license is used already in a couple of places so add the necessary entry in the README. Signed-off-by: Stephen Hemminger Acked-by: Ferruh Yigit --- license

[RFC 2/2] license: add using MIT license in base code

2022-10-17 Thread Stephen Hemminger
Many network drivers have base code which is shared from other sources. It is allowed to use MIT license in this code since that license is compatiable with BSD license. The dates need to be adjusted after final approval. Signed-off-by: Stephen Hemminger --- license/exceptions.txt | 1 + 1 file

  1   2   >