Re: [PATCH v2 1/3] net/bonding: support Tx prepare

2022-09-26 Thread Chas Williams
On 9/26/22 06:18, Konstantin Ananyev wrote: Hi everyone, Sorry for late reply. The main problem is hard to design a tx_prepare for bonding device: 1. as Chas Williams said, there maybe twice hash calc to get target slave     devices. 2. also more important, if the slave devices have cha

[PATCH v6 0/3] Add and test IPsec SA expiry events

2022-09-26 Thread Akhil Goyal
This patchset is carried forward from last release patches [1] which added test application changes to test inline IPsec. These patches were not merged due to the ABI compatibility issues due to the extension of enum. Changes in v6: fix doc build in 1/3 Changes in v5: added reference to struct wh

[PATCH v6 1/3] ethdev: add IPsec SA expiry event subtypes

2022-09-26 Thread Akhil Goyal
From: Vamsi Attunuru Patch adds new event subtypes for notifying expiry events upon reaching IPsec SA soft packet expiry and hard packet/byte expiry limits. Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal Acked-by: Thomas Monjalon --- lib/ethdev/rte_ethdev.h | 23 +++

[PATCH v6 2/3] test/security: add inline IPsec SA soft expiry cases

2022-09-26 Thread Akhil Goyal
From: Vamsi Attunuru Patch adds unit tests for packet & byte soft expiry events. Signed-off-by: Vamsi Attunuru Acked-by: Akhil Goyal --- app/test/test_cryptodev_security_ipsec.h | 2 + app/test/test_security_inline_proto.c | 105 +- app/test/test_security_inline

[PATCH v6 3/3] test/security: add inline IPsec SA hard expiry cases

2022-09-26 Thread Akhil Goyal
From: Vamsi Attunuru Patch adds hard expiry unit tests for both packet and byte limits. Signed-off-by: Vamsi Attunuru Acked-by: Akhil Goyal --- app/test/test_security_inline_proto.c | 71 +++ 1 file changed, 61 insertions(+), 10 deletions(-) diff --git a/app/test/test

RE: [PATCH v5 0/7] ethdev: separate metering and marking from policing

2022-09-26 Thread Alexander Kozyrev
> Hi Alexander, > > Thanks very much for your pseudo-code detailing the updated meter & flow > operation! > > Should we setup another call sometime next week to go through it? I still see > a few fuzzy things where we need to level set. > > Regards, > Cristian Hi Christian, do you still have qu

[PATCH v4 0/6] crypto/security session framework rework

2022-09-26 Thread Akhil Goyal
This patchset reworks the symmetric crypto and security session data structure to use a single virtual/physical contiguous buffer for symmetric crypto/security session and driver private data. In addition the session data structure is now private. The session is represented as an opaque pointer in

[PATCH v4 2/6] crypto/scheduler: use unified session

2022-09-26 Thread Akhil Goyal
From: Fan Zhang This patch updates the scheduler PMD to use unified session data structure. Previously thanks to the private session array in cryptodev sym session there are no necessary change needed for scheduler PMD other than the way ops are enqueued/dequeued. The patch inherits the same desi

[PATCH v4 4/6] security: remove priv mempool usage

2022-09-26 Thread Akhil Goyal
As per current design, rte_security_session_create() unnecessarily use 2 mempool objects for a single session. To address this, the API will now take only 1 mempool object instead of 2. With this change, the library layer will get the object from mempool and session priv data is stored contiguousl

[PATCH v4 3/6] cryptodev: hide sym session structure

2022-09-26 Thread Akhil Goyal
Structure rte_cryptodev_sym_session is moved to internal headers which are not visible to applications. The only field which should be used by app is opaque_data. This field can now be accessed via set/get APIs added in this patch. Subsequent changes in app and lib are made to compile the code. Si

[PATCH v4 5/6] drivers/crypto: support security session get size op

2022-09-26 Thread Akhil Goyal
Added the support for rte_security_op.session_get_size() in all the PMDs which support rte_security sessions and the op was not supported. Signed-off-by: Akhil Goyal Acked-by: Kai Ji Tested-by: Gagandeep Singh Tested-by: David Coyle Tested-by: Kevin O'Sullivan --- drivers/crypto/caam_jr/caam

[PATCH v4 6/6] security: hide session structure

2022-09-26 Thread Akhil Goyal
Structure rte_security_session is moved to internal headers which are not visible to applications. The only field which should be used by app is opaque_data. This field can now be accessed via set/get APIs added in this patch. Subsequent changes in app and lib are made to compile the code. Signed-

RE: [PATCH v4 0/6] crypto/security session framework rework

2022-09-26 Thread Akhil Goyal
++ Liron for mvsam. > Subject: [PATCH v4 0/6] crypto/security session framework rework > > This patchset reworks the symmetric crypto and security session > data structure to use a single virtual/physical contiguous buffer > for symmetric crypto/security session and driver private data. > In addi

RE: [dpdk-dev] [PATCH v2 2/2] net/mlx5: fix resource leak when releasing a drop action

2022-09-26 Thread Slava Ovsiienko
Hi, Yunjian We have drop action in mlx5. To create/destroy drop action we have mlx5_drop_action_create/ mlx5_drop_action_destroy common routines. As PMD supports operation either over FW (Verbs in rdma_core) or SW/HW steering with DevX objects the "virtual" methods are used for objects: priv->o

[PATCH v2 1/3] event/dlb2: add producer port probing optimization

2022-09-26 Thread Abdullah Sevincer
For best performance, applications running on certain cores should use the DLB device locally available on the same tile along with other resources. To allocate optimal resources, probing is done for each producer port (PP) for a given CPU and the best performing ports are allocated to producers. T

[PATCH v2 2/3] event/dlb2: add fence bypass option for producer ports

2022-09-26 Thread Abdullah Sevincer
If producer thread is only acting as a bridge between NIC and DLB, then performance can be greatly improved by bypassing the fence instruction. DLB enqueue API calls memory fence once per enqueue burst. If prodcuer thread is just reading from NIC and sending to DLB without updating the read buffer

[PATCH v2 3/3] event/dlb2: optimize credit allocations

2022-09-26 Thread Abdullah Sevincer
This commit implements the changes required for using suggested port type hint feature. Each port uses different credit quanta based on port type specified using port configuration flags. Each port has separate quanta defined in dlb2_priv.h Producer and consumer ports will need larger quanta value

[PATCH v3 1/3] event/dlb2: add producer port probing optimization

2022-09-26 Thread Abdullah Sevincer
For best performance, applications running on certain cores should use the DLB device locally available on the same tile along with other resources. To allocate optimal resources, probing is done for each producer port (PP) for a given CPU and the best performing ports are allocated to producers. T

[PATCH v3 2/3] event/dlb2: add fence bypass option for producer ports

2022-09-26 Thread Abdullah Sevincer
If producer thread is only acting as a bridge between NIC and DLB, then performance can be greatly improved by bypassing the fence instruction. DLB enqueue API calls memory fence once per enqueue burst. If prodcuer thread is just reading from NIC and sending to DLB without updating the read buffer

[PATCH v3 3/3] event/dlb2: optimize credit allocations

2022-09-26 Thread Abdullah Sevincer
This commit implements the changes required for using suggested port type hint feature. Each port uses different credit quanta based on port type specified using port configuration flags. Each port has separate quanta defined in dlb2_priv.h Producer and consumer ports will need larger quanta value

[PATCH v1] doc: update DLB2 documentation

2022-09-26 Thread Abdullah Sevincer
This commit updates the dlb2.rst eventdev guide to document a new devarg. A new devarg: "default_port_allocation" added to allow default ldb port allocation scheme. Signed-off-by: Abdullah Sevincer --- doc/guides/eventdevs/dlb2.rst | 19 +++ 1 file changed, 19 insertions(+) diff

[PATCH v2] doc: update DLB2 documentation

2022-09-26 Thread Abdullah Sevincer
This commit updates the dlb2.rst eventdev guide to document a new devarg. A new devarg: "default_port_allocation" added to allow default ldb port allocation scheme. Signed-off-by: Abdullah Sevincer --- doc/guides/eventdevs/dlb2.rst | 19 +++ 1 file changed, 19 insertions(+) diff

[PATCH v3] doc: update DLB2 documentation

2022-09-26 Thread Abdullah Sevincer
This commit updates the dlb2.rst eventdev guide to document a new devarg. A new devarg: "default_port_allocation" added to allow default ldb port allocation scheme. Signed-off-by: Abdullah Sevincer --- doc/guides/eventdevs/dlb2.rst | 19 +++ 1 file changed, 19 insertions(+) diff

[PATCH v4 1/3] event/dlb2: add producer port probing optimization

2022-09-26 Thread Abdullah Sevincer
For best performance, applications running on certain cores should use the DLB device locally available on the same tile along with other resources. To allocate optimal resources, probing is done for each producer port (PP) for a given CPU and the best performing ports are allocated to producers. T

[PATCH v4 2/3] event/dlb2: add fence bypass option for producer ports

2022-09-26 Thread Abdullah Sevincer
If producer thread is only acting as a bridge between NIC and DLB, then performance can be greatly improved by bypassing the fence instruction. DLB enqueue API calls memory fence once per enqueue burst. If prodcuer thread is just reading from NIC and sending to DLB without updating the read buffer

[PATCH v4 3/3] event/dlb2: optimize credit allocations

2022-09-26 Thread Abdullah Sevincer
This commit implements the changes required for using suggested port type hint feature. Each port uses different credit quanta based on port type specified using port configuration flags. Each port has separate quanta defined in dlb2_priv.h Producer and consumer ports will need larger quanta value

RE: [PATCH] net/ice: check process type in reset operation

2022-09-26 Thread Zhang, Qi Z
> -Original Message- > From: Yang, Qiming > Sent: Monday, September 26, 2022 9:44 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > > Subject: [PATCH] net/ice: check process type in reset operation > > The secondary processes are not allowed to release shared resources. > so th

RE: [PATCH v2] net/iavf: fix TSO offload for tunnel case

2022-09-26 Thread Zhang, Qi Z
> -Original Message- > From: Zeng, ZhichaoX > Sent: Monday, September 26, 2022 1:17 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhou, YidingX > ; Zhang, Qi Z ; Zeng, > ZhichaoX ; Wu, Jingjing ; > Xing, Beilei ; Sinha, Abhijit > ; > Doherty, Declan ; Nicolau, Radu > > Subject: [PATCH v2

[PATCH v2 0/3] Direct re-arming of buffers on receive side

2022-09-26 Thread Feifei Wang
Currently, the transmit side frees the buffers into the lcore cache and the receive side allocates buffers from the lcore cache. The transmit side typically frees 32 buffers resulting in 32*8=256B of stores to lcore cache. The receive side allocates 32 buffers and stores them in the receive side so

[PATCH v2 1/3] ethdev: add API for direct rearm mode

2022-09-26 Thread Feifei Wang
Add API for enabling direct rearm mode and for mapping RX and TX queues. Currently, the API supports 1:1(txq : rxq) mapping. Furthermore, to avoid Rx load Tx data directly, add API called 'rte_eth_txq_data_get' to get Tx sw_ring and its information. Suggested-by: Honnappa Nagarahalli Suggested-b

[PATCH v2 2/3] net/i40e: enable direct rearm mode

2022-09-26 Thread Feifei Wang
For i40e driver, enable direct re-arm mode. This patch supports the case of mapping Rx/Tx queues from the same single lcore. Suggested-by: Honnappa Nagarahalli Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- drivers/net/i40e/i40e_ethdev.c| 1

[PATCH v2 3/3] examples/l3fwd: enable direct rearm mode

2022-09-26 Thread Feifei Wang
Enable direct rearm mode in l3fwd. Users can use parameters: '--direct-rearm=(rx_portid,rx_queueid,tx_portid,tx_queueid)' to enable direct rearm. Suggested-by: Honnappa Nagarahalli Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- examples/l3fwd/l3fwd.

Re: [EXT] Re: [PATCH] event/cnxk: fix stale data in workslots

2022-09-26 Thread Jerin Jacob
On Wed, Sep 21, 2022 at 1:31 PM Pavan Nikhilesh Bhagavatula wrote: > > > > > -Original Message- > > From: Jerin Jacob > > Sent: Tuesday, September 13, 2022 8:06 PM > > To: Pavan Nikhilesh Bhagavatula > > Cc: Jerin Jacob Kollanukkaran ; Shijith Thotton > > ; dev@dpdk.org; sta...@dpdk.org

RE: [PATCH v4 0/6] crypto/security session framework rework

2022-09-26 Thread Ruifeng Wang
> -Original Message- > From: Akhil Goyal > Sent: Tuesday, September 27, 2022 3:14 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; hemant.agra...@nxp.com; > vattun...@marvell.com; ferruh.yi...@xilinx.com; andrew.rybche...@oktetlabs.ru; > konstantin.v.anan...@yand

[v2 1/7] examples/fips_validation: fix parsing test group info

2022-09-26 Thread Gowrishankar Muthukrishnan
If a test group does not have expected key, it should not crash. This patch fixes parsing test group info to continue further when a key does not exist (as in asym tests). Fixes: 58cc98801eb ("examples/fips_validation: add JSON parsing") Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian

[v2 2/7] examples/fips_validation: add interim parse writeback

2022-09-26 Thread Gowrishankar Muthukrishnan
Asym tests need a callback to write interim info in expected output. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian Dooley --- examples/fips_validation/fips_validation.c | 6 ++ examples/fips_validation/fips_validation.h | 1 + 2 files changed, 7 insertions(+) diff --git a/examp

[v2 3/7] examples/fips_validation: add function to calculate SHA hash size

2022-09-26 Thread Gowrishankar Muthukrishnan
Add function to calculate hash size for a given SHA hash algorithm. Fixes: d5c247145c2 ("examples/fips_validation: add parsing for SHA") Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian Dooley --- v2: - fixed include file --- examples/fips_validation/fips_validation.h| 1 + ...

[v2 4/7] examples/fips_validation: fix buffer size to parse JSON string

2022-09-26 Thread Gowrishankar Muthukrishnan
In asym op, while parsing test interim info, existing buffer of size 256 bytes is not sufficient, hence setting it to maximum that a test would need. Fixes: 58cc98801eb ("examples/fips_validation: add JSON parsing") Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian Dooley --- examples/

[v2 5/7] examples/fips_validation: add asymmetric validation

2022-09-26 Thread Gowrishankar Muthukrishnan
Add support for asymmetric crypto validation starting with RSA. For the generation of crypto values which is multiprecision in math, openssl library is used only for this purpose. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Brian Dooley -- v2: - improved handling priv key type. --- co

[v2 6/7] examples/fips_validation: encode digest with hash OID

2022-09-26 Thread Gowrishankar Muthukrishnan
FIPS RSA validation requires hash ddigest be encoded with ASN.1 value for digest info. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/main.c | 78 + 1 file changed, 78 insertions(+) diff --git a/examples/fips_validation/main.c b/examples/f

[v2 7/7] examples/fips_validation: randomize message for conformance test

2022-09-26 Thread Gowrishankar Muthukrishnan
FIPS conformance tests require randomizing message based on SP 800-106. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation.h| 4 + .../fips_validation/fips_validation_rsa.c | 112 +- 2 files changed, 115 insertions(+), 1 deletion(-)

RE: [PATCH v2] net/mlx5: use just sufficient barrier for Arm platforms

2022-09-26 Thread Slava Ovsiienko
Hi, Honnappa We discussed the barrier here: http://patches.dpdk.org/project/dpdk/patch/20210606164948.35997-1-honnappa.nagaraha...@arm.com/ (BTW, it is good practice to keep the reference to previous patch versions below Commit Message of the next ones). This barrier is not about compiler order

[PATCH] examples/pipeline: fix file close

2022-09-26 Thread Harshad Narayane
Coverity issue: 380860 Fixes: 9043f66a ("examples/pipeline: add command for code generation") Fix file close at pipeline code generation. Signed-off-by: Harshad Narayane Signed-off-by: Kamalakannan R Acked-by: Cristian Dumitrescu --- examples/pipeline/cli.c | 1 + 1 file changed, 1 insertion(

[PATCH] examples/pipeline: fix file close

2022-09-26 Thread Harshad Narayane
Coverity issue: 380860 Fixes: 9043f66a ("examples/pipeline: add command for code generation") Fix file close at pipeline code generation. Signed-off-by: Harshad Narayane Signed-off-by: Kamalakannan R Acked-by: Cristian Dumitrescu --- examples/pipeline/cli.c | 1 + 1 file changed, 1 insertion(

<    1   2