[PATCH v3] eal: update lcore-worker name due to high number of cores

2022-09-23 Thread Abdullah Ömer Yamaç
In this patch we suggest a new name for lcore-worker. In case of more than 99 logical cores, name is truncated (length is restricted to 16 characters, including the terminating null byte ('\0')) and it makes hard to follow threads. Signed-off-by: Abdullah Ömer Yamaç Acked-by: Stephen Hemminger

Re: [RFC v3 00/26] Bus and device cleanup for 22.11

2022-09-23 Thread David Marchand
On Thu, Sep 22, 2022 at 12:29 AM Harris, James R wrote: > > On Aug 30, 2022, at 8:09 AM, David Marchand > > wrote: > > > > On Mon, Aug 29, 2022 at 7:12 PM Walker, Benjamin > > wrote: > Can we keep rte_pci_register(), or a new variation of it that keeps > the rte_pci_driver structure h

RE: [PATCH v4 4/9] dts: add ssh pexpect library

2022-09-23 Thread Juraj Linkeš
> -Original Message- > From: Stanislaw Kardach > Sent: Thursday, September 22, 2022 4:32 PM > To: Juraj Linkeš > Cc: tho...@monjalon.net; david.march...@redhat.com; > ronan.rand...@intel.com; honnappa.nagaraha...@arm.com; > ohily...@iol.unh.edu; lijuan...@intel.com; dev@dpdk.org > Subje

Re: [PATCH v1] ethdev: add direction info when creating the transfer table

2022-09-23 Thread Andrew Rybchenko
Hi Ori, On 9/22/22 16:00, Ori Kam wrote: Hi Andrew, -Original Message- From: Andrew Rybchenko Sent: Thursday, 22 September 2022 13:31 On 9/22/22 13:06, Ori Kam wrote: Hi Andrew, -Original Message- From: Andrew Rybchenko Sent: Thursday, 22 September 2022 10:39 On 9/21/22

RE: [EXT] [PATCH 3/8] trace: fix leak with regexp

2022-09-23 Thread Sunil Kumar Kori
> -Original Message- > From: David Marchand > Sent: Friday, September 23, 2022 12:05 PM > To: Sunil Kumar Kori > Cc: dev@dpdk.org; sta...@dpdk.org; Jerin Jacob Kollanukkaran > > Subject: Re: [EXT] [PATCH 3/8] trace: fix leak with regexp > > On Thu, Sep 22, 2022 at 1:00 PM Sunil Kumar Ko

[PATCH v4 0/3] support ethdev Rx/Tx descriptor dump

2022-09-23 Thread Dongdong Liu
Support ethdev Rx/Tx descriptor dump by using procinfo tool. Note: '[PATCH v4 1/3] net/hns3: support Rx/Tx bd dump' depend on [1] applied first. Hope patchset [1] can be applied soon. [1]: [PATCH RESEND 00/13] some bugfixes and clean code for hns3 https://patches.dpdk.org/project/dpdk/list/?serie

[PATCH v4 2/3] net/hns3: support Rx/Tx bd dump

2022-09-23 Thread Dongdong Liu
From: "Min Hu (Connor)" This patch support query HW descriptor from hns3 device. HW descriptor is also called BD(buffer description) which is shared memory between software and hardware. Signed-off-by: Min Hu (Connor) Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_dump.c | 80

[PATCH v4 3/3] app/procinfo: support descriptor dump

2022-09-23 Thread Dongdong Liu
From: "Min Hu (Connor)" This patch support HW Rx/Tx descriptor dump The command is like: dpdk-proc-info -a :xx:xx.x --file-prefix=xxx -- -- --show-rx-descriptor queue_id:num dpdk-proc-info -a :xx:xx.x --file-prefix=xxx -- -- --show-tx-descriptor queue_id:num Signed-off-by: Min Hu (Conn

[PATCH v4 1/3] ethdev: introduce ethdev desc dump API

2022-09-23 Thread Dongdong Liu
From: "Min Hu (Connor)" Added the ethdev Rx/Tx desc dump API which provides functions for query descriptor from device. HW descriptor info differs in different NICs. The information demonstrates I/O process which is important for debug. As the information is different between NICs, the new API is

RE: DPDK with i225/226 on elkhartlake

2022-09-23 Thread Yang, Qiming
Hi, Sam We don't support I225-IT in 22.07 release, you can update you code to the latest next-net-intel branch, it contain the fix. But for i226v's log, I don't see any issue, seems 06:00.0 init success. Could you clarify it? Qiming > -Original Message- > From: SamChen 陳嘉良 > Sent: Thur

RE: [PATCH v3 6/7] app/procinfo: fix some wrong doxygen syntax

2022-09-23 Thread Pattan, Reshma
> -Original Message- > From: Dongdong Liu > Sent: Wednesday, September 21, 2022 3:27 PM > To: dev@dpdk.org; Pattan, Reshma ; > tho...@monjalon.net; ferruh.yi...@xilinx.com; > andrew.rybche...@oktetlabs.ru > Cc: Dongdong Liu ; Maryam Tahhan > > Subject: [PATCH v3 6/7] app/procinfo: fix

Re: [PATCH v4 4/9] dts: add ssh pexpect library

2022-09-23 Thread Bruce Richardson
On Fri, Sep 23, 2022 at 07:22:26AM +, Juraj Linkeš wrote: > > > > -Original Message- > > From: Stanislaw Kardach > > Sent: Thursday, September 22, 2022 4:32 PM > > To: Juraj Linkeš > > Cc: tho...@monjalon.net; david.march...@redhat.com; > > ronan.rand...@intel.com; honnappa.nagaraha

Re: [PATCH v3] eal: Pointer alignment check improvements

2022-09-23 Thread Bruce Richardson
On Thu, Sep 22, 2022 at 10:54:38PM +0200, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Thursday, 22 September 2022 15.39 > > > > On Thu, Sep 22, 2022 at 03:27:30PM +0200, Morten Brørup wrote: > > > Checking a const pointer for alignment would emit a

Re: [PATCH v2] eal: Pointer alignment check improvements

2022-09-23 Thread Bruce Richardson
On Thu, Sep 22, 2022 at 01:44:13PM +0200, Morten Brørup wrote: > Checking a const pointer for alignment would emit a warning about the > const qualifier being discarded. > > No need to calculate the aligned pointer; just check the last bits of the > pointer. > > v2: > - Remove compiler attribute

[PATCH] gpu/cuda: fix build

2022-09-23 Thread Thomas Monjalon
A recent commit removed errno.h from rte_common.h. It has to be added in various places where it is used, and wad implicitly included via rte_common.h, but was forgotten in gpu/cuda. As a result, the compilation is broken: drivers/gpu/cuda/gdrcopy.c:116:17: error: ‘ENOTSUP’ undeclared Not

Re: [PATCH v4 08/14] baseband/acc: add LDPC processing functions

2022-09-23 Thread Maxime Coquelin
Hi Nicolas, I'm finishing reviewing this patch from v4 as I was in the middle of the review when you posted v5. Will continue the other ones on v5. On 9/22/22 02:27, Nic Chautru wrote: Adding LDPC encode and decode processing functions. Signed-off-by: Nic Chautru --- drivers/baseband/acc/ac

Re: [PATCH] gpu/cuda: fix build

2022-09-23 Thread David Marchand
On Fri, Sep 23, 2022 at 10:26 AM Thomas Monjalon wrote: > > A recent commit removed errno.h from rte_common.h. > It has to be added in various places where it is used, > and wad implicitly included via rte_common.h, was* > but was forgotten in gpu/cuda. > > As a result, the compilation is broken

Re: [PATCH] gpu/cuda: fix build

2022-09-23 Thread David Marchand
On Fri, Sep 23, 2022 at 10:29 AM David Marchand wrote: > > On Fri, Sep 23, 2022 at 10:26 AM Thomas Monjalon wrote: > > > > A recent commit removed errno.h from rte_common.h. > > It has to be added in various places where it is used, > > and wad implicitly included via rte_common.h, > > was* > > >

Re: [RFC PATCH 11/11] bus: hide bus object

2022-09-23 Thread David Marchand
On Sat, Jul 9, 2022 at 6:28 PM Stephen Hemminger wrote: > > > > > > > to avoid people tripping over mishandling pointers in/out of the > > > > > > > api > > > > > > > surface taking the opaque object you could declare opaque handle > > > > > > > for the > > > > > > > api to operate on instead. i

Re: [RFC PATCH 11/11] bus: hide bus object

2022-09-23 Thread Thomas Monjalon
23/09/2022 10:49, David Marchand: > On Sat, Jul 9, 2022 at 6:28 PM Stephen Hemminger > wrote: > > > For now, I'll post a v2, extending the series to other internal objects. > > > We can conclude on this topic during 22.11. > > > > If you get chance to deconstruct API, switching to a numeric index

RE: [PATCH v3 7/7] doc: add some extended features in procinfo guide

2022-09-23 Thread Pattan, Reshma
> -Original Message- > From: Dongdong Liu > Signed-off-by: Dongdong Liu Acked-by: Reshma Pattan

Re: [PATCH v4 09/14] baseband/acc: add LTE processing functions

2022-09-23 Thread Maxime Coquelin
On 9/22/22 02:27, Nic Chautru wrote: Add functions and capability for 4G FEC Signed-off-by: Nic Chautru --- drivers/baseband/acc/rte_acc200_pmd.c | 894 +- 1 file changed, 874 insertions(+), 20 deletions(-) diff --git a/drivers/baseband/acc/rte_acc200_pmd.

Re: [PATCH v4 10/14] baseband/acc: add support for FFT operations

2022-09-23 Thread Maxime Coquelin
On 9/22/22 02:27, Nic Chautru wrote: Add functions and capability for FFT processing Signed-off-by: Nic Chautru --- drivers/baseband/acc/rte_acc200_pmd.c | 251 +- 1 file changed, 249 insertions(+), 2 deletions(-) diff --git a/drivers/baseband/acc/rte_acc2

RE: [PATCH v3 1/7] app/procinfo: add dpdk version dump

2022-09-23 Thread Pattan, Reshma
> -Original Message- > From: Dongdong Liu > Subject: [PATCH v3 1/7] app/procinfo: add dpdk version dump > Add support for dump dpdk version. > > The command is like: > dpdk-proc-info -a :xx:xx.x --file-prefix=xxx -- --version > > Signed-off-by: Min Hu (Connor) > Signed-off-by: Do

[PATCH] replace Mellanox with NVIDIA

2022-09-23 Thread Thomas Monjalon
NVIDIA acquired Mellanox Technologies in 2020. The DPDK documentation and code might still include instances of or references to Mellanox trademarks (like BlueField and ConnectX) that are now NVIDIA trademarks. The PCI IDs and copyrights are unchanged. Signed-off-by: Thomas Monjalon --- MAINTAI

Re: [PATCH v4 11/14] baseband/acc: support interrupt

2022-09-23 Thread Maxime Coquelin
On 9/22/22 02:27, Nic Chautru wrote: Adding support for capability and functions for MSI/MSI-X interrupt and underlying information ring. Signed-off-by: Nic Chautru --- drivers/baseband/acc/rte_acc200_pmd.c | 346 +- 1 file changed, 344 insertions(+), 2 del

RE: [PATCH v3 2/7] app/procinfo: add firmware version dump

2022-09-23 Thread Pattan, Reshma
> -Original Message- > From: Dongdong Liu > Subject: [PATCH v3 2/7] app/procinfo: add firmware version dump > > Add support for dump ethdev firmware version. > > The command is like: > dpdk-proc-info -a :xx:xx.x --file-prefix=xxx -- --firmware-version > > Signed-off-by: Min Hu (C

Re: [PATCH v4 12/14] baseband/acc: add device status and vf2pf comms

2022-09-23 Thread Maxime Coquelin
On 9/22/22 02:27, Nic Chautru wrote: Add support to expose the device status seen from the host through v2pf mailbox communication. Signed-off-by: Nic Chautru --- drivers/baseband/acc/rte_acc200_pmd.c | 61 +-- 1 file changed, 44 insertions(+), 17 deletions

[PATCH] examples/ipsec-secgw: free event vector mbufs

2022-09-23 Thread Rahul Bhansali
Free mbufs from event vector list when enqueue operation fails and during event port flush for cleanup. Signed-off-by: Rahul Bhansali --- examples/ipsec-secgw/ipsec_worker.c | 34 + 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/examples/ipsec-secgw/ip

Re: [PATCH v4 13/14] baseband/acc: add PF configure companion function

2022-09-23 Thread Maxime Coquelin
On 9/22/22 02:27, Nic Chautru wrote: Add configure function notably to configure the device from the PF within DPDK and bbdev-test (without external dependency). Signed-off-by: Nic Chautru --- app/test-bbdev/test_bbdev_perf.c | 71 ++ drivers/baseband/acc/meson.build | 2

RE: [PATCH v2 0/6] crypto/security session framework rework

2022-09-23 Thread Gagandeep Singh
Hi Akhil, We have verified this patch series on DPAA1 and DPAA2 platforms using test and ipsec-secgw applications. Series Tested-by: Gagandeep Singh Regards, Gagan > -Original Message- > From: Akhil Goyal > Sent: Wednesday, September 21, 2022 8:33 PM > To: dev@dpdk.org > Cc: tho...@m

RE: [dpdk-dev] [PATCH v2 1/2] net/mlx5: fix use after free when releasing tx queues

2022-09-23 Thread wangyunjian
Friendly ping. > -Original Message- > From: wangyunjian > Sent: Tuesday, August 23, 2022 2:46 PM > To: dev@dpdk.org > Cc: ma...@nvidia.com; rasl...@nvidia.com; viachesl...@nvidia.com; > dkozl...@nvidia.com; Huangshaozhang ; > wangyunjian ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2 1/

RE: [dpdk-dev] [PATCH v2 2/2] net/mlx5: fix resource leak when releasing a drop action

2022-09-23 Thread wangyunjian
Friendly ping. > -Original Message- > From: wangyunjian > Sent: Tuesday, August 23, 2022 2:46 PM > To: dev@dpdk.org > Cc: ma...@nvidia.com; rasl...@nvidia.com; viachesl...@nvidia.com; > dkozl...@nvidia.com; Huangshaozhang ; > wangyunjian ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2 2/

RE: [PATCH v2 03/10] net/gve: support device initialization

2022-09-23 Thread Guo, Junfeng
> -Original Message- > From: Ferruh Yigit > Sent: Friday, September 2, 2022 01:22 > To: Guo, Junfeng ; Zhang, Qi Z > ; Wu, Jingjing > Cc: dev@dpdk.org; Li, Xiaoyun ; > awogbem...@google.com; Richardson, Bruce > ; Wang, Haiyue > Subject: Re: [PATCH v2 03/10] net/gve: support device ini

RE: [PATCH v2 04/10] net/gve: add link update support

2022-09-23 Thread Guo, Junfeng
> -Original Message- > From: Ferruh Yigit > Sent: Friday, September 2, 2022 01:23 > To: Guo, Junfeng ; Zhang, Qi Z > ; Wu, Jingjing > Cc: dev@dpdk.org; Li, Xiaoyun ; > awogbem...@google.com; Richardson, Bruce > > Subject: Re: [PATCH v2 04/10] net/gve: add link update support > > On 8/

RE: [PATCH v2 08/10] net/gve: add support to get dev info and configure dev

2022-09-23 Thread Guo, Junfeng
> -Original Message- > From: Ferruh Yigit > Sent: Friday, September 2, 2022 01:24 > To: Guo, Junfeng ; Zhang, Qi Z > ; Wu, Jingjing > Cc: dev@dpdk.org; Li, Xiaoyun ; > awogbem...@google.com; Richardson, Bruce > > Subject: Re: [PATCH v2 08/10] net/gve: add support to get dev info and >

RE: [PATCH v2 09/10] net/gve: add stats support

2022-09-23 Thread Guo, Junfeng
> -Original Message- > From: Ferruh Yigit > Sent: Friday, September 2, 2022 01:24 > To: Guo, Junfeng ; Zhang, Qi Z > ; Wu, Jingjing > Cc: dev@dpdk.org; Li, Xiaoyun ; > awogbem...@google.com; Richardson, Bruce > > Subject: Re: [PATCH v2 09/10] net/gve: add stats support > > On 8/29/202

[PATCH v3 0/9] introduce GVE PMD

2022-09-23 Thread Junfeng Guo
Introduce a new PMD for Google Virtual Ethernet (GVE). This patch set requires an exception for MIT license for GVE base code. And the base code includes the following files: - gve_adminq.c - gve_adminq.h - gve_desc.h - gve_desc_dqo.h - gve_register.h It's based on GVE kernel driver v1.3.0 a

[PATCH v3 1/9] net/gve: introduce GVE PMD base code

2022-09-23 Thread Junfeng Guo
The following base code is based on Google Virtual Ethernet (gve) driver v1.3.0 under MIT license. - gve_adminq.c - gve_adminq.h - gve_desc.h - gve_desc_dqo.h - gve_register.h - gve.h The original code is in: https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-linux/\ tree/v1.3.0

[PATCH v3 2/9] net/gve: add logs and OS specific implementation

2022-09-23 Thread Junfeng Guo
Add GVE PMD logs. Add some MACRO definitions and memory operations which are specific for DPDK. Signed-off-by: Haiyue Wang Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- drivers/net/gve/gve_adminq.h | 2 + drivers/net/gve/gve_desc.h | 2 + drivers/net/gve/gve_desc_dqo.h |

[PATCH v3 4/9] net/gve: add link update support

2022-09-23 Thread Junfeng Guo
Support dev_ops link_update. Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- doc/guides/nics/features/gve.ini | 2 ++ drivers/net/gve/gve_ethdev.c | 30 ++ 2 files changed, 32 insertions(+) diff --git a/doc/guides/nics/features/gve.ini b/doc/guides/nic

[PATCH v3 3/9] net/gve: support device initialization

2022-09-23 Thread Junfeng Guo
Support device init and the fowllowing devops: - dev_configure - dev_start - dev_stop - dev_close Signed-off-by: Haiyue Wang Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- MAINTAINERS| 6 + doc/guides/nics/features/gve.ini | 10 + doc/guides/nics/

[PATCH v3 5/9] net/gve: add MTU set support

2022-09-23 Thread Junfeng Guo
Support dev_ops mtu_set. Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- doc/guides/nics/features/gve.ini | 1 + drivers/net/gve/gve_ethdev.c | 29 + 2 files changed, 30 insertions(+) diff --git a/doc/guides/nics/features/gve.ini b/doc/guides/nics/feat

[PATCH v3 6/9] net/gve: add queue operations

2022-09-23 Thread Junfeng Guo
Add support for queue operations: - setup rx/tx queue - release rx/tx queue - start rx/tx queues - stop rx/tx queues Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- drivers/net/gve/gve_ethdev.c | 206 + drivers/net/gve/gve_ethdev.h | 47 driver

[PATCH v3 7/9] net/gve: add Rx/Tx support

2022-09-23 Thread Junfeng Guo
Add Rx/Tx of GQI_QPL queue format and GQI_RDA queue format. Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- doc/guides/nics/features/gve.ini | 2 + drivers/net/gve/gve_ethdev.c | 5 + drivers/net/gve/gve_ethdev.h | 16 ++ drivers/net/gve/gve_rx.c | 143 ++

[PATCH v3 8/9] net/gve: add support to get dev info and configure dev

2022-09-23 Thread Junfeng Guo
Add dev_ops dev_infos_get. Complete dev_configure with RX offloads configuration. Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- doc/guides/nics/features/gve.ini | 1 + drivers/net/gve/gve_ethdev.c | 63 2 files changed, 64 insertions(+) diff --g

[PATCH v3 9/9] net/gve: add stats support

2022-09-23 Thread Junfeng Guo
Update stats add support of dev_ops stats_get/reset. Signed-off-by: Xiaoyun Li Signed-off-by: Junfeng Guo --- doc/guides/nics/features/gve.ini | 2 + drivers/net/gve/gve_ethdev.c | 71 drivers/net/gve/gve_ethdev.h | 12 ++ drivers/net/gve/gve_rx.c

RE: [PATCH v3 3/7] app/procinfo: add RSS RETA dump

2022-09-23 Thread Pattan, Reshma
> -Original Message- > From: Dongdong Liu > Subject: [PATCH v3 3/7] app/procinfo: add RSS RETA dump > > From: "Min Hu (Connor)" > > This patch add support for RSS reta dump. > > The command is like: > dpdk-proc-info -a :xx:xx.x --file-prefix=xxx -- --show-rss-reta > > Signed-of

RE: [PATCH v3 4/7] app/procinfo: add module info dump

2022-09-23 Thread Pattan, Reshma
> -Original Message- > From: Dongdong Liu > Subject: [PATCH v3 4/7] app/procinfo: add module info dump > > From: "Min Hu (Connor)" > > This patch add support for module info dump. > > The command is like: > dpdk-proc-info -a :xx:xx.x --file-prefix=xxx -- --show-module-info You

RE: [PATCH v3 5/7] app/procinfo: add dump of Rx/Tx burst mode

2022-09-23 Thread Pattan, Reshma
> -Original Message- > From: Dongdong Liu > Subject: [PATCH v3 5/7] app/procinfo: add dump of Rx/Tx burst mode > > Signed-off-by: Jie Hai > Signed-off-by: Dongdong Liu > --- > + if (rte_eth_rx_burst_mode_get(i, j, &mode) == 0) > + pri

Re: [PATCH v4 4/9] dts: add ssh pexpect library

2022-09-23 Thread Stanislaw Kardach
On Fri, Sep 23, 2022 at 09:15:07AM +0100, Bruce Richardson wrote: > On Fri, Sep 23, 2022 at 07:22:26AM +, Juraj Linkeš wrote: > > > > Absolutely, but effective time use is also something to consider. Our > > current plan doesn't won't really have to contend with problems in the > > future,

Re: [PATCH] eal: make eal_parse_coremask external

2022-09-23 Thread David Marchand
Hello Abdullah, On Thu, Sep 15, 2022 at 5:39 AM Abdullah Sevincer wrote: > > DLB2 has a need to parse a user supplied coremask as part > of an optimization that associates optimal core/resource > pairs. Therefore eal_parse_coremask has been renamed > to rte_eal_parse_coremask and exported. Plea

Re: [EXT] [PATCH v7 6/7] bbdev: add queue related warning and status information

2022-09-23 Thread Ferruh Yigit
On 9/21/2022 8:21 PM, Akhil Goyal wrote: diff --git a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev.h index ed528b8..b7ecf94 100644 --- a/lib/bbdev/rte_bbdev.h +++ b/lib/bbdev/rte_bbdev.h @@ -224,6 +224,19 @@ struct rte_bbdev_queue_conf { rte_bbdev_queue_stop(uint16_t dev_id, uint16_t queue_id);

[Bug 1084] Convert MBOX file to PST for Outlook Platform

2022-09-23 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1084 Bug ID: 1084 Summary: Convert MBOX file to PST for Outlook Platform Product: DPDK Version: 17.02 Hardware: All URL: https://www.mailsdaddy.com/mbox-to-pst-converter/ OS:

Re: DPDK 19.11.5 Legacy Memory Design Query

2022-09-23 Thread Umakiran Godavarthi (ugodavar)
Hi Dmitry My answer for your reply You unmap memory, but you do not maintain DPDK memory management structures, that is, DPDK does not know that this page is no longer usable. Probably this is the reason for the crash. You could print regions you're unmapping and the segfault address to confirm.

[PATCH v2] examples/ipsec-secgw: free event vector mbufs

2022-09-23 Thread Rahul Bhansali
Free mbufs from event vector list when enqueue operation fails and during event port flush for cleanup. Signed-off-by: Rahul Bhansali --- v2: Added dependent series info. Depends-on: series-24761 ("[v2,1/3] eventdev: add element offset to event vector") examples/ipsec-secgw/ipsec_worker.c | 3

Re: From: Nic Chautru

2022-09-23 Thread Maxime Coquelin
Hi Nicolas, I'm done with v4 review. Please post a v6, I don't plan to review v5 that was posted while I was in the middle of my review. Thanks, Maxime On 9/22/22 02:27, Nic Chautru wrote: v4: Rebase to split the first commit and change the order within the series based on Maxime's feedback.

RE: [RFT] dumpcap: add file-prefix option

2022-09-23 Thread Kaur, Arshdeep
++ Balaji and Mike. > -Original Message- > From: Kaur, Arshdeep > Sent: Friday, September 16, 2022 1:49 PM > To: Stephen Hemminger ; dev@dpdk.org > Subject: RE: [RFT] dumpcap: add file-prefix option > > > > > -Original Message- > > From: Stephen Hemminger > > Sent: Tuesday, Se

Re: DPDK 19.11.5 Legacy Memory Design Query

2022-09-23 Thread Dmitry Kozlyuk
2022-09-23 11:20 (UTC+), Umakiran Godavarthi (ugodavar): > [Uma] : Yes we are unmapping the entire range hoping all are free inside > DPDK and DPDK heaps never use these pages. > > Suppose we have 400 pages total free_hp, we want only 252 pages , so we > reduce nr_pages to 252. > > So we

Re: [PATCH 0/4] pipeline: support large structure fields

2022-09-23 Thread Thomas Monjalon
12/08/2022 11:54, Cristian Dumitrescu: > This patch set adds support for structure fields bigger than 64 bits. > These fields can be packet header or meta-data fields. They can be > used as part of the table lookup key or as action arguments. They are > now valid operands for the move instruction.

Re: DPDK 19.11.5 Legacy Memory Design Query

2022-09-23 Thread Umakiran Godavarthi (ugodavar)
Thanks Dmitry for quick turn around Yes below are my answers There still DPDK malloc internal structures that you cannot adjust. I suggest going another way: Instead of letting DPDK allocate all hugepages and unmapping some, allow DPDK to allocate an absolute minimum (1 x 2MB page?) and add all

RE: [PATCH v4 3/3] app/procinfo: support descriptor dump

2022-09-23 Thread Pattan, Reshma
> -Original Message- > From: Dongdong Liu > Subject: [PATCH v4 3/3] app/procinfo: support descriptor dump > > From: "Min Hu (Connor)" > > This patch support HW Rx/Tx descriptor dump > > The command is like: > dpdk-proc-info -a :xx:xx.x --file-prefix=xxx -- -- --show-rx-descripto

RE: [PATCH v2 0/6] crypto/security session framework rework

2022-09-23 Thread Coyle, David
Hi Akhil/Fan Patchset verified for QAT and AESNI_MB sessions, with particular focus on Security Cipher-CRC For the series, Tested-by: David Coyle Tested-by: Kevin O'Sullivan Regards, David > -Original Message- > From: Akhil Goyal > Sent: Wednesday, September 21, 2022 4:11 PM > To: A

O/S noise histogram

2022-09-23 Thread Morten Brørup
Dear DPDK community, We have been using the code below to measure O/S noise affecting our data plane threads, so we can tune the kernel parameters. The measurement method is based on dedicating an lcore to run the experimental_thread() function, which repeatedly reads the TSC and stores the dif

Re: DPDK 19.11.5 Legacy Memory Design Query

2022-09-23 Thread Dmitry Kozlyuk
2022-09-23 12:12 (UTC+), Umakiran Godavarthi (ugodavar): > [Uma] : Yes I agree if free_hp = 400, nr_hp = 252, we are expecting DPDK > takes only 252 and keep the remaining pages free in its heap. >As you have mentioned just boot DPDK with 1 page, and add > pages we want late

Re: [PATCH v4 2/3] l3fwd-power: add option to call uncore API

2022-09-23 Thread Hunt, David
On 20/09/2022 10:48, Tadhg Kearney wrote: Add option for setting uncore frequency min/max/index, through uncore API. This will be set for each package and die on the SKU. On exit, uncore min and max frequency will be reverted back to previous frequencies. Signed-off-by: Tadhg Kearney --- ..

Re: [PATCH v4 1/3] power: add uncore frequency control API to the power library

2022-09-23 Thread Hunt, David
On 20/09/2022 10:48, Tadhg Kearney wrote: Add API to allow uncore frequency adjustment. This is done through manipulating related uncore frequency control sysfs entries to adjust the minimum and maximum uncore frequency values. Nine API's are being added that are all public and experimental. S

Re: [PATCH v4 3/3] test/power: add unit tests for uncore API

2022-09-23 Thread Hunt, David
Hi Tadhg, On 20/09/2022 10:48, Tadhg Kearney wrote: Add basic unit tests covering all nine uncore API's. Signed-off-by: Tadhg Kearney --- app/test/meson.build | 2 + app/test/test_power_uncore.c | 299 +++ 2 files changed, 301 insertions(+) create

[PATCH] ethdev: queue rate parameter changed from 16b to 32b

2022-09-23 Thread skoteshwar
From: Satha Rao The rate parameter modified to uint32_t, so that it can work for more than 64 Gbps. Change-Id: I7115c22a4dfdda84d820b221bf33839a7b57f2cd Signed-off-by: Satha Rao --- app/test-pmd/cmdline.c| 8 app/test-pmd/config.c | 4 ++-- app/test-pmd/testp

[PATCH v2] ethdev: queue rate parameter changed from 16b to 32b

2022-09-23 Thread skoteshwar
From: Satha Rao The rate parameter modified to uint32_t, so that it can work for more than 64 Gbps. Signed-off-by: Satha Rao --- v2: Fixed checkpatch warnings app/test-pmd/cmdline.c| 8 app/test-pmd/config.c | 4 ++-- app/test-pmd/testpmd.h| 4

[PATCH] eal: restore some needed header includes

2022-09-23 Thread Andrew Boyer
These are necessary to build when HPET is enabled. Fixes: 2ff3976e677c ("eal: remove unneeded header includes") Cc: sean.morris...@intel.com Signed-off-by: Andrew Boyer --- lib/eal/linux/eal_timer.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/eal/linux/eal_timer.c b/lib/eal/li

[PATCH 00/27] net/mlx5: HW steering PMD update

2022-09-23 Thread Suanming Mou
The skeleton of mlx5 HW steering(HWS) has been updated into upstream for pretty a long time, but not updated anymore due to missing of the low-level steering layer code. Luckily, better late than never, the steering layer finnaly comes[1]. This series will add more features to the existing PMD cod

[PATCH 01/27] net/mlx5: fix invalid flow attributes

2022-09-23 Thread Suanming Mou
In the function flow_get_drv_type(), attr will be read in non-HWS mode. In case user call the HWS API in SWS mode, attr should be placed in HWS functions, or it will cause crash. Fixes: 572801ab860f ("ethdev: backport upstream rte_flow_async codes") Signed-off-by: Suanming Mou --- drivers/net/m

[PATCH 02/27] net/mlx5: fix IPv6 and TCP RSS hash fields

2022-09-23 Thread Suanming Mou
In the flow_dv_hashfields_set() function, while item_flags was 0, the code went directly to the first if and the else case would never have chance be checked. This caused the IPv6 and TCP hash fileds in the else case would never be set. This commit adds the dedicate HW steering hash field set func

[PATCH 03/27] net/mlx5: add shared header reformat support

2022-09-23 Thread Suanming Mou
As the rte_flow_async API defines, the action mask with field value not be 0 means the action will be used as shared in all the flows in the table. The header reformat action with action mask field not be 0 will be created as constant shared action. For encapsulation header reformat action, there

[PATCH 04/27] net/mlx5: add modify field hws support

2022-09-23 Thread Suanming Mou
This patch introduces support for modify_field rte_flow actions in HWS mode. Support includes: - Ingress and egress domains, - SET and ADD operations, - usage of arbitrary bit offsets and widths for packet and metadata fields. Support is implemented in two phases:

[PATCH 05/27] net/mlx5: validate modify field action template

2022-09-23 Thread Suanming Mou
From: Dariusz Sosnowski This patch adds validation step for action templates and validates if RTE_FLOW_ACTION_TYPE_MODIFY_FIELD actions' fields are properly masked. Signed-off-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_hw.c | 132 1 file changed, 132

[PATCH 06/27] net/mlx5: enable mark flag for all ports in the same domain

2022-09-23 Thread Suanming Mou
From: Bing Zhao In the switchdev mode, there is a unique FDB domain for all the representors and only the eswitch manager can insert the rule into this domain. If a flow rule is like below: flow create 0 ingress transfer pattern port_id id is X / eth / end actions mark id 25 ... It is used for r

[PATCH 07/27] net/mlx5: create port actions

2022-09-23 Thread Suanming Mou
From: Dariusz Sosnowski This patch implements creating and caching of port actions for use with HW Steering FDB flows. Actions are created on flow template API configuration and created only on the port designated as master. Attaching and detaching of ports in the same switching domain causes an

[PATCH 09/27] ethdev: add meter profiles/policies config

2022-09-23 Thread Suanming Mou
From: Alexander Kozyrev Provide an ability to specify the number of meter profiles/policies alongside with the number of meters during the Flow engine configuration. Signed-off-by: Alexander Kozyrev --- lib/ethdev/rte_flow.h | 22 +- 1 file changed, 21 insertions(+), 1 dele

[PATCH 08/27] net/mlx5: add extended metadata mode for hardware steering

2022-09-23 Thread Suanming Mou
From: Bing Zhao The new mode 4 of devarg "dv_xmeta_en" is added for HWS only. In this mode, the Rx / Tx metadata with 32b width copy between FDB and NIC is supported. The mark is only supported in NIC and there is no copy supported. Signed-off-by: Bing Zhao --- drivers/net/mlx5/linux/mlx5_os.c

[PATCH 10/27] net/mlx5: add HW steering meter action

2022-09-23 Thread Suanming Mou
From: Alexander Kozyrev This commit adds meter action for HWS steering. HW steering meter is based on ASO. The number of meters will be used by flows should be specified in advanced in the flow configure API. Signed-off-by: Alexander Kozyrev Signed-off-by: Alexander Kozyrev --- drivers/net/

[PATCH 12/27] net/mlx5: support caching queue action

2022-09-23 Thread Suanming Mou
If the port is stopped, the Rx queue data will also be destroyed. At that time, create table with RSS action would be failed due to lack of Rx queue data. This commit adds the cache of queue create operation while port stopped. In case port is stopped, add tables to the ongoing list first, then d

[PATCH 11/27] net/mlx5: add HW steering counter action

2022-09-23 Thread Suanming Mou
From: Xiaoyu Min This commit adds HW steering counter action support. Pool mechanism is the basic data structure for the HW steering counter. The HW steering's counter pool is based on the rte_ring of zero-copy variation. There are two global rte_rings: 1. free_list: Store the counters ind

[PATCH 15/27] net/mlx5: update indirect actions ops to HW variation

2022-09-23 Thread Suanming Mou
From: Xiaoyu Min Each flow engine should have its own callback functions for each flow's ops. Create new callback functions for indirect actions' ops which actually are wrppers of their mlx5_hw_async_* counter parts. Signed-off-by: Xiaoyu Min --- drivers/net/mlx5/mlx5_flow_hw.c | 98 +

[PATCH 13/27] net/mlx5: support DR action template API

2022-09-23 Thread Suanming Mou
From: Dariusz Sosnowski This patch adapts mlx5 PMD to changes in mlx5dr API regarding action templates. It changes the following: 1. Actions template creation: - Flow actions types are translated to mlx5dr action types in order to create mlx5dr_action_template object. - An offset

[PATCH 14/27] net/mlx5: fix indirect action validate

2022-09-23 Thread Suanming Mou
For indirect actions, the action mask type indicates the indirect action type. And action mask conf be NULL means the indirect action will be provided by flow action conf. This commit fixes the indirect action validate. Fixes: 393e0eb555c0 ("net/mlx5: support DR action template API") Signed-off-

[PATCH 16/27] net/mlx5: support indirect count action for HW steering

2022-09-23 Thread Suanming Mou
From: Xiaoyu Min The indirect counter action is taked as _shared_ counter between the flows use it. This _shared_ counter is gotten from counter pool at time the indirect action is created. And be put back to counter pool when indirect action is destroyed. Signed-off-by: Xiaoyu Min --- driver

[PATCH 17/27] net/mlx5: add pattern and table attribute validation

2022-09-23 Thread Suanming Mou
From: Dariusz Sosnowski This patch adds validation of direction attributes of pattern templates and template tables. In case of pattern templates the following configurations are allowed (and if this configuration requires addition of implicit pattern items): 1. If E-Switch is enabled (i.e. dv_

[PATCH 18/27] net/mlx5: add meta item support in egress

2022-09-23 Thread Suanming Mou
From: Dariusz Sosnowski This patch adds support for META item in HW Steering mode, in NIC TX domain. Due to API limitations, usage of META item requires that all mlx5 ports use the same configuration of dv_esw_en and dv_xmeta_en device arguments in order to consistently translate META item to ap

[PATCH 22/27] net/mlx5: add HW steering VLAN push, pop and VID modify flow actions

2022-09-23 Thread Suanming Mou
From: Gregory Etelson Add PMD implementation for HW steering VLAN push, pop and modify flow actions. HWS VLAN push flow action is triggered by a sequence of mandatory OF_PUSH_VLAN, OF_SET_VLAN_VID and optional OF_SET_VLAN_PCP flow actions commands. The commands must be arranged in the exact orde

[PATCH 19/27] net/mlx5: add support for ASO return register

2022-09-23 Thread Suanming Mou
From: Bing Zhao A REG_C_x metadata register is needed to store the result after an ASO action. Like in the SWS, the meter color register is used for all the ASO actions right now and this register was already filtered out from the available tags. It is assumed that all the devices are using the

[PATCH 20/27] lib/ethdev: add connection tracking configuration

2022-09-23 Thread Suanming Mou
This commit adds the maximum connection tracking number configuration for async flow engine. Signed-off-by: Suanming Mou --- lib/ethdev/rte_flow.h | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index abb475bdee..e9a1bce38b 100644 --- a/lib/

[PATCH 21/27] net/mlx5: add HW steering connection tracking support

2022-09-23 Thread Suanming Mou
This commit adds the support of connection tracking to HW steering as SW steering did before. Different with SW steering implementation, take advantage of HW steering bulk action allocation support, in HW steering only one single CT pool is needed. An indexed pool is introduced to record allocate

[PATCH 23/27] net/mlx5: add meter color flow matching in dv

2022-09-23 Thread Suanming Mou
From: Alexander Kozyrev Create firmware and software steering meter color support. Allow matching on a meter color in both root and non-root groups. Signed-off-by: Alexander Kozyrev --- drivers/net/mlx5/mlx5_flow.h| 3 + drivers/net/mlx5/mlx5_flow_dv.c | 113 +

[PATCH 25/27] net/mlx5: implement profile/policy get

2022-09-23 Thread Suanming Mou
From: Alexander Kozyrev Add callback functions for both software and hardware steering to get a pointers to Meter profile/policy by their IDs. Signed-off-by: Alexander Kozyrev --- drivers/net/mlx5/mlx5_flow_meter.c | 65 ++ 1 file changed, 65 insertions(+) diff --g

[PATCH 24/27] net/mlx5: add meter color flow matching in hws

2022-09-23 Thread Suanming Mou
From: Alexander Kozyrev Create hardware steering meter color support. Allow matching on a meter color using hardware steering. Signed-off-by: Alexander Kozyrev --- drivers/net/mlx5/mlx5_flow.h| 1 + drivers/net/mlx5/mlx5_flow_dv.c | 32 ++-- drivers/net/mlx5/ml

[PATCH 27/27] net/mlx5: implement METER MARK indirect action for HWS

2022-09-23 Thread Suanming Mou
From: Alexander Kozyrev Add ability to create an indirect action handle for METER_MARK. It allows to share one Meter between several different actions. Signed-off-by: Alexander Kozyrev --- drivers/net/mlx5/mlx5_flow.c| 6 ++ drivers/net/mlx5/mlx5_flow.h| 25 - drivers/net/mlx5/m

[PATCH 26/27] net/mlx5: implement METER MARK action for HWS

2022-09-23 Thread Suanming Mou
From: Alexander Kozyrev Implement METER_MARK action for hardware steering case. Signed-off-by: Alexander Kozyrev --- drivers/net/mlx5/mlx5.h| 9 ++- drivers/net/mlx5/mlx5_flow.h | 2 + drivers/net/mlx5/mlx5_flow_aso.c | 7 +- drivers/net/mlx5/mlx5_flow_hw.c| 116 +

RE: [EXT] [PATCH] examples/ipsec-secgw: free event vector mbufs

2022-09-23 Thread Pavan Nikhilesh Bhagavatula
> Free mbufs from event vector list when enqueue operation fails > and during event port flush for cleanup. > > Signed-off-by: Rahul Bhansali > --- > examples/ipsec-secgw/ipsec_worker.c | 34 +-- > -- > 1 file changed, 25 insertions(+), 9 deletions(-) > > diff --git a/ex

  1   2   >