RE: [dpdk-dev] [PATCH 1/1] net/mlx5: fix memory leak when releasing a drop action

2022-07-31 Thread Matan Azrad
Hi Yunjian From: Yunjian Wang > When the memory for hrxq->action is allocated in mlx5_devx_hrxq_new(). Memory -> resources .. are > But it was not being freed when the drop action was released in > mlx5_devx_drop_action_destroy(). These cause a memory leak. > > Fixes: bc5bee028ebc ("net/mlx5: c

Re: Question about pattern types for rte_flow RSS rule

2022-07-31 Thread Andrew Rybchenko
Hi, Huisong! On 7/29/22 05:30, lihuisong (C) wrote: Hi Ori, and all, For RSS flow rule, pattern item types and RSS types in action are an inclusive relationship, and RSS types contain pattern item types. I disagree with the statement. We can redirect various packets, but apply RSS on subset

[PATCH 0/2] vhost fixes for OVS SIGSEGV in PMD

2022-07-31 Thread Claudio Fontana
Hi, the real meat is in patch 1/2, which fixes a segmentation fault in the OVS PMD thread when resynchronizing with QEMU after the guest application has been killed with SIGKILL. This fixes an issue where the guest DPDK application is able to crash the OVS process on the host. Patch 2/2 is just

[PATCH 1/2] vhost: fix error handling in virtio_dev_tx_split

2022-07-31 Thread Claudio Fontana
in virtio_dev_split we add a check for invalid nr_vec, mainly for nr_vec == 0 (but add a check for BUF_VECTOR_MAX too), and bail out before calling desc_to_mbuf, otherwise in desc_to_mbuf we end up trying to memcpy from a source address buf_vec[0] that is an uninitialized stack variable. This shou

[PATCH 2/2] vhost: improve error handling in desc_to_mbuf

2022-07-31 Thread Claudio Fontana
check when increasing vec_idx that it is still valid in the (buf_len < dev->vhost_hlen) case too. Signed-off-by: Claudio Fontana --- lib/vhost/virtio_net.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c index 0b8db2046e..6d

Re: [PATCH v4 0/6] add thread lifetime and attributes API

2022-07-31 Thread Dmitry Kozlyuk
2022-06-27 09:56 (UTC-0700), Tyler Retzlaff: > add rte thread lifetime and attributes api. with these api additions > there is now sufficient platform abstracted thread api to remove the > use of pthread in the unit tests. For series, Acked-by: Dmitry Kozlyuk Sorry it took so long to review.

RE: [RFC,1/2] member: implement NitroSketch mode

2022-07-31 Thread Wang, Yipeng1
> -Original Message- > From: Rong, Leyi > Sent: Wednesday, June 1, 2022 1:22 AM > To: Wang, Yipeng1 ; zaoxing...@gmail.com; Gobriel, > Sameh > Cc: dev@dpdk.org; Rong, Leyi > Subject: [RFC,1/2] member: implement NitroSketch mode > > Sketching algorithm provide high-fidelity approximate m

[Bug 1061] [dpdk v21.11.2-rc1] examples/performance-thread meson build error with gcc12.1 on fedora36

2022-07-31 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1061 Bug ID: 1061 Summary: [dpdk v21.11.2-rc1] examples/performance-thread meson build error with gcc12.1 on fedora36 Product: DPDK Version: 21.11 Hardware: All OS: All

RE: DPDK source code browser

2022-07-31 Thread Honnappa Nagarahalli
Good to add to Techboard agenda > -Original Message- > From: Morten Brørup > Sent: Friday, July 29, 2022 11:57 AM > To: dev@dpdk.org > Cc: Michael Opdenacker > Subject: DPDK source code browser > > Good news, everyone. > > Bootlin's Elixir source code browser now includes the stable r

[PATCH] app/testpmd: add command line argument 'rx-metadata'

2022-07-31 Thread Hanumanth Pothula
Performance drop is observed by sending per packet rx metadata (offloads). Hence, introducing command line argument, 'rx-metadata' to control passing rx metadata to PMD. By default it’s disabled. Signed-off-by: Hanumanth Pothula --- app/test-pmd/parameters.c | 4 app/test-pmd/testpmd.c

RE: [PATCH v6] net/ice: add retry mechanism for DCF after failure

2022-07-31 Thread Zhou, YidingX
> -Original Message- > From: Zhang, Qi Z > Sent: Thursday, July 7, 2022 2:56 PM > To: Zhang, Peng1X ; Yang, Qiming > ; dev@dpdk.org > Subject: RE: [PATCH v6] net/ice: add retry mechanism for DCF after failure > > > > > -Original Message- > > From: Zhang, Peng1X > > Sent: Wed

[dpdk-dev] [PATCH 1/3] common/cnxk: fix printing disabled MKEX registers

2022-07-31 Thread psatheesh
From: Satheesh Paul This patch skips printing disabled MKEX registers when dumping hardware flow MCAM entry data. Fixes: 9869c39918 ("common/cnxk: support flow entry dump") Cc: sta...@dpdk.org Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar K --- drivers/common/cnxk/roc_npc_mcam_dump.c

[dpdk-dev] [PATCH 2/3] common/cnxk: print counters along with flow dump

2022-07-31 Thread psatheesh
From: Satheesh Paul When dumping hardware flow data, print any counter configured on the flow as well. Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar K --- drivers/common/cnxk/roc_npc_mcam_dump.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/co

[dpdk-dev] [PATCH 3/3] common/cnxk: update MKEX capability flags

2022-07-31 Thread psatheesh
From: Satheesh Paul Update MKEX capability flags to enable parsing VLAN PCP, DSCP and GTPv1 TEID. Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar K --- drivers/common/cnxk/roc_npc_mcam.c | 86 -- drivers/common/cnxk/roc_npc_priv.h | 12 +++-- 2 files changed,

RE: [PATCH 1/2] eventdev/eth_tx: add spinlock for adapter start/stop

2022-07-31 Thread Jayatheerthan, Jay
> -Original Message- > From: Naga Harish K, S V > Sent: Tuesday, July 26, 2022 9:52 AM > To: Jayatheerthan, Jay ; jer...@marvell.com > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH 1/2] eventdev/eth_tx: add spinlock for adapter start/stop > > add spinlock protection for tx adapter s

RE: [PATCH 2/2] eventdev/eth_tx: fix adapter stop

2022-07-31 Thread Jayatheerthan, Jay
> -Original Message- > From: Naga Harish K, S V > Sent: Tuesday, July 26, 2022 9:52 AM > To: Jayatheerthan, Jay ; jer...@marvell.com > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH 2/2] eventdev/eth_tx: fix adapter stop > > adapter_stop function is stopping the adapter service using