Re: [PATCH] gro: fix gro with tcp push flag

We should do it for the rte_gro_reassemble as well, with timer mode it could lead to more duplicate ACKs. I had a proposal for the enhancement which would handle both rte_gro_reassemble and rte_gro_reassemble_burst but have not got any response yet. I have a custom patch which is working fine for

Re: [PATCH v3 1/4] vhost: fix vq use after free on NUMA reallocation

On 7/25/22 22:32, David Marchand wrote: translate_ring_addresses (via numa_realloc) may change a virtio device and virtio queue. The virtqueue object must be refreshed before accessing the lock. Fixes: 04c27cb673b9 ("vhost: fix unsafe vring addresses modifications") Cc: sta...@dpdk.org Signe

Re: [PATCH v3 2/4] vhost: make NUMA reallocation code more robust

On 7/25/22 22:32, David Marchand wrote: translate_ring_addresses and numa_realloc may change a virtio device and virtio queue. Callers of those helpers must be extra careful and refresh any reference to old data. Change those functions prototype as a way to hint about this issue and always as

Re: [PATCH v2] examples/dma: support DMA dequeue when no packet received

On 25/07/2022 13:22, Chengwen Feng wrote: Currently the example using DMA in asynchronous mode, which are: nb_rx = rte_eth_rx_burst(); if (nb_rx == 0) continue; ... dma_enqueue(); // enqueue the received packets copy request nb_cpl = dma_deq

Re: [PATCH v3 3/4] vhost: keep a reference to virtqueue index

On 7/25/22 22:32, David Marchand wrote: Having a back reference to the index of the vq in the dev->virtqueue[] array makes it possible to unify the internal API, with only passing dev and vq. It also allows displaying the vq index in log messages. Remove virtqueue index checks where unneeded

RE: [EXT] [PATCH v2 19/20] remove repeated word 'be'

> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, July 26, 2022 9:05 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Rasesh Mody > ; Devendra Singh Rawat > Subject: [EXT] [PATCH v2 19/20] remove repeated word 'be' > > External Email > > -

Re: [PATCH v3 4/4] vhost: stop using mempool for IOTLB cache

On 7/25/22 22:32, David Marchand wrote: A mempool consumes 3 memzones (with the default ring mempool driver). The default DPDK configuration allows RTE_MAX_MEMZONE (2560) memzones. Assuming there is no other memzones that means that we can have a maximum of 853 mempools. In the vhost library

[dpdk-dev v1] crypto/qat: add in libcrypto version check

This patch add in libcrypto version check before enable libipsec-mb for QAT. The inter-ipsec-mb lib for partial hash and AES cacluation should only be enabled when both OpensSSL 3.0 and IPSec_MB 1.2.0 are installed on the system. Signed-off-by: Kai Ji --- drivers/common/qat/meson.build | 4 +++-

Re: [PATCH v3 3/4] vhost: keep a reference to virtqueue index

On Tue, Jul 26, 2022 at 10:52 AM Maxime Coquelin wrote: > > @@ -2275,12 +2267,11 @@ rte_vhost_clear_queue(int vid, uint16_t queue_id, > > struct rte_mbuf **pkts, > > } > > > > if ((queue_id & 1) == 0) > > - n_pkts_cpl = vhost_poll_enqueue_completed(dev, queue_id, > > -

[dpdk-dev v2] crypto/qat: add in libcrypto version check

This patch add in libcrypto version check before enable libipsec-mb for QAT. The inter-ipsec-mb lib for partial hash and AES calculation should only be enabled when both OpensSSL 3.0 and IPSec_MB 1.2.0 are installed on the system. Signed-off-by: Kai Ji --- drivers/common/qat/meson.build | 4 +++-

RE: [EXT] [PATCH v2 09/20] remove repeated word 'only'

> From: Stephen Hemminger > Sent: Tuesday, July 26, 2022 9:05 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Rasesh Mody > ; Shahed Shaikh > Subject: [EXT] [PATCH v2 09/20] remove repeated word 'only' > > Found by doing duplicate word scan. > > Signed-off-by: Stephen Hemminger Acked-by: Rase

RE: [EXT] [PATCH v2 19/20] remove repeated word 'be'

> From: Stephen Hemminger > Sent: Tuesday, July 26, 2022 9:05 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Rasesh Mody > ; Devendra Singh Rawat > Subject: [EXT] [PATCH v2 19/20] remove repeated word 'be' > > Found by doing duplicate word scan. > > Signed-off-by: Stephen Hemminger Acked-by:

RE: [EXT] [dpdk-dev v1] crypto/qat: add in libcrypto version check

Hi Kai, This is a fix for compilation when openssl 1.1 is used to build QAT. Can you update the title to Crypto/qat: fix build with OpenSSL 1.1 > This patch add in libcrypto version check before enable libipsec-mb for > QAT. The inter-ipsec-mb lib for partial hash and AES cacluation should > only

[PATCH] test/crypto: add AES-CCM test vectors

From: Archana Muniganti Added ESP tunnel mode known vectors for AES-CCM along with combined mode support. Signed-off-by: Archana Muniganti --- app/test/test_cryptodev.c | 8 ++ app/test/test_cryptodev_security_ipsec.c | 3 + app/test/test_cryptodev_security_ipsec.h

[PATCH] memif: memif driver does not crashes when there's different N of TX and RX queues

Bugzilla ID: 734 there's a bug in memif_stats_get() function due to confusion between C2S (client->server) and S2C (server->client) rings, causing a crash if there's a different number of RX and TX queues. this is fixed by selectiing the correct rings for RX and TX i.e for RX, S2C rings are selec

[RFC] regexdev: add maximum number of mbuf segments field

Allows application to query maximum number of mbuf segments that can be chained together. Signed-off-by: Gerry Gribbon --- drivers/regex/mlx5/mlx5_regex.h | 1 + drivers/regex/mlx5/mlx5_regex_fastpath.c | 43 drivers/regex/mlx5/mlx5_rxp.c| 1 + lib

Re: [PATCH v2] ethtool: added help command to list all available

Hi, Is there any other work/changes required for this patch to be submitted? Thanks On Mon, May 30, 2022 at 3:42 PM Ferruh Yigit wrote: > On 5/27/2022 6:14 AM, Huzaifa Rahman wrote: > > [CAUTION: External Email] > > Hi, > > > > The following tests are failing but my patch is not related to a

[dpdk-dev v2] Crypto/qat: fix build with OpenSSL 1.1

This patch add in libcrypto version check before enable libipsec-mb for QAT. The inter-ipsec-mb lib for partial hash and AES calculation should only be enabled when both OpensSSL 3.0 and IPSec_MB 1.2.0 are installed on the system. Signed-off-by: Kai Ji --- drivers/common/qat/meson.build | 4 +++-

RE: [EXT] [dpdk-dev v1] crypto/qat: add in libcrypto version check

Thanks akhil, V2 here: http://patchwork.dpdk.org/project/dpdk/patch/20220726115608.84140-1-kai...@intel.com/ Regards Kai > -Original Message- > From: Akhil Goyal > Sent: Tuesday, July 26, 2022 11:14 AM > To: Ji, Kai ; dev@dpdk.org > Cc: Ashwin Sekhar Thalakalath Kottilveetil ; Anoob

[PATCH dpdk-latest v2] system-dpdk: Update vhost tests to be compatible with DPDK 22.07.

The DPDK commit [1] improves the socket layer logs in the vhost library to ease log filtering and debugging. Update the system-dpdk vhost tests to reflect this change. [1] c85c35b1d447 ("vhost: improve socket layer logs") Signed-off-by: Sunil Pai G --- v1->v2: updated more tests that were added

RE: [PATCH dpdk-latest v2] system-dpdk: Update vhost tests to be compatible with DPDK 22.07.

Copy paste error of wrong mailing list , please ignore this patch, was intended for OVS ML

[PATCH] net: rename octeon ep PMD

This patch renames octeon end point driver from octeontx_ep to octeon_ep to enable single unified driver to support current OcteonTx and future Octeon PCI endpoint NICs to reflect common driver for all Octeon based PCI endpoint NICs. Signed-off-by: Sathesh Edara --- MAINTAINERS

RE: [PATCH v11] sched: enable CMAN at runtime

> -Original Message- > From: Danilewicz, MarcinX > Sent: Friday, July 15, 2022 3:51 PM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v11] sched: enable CMAN at runtime > > Added changes to enable CMAN (RED or PIE) at init from pro

RE: [PATCH v2 00/13] telemetry JSON escaping and other enhancements

> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Monday, 25 July 2022 18.35 > > This patchset contains fixes for the problem of handling characters > returned by telemetry callbacks which require escaping when encoded in > JSON format. It also includes unit tests to validate th

Re: [RFC] regexdev: add maximum number of mbuf segments field

On Tue, 26 Jul 2022 10:47:07 + Gerry Gribbon wrote: > diff --git a/lib/regexdev/rte_regexdev.h b/lib/regexdev/rte_regexdev.h > index 3bce8090f6..7d2e1ee1d0 100644 > --- a/lib/regexdev/rte_regexdev.h > +++ b/lib/regexdev/rte_regexdev.h > @@ -622,6 +622,8 @@ struct rte_regexdev_info { > /

RE: [PATCH v2 1/3] power: add uncore API to power library

> -Original Message- > From: Richardson, Bruce *snip* > > > +dpdk_conf.set('RTE_MAX_NUMA_DIE', 1) > > > +dpdk_conf.set('RTE_MAX_UNCORE_FREQS', 32) > > > > Check if these flags should be added to other platforms. > > > > I think we need some explanation as to what these values are for, and

[PATCH v3 00/20] Remove repeated words in comments and messages

This is a cleanup of comments and messages. Done by an ugly pcregrep across sources and skipping lots of false positives The idea is based of what some maintainers have been doing in netdev. Series-acked-by: Bruce Richardson v3 - fix some small checkpatch complaints v2 - reword ethdev com

[PATCH v3 01/20] ethdev: reword dev_info_get description.

The original comment was redundant and had duplicate word 'of'. Signed-off-by: Stephen Hemminger --- lib/ethdev/rte_ethdev.h | 33 + 1 file changed, 5 insertions(+), 28 deletions(-) diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index de9e970d4d11

[PATCH v3 02/20] remove repeated word 'to'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- app/test/test_resource.c | 2 +- drivers/common/sfc_efx/base/siena_nvram.c | 2 +- lib/pipeline/rte_swx_ctl.c| 2 +- lib/power/guest_channel.c | 2 +- 4 files changed, 4 inse

[PATCH v3 03/20] remove repeated word 'is'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- drivers/common/sfc_efx/base/efx_regs_mcdi.h | 2 +- lib/net/rte_ether.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/sfc_efx/base/efx_regs_mcdi.h b/drivers/c

[PATCH v3 04/20] remove repeated word 'same'

The word 'same' is duplicated in comment. Signed-off-by: Stephen Hemminger Acked-by: Liron Himi --- drivers/net/mvneta/mvneta_ethdev.c | 2 +- drivers/net/mvpp2/mrvl_ethdev.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mvneta/mvneta_ethdev.c b/drivers/

[PATCH v3 05/20] remove repeated word 'on'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- drivers/net/bonding/rte_eth_bond_8023ad.h | 2 +- examples/vm_power_manager/channel_monitor.h | 2 +- examples/vm_power_manager/oob_monitor.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/driv

[PATCH v3 06/20] remove repeated word 'in'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- drivers/common/sfc_efx/base/efx_types.h | 2 +- drivers/event/sw/sw_evdev.c | 2 +- drivers/net/hns3/hns3_ethdev.c | 2 +- drivers/net/mlx5/mlx5_flow.c| 2 +- drivers/net/sfc/sfc_ef10_tx.c

[PATCH v3 07/20] remove repeated word 'this'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- lib/ring/rte_ring.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/ring/rte_ring.c b/lib/ring/rte_ring.c index cddaf6b2876f..8ed455043dee 100644 --- a/lib/ring/rte_ring.c +++ b/lib/ring/rte_ring.c

[PATCH v3 08/20] remove repeated word 'then'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- drivers/net/i40e/i40e_fdir.c | 2 +- drivers/net/igc/base/igc_mac.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c index 8caedea14eaa..3b

[PATCH v3 09/20] remove repeated word 'only'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger Acked-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x.c | 2 +- drivers/net/pcap/pcap_ethdev.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index

[PATCH v3 10/20] remove repeated word 'worker'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- lib/distributor/rte_distributor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/distributor/rte_distributor.c b/lib/distributor/rte_distributor.c index 3035b7a99925..967e27d35a49 100644 --- a/lib/

[PATCH v3 11/20] remove repeated word 'or'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- drivers/net/cxgbe/sge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/cxgbe/sge.c b/drivers/net/cxgbe/sge.c index 5d91355c9ab1..1a767dabf59c 100644 --- a/drivers/net/cxgbe/sge.c +++ b/drive

[PATCH v3 12/20] remove repeated word 'table'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- drivers/net/ixgbe/ixgbe_ipsec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_ipsec.c b/drivers/net/ixgbe/ixgbe_ipsec.c index c353ae33b4f8..3d479011bea1 100644 --- a/drivers/net

[PATCH v3 13/20] remove repeated word 'that'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_ctrl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_ctrl.h b/drivers/net/nfp/nfp_ctrl.h index 372d53746243..2327d4eb7646 100644 -

[PATCH v3 14/20] remove repeated word 'override'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c index 8444f1a795

[PATCH v3 15/20] remove repeated word 'groups'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- app/test/test_ipsec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_ipsec.c b/app/test/test_ipsec.c index 7047e1796091..8d208c526a49 100644 --- a/app/test/test_ipsec.c +++ b/app/test/test

[PATCH v3 16/20] remove repeated word 'page'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/ecore_fw_defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnx2x/ecore_fw_defs.h b/drivers/net/bnx2x/ecore_fw_defs.h index 6fc1fce7e29c..ab1abf6b34b3 100644 --- a/driv

[PATCH v3 17/20] remove repeated word 'individual'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- drivers/net/cxgbe/cxgbe_filter.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/cxgbe/cxgbe_filter.h b/drivers/net/cxgbe/cxgbe_filter.h index 46ebf833381e..6e099a5c1cfc 100644 --- a/drivers/

[PATCH v3 18/20] remove repeated word 'expected'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- lib/bpf/rte_bpf_ethdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/bpf/rte_bpf_ethdev.h b/lib/bpf/rte_bpf_ethdev.h index 135062c9e13c..1cca2e6c95a2 100644 --- a/lib/bpf/rte_bpf_ethdev.h +++ b/l

[PATCH v3 19/20] remove repeated word 'be'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger Acked-by: Devendra Singh Rawat Acked-by: Rasesh Mody --- drivers/net/qede/qede_filter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/qede/qede_filter.c b/drivers/net/qede/qede_filter.c i

[PATCH v3 20/20] remove repeated word 'all'

Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/ecore_sp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnx2x/ecore_sp.h b/drivers/net/bnx2x/ecore_sp.h index 1f4d5a3ebe29..c0b4d431c879 100644 --- a/drivers/net/bnx2x/ec

RE: [PATCH v3 14/20] remove repeated word 'override'

> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, July 26, 2022 10:00 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Gagandeep Singh > ; Hemant Agrawal > Subject: [PATCH v3 14/20] remove repeated word 'override' > Importance: High > > Found by doing duplicate word scan.

RFC: EAL legacy memory fixed address translations

This proposal describes a method for translating any huge page address from virtual to physical or vice versa using simple addition or subtraction of a single fixed value. This allows devices to efficiently access arbitrary huge page memory, even stack data when worker stacks are in huge pages. W

RE: [PATCH v2 02/13] telemetry: fix escaping of invalid json characters

> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Monday, 25 July 2022 18.36 > To: dev@dpdk.org > Cc: Bruce Richardson; Ciara Power; Keith Wiles > Subject: [PATCH v2 02/13] telemetry: fix escaping of invalid json > characters > > For string values returned from telemetry, escape

[RFC] EAL: legacy memory fixed address translations

This proposal describes a method for translating any huge page address from virtual to physical or vice versa using simple addition or subtraction of a single fixed value. This allows devices to efficiently access arbitrary huge page memory, even stack data when worker stacks are in huge pages. W

Re: [RFC] EAL: legacy memory fixed address translations

Hi Don, 2022-07-26 14:33 (UTC-0400), Don Wallwork: > This proposal describes a method for translating any huge page > address from virtual to physical or vice versa using simple > addition or subtraction of a single fixed value. This allows > devices to efficiently access arbitrary huge page memor

[RFC] pcapng: record received RSS hash in pcap file

There is an option for recording RSS hash with packets in the pcapng standard. This implements this for all received packets. There is a corner case that can not be addressed with current DPDK API's. If using rte_flow() and some hardware it is possible to write a flow rule that uses another hash f

[dpdk-dev v1] lib/cryptodev: multi-process IPC request handler

This patch add in multi-process IPC request handler function in rte cryptodev. This function intend to support a queue-pair configuration request to allow the secondary process to reconfigure the queue-pair setup'ed by the primary process. Signed-off-by: Kai Ji --- lib/cryptodev/rte_cryptodev.c

[PATCH v1] graph: fix out of bounds access when re-allocate node objs

For __rte_node_enqueue_prologue(), If the number of objs is more than the node->size * 2, the extra objs will write out of bounds memory. It should use __rte_node_stream_alloc_size() to request enough memory. And for rte_node_next_stream_put(), it will re-allocate a small size, when the node free

RE: [EXT] [dpdk-dev v1] lib/cryptodev: multi-process IPC request handler

This is a library change you should cc all PMD owners while sending patch. > This patch add in multi-process IPC request handler function in rte > cryptodev. This function intend to support a queue-pair configuration > request to allow the secondary process to reconfigure the queue-pair > setup'ed

[PATCH] config/arm: add Graviton3

Add meson build configuration for Graviton3 platform with 64-bit Arm Neoverse N2 cores. It adds crypto feature to generic Neoverse N2 config. Signed-off-by: Ruifeng Wang --- config/arm/arm64_graviton3_linux_gcc | 16 config/arm/meson.build | 10 ++ 2 files

[PATCH v2] config/arm: add Graviton3

Add meson build configuration for Graviton3 platform with 64-bit Arm Neoverse N2 cores. It adds crypto feature to generic Neoverse N2 config. Signed-off-by: Ruifeng Wang --- v2: Rebased to top of tree. config/arm/arm64_graviton3_linux_gcc | 16 config/arm/meson.build