Minutes of Technical Board Meeting, 2022-06-29

2022-07-11 Thread Thomas Monjalon
Members Attending: 9/10 - Aaron Conole - Bruce Richardson - Honnappa Nagarahalli - Jerin Jacob - Kevin Traynor - Konstantin Ananyev - Maxime Coquelin - Stephen Hemminger - Thomas Monjalon (Chair) NOTE: The Technical Board meet

RE: [PATCH] vhost: fix unnecessary dirty page logging

2022-07-11 Thread He, Xingguang
Hi, > -Original Message- > From: Ding, Xuan > Sent: Friday, July 8, 2022 4:09 PM > To: Maxime Coquelin ; Xia, Chenbo > > Cc: dev@dpdk.org; Hu, Jiayu ; He, Xingguang > ; Yang, YvonneX ; > Jiang, Cheng1 > Subject: RE: [PATCH] vhost: fix unnecessary dirty page logging > > > > > -Ori

Re: [PATCH] common/sfc_efx/base: remove VQ index check during VQ start

2022-07-11 Thread Andrew Rybchenko
Hi Vijay, On 7/8/22 12:17, Srivastava, Vijay wrote: Acked-by: Vijay Srivastava Please, send a patch to MAINTAINERS to update your E-mail address from Xilinx to AMD domain. Andrew.

Re: [PATCH] common/sfc_efx/base: remove VQ index check during VQ start

2022-07-11 Thread David Marchand
Hello, On Mon, Jul 11, 2022 at 10:26 AM Andrew Rybchenko wrote: > > On 7/8/22 12:17, Srivastava, Vijay wrote: > > > Acked-by: Vijay Srivastava > > Please, send a patch to MAINTAINERS to update your E-mail > address from Xilinx to AMD domain. Please register this mail address to the mailing list

Re: [PATCH] common/sfc_efx/base: remove VQ index check during VQ start

2022-07-11 Thread Andrew Rybchenko
On 7/8/22 10:37, abhimanyu.sa...@xilinx.com wrote: From: Abhimanyu Saini The used/avail queue indexes are not bound by queue size, because the descriptor entry index is calculated by a simple modulo between queue index and queue_size "is calculated" is a bit vague since looking at the code I'

Re: [RFC v2 v2 00/29] Bus and device cleanup for 22.11

2022-07-11 Thread Bruce Richardson
On Sat, Jul 09, 2022 at 10:26:15AM +0200, David Marchand wrote: > This is a PoC for hiding the rte_bus, rte_driver and rte_device objects. > And mark associated driver only API as internal. > > A good amount of the patches are preparation work on rte_bus.h, > rte_dev.h, rte_devargs.h and rte_eal.h

RE: [PATCH v3] vhost: fix deadlock when message handling failed

2022-07-11 Thread Pei, Andy
HI ALL, I see that in function vhost_user_msg_handler. We use "ret" to store both vhost msg return code like "RTE_VHOST_MSG_RESULT_XXX" and function return value. I wonder if it is better to use two different variable to make it easy to read. > -Original Message- > From: Maxime Coquelin

RE: [PATCH v3] vhost: fix deadlock when message handling failed

2022-07-11 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Monday, July 11, 2022 4:42 PM > To: Maxime Coquelin ; Ma, WenwuX > ; Xia, Chenbo ; dev@dpdk.org > Cc: Hu, Jiayu ; Wang, Yinan ; He, > Xingguang ; sta...@dpdk.org > Subject: RE: [PATCH v3] vhost: fix deadlock when message handling failed > > H

RE: [PATCH v3] vhost: fix deadlock when message handling failed

2022-07-11 Thread Pei, Andy
HI Chenbo, See below example 1. ret = read_vhost_message(dev, fd, &ctx); if (ret <= 0) { if (ret < 0) VHOST_LOG_CONFIG(dev->ifname, ERR, "vhost read message failed\n"); else VHOST_LOG_CONFIG(dev->ifna

RE: [PATCH v3] vhost: fix deadlock when message handling failed

2022-07-11 Thread Xia, Chenbo
Hi Andy, > -Original Message- > From: Pei, Andy > Sent: Monday, July 11, 2022 5:03 PM > To: Xia, Chenbo ; Maxime Coquelin > ; Ma, WenwuX ; > dev@dpdk.org > Cc: Hu, Jiayu ; Wang, Yinan ; He, > Xingguang ; sta...@dpdk.org > Subject: RE: [PATCH v3] vhost: fix deadlock when message handling f

Re: [PATCH v2] ip_frag: add IPv4 fragment copy packet API

2022-07-11 Thread Konstantin Ananyev
11/07/2022 00:35, Konstantin Ananyev пишет: > Some NIC drivers support MBUF_FAST_FREE(Device supports optimization > for fast release of mbufs. When set application must guarantee that > per-queue all mbufs comes from the same mempool and has refcnt = 1) > offload. In order to adapt to this o

Re: Minutes of Technical Board Meeting, 2022-06-29

2022-07-11 Thread Konstantin Ananyev
Ack Members Attending: 9/10 - Aaron Conole - Bruce Richardson - Honnappa Nagarahalli - Jerin Jacob - Kevin Traynor - Konstantin Ananyev - Maxime Coquelin - Stephen Hemminger - Thomas Monjalon (Chair) NOTE: The Technical B

RE: release candidate 22.07-rc3

2022-07-11 Thread Jiang, YuX
> -Original Message- > From: Jiang, YuX > Sent: Thursday, July 7, 2022 5:07 PM > To: Thomas Monjalon ; dev (dev@dpdk.org) > > Cc: Devlin, Michelle ; Mcnamara, John > ; Ferruh Yigit > Subject: RE: release candidate 22.07-rc3 > > > -Original Message- > > From: Thomas Monjalon > > S

Re: Minutes of Technical Board Meeting, 2022-06-29

2022-07-11 Thread Konstantin Ananyev
Ack Ups, sorry, wrong thread :( Lack of coffee :) Members Attending: 9/10 - Aaron Conole - Bruce Richardson - Honnappa Nagarahalli - Jerin Jacob - Kevin Traynor - Konstantin Ananyev - Maxime Coquelin - Stephen Hemminger - Thomas Monjalon (Chair) NOTE:

Re: [PATCH v2 1/2] app/test: add cksum performance test

2022-07-11 Thread Olivier Matz
Hi Mattias, Please see few comments below. On Fri, Jul 08, 2022 at 02:56:07PM +0200, Mattias Rönnblom wrote: > Add performance test for the rte_raw_cksum() function, which delegates > the actual work to __rte_raw_cksum(), which in turn is used by other > functions in need of Internet checksum cal

Re: [PATCH v2 2/2] net: have checksum routines accept unaligned data

2022-07-11 Thread Olivier Matz
Hi, On Fri, Jul 08, 2022 at 02:56:08PM +0200, Mattias Rönnblom wrote: > __rte_raw_cksum() (used by rte_raw_cksum() among others) accessed its > data through an uint16_t pointer, which allowed the compiler to assume > the data was 16-bit aligned. This in turn would, with certain > architectures and

RE: [PATCH v9 2/4] ethdev: introduce protocol hdr based buffer split

2022-07-11 Thread Ding, Xuan
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Thursday, July 7, 2022 5:08 PM > To: Wu, WenxuanX > Cc: andrew.rybche...@oktetlabs.ru; Li, Xiaoyun ; > ferruh.yi...@xilinx.com; Singh, Aman Deep ; > dev@dpdk.org; Zhang, Yuying ; Zhang, Qi Z > ; jerinjac...@gmail.com; > step

[PATCH] doc: add IP ECN header rewrite to mlx5 notes

2022-07-11 Thread Jiawei Wang
This patch updates the mlx5 notes for IPv4/IPv6 ECN field rewrite offload. Fixes: c4e442fa4c45 ("ethdev: add IPv4/IPv6 ECN header rewrite action") Fixes: 097d84a42a87 ("common/mlx5: check ECN modification capability") Fixes: 76d575612277 ("net/mlx5: support modifying ECN field") Signed-off-by: Ji

RE: [PATCH v9 0/4] add an api to support proto based buffer split

2022-07-11 Thread Ding, Xuan
Hi, > -Original Message- > From: Thomas Monjalon > Sent: Thursday, July 7, 2022 5:10 PM > To: Wu, WenxuanX ; Ding, Xuan > > Cc: andrew.rybche...@oktetlabs.ru; dev@dpdk.org; Li, Xiaoyun > ; ferruh.yi...@xilinx.com; dev@dpdk.org; Zhang, > Yuying ; Zhang, Qi Z ; > jerinjac...@gmail.com; ste

Re: [PATCH v9 2/4] ethdev: introduce protocol hdr based buffer split

2022-07-11 Thread Thomas Monjalon
11/07/2022 11:54, Ding, Xuan: > From: Thomas Monjalon > > 13/06/2022 12:25, wenxuanx...@intel.com: > > > --- a/lib/ethdev/rte_ethdev.h > > > +++ b/lib/ethdev/rte_ethdev.h > > > @@ -1176,6 +1176,9 @@ struct rte_eth_txmode { > > > * specified in the first array element, the second buffer, from t

Re: [PATCH v2 1/2] app/test: add cksum performance test

2022-07-11 Thread Mattias Rönnblom
On 2022-07-11 11:47, Olivier Matz wrote: > Hi Mattias, > > Please see few comments below. > > On Fri, Jul 08, 2022 at 02:56:07PM +0200, Mattias Rönnblom wrote: >> Add performance test for the rte_raw_cksum() function, which delegates >> the actual work to __rte_raw_cksum(), which in turn is used

RE: [PATCH] doc: add deprecation for restrictions in telemetry naming

2022-07-11 Thread Power, Ciara
> -Original Message- > From: Richardson, Bruce > Sent: Thursday 7 July 2022 14:40 > To: dev@dpdk.org > Cc: Richardson, Bruce ; > m...@smartsharesystems.com; step...@networkplumber.org; Power, Ciara > > Subject: [PATCH] doc: add deprecation for restrictions in telemetry naming > > Foll

Re: [PATCH] doc: add deprecation for restrictions in telemetry naming

2022-07-11 Thread David Marchand
On Thu, Jul 7, 2022 at 3:39 PM Bruce Richardson wrote: > > Following discussion on-list [1], we will look to limited the allowed > characters in names for items in telemetry. This will simplify the > escaping needed for json output, or any future output formats. The lists > will initially be minim

Re: [PATCH] doc: add IP ECN header rewrite to mlx5 notes

2022-07-11 Thread David Marchand
On Mon, Jul 11, 2022 at 11:59 AM Jiawei Wang wrote: > > This patch updates the mlx5 notes for IPv4/IPv6 ECN field > rewrite offload. > > Fixes: c4e442fa4c45 ("ethdev: add IPv4/IPv6 ECN header rewrite action") > Fixes: 097d84a42a87 ("common/mlx5: check ECN modification capability") > Fixes: 76d5756

Re: [PATCH v2 2/2] net: have checksum routines accept unaligned data

2022-07-11 Thread Mattias Rönnblom
On 2022-07-11 11:53, Olivier Matz wrote: > Hi, > > On Fri, Jul 08, 2022 at 02:56:08PM +0200, Mattias Rönnblom wrote: >> __rte_raw_cksum() (used by rte_raw_cksum() among others) accessed its >> data through an uint16_t pointer, which allowed the compiler to assume >> the data was 16-bit aligned. Th

Re: [PATCH] doc: add deprecation for restrictions in telemetry naming

2022-07-11 Thread Bruce Richardson
On Fri, Jul 08, 2022 at 12:06:31AM +0200, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Thursday, 7 July 2022 15.40 > > > > Following discussion on-list [1], we will look to limited the allowed > > characters in names for items in telemetry. This wil

[PATCH v2 1/2] test/service: add perf measurements for with stats mode

2022-07-11 Thread Harry van Haaren
This commit improves the performance reporting of the service cores polling loop to show both with and without statistics collection modes. Collecting cycle statistics is costly, due to calls to rte_rdtsc() per service iteration. Reported-by: Mattias Rönnblom Suggested-by: Honnappa Nagarahalli S

[PATCH v2 2/2] service: fix potential stats race-condition on MT services

2022-07-11 Thread Harry van Haaren
This commit fixes a potential racey-add that could occur if multiple service-lcores were executing the same MT-safe service at the same time, with service statistics collection enabled. Because multiple threads can run and execute the service, the stats values can have multiple writer threads, res

Re: [PATCH v2 1/2] app/test: add cksum performance test

2022-07-11 Thread Olivier Matz
On Mon, Jul 11, 2022 at 10:42:37AM +, Mattias Rönnblom wrote: > On 2022-07-11 11:47, Olivier Matz wrote: > > Hi Mattias, > > > > Please see few comments below. > > > > On Fri, Jul 08, 2022 at 02:56:07PM +0200, Mattias Rönnblom wrote: > >> Add performance test for the rte_raw_cksum() function,

RE: [PATCH] doc: add deprecation for restrictions in telemetry naming

2022-07-11 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Monday, 11 July 2022 12.54 > > On Fri, Jul 08, 2022 at 12:06:31AM +0200, Morten Brørup wrote: > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > Sent: Thursday, 7 July 2022 15.40 > > > > > > Following discussi

Re: [dpdk-dev] [PATCH v2 0/7] Removal of PCI bus ABIs

2022-07-11 Thread Thomas Monjalon
9 months have passed. Do you have any news from SPDK side? 14/10/2021 08:41, Thomas Monjalon: > 14/10/2021 00:48, Walker, Benjamin: > > > From: Thomas Monjalon > > > > > Yes I think we need to agree on functions to keep as-is for compatibility. > > > Waiting for your input please. > > > > We'

[PATCH v3 2/2] net: have checksum routines accept unaligned data

2022-07-11 Thread Mattias Rönnblom
__rte_raw_cksum() (used by rte_raw_cksum() among others) accessed its data through an uint16_t pointer, which allowed the compiler to assume the data was 16-bit aligned. This in turn would, with certain architectures and compiler flag combinations, result in code with SIMD load or store instruction

[PATCH v3 1/2] app/test: add cksum performance test

2022-07-11 Thread Mattias Rönnblom
Add performance test for the rte_raw_cksum() function, which delegates the actual work to __rte_raw_cksum(), which in turn is used by other functions in need of Internet checksum calculation. Signed-off-by: Mattias Rönnblom --- v3: * Changed init function buffer parameter type, to avoid cast.

Re: [PATCH] doc: announce marking device and driver objects as internal

2022-07-11 Thread Thomas Monjalon
11/07/2022 04:16, Xia, Chenbo: > From: David Marchand > > rte_driver and rte_device are unnecessarily exposed in the public API/ABI. > > Announce that they will be made opaque in the public API and mark > > associated API as internal. > > This impacts all bus, as their driver registration mechanis

Re: [PATCH] event/dsw: fix migration bug

2022-07-11 Thread Jerin Jacob
On Thu, Jul 7, 2022 at 5:13 PM Mattias Rönnblom wrote: > > From: Mattias Rönnblom > > Fix bug in flow migration, which under certain conditions causes > reordering and violation of atomicity guarantees. > > The issue occurs when the processing of a flow (on an atomic queue) > has resulted in even

Re: [PATCH v3 1/4] doc/howto: rework section on virtio-user as exception path

2022-07-11 Thread Thomas Monjalon
10/06/2022 17:35, Bruce Richardson: > This patch extensively reworks the howto guide on using virtio-user for > exception packets. Changes include: > > * rename "exceptional path" to "exception path" > * remove references to uio and just reference vfio-pci > * simplify testpmd command-lines, givin

Re: [PATCH v3 1/4] doc/howto: rework section on virtio-user as exception path

2022-07-11 Thread Bruce Richardson
On Mon, Jul 11, 2022 at 03:10:56PM +0200, Thomas Monjalon wrote: > 10/06/2022 17:35, Bruce Richardson: > > This patch extensively reworks the howto guide on using virtio-user for > > exception packets. Changes include: > > > > * rename "exceptional path" to "exception path" > > * remove references

[PATCH v3 1/2] test/service: add perf measurements for with stats mode

2022-07-11 Thread Harry van Haaren
This commit improves the performance reporting of the service cores polling loop to show both with and without statistics collection modes. Collecting cycle statistics is costly, due to calls to rte_rdtsc() per service iteration. Reported-by: Mattias Rönnblom Suggested-by: Honnappa Nagarahalli S

[PATCH v3 2/2] service: fix potential stats race-condition on MT services

2022-07-11 Thread Harry van Haaren
This commit fixes a potential racey-add that could occur if multiple service-lcores were executing the same MT-safe service at the same time, with service statistics collection enabled. Because multiple threads can run and execute the service, the stats values can have multiple writer threads, res

Re: [PATCH v3 1/2] app/test: add cksum performance test

2022-07-11 Thread Olivier Matz
On Mon, Jul 11, 2022 at 02:11:31PM +0200, Mattias Rönnblom wrote: > Add performance test for the rte_raw_cksum() function, which delegates > the actual work to __rte_raw_cksum(), which in turn is used by other > functions in need of Internet checksum calculation. > > Signed-off-by: Mattias Rönnblo

Re: [PATCH v3 2/2] net: have checksum routines accept unaligned data

2022-07-11 Thread Olivier Matz
On Mon, Jul 11, 2022 at 02:11:32PM +0200, Mattias Rönnblom wrote: > __rte_raw_cksum() (used by rte_raw_cksum() among others) accessed its > data through an uint16_t pointer, which allowed the compiler to assume > the data was 16-bit aligned. This in turn would, with certain > architectures and comp

Re: [dpdk-dev] [PATCH v2] doc: propose correction rte_{bsf, fls} inline functions type use

2022-07-11 Thread Jerin Jacob
On Thu, Nov 11, 2021 at 6:11 PM Morten Brørup wrote: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Thursday, 11 November 2021 12.55 > > > > 11/11/2021 05:15, Tyler Retzlaff: > > > On Tue, Oct 26, 2021 at 09:45:20AM +0200, Morten Brørup wrote: > > > > > From: dev [mailto:dev-b

Re: [PATCH v3 2/2] doc: announce KNI deprecation

2022-07-11 Thread Jerin Jacob
On Wed, Nov 24, 2021 at 10:48 PM Ferruh Yigit wrote: > > Announce the KNI kernel module move to out of dpdk repo and announce > long term plan to deprecate the KNI. > > Signed-off-by: Ferruh Yigit Acked-by: Jerin Jacob > --- > Cc: Olivier Matz Olivier Matz > Cc: David Marchand David Marchand

Re: [PATCH] doc: announce name change of stop flush callback

2022-07-11 Thread Jerin Jacob
On Fri, Jun 24, 2022 at 2:40 PM wrote: > > From: Pavan Nikhilesh > > Stop flush callback is missing `rte_` prefix and might conflict with > application declarations. > > Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob + @Gage Eads > --- > doc/guides/rel_notes/deprecation.rst | 3 +++ >

[PATCH v2 1/8] dts: add basic logging facility

2022-07-11 Thread Juraj Linkeš
The logging module provides loggers distinguished by two attributes, a custom format and a verbosity switch. The loggers log to both console and more verbosely to files. Signed-off-by: Juraj Linkeš --- dts/framework/logger.py | 118 1 file changed, 118 in

[PATCH v2 0/8] ssh connection to a node

2022-07-11 Thread Juraj Linkeš
All the necessary code needed to connect to a node in a topology with some extras, such as basic logging, per-node locks and some extra useful methods. To run the code, modify the config file, conf.yaml and execute ./main.py from the root dts folder. Here's an example config: executions: - syste

[PATCH v2 2/8] dts: add ssh pexpect library

2022-07-11 Thread Juraj Linkeš
The library uses the pexpect python library and implements connection to a node and two ways to interact with the node: 1. Send a string with specified prompt which will be matched after the string has been sent to the node. 2. Send a command to be executed. No prompt is specified here. Signed-

[PATCH v2 3/8] dts: add locks for parallel node connections

2022-07-11 Thread Juraj Linkeš
Each lock is held per node. The lock assures that multiple connections to the same node don't execute anything at the same time, removing the possibility of race conditions. Signed-off-by: Juraj Linkeš --- dts/framework/ssh_pexpect.py | 14 -- dts/framework/utils.py | 88 ++

[PATCH v2 4/8] dts: add ssh connection extension

2022-07-11 Thread Juraj Linkeš
The class adds logging and history records to existing pexpect methods. Signed-off-by: Juraj Linkeš --- dts/framework/ssh_connection.py | 70 + 1 file changed, 70 insertions(+) create mode 100644 dts/framework/ssh_connection.py diff --git a/dts/framework/ssh_con

[PATCH v2 5/8] dts: add config parser module

2022-07-11 Thread Juraj Linkeš
From: Owen Hilyard The configuration is split into two parts, one defining the parameters of the test run and the other defining the topology to be used. The format of the configuration is YAML. It is validated according to a json schema which also servers as detailed documentation of the variou

[PATCH v2 6/8] dts: add Node base class

2022-07-11 Thread Juraj Linkeš
The base class implements basic node management methods - connect and execute commands. Signed-off-by: Juraj Linkeš --- dts/framework/node.py | 108 ++ dts/framework/settings.py | 3 ++ 2 files changed, 111 insertions(+) create mode 100644 dts/framework

[PATCH v2 7/8] dts: add dts workflow module

2022-07-11 Thread Juraj Linkeš
The module implements methods needed to run DTS. It handles the creation of objects and eventually the whole DTS workflow, such as running node setups, test gathering, setup and execution and various cleanups. Signed-off-by: Juraj Linkeš --- dts/framework/dts.py | 76 ++

[PATCH v2 8/8] dts: add dts executable script

2022-07-11 Thread Juraj Linkeš
The script is an interface to run DTS with standard argument parser. Signed-off-by: Juraj Linkeš --- dts/main.py | 47 +++ 1 file changed, 47 insertions(+) create mode 100755 dts/main.py diff --git a/dts/main.py b/dts/main.py new file mode 100755 ind

Re: [PATCH] doc: announce change in event vector structure

2022-07-11 Thread Jerin Jacob
On Fri, Jun 24, 2022 at 2:42 PM wrote: > > From: Pavan Nikhilesh > > The field `*u64s` in the structure `rte_event_vector` will > be replaced with `u64s`. > > Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob > --- > doc/guides/rel_notes/deprecation.rst | 3 +++ > 1 file changed, 3 inse

Re: [PATCH] doc: announce change to cryptodev cb function prototype

2022-07-11 Thread Jerin Jacob
On Wed, Jul 6, 2022 at 2:41 PM Zhang, Roy Fan wrote: > > > -Original Message- > > From: Srujana Challa > > Sent: Friday, June 24, 2022 2:45 PM > > To: gak...@marvell.com; Zhang, Roy Fan > > Cc: dev@dpdk.org; jer...@marvell.com; ndabilpu...@marvell.com; > > ano...@marvell.com > > Subject:

Re: [PATCH v2 1/1] doc: announce addition of new ipsec event subtypes

2022-07-11 Thread Jerin Jacob
On Wed, Jul 6, 2022 at 3:19 PM Zhang, Roy Fan wrote: > > > -Original Message- > > From: Vamsi Attunuru > > Sent: Monday, June 27, 2022 6:30 AM > > To: dev@dpdk.org > > Cc: jer...@marvell.com; vattun...@marvell.com; gak...@marvell.com; > > ferruh.yi...@intel.com; tho...@monjalon.net; ano..

Re: [PATCH 1/2] doc: add enqueue depth for new event type

2022-07-11 Thread Jerin Jacob
On Mon, Jun 27, 2022 at 3:29 PM wrote: > > From: Pavan Nikhilesh > > A new field ``max_event_port_enqueue_new_burst`` will be added to the > structure ``rte_event_dev_info``. The field defines the max enqueue > burst size of new events (OP_NEW) supported by the underlying event > device. > > Sign

Re: [PATCH] doc: add event timer expiry drop stat

2022-07-11 Thread Jerin Jacob
On Fri, Jul 1, 2022 at 12:43 AM Carrillo, Erik G wrote: > > > -Original Message- > > From: Naga Harish K, S V > > Sent: Monday, June 27, 2022 10:40 AM > > To: m...@ashroe.eu; jer...@marvell.com; pbhagavat...@marvell.com; > > sthot...@marvell.com; Carrillo, Erik G > > Cc: dev@dpdk.org > >

Re: [PATCH] doc: announce changes to event vector structure

2022-07-11 Thread Jerin Jacob
On Tue, Jun 28, 2022 at 5:01 PM wrote: > > From: Pavan Nikhilesh > > The structure ``rte_event_vector`` will be modified to include > ``elem_offset:12`` bits taken from ``rsvd:15``. > The ``elem_offset`` defines the offset into the vector array from > which valid elements are present. > > Signed-

Re: [PATCH] doc: announce change in crypto adapter queue add

2022-07-11 Thread Jerin Jacob
On Tue, Jun 28, 2022 at 6:12 PM Akhil Goyal wrote: > > > Subject: [PATCH] doc: announce change in crypto adapter queue add > > > > The function `rte_event_crypto_adapter_queue_pair_add` will accept > > `rte_event_crypto_adapter_queue_conf` argument instead of `rte_event`. > > > > Signed-off-by: Vo

Re: [PATCH] doc: announce support for MACsec in rte_security

2022-07-11 Thread Jerin Jacob
On Wed, Jun 29, 2022 at 1:10 PM Zhang, Roy Fan wrote: > > > -Original Message- > > From: Akhil Goyal > > Sent: Tuesday, June 28, 2022 8:08 PM > > To: dev@dpdk.org > > Cc: tho...@monjalon.net; david.march...@redhat.com; > > hemant.agra...@nxp.com; ano...@marvell.com; > > konstantin.v.anan.

Re: [PATCH] doc: announce marking device and driver objects as internal

2022-07-11 Thread Jerin Jacob
On Sun, Jul 10, 2022 at 11:48 AM David Marchand wrote: > > rte_driver and rte_device are unnecessarily exposed in the public API/ABI. > Announce that they will be made opaque in the public API and mark > associated API as internal. > This impacts all bus, as their driver registration mechanism wil

Re: [PATCH] doc: announce rename of octeontx_ep driver

2022-07-11 Thread Jerin Jacob
On Fri, Jul 1, 2022 at 1:40 PM Veerasenareddy Burru wrote: > > To enable single unified driver to support current OcteonTx and > future Octeon PCI endpoint NICs, octeontx_ep driver is renamed to > octeon_ep to reflect common driver for all Octeon based > PCI endpoint NICs. > > Signed-off-by: Veera

Re: [PATCH v2] net/iavf: fix gtpu extension flow error

2022-07-11 Thread Thomas Monjalon
07/07/2022 09:13, Zhang, Qi Z: > From: Yang, Qiming > > From: Wu, WenxuanX > > > From: Wenxuan Wu > > > > > > Due to the change of struct rte_gtp_psc_generic_hdr, kernel driver can > > > not handle gtp_psc properly, we introduce a new structure to fix this > > > gap between kernel driver and str

[PATCH v1 0/4] add uncore api to be called through l3fwd-power

2022-07-11 Thread tadhgkearney
This is targeting 22.11 and aims to add an API to DPDK to allow uncore frequency adjustment. This will be called through the l3fwd-power app, and gives the ability to set the min, max and specific frequency index that you want the uncore to be at. tadhgkearney (4): power: add uncore api to pow

[PATCH v1 1/4] power: add uncore api to power library

2022-07-11 Thread tadhgkearney
Add api to allow uncore frequency adjustment. This is done through manipulating related sysfs entries to adjust the min/max uncore values. Seven api's are being added that are all public and experimental. Power man docs updated to reflect this. Signed-off-by: tadhgkearney --- doc/guides/prog_g

[PATCH v1 2/4] l3fwd-power: add option to call uncore api

2022-07-11 Thread tadhgkearney
Add option for setting uncore frequency min/max/index, through uncore api. This will be set for each package and die on the SKU. On exit, uncore frequency will be reverted back to previous frequency. Signed-off-by: tadhgkearney --- .../sample_app_ug/l3_forward_power_man.rst| 28 examp

[PATCH v1 3/4] test/power: add unit tests for uncore api

2022-07-11 Thread tadhgkearney
Add basic unit tests covering all seven uncore api's. Signed-off-by: tadhgkearney --- app/test/meson.build | 2 + app/test/test_power_uncore.c | 245 +++ 2 files changed, 247 insertions(+) create mode 100644 app/test/test_power_uncore.c diff --git a/ap

[PATCH v1 4/4] config: add uncore defines for x86

2022-07-11 Thread tadhgkearney
Add global define for max numa die and max uncore freqs. Signed-off-by: tadhgkearney --- config/x86/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/config/x86/meson.build b/config/x86/meson.build index 54345c4da3..f81103d8e3 100644 --- a/config/x86/meson.build +++ b/config/x86/

Re: [PATCH v1 1/4] power: add uncore api to power library

2022-07-11 Thread Stephen Hemminger
On Mon, 11 Jul 2022 16:22:57 + tadhgkearney wrote: > +FILE *f_cur_min; /**< FD of scaling_min */ > +FILE *f_cur_max; /**< FD of scaling_max */ > +FILE *f_base_min;/**< FD of initial min */ > +FILE *f_base_max;

Re: [PATCH v4] net/i40e: restore disable double VLAN by default

2022-07-11 Thread Thomas Monjalon
07/07/2022 19:04, Kevin Liu: > +Vlan related Features miss when FW >= 8.4 > +~ > + > +If FW version >= 8.4, there'll be some Vlan related issues: > +1. TCI input set for QinQ is invalid. > +2. Fail to configure TPID for QinQ. > +3. Need to enable QinQ before

RE: [PATCH v1 0/4] add uncore api to be called through l3fwd-power

2022-07-11 Thread Pattan, Reshma
> -Original Message- > From: Kearney, Tadhg > Sent: Monday, July 11, 2022 5:23 PM > To: dev@dpdk.org > Cc: dave.h...@intel.com; Burakov, Anatoly ; > Pattan, Reshma ; Kearney, Tadhg > > Subject: [PATCH v1 0/4] add uncore api to be called through l3fwd-power > The below patch should b

[dpdk-dev v1] crypto/openssl: fix of dstlen passed in HMAC

2022-07-11 Thread Kai Ji
This fix of dstlen passed in OpenSSL 3.0 lib EVP MAC final routine. Fixes: 75adf1eae44f ("crypto/openssl: update HMAC routine with 3.0 EVP API") Signed-off-by: Kai Ji --- drivers/crypto/openssl/rte_openssl_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/

[dpdk-dev v1] crypto/qat: Enable OpenSSL legacy provider in session

2022-07-11 Thread Kai Ji
Some cryptographic algorithms such as MD and DES are now considered legacy and not enabled by default in OpenSSL 3.0. Load up lagacy provider as MD5 DES are needed in QAT session pre-computes and secure session creation. Fixes: 3227bc7138f5 ("crypto/qat: use intel-ipsec-mb for partial hash and AES

Re: [PATCH] doc: add IP ECN header rewrite to mlx5 notes

2022-07-11 Thread Thomas Monjalon
11/07/2022 12:49, David Marchand: > On Mon, Jul 11, 2022 at 11:59 AM Jiawei Wang wrote: > > > > This patch updates the mlx5 notes for IPv4/IPv6 ECN field > > rewrite offload. > > > > Fixes: c4e442fa4c45 ("ethdev: add IPv4/IPv6 ECN header rewrite action") > > Fixes: 097d84a42a87 ("common/mlx5: chec

[Bug 1051] l2fwd-event: signal unsafe usage

2022-07-11 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1051 Bug ID: 1051 Summary: l2fwd-event: signal unsafe usage Product: DPDK Version: 21.11 Hardware: All OS: All Status: UNCONFIRMED Severity: minor Priority:

Re: [PATCH] config: set pkgconfig for ppc64le

2022-07-11 Thread Thomas Monjalon
+ PPC maintainer 07/07/2022 13:41, Ali Alnubani: > Meson fails to detect the dependencies that are included > in PKG_CONFIG_PATH and built for ppc64le if binaries.pkgconfig > is not set in the ppc64le cross-file for Ubuntu. > > This fixes the issue by setting binaries.pkgconfig to the > binary pr

Re: [PATCH v2 0/2] DLB2: cq_weight fixes

2022-07-11 Thread Thomas Monjalon
08/07/2022 17:02, McDaniel, Timothy: > From: Thomas Monjalon > > 06/07/2022 23:46, Timothy McDaniel: > > > This patch series contains the following: > > > - fix coverity issue 379234 > > > - improve error reporting for cq_weight feature > > > > > > Changes since V1 > > > - fixed a repeated word in

RE: [PATCH v2 0/2] DLB2: cq_weight fixes

2022-07-11 Thread McDaniel, Timothy
> -Original Message- > From: Thomas Monjalon > Sent: Monday, July 11, 2022 3:31 PM > To: McDaniel, Timothy > Cc: sta...@dpdk.org; dev@dpdk.org; jer...@marvell.com; > jerinjac...@gmail.com; sta...@dpdk.org > Subject: Re: [PATCH v2 0/2] DLB2: cq_weight fixes > > 08/07/2022 17:02, McDani

Re: [PATCH] event/dsw: fix migration bug

2022-07-11 Thread Thomas Monjalon
11/07/2022 14:45, Jerin Jacob: > On Thu, Jul 7, 2022 at 5:13 PM Mattias Rönnblom wrote: > > > > From: Mattias Rönnblom > > > > Fix bug in flow migration, which under certain conditions causes > > reordering and violation of atomicity guarantees. > > > > The issue occurs when the processing of a f

Re: [PATCH v3] doc: update Linux core isolation guide

2022-07-11 Thread Thomas Monjalon
I appreciate you work on the doc. Please take extra care of the rendering, thanks. 17/05/2022 21:59, pbhagavat...@marvell.com: > From: Pavan Nikhilesh > > Update Linux core isolation guide to include isolation from > timers, rcu processing and IRQs. > > Signed-off-by: Pavan Nikhilesh > --- [.

Re: [dpdk-dev v1] doc/multi-process: fixed grammar and rephrasing

2022-07-11 Thread Thomas Monjalon
Anyone to review? Please could you go a step further and remove one useless header level, fix links, enclose code with double backticks and other basic stuff? Thanks 01/06/2022 11:57, Kai Ji: > Update and rephrasing some sentences, small improvements > made to the multi-process sample applicatio

Re: [PATCH 1/1] doc: expand description of no-huge and PMD issue

2022-07-11 Thread Thomas Monjalon
13/06/2022 11:31, David Marchand: > On Thu, Jun 9, 2022 at 3:40 PM Stanislaw Kardach wrote: > > > > Add more details to the description of a known issue of PMDs not being > > usable when --no-huge EAL command line parameter is used. The issue > > actually happens whenever there is a need for physi

Re: [PATCH v2] doc/eal: add signal safety warning

2022-07-11 Thread Thomas Monjalon
05/07/2022 22:44, Stephen Hemminger: > The DPDK is not designed to be used from a signal handler. > Add a notice in the documentation describing this limitation, > similar to Linux signal-safety manual page. > > Bugzilla ID: 1030 > Signed-off-by: Stephen Hemminger > Acked-by: Tyler Retzlaff > Ac

Re: [PATCH v1] docs: update l3fwd sample app docs

2022-07-11 Thread Thomas Monjalon
That's sad to see such patch is not reviewed. 03/06/2022 13:11, Sean Morrissey: > The L3FWD sample app doc contains outdated static code > snippets and references to functions which no longer > exist. This patch updates this doc to use up to date > references. > > Signed-off-by: Sean Morrissey

Re: [PATCH v2] doc/eal: add signal safety warning

2022-07-11 Thread Stephen Hemminger
On Mon, 11 Jul 2022 23:15:26 +0200 Thomas Monjalon wrote: > 05/07/2022 22:44, Stephen Hemminger: > > The DPDK is not designed to be used from a signal handler. > > Add a notice in the documentation describing this limitation, > > similar to Linux signal-safety manual page. > > > > Bugzilla ID: 1

Re: [PATCH] doc: update doc for NVIDIA devices

2022-07-11 Thread Thomas Monjalon
07/07/2022 16:26, Raslan Darawsheh: > This updates the doc to include new supported devices like ConnectX7, > and updates the description of older ones. > > Signed-off-by: Raslan Darawsheh Completed with an all-in move to NVIDIA trademark, and applied, thanks. Signed-off-by: Thomas Monjalon

Re: [PATCH] doc: add tested platforms with NVIDIA NICs

2022-07-11 Thread Thomas Monjalon
07/07/2022 15:46, Raslan Darawsheh: > Add tested platforms with NVIDIA NICs to the 22.07 release notes. > > Signed-off-by: Raslan Darawsheh Renamed all devices to NVIDIA and applied, thanks.

Re: [PATCH V1] doc: add tested Intel platforms with Intel NICs

2022-07-11 Thread Thomas Monjalon
08/07/2022 11:16, Lingli Chen: > Add tested Intel platforms with Intel NICs to v22.07 release note. > > Signed-off-by: Lingli Chen > --- > index b40d6f9d84..abb787afc6 100644 > --- a/doc/guides/rel_notes/release_22_07.rst > +++ b/doc/guides/rel_notes/release_22_07.rst > @@ -356,3 +356,107 @@ Test

release candidate 22.07-rc4

2022-07-11 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v22.07-rc4 There are 22 new patches in this snapshot. Release notes: https://doc.dpdk.org/guides/rel_notes/release_22_07.html This is the last release candidate. Only documentation should be upda

[PATCH v3] doc/eal: add signal safety warning

2022-07-11 Thread Stephen Hemminger
The DPDK is not designed to be used from a signal handler. Add a notice in the documentation describing this limitation, similar to Linux signal-safety manual page. Bugzilla ID: 1030 Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Chengwen Feng --- doc/guides/prog_guide/env

[PATCH v4] doc/eal: add signal safety warning

2022-07-11 Thread Stephen Hemminger
The DPDK is not designed to be used from a signal handler. Add a notice in the documentation describing this limitation, similar to Linux signal-safety manual page. Bugzilla ID: 1030 Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Chengwen Feng --- v4 - add more functions an

Re: [PATCH] doc: announce marking device and driver objects as internal

2022-07-11 Thread Hemant Agrawal
On 7/10/2022 11:47 AM, David Marchand wrote: rte_driver and rte_device are unnecessarily exposed in the public API/ABI. Announce that they will be made opaque in the public API and mark associated API as internal. This impacts all bus, as their driver registration mechanism will be made interna

RE: [PATCH] common/sfc_efx/base: remove VQ index check during VQ start

2022-07-11 Thread Saini, Abhimanyu
[AMD Official Use Only - General] On 7/8/22 10:37, abhimanyu.sa...@xilinx.com wrote: > > From: Abhimanyu Saini > > > > The used/avail queue indexes are not bound by queue > > size, because the descriptor entry index is calculated > > by a simple modulo between queue index and queue_size > > "is

RE: [EXT] Re: [PATCH] doc: announce change in crypto adapter queue add

2022-07-11 Thread Akhil Goyal
> On Tue, Jun 28, 2022 at 6:12 PM Akhil Goyal wrote: > > > > > Subject: [PATCH] doc: announce change in crypto adapter queue add > > > > > > The function `rte_event_crypto_adapter_queue_pair_add` will accept > > > `rte_event_crypto_adapter_queue_conf` argument instead of `rte_event`. > > > > > > S

DPDK 19.11.3 with multi processes and external physical memory: unable to receive traffic in the secondary processes

2022-07-11 Thread Asaf Sinai
Hi, We run DPDK 19.11.3 with multi processes. When using external memory for DPDK (instead of huge pages), we are unable to receive traffic in the secondary processes. * We have external physical memory regions (excluded from Linux): [ULP-NG]# cat /proc/cmdline console=ttyS0,19200 isolcpus