RE: [PATCH] mbuf: add mbuf physical address field to dynamic field

2022-07-03 Thread Morten Brørup
> From: Shijith Thotton [mailto:sthot...@marvell.com] > Sent: Friday, 1 July 2022 14.25 > > >> If all devices are configured to run in IOVA mode as VA, physical > >> address field of mbuf (buf_iova) won't be used. Will some of the hardware vendors please comment on this: Has IOVA VA mode become

RE: [PATCH 01/17] net/mana: add basic driver, build environment and doc

2022-07-03 Thread Long Li
> Subject: Re: [PATCH 01/17] net/mana: add basic driver, build environment and > doc > > On Fri, 1 Jul 2022 02:02:31 -0700 > lon...@linuxonhyperv.com wrote: > > > + uint64_t max_mr_size; > > + rte_rwlock_tmr_list_lock; > > +}; > > Reader/Writer locks are slower for the usual uncontended

[PATCH] net/mlx5: reject negative integrity item configuration

2022-07-03 Thread Gregory Etelson
Negative integrity item refers to condition when the item value mask is set, but value spec is cleared: ... integrity value mask l4_ok value spec 0 ... RTE library defines integrity bits `l3_ok` and `l4_ok` as accumulators for all hardware L3 and L4 integrity verifications respectfully. Hardwa

[PATCH v2] net/mlx5: reject negative integrity item configuration

2022-07-03 Thread Gregory Etelson
Negative integrity item refers to condition when the item value mask is set, but value spec is cleared: ... integrity value mask l4_ok value spec 0 ... RTE library defines integrity bits `l3_ok` and `l4_ok` as accumulators for all hardware L3 and L4 integrity verifications respectfully. Hardwa

RE: [PATCH] vdpa/mlx5: fix leak on event thread creation

2022-07-03 Thread Matan Azrad
From: David Marchand > As stated in the manual, pthread_attr_init return value should be checked. > Besides, a pthread_attr_t should be destroyed once unused. > > In practice, we may have no leak (from what I read in glibc current code), but > this may change in the future. > Stick to a correct

Re: [RFC PATCH v1] net/i40e: put mempool cache out of API

2022-07-03 Thread Konstantin Ananyev
Refer to "i40e_tx_free_bufs_avx512", this patch puts mempool cache out of API to free buffers directly. There are two changes different with previous version: 1. change txep from "i40e_entry" to "i40e_vec_entry" 2. put cache out of "mempool_bulk" API to copy buffers into it directly Performanc

[PATCH v2 0/3] Fix IDXD PCI device close

2022-07-03 Thread Kevin Laatz
This patchset addresses the device close for IDXD PCI devices. Initially, there was a memory leak reported by ASAN for the 'pci' member of the 'idxd_dmadev' struct due to a missing free. In addition, this patch set corrects the behaviour of the device close function to ensure the cleanup is complet

[PATCH v2 1/3] dma/idxd: fix memory leak in pci close

2022-07-03 Thread Kevin Laatz
ASAN reports a memory leak for the 'pci' pointer in the 'idxd_dmadev' struct. This is fixed by free'ing the struct when the last queue on the PCI device is being closed. Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe") Cc: sta...@dpdk.org Cc: bruce.richard...@intel.com Repo

[PATCH v2 2/3] dma/idxd: fix memory leak due to free on incorrect pointer

2022-07-03 Thread Kevin Laatz
During PCI device close, any allocated memory needs to be free'd. Currently, one of the free's is being called on an incorrect idxd_dmadev struct member, namely 'batch_idx_ring', causing a memleak from the pointer that should have been free'd. This patch fixes this memleak by calling free on the co

[PATCH v2 3/3] dma/idxd: fix null pointer dereference during pci remove

2022-07-03 Thread Kevin Laatz
The 'info' struct was being declared as a NULL pointer. If a NULL pointer is passed to 'rte_dma_info_get', EINVAL is returned and the struct is not populated. This subsequently causes a segfault when dereferencing 'info'. This patch fixes the issue by simply declaring 'info' as a variable and pass

Re: Optimizations are not features

2022-07-03 Thread Konstantin Ananyev
29/06/2022 21:44, Honnappa Nagarahalli пишет: 04/06/2022 13:51, Andrew Rybchenko пишет: On 6/4/22 15:19, Morten Brørup wrote: From: Jerin Jacob [mailto:jerinjac...@gmail.com] Sent: Saturday, 4 June 2022 13.10 On Sat, Jun 4, 2022 at 3:30 PM Andrew Rybchenko wrote: On 6/4/22 12:33, Jerin

Re: [PATCH v3 1/2] examples/l3fwd: common packet group functionality

2022-07-03 Thread Thomas Monjalon
23/06/2022 11:38, Rahul Bhansali: > This will make the packet grouping function common, so > that other examples can utilize as per need. > > For each architecture sse/neon/altivec, port group > headers will be created under examples/common/. > > Signed-off-by: Rahul Bhansali > --- > Changes in

RE: [PATCH] vdpa/ifc: fix vhost message size check issue

2022-07-03 Thread Pei, Andy
Hi Maxime, Thanks for your effort. > -Original Message- > From: Maxime Coquelin > Sent: Friday, July 1, 2022 9:55 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Xiao, QimaiX > Subject: Re: [PATCH] vdpa/ifc: fix vhost message size check issue > > > > On 6/21/22 15

RE: [PATCH] vhost: fix virtio blk vDPA live migration IO drop

2022-07-03 Thread Pei, Andy
HI Maxime, Thanks. > -Original Message- > From: Maxime Coquelin > Sent: Friday, July 1, 2022 9:55 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Xiao, QimaiX > Subject: Re: [PATCH] vhost: fix virtio blk vDPA live migration IO drop > > > > On 6/22/22 09:47, Andy P

Re: [PATCH] app/testpmd: fix secondary process cannot dump packet

2022-07-03 Thread Dmitry Kozlyuk
On Mon, Jul 4, 2022 at 5:37 AM lihuisong (C) wrote: > [...] > 在 2022/7/1 19:36, Zhang, Peng1X 写道: > [...] > > The reason why not use 'dev->data->rx_queue_state' is whether queue > state is start or stop in primary > > process depend on rx_conf->rx_deferred_start after start testpmd. And > after h